[Koha-bugs] [Bug 32942] Suggestion API doesn't support custom statuses

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942

--- Comment #23 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Oh and I see that ORDERED and AVAILABLE are missing from my @status_constants
no ?

 > git grep 'ASKED.*REJECTED' origin/master 
origin/master:Koha/Schema/Result/Suggestion.pm:suggestion status (ASKED,
CHECKED, ACCEPTED, REJECTED, ORDERED, AVAILABLE or a value from the
SUGGEST_STATUS authorised value category)
origin/master:Koha/Suggestion.pm:    my @status_constants = qw(ASKED CHECKED
ACCEPTED REJECTED);
origin/master:installer/data/mysql/kohastructure.sql:  `STATUS` varchar(10) NOT
NULL DEFAULT '' COMMENT 'suggestion status (ASKED, CHECKED, ACCEPTED, REJECTED,
ORDERED, AVAILABLE or a value from the SUGGEST_STATUS authorised value
category)',
origin/master:misc/cronjobs/archive_purchase_suggestions.pl:    push
@available_statuses, qw( ASKED ACCEPTED CHECKED REJECTED ORDERED AVAILABLE );
origin/master:misc/cronjobs/archive_purchase_suggestions.pl:It must be one of
the 6 default statuses (ASKED, ACCEPTED, CHECKED, REJECTED, ORDERED or
AVAILABLE), or one define in the SUGGEST_STATUS authorized value's category.
origin/master:suggestion/suggestion.pl:        unless ( grep {
/$criteriumvalue/ } qw(ASKED ACCEPTED REJECTED CHECKED ORDERED AVAILABLE) ) {

In fact @status_constants should be a constant in Koha::Suggestion, to be used
by other scripts, no ?
Like we currently have Koha::Serials::MISSING_STATUSES

-- 
You are receiving this mail because:
You are watching all bug changes.