[Koha-bugs] [Bug 34828] Add Koha::MetadataExtractor class

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
David and all, I'm happy to have the ball roll and have all your ideas. I'm not
attached to this particular code in any way.

I'm just generally not sure about the approach we have taken, and this is the
best I have come up with.

opac-detail.pl has calls to:

    GetNormalizedEAN
    GetNormalizedISBN
    GetNormalizedOCLCNumber
    GetNormalizedUPC
    GetMarcControlnumber
    GetMarcISBN
    GetMarcISSN
    GetMarcSeries
    GetMarcSubjects
    GetMarcUrls

About object orientation: I think I just didn't want to type long names for
each call (considering we might have mixes of schemas, even). I would agree my
code could just be passed a Koha::Biblio::Metadata object instead, which
*should* cache the calculated MARC::Record object in some way.

The ambivalence between Koha::Biblio and Koha::Biblio::Metadata has always
smelled. It become evident when we were developing the /biblios endpoint. And
the reason I filed bug 14645 8 years ago (LOL, just remembered).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.