[Koha-bugs] [Bug 34843] New: Koha/Database/Commenter.t is failing if the DB has been upgraded

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34843

            Bug ID: 34843
           Summary: Koha/Database/Commenter.t is failing if the DB has
                    been upgraded
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: m.de.rooy at rijksmuseum.nl
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 32334
            Blocks: 34841

To recreate:
root at kohadevbox:koha$ perl /kohadevbox/misc4dev/run_tests.pl
--run-db-upgrade-only

kohadev-koha at kohadevbox:koha$ prove t/db_dependent/Koha/Database/Commenter.t

t/db_dependent/Koha/Database/Commenter.t .. 
    #   Failed test 'No comment for toc_request'
    #   at t/db_dependent/Koha/Database/Commenter.t line 40.
    #          got: '0'
    #     expected: '1'

    #   Failed test 'Reset for one-columned article_requests'
    #   at t/db_dependent/Koha/Database/Commenter.t line 55.
    #                   'ALTER TABLE koha_kohadev.article_requests MODIFY
COLUMN `cancellation_reason` varchar(80) COLLATE utf8mb4_unicode_ci DEFAULT
NULL;
    # ALTER TABLE koha_kohadev.article_requests MODIFY COLUMN `debit_id`
int(11) DEFAULT NULL;
    # ALTER TABLE koha_kohadev.article_requests MODIFY COLUMN `toc_request`
tinyint(4) NOT NULL DEFAULT 0 COMMENT 'borrower requested table of contents';'
    #     doesn't match '(?^um:ALTER.*toc_request.*DEFAULT
0;(.*\n)+ALTER.*toc_request.*COMMENT.*$)'
    # Looks like you failed 2 tests of 9.
t/db_dependent/Koha/Database/Commenter.t .. 1/2 
#   Failed test '->new, dry_run'
#   at t/db_dependent/Koha/Database/Commenter.t line 58.
# Looks like you failed 1 test of 2.
t/db_dependent/Koha/Database/Commenter.t .. Dubious, test returned 1 (wstat
256, 0x100)
Failed 1/2 subtests


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334
[Bug 32334] Sync comments in database with schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34841
[Bug 34841] The test suite is failing is the DB has been upgraded
-- 
You are receiving this mail because:
You are watching all bug changes.