[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704

--- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Lucas Gass from comment #9)
> (In reply to Jonathan Druart from comment #6)
> > I don't think this is correct. You will still need to add br tags for non
> > HTML notice templates, or it will be on a single line :)
> 
> Isn't this only when the html flag is passed? 
> 
> if ( $html ) {

I have not tested the patch (what I should), but reading the diff it seems that
the following use case will be problematic:
Define a notice template that is not using HTML tags (so is_html=0)
Run the print_notices script with the --html flag
=> All will be one line

I guess that's why we had this replacement.

If you think I am wrong, please switch back to SO and I will have a look at it
again next week.

-- 
You are receiving this mail because:
You are watching all bug changes.