[Koha-bugs] [Bug 34153] Add ability to allow items with additional materials notes to be checked out via SIP

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34153

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Victor Grousset/tuxayo from comment #11)
> Lol perltidy puts tons of spaces to align $response with 'equals'.
> >    check_field(
> >        $respcode,          $response, FID_SCREEN_MSG, 'Item must be checked out at a circulation desk',
> >        'Check screen msg', 'equals'
> >    );

I agree it's an interesting choice, but we have a community .perltidyrc as of
bug 30002 and it's just doing what it's told to. If we don't like those results
we should probably have a followup to bug 30002. 

> Last point to settle is whether allow_additional_materials_checkout should
> be on by default. I don't have an educated enough opinion on this.

I did not add the option to the debian SIPconfig.xml template, so it is off by
default ( as it should be to retain current behavior ). The file
etc/SIPconfig.xml is just an example file to demonstrate all the possible
options in the SIP config, so it's fine to have it "enabled" there!

-- 
You are receiving this mail because:
You are watching all bug changes.