[Koha-bugs] [Bug 33478] Customise the format of notices when they are printed

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #82 from Nick Clemens <nick at bywatersolutions.com> ---
Must fix:
Applying this patch adds a default left justified, 14pt, 8.5 inches style to
all notices which overrides anything set in SlipCSS - this will break user slip
customizations - the new formatting must not override SlipCSS - especially if
it is adding new defaults. This patchset must not affect existing slips.
Ideally there would be nothing saved in the DB by default

Should fix:
Formatting applies to most things, however, some from print.css take precedence
- for a hold slip the <h5> doesn't respect the font size I entered - if I enter
a font size, I expect the entire notice to respect it - or we need more
granular settings here

Would fix:
As we are storing the form values and using it to generate CSS - we could
calculate that on save, and only need a single 'style' field for the slip -
this would allow for adding an advanced editor in the future to allow staff to
directly enter styles here. Not a blocker per se, but would add less fields and
allow future extension. Otherwise each style we want to provide will require a
new field

Question:
For a non-html notice - the formatting is odd.
Set OVERDUES_SLIP / Print / HTML Message unchecked
Set OVERDUES_SLIP / Format /Text justification: Right, Notice width: 4
Generate the overdue as per test plan
Notice is narrow, cuttoff at edge, and not justified
Should the style and wrapping div should only be added for html notices? i.e.
should the <pre> trags be outside of the div and style, or those dropped
entirely when notice is not html?

-- 
You are receiving this mail because:
You are watching all bug changes.