[Koha-bugs] [Bug 34911] New: Test suite no longer run test critic

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Sep 26 10:27:24 CEST 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34911

            Bug ID: 34911
           Summary: Test suite no longer run test critic
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: major
          Priority: P5 - low
         Component: Test Suite
          Assignee: jonathan.druart+koha at gmail.com
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 32352, 34303

Since bug 34303 the test suite (when ran on jenkins) is no longer testing
Perl::Critic

koha_1       | fatal: Not a valid object name master
koha_1       | [14:58:14] t/00-testcritic.t

check_makefile.t is also failing:
koha_1       | fatal: Not a valid object name master
koha_1       | [15:00:01] xt/check_makefile.t

We are not cloning the whole repo and "master" is not available. Additionally
we do not want to test master's files on stable branches anyway...


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352
[Bug 32352] xt/check_makefile.t failing on node_modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34303
[Bug 34303] t/00-testcritic.t should only test files part of git repo
-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list