[Koha-bugs] [Bug 31427] Automatic renewal errors should come before many other renewal errors

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427

--- Comment #16 from David Cook <dcook at prosentient.com.au> ---
(In reply to Martin Renvoize from comment #14)
> I think this all works as I would expect.. however I think we need a unit
> test to try and prevent future regression again in this complex and
> frequently flip-flopping piece of code.

(In reply to Martin Renvoize from comment #15)
> Sorry David.. if you find yourself struggling on unit tests I can try to
> find a moment.. I must admit, I've not looked at what already exists for
> these methods.

I was thinking the 4 existing unit tests that cover CanBookBeRenewed would be
enough, but I suppose there wasn't a unit test that revealed the problem, so
clearly there is at least 1 unit test missing...

This one is pretty low on my priority list, as I have a different (less
optimal) workaround for this problem that I've been using locally for many
years. 

I'll get to it eventually but if someone else wants to write that test first I
wouldn't complain hehe.

-- 
You are receiving this mail because:
You are watching all bug changes.