[Koha-bugs] [Bug 34881] Database update for bug 28854 isn't fully idempotent

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34881

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #4 from David Nind <david at davidnind.com> ---
Just checking on what is the best way to test this.

I tried these steps, but not sure if this is the best way:

1. Check the authorized values list for LOST and note that there is this value:
5 Missing from bundle

2. Run the database update (found this on another idempotent bug): perl -e 'use
C4::Installer; warn
Data::Dumper::Dumper(C4::Installer::run_db_rev("installer/data/mysql/db_revs/220600015.pl"));'

3. Note that for the LOST authorized value lists, the value is duplicated: 6
Missing from bundle

4. Reset everything: reset_all

5. Run the database update again (see step 2). This time I got this error when
running the update (at least the value isn't duplicated!): 

perl -e 'use C4::Installer; warn
Data::Dumper::Dumper(C4::Installer::run_db_rev("installer/data/mysql/db_revs/220600015.pl"));'
$VAR1 = {
          'error' => bless( {
                              'msg' => '{UNKNOWN}: DBI Exception:
DBD::mysql::db selectrow_array failed: You have an error in your SQL syntax;
check the manual that corresponds to your MariaDB server version for the right
syntax to use near \'\' at line 1 at /kohadevbox/koha/C4/Installer.pm line 741
'
                            }, 'DBIx::Class::Exception' ),
          'time' => '18:19:10',
          'exec_output' => 'Added new table \'item_bundles\'
',
          'bug_number' => '28854',
          'output' => [
                        'Upgrade to 22.06.00.015  [18:19:10]: Bug 28854 - Item
bundles support',
                        '       Added new table \'item_bundles\''
                      ],
          'description' => 'Item bundles support',
          'version' => '22.06.00.015',
          'filepath' => 'installer/data/mysql/db_revs/220600015.pl'

-- 
You are receiving this mail because:
You are watching all bug changes.