[Koha-bugs] [Bug 34188] Require library selection when logging in

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Sep 28 18:24:23 CEST 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34188

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Martin Renvoize from comment #8)
> Agreed on the serverside requirement.. we should really check the pref there
> too rather than do the standard auto-selection.

(In reply to Jonathan Druart from comment #7)
> 2. You are not enforcing the condition server-side, shouldn't we?

I think we did talk about this initially - your library won't be removed from
the list, so is still a valid selection. If you are going to far as to trick
the script to sign you in to your library, I think you have been forced to make
a selection :-)

We could add a check, but it would need to be in Auth.pm, and is a bigger
change that need more tests. I don't see this one so much as a security
feature, but a convenience feature to ensure libraries don't accidentally sign
in to the wrong branch

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list