[Koha-bugs] [Bug 34870] Unrecognized special characters when writing off an invoice with a note

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34870

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #156120|0                           |1
        is obsolete|                            |
 Attachment #156357|0                           |1
        is obsolete|                            |

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 156363
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156363&action=edit
Bug 34870: Perform UTF8 encoding before redirection

Display special characters correctly when writing off an invoice.

The issue arises because pay.pl does not perform UTF-8 encoding on the “notes”
parameter before redirecting the page. By using uri_escape_utf8, characters
with a code above 255 are also UTF-8 encoded. Then, paycollect.pl can collect
the information without any trouble.

This patch work with “;” and “:” characters.

TEST PLAN
1) Go to any patron profile > Accounting
2) Click “Create manual invoice”
3) Fill the fields and click the “Save” button
4) Repeat steps 2 and 3
5) Click “Make a payment”
6) Add a note with special characters for each one (e.g., éçö)
7) Select the created invoices and click the “Write off selected” button
8) In the note field, you should see “�” symbols where the special characters
are supposed to be
9) Click the “Cancel” button
10) Now add a note with “:;” for one of the invoices
11) Select the invoices and click the “Write off selected” button
12) You should see a page with an error 500
13) Go back to the “Make a payment” page
14) Apply the patch
15) Add a note with special characters for each one (e.g., éçö)
16) Add “:;” to one of the note fields
17) Select the invoices and click the “Write off selected” button
18) Now the special characters are displayed correctly

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
[EDIT] Added parentheses around construct for clarity.

-- 
You are receiving this mail because:
You are watching all bug changes.