[Koha-bugs] [Bug 28657] Expand branches.branchip to allow for multiple space separated ip ranges

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28657

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Thanks for your patch, Michael. It still needs a bit of attention:

   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 446,
now: 447)

+    $dbh->do( "ALTER TABLE `branches` MODIFY `branchip` mediumtext COLLATE
utf8mb4_unicode_ci DEFAULT NULL COMMENT 'the IP address(s) for your library or
branch'" );
+  `branchip` mediumtext DEFAULT NULL COMMENT 'the IP address for your library
or branch',
These are not identical. Look at collation and comment.

installer/data/mysql/atomicupdate/bug_28657.perl
Please adjust to "new" style. We are doing that for quite some time already.
Extension should be pl now
See skeleton file.

+    # FIXME remove '*' for backwards compatibility in branchip settings
Why FIXME? You remove it one line later..

koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
If we do want * in the IP field, we should check here. And server side probably
too (library->store or so).

t/Auth.t
Show that * does no longer work. And show that 1.2.3. as range does work.

-- 
You are receiving this mail because:
You are watching all bug changes.