[Koha-bugs] [Bug 34829] Cash register report reverts to "All libraries" after every search

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34829

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Marcel de Rooy from comment #4)
> my $branch             = $input->param("branch");
> my $manager_branchcode = $input->param("branch") ||
> C4::Context->userenv->{'branch'};
> This does not look good.

I am sorry, but this is not constructive. Especially since I didn't change this
line. It only appears in the patch because of the perltidy.

> 
> 
> And this looks bad:
> -                        <option value="ALL">All</option>
> Script still has it:
>     if ($manager_branchcode ne 'ALL') {

Still, no explanation.

-- 
You are receiving this mail because:
You are watching all bug changes.