From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 00:07:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2024 23:07:13 +0000 Subject: [Koha-bugs] [Bug 35518] Call to C4::Context->userenv happens before it's gets populated breaks code logic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35518 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 00:07:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2024 23:07:16 +0000 Subject: [Koha-bugs] [Bug 35518] Call to C4::Context->userenv happens before it's gets populated breaks code logic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35518 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161539|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 161707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161707&action=edit Bug 35518: Check authentication and set userenv before fetching userenv variables Currently we get the userenv before we have set it correctly for the session To test: 1 - Sign in as a user with fast cataloging permission 2 - Bring up a patron, type gibberish into barcode field to get a fast cataloging link 3 - Check the link, it should have your current signed in barcode 4 - Sign in to a different browser with a different user and at a different branch 5 - Bring up a aptron in circulation and type gibberish into barcode field to get a fast cataloging link 6 - It may have your branch, but it may also have the other user's branch from the other window 7 - Keep entering gibberish to get a link until one user has the correct branch 8 - Then switch to the other browser, and keep entering gibberish, watch the branchcode change 9 - Apply patch, restart all 10 - Test switching between browsers. generating fast cataloging links 11 - Users should now consistently have the correct branch Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 00:08:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2024 23:08:05 +0000 Subject: [Koha-bugs] [Bug 18787] Create permission profiles for staff users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18787 Marie-Luce Laflamme changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie-luce.laflamme at inlibro | |.com --- Comment #4 from Marie-Luce Laflamme --- +1. This is a great idea! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 00:30:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2024 23:30:16 +0000 Subject: [Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display local cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207 --- Comment #24 from Lucas Gass --- Is this still being worked on? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 01:44:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 00:44:52 +0000 Subject: [Koha-bugs] [Bug 35967] REST API: Add /api/v1/patrons/{patron_id}/recalls endpoint to list patron's recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35967 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|REST API: Add |REST API: Add |/api/v1/recalls endpoint to |/api/v1/patrons/{patron_id} |list recalls |/recalls endpoint to list | |patron's recalls -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 02:30:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 01:30:04 +0000 Subject: [Koha-bugs] [Bug 35967] REST API: Add /api/v1/patrons/{patron_id}/recalls endpoint to list patron's recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35967 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 02:30:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 01:30:06 +0000 Subject: [Koha-bugs] [Bug 35967] REST API: Add /api/v1/patrons/{patron_id}/recalls endpoint to list patron's recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35967 --- Comment #1 from Aleisha Amohia --- Created attachment 161708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161708&action=edit Bug 35967: Add REST API endpoint to list patron recalls This enhancement adds a REST API endpoint to list a patron's recalls: /api/v1/patrons/{patron_id}/recalls This depends on the logged in patron having the manage_recalls subpermission. To test: 1. Log in to the staff interface as your superlibrarian self (Patron A) 2. Go to Koha Administration -> Global system preferences. Enable the UseRecalls system preference 3. Set the relevant recalls circulation and fines rules 4. Search for an item (Item A) 5. Check out Item A to yourself (Patron A) 6. Log in to the OPAC as Patron B, a patron who does not have the manage_recalls permission 7. Search for Item A and request a recall 8. While still logged in to the OPAC as Patron B, hit this URL: https://your-opac-url/api/v1/patrons/patron-b-borrowernumber/recalls (swap out your URL and Patron B's borrowernumber) 9. Confirm you are given an error: "Authorization failure. Missing required permission(s)." 10. Log out of the OPAC and log back in, this time as Patron A 11. Hit the URL again https://your-opac-url/api/v1/patrons/patron-b-borrowernumber/recalls 12. Confirm you are able to view a list of Patron B's recalls 13. Confirm tests pass: t/db_dependent/api/v1/patrons_recalls.t Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 03:22:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 02:22:52 +0000 Subject: [Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 --- Comment #48 from Victor Grousset/tuxayo --- (In reply to Katrin Fischer from comment #47) > what is needed to move forward? The questions on comment 42 for Jonathan that are mostly about whether or not the changes that I added in the second patch are ok. (with all the reasons detailed in the comment) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 07:31:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 06:31:07 +0000 Subject: [Koha-bugs] [Bug 5920] Remove HTML from downloaded reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 --- Comment #9 from Martin Renvoize --- Created attachment 161709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161709&action=edit Bug 5920: Strip HTML from report exports This patch uses HTML::Restrict to strip out HTML tags from the CSV download of reports. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 07:31:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 06:31:11 +0000 Subject: [Koha-bugs] [Bug 5920] Remove HTML from downloaded reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 --- Comment #10 from Martin Renvoize --- Created attachment 161710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161710&action=edit Bug 5920: Add HTML::Restrict to cpanfile Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 07:31:25 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 06:31:25 +0000 Subject: [Koha-bugs] [Bug 5920] Remove HTML from downloaded reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 07:32:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 06:32:09 +0000 Subject: [Koha-bugs] [Bug 5920] Remove HTML from downloaded reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 --- Comment #11 from Martin Renvoize --- Attached patches from Mirjam's branch.. I wasn't aware of this bug prior to now, otherwise I would have submitted this up earlier. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 07:32:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 06:32:16 +0000 Subject: [Koha-bugs] [Bug 5920] Remove HTML from downloaded reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 07:33:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 06:33:14 +0000 Subject: [Koha-bugs] [Bug 5920] Remove HTML from downloaded reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 --- Comment #12 from Martin Renvoize --- Whilst I agree, the core reason for this has an alternative now, I could see other use cases for HTML in report output that may not be catered for in other ways yet, so I think this is still a worthwhile patch. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 07:46:29 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 06:46:29 +0000 Subject: [Koha-bugs] [Bug 23978] Notes field in saved reports should allow for HTML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 --- Comment #5 from Martin Renvoize --- Created attachment 161711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161711&action=edit Bug 23978: Expose HTML in Reports This patch updates the notes field to a $raw filter to prevent html escaping of the data within it. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 07:46:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 06:46:38 +0000 Subject: [Koha-bugs] [Bug 23978] Notes field in saved reports should allow for HTML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|theod at lib.auth.gr |martin.renvoize at ptfs-europe | |.com CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 07:46:43 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 06:46:43 +0000 Subject: [Koha-bugs] [Bug 23978] Notes field in saved reports should allow for HTML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 07:47:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 06:47:00 +0000 Subject: [Koha-bugs] [Bug 23978] Notes field in saved reports should allow for HTML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95108|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 07:47:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 06:47:12 +0000 Subject: [Koha-bugs] [Bug 23978] Notes field in saved reports should allow for HTML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 07:48:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 06:48:50 +0000 Subject: [Koha-bugs] [Bug 23978] Notes field in saved reports should allow for HTML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 --- Comment #6 from Martin Renvoize --- Is there a more secure way of doing this rather than just exposing the raw html.. I feel like we're just undoing a security flaw we fixed for a reason. Is it time to use markdown for rich text or perhaps for linebreaks just outputting the note field in a pre/code block? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 07:52:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 06:52:40 +0000 Subject: [Koha-bugs] [Bug 35968] New: ClassSplitRoutine should be plugable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35968 Bug ID: 35968 Summary: ClassSplitRoutine should be plugable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org There are cases where libraries use custom/local class numbers. We should make this a pluggable option so custom routines can be filled by local plugins. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 07:52:44 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 06:52:44 +0000 Subject: [Koha-bugs] [Bug 35968] ClassSplitRoutine should be plugable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35968 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 07:52:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 06:52:52 +0000 Subject: [Koha-bugs] [Bug 35968] ClassSplitRoutine should be plugable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35968 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirjam.vantieghem at etf.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 08:09:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 07:09:30 +0000 Subject: [Koha-bugs] [Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race condition) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Status|Passed QA |Signed Off --- Comment #42 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #41) > Marcel, could you maybe do a final review here? Sure, will do. Changing status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 08:12:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 07:12:37 +0000 Subject: [Koha-bugs] [Bug 35920] Centralize code from workers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35920 --- Comment #4 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #3) > I like the concept. > > Given the discussion Marcel is driving around rabbit vs. polling, why not > create some base class and then different classes implementing each > communication mechanism? That way each use case would be self-contained and > maintainble (i.e. one can fix a bug without possibly breaking the other use > case, etc). > > Something like: > > Koha::Worker > Koha::Worker::STOMP > Koha::Worker::Polling > > and then the `background_jobs_worker.pl` script would just call > > > if ( C4::Context->use_stomp ) { > Koha::Worker->new( 'STOMP' )->run(); > } > else { > Koha::Worker->new( 'Polling' )->run(); > } Looks promising! Lets go there. Less_code_in_scripts++ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 08:22:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 07:22:18 +0000 Subject: [Koha-bugs] [Bug 22514] Hardcoded value of 10 for return hour when calculating hourly loans affected by holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22514 Ray Delahunty changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 08:23:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 07:23:38 +0000 Subject: [Koha-bugs] [Bug 35445] OPAC registration verification triggered by email URL scanners In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35445 --- Comment #13 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #11) > Should not we adjust opac-shareshelf.pl as well? Will have a look at that marvelous script :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 08:25:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 07:25:07 +0000 Subject: [Koha-bugs] [Bug 35920] Centralize code from workers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35920 --- Comment #5 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #3) > I like the concept. > > Given the discussion Marcel is driving around rabbit vs. polling, why not > create some base class and then different classes implementing each > communication mechanism? The discussion is going into a "drop one of the other" conclusion, so it does not seem useful to provide a temporary abstraction that will be useless later... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 08:25:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 07:25:17 +0000 Subject: [Koha-bugs] [Bug 35966] Koha should not strip limits from SQL queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35966 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 08:33:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 07:33:53 +0000 Subject: [Koha-bugs] [Bug 25267] OPAC browse shelf feature is not responsive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25267 andrea.capitanio at univ-amu.fr changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|andrea.capitanio at univ-amu.f |lucas at bywatersolutions.com |r | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 08:57:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 07:57:39 +0000 Subject: [Koha-bugs] [Bug 35969] New: opac-sendbasket: Improve error message, remove some logging Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35969 Bug ID: 35969 Summary: opac-sendbasket: Improve error message, remove some logging Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org There is no need for log lines like: [WARN] Error sending mail: empty basket at /usr/share/perl5/CGI/Compile.pm line 151. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 08:57:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 07:57:54 +0000 Subject: [Koha-bugs] [Bug 35969] opac-sendbasket: Improve error message, remove some logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35969 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |m.de.rooy at rijksmuseum.nl Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 08:58:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 07:58:01 +0000 Subject: [Koha-bugs] [Bug 35969] opac-sendbasket: Improve error message, remove some logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35969 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 09:13:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 08:13:35 +0000 Subject: [Koha-bugs] [Bug 35968] ClassSplitRoutine should be plugable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35968 --- Comment #1 from Mirjam Vantieghem --- +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 09:44:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 08:44:27 +0000 Subject: [Koha-bugs] [Bug 35969] opac-sendbasket: Improve error message, remove some logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35969 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 09:44:29 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 08:44:29 +0000 Subject: [Koha-bugs] [Bug 35969] opac-sendbasket: Improve error message, remove some logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35969 --- Comment #1 from Marcel de Rooy --- Created attachment 161713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161713&action=edit Bug 35969: Add error code in opac-sendbasket.pl No need to carp about empty basket or no reply address. Just add a simple explanation on the form. Note that it makes no sense to show the form if the patron has no email address. We need it as reply-to. Test plan: Try opac-sendbasket.pl?bib_list=null Remove email address from your account, try again. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 09:44:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 08:44:42 +0000 Subject: [Koha-bugs] [Bug 35969] opac-sendbasket: Improve error message, remove some logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35969 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 09:49:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 08:49:31 +0000 Subject: [Koha-bugs] [Bug 35968] ClassSplitRoutine should be plugable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35968 --- Comment #2 from Katrin Fischer --- It is a little bit pluggable, but very old-style and pre-plugins and hooks. If you put a .pm in the right spot with your class splitting rules, the GUI will show it in the pull down for selection and you can configure it. It works similar to the value builders. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 09:50:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 08:50:02 +0000 Subject: [Koha-bugs] [Bug 35969] opac-sendbasket: Improve error message, remove some logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35969 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart --- This will conflict with bug 34478. Please keep in mind that we have something HUGE in the queue that MUST be high priority for everybody and pushed as soon as possible. Those kind of patches should definitely be delayed until 34478 is pushed. Marked as blocked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 09:50:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 08:50:09 +0000 Subject: [Koha-bugs] [Bug 35968] ClassSplitRoutine should be plugable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35968 --- Comment #3 from Katrin Fischer --- Just in case a workaround is needed and to keep the use case in mind for people who might need/want to transition. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 09:51:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 08:51:35 +0000 Subject: [Koha-bugs] [Bug 35969] opac-sendbasket: Improve error message, remove some logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35969 --- Comment #3 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #2) > This will conflict with bug 34478. Please keep in mind that we have > something HUGE in the queue that MUST be high priority for everybody and > pushed as soon as possible. Those kind of patches should definitely be > delayed until 34478 is pushed. > > Marked as blocked. No reason to block every patch for something In discussion, right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 09:57:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 08:57:53 +0000 Subject: [Koha-bugs] [Bug 35969] opac-sendbasket: Improve error message, remove some logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35969 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 10:18:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 09:18:47 +0000 Subject: [Koha-bugs] [Bug 26567] Allow to limit subscription search to subscriptions with routing lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26567 Christian Stelzenmüller changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |christian.stelzenmueller at bs | |z-bw.de --- Comment #8 from Christian Stelzenmüller --- An error occured when trying to add two or more patrons to the routing list. Error trace C4::Serials::addroutingmember(): DBI Exception: DBD::mysql::st execute failed: Duplicate entry '2-19' for key 'subscriptionid' at /kohadevbox/koha/serials/routing.pl line 69 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 10:33:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 09:33:30 +0000 Subject: [Koha-bugs] [Bug 26567] Allow to limit subscription search to subscriptions with routing lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26567 Christian Stelzenmüller changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #9 from Christian Stelzenmüller --- I'll take it back. I'll verified it without the patch, this error has nothing to do with the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 11:38:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 10:38:52 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 13:17:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 12:17:48 +0000 Subject: [Koha-bugs] [Bug 18787] Create permission profiles for staff users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18787 --- Comment #5 from Alexander Wagner --- Diving into the mentioned plugin I found indeed that it assumes each patron gains only one set of permissions (iow you can not be in more than one group). For this reason I came up with a small perl script than will handle permission setup for j2k. This script basically reads an input file giving the name of the role someone should have and her cardnumber. It will then create a patron list for the roles, add patrons to the list (for easy reference) and add permissions accordingly. This script could need a bit of improvement for general use. E.g. an immediate thing would be to move the hard coded hash for permissions to some source read in, and probably for koha purists the idea to have files around that implement the functions are not that common. (It's just easy for me to handle those files in git within j2k.) But maybe one could build upon it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 13:42:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 12:42:19 +0000 Subject: [Koha-bugs] [Bug 35971] New: Adding a patron/recipient to a routing list twice creates an error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35971 Bug ID: 35971 Summary: Adding a patron/recipient to a routing list twice creates an error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: christian.stelzenmueller at bsz-bw.de QA Contact: testopia at bugs.koha-community.org If you try to add a patron or recipient twice to a routing list, it creates an error. To test: 1. Create a subscription 2. Create a routing list. 3. Click ‚Add recipients‘ to the routing list. 4. Search for a patron, and add them. Then, add the same person again. Part of the error trace: C4::Serials::addroutingmember(): DBI Exception: DBD::mysql::st execute failed: Duplicate entry '2-19' for key 'subscriptionid' at /kohadevbox/koha/serials/routing.pl line 69 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 14:21:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 13:21:09 +0000 Subject: [Koha-bugs] [Bug 26297] Rest API: add a route to list patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 14:23:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 13:23:30 +0000 Subject: [Koha-bugs] [Bug 35701] Cannot use i18n.inc from memberentrygen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35701 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.03 released in| | --- Comment #15 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 14:31:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 13:31:12 +0000 Subject: [Koha-bugs] [Bug 35972] New: Using Course reserves module for Research table reserves Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Bug ID: 35972 Summary: Using Course reserves module for Research table reserves Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: mirjam.vantieghem at etf.edu QA Contact: testopia at bugs.koha-community.org Created attachment 161714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161714&action=edit Screenshot of example Research tables on OPAC Our library has research tables and lets patrons (mainly master students working on their thesis) keep items for a longer period on these tables. In order for both library staff and patrons to be able to quickly track down items, we are using the Course reserves module to set a certain research table as temporary location for a certain item. Because tables are not courses, we use a custom patch to have the research tables appear as a separate module on the OPAC. We use the authorized value category DEPARTMENT to distinguish courses from tables. The tables have a separate value "Research tables". Because some of the columns used for the course reserves are not relevant for the tables, we also change the display of these on the OPAC. The following columns are renamed: “Course #” => “Table #” “Instructors” => “Researcher” “Notes” => “Topic” And these columns are hidden: “Dept.”, “Section”, “Term”. Notes: 1) Because of possible privacy issues, we are no longer displaying the name of the researcher, so this column might also be hidden. 2) The topic is optional. Some like to see what others are doing research on. It also helps to know where to look for a book on a certain topic if it is not on the shelf, because keeping the 'table reserves' up to date is a bit of a challenge sometimes, depending on the cooperation of the patron. Ideally this should be a separate module on both the Staff client and the OPAC. It might be called 'Table reserves' if 'Research tables' is too specific. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 14:32:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 13:32:14 +0000 Subject: [Koha-bugs] [Bug 35972] Using Course reserves module for Research table reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Mirjam Vantieghem changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 14:35:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 13:35:42 +0000 Subject: [Koha-bugs] [Bug 35973] New: Redirect Guarantee Email has incorrect values Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35973 Bug ID: 35973 Summary: Redirect Guarantee Email has incorrect values Change sponsored?: --- Product: Koha Version: 23.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com With the introduction to bug 12532, Copy guarantee email to the guarantor (or redirect if guarantee has no email set), a new system preference has been included in Koha, EnableRedirectGuaranteeEmail. Unfortunately, although the system preference choices on the interface say Enable/Don't Enable, the code has a Yes/No value. koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref This will need to be fixed to align with Koha is looking for to turn on this sys pref. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 14:41:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 13:41:24 +0000 Subject: [Koha-bugs] [Bug 35974] New: Include the ability to type in a search within Members-Home.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35974 Bug ID: 35974 Summary: Include the ability to type in a search within Members-Home.pl Change sponsored?: --- Product: Koha Version: 23.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When using the Patron search, koha/members/members-home.pl? and there are results on the screen, the user is presented with a table that has columns. Columns such as Home Library and Category only include the option to use a drop-down of options to choose from. With libraries that have a lot of libraries and/or categories, this can be tedious. It would be nice if the user could have the choice of a dropdown but also start typing in the first few letters to bring that result to the top. This option appears in other places such as in the additem.pl in the shelving location and collection code, both a drop-down and the option to type in the search exist. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 14:43:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 13:43:55 +0000 Subject: [Koha-bugs] [Bug 35975] New: Download cart with BIBTEX contains hash value Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35975 Bug ID: 35975 Summary: Download cart with BIBTEX contains hash value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org @book{Koha::Biblio=HASH(0x560e89ade4b8), author = {Schwartz, Randal L. and Phoenix, Tom}, title = {Learning Perl /}, etc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 14:44:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 13:44:04 +0000 Subject: [Koha-bugs] [Bug 35354] Update EmailLibrarianWhenHoldisPlaced system preference description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35354 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.03 released in| | --- Comment #6 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 14:46:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 13:46:24 +0000 Subject: [Koha-bugs] [Bug 35354] Update EmailLibrarianWhenHoldisPlaced system preference description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35354 --- Comment #7 from Fridolin Somers --- Note that system preference real name is : emailLibrarianWhenHoldIsPlaced -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 14:47:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 13:47:15 +0000 Subject: [Koha-bugs] [Bug 35976] New: Enlarge the text boxes for Barcode Width and Height Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35976 Bug ID: 35976 Summary: Enlarge the text boxes for Barcode Width and Height Change sponsored?: --- Product: Koha Version: 23.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org With the introduction of the barcode width and height options ( bug 10762), a user can now add values to adjust these dimensions. It would be very nice if the boxes for the values were bit bigger or adjustable. The boxes only hold 2 digits, but most libraries will be adding 3 digits in this box, such as 0.02 . To see the value, the cursor needs to be placed in the text box and arrowed over to see the contents. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 14:47:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 13:47:35 +0000 Subject: [Koha-bugs] [Bug 35373] Remove comment about bug 8000 in gather_print_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35373 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.03 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 14:48:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 13:48:31 +0000 Subject: [Koha-bugs] [Bug 35596] Error in writeoff_debts documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35596 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.03 released in| | --- Comment #5 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 14:51:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 13:51:04 +0000 Subject: [Koha-bugs] [Bug 35349] Reindent label item search template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35349 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.03 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 14:51:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 13:51:53 +0000 Subject: [Koha-bugs] [Bug 35350] Update label creator pop-up windows with consistent footer markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35350 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 14:54:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 13:54:13 +0000 Subject: [Koha-bugs] [Bug 34872] Cart pop-up is missing page section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34872 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.03 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #5 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 14:55:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 13:55:49 +0000 Subject: [Koha-bugs] [Bug 35977] New: Display current date in Hold starts on date on opac-reserve Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 Bug ID: 35977 Summary: Display current date in Hold starts on date on opac-reserve Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: mirjam.vantieghem at etf.edu QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com This is related to bug #15652. If you enable AllowHoldDateInFuture (and its OPAC variant), you get an additional "Hold starts on date". It is possible to select the current date from the datepicker in the OPAC. If no date is selected, the default is the current date. However, it is not clear to the patron that the current date is selected by default, as the field is empty if no date has been selected from the datepicker. This caused confusion among some of our patrons. Therefore we use a custom patch to have the current date shown in the field "Hold starts on date". What Marcel de Rooy wrote in the related bug, also applies here: "Although it does not really make any difference if you leave the startdate empty or put the current date in it, we concluded that it still makes a psychological difference." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 14:56:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 13:56:26 +0000 Subject: [Koha-bugs] [Bug 35977] Display current date in Hold starts on date on opac-reserve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 Mirjam Vantieghem changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 14:56:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 13:56:47 +0000 Subject: [Koha-bugs] [Bug 35977] Display current date in Hold starts on date on opac-reserve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 Mirjam Vantieghem changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gmcharlt at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:05:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 14:05:59 +0000 Subject: [Koha-bugs] [Bug 34298] Duplicate existing orders is missing page section on order list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34298 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:06:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 14:06:35 +0000 Subject: [Koha-bugs] [Bug 33464] Report "Orders by fund" is missing page-section class on results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33464 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:07:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 14:07:31 +0000 Subject: [Koha-bugs] [Bug 35833] Fix few noisy warnings from C4/Koha and search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35833 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25790 CC| |fridolin.somers at biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:07:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 14:07:31 +0000 Subject: [Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35833 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35833 [Bug 35833] Fix few noisy warnings from C4/Koha and search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:08:58 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 14:08:58 +0000 Subject: [Koha-bugs] [Bug 35833] Fix few noisy warnings from C4/Koha and search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35833 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.03 released in| | --- Comment #7 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:14:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 14:14:39 +0000 Subject: [Koha-bugs] [Bug 35978] New: Extend breadcrumbs Course reserves with sections Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35978 Bug ID: 35978 Summary: Extend breadcrumbs Course reserves with sections Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: mirjam.vantieghem at etf.edu QA Contact: testopia at bugs.koha-community.org It is allowed to have duplicate values for 'Course #' for the courses in the Course reserves module. Some of our courses are taught both in the residential and Open University (distance learning) program under the same name and with the same abbreviation. But the literature sometimes differs, so we create a separate course for each program, but with the same name and 'Course #'. We use 'Section' to distinguish the different programs. However, 'Section' is not added to the breadcrumb when viewing course details and when adding reserves. We currently use a custom patch to have the 'Section' added to the course 'Name'. It is then displayed as part of the 'Name' when viewing the list of courses, and also in the breadcrumb as part of the course name. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:14:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 14:14:49 +0000 Subject: [Koha-bugs] [Bug 35978] Extend breadcrumbs Course reserves with sections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35978 Mirjam Vantieghem changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:24:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 14:24:02 +0000 Subject: [Koha-bugs] [Bug 35979] New: Possible RealTimeHoldsQueue check missing in modrequest.pl for BatchUpdateBiblioHoldsQueue background job Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35979 Bug ID: 35979 Summary: Possible RealTimeHoldsQueue check missing in modrequest.pl for BatchUpdateBiblioHoldsQueue background job Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: pedro.amorim at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: jonathan.druart+koha at gmail.com, katrin.fischer at bsz-bw.de, martin.renvoize at ptfs-europe.com, nick at bywatersolutions.com, tomascohen at gmail.com Not sure if a bug or not, but bug 30728 introduced a check for the RealTimeHoldsQueue everywhere the BatchUpdateBiblioHoldsQueue background job is enqueued. However, modrequest.pl enqueues BatchUpdateBiblioHoldsQueue without this check. Opening this bug to perhaps get confirmation on this or discover what bug this may cause. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:24:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 14:24:02 +0000 Subject: [Koha-bugs] [Bug 30728] Allow real-time holds queue opt-out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35979 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:39:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 14:39:24 +0000 Subject: [Koha-bugs] [Bug 35800] edit_any_item permission required to see patron name in detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35800 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.03 released in| | --- Comment #11 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:42:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 14:42:12 +0000 Subject: [Koha-bugs] [Bug 35744] Implement +strings for GET /patrons/:patron_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35744 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.03 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #7 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:43:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 14:43:36 +0000 Subject: [Koha-bugs] [Bug 35745] Setting suggester on the suggestion edit form does not show library and category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35745 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:47:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 14:47:04 +0000 Subject: [Koha-bugs] [Bug 35743] The "category" filter is not selected in the column filter dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35743 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:49:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 14:49:21 +0000 Subject: [Koha-bugs] [Bug 35742] Cannot remove new user added to fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35742 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.03 released in| | --- Comment #6 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:51:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 14:51:35 +0000 Subject: [Koha-bugs] [Bug 35578] Validate "Where" in OPAC Authority search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35578 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.03 released in| | Patch complexity|--- |Small patch CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #12 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:52:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 14:52:20 +0000 Subject: [Koha-bugs] [Bug 35530] Can't tell if UserCSS and UserJS in libraries are for staff interface or OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #8 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:53:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 14:53:16 +0000 Subject: [Koha-bugs] [Bug 35514] New order line form: Total prices not updated when adding multiple items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Patch complexity|--- |Trivial patch Version(s)|24.05.00 |24.05.00,23.11.03 released in| | --- Comment #12 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:56:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 14:56:19 +0000 Subject: [Koha-bugs] [Bug 5920] Remove HTML from downloaded reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from Andrew Fuerste-Henry --- With this patch on ByWater's sandbox site I get the following error when I attempt to create a report via SQL: Could not compile /kohadevbox/koha/reports/guided_reports.pl: Can't locate HTML/Restrict.pm in @INC (you may need to install the HTML::Restrict module) (@INC contains: /kohadevbox/koha /kohadevbox/koha/lib /kohadevbox/koha/installer /kohadevbox/koha/lib/installer /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.32.1 /usr/local/share/perl/5.32.1 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl /var/lib/koha/html/plugins) at /kohadevbox/koha/reports/guided_reports.pl line 43. BEGIN failed--compilation aborted at /kohadevbox/koha/reports/guided_reports.pl line 43. at /usr/share/perl5/CGI/Compile.pm line 144 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:56:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 14:56:38 +0000 Subject: [Koha-bugs] [Bug 35445] OPAC registration verification triggered by email URL scanners In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35445 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.03 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #14 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 16:04:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 15:04:05 +0000 Subject: [Koha-bugs] [Bug 35396] Replace Datatables' column filters throttling with input timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35396 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 16:06:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 15:06:48 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #69 from Jonathan Druart --- (In reply to Emily Lamancusa from comment #66) Thanks a lot! > Notes from my testing: > The majority of it seems to be working as it's supposed to. I ran into a few > problems with filtering, though: > > 1. When using the general "Search" field at the top of the table, the filter > often failed with the error message: “Something went wrong when loading the > table: 500 Internal Server Error”. In this case, the displayed result set > remained unchanged. This is driving me crazy and I am totally stuck. I have pushed some info to a separate branch bug_33568_wip https://gitlab.com/joubu/Koha/-/commit/c7969388f1a59ad83a2bf82df1d0abf9a8c065b3 > 3. If StaffDetailItemSelection and/or LocalCoverImages is turned off, the > alignment of the drop-down filters for the other columns is offset by 1 for > each of the two sysprefs that is disabled Good catch. Fixed in "Fix columns shift when pref are off". > 4. The general "Search" bar at the top of the table can only search on AV > codes, not display names (is this intentionally left for follow-up since the > column-specific filters were fixed by adding drop-downs?) Yes, that's a limitation of our DT/REST API for now. We need to deal with that but that's not for here. > A couple of other minor things that do not need to be blockers: > 1. The "Clear filter" button (next to the general "Search" box at the top of > the table) is always disabled Weird, I am sure I fixed that already. This is not related directly to this table (see the patron search for instance). It should be reported separately. > 2. Missing space after the transit date: “In transit from Springfield to > Fairfield since 01/25/2024There is an item level hold on this item (priority > = 0).” Done (fixed inline) (In reply to Emily Lamancusa from comment #67) > Feedback from the MCPL staff who looked at the patch: > > Inability to sort/filter on status: Front-line staff don't often do this, so > it's not a big deal for them. However, acquisitions staff do need to > sort/filter by item status on bib records pretty frequently. It would be > great if that could be prioritized as a follow-up, even if it's a filter > that's more hard-coded than we'd like with a FIXME for later. It can be done, but it is not trivial. We need to move the logic to perl. > Hiding columns based on whether the first page of results returns data: This > doesn't come up often for us (most columns in our system either always have > data or very rarely have data), though I see how this could potentially be > an issue for other libraries. As state in a previous comment this is impossible to resolve. > Finally, the reload time when changing the sort/filter was also a concern - > if you do multiple sorts/filters on smaller bibs, this can actually increase > the overall loading time. The potential follow-up that was discussed > earlier, to block the Ajax reload when all items are showing, could > definitely help with this, especially on smaller bibs. To be honest I have no idea how easy/hard it is to implement. But I will be happy to look into it. Don't hesitate to open new bug reports depending on this one, if you have enhancement ideas/requests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 16:07:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 15:07:47 +0000 Subject: [Koha-bugs] [Bug 34853] Move EDI link to new line in invoice column of acquisition details display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34853 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.03 released in| | --- Comment #11 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 16:09:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 15:09:16 +0000 Subject: [Koha-bugs] [Bug 35774] add_item_to_item_group additem.pl should be $item->itemnumber instead of biblioitemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35774 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 16:10:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 15:10:45 +0000 Subject: [Koha-bugs] [Bug 35753] Checkbox() function in additional-contents not necessary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35753 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.03 released in| | --- Comment #6 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 16:21:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 15:21:26 +0000 Subject: [Koha-bugs] [Bug 35535] Cancel hold -button does not work in pop-up (Hold found, item is already waiting) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #12 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 16:31:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 15:31:30 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off --- Comment #70 from Jonathan Druart --- (In reply to Jonathan Druart from comment #69) > (In reply to Emily Lamancusa from comment #66) > > Thanks a lot! > > > Notes from my testing: > > The majority of it seems to be working as it's supposed to. I ran into a few > > problems with filtering, though: > > > > 1. When using the general "Search" field at the top of the table, the filter > > often failed with the error message: “Something went wrong when loading the > > table: 500 Internal Server Error”. In this case, the displayed result set > > remained unchanged. > > This is driving me crazy and I am totally stuck. I have pushed some info to > a separate branch bug_33568_wip > https://gitlab.com/joubu/Koha/-/commit/ > c7969388f1a59ad83a2bf82df1d0abf9a8c065b3 "Fixed" on "Bug 33568: Remove LPAD ordering" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 16:44:33 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 15:44:33 +0000 Subject: [Koha-bugs] [Bug 24710] patron-title.inc should have seperate span classes for firstname, othername, surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710 --- Comment #22 from Lucas Gass --- Could we have 2 includes here? A patron-title-html.inc and a patron-title-nohtml.inc? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 16:46:23 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 15:46:23 +0000 Subject: [Koha-bugs] [Bug 35940] Cypress tests for the Preservation module are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35940 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Katrin Fischer --- After getting past the regressions.t fail, we now see this one on Jenkins. I have tested locally and now pushed the patches in hope to get us to green. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 16:46:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 15:46:30 +0000 Subject: [Koha-bugs] [Bug 35940] Cypress tests for the Preservation module are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35940 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 16:47:51 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 15:47:51 +0000 Subject: [Koha-bugs] [Bug 35354] Update emailLibrarianWhenHoldisPlaced system preference description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35354 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update |Update |EmailLibrarianWhenHoldisPla |emailLibrarianWhenHoldisPla |ced system preference |ced system preference |description |description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 17:07:28 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 16:07:28 +0000 Subject: [Koha-bugs] [Bug 35980] New: Add message to patron needs permission check Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35980 Bug ID: 35980 Summary: Add message to patron needs permission check Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Since Bug 30230, a user can see patron details without edit_borrowers permission. In tools bar, "Add message" needs to check this permission. Maybe other places. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 17:07:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 16:07:35 +0000 Subject: [Koha-bugs] [Bug 35980] Add message to patron needs permission check In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35980 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30230 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 17:07:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 16:07:35 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35980 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35980 [Bug 35980] Add message to patron needs permission check -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 17:09:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 16:09:21 +0000 Subject: [Koha-bugs] [Bug 35980] Add message to patron needs permission check In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35980 --- Comment #1 from Fridolin Somers --- Test with authentication on staff interface with only permissions 'catalogue' and 'list_borrowers'. On a patron page try add a message => you get permission denied page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 17:10:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 16:10:08 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #87 from Fridolin Somers --- I've found a minor issue Bug 35980 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 17:11:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 16:11:40 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.03 released in| | Patch complexity|--- |Medium patch --- Comment #88 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 17:12:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 16:12:59 +0000 Subject: [Koha-bugs] [Bug 35980] Add message to patron needs permission check In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35980 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 17:15:33 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 16:15:33 +0000 Subject: [Koha-bugs] [Bug 34913] Upgrade DataTables from 1.10.18 to 1.13.6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34913 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #67 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 17:16:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 16:16:08 +0000 Subject: [Koha-bugs] [Bug 32752] Add new serial issue status: "Out for binding", "Bound", and "Circulating" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32752 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose at inlibr | |o.com Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/829 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 17:16:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 16:16:09 +0000 Subject: [Koha-bugs] [Bug 35595] Show new issue status in subscription tab in OPAC and staff detail pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35595 Bug 35595 depends on bug 32752, which changed state. Bug 32752 Summary: Add new serial issue status: "Out for binding", "Bound", and "Circulating" https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32752 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 17:17:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 16:17:30 +0000 Subject: [Koha-bugs] [Bug 35922] t/db_dependent/www/batch.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35922 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.03 released in| | --- Comment #4 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 17:19:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 16:19:22 +0000 Subject: [Koha-bugs] [Bug 35368] "Add a checkout" shows up twice in online documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35368 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.03 released in| | --- Comment #5 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 17:20:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 16:20:30 +0000 Subject: [Koha-bugs] [Bug 35406] Typo in holds queue viewer template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35406 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #10 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 17:21:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 16:21:01 +0000 Subject: [Koha-bugs] [Bug 35300] Add page-section to table of invoice files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35300 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.03 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #5 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 17:23:44 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 16:23:44 +0000 Subject: [Koha-bugs] [Bug 35936] Cannot save existing report with incorrect AV category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35936 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 17:29:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 16:29:06 +0000 Subject: [Koha-bugs] [Bug 35483] Restore item level to record level hold switch in hold table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35483 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #11 from Fridolin Somers --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 17:31:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 16:31:30 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #88 from Fridolin Somers --- Enhancement not pushed to 23.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 18:02:56 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 17:02:56 +0000 Subject: [Koha-bugs] [Bug 35981] New: Add authorized values for Relator Codes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35981 Bug ID: 35981 Summary: Add authorized values for Relator Codes Change sponsored?: --- Product: Koha Version: 23.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: esther.melander at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Bug 34677 updates the relator terms and codes list. There are authorized values for Relator Terms but not for Relator Codes. This should be separated out so that the codes can be selected for $4, which is more correct for that subfield. While it is possible for a user to add authorized values for Relator Codes, it would be nice if they were included. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 18:11:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 17:11:47 +0000 Subject: [Koha-bugs] [Bug 35982] New: 500 error when removing authorized value in framework subfield Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35982 Bug ID: 35982 Summary: 500 error when removing authorized value in framework subfield Change sponsored?: --- Product: Koha Version: 23.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: esther.melander at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 161715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161715&action=edit 500 error logs To recreate: 1. Edit the default framework, tag 100. 2. Edit subfield $e and add the authorized value RELTERMS. Save. 3. Find a bibliographic record and edit. 4. Find tag 100 and see that subfield $e has a drop down to select Relator Terms. 5. Edit the framework again for tag 100 $e. 6. In the box for Authorized Value, scroll to the top of the list and select the "blank" option. 7. Attempt to save. I would have expected that selecting the "blank" option in the authorized value list would remove the authorized value from that subfield. Database error message attached. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 18:39:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 17:39:54 +0000 Subject: [Koha-bugs] [Bug 35982] 500 error when removing authorized value in framework subfield In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35982 Esther Melander changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Esther Melander --- Possibly a database problem on my demo site. I will mark this as invalid for now and reopen if I can replicate on more than one site. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 18:44:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 17:44:27 +0000 Subject: [Koha-bugs] [Bug 35912] Item prices not populating order form when adding to a basket from a staged file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35912 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161483|0 |1 is obsolete| | --- Comment #8 from ByWater Sandboxes --- Created attachment 161716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161716&action=edit Bug 35912: Corretc field name form itemprice to price in addorderiso2709 template To test: Setup -- Set systempreferences below MarcFieldsToOrder: price: 949$g quantity: 949$k budget_code: 949$l discount: 949$m sort1: 949$n sort2: 949$q MarcItemFieldsToOrder: homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t price: 949$g replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l Stage the attached bib-303.marcxml file Add to basket from the staged file Select the biblio Note items do no have prices Cancel Apply patch Add to basket from file again Note prices, and other fields, come through as expected Signed-off-by: Michelle Spinney Signed-off-by: Marcel de Rooy Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 18:50:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 17:50:08 +0000 Subject: [Koha-bugs] [Bug 35913] Item order prices do not fall back to MarcFieldsToOrder if not set by MarcItemFieldsToOrder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35913 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161464|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes --- Created attachment 161717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161717&action=edit Bug 35913 - Restore price fall back to MarcFieldsToOrder if not set by MarcItemFieldsToOrder To test: Setup -- Set systempreferences below MarcFieldsToOrder: price: 949$g quantity: 949$k budget_code: 949$l discount: 949$m sort1: 949$n sort2: 949$q MarcItemFieldsToOrder: homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t price: 949$g replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l Stage the attached bib-303.marcxml file Add to basket from the staged file Select the biblio Note items have prices Cancel Remove 'price' mapping from MarcItemFieldsToOrder Apply patch Add to basket from file again Note item prices, and other fields, come through as expected Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 18:50:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 17:50:20 +0000 Subject: [Koha-bugs] [Bug 35913] Item order prices do not fall back to MarcFieldsToOrder if not set by MarcItemFieldsToOrder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35913 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 18:53:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 17:53:09 +0000 Subject: [Koha-bugs] [Bug 35912] Item prices not populating order form when adding to a basket from a staged file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35912 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org --- Comment #9 from Andrew Fuerste-Henry --- Apologies for the stray sign-off, it was a sandbox error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 20:50:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 19:50:17 +0000 Subject: [Koha-bugs] [Bug 20747] Allow LocalHoldsPriority to fill by hierarchical groups system rather than individual library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Catrina Berka changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catrina at bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 20:52:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 19:52:57 +0000 Subject: [Koha-bugs] [Bug 25047] Tutorial for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25047 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 21:45:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 20:45:57 +0000 Subject: [Koha-bugs] [Bug 30318] Cannot override default patron messaging preferences when creating a patron in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 Kristi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger at cuyahogalibrary.or | |g --- Comment #4 from Kristi --- This is a much needed fix for us. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 21:46:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 20:46:06 +0000 Subject: [Koha-bugs] [Bug 5920] Remove HTML from downloaded reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |no-sandbox --- Comment #14 from Martin Renvoize --- Sandboxes don't pull new dependencies from the cpanfile I'm afraid, so this one can't easily be tested there :-(. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 21:46:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 20:46:13 +0000 Subject: [Koha-bugs] [Bug 5920] Remove HTML from downloaded reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 21:47:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 20:47:59 +0000 Subject: [Koha-bugs] [Bug 5920] Remove HTML from downloaded reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 --- Comment #15 from Andrew Fuerste-Henry --- (In reply to Martin Renvoize from comment #14) > Sandboxes don't pull new dependencies from the cpanfile I'm afraid, so this > one can't easily be tested there :-(. Ahha! I'll try to get to it on my testing docker. Thanks! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 22:14:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 21:14:52 +0000 Subject: [Koha-bugs] [Bug 27298] Adjusting a Numbering Pattern will not show in receiving next issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27298 Sue changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |yach at morainevalley.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 22:37:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 21:37:02 +0000 Subject: [Koha-bugs] [Bug 26567] Allow to limit subscription search to subscriptions with routing lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26567 Danyon Sewell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161618|0 |1 is obsolete| | --- Comment #10 from Danyon Sewell --- Created attachment 161718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161718&action=edit Bug 26567: Allow to limit subscription search to subscriptions with routing lists unit tests have now been written for the SearchSubscription subroutine. Test plan: 1. Apply this patch 2. Create two subscriptions, one with a routing list and one without 3. Navigate to Serials home and tick the checkbox labeled "Search routing lists only:" 4. Confirm that the only search result to appear is the subscription you added the routing list to Sponsored by: Bibliotheksservice-Zentrum Baden-Wuerttemberg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 23:36:29 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 22:36:29 +0000 Subject: [Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #23 from Barbara Johnson --- Here is what I found in testing this bug: * The location code of 'AV' was not imported into the 949$c tag even though it looks correct in the sample file and the location code exists. * No data was imported into replacement price (949$v) because there was no data in the sample file. It would be good to test this field because I hear many complaints from librarians when the replacement price doesn't come through. * The itemcallnumber from the sample file was not imported into the 949$o. It was not specified to be included in MarcItemFieldsToOrder in the test plan. * The barcode# from the sample file was not imported into the 949$p. It was not specified to be included in MarcItemFieldsToOrder in the test plan. * The sample file contains three fields with the date of 2014-09-04. These are in subfields d - Date acquired and w - Price effective from. Those fields were not specified to be included in MarcItemFieldsToOrder in the test plan which is probably why they populated with today's date. That date was also in subfield r in the sample file. * There are other fields that were not contained in the sample data that I think it would be good to test. They are the 949$7 (Not for loan), 949$u (Uniform resource identifier) and 949$x (Nonpublic note) * When I saved the file and viewed it in steps 9 and 10 I got the message: No records imported No records have been imported because they all match existing records in your catalog. You'll have to treat them individually. Since that's not something I do very often I opted to not match existing records which were successfully imported. The item data looked correct to me in the other fields, the prices appeared correct and the ordered were split up amongst the three funds. Once you are ready I'll be glad to retest this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 23:44:23 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 22:44:23 +0000 Subject: [Koha-bugs] [Bug 35966] Koha should not strip limits from SQL queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35966 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 00:12:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 23:12:52 +0000 Subject: [Koha-bugs] [Bug 29490] Preview for more notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29490 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 00:13:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2024 23:13:01 +0000 Subject: [Koha-bugs] [Bug 7999] Send test notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7999 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 01:02:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 00:02:45 +0000 Subject: [Koha-bugs] [Bug 35983] New: Branch specific Refund lost item replacement fee cannot be 'refund_unpaid' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35983 Bug ID: 35983 Summary: Branch specific Refund lost item replacement fee cannot be 'refund_unpaid' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To recreate: 1. Admin > Circ & fine rules 2. Select a library at the top of the forms ( #selectlibrary ) 3. Try to change the 'Refund lost item replacement fee' to "Refund lost item charge (only if unpaid)". 4. Press save and let the page reload. 5. Look at the dropdown again, the value is now set to "Refund lost item charge and restore overdue fine". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 01:06:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 00:06:00 +0000 Subject: [Koha-bugs] [Bug 35983] Branch specific Refund lost item replacement fee cannot be 'refund_unpaid' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35983 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 01:06:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 00:06:01 +0000 Subject: [Koha-bugs] [Bug 35983] Branch specific Refund lost item replacement fee cannot be 'refund_unpaid' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35983 --- Comment #1 from Lucas Gass --- Created attachment 161719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161719&action=edit Bug 35983: Remove extra seleted=selected from dropdown menu To test: 1. Admin > Circ & fine rules 2. Select a library at the top of the forms ( #selectlibrary ) 3. Try to change the 'Refund lost item replacement fee' to "Refund lost item charge (only if unpaid)". 4. Press save and let the page reload. 5. Look at the dropdown again, the value is now set to "Refund lost item charge and restore overdue fine". 6. APPLY PATCH 7. Try steps 2 - 5 again but this time the value in the dropdown should not change. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 01:06:10 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 00:06:10 +0000 Subject: [Koha-bugs] [Bug 35983] Branch specific Refund lost item replacement fee cannot be 'refund_unpaid' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35983 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 01:12:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 00:12:49 +0000 Subject: [Koha-bugs] [Bug 35984] New: automated static code analysis should include security tests Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35984 Bug ID: 35984 Summary: automated static code analysis should include security tests Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: evelyn at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org A few libraries have asked recently if, prior to production/during the development lifecycle, automated source code analysis tools are used to test for security flaws specifically. Typically these questions are in relation to processes like renewing cybersecurity insurance or initial discovery by a potential partner library's security/IT department. Perlcritic seems to be currently used, but as far as I can tell it appears the tests are for enforcing the coding standard. Using an automated tool to look for security flaws will be a beneficial addition to the project, so I'd like to at least start the discussion here. OWASP has an informational page for further reading: https://owasp.org/www-community/controls/Static_Code_Analysis -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 02:16:33 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 01:16:33 +0000 Subject: [Koha-bugs] [Bug 33563] Document Elasticsearch secure mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33563 --- Comment #3 from David Cook --- I've been setting up Elasticsearch 7 with a Koha and this is what I used: localhost:9200 elastic:CHANGEME 1 The relevant bits above being "userinfo" and "use_https", and I found them by looking at https://metacpan.org/pod/Search::Elasticsearch::Role::Cxn#node and looking around the code a bit. With Elasticsearch 7, to use basic auth you have to use HTTPS as well, but that's a much more complicated topic. We could add commented out "userinfo" and "use_https" elements in koha-conf.xml though to get people on the right track. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 02:52:25 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 01:52:25 +0000 Subject: [Koha-bugs] [Bug 35953] Add delete_any_record cataloguing subpermission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35953 --- Comment #1 from wainuiwitikapark at catalyst.net.nz --- Created attachment 161720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161720&action=edit Bug 35953: Add delete_any_record cataloguing subpermission To test: - apply patch - create a new test user - give the test user "catalogue" permissions so that they can enter the staff interface - also give the test user the "edit_catalogue" subpermission under the "editcatalogue" permission - login to the staff interface as the test user - do a catalogue search - click on a result and go to their biblio details page - notice there is an "Edit" button dropdown - click on the "Edit" button dropdown and notice there are only 2 results - change the permissions of the test user to also have "delete_any_record" subpermission under the "editcatalogue" permission - do another catalogue search and click on the result - click on the "Edit" button dropdown and notice there are 2 more options: "Edit record" and "Delete record" Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 02:53:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 01:53:26 +0000 Subject: [Koha-bugs] [Bug 35953] Add delete_any_record cataloguing subpermission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35953 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 03:00:56 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 02:00:56 +0000 Subject: [Koha-bugs] [Bug 35984] automated static code analysis should include security tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35984 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 05:49:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 04:49:24 +0000 Subject: [Koha-bugs] [Bug 35514] New order line form: Total prices not updated when adding multiple items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514 --- Comment #13 from Victor Grousset/tuxayo --- (In reply to Thibaud Guillot from comment #10) > ah right... that's my mistake... I meant to say that the price is simply not > updated... I misspoke. Great news, so no weird stuff happens to only some setups :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 06:14:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 05:14:07 +0000 Subject: [Koha-bugs] [Bug 30627] koha-run-backups delete the backup files after finished its job without caring days option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30627 --- Comment #13 from Victor Grousset/tuxayo --- (In reply to Marcel de Rooy from comment #10) > Victor: Can understand your concerns, but should not really be an issue imo > in daily operation. Oh great :D I though we were doomed when you said "LOL It happens all the time :)" T_T But no! Thanks for your insight that this shouldn't be a problem in practice ^^ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 09:00:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 08:00:08 +0000 Subject: [Koha-bugs] [Bug 32132] Missing budget_period_id in aqbudgets kills lateorders.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32132 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143988|0 |1 is obsolete| | --- Comment #4 from Emmi Takkinen --- Created attachment 161721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161721&action=edit Bug 32132: Do not allow NULL value in column aqbudgets.budget_period_id If budget_period_id column is set as NULL, "Late orders" page dies on error 500. Logs read: Template process failed: undef error - DBIC result _type isn't of the _type Aqbudget at /home/koha/Koha/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt line 157 This patch makes changes to column aqbudgets.budget_period_id so that it no longer allows NULL values. This is in line with aqbudgets tables foreign key "budget_period_id" which has ON DELETE CASCADE clause. To test: 1. Run prove t/db_dependent/Koha/Acquisition/Fund.t => Tests should fail 2. Run updatedatabase.pl and restart services if needed 3. Rerun prove t/db_dependent/Koha/Acquisition/Fund.t => Tests should now pass Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 09:00:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 08:00:14 +0000 Subject: [Koha-bugs] [Bug 32132] Missing budget_period_id in aqbudgets kills lateorders.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32132 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 09:13:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 08:13:53 +0000 Subject: [Koha-bugs] [Bug 35940] Cypress tests for the Preservation module are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35940 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 09:13:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 08:13:54 +0000 Subject: [Koha-bugs] [Bug 35940] Cypress tests for the Preservation module are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35940 --- Comment #5 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 09:21:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 08:21:20 +0000 Subject: [Koha-bugs] [Bug 35985] New: ./t/db_dependent/check_sysprefs.t --showsql since Bug 34979 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35985 Bug ID: 35985 Summary: ./t/db_dependent/check_sysprefs.t --showsql since Bug 34979 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org With Bug 34979 looks like we need to adapt ./t/db_dependent/check_sysprefs.t --showsql Example : kohadev-koha at kohadevbox:koha(master)$ ./t/db_dependent/check_sysprefs.t --showsql 1..2 # Subtest: Compare database with sysprefs.sql file ('MARCOrgCode','OSt','','Define MARC Organization Code for MARC21 records - http://www.loc.gov/marc/organizations/orgshome.html','free'), 1..0 # No tests run! not ok 1 - No tests run for subtest "Compare database with sysprefs.sql file" # Failed test 'No tests run for subtest "Compare database with sysprefs.sql file"' # at ./t/db_dependent/check_sysprefs.t line 53. # Subtest: Compare sysprefs.sql with YAML files 1..2 ok 1 - No system preference entries missing from sysprefs.sql ok 2 - No system preference entries missing from YAML files ok 2 - Compare sysprefs.sql with YAML files # Looks like you failed 1 test of 2. Too much verbose. Should we skip subtest "Compare database with sysprefs.sql file" ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 09:21:28 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 08:21:28 +0000 Subject: [Koha-bugs] [Bug 35985] ./t/db_dependent/check_sysprefs.t --showsql since Bug 34979 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35985 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34979 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 [Bug 34979] System preferences missing from sysprefs.sql -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 09:21:28 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 08:21:28 +0000 Subject: [Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35985 [Bug 35985] ./t/db_dependent/check_sysprefs.t --showsql since Bug 34979 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 09:29:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 08:29:37 +0000 Subject: [Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 --- Comment #49 from Katrin Fischer --- I have pushed the first patch yesterday as a compromise and to get this moving. So far, Jenkins seems happy, but as this was a random failure, we are not totally out of the woods yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 09:32:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 08:32:14 +0000 Subject: [Koha-bugs] [Bug 35962] t/db_dependent/Koha/BackgroundJob.t failing on D10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35962 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 09:32:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 08:32:19 +0000 Subject: [Koha-bugs] [Bug 35962] t/db_dependent/Koha/BackgroundJob.t failing on D10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35962 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 09:33:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 08:33:57 +0000 Subject: [Koha-bugs] [Bug 35962] t/db_dependent/Koha/BackgroundJob.t failing on D10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35962 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 09:33:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 08:33:59 +0000 Subject: [Koha-bugs] [Bug 35962] t/db_dependent/Koha/BackgroundJob.t failing on D10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35962 --- Comment #2 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 09:37:28 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 08:37:28 +0000 Subject: [Koha-bugs] [Bug 35985] ./t/db_dependent/check_sysprefs.t --showsql since Bug 34979 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35985 --- Comment #1 from Katrin Fischer --- I wrote the patch, but the different comparisons are confusing :( Happy to have some help with the fix really. I think the --showsql is to help fix an already found problem, so it probably makes sense to skip tests when the script is run with this parameter. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 10:46:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 09:46:31 +0000 Subject: [Koha-bugs] [Bug 35962] t/db_dependent/Koha/BackgroundJob.t failing on D10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35962 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #3 from Katrin Fischer --- It looks like D10 is still unhappy - could you have another look at it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 10:53:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 09:53:06 +0000 Subject: [Koha-bugs] [Bug 34893] ILS-DI can return the wrong patron for AuthenticatePatron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34893 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Product|Koha security |Koha Group|Koha security | Version|unspecified |master Component|Koha |Web services Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:06:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 10:06:36 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #89 from Katrin Fischer --- Tests were green when I ran them locally. so maybe something has changed, can you please check on this fail? https://jenkins.koha-community.org/job/Koha_Master/lastCompletedBuild/testReport/(root)/Should%20load%20the%20next%20page%20on%20scroll/Infinite_scroll_Should_load_the_next_page_on_scroll/ koha_1 | Running: InfiniteScrollSelect_spec.ts (1 of 13) koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:06:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 10:06:42 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:13:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 10:13:42 +0000 Subject: [Koha-bugs] [Bug 22322] Self-checkin module should provide for automatic logins (like self-checkout) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 --- Comment #14 from Emmi Takkinen --- (In reply to Stina Hallin from comment #12) > I tried to sign off, but the checkin was not always returned successfully > when I checked the patron details. Sometimes it worked as it should, but I > didn't manage to see why it worked sometimes, and sometimes failed. I tried > waiting until the sco-page logged out, and sometimes it worked on the first > try but not the next. I tried using both the Submit button and return key. > Once it worked when I changed home library for the patron. I'm unable to repeat this. I was able to return several loans of several different patrons. Both items and patrons had different homebranch than library I was logged in on sco-page. Patch needs rebase, so I'll do that and set this back "Needs Signoff" to get more feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:24:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 10:24:07 +0000 Subject: [Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display local cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207 --- Comment #25 from Andreas Roussos --- (In reply to Lucas Gass from comment #24) > Is this still being worked on? Hi, Lucas! I'm really sorry for the lack of any response on this bug :-( The TL;DR version is that it's all due to bad communication on my part (I should have asked for further clarifications before setting off to rewrite my patch). I actually tried to follow-up on this after Jonathan's latest feedback in Comment 21. However, in my revised patch I had to modify more than just localcovers.js and opac-image.pl since I couldn't figure out how to implement the suggested fallback parameter. So, I left this idle for a while until I could fix it properly and then, unfortunately, it fell under the radar. I'll ask for Jonathan's advice ASAP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:24:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 10:24:32 +0000 Subject: [Koha-bugs] [Bug 22322] Self-checkin module should provide for automatic logins (like self-checkout) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140162|0 |1 is obsolete| | --- Comment #15 from Emmi Takkinen --- Created attachment 161722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161722&action=edit Bug 22322: Self check-in without log in One should be able to return loans via SCO without login required. This patch adds check in box where patrons can check in their loans with barcode. To test: 1. Set "SelfCheckoutByLogin" as "cardnumber". 2. Find patron with loan or add one. 3. Go to /cgi-bin/koha/sco/sco-main.pl 4. Return loan by passing items barcode => confirm loans is returned succesfully Sponsored-by: Koha-Suomi Oy Signed-off-by: Lucy Vaux-Harvey -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:24:58 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 10:24:58 +0000 Subject: [Koha-bugs] [Bug 22322] Self-checkin module should provide for automatic logins (like self-checkout) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150776|0 |1 is obsolete| | --- Comment #16 from Emmi Takkinen --- Created attachment 161723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161723&action=edit Bug 22322: Fix QA issues This patch fixes following QA issues: - Add missing filters - Use dt_from_string instead of DateTime->now in sco-main.pl Following issue is left unchanged, since it is purposeful: forbidden pattern: Script permissions is authnotrequired => 0, it could be correct for an OPAC script if it is was you really want error Sponsored-by: Koha-Suomi Oy Signed-off-by: hinemoea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:25:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 10:25:06 +0000 Subject: [Koha-bugs] [Bug 22322] Self-checkin module should provide for automatic logins (like self-checkout) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:28:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 10:28:04 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #90 from Matt Blenkinsop --- Passes locally for me too but I think telling cypress to wait for the intercepted requests for pages two and three may help. I'll add a follow-up patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:30:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 10:30:14 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #91 from Matt Blenkinsop --- Created attachment 161724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161724&action=edit Bug 32474: (follow-up): Tell the tests to wait for the intercepted request responses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:36:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 10:36:42 +0000 Subject: [Koha-bugs] [Bug 35630] Add ability to log changes to Authorized Values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 Alban Peyrat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alban.peyrat_koha at yahoo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:54:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 10:54:46 +0000 Subject: [Koha-bugs] [Bug 35277] Pseudonymization should be done in a background job In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35277 --- Comment #28 from Fridolin Somers --- OK i give it a try -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 12:45:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 11:45:42 +0000 Subject: [Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 13:37:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 12:37:39 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #92 from Katrin Fischer --- Thanks Matt, follow-up pushed - now we need to wait and see :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 14:43:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 13:43:14 +0000 Subject: [Koha-bugs] [Bug 34893] ILS-DI can return the wrong patron for AuthenticatePatron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34893 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Product|Koha security |Koha Component|Koha |Web services Version|unspecified |23.11 Group|Koha security | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 14:43:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 13:43:55 +0000 Subject: [Koha-bugs] [Bug 34893] ILS-DI can return the wrong patron for AuthenticatePatron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34893 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 14:48:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 13:48:06 +0000 Subject: [Koha-bugs] [Bug 34893] ILS-DI can return the wrong patron for AuthenticatePatron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34893 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 14:49:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 13:49:20 +0000 Subject: [Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display local cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207 --- Comment #26 from Andreas Roussos --- (In reply to Jonathan Druart from comment #21) Hi, Jonathan! I'm sorry for the (much) belated reply. As per my previous message to Lucas, I realise this bug has been left lingering for too long. I'm keen to move this forward, so please see my comments inline below: > + [% IF itemloop_has_images OR otheritemloop_has_images %] > + KOHA.LocalCover.GetCoverFromItemnumber(true); > + [% END %] > > > This is not correct, that's not what we want here. > > You don't want to get the image at the item level if the *current* biblio > has image at the item level. Fair point, I agree. To decide which local cover image to display for the items shown in the shelf browser we shouldn't look at the current biblio but rather handle each item independently. In fact, I think that the algorithm should operate as follows: 1) If only a biblio-level image exists: => show that for all biblio items 2) If only item-level images exist: => show the respective image for each item 3) If both biblio-level and item-level images exist: => show the item-level image for the items that have one => fall back to the biblio-level image for all other items > If you want to implement that you need to: > 1. Create a new JS function in localcovers.js (say > GetCoverFromItemnumberOrBibnumber) that would call opac-image.pl with a new > parameter (say biblio-fallback=1) > 2. Modify opac-image.pl to retrieve this parameter and return > $item->cover_image || $biblio->cover_image I'm afraid this is the part that I don't understand fully ;-) When would this new biblio-fallback parameter be set? And how would it work in conjunction with opac-image.pl? As per the DESCRIPTION section of opac-image.pl, the script currently accepts an imagenumber or a biblionumber, returning a random image if the latter was provided (side note: I think it's not actually 100% random but rather the first cover image): 72 elsif ( defined $biblionumber ) { 73 my $biblio = Koha::Biblios->find($biblionumber); 74 unless ($biblio) { 75 print $input->redirect("/cgi-bin/koha/errors/404.pl"); 76 exit; 77 } 78 my $cover_images = $biblio->cover_images; 79 if ( $cover_images->count ) { 80 $image = $cover_images->next; 81 } 82 } AIUI, unless we modify opac-image.pl to also accept an itemnumber parameter we have no way of implementing the cover image selection algorithm I described above. To do this I actually had to also modify opac-detail.tt, shelfbrowser.inc, and C4/ShelfBrowser.pm. > The selenium test could also cover this situation :) OK, I reckon that should be easy to implement since we already have a test action that uploads an item-level local cover image. What's left to be done is to write some more tests to check if the correct local cover image is returned in each situation. > Does that make sense? I think what confused me in the past (not your fault!) was that you mentioned two changes that needed to be made (localcovers.js and opac-image.pl), and because I had to change more files I considered my revised patch a failure. Apologies for not asking for your feedback earlier. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 14:51:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 13:51:08 +0000 Subject: [Koha-bugs] [Bug 34893] ILS-DI can return the wrong patron for AuthenticatePatron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34893 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.02,23.05.08 |24.05.00,23.11.02,23.05.08, released in| |22.11.14 Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 14:51:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 13:51:39 +0000 Subject: [Koha-bugs] [Bug 34893] ILS-DI can return the wrong patron for AuthenticatePatron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34893 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.02,23.05.08, |24.05.00,23.11.02,23.05.08, released in|22.11.14 |22.11.14,22.05.18 Status|Pushed to oldoldstable |Pushed to oldoldoldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 15:14:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 14:14:36 +0000 Subject: [Koha-bugs] [Bug 35986] New: Add plugin hook for adding to OPAC item display Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35986 Bug ID: 35986 Summary: Add plugin hook for adding to OPAC item display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org Add a new cell on the right of every row in the table that displays item information on detail pages in the OPAC. The content of the cell should be rendered by a plugin. Use case: Link to a shelf map. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 15:31:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 14:31:41 +0000 Subject: [Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #24 from Barbara Johnson --- Forgot to set the status to Failed QA after testing the bug yesterday. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 15:50:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 14:50:12 +0000 Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 --- Comment #25 from Martin Renvoize --- Such a shame things like this just die instead of getting support. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 15:55:34 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 14:55:34 +0000 Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 --- Comment #26 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #20) > Also.. should I work through and try to replace ALL calls to > ->metadata->record with ->metadata_record.. and check for superfluous > RecordProcessor instantiations now we can do it inline? I'm sorry. Yes to all your suggestions :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 16:35:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 15:35:59 +0000 Subject: [Koha-bugs] [Bug 31327] Add color scheme picker to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31327 --- Comment #7 from David Liddle --- I've was working some more on our own OPAC customizations, and not being a web developer or design professional, I had cause to look up some aspects of CSS. It was then that I learned about CSS variables. (See https://www.w3schools.com/css/css3_variables.asp.) It occurred to me that CSS variables for colors could make Koha theming really easy. There *is* a list of such variables listed in the ":root" section of opac.css, but it seems that none of them are in use. Instead, colors are specified directly by each rule. If a default color palette was formed for the Koha OPAC, and the CSS contained something like this: :root { --kColor1: #abcdef --kColor2: #fedcba --kColor3: #123456 --kColor4: #654321 ... } AND the CSS rules in opac.css (and others) were edited to *always* refer to colors by way of variables, then a *basic* theme variation would simply need to change those variables. The change could come by way of OPACUserCSS, a custom CSS file, a built-in light/dark mode switcher, or a plugin. Some color variants can be created programmatically – e.g. lighter or darker, shades or tints – so they wouldn't have to exist as separate variables. The color-mix() function is a good example of this. (See https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/color-mix.) As I wrote, I'm not a web pro, so I could be wrong, or there could be a more efficient way. In some ways, I'm just recording my own thoughts on the matter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 17:06:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 16:06:00 +0000 Subject: [Koha-bugs] [Bug 5920] Remove HTML from downloaded reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 --- Comment #16 from Andrew Fuerste-Henry --- Martin, can you please provide a test plan? What I've tried doesn't seem to work, but perhaps I'm misunderstanding your intent. Here's what I did: - apply patch - cpan HTML:Restrict - restart_all - create a new report from SQL: "select concat('

','Hello world','

') as message" - run report - click Download, select CSV format - open csv in text editor I expected my CSV to contain "Hello world" without the tags, but I got: message "

Hello world

" I also tried: SELECT biblionumber, CONCAT('',title,'') AS Title from biblio and ended up with a csv containing: biblionumber,Title 12484,"The mask" -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 17:10:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 16:10:05 +0000 Subject: [Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in| | --- Comment #26 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 17:11:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 16:11:24 +0000 Subject: [Koha-bugs] [Bug 35774] add_item_to_item_group additem.pl should be $item->itemnumber instead of biblioitemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35774 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.03 |24.05.00,23.11.03,23.05.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 17:12:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 16:12:16 +0000 Subject: [Koha-bugs] [Bug 35634] Permissions mismatch for vendor issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35634 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com Resolution|--- |FIXED --- Comment #6 from Lucas Gass --- Missing 23.05.x dependencies. NO backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 17:18:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 16:18:06 +0000 Subject: [Koha-bugs] [Bug 35504] Release team 24.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in| | --- Comment #40 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 17:18:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 16:18:54 +0000 Subject: [Koha-bugs] [Bug 35759] Preservation module home yields a blank page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35759 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 17:20:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 16:20:01 +0000 Subject: [Koha-bugs] [Bug 35475] Untranslatable strings in booking modal and JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #13 from Lucas Gass --- Missing 23.05.x dependencies, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 17:21:28 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 16:21:28 +0000 Subject: [Koha-bugs] [Bug 35756] Wrong use of encodeURIComponent in patron-search.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35756 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in| | CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 17:23:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 16:23:39 +0000 Subject: [Koha-bugs] [Bug 34999] REST API: Public routes should respect OPACMaintenance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34999 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in| | --- Comment #19 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 17:24:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 16:24:06 +0000 Subject: [Koha-bugs] [Bug 5920] Remove HTML from downloaded reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 --- Comment #17 from Andrew Fuerste-Henry --- Clearly I've doing this too early in the morning. I applied your patches to my testing docker and then ran my reports on the wrong Koha. When I follow my test plan correctly, this works! However, for my test report: SELECT biblionumber, CONCAT('',title,'') AS Title from biblio When I download CSV or ODS formats, the second column contains just the title. When I download TSV format, the second column contains just the biblionumber (so the report is two columns of the same data). It'd be best if all 3 options work the same way. But I'm happy to sign off on this and pursue that consistency in a new bug if desired; this is absolutely useful as-is. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 17:25:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 16:25:35 +0000 Subject: [Koha-bugs] [Bug 5920] Remove HTML from downloaded reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 --- Comment #18 from Andrew Fuerste-Henry --- It would also be great to have HTML-stipping available in reports run and emailed via the commandline. Martin, is that reasonably easy to add here, or would you rather I file a new bug? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 17:26:33 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 16:26:33 +0000 Subject: [Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in| | --- Comment #25 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 17:31:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 16:31:38 +0000 Subject: [Koha-bugs] [Bug 35702] Reduce DB calls when performing authorities merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35702 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in| | CC| |lucas at bywatersolutions.com --- Comment #10 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 17:34:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 16:34:15 +0000 Subject: [Koha-bugs] [Bug 5920] Remove HTML from downloaded reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 --- Comment #19 from George Williams (NEKLS) --- I want to reiterate that whether or not the HTML is stripped from a report when it's downloaded should be optional. There are times that I actually want the raw HTML output in a downloaded report. Example: I have reports that a library can run and download that has HTML in the output so that the raw HTML can then be cut and pasted into the library's website. If this patch strips all of the HTML tags from -all- downloaded report output, then I'm going to have to re-write those reports to find a new way to create the raw HTML when I actually want the raw HTML output. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 17:40:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 16:40:17 +0000 Subject: [Koha-bugs] [Bug 5920] Optionally remove HTML from downloaded reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove HTML from downloaded |Optionally remove HTML from |reports |downloaded reports --- Comment #20 from Andrew Fuerste-Henry --- (In reply to George Williams (NEKLS) from comment #19) > I want to reiterate that whether or not the HTML is stripped from a report > when it's downloaded should be optional. Well-reiterated, thank you! Would you prefer a global option for this, or something more granular? As someone who probably never wants to export the HTML, I'd hate to add a to every report download in order to opt for stripping the HTML at that point. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 18:46:56 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 17:46:56 +0000 Subject: [Koha-bugs] [Bug 32477] Hiding batch item modification columns isn't remembered correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32477 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #23 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 18:49:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 17:49:11 +0000 Subject: [Koha-bugs] [Bug 35438] Importing records can create too large transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35438 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in| | Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #13 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 18:50:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 17:50:31 +0000 Subject: [Koha-bugs] [Bug 25691] Debian packages point to /usr/share/doc/koha/README.Debian which does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25691 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #13 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 18:50:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 17:50:52 +0000 Subject: [Koha-bugs] [Bug 35772] Double escaping of patron fields in bookings modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35772 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 18:51:25 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 17:51:25 +0000 Subject: [Koha-bugs] [Bug 35676] OPAC search results - link for "Check for suggestions" generates a blank page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35676 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 18:52:28 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 17:52:28 +0000 Subject: [Koha-bugs] [Bug 35641] Reduce DB calls when performing inventory on a list of barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35641 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in| | CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 18:53:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 17:53:39 +0000 Subject: [Koha-bugs] [Bug 35510] Non-patron guarantor missing from CollapseFieldsPatronAddForm options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35510 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in| | --- Comment #9 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 18:55:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 17:55:19 +0000 Subject: [Koha-bugs] [Bug 34950] ILS DI Availability is not accurate for items on holds shelf or in transit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34950 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in| | --- Comment #13 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 18:55:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 17:55:46 +0000 Subject: [Koha-bugs] [Bug 35651] Toggle for advanced editor should not show to staff without advanced_editor permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35651 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 19:00:25 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 18:00:25 +0000 Subject: [Koha-bugs] [Bug 35322] AllowItemsOnHoldCheckoutSCO and AllowItemsOnHoldCheckoutSIP do not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35322 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in| | CC| |lucas at bywatersolutions.com --- Comment #13 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 19:01:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 18:01:49 +0000 Subject: [Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in| | --- Comment #48 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 19:03:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 18:03:05 +0000 Subject: [Koha-bugs] [Bug 35474] Add icon for protected patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35474 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in| | --- Comment #7 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 19:03:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 18:03:48 +0000 Subject: [Koha-bugs] [Bug 35687] Upgrade to 23.06.00.013 may fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #29 from Lucas Gass --- Missing 23.05.x dependencies. No backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 19:19:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 18:19:27 +0000 Subject: [Koha-bugs] [Bug 34479] Clear saved patron search selections after certain actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|24.05.00,23.11.03 |24.05.00,23.11.03,23.05.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #32 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 20:43:56 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 19:43:56 +0000 Subject: [Koha-bugs] [Bug 5920] Optionally remove HTML from downloaded reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 --- Comment #21 from George Williams (NEKLS) --- How about switching the "Download" drop-down from a list of options to a checkbox drop-down that allows the user to specify the format and whether or not HTML is stripped from the output. That would be the most granular way of going about it. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 21:20:34 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 20:20:34 +0000 Subject: [Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 21:20:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 20:20:36 +0000 Subject: [Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157133|0 |1 is obsolete| | --- Comment #12 from Andrew Fuerste-Henry --- Created attachment 161725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161725&action=edit Bug 32702: Move item status checks to CanItemBeReserved This patch moves item status checks from IsAvailableForItemLevelRequest to CanItemBeReserved. Changes to existing calls highlighted below. Existing Calls for CanItemBeReserved/CanBookBeReserved: Call in Circulation.pm checkHighHolds - previously would have allowed damaged, notforloan, etc items to fill holds CanBookBeRenewed - Already a combination of CanItemBeReserved and IsAvailableForItemLevelRequest Call in ILSDI/Services.pm HoldItem - would have allowed placing holds on damaged/notforloan/etc items GetServices - Already a combination of CanItemBeReserved and IsAvailableForItemLevelRequest C4/Reserves: What is ItemsAnyAvailableAndNotRestricted used for C4/SIP/ILS/Transaction/Hold.pm: do_hold - would have allowed hold on lost/damaged/etc. Koha/Club/Hold/pm: add - would have allowed etc. Koha/REST/V1/Holds.pm: add - would have allowed ... opac/opac-reserve.pl: Was already combo of CanItemBeReserved and IsAvailableForItemLevelRequest reserve/placerequest: Items would have been filtered on reserve/request.pl by IsAvailableForItemLevelRequest In this case and opac, I believe before this a hold could have been forced with the right parameters Existing Calls for IsAvailableForItemLevelRequest C4/Circulation - see above Call in opac/opac-reserve.pl: Already a combination of CanItemBeReserved and IsAvailableForItemLevelRequest Call in reserve/request.pl: Already a combination of CanItemBeReserved and IsAvailableForItemLevelRequest To test: 1 - Setup a record with items to have: 1 available item 1 lost item 1 item with positive not for loan status 1 item with negative not for loan status 1 item withdrawn 1 item damaged 1 item not for loan by itemtype 2 - Attempt to place hold on staff and opac and note the statuses 3 - Apply patch 4 - Confirm the statuses have not changed 5 - Attempt to hold lost/damaged/withdrawn/notforloan items via API 6 - You should not be able to place the hold 7 - Attempt to place club holds on these items - it should not be possible 8 - Attempt to place holds via ILSDI - it should not be possible Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 21:20:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 20:20:38 +0000 Subject: [Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157134|0 |1 is obsolete| | --- Comment #13 from Andrew Fuerste-Henry --- Created attachment 161726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161726&action=edit Bug 32702: Unit tests Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 21:24:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 20:24:50 +0000 Subject: [Koha-bugs] [Bug 35653] Allow the patron import script to log it's output to the action_logs cron logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35653 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160384|0 |1 is obsolete| | --- Comment #3 from Emily Lamancusa --- Created attachment 161727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161727&action=edit Bug 35653: Log import_patroni.pl info to action logs To test: 1. APPLY PATCH 2. Create a CSV file with a few lines that contain at least firstname, surname, cardnumber 3. Turn on "CronjobLog". 4. Run the import patron script. I did this: perl /kohadevbox/koha/misc/import_patrons.pl --file 'test1.csv' --matchpoint cardnumber -c 5. Check the action logs for cronjobs. 6. You should see info. about the import patron script. Signed-off-by: David Nind Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 21:24:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 20:24:52 +0000 Subject: [Koha-bugs] [Bug 35653] Allow the patron import script to log it's output to the action_logs cron logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35653 --- Comment #4 from Emily Lamancusa --- Created attachment 161728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161728&action=edit Bug 35653: (QA follow-up) Perltidy Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 21:25:25 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 20:25:25 +0000 Subject: [Koha-bugs] [Bug 35653] Allow the patron import script to log it's output to the action_logs cron logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35653 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |emily.lamancusa at montgomeryc | |ountymd.gov QA Contact|testopia at bugs.koha-communit |emily.lamancusa at montgomeryc |y.org |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 21:38:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 20:38:12 +0000 Subject: [Koha-bugs] [Bug 14180] Make "Always show checkouts immediately" a global setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |andrewfh at dubcolib.org --- Comment #29 from Andrew Fuerste-Henry --- This looks like maybe it should have been set to Signed Off when Kelly tested it 1/26. As of today, the patch doesn't apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 21:54:34 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 20:54:34 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_35816=5D_Email_Notification_Alert_f?= =?utf-8?q?or_Purchase_Suggestion_don=E2=80=99t_properly_work?= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35816 S Martin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |smartin at lancasterseminary.e | |du -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 21:56:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 20:56:57 +0000 Subject: [Koha-bugs] [Bug 23208] Built in Holds Ratio Report - default ratio set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23208 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 21:56:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 20:56:59 +0000 Subject: [Koha-bugs] [Bug 23208] Built in Holds Ratio Report - default ratio set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23208 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161557|0 |1 is obsolete| | --- Comment #9 from Andrew Fuerste-Henry --- Created attachment 161729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161729&action=edit Bug 23208: Add system preference HoldRatioDefault Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 21:57:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 20:57:01 +0000 Subject: [Koha-bugs] [Bug 23208] Built in Holds Ratio Report - default ratio set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23208 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161558|0 |1 is obsolete| | --- Comment #10 from Andrew Fuerste-Henry --- Created attachment 161730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161730&action=edit Bug 23208: Add ability to set a default hold ratio value To test: 1. APPLY PATCH, updatedatebase, restart_all 2. Search for the system preference 'HoldRatioDefault'. 3. It should be set to 3. Change the value to something else. 4. Load the report at 'circ/reserveratios.pl'. Circulation > Hold ratios 5. The default value should be the value you set in the new system preference. 6. Run the report with the default value and make sure it works. 7. Change the value and run the report. The new value should be retained. 8. Leave the page and come back. Again the default value from the new system preference should be set. Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 21:57:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 20:57:04 +0000 Subject: [Koha-bugs] [Bug 23208] Built in Holds Ratio Report - default ratio set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23208 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161559|0 |1 is obsolete| | --- Comment #11 from Andrew Fuerste-Henry --- Created attachment 161731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161731&action=edit Bug 23208: perltidy Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 21:58:56 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 20:58:56 +0000 Subject: [Koha-bugs] [Bug 35854] Suggestions generate identical messages when edited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35854 S Martin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |smartin at lancasterseminary.e | |du --- Comment #3 from S Martin --- I'm also having this problem. The suggestion accepted message is sent to patrons whenever something in the record is edited. It's also being sent when the suggestion is marked as ordered (the suggestion ordered notice is sent, and the suggestion accepted message is being sent again at the same time.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 22:14:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 21:14:15 +0000 Subject: [Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 22:27:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 21:27:30 +0000 Subject: [Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 22:27:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 21:27:32 +0000 Subject: [Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161613|0 |1 is obsolete| | --- Comment #30 from Andrew Fuerste-Henry --- Created attachment 161732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161732&action=edit Bug 35840: Add option to AddReturn to skip recording of localuse To test: 1. APPLY PATCH, restart_all 2. Turn on RecordLocalUseOnReturn 3. Create a Statistical patron. 4. Check an item out to a regular patron. 5. Check the item out to a Statistical patron. 6. This should trigger a return and you will see 2 entries in the statistics table, one for localuse and one for a return. 7. Try checking out an item to the Stats patron that is NOT checked out. 8. You should only see 1 entry, localuse, in the statistics table. Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 22:27:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 21:27:35 +0000 Subject: [Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161614|0 |1 is obsolete| | --- Comment #31 from Andrew Fuerste-Henry --- Created attachment 161733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161733&action=edit Bug 35840: Add unit tests Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 22:39:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 21:39:17 +0000 Subject: [Koha-bugs] [Bug 35924] The 'checkin slip' button should not be available for patrons whose privacy is set to never In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35924 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 22:39:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 21:39:19 +0000 Subject: [Koha-bugs] [Bug 35924] The 'checkin slip' button should not be available for patrons whose privacy is set to never In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35924 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161592|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry --- Created attachment 161734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161734&action=edit Bug 35924: Hide the print checkins button on the patron screens for patron's who always anonymize If a patron anonymizes their checkins, the checkin slip cannot retrieve any info to print the checkin slip. We should not show the button in this scenario Test Plan: 1) Set a patron's privacy to "Never" 2) Note the "Print checkin slip" option in the Print button on the patrons toolbar displays 3) Apply this patch 4) Reload the page 5) Note the option is now missing 6) Set the patron's privacy to "Forever" or "Default" 7) Reload the page 8) Note the print checkins option is back! Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 22:39:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 21:39:21 +0000 Subject: [Koha-bugs] [Bug 35924] The 'checkin slip' button should not be available for patrons whose privacy is set to never In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35924 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161593|0 |1 is obsolete| | --- Comment #4 from Andrew Fuerste-Henry --- Created attachment 161735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161735&action=edit Bug 35924: Hide the print checkins button on the checkin screen for patron's who always anonymize Test Plan: 1) Set a patron's privacy to "Never" 2) Check out a few items to a patron 3) Check in one item 4) Note the "Print checkin slip" diplays 3) Apply this patch 4) Check in an item 5) Note the option is now missing 6) Set the patron's privacy to "Forever" or "Default" 7) Check in an item 8) Note the print checkins option is back! Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 22:51:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 21:51:38 +0000 Subject: [Koha-bugs] [Bug 35134] cn_browser.pl pop-up size should be configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35134 Phil Ringnalda changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil at chetcolibrary.org --- Comment #4 from Phil Ringnalda --- Sizing relative to screen width/height gives reasonable results on a laptop screen (where I'm typically using window size close to screen size), but on a decent size monitor it gets pretty comical. I don't have a monitor quite big enough to catalog in a window that's less than half the screen width, but plenty of people do, which would result in a popup that completely covers the parent window. And since the plugin only displays a fixed number of results, screen height makes it look like a mistake, with two-thirds of the window height just blank. Half the parent window width and the parent window height would eliminate covering the parent window, and give people with more space who need it bigger an easy way to get it: just increase the size of the window you are cataloging in and the popups will be bigger. Makes me wonder what screen height is for a Safari window in VisionOS. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 22:57:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 21:57:13 +0000 Subject: [Koha-bugs] [Bug 25667] Add field for items.notforloan_on to record when a notforloan status is applied In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25667 Sara Porter changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com --- Comment #4 from Sara Porter --- *** Bug 34699 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 22:57:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 21:57:13 +0000 Subject: [Koha-bugs] [Bug 34699] add a notforloan_on column in items table to store the date of last notforloan change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34699 Sara Porter changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |sara.porter at bywatersolution | |s.com Resolution|--- |DUPLICATE --- Comment #1 from Sara Porter --- *** This bug has been marked as a duplicate of bug 25667 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 22:58:44 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 21:58:44 +0000 Subject: [Koha-bugs] [Bug 25667] Add field for items.notforloan_on to record when a notforloan status is applied In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25667 Sara Porter changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sara.porter at bywatersolution | |s.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 23:05:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 22:05:09 +0000 Subject: [Koha-bugs] [Bug 35987] New: See highlighted items below link broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35987 Bug ID: 35987 Summary: See highlighted items below link broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: lisette.scheer at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com On circulation.pl and moremember.pl the "see highlighted items below" link goes to #checkouts, but there is no div #checkouts instead of #checkouts_panel -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 23:37:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 22:37:46 +0000 Subject: [Koha-bugs] [Bug 25825] Allow claim return function to be controlled by permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25825 Marie-Luce Laflamme changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie-luce.laflamme at inlibro | |.com --- Comment #7 from Marie-Luce Laflamme --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 3 00:01:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2024 23:01:12 +0000 Subject: [Koha-bugs] [Bug 35988] New: Record of deleted item not recorded in action logs even if record wasn't deleted Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35988 Bug ID: 35988 Summary: Record of deleted item not recorded in action logs even if record wasn't deleted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: lisette.scheer at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Created attachment 161736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161736&action=edit Screenshot of object column for deleted items. When an item is deleted, it shows in the action logs that "Item number was deleted from Bibliographic record " There is no indication of which bibliographic record the item was attached to, even when the record still exists. Both links are useless as the items have been deleted the bibliographic link has no number associated with it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 3 22:29:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Feb 2024 21:29:12 +0000 Subject: [Koha-bugs] [Bug 32137] Use current patron contact info when resending notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32137 Lauren Denny changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lauren_denny at sil.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 20:38:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2024 19:38:38 +0000 Subject: [Koha-bugs] [Bug 24710] patron-title.inc should have seperate span classes for firstname, othername, surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710 Steve, OSLRI, USA changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sspohn at oslri.net --- Comment #23 from Steve, OSLRI, USA --- We are interested in this bug moving ahead. We are using "borrowers.othernames" to store what we are calling "legal name if different". Our primary intent is to serve trans patrons who may not have yet legally changed names. We would like this field in the system. However, we want to dramatically reduce where and how it displays. E.g., there is no need to see it when simply checking out a book. In fact, it's really only necessary when confirming ID, pursuing legal action or editing the patron's record. The ability to more finely control how a name displays would be advantageous to us for this purpose. Hope this helps! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 23:21:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2024 22:21:35 +0000 Subject: [Koha-bugs] [Bug 35880] Use template wrapper for accordions: Patrons requesting modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35880 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 23:21:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2024 22:21:37 +0000 Subject: [Koha-bugs] [Bug 35880] Use template wrapper for accordions: Patrons requesting modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35880 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161329|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 161737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161737&action=edit Bug 35880: Use template wrapper for accordions: Patrons requesting modifications This patch updates the patrons requesting modification page so that Bootstrap accordion markup is generated by WRAPPERs. To test, apply the patch and make sure you have the OPACPatronDetails system preference enabled. - Create at least two different patron modification requests: - Log in to the OPAC using two different patron accounts, each time following the sidebar link for "Personal details." - Make some changes to the patron records and submit them. - In the staff interface, from the home page, click the "Patrons requesting modifications" link. - You should see the list of updates in the same format as before: Collapsible panels where clicking the patron name heading expands the corresponding information. - View the detail or checkout page for one of your updated patrons. - Click the "Review pending modifications" link. - The modifications page should open with that patron's information exapanded. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 23:29:33 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2024 22:29:33 +0000 Subject: [Koha-bugs] [Bug 35882] Use template wrapper for accordions: Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35882 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 23:29:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2024 22:29:36 +0000 Subject: [Koha-bugs] [Bug 35882] Use template wrapper for accordions: Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35882 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161330|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 161738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161738&action=edit Bug 35882: Use template wrapper for accordions: Notices This patch updates the notices template so that Bootstrap accordion markup for the notice edit view is generated by WRAPPERs. To test, apply the patch and go to Tools -> Notices. - Edit any notice. - The list of message transport types (Email, Print, SMS) should be displayed as before: Collapsible panels where clicking the transport type heading expands the corresponding information. - Confirm that changes to notices are correctly saved. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 23:38:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2024 22:38:40 +0000 Subject: [Koha-bugs] [Bug 35883] Use template wrapper for accordions: Table settings administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35883 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david at davidnind.com --- Comment #2 from David Nind --- The patch no longer applies 8-(... ... Applying: Bug 35883: Use template wrapper for accordions: Table settings administration Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 35883: Use template wrapper for accordions: Table settings administration ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 23:41:25 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2024 22:41:25 +0000 Subject: [Koha-bugs] [Bug 35877] Use template wrapper to build Bootstrap accordion components In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35877 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 23:41:28 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2024 22:41:28 +0000 Subject: [Koha-bugs] [Bug 35877] Use template wrapper to build Bootstrap accordion components In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35877 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161328|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 161739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161739&action=edit Bug 35877: Use template wrapper to build Bootstrap accordion components This patch adds Template::Toolkit WRAPPER blocks to html_helpers.inc so that templates can build Bootstrap accordion components while keeping the Bootstrap structural markup separate. Each individual component of a Bootstrap accordion interface is defined: - Group container - Collapsible item - Item heading - Item content Included is a usage example: [ WRAPPER accordion id="accordion container id" ] [ WRAPPER accordion_item ] [ WRAPPER accordion_heading panel_id = "panel id" ] [Clickable panel heading ] [ END ] [ WRAPPER accordion_panel panel_id = "panel id" ] [Expanding content panel] [ END ] [ END ] [ END ] To test, apply this patch and one of the dependent patches. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 06:54:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 05:54:22 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #80 from David Cook --- I was just looking at the Debian packaging logs and wondering why build-resources.PL gets run twice, but it's because it's run for "make" and "make install". And that's because in Makefile.PL there is the following line: install :: all install_koha set_koha_ownership set_koha_permissions warn_koha_env_vars I suppose if it really bothered us we could do something about it, but it doesn't really seem like a big issue. Wastes a bit of time, but better to do it too much than not enough... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 07:09:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 06:09:32 +0000 Subject: [Koha-bugs] [Bug 35989] New: Searching Geographic authorities generates error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35989 Bug ID: 35989 Summary: Searching Geographic authorities generates error Change sponsored?: --- Product: Koha Version: 23.11 Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: rcooper at inceptlabs.com.au QA Contact: testopia at bugs.koha-community.org 1) Search Authorities from the main view (/cgi-bin/koha/authorities/authorities-home.pl) 2) From Authority type drop down select Geographic Name 3) Leave the search field blank 4) Run the search 5) The following error is returned : Error: Unmatched [ in regex; marked by <-- HERE in m/^[ <-- HERE ]$/ at /usr/share/perl5/MARC/Field.pm line 643. Notes: This also happens when searching for a or Australia, but not when searching for Japan When searching using the Authority Search pop-up, an Error 500 is returned. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 09:18:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 08:18:45 +0000 Subject: [Koha-bugs] [Bug 35954] Add --status to koha-plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35954 --- Comment #1 from Magnus Enger --- Created attachment 161740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161740&action=edit Bug 35954: Add --status to koha-plack This adds a --status switch to the koha-plack command. To test on ktd: - Copy the script to /usr/sbin, so you run the modified script, and not the one installed by Koha: $ sudo cp debian/scripts/koha-plack /usr/sbin/ - Stop and start Plack for kohadev like so: $ sudo koha-plack --stop kohadev $ sudo koha-plack --start kohadev And make sure this reports the correct status, both when Plack is running and when it is not running: $ sudo koha-plack --status kohadev - Make sure --status is mentioned here: $ sudo koha-plack --help - See https://wiki.koha-community.org/wiki/Testing_man_pages for details on how to check the manual page for the command -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 09:19:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 08:19:16 +0000 Subject: [Koha-bugs] [Bug 35954] Add --status to koha-plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35954 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 09:19:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 08:19:18 +0000 Subject: [Koha-bugs] [Bug 35954] Add --status to koha-plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35954 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161740|0 |1 is obsolete| | --- Comment #2 from Magnus Enger --- Created attachment 161741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161741&action=edit Bug 35954: Add --status to koha-plack This adds a --status switch to the koha-plack command. To test on ktd: - Copy the script to /usr/sbin, so you run the modified script, and not the one installed by Koha: $ sudo cp debian/scripts/koha-plack /usr/sbin/ - Stop and start Plack for kohadev like so: $ sudo koha-plack --stop kohadev $ sudo koha-plack --start kohadev And make sure this reports the correct status, both when Plack is running and when it is not running: $ sudo koha-plack --status kohadev - Make sure --status is mentioned here: $ sudo koha-plack --help - See https://wiki.koha-community.org/wiki/Testing_man_pages for details on how to check the manual page for the command -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:15:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 09:15:17 +0000 Subject: [Koha-bugs] [Bug 35473] Core bookings and room reservations plugin tables clash In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35473 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160879|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 161742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161742&action=edit Bug 35473: Handle room reservations plugin conflict We now look for the existance of the room reservations 'bookings' table prior to attempting to install the core bookings table and migrate it in the same way the upstream plugin does before proceeding with installing the core bookings tables. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:15:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 09:15:20 +0000 Subject: [Koha-bugs] [Bug 35473] Core bookings and room reservations plugin tables clash In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35473 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161043|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 161743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161743&action=edit Bug 35473: Also disable the plugin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:15:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 09:15:30 +0000 Subject: [Koha-bugs] [Bug 35473] Core bookings and room reservations plugin tables clash In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35473 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:15:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 09:15:57 +0000 Subject: [Koha-bugs] [Bug 35473] Core bookings and room reservations plugin tables clash In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35473 --- Comment #11 from Martin Renvoize --- Tidied.. again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:19:58 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 09:19:58 +0000 Subject: [Koha-bugs] [Bug 35959] Inconsistent hierarchy during C3 merge of class 'Koha::AuthorisedValue' (and a few other modules) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35959 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28869 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 [Bug 28869] If authorized values for STACK (shelving control number) are > 127 things explode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:19:58 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 09:19:58 +0000 Subject: [Koha-bugs] [Bug 28869] If authorized values for STACK (shelving control number) are > 127 things explode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35959 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35959 [Bug 35959] Inconsistent hierarchy during C3 merge of class 'Koha::AuthorisedValue' (and a few other modules) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:20:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 09:20:12 +0000 Subject: [Koha-bugs] [Bug 28869] If authorized values for STACK (shelving control number) are > 127 things explode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:44:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 09:44:26 +0000 Subject: [Koha-bugs] [Bug 35990] New: [OMNIBUS] Improvements for using tinyint authorised values Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35990 Bug ID: 35990 Summary: [OMNIBUS] Improvements for using tinyint authorised values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com This omnibus relates to the work done on bug 28869 making it possible to restrict AV categories to 'tinyint' values (signed tinyint, -128 to 127). I am not doing all the work on that report. Bug 28869 is just the base point for further improvements. Listing a few suggestions on next comments. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:45:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 09:45:27 +0000 Subject: [Koha-bugs] [Bug 35990] [OMNIBUS] Improvements for using tinyint authorised values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35990 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28869 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 [Bug 28869] If authorized values for STACK (shelving control number) are > 127 things explode -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:45:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 09:45:27 +0000 Subject: [Koha-bugs] [Bug 28869] If authorized values for STACK (shelving control number) are > 127 things explode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35990 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35990 [Bug 35990] [OMNIBUS] Improvements for using tinyint authorised values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:46:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 09:46:49 +0000 Subject: [Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|If authorized values for |Optionally restrict |STACK (shelving control |authorised values to |number) are > 127 things |tinyint |explode | --- Comment #8 from Marcel de Rooy --- Renaming title from If authorized values for STACK (shelving control number) are > 127 things explode to Optionally restrict authorised values to tinyint -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:48:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 09:48:16 +0000 Subject: [Koha-bugs] [Bug 35906] Add bookable option on itemtypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161638|0 |1 is obsolete| | --- Comment #6 from Thibaud Guillot --- Created attachment 161744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161744&action=edit Bug 35906: Add bookable option on itemtype Actually new "booking" feature can be set on an item but no directly on an itemtype. This patch adds this possibility. Test plan: 1) Test this new feature on an item as it were currently working. 2) Apply this patch 3) Run updatedatabase.pl 4) Reload Schema by running update_dbix_class_files.pl 5) Change new syspref 'item-level_booking' to 'itemtype' 6) Edit an itemtype, there is a new checkbox to add 'bookable' option 7) Test it with item with this itemtype, if there is 1 item at least you will see 'Booking' tab. 8) You can change syspref to 'item' to see the current behavior Note: When item-level_booking is set on 'itemtype' you can change dropdown option to 'No' on item bookable option. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:51:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 09:51:12 +0000 Subject: [Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:51:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 09:51:15 +0000 Subject: [Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #9 from Marcel de Rooy --- Created attachment 161745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161745&action=edit Bug 28869: Database revision Test plan: Run updatedatabase.pl Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:51:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 09:51:17 +0000 Subject: [Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #10 from Marcel de Rooy --- Created attachment 161746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161746&action=edit Bug 28869: DBIx schema changes for AuthorisedValueCategory Note: Also adds boolean flag in the custom part! Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:51:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 09:51:19 +0000 Subject: [Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #11 from Marcel de Rooy --- Created attachment 161747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161747&action=edit Bug 28869: Implement authorised_value_categories.is_integer_only Test plan: Add category with/without integer restriction. Test adding/editing values. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:51:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 09:51:21 +0000 Subject: [Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #12 from Marcel de Rooy --- Created attachment 161748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161748&action=edit Bug 28869: (follow-up) Add html restriction for tinyint Several item fields are signed tinyints, connected to authorised value categories like NOT_LOAN etc. They only accept -128 up to 127. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:51:23 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 09:51:23 +0000 Subject: [Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #13 from Marcel de Rooy --- Created attachment 161749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161749&action=edit Bug 28869: Unit tests Test plan: Run t/db_dependent/AuthorisedValues.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:52:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 09:52:50 +0000 Subject: [Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #14 from Marcel de Rooy --- === Note for QA WARN Koha/Schema/Result/AuthorisedValueCategory.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 16, now: 18) => PLEASE IGNORE (from automated build) FAIL Koha/AuthorisedValue.pm FAIL valid Constant subroutine Koha::AuthorisedValue::NUM_PATTERN redefined Constant subroutine Koha::AuthorisedValue::NUM_PATTERN_JS redefined => PLEASE IGNORE (false failures for constants, related to module dependencies outside report scope). Note too that qa tools should say WARN here and not FAIL. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:54:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 09:54:12 +0000 Subject: [Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #15 from Marcel de Rooy --- For suggesting further improvements and extending this development, please go to the omnibus on bug 35990. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:55:44 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 09:55:44 +0000 Subject: [Koha-bugs] [Bug 35990] [OMNIBUS] Improvements for using tinyint authorised values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35990 --- Comment #1 from Marcel de Rooy --- Here are a few: Apply tinyint restriction to installer files / sample data en/mandatory/auth_values.yml mandatory/auth_val_cat.sql category: "YES_NO" categories LOST DAMAGED WITHDRAWN RESTRICTED Correct/warn bad data (search_for_data_inconsistencies.pl, about page) Form navigation improvement Distinction between category code and title -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 11:02:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 10:02:01 +0000 Subject: [Koha-bugs] [Bug 35357] Item not removed from holds queue when checked out to a different patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35357 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net QA Contact|testopia at bugs.koha-communit |victor at tuxayo.net |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 11:22:43 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 10:22:43 +0000 Subject: [Koha-bugs] [Bug 26567] Allow to limit subscription search to subscriptions with routing lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26567 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 11:22:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 10:22:45 +0000 Subject: [Koha-bugs] [Bug 26567] Allow to limit subscription search to subscriptions with routing lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26567 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161718|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 161750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161750&action=edit Bug 26567: Allow to limit subscription search to subscriptions with routing lists Adds a search option to the advanced search in the serials module that allows to limit search on subscriptions with routing lists. Test plan: 1. Apply this patch 2. Create two subscriptions, one with a routing list and one without 3. Navigate to Serials home and tick the checkbox labeled "Search routing lists only:" 4. Confirm that the only search result to appear is the subscription you added the routing list to 5. Run unit tests: prove t/db_dependent/Serials.t Sponsored by: Bibliotheksservice-Zentrum Baden-Wuerttemberg Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Perltidied changes to make QA test tools pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 11:22:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 10:22:48 +0000 Subject: [Koha-bugs] [Bug 26567] Allow to limit subscription search to subscriptions with routing lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26567 --- Comment #12 from Katrin Fischer --- Created attachment 161751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161751&action=edit Bug 26567: (follow-up) Update label and add check for RoutingSerials The system preference RoutingSerials controls if the routing list feature is available in the staff interface or not. If routing lists are deactivated, the search option should not show. Also updated the label to read: "Has routing list" Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 11:35:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 10:35:49 +0000 Subject: [Koha-bugs] [Bug 35991] New: C4::Items::AddItemBatchFromMarc should not call logaction() Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35991 Bug ID: 35991 Summary: C4::Items::AddItemBatchFromMarc should not call logaction() Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl C4::Items::AddItemBatchFromMarc calls logaction() : https://git.koha-community.org/Koha-community/Koha/src/commit/12b6c0e67d39590da23a614fbe6d4aa4f18923aa/C4/Items.pm#L266 But this action is already done by Koha::Item->store() a few line above. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 11:36:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 10:36:26 +0000 Subject: [Koha-bugs] [Bug 35991] C4::Items::AddItemBatchFromMarc should not call logaction() In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35991 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23033 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 11:36:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 10:36:26 +0000 Subject: [Koha-bugs] [Bug 23033] C4::Items::AddItemBatchFromMarc does not queue bib record for indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23033 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35991 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 11:50:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 10:50:35 +0000 Subject: [Koha-bugs] [Bug 35992] New: opac-shareshelf: Accepting invitation should not be triggered directly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35992 Bug ID: 35992 Summary: opac-shareshelf: Accepting invitation should not be triggered directly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl See bug 35445. Microsoft Safe Links should not try to accept the list invite. Resolve by adding a separate accept button on the form. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 11:50:56 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 10:50:56 +0000 Subject: [Koha-bugs] [Bug 35992] opac-shareshelf: Accepting invitation should not be triggered directly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35992 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35445 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35445 [Bug 35445] OPAC registration verification triggered by email URL scanners -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 11:50:56 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 10:50:56 +0000 Subject: [Koha-bugs] [Bug 35445] OPAC registration verification triggered by email URL scanners In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35445 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35992 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35992 [Bug 35992] opac-shareshelf: Accepting invitation should not be triggered directly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 11:51:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 10:51:53 +0000 Subject: [Koha-bugs] [Bug 35445] OPAC registration verification triggered by email URL scanners In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35445 --- Comment #15 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #13) > (In reply to Jonathan Druart from comment #11) > > Should not we adjust opac-shareshelf.pl as well? > > Will have a look at that marvelous script :) Opened a new bug 35992, but will wait first for changes from 34478. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 11:52:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 10:52:19 +0000 Subject: [Koha-bugs] [Bug 35992] opac-shareshelf: Accepting invitation should not be triggered directly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35992 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 12:26:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 11:26:53 +0000 Subject: [Koha-bugs] [Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race condition) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 12:26:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 11:26:55 +0000 Subject: [Koha-bugs] [Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race condition) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161682|0 |1 is obsolete| | --- Comment #43 from Marcel de Rooy --- Created attachment 161752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161752&action=edit Bug 35819: Notify NACK and requeue when Job ID not found This patch makes the worker reject the incoming frame for putting the message back in the queue, in the event the job id doesn't exist yet. Which is the case when some actions are being triggered inside a transaction which hasn't been commited to the DB yet. To test you will need 3 KTD shells (a) mysql: $ ktd --shell k$ sudo koha-mysql kohadev (b) logs: $ ktd --shell # for restarting the worker and looking at the logs k$ sudo koha-worker --restart kohadev ; tail -f /var/log/koha/kohadev/worker-*.log (c) running the test: $ ktd --shell 1. Have (a), (b) and (c) terminals ready 2. On (c), run: $ perl -MKoha::Database -MKoha::BackgroundJob::BatchUpdateBiblioHoldsQueue -e 'Koha::Database->schema->txn_do( sub { Koha::BackgroundJob::BatchUpdateBiblioHoldsQueue->new->enqueue({ biblio_ids => [ 1 ] }); sleep 1; } );' => FAIL: * (b) shows (once) an error about a job not existing 3. On (a) run: > SELECT * FROM background_jobs; => FAIL: Notice the job ID mentioned on 2 stands as 'new'. 4. Apply this patch 5. Ctrl+c on (b), and re-run to launch the worker with the patch applied 6. Repeat 2 => SUCCESS (partial): The error about the job not existing is displayed many times 7. Repeat 3 => SUCCESS: The job ID mentioned on 6 stands as 'finished'. 8. Sign off :-D Discussion: * The `requeue` header I added is correct, but it is the default behavior anyway. I prefered to make it explicit, though. * To avoid that bunch of retries, we should requeue with some delay. I didn't manage to make it work (yet) but there's a 'delay' plugin for rabbit [1]. We already install the 'stomp' plugin in koha-common.postinst. But this plugin requires downloading it. Which would require further investigation. * As Nick and Marcel pointed, we need to revisit the whole architecture, the need of a MQ (DB polling wouldn't have this problem), etc. But that's for another place. [1] https://hevodata.com/learn/rabbitmq-delayed-message/#:~:text=To%20delay%20a%20message%2C%20the,to%20queues%20or%20other%20exchanges. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 12:26:58 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 11:26:58 +0000 Subject: [Koha-bugs] [Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race condition) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161683|0 |1 is obsolete| | --- Comment #44 from Marcel de Rooy --- Created attachment 161753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161753&action=edit Bug 35819: Add simple delay Here I add 500 ms. In my testing with the 1s sleep from the test plan, I might see one or two 'not found' lines. Obviously things depend on the time needed before the txn commits. But it will reduce a flood of these messages. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 12:27:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 11:27:01 +0000 Subject: [Koha-bugs] [Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race condition) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161684|0 |1 is obsolete| | --- Comment #45 from Marcel de Rooy --- Created attachment 161754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161754&action=edit Bug 35819: nack and not requeue if frame is invalid If a frame cannot be correctly processed (most probably because the body is not valid JSON) then we are not acking or nacking the frame and the worker is stuck. In this specific case we should nack without requeuing the frame. NOTE that requeue must be 'true' or 'false', not 1 or 0, or the default 'true' will be used. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 12:27:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 11:27:03 +0000 Subject: [Koha-bugs] [Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race condition) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161685|0 |1 is obsolete| | --- Comment #46 from Marcel de Rooy --- Created attachment 161755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161755&action=edit Bug 35819: Improve logging Log (warn) if the job will be processed later, but add a debug however. Have a specific log for bad status Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 12:27:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 11:27:06 +0000 Subject: [Koha-bugs] [Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race condition) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161686|0 |1 is obsolete| | --- Comment #47 from Marcel de Rooy --- Created attachment 161756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161756&action=edit Bug 35819: Adjust es_indexer_daemon Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy [EDIT] Add forgotten module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 12:27:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 11:27:09 +0000 Subject: [Koha-bugs] [Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race condition) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819 --- Comment #48 from Marcel de Rooy --- Created attachment 161757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161757&action=edit Bug 35819: (QA follow-up) Prevent warning on uninitialized retries count Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 12:27:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 11:27:55 +0000 Subject: [Koha-bugs] [Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race condition) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819 --- Comment #49 from Marcel de Rooy --- No problem for me. Get this further now. WARN misc/workers/background_jobs_worker.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 12, now: 15) WARN misc/workers/es_indexer_daemon.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 19, now: 23) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 12:52:34 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 11:52:34 +0000 Subject: [Koha-bugs] [Bug 35357] Item not removed from holds queue when checked out to a different patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35357 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Victor Grousset/tuxayo --- > 7) Verify the holds queue viewer no longer shows that patron and item! The next run of misc/cronjobs/holds/build_holds_queue.pl brings back that patron and item in the Holds queue page. So back with the initial issue :( ---- QA script unhappy: WARN t/db_dependent/HoldsQueue.t WARN tidiness The file is less tidy than before (bad/messy lines before: 484, now: 488) ---- minor finding: The test uses a record level hold instead of an item level one. It works because there is one item for the record. Otherwise reproducing the bug would depend on which item is picked. IIUC it has to be the one suggested by the hold queue to get the issue. So maybe a comment is needed to say that the test tests the case where the checked out item is the one suggested by the hold queue. Or make it do an item level hold like in the test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 12:56:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 11:56:12 +0000 Subject: [Koha-bugs] [Bug 35066] In the Holds Queue, add ability to decline to fill a hold and automatically push to the next branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35066 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:18:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 12:18:01 +0000 Subject: [Koha-bugs] [Bug 35573] Koha is no correctly warning of overridden items when placing a hold if AllowHoldPolicyOverride In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35573 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:18:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 12:18:03 +0000 Subject: [Koha-bugs] [Bug 35573] Koha is no correctly warning of overridden items when placing a hold if AllowHoldPolicyOverride In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35573 --- Comment #1 from Thibaud Guillot --- Created attachment 161758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161758&action=edit Bug 35573: Revert "Bug 30687: Allow pickup location to be forced when override is allowed" This reverts commit ab93008da7eb61b697e4586c679b88c2eebaacd0. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:18:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 12:18:06 +0000 Subject: [Koha-bugs] [Bug 35573] Koha is no correctly warning of overridden items when placing a hold if AllowHoldPolicyOverride In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35573 --- Comment #2 from Thibaud Guillot --- Created attachment 161759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161759&action=edit Bug 35573: Correctly display warning when placing a hold Test plan: 1) Add a basic circulation rule like : 0 hold allowed on patron category 'A' and set AllowHoldPolicyOverride to 'Allow' 2) Make a hold on a patron belongs to this category 3) Normally you should see a warning on item (override needed) but it's not the case 4) Apply this patch 5) Refresh and repeat step 2 This patch comes from an alternative patch on the original bug (I'm including the original test plan for your information) : (Bug 30687 - alternative patch): Always allow to force hold pickup location If AllowHoldPolicyOverride is enabled and only some pickup locations are available, you still have the possibility to force one of the others pickup locations. But when there are zero pickup locations available, that is not possible. This patch change that by always displaying the list of pickup locations when AllowHoldPolicyOverride is enabled. Test plan: 1. Apply patch 2. Disable AllowHoldPolicyOverride 3. Create a biblio B with an item I at library A. 4. Configure this library A to not be a pickup location 5. Add a "Default holds policy by item type" for item I type where "Hold pickup library match" is "item's home library" 6. Try to place a hold on biblio B You should not be able to place a hold because there is no valid pickup locations 7. Enable AllowHoldPolicyOverride 8. Try to place a hold on biblio B You should now see all valid pickup locations in a dropdown list (with an exclamation mark in front of each option) with none selected by default 9. Verify you can place a title-level hold and an item-level hold -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:18:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 12:18:30 +0000 Subject: [Koha-bugs] [Bug 35573] Koha is no correctly warning of overridden items when placing a hold if AllowHoldPolicyOverride In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35573 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thibaud.guillot at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |thibaud.guillot at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:21:23 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 12:21:23 +0000 Subject: [Koha-bugs] [Bug 35357] Item not removed from holds queue when checked out to a different patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35357 --- Comment #6 from Victor Grousset/tuxayo --- While testing, found this that is not due to this patch but related: When canceling a hold, it stays in the hold queue. Is that bad? It stays until the next queue rebuild (15min is said to be the usual delay) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:00:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 13:00:53 +0000 Subject: [Koha-bugs] [Bug 34234] Item groups dropdown in detail page modal does not respect display order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34234 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161019|0 |1 is obsolete| | --- Comment #17 from Victor Grousset/tuxayo --- Created attachment 161760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161760&action=edit Bug 34234: Respect display_order in additem.tt and detail.tt 1. APPLY PATCH 2. EnableItemGroups 3. Find a record and add some new item groups with display orders that are different from the order in which the groups were added 4. Check the checkbox next to one or more items and click the link to "Add/move to item group" 5. Ensure display order is correct 6. Now add a new item to the record and scroll down to the dropdown underneath "+ Add to item group" 7. Display order should be correct. Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:02:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 13:02:53 +0000 Subject: [Koha-bugs] [Bug 34234] Item groups dropdown in detail page modal does not respect display order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34234 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #18 from Victor Grousset/tuxayo --- Works, makes sense, QA script happy, code looks good, passing QA :) For some reason the add item form was already respecting the order (was not luck, changing the order was reflected). Still good to have this set in stone. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:02:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 13:02:59 +0000 Subject: [Koha-bugs] [Bug 34234] Item groups dropdown in detail page modal does not respect display order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34234 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:09:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 13:09:11 +0000 Subject: [Koha-bugs] [Bug 35993] New: AddBiblio should add 005 just like ModBiblio updates it Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35993 Bug ID: 35993 Summary: AddBiblio should add 005 just like ModBiblio updates it Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Records added via Acquisition do not contain a 005 tag. This is inconsistent. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:09:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 13:09:21 +0000 Subject: [Koha-bugs] [Bug 35993] AddBiblio should add 005 just like ModBiblio updates it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35993 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:09:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 13:09:32 +0000 Subject: [Koha-bugs] [Bug 35993] AddBiblio should add 005 just like ModBiblio updates it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35993 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=5374 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:09:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 13:09:32 +0000 Subject: [Koha-bugs] [Bug 5374] Update date/time last transaction (MARC 005) when saving biblio record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5374 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35993 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:28:56 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 13:28:56 +0000 Subject: [Koha-bugs] [Bug 35993] AddBiblio should add 005 just like ModBiblio updates it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35993 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 15:09:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 14:09:57 +0000 Subject: [Koha-bugs] [Bug 35994] New: Need a easy way to see if biblio record or item is still in acquisition Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35994 Bug ID: 35994 Summary: Need a easy way to see if biblio record or item is still in acquisition Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org See also bug 35993. Checking for 005 would not be a good way to approach this question. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 15:10:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 14:10:07 +0000 Subject: [Koha-bugs] [Bug 35994] Need a easy way to see if biblio record or item is still in acquisition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35994 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35993 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 15:10:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 14:10:07 +0000 Subject: [Koha-bugs] [Bug 35993] AddBiblio should add 005 just like ModBiblio updates it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35993 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35994 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 15:11:43 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 14:11:43 +0000 Subject: [Koha-bugs] [Bug 35994] Need a easy way to see if biblio record or item is still in acquisition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35994 --- Comment #1 from Marcel de Rooy --- Note that acquisition of older books may take a long time. In the meantime we may have changed from creating items at ordering, receiving or cataloging. So we cannot just trust checking items.notforloan. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 15:16:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 14:16:02 +0000 Subject: [Koha-bugs] [Bug 35993] AddBiblio should add 005 just like ModBiblio updates it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35993 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 15:16:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 14:16:04 +0000 Subject: [Koha-bugs] [Bug 35993] AddBiblio should add 005 just like ModBiblio updates it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35993 --- Comment #1 from Marcel de Rooy --- Created attachment 161761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161761&action=edit Bug 35993: Add SimpleMarc::update_last_transaction_time Note: This routine does not check field existence like ModBiblioMarc does/did (see next patch). So it inserts a field 005 if it is not present. Test plan: Run t/SimpleMARC.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 15:16:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 14:16:06 +0000 Subject: [Koha-bugs] [Bug 35993] AddBiblio should add 005 just like ModBiblio updates it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35993 --- Comment #2 from Marcel de Rooy --- Created attachment 161762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161762&action=edit Bug 35993: Apply new routine to ModBiblioMarc Now both AddBiblio and ModBiblio will insert 005 if not present. Test plan: Run t/db_dependent/Biblio.t And via interface: Add a new biblio record via Acquisition. Without this patch it does not have a 005, now it does. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 15:52:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 14:52:27 +0000 Subject: [Koha-bugs] [Bug 35987] See highlighted items below link broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35987 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Depends on| |33528 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33528 [Bug 33528] Use template wrapper for tabs: Patron details and circulation -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 15:52:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 14:52:27 +0000 Subject: [Koha-bugs] [Bug 33528] Use template wrapper for tabs: Patron details and circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33528 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35987 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35987 [Bug 35987] See highlighted items below link broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 15:54:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 14:54:36 +0000 Subject: [Koha-bugs] [Bug 35987] See highlighted items below link broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35987 --- Comment #1 from Lucas Gass --- Even with `*_panel` the behavior is still odd if you don't "Always show checkouts automatically". Clicking "See highlighted items below:" should expand the checkout table if it is not already. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 16:09:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 15:09:21 +0000 Subject: [Koha-bugs] [Bug 35945] Expand OverduesBlockCirc to guarantees and guarantors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35945 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org --- Comment #1 from George Williams (NEKLS) --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 16:30:10 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 15:30:10 +0000 Subject: [Koha-bugs] [Bug 35883] Use template wrapper for accordions: Table settings administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35883 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 16:30:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 15:30:12 +0000 Subject: [Koha-bugs] [Bug 35883] Use template wrapper for accordions: Table settings administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35883 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161331|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 161763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161763&action=edit Bug 35883: Use template wrapper for accordions: Table settings administration This patch updates the table settings administration page so that Bootstrap accordion markup is generated by WRAPPERs. This patch also makes some changes to fix the automatic scroll when a table configuration button was clicked. To test, apply the patch and go to Administration -> Table settings. - The list of modules should be displayed as before: Collapsible panels where clicking the module name heading expands the corresponding panel of settings. - Test that direct links to configurable tables still work correctly: - Go to Administration -> Libraries. - Click the "Configure" button at the top of the table of libraries. - You should be taken to the table settings page. - The "Administration" panel should be expanded by default. - You should be scrolled down automatically to the "Libraries" table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 16:33:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 15:33:42 +0000 Subject: [Koha-bugs] [Bug 35920] Centralize code from workers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35920 --- Comment #6 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #5) > (In reply to Tomás Cohen Arazi from comment #3) > > I like the concept. > > > > Given the discussion Marcel is driving around rabbit vs. polling, why not > > create some base class and then different classes implementing each > > communication mechanism? > > The discussion is going into a "drop one of the other" conclusion, so it > does not seem useful to provide a temporary abstraction that will be useless > later... But... will we make a decision anytime soon? This is a blocker IMHO, for a maintainable implementation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 16:34:28 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 15:34:28 +0000 Subject: [Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Mike Barrette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mbarrette at oslri.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 16:49:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 15:49:12 +0000 Subject: [Koha-bugs] [Bug 35995] New: Real time holds queue jobs for the same record should run in serial, never parallel Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35995 Bug ID: 35995 Summary: Real time holds queue jobs for the same record should run in serial, never parallel Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com As described in bug 34596 there are times when multiple jobs to rebuild the holds queue for a single job will run where the first job as the last to execute ( or at least the last to finish ). We need to force these jobs to run in serial, and only the newest job for a given record *needs* to run, older jobs can exit early. To this end, I propose a "holds queue job lock" table. The table will have rows for the record id, and the timestamp of job initiation. When a job begins processing, it will attempt to insert a row into this table. If that insert succeeds, the job will process then remove the lock from the table. If the insert fails, it means another job has already written a lock. The blocked job can then read the row in the table. If the queued time for the job that got the lock is newer than the time queued for the blocked job that is checking it, that job can exit as it is obsolete. If the queue time for the job that got the lock is older than the time queue for the blocked job, that job needs to reinsert itself into the job queue before exiting so it may try again in the future. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 17:49:33 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 16:49:33 +0000 Subject: [Koha-bugs] [Bug 35996] New: Add clarification to POD in writeoff_debts.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35996 Bug ID: 35996 Summary: Add clarification to POD in writeoff_debts.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: matt.blenkinsop at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 17:50:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 16:50:04 +0000 Subject: [Koha-bugs] [Bug 35996] Add clarification to POD in writeoff_debts.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35996 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35074 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35074 [Bug 35074] Add --patron_category to writeoff_debts.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 17:50:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 16:50:04 +0000 Subject: [Koha-bugs] [Bug 35074] Add --patron_category to writeoff_debts.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35074 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35996 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35996 [Bug 35996] Add clarification to POD in writeoff_debts.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 17:53:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 16:53:50 +0000 Subject: [Koha-bugs] [Bug 35996] Add clarification to POD in writeoff_debts.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35996 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 17:53:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 16:53:53 +0000 Subject: [Koha-bugs] [Bug 35996] Add clarification to POD in writeoff_debts.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35996 --- Comment #1 from Matt Blenkinsop --- Created attachment 161764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161764&action=edit Bug 35996: Make it clear that --category-code can not be used alone This patch adds a clarification to writeoff_debts.pl to make it clear that --category-code can't be used as the only filter when running the script. If this is the case, the script just displays the help menu as it is expecting one of the other filters Test plan: 1) Run perl misc/cronjobs/writeoff_debts.pl --category-code TEST --confirm 2) Observe that the help menu is displayed instead of running the script 3) Check the help menu for the text added in this patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 17:54:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 16:54:06 +0000 Subject: [Koha-bugs] [Bug 35996] Add clarification to POD in writeoff_debts.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35996 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |matt.blenkinsop at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 18:54:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 17:54:14 +0000 Subject: [Koha-bugs] [Bug 35966] Koha should not strip limits from SQL queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35966 Brendan Lawlor changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor at clamsnet.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 19:38:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 18:38:13 +0000 Subject: [Koha-bugs] [Bug 35988] Record of deleted item not recorded in action logs even if record wasn't deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35988 Miranda Nero changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mnero at oslri.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 19:39:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 18:39:27 +0000 Subject: [Koha-bugs] [Bug 31606] Enhance acquisitions to allow ordering on next year's budget when still in current year. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31606 Kris changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kbecker at jcls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 19:46:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 18:46:36 +0000 Subject: [Koha-bugs] [Bug 35883] Use template wrapper for accordions: Table settings administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35883 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 19:46:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 18:46:38 +0000 Subject: [Koha-bugs] [Bug 35883] Use template wrapper for accordions: Table settings administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35883 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161763|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 161765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161765&action=edit Bug 35883: Use template wrapper for accordions: Table settings administration This patch updates the table settings administration page so that Bootstrap accordion markup is generated by WRAPPERs. This patch also makes some changes to fix the automatic scroll when a table configuration button was clicked. To test, apply the patch and go to Administration -> Table settings. - The list of modules should be displayed as before: Collapsible panels where clicking the module name heading expands the corresponding panel of settings. - Test that direct links to configurable tables still work correctly: - Go to Administration -> Libraries. - Click the "Configure" button at the top of the table of libraries. - You should be taken to the table settings page. - The "Administration" panel should be expanded by default. - You should be scrolled down automatically to the "Libraries" table. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 19:56:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 18:56:12 +0000 Subject: [Koha-bugs] [Bug 27769] Advanced editor shouldn't break copying selected text with Ctrl+C In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27769 --- Comment #6 from Nick Clemens --- When originally implemented, the feature was unable to use the system clipboard, this was a browser limitation at the time. The internal clipboard was developed as a workaround, and used the familiar key combinations to provide the closest experience possible. We could change the default keys for new installations, however, I agree with Katrin that making a change to existing setups might be more confusing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 19:58:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 18:58:14 +0000 Subject: [Koha-bugs] [Bug 35997] New: Cancelling a hold should remove the hold form the queue Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 Bug ID: 35997 Summary: Cancelling a hold should remove the hold form the queue Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com >From bug 35357 - a cancelled hold remains in the hold queue until rebuilt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 20:05:25 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 19:05:25 +0000 Subject: [Koha-bugs] [Bug 35997] Cancelling a hold should remove the hold from the queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cancelling a hold should |Cancelling a hold should |remove the hold form the |remove the hold from the |queue |queue -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 20:42:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 19:42:09 +0000 Subject: [Koha-bugs] [Bug 27769] Advanced editor shouldn't break copying selected text with Ctrl+C In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27769 --- Comment #7 from Heather --- OK, y'all, Real Cataloger here, one who uses the Advanced Bib Editor all the time--like, all the time. Please, please, please change Ctrl-C to conform to the standard behavior of all the other software applications. I do appreciate people thinking it might be confusing to have the "Koha Ctrl C" implemented in all its weirdness and then change it, but here are my arguments: --We catalogers are *not* using Koha in a vacuum; we are using Koha alongside many other applications within which Ctrl-C is behaving consistently, such as OCLC software, MarcEdit, spreadsheets, databases, text editors, web browsers, etc.--it's what we do. Then we pop into Koha and it's, "Oh for fuschia's sake, that's right, Koha-Ctrl-C is different." (Please note that I'm not mentally saying "fuschia" but am mentally thinking another word in English that is one syllable.):) --We catalogers copy & paste OFTEN because it is a time honored technique to avoid typos and promote consistency. Standardizing this behavior would speed up our workflow by promoting consistency in keystrokes. --Which brings me to Consistency: We catalogers love, adore, and are professionally committed to Consistency. 'Koha Ctrl C' is Inconsistent and slows up every cataloger who then has to pause and think, "Oh, right...it's Koha-Ctrl-C rather than Ctrl-C. I would be absolutely delighted to be outvoted on this by other catalogers, but I strongly suspect that all catalogers would vote for consistency and request that Ctrl-C in the Advanced Bib Editor be changed to conformed with standard practice! As is, Koha-Ctrl-C *is* behaving in ways that are invisible to the user (i.e., not showing anything in the Clipboard to the lower left)--it is copying anything highlighted or being it's own wacky non-standard self and copying the entire MARC tag if nothing is hightlighted). If the Koha Clipboard even showed what Koha-Ctrl-C copied, I could see an argument for maintaining this inconsistent behavior, but seeing as the Koha Clipboard doesn't even show what was copied, I think this feature is broken and needs fixing, and as it needs fixing, I advocate fixing it to standard & consistent behavior. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 20:44:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 19:44:37 +0000 Subject: [Koha-bugs] [Bug 35997] Cancelling a hold should remove the hold from the queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 20:48:51 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 19:48:51 +0000 Subject: [Koha-bugs] [Bug 35997] Cancelling a hold should remove the hold from the queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 20:48:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 19:48:53 +0000 Subject: [Koha-bugs] [Bug 35997] Cancelling a hold should remove the hold from the queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 --- Comment #1 from Kyle M Hall --- Created attachment 161766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161766&action=edit Bug 35997: Cancelling a hold should remove the hold from the queue Test plan: 1) Place a hold for a record for a patron 2) Build the holds queue 3) Note the holds queue contains a match for that patron and record 4) Cancel the holds queue 5) Reload the holds queue page, note the match for that patron and record is gone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 21:00:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 20:00:37 +0000 Subject: [Koha-bugs] [Bug 35997] Cancelling a hold should remove the hold from the queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161766|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 161767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161767&action=edit Bug 35997: Cancelling a hold should remove the hold from the queue Test plan: 1) Place a hold for a record for a patron 2) Build the holds queue 3) Note the holds queue contains a match for that patron and record 4) Cancel the holds queue 5) Reload the holds queue page, note the match for that patron and record is gone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 21:21:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 20:21:52 +0000 Subject: [Koha-bugs] [Bug 35998] New: Add the ability to email a patron invoice Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35998 Bug ID: 35998 Summary: Add the ability to email a patron invoice Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: esther.melander at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The transactions tab on a patron account currently has the ability to print an invoice. It would be nice to add the ability to email a patron invoice. This would be useful in many settings, but especially an academic setting. A use case exists where students may not be physically on the campus and have to be billed for charges via email. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 21:29:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 20:29:00 +0000 Subject: [Koha-bugs] [Bug 29539] UNIMARC: authority number in $9 displays for thesaurus controlled fields instead of content of $a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29539 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 21:29:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 20:29:03 +0000 Subject: [Koha-bugs] [Bug 29539] UNIMARC: authority number in $9 displays for thesaurus controlled fields instead of content of $a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29539 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161262|0 |1 is obsolete| | --- Comment #21 from David Nind --- Created attachment 161768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161768&action=edit Bug 29539: UNIMARC: authority number in $9 displays for thesaurus controlled fields instead of content of $a When you try to dislpay a bibliographic record on unimarc that has subjects linked with authorities then only the $9 is displayed as link instead of the content of $a and it's subdivisions, if any. To test: 1) You will need to have a bibliographic record with at least one subject autority connected in unimarc framework. 2) View that record on OPAC on detail display. The subject will display as a number ( $9 ) and you cannot see the text/term of the subject ( $a ) 3) Apply patch 4) Repeat step 2 5) The subject display in a normal way based on content $a - or more subfields Sponsored-by: National Library of Greece Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 21:29:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 20:29:06 +0000 Subject: [Koha-bugs] [Bug 29539] UNIMARC: authority number in $9 displays for thesaurus controlled fields instead of content of $a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29539 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161622|0 |1 is obsolete| | --- Comment #22 from David Nind --- Created attachment 161769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161769&action=edit Bug 29539: (follow-up) remove tag_onesubject template Also: Restores the Replaces "not(position()=last())" with the more used "position() != last()" Removes unecessary change in Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 21:35:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 20:35:46 +0000 Subject: [Koha-bugs] [Bug 35996] Add clarification to POD in writeoff_debts.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35996 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 21:35:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 20:35:48 +0000 Subject: [Koha-bugs] [Bug 35996] Add clarification to POD in writeoff_debts.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35996 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161764|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 161770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161770&action=edit Bug 35996: Make it clear that --category-code can not be used alone This patch adds a clarification to writeoff_debts.pl to make it clear that --category-code can't be used as the only filter when running the script. If this is the case, the script just displays the help menu as it is expecting one of the other filters Test plan: 1) Run perl misc/cronjobs/writeoff_debts.pl --category-code TEST --confirm 2) Observe that the help menu is displayed instead of running the script 3) Check the help menu for the text added in this patch Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 22:37:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 21:37:17 +0000 Subject: [Koha-bugs] [Bug 14180] Make "Always show checkouts immediately" a global setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180 --- Comment #30 from Lucas Gass --- (In reply to Andrew Fuerste-Henry from comment #29) > This looks like maybe it should have been set to Signed Off when Kelly > tested it 1/26. As of today, the patch doesn't apply. Due to patches from Bug 35506 being pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 23:35:33 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2024 22:35:33 +0000 Subject: [Koha-bugs] [Bug 35992] opac-shareshelf: Accepting invitation should not be triggered directly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35992 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 03:16:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 02:16:41 +0000 Subject: [Koha-bugs] [Bug 31732] 880 titles missing from OPAC and staff interface checkout summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31732 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 08:32:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 07:32:53 +0000 Subject: [Koha-bugs] [Bug 35962] t/db_dependent/Koha/BackgroundJob.t failing on D10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35962 --- Comment #4 from Jonathan Druart --- Created attachment 161771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161771&action=edit Bug 35962: (bug 35843 follow-up 2) Fix BackgroundJob.t on D10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 08:33:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 07:33:24 +0000 Subject: [Koha-bugs] [Bug 35962] t/db_dependent/Koha/BackgroundJob.t failing on D10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35962 --- Comment #5 from Jonathan Druart --- Sorry, I simplified the code that was passing on D10, but only tested on D12 it seems... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 08:35:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 07:35:26 +0000 Subject: [Koha-bugs] [Bug 35962] t/db_dependent/Koha/BackgroundJob.t failing on D10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35962 --- Comment #6 from Jonathan Druart --- https://github.com/geofffranks/test-mockmodule/issues/34 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 09:00:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 08:00:21 +0000 Subject: [Koha-bugs] [Bug 35962] t/db_dependent/Koha/BackgroundJob.t failing on D10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35962 --- Comment #7 from Jonathan Druart --- I pushed the second patch to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 09:00:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 08:00:24 +0000 Subject: [Koha-bugs] [Bug 35962] t/db_dependent/Koha/BackgroundJob.t failing on D10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35962 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 10:00:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 09:00:36 +0000 Subject: [Koha-bugs] [Bug 35999] New: Incorrect warning about "Port" when creating a new Z39.50 server Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35999 Bug ID: 35999 Summary: Incorrect warning about "Port" when creating a new Z39.50 server Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 11795 "Port: Please add amount in valid format: 0.00 Required" Port is a number, not an amount. To recreate: Go to http://localhost:8081/cgi-bin/koha/admin/z3950servers.pl?op=add&type=zed Type "foo" for "Port" Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11795 [Bug 11795] Use validation plugin when creating new Z39.50 server -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 10:00:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 09:00:36 +0000 Subject: [Koha-bugs] [Bug 11795] Use validation plugin when creating new Z39.50 server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11795 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35999 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35999 [Bug 35999] Incorrect warning about "Port" when creating a new Z39.50 server -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 13:15:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 12:15:18 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #48 from Owen Leonard --- html_helpers.inc defines a variable, preference_value, with the contents of the OPACLoginLabelTextContent system preference. This variable seems to be available everywhere but on the login screen (opac-auth.tt). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 13:16:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 12:16:16 +0000 Subject: [Koha-bugs] [Bug 34077] writeoff_debts without --confirm doesn't show which accountline records it would have been written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34077 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159987|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 161772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161772&action=edit Bug 34077: Update output to match POD This patch adds a check on !$confirm such that we enable verbose output should the confirm flag not be passed. This adheres with what the documentation already states. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 13:16:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 12:16:19 +0000 Subject: [Koha-bugs] [Bug 34077] writeoff_debts without --confirm doesn't show which accountline records it would have been written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34077 --- Comment #11 from Martin Renvoize --- Created attachment 161773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161773&action=edit Bug 34077: Only print verbose output when asked for This patch updates the logic such that we only trigger verbose when verbose is explicitly asked for. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 13:16:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 12:16:30 +0000 Subject: [Koha-bugs] [Bug 34077] writeoff_debts without --confirm doesn't show which accountline records it would have been written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34077 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 13:17:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 12:17:16 +0000 Subject: [Koha-bugs] [Bug 34077] writeoff_debts without --confirm doesn't show which accountline records it would have been written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34077 --- Comment #12 from Martin Renvoize --- Follow up added to take account of Julians comment.. He's right.. we should really only output verbose if it's specifically asked for. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 13:22:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 12:22:32 +0000 Subject: [Koha-bugs] [Bug 34077] writeoff_debts without --confirm doesn't show which accountline records it would have been written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34077 --- Comment #13 from Martin Renvoize --- Created attachment 161774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161774&action=edit Bug 34077: Tidy the script Minimal changes were needed to bring the script up to date with current perltidy requirements. I opted to do a full tidy rather than just tidy the blocks changed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 13:32:28 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 12:32:28 +0000 Subject: [Koha-bugs] [Bug 36000] New: Fix CGI::param called in list context from catalogue/search.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36000 Bug ID: 36000 Summary: Fix CGI::param called in list context from catalogue/search.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org $template->param( sort => $cgi->param('sort_by'), ); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 13:34:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 12:34:08 +0000 Subject: [Koha-bugs] [Bug 36000] Fix CGI::param called in list context from catalogue/search.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36000 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 13:34:10 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 12:34:10 +0000 Subject: [Koha-bugs] [Bug 36000] Fix CGI::param called in list context from catalogue/search.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36000 --- Comment #1 from Marcel de Rooy --- Created attachment 161775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161775&action=edit Bug 36000: Fix CGI::param warning in catalogue search Speaks for itself. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 13:34:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 12:34:36 +0000 Subject: [Koha-bugs] [Bug 36000] Fix CGI::param called in list context from catalogue/search.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36000 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Status|Needs Signoff |Signed Off --- Comment #2 from Marcel de Rooy --- Taking liberty to pass QA myself. Super trivial -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 13:34:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 12:34:42 +0000 Subject: [Koha-bugs] [Bug 34077] writeoff_debts without --confirm doesn't show which accountline records it would have been written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34077 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35074 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35074 [Bug 35074] Add --patron_category to writeoff_debts.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 13:34:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 12:34:42 +0000 Subject: [Koha-bugs] [Bug 35074] Add --patron_category to writeoff_debts.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35074 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34077 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34077 [Bug 34077] writeoff_debts without --confirm doesn't show which accountline records it would have been written off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 13:34:43 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 12:34:43 +0000 Subject: [Koha-bugs] [Bug 36000] Fix CGI::param called in list context from catalogue/search.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36000 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 13:35:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 12:35:03 +0000 Subject: [Koha-bugs] [Bug 36000] Fix CGI::param called in list context from catalogue/search.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36000 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 13:36:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 12:36:42 +0000 Subject: [Koha-bugs] [Bug 35996] Add clarification to POD in writeoff_debts.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35996 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34077 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 13:36:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 12:36:42 +0000 Subject: [Koha-bugs] [Bug 34077] writeoff_debts without --confirm doesn't show which accountline records it would have been written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34077 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35996 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 13:37:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 12:37:54 +0000 Subject: [Koha-bugs] [Bug 35996] Add clarification to POD in writeoff_debts.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35996 --- Comment #3 from Martin Renvoize --- I decided in the end that you were probably right in the first place Matt, and that it could be a useful option to allow category only filtering. In bug 34077 we add the category parameter to the initial check line, so maybe we just need that one instead of this. I'll leave this open for now to get other opinions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 13:39:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 12:39:41 +0000 Subject: [Koha-bugs] [Bug 35962] t/db_dependent/Koha/BackgroundJob.t failing on D10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35962 --- Comment #8 from Katrin Fischer --- (In reply to Jonathan Druart from comment #7) > I pushed the second patch to master. I am still here you know ;) But it's good. I was just about to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 13:43:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 12:43:17 +0000 Subject: [Koha-bugs] [Bug 35357] Item not removed from holds queue when checked out to a different patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35357 --- Comment #7 from Katrin Fischer --- (In reply to Victor Grousset/tuxayo from comment #6) > While testing, found this that is not due to this patch but related: > > When canceling a hold, it stays in the hold queue. Is that bad? It stays > until the next queue rebuild (15min is said to be the usual delay) Please keep in mind that build_holdsqueue is no longer the only use case. We have RTHoldsqueue without people running the script or only running it nightly now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 13:44:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 12:44:19 +0000 Subject: [Koha-bugs] [Bug 34862] blocking_errors.inc not included everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #46 from Marcel de Rooy --- What about OPAC here ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 13:48:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 12:48:22 +0000 Subject: [Koha-bugs] [Bug 35092] [OMNIBUS] Remaining background job/worker issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35092 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35920 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35920 [Bug 35920] Centralize code from workers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 13:48:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 12:48:22 +0000 Subject: [Koha-bugs] [Bug 35920] Centralize code from workers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35920 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35092 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35092 [Bug 35092] [OMNIBUS] Remaining background job/worker issues -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 13:49:58 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 12:49:58 +0000 Subject: [Koha-bugs] [Bug 35920] Centralize code from workers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35920 --- Comment #7 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #6) > (In reply to Jonathan Druart from comment #5) > > (In reply to Tomás Cohen Arazi from comment #3) > > > I like the concept. > > > > > > Given the discussion Marcel is driving around rabbit vs. polling, why not > > > create some base class and then different classes implementing each > > > communication mechanism? > > > > The discussion is going into a "drop one of the other" conclusion, so it > > does not seem useful to provide a temporary abstraction that will be useless > > later... > > But... will we make a decision anytime soon? This is a blocker IMHO, for a > maintainable implementation. Lack of response and available time are the usual suspects :) I did not happen to see your own response on bug 35092 btw.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 13:53:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 12:53:36 +0000 Subject: [Koha-bugs] [Bug 34077] writeoff_debts without --confirm doesn't show which accountline records it would have been written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34077 --- Comment #14 from Julian Maurice --- With the followup we can now execute the script without -v nor -c, which prints nothing and does nothing. Not only useless, it may also give the impression that something has been done without errors. Failing QA for that. I think the current behavior in master is ok (-v is required if -c is absent) and only the documentation needs to be fixed. On the other hand, requiring a "verbose" flag is unusual for a CLI. So maybe one of the following alternatives is better (or both): - Set default verbosity to 1, and add a `-q, --quiet` flag to decrease verbosity - Add a `-n, --dry-run` flag and require exclusively one of -n or -c (maybe best in an another bug report ?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 13:53:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 12:53:48 +0000 Subject: [Koha-bugs] [Bug 34077] writeoff_debts without --confirm doesn't show which accountline records it would have been written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34077 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:14:51 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 13:14:51 +0000 Subject: [Koha-bugs] [Bug 36001] New: Visualize MARC fields 310 and 362 for serial publications Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36001 Bug ID: 36001 Summary: Visualize MARC fields 310 and 362 for serial publications Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: verolencinas at yahoo.com.ar QA Contact: testopia at bugs.koha-community.org In MARC 21, fields 310, 321 and 362 show useful information for users. Field 310 shows periodicity; 321, former periodicity, and 362, Dates of Publication and/or Sequential Designation. If would be useful for libraries with serial publications to show these data to users. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:16:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 13:16:03 +0000 Subject: [Koha-bugs] [Bug 35993] AddBiblio should add 005 just like ModBiblio updates it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35993 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161761|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 161776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161776&action=edit Bug 35993: Add SimpleMarc::update_last_transaction_time Note: This routine does not check field existence like ModBiblioMarc does/did (see next patch). So it inserts a field 005 if it is not present. Test plan: Run t/SimpleMARC.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:16:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 13:16:05 +0000 Subject: [Koha-bugs] [Bug 35993] AddBiblio should add 005 just like ModBiblio updates it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35993 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161762|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 161777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161777&action=edit Bug 35993: Apply new routine to ModBiblioMarc Now both AddBiblio and ModBiblio will insert 005 if not present. Test plan: Run t/db_dependent/Biblio.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:19:34 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 13:19:34 +0000 Subject: [Koha-bugs] [Bug 23978] Notes field in saved reports should allow for HTML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:19:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 13:19:57 +0000 Subject: [Koha-bugs] [Bug 35993] AddBiblio should add 005 just like ModBiblio updates it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35993 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161777|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 161778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161778&action=edit Bug 35993: Apply new routine to ModBiblioMarc Now both AddBiblio and ModBiblio will insert 005 if not present. Test plan: Run t/db_dependent/Biblio.t Add biblio record via acquistion order. Check 005 in the table biblio_metadata. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:27:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 13:27:39 +0000 Subject: [Koha-bugs] [Bug 36002] New: Get rid of aqorders.purchaseordernumber Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36002 Bug ID: 36002 Summary: Get rid of aqorders.purchaseordernumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org This field is unused. Any attempt to use it was inactive since 2014. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:28:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 13:28:12 +0000 Subject: [Koha-bugs] [Bug 11010] Useless column purchaseordernumber in aqorders table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11010 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #5 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #4) > Since bug 4456 will use this field, this bug report is invalid. Bug 4456 died prematurely. I opened 36002 to resurrect removal of this confusing column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:28:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 13:28:42 +0000 Subject: [Koha-bugs] [Bug 36002] Get rid of aqorders.purchaseordernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36002 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11010 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:28:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 13:28:42 +0000 Subject: [Koha-bugs] [Bug 11010] Useless column purchaseordernumber in aqorders table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11010 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36002 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:55:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 13:55:01 +0000 Subject: [Koha-bugs] [Bug 36002] Get rid of aqorders.purchaseordernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36002 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:55:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 13:55:03 +0000 Subject: [Koha-bugs] [Bug 36002] Get rid of aqorders.purchaseordernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36002 --- Comment #1 from Marcel de Rooy --- Created attachment 161779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161779&action=edit Bug 36002: Database revision for aqorders.purchaseordernumber Test plan: Run dbrev. Check if field is no longer there. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:55:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 13:55:06 +0000 Subject: [Koha-bugs] [Bug 36002] Get rid of aqorders.purchaseordernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36002 --- Comment #2 from Marcel de Rooy --- Created attachment 161780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161780&action=edit Bug 36002: DBIx schema changes for Aqorder No test plan. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:55:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 13:55:08 +0000 Subject: [Koha-bugs] [Bug 36002] Get rid of aqorders.purchaseordernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36002 --- Comment #3 from Marcel de Rooy --- Created attachment 161781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161781&action=edit Bug 36002: Remove unused subroutine GetParcels That did refer to our aqorders.purchaseordernumber.. Test plan: Git grep for GetParcels. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:55:10 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 13:55:10 +0000 Subject: [Koha-bugs] [Bug 36002] Get rid of aqorders.purchaseordernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36002 --- Comment #4 from Marcel de Rooy --- Created attachment 161782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161782&action=edit Bug 36002: Remove last references to purchaseordernumber Test plan: Git grep for it. Ignore update22to30.pl and atomicupdate. Verify that you can still create/update/delete an acq order. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:55:44 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 13:55:44 +0000 Subject: [Koha-bugs] [Bug 36002] Get rid of aqorders.purchaseordernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36002 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 15:01:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 14:01:30 +0000 Subject: [Koha-bugs] [Bug 36003] New: Printing list from OPAC shows "Cookies" when CookieConsent enabled Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36003 Bug ID: 36003 Summary: Printing list from OPAC shows "Cookies" when CookieConsent enabled Change sponsored?: --- Product: Koha Version: 23.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: mirjam.vantieghem at etf.edu QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl If system preference CookieConsent is set to "Required", the word "Cookies" appears at the bottem left on the last page, under the last result, when printing a list from the OPAC. Funny, but not desirable. Not sure if similar to bug #12260. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 15:09:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 14:09:24 +0000 Subject: [Koha-bugs] [Bug 11340] Make the 'print summary' a custom slip/notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11340 --- Comment #13 from Jessie Zairo --- just adding more feedback. A librarian shared yesterday that it would be helpful to be able to change the sorting for the table so the account summary showed the most recent checkouts first, rather than just an alphabetical listing. Or at least adding the option for libraries to customize. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 15:33:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 14:33:52 +0000 Subject: [Koha-bugs] [Bug 34965] Authority match failing due to possible encoding conflicts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34965 Michelle Spinney changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney at clamsnet.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 15:34:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 14:34:04 +0000 Subject: [Koha-bugs] [Bug 35438] Importing records can create too large transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35438 Michelle Spinney changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney at clamsnet.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 15:35:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 14:35:32 +0000 Subject: [Koha-bugs] [Bug 21972] Record matching rule for authorities only works for first 20 authority records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21972 Michelle Spinney changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney at clamsnet.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 15:37:44 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 14:37:44 +0000 Subject: [Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 15:37:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 14:37:47 +0000 Subject: [Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755 --- Comment #4 from Maryse Simard --- Created attachment 161783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161783&action=edit Bug 34755: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 15:37:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 14:37:49 +0000 Subject: [Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755 --- Comment #5 from Maryse Simard --- Created attachment 161784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161784&action=edit Bug 34755: Resets the userenv when calling OAuth api endpoints When using OIDC authentication, the error "wrong_csrf_token" can happen if another user's userenv is loaded during login. This is because the wrong userenv is used to compare the tokens. This patch explicitly resets userenv when using OAuth endpoints of the Koha api. Steps to reproduce: 0. On a Koha with SSO configured 1. Open the OPAC 2. Log in with a regular Koha user, not using SSO. 3. In a private browser window, open the OPAC 4. log in using SSO with a different user account. 5. Notice that you get the error message "There was an error authenticating to external identity provider wrong_csrf_token" 6. Click on the "Log in with [...]" button again. 7. Notice that the user is immediately logged in. To test: - Apply the tests patch - prove t/db_dependent/api/v1/idp.t => FAIL: wrong_csrf_token - Apply patch - prove t/db_dependent/api/v1/idp.t => SUCCESS - Run other OAuth endpoints tests to make sure nothing broke: prove t/db_dependent/api/v1/auth_authenticate_api_request.t prove t/db_dependent/api/v1/oauth.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 15:38:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 14:38:27 +0000 Subject: [Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard at inlibro.com Assignee|tomascohen at gmail.com |maryse.simard at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 15:43:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 14:43:24 +0000 Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #17 from Marcel de Rooy --- A bit late, but wondering why active_orders include completed lines ? Looks a bit strange to me.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 15:44:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 14:44:01 +0000 Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 --- Comment #18 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #0) > Using the DBIC relationship with aqorders and count, we can get rid of it. You could have used aqorders but added orders? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 15:46:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 14:46:06 +0000 Subject: [Koha-bugs] [Bug 35994] Need a easy way to see if biblio record or item is still in acquisition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35994 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24430 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 15:46:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 14:46:06 +0000 Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35994 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 15:47:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 14:47:05 +0000 Subject: [Koha-bugs] [Bug 35994] Need a easy way to see if biblio record or item is still in acquisition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35994 --- Comment #2 from Marcel de Rooy --- Bug 24430 added biblio->active_orders but they include the lines which are completely received. These are actually 'not-cancelled' orders. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 15:47:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 14:47:50 +0000 Subject: [Koha-bugs] [Bug 35994] Need an easy way to see if biblio record or item is still in acquisition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35994 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Need a easy way to see if |Need an easy way to see if |biblio record or item is |biblio record or item is |still in acquisition |still in acquisition -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 15:58:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 14:58:32 +0000 Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 --- Comment #19 from Martin Renvoize --- Adding the orders relation alias is forward thinking for the API here. I agree with the approach Tomas took -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 16:02:28 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 15:02:28 +0000 Subject: [Koha-bugs] [Bug 34077] writeoff_debts without --confirm doesn't show which accountline records it would have been written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34077 --- Comment #15 from Martin Renvoize --- I'm out, this was meant to be a simple consistency fix -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 16:32:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 15:32:52 +0000 Subject: [Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755 --- Comment #6 from Katrin Fischer --- Excited to see patches on this one! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 16:35:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 15:35:32 +0000 Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 --- Comment #20 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #19) > Adding the orders relation alias is forward thinking for the API here. I > agree with the approach Tomas took Yeah no problem. But couldnt you add an ->orders method and use the aqorders relation inside. Preventing custom relations in DBIx schema? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:01:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 16:01:20 +0000 Subject: [Koha-bugs] [Bug 36004] New: Typo in "Your concern was successfully submitted" text Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36004 Bug ID: 36004 Summary: Typo in "Your concern was successfully submitted" text Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: Laura.escamilla at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: 1. Turn on the syspref 'OpacCatalogConcerns' 2. Go to view a record in the OPAC and click on "Report a concern" in the column located on the right-hand side. 3. Fill out the title on the form and leave everything else the same. Click on submit and notice that the message on the screen says "Your concern was sucessfully submitted." Successfully is spelled incorrectly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:01:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 16:01:27 +0000 Subject: [Koha-bugs] [Bug 36004] Typo in "Your concern was successfully submitted" text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36004 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |Laura.escamilla at bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:01:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 16:01:40 +0000 Subject: [Koha-bugs] [Bug 36004] Typo in "Your concern was successfully submitted" text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36004 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:18:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 16:18:06 +0000 Subject: [Koha-bugs] [Bug 36004] Typo in "Your concern was successfully submitted" text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36004 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:18:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 16:18:08 +0000 Subject: [Koha-bugs] [Bug 36004] Typo in "Your concern was successfully submitted" text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36004 --- Comment #1 from Laura Escamilla --- Created attachment 161785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161785&action=edit Bug 36004: Fixed typo in successfully To test: 1. Turn on the syspref 'OpacCatalogConcerns' 2. Go to view a record in the OPAC and click on "Report a concern" in the column located on the right-hand side. 3. Fill out the title on the form and leave everything else the same. Click on submit and notice that the message on the screen says "Your concern was sucessfully submitted." 4. Apply the patch. 5. Submit a new concern. Notice that the text now has "successfully" spelled correctly. 6. Sign off and have a great day! :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:23:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 16:23:32 +0000 Subject: [Koha-bugs] [Bug 36004] Typo in "Your concern was successfully submitted" OPAC text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36004 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Typo in "Your concern was |Typo in "Your concern was |successfully submitted" |successfully submitted" |text |OPAC text -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:25:28 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 16:25:28 +0000 Subject: [Koha-bugs] [Bug 25667] Add field for items.notforloan_on to record when a notforloan status is applied In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25667 --- Comment #5 from Sara Porter --- This would be particularly useful if notforloan_on contained a date even when notforloan was changed to 0. It would give us a simple way to track when items became available. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:26:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 16:26:18 +0000 Subject: [Koha-bugs] [Bug 36005] New: Typo in "Your concern was successfully submitted" Staff Intranet text Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36005 Bug ID: 36005 Summary: Typo in "Your concern was successfully submitted" Staff Intranet text Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: Laura.escamilla at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com To recreate: 1. Turn on the syspref 'CatalogConcerns' 2. Go to view a record in the staff intranet and click on "New catalog concern" which is located in the "+New" dropdown. 3. Fill out the title on the form and leave everything else the same. Click on submit and notice that the message on the screen says "Your concern was sucessfully submitted." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:31:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 16:31:30 +0000 Subject: [Koha-bugs] [Bug 36005] Typo in "Your concern was successfully submitted" Staff Intranet text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36005 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:31:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 16:31:32 +0000 Subject: [Koha-bugs] [Bug 36005] Typo in "Your concern was successfully submitted" Staff Intranet text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36005 --- Comment #1 from Laura Escamilla --- Created attachment 161786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161786&action=edit Bug 36005: Fixed typo in "Your concern was successfully submitted." text To test: 1. Turn on the syspref 'CatalogConcerns' 2. Go to view a record in the staff intranet and click on "New catalog concern" which is located in the "+New" dropdown. 3. Fill out the title on the form and leave everything else the same. Click on submit and notice that the message on the screen says "Your concern was sucessfully submitted." 4. Apply the patch. 5. Refresh the page and submit a new concern. Notice that the message now has "successfully" spelled correctly. 6. Sign off and have a wonderful day! :D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:32:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 16:32:17 +0000 Subject: [Koha-bugs] [Bug 36005] Typo in "Your concern was successfully submitted" Staff Intranet text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36005 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |Laura.escamilla at bywatersolu |ity.org |tions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:32:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 16:32:31 +0000 Subject: [Koha-bugs] [Bug 32137] Use current patron contact info when resending notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32137 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #5 from Christopher Brannon --- It seems at some point this was fixed. Not sure when. But is not an issue in 23.05, after doing some recent tests. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:41:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 16:41:15 +0000 Subject: [Koha-bugs] [Bug 35457] Move SerialsDefaultEMailAddress and SerialsDefaultReplyTo to serials preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35457 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:41:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 16:41:17 +0000 Subject: [Koha-bugs] [Bug 35457] Move SerialsDefaultEMailAddress and SerialsDefaultReplyTo to serials preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35457 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161543|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 161787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161787&action=edit Bug 35457: Move SerialsDefaultEMailAddress and SerialsDefaultReplyTo to serials preferences This patch moved the SerialsDefaultEMailAddress system preference and the SerialsDefaultReplyTo system preference to the Serials preferences. To test: 1. Apply patch 2. Go to Administration > System preferences > Acquisitions --> SerialsDefaultEMailAddress and SerialsDefaultReplyTo should not be there 3. Go to Administration > System preferences > Serials --> There should be a new section called "Notifications" with the two system preferences Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:43:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 16:43:01 +0000 Subject: [Koha-bugs] [Bug 35457] Move SerialsDefaultEMailAddress and SerialsDefaultReplyTo to serials preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35457 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com CC| |david at davidnind.com --- Comment #5 from David Nind --- Changed assignee. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:52:44 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 16:52:44 +0000 Subject: [Koha-bugs] [Bug 35357] Item not removed from holds queue when checked out to a different patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35357 --- Comment #8 from Kyle M Hall --- (In reply to Victor Grousset/tuxayo from comment #6) > While testing, found this that is not due to this patch but related: > > When canceling a hold, it stays in the hold queue. Is that bad? It stays > until the next queue rebuild (15min is said to be the usual delay) See Bug 35997 for the fix for that! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 18:07:23 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 17:07:23 +0000 Subject: [Koha-bugs] [Bug 36004] Typo in "Your concern was successfully submitted" OPAC text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36004 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 18:07:25 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 17:07:25 +0000 Subject: [Koha-bugs] [Bug 36004] Typo in "Your concern was successfully submitted" OPAC text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36004 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161785|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 161788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161788&action=edit Bug 36004: Fixed typo in successfully To test: 1. Turn on the syspref 'OpacCatalogConcerns' 2. Go to view a record in the OPAC and click on "Report a concern" in the column located on the right-hand side. 3. Fill out the title on the form and leave everything else the same. Click on submit and notice that the message on the screen says "Your concern was sucessfully submitted." 4. Apply the patch. 5. Submit a new concern. Notice that the text now has "successfully" spelled correctly. 6. Sign off and have a great day! :D Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 18:12:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 17:12:30 +0000 Subject: [Koha-bugs] [Bug 35357] Item not removed from holds queue when checked out to a different patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35357 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 18:12:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 17:12:32 +0000 Subject: [Koha-bugs] [Bug 35357] Item not removed from holds queue when checked out to a different patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35357 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161009|0 |1 is obsolete| | Attachment #161010|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 161789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161789&action=edit Bug 35357: Add unit test Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 18:12:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 17:12:40 +0000 Subject: [Koha-bugs] [Bug 35357] Item not removed from holds queue when checked out to a different patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35357 --- Comment #10 from Kyle M Hall --- Created attachment 161790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161790&action=edit Bug 35357: Remove item from holds queue when it is checked out Test Plan: 1) Place a hold on an item 2) Build the holds queue 3) Check out the item to a different patron than the one targeted in the holds queue 4) Verify the holds queue viewer still shows that item and patron 5) Apply this patch 6) Repeat stepts 1 through 3 7) Verify the holds queue viewer no longer shows that patron and item! Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 18:12:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 17:12:42 +0000 Subject: [Koha-bugs] [Bug 35357] Item not removed from holds queue when checked out to a different patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35357 --- Comment #11 from Kyle M Hall --- Created attachment 161791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161791&action=edit Bug 35357: Enhance unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 18:13:43 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 17:13:43 +0000 Subject: [Koha-bugs] [Bug 35357] Item not removed from holds queue when checked out to a different patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35357 --- Comment #12 from Kyle M Hall --- (In reply to Victor Grousset/tuxayo from comment #5) > > 7) Verify the holds queue viewer no longer shows that patron and item! > > The next run of misc/cronjobs/holds/build_holds_queue.pl brings back that > patron and item in the Holds queue page. So back with the initial issue :( I am unable to recreate that. If you can please submit a new bug report as that would be a different bug! > QA script unhappy: > WARN t/db_dependent/HoldsQueue.t > WARN tidiness > The file is less tidy than before (bad/messy lines before: 484, now: 488) Fixed! > minor finding: > The test uses a record level hold instead of an item level one. It works > because there is one item for the record. Otherwise reproducing the bug > would depend on which item is picked. IIUC it has to be the one suggested by > the hold queue to get the issue. > So maybe a comment is needed to say that the test tests the case where the > checked out item is the one suggested by the hold queue. Or make it do an > item level hold like in the test plan. That is correct, it is always the one suggested by the holds queue. I have enhanced the unit tests to prove this is the case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 18:15:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 17:15:24 +0000 Subject: [Koha-bugs] [Bug 35357] Item not removed from holds queue when checked out to a different patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35357 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161791|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 161792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161792&action=edit Bug 35357: Enhance unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 18:52:10 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 17:52:10 +0000 Subject: [Koha-bugs] [Bug 35927] Selecting MARC framework again doesn't work when adding to basket from an external source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35927 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #2 from David Nind --- I'm not seeing this on the current master. Are there any additional steps I need to do? Happy to sign off if this is aimed at improving the code and no change in behavour. Or should I test using Ubuntu Focal as the operating system? How I tested: 1. Go to Acquisitions, then click 'Search'. 2. Select 'My Basket' > Add to basket > From an external source. 3. In the 'Order from external source' form: - Title: DITA best practices - Select MARC framework: select another framework, such as 'Books. Booklets, Workbooks' 4. For actions, select +Order. 5. Complete the required fields and click 'Add item'. 6. Complete the accounting details form and click 'Save'. 7. Edit the newly created record. 8. Under the Settings menu, the framework should be the same as you selected in step 3. Note: If I repeat and add the same record again (for duplicate warning: create new record), the new record shows as the default framework. (I'm not sure why you would do this, but it is possible to. The patch doesn't fix this.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 18:59:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 17:59:26 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 Esther Melander changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander at bywatersolu | |tions.com --- Comment #29 from Esther Melander --- I agree that moving the 001 control number of an incoming authority record to the 035 needs to happen. Some third party suppliers of authority records are using the 001 for their control number. Once that record is imported, the third party control number is lost. On the next round of authority updates it then becomes impossible to match and overlay those records. If the incoming authority is missing the corresponding 003, then it should just be left off when the number is copied over to the 035. If this copying action is done, then the 003 should be the local organizations code or blank if not defined. The current work around is to edit the authorities using MarcEdit to move/copy the 001 control number to the 035 before importing. A task that could be pretty tedious when there are thousands of records that need to be imported and overlaid every three months. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 19:04:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 18:04:07 +0000 Subject: [Koha-bugs] [Bug 35943] SQL reports groups/subgroups whose name contains regexp special characters break table filtering In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35943 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 19:04:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 18:04:09 +0000 Subject: [Koha-bugs] [Bug 35943] SQL reports groups/subgroups whose name contains regexp special characters break table filtering In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35943 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161645|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 161793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161793&action=edit Bug 35943: Fix group/subgroup filtering of saved reports Use code instead of name for filtering and escape regexp special characters. This patch also disables datatables' smart filtering as it is not recommended to use with regexp filtering https://datatables.net/reference/api/search() Test plan: 1. Create a report in a group named "Foo + Bar" and in a subgroup named "Baz + Quux" 2. Create other reports in group "Foo + Bar" but in other subgroups, as well as in other groups. This is useful to see the effect of filtering 3. Go to the saved reports page and verify that navigating between tabs have the desired result. Same for the subgroup select Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 19:53:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 18:53:35 +0000 Subject: [Koha-bugs] [Bug 35997] Cancelling a hold should remove the hold from the queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 Brendan Lawlor changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 19:53:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 18:53:37 +0000 Subject: [Koha-bugs] [Bug 35997] Cancelling a hold should remove the hold from the queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 Brendan Lawlor changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161767|0 |1 is obsolete| | --- Comment #3 from Brendan Lawlor --- Created attachment 161794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161794&action=edit Bug 35997: Cancelling a hold should remove the hold from the queue Test plan: 1) Place a hold for a record for a patron 2) Build the holds queue 3) Note the holds queue contains a match for that patron and record 4) Cancel the holds queue 5) Reload the holds queue page, note the match for that patron and record is gone! Signed-off-by: Brendan Lawlor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 19:59:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 18:59:12 +0000 Subject: [Koha-bugs] [Bug 35997] Cancelling a hold should remove the hold from the queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 Brendan Lawlor changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor at clamsnet.org --- Comment #4 from Brendan Lawlor --- Testing notes 1. Placed holds 2. Find the script and run it: git grep build_holds_queue cd misc/cronjobs/holds/ perl build_holds_queue.pl 3. Check http://localhost:8081/cgi-bin/koha/circ/view_holdsqueue.pl 4. Cancel holds and refresh the page The holds were removed from the queue! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 20:01:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 19:01:50 +0000 Subject: [Koha-bugs] [Bug 2635] Allow validation of price related item fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2635 Esther Melander changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander at bywatersolu | |tions.com --- Comment #9 from Esther Melander --- To be clear, would this bug validate the 952$g (Cost, normal purchase price) and 952$v (Cost, replacement price)? Bug 34169 added validation of monetary fields in acquisitions, but it did not include the item form used in acquisitions. In general it would be nice if it was included both in acquisitions and when editing/adding an item record to a bibliographic record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 20:16:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 19:16:47 +0000 Subject: [Koha-bugs] [Bug 2635] Allow validation of price related item fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2635 --- Comment #10 from Chris Nighswonger --- (In reply to Esther Melander from comment #9) > To be clear, would this bug validate the 952$g (Cost, normal purchase price) > and 952$v (Cost, replacement price)? > > Bug 34169 added validation of monetary fields in acquisitions, but it did > not include the item form used in acquisitions. In general it would be nice > if it was included both in acquisitions and when editing/adding an item > record to a bibliographic record. In another four years this bug will turn 20... wow! I really do not recall much of anything about this as it has been so long. Reading back, it appears that work I did for LL never made it into the public repo. Sad. Maybe someone currently working on the project can comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 20:50:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 19:50:50 +0000 Subject: [Koha-bugs] [Bug 36006] New: Patron notification methods Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36006 Bug ID: 36006 Summary: Patron notification methods Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org Patrons have the option to turn on or off any notifications for any of the methods available (email, print, sms, phone). Could we offer another method that allows them to be notified when they login to their account? So, basically, when selected for a particular notice, the notice appears in their opac messages. When they mark it as read, there could be an indicator in the staff side next to that notice when they marked it read. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 21:01:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 20:01:12 +0000 Subject: [Koha-bugs] [Bug 11583] Add WYSIWYG editor for HTML notices/letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11583 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org Status|RESOLVED |REOPENED Resolution|WISHLIST |--- --- Comment #5 from Christopher Brannon --- I would like to see this. If we select HTML in the template, we should be able to see it and format with tools like we can everywhere else. This would be a very welcome enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 21:04:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 20:04:07 +0000 Subject: [Koha-bugs] [Bug 35907] Add ability to log all custom report runs with or without query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35907 Brendan Lawlor changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor at clamsnet.org --- Comment #7 from Brendan Lawlor --- I tried testing this but couldn't find the log files /tmp/report-time.log and /tmp/report-query.log I may be missing a step. 1. Applied the patch 2. Added the provided config to /koha/etc/log4perl.conf 3. restart_all 4. Set all Logging system prefs to 'Log' 5. Ran some reports 6. Check /tmp for report-time.log and report-query.log There were files in /tmp but none name like that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 21:05:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 20:05:53 +0000 Subject: [Koha-bugs] [Bug 30515] Move Overdue transports to patron messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33459 CC| |cbrannon at cdalibrary.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 21:05:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 20:05:53 +0000 Subject: [Koha-bugs] [Bug 33459] Patrons need messaging preferences for other notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33459 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30515 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 21:06:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 20:06:39 +0000 Subject: [Koha-bugs] [Bug 30515] Move Overdue transports to patron messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36006 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 21:06:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 20:06:39 +0000 Subject: [Koha-bugs] [Bug 36006] Patron notification methods In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36006 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30515 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 21:35:44 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 20:35:44 +0000 Subject: [Koha-bugs] [Bug 36007] New: Add the ability to batch edit in Course Reserves Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36007 Bug ID: 36007 Summary: Add the ability to batch edit in Course Reserves Change sponsored?: --- Product: Koha Version: 23.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It would be nice to have the ability to batch edit in course reserves. A scenario could be, a course is reactivated, the items in the course are the same, but they all need to be relocated for the course is happening at a different branch, or a different reserve location. A batch edit would allow staff to retain the list of items in the course, but easily update the new course reserves values. At this time, each item would need to be individually edited. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 21:49:29 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 20:49:29 +0000 Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 --- Comment #21 from Martin Renvoize --- Not with how the API embeds get translated. The real fix is to fix our database field names and database table names to generally be consistency.. but that would upset everyone with reports. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 22:12:56 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 21:12:56 +0000 Subject: [Koha-bugs] [Bug 35836] search_for_data_inconsistencies.pl - Search for loops in dependencies. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35836 Matthias Le Gac changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 22:39:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 21:39:35 +0000 Subject: [Koha-bugs] [Bug 36006] New patron notification method to show notice in patron account in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36006 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron notification methods |New patron notification | |method to show notice in | |patron account in OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 22:43:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 21:43:03 +0000 Subject: [Koha-bugs] [Bug 35836] search_for_data_inconsistencies.pl - Search for loops in dependencies. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35836 Matthias Le Gac changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Matthias Le Gac --- were I can know which lines are bad ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 22:50:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 21:50:08 +0000 Subject: [Koha-bugs] [Bug 36007] Add the ability to batch edit in Course Reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36007 Beth changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bboehm at waynesburg.edu --- Comment #1 from Beth --- I would like to add that if we enable a course that was previously disabled, the location (say Reserve)does not automatically return to Reserve. It would be great to be able to batch edit the location. Hopefully the system will still retain the previous shelf location before it was placed on Reserve. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 23:07:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 22:07:52 +0000 Subject: [Koha-bugs] [Bug 35969] opac-sendbasket: Improve error message, remove some logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35969 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 23:07:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 22:07:54 +0000 Subject: [Koha-bugs] [Bug 35969] opac-sendbasket: Improve error message, remove some logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35969 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161713|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 161795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161795&action=edit Bug 35969: Add error code in opac-sendbasket.pl No need to carp about empty basket or no reply address. Just add a simple explanation on the form. Note that it makes no sense to show the form if the patron has no email address. We need it as reply-to. Test plan: Try opac-sendbasket.pl?bib_list=null Remove email address from your account, try again. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 23:31:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 22:31:39 +0000 Subject: [Koha-bugs] [Bug 35969] opac-sendbasket: Improve error message, remove some logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35969 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #5 from David Nind --- I've signed off, as I think having better messages is great. Some suggestions: There was an error sending the cart: No valid biblio records found. > There was an error sending the cart: no valid records were found. Since we do not have your email address, we cannot send a mail. We need your email address as reply-to address. > There was an error sending the cart: we cannot send an email as there is no email address recorded for your account (your email address is used for the reply to address). Testing notes (using KTD): 1. Go to http://127.0.0.1:8080/cgi-bin/koha/opac-sendbasket.pl?bib_list=null 2. Log in as koha/koha 3. Add an email address to the form and click 'Send': me at example.com 4. Error message displayed: "There was an error sending the cart." 5. Note the warning in the log: /var/log/koha/kohadev/plack-opac-error.log 6. Apply the patch 7. Repeat steps 1-3 8. Note that the error displayed is now: "Since we do not have your email address, we cannot send a mail. We need your email address as reply-to address." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 23:35:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 22:35:35 +0000 Subject: [Koha-bugs] [Bug 23978] Notes field in saved reports should allow for HTML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 --- Comment #7 from David Cook --- (In reply to Martin Renvoize from comment #6) > Is there a more secure way of doing this rather than just exposing the raw > html.. I feel like we're just undoing a security flaw we fixed for a reason. Yeah I don't think we can just expose the raw HTML. One option would be to use the HTML scrubber. I think there are quite a few parts of Koha where people want to use HTML, but could be limited to a fairly small subset of elements and attributes. > Is it time to use markdown for rich text or perhaps for linebreaks just > outputting the note field in a pre/code block? For line breaks, the "html_line_break" filter can be useful. For notes, adding that line break filter would make sense. I don't know that any other HTML features would really needed though. If they were to be added, I think we'd have to scrub them first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 23:47:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 22:47:16 +0000 Subject: [Koha-bugs] [Bug 35943] SQL reports groups/subgroups whose name contains regexp special characters break table filtering In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35943 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 23:50:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 22:50:36 +0000 Subject: [Koha-bugs] [Bug 36001] Visualize MARC fields 310 and 362 for serial publications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36001 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 00:11:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 23:11:30 +0000 Subject: [Koha-bugs] [Bug 36008] New: SendAlerts should use notice_email_address instead of email Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36008 Bug ID: 36008 Summary: SendAlerts should use notice_email_address instead of email Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org C4::Letters::SendAlerts() uses $patron->email instead of $patron->notice_email_address -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 00:11:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 23:11:35 +0000 Subject: [Koha-bugs] [Bug 36008] SendAlerts should use notice_email_address instead of email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36008 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33223 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 00:11:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 23:11:35 +0000 Subject: [Koha-bugs] [Bug 33223] Koha::Patron->notice_email_address isn't consistently used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36008 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 00:16:58 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 23:16:58 +0000 Subject: [Koha-bugs] [Bug 28996] SendAlerts crashes on a bad email 'To' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28996 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |dcook at prosentient.com.au Summary|SendQueuedMessages exit on |SendAlerts crashes on a bad |a bad email 'To' and |email 'To' |following messages are | |never processed. | Resolution|DUPLICATE |--- --- Comment #6 from David Cook --- It looks like bug 28803 only covers part of the root problem. C4::Letters::SendAlerts still has the problem. I'll rename the bug title to be more accurate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 00:17:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 23:17:08 +0000 Subject: [Koha-bugs] [Bug 30324] Parent and child itemtype checkout limits not enforced as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30324 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #6 from Victor Grousset/tuxayo --- > 15: Other results should be the same 9 isn't the same. And it shouldn't be the same. Because 7 failed, it's not "2 checked out" but "1 checked out". So what happens makes sense. Thanks for the test plan with all those combination. It's great! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 00:18:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2024 23:18:16 +0000 Subject: [Koha-bugs] [Bug 28996] SendAlerts crashes on a bad email 'To' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28996 --- Comment #7 from David Cook --- The patch will need to be rewriten to take into account bug 28803 but should be an easy fix overall. (I've applied the fix locally for years. At some point this year I might find the time to upstream it.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 02:18:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 01:18:11 +0000 Subject: [Koha-bugs] [Bug 30324] Parent and child itemtype checkout limits not enforced as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30324 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |victor at tuxayo.net |y.org | Status|Signed Off |Failed QA --- Comment #7 from Victor Grousset/tuxayo --- > #Patron has 1 checkout of parent itemtype {{{{ child itype1 What does {{{{ means? My guess is that «{{{{ child itype1» isn't meant to be here. And it's just some mistyping in vim ^^ +# my $circ_rule_object = +# Koha::CirculationRules->find( $parent_iq_rule->{id} ); +# $circ_rule_object->rule_value(4)->store(); --- There is a probably forgotten comment: +# my $circ_rule_object = +# Koha::CirculationRules->find( $parent_iq_rule->{id} ); +# $circ_rule_object->rule_value(4)->store(); Otherwise, all seems to work as it should and code looks good :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 03:02:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 02:02:05 +0000 Subject: [Koha-bugs] [Bug 35357] Item not removed from holds queue when checked out to a different patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35357 --- Comment #14 from Victor Grousset/tuxayo --- (In reply to Katrin Fischer from comment #7) > (In reply to Victor Grousset/tuxayo from comment #6) > > While testing, found this that is not due to this patch but related: > > > > When canceling a hold, it stays in the hold queue. Is that bad? It stays > > until the next queue rebuild (15min is said to be the usual delay) > > Please keep in mind that build_holdsqueue is no longer the only use case. We > have RTHoldsqueue without people running the script or only running it > nightly now. Indeed thanks for pointing this out. (confirmed that the RTHQ doesn't suffer from the bug here) --- Thanks Kyle for the followups, I'll looks at them asap and again at the issue at step 7. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 05:05:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 04:05:38 +0000 Subject: [Koha-bugs] [Bug 35953] Add delete_any_record cataloguing subpermission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35953 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 08:17:25 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 07:17:25 +0000 Subject: [Koha-bugs] [Bug 36009] New: Document koha-worker --queue elastic_index Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36009 Bug ID: 36009 Summary: Document koha-worker --queue elastic_index Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz koha-worker --help currently says: --queue Specify the queue/worker to restart - 'default' is used if not specified current queues are: default, long_tasks We should add elastic_index to the "current queues". "man koha-worker" only says: Allows specifying the queue worker (defaults to 'default'). It would probably make sense to add a line about the actual queues there too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 08:25:58 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 07:25:58 +0000 Subject: [Koha-bugs] [Bug 36010] New: Items/AutomaticItemModificationByAge.t is failing randomly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010 Bug ID: 36010 Summary: Items/AutomaticItemModificationByAge.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 32029 koha_1 | # Failed test 'ToggleNewStatus: conditions on biblio' koha_1 | # at t/db_dependent/Items/AutomaticItemModificationByAge.t line 356. koha_1 | # got: 'agefield_new_value' koha_1 | # expected: 'new_updated_value_biblio' koha_1 | # Looks like you failed 1 test of 20. Koha_Master_My8/1279 First failure from this one that has been pushed recently. I don't recreate locally (even using MySQL8). Maybe something to do with the age comparison if the node is slow? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32029 [Bug 32029] Automatic item modifications by age missing biblio table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 08:25:58 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 07:25:58 +0000 Subject: [Koha-bugs] [Bug 32029] Automatic item modifications by age missing biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32029 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36010 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010 [Bug 36010] Items/AutomaticItemModificationByAge.t is failing randomly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 08:26:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 07:26:24 +0000 Subject: [Koha-bugs] [Bug 32029] Automatic item modifications by age missing biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32029 --- Comment #20 from Jonathan Druart --- It caused a failure, see bug 36010 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 08:28:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 07:28:12 +0000 Subject: [Koha-bugs] [Bug 36010] Items/AutomaticItemModificationByAge.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Items/AutomaticItemModifica |Items/AutomaticItemModifica |tionByAge.t is failing |tionByAge.t is failing |randomly | Status|NEW |ASSIGNED Assignee|chris at bigballofwax.co.nz |fridolin.somers at biblibre.co | |m --- Comment #1 from Jonathan Druart --- It is actually failing consistently, see https://jenkins.koha-community.org/job/Koha_Master_My8/1274/ https://jenkins.koha-community.org/job/Koha_Master_My8/1275/ https://jenkins.koha-community.org/job/Koha_Master_My8/1276/ https://jenkins.koha-community.org/job/Koha_Master_My8/1277/ https://jenkins.koha-community.org/job/Koha_Master_My8/1278/ https://jenkins.koha-community.org/job/Koha_Master_My8/1279/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 08:47:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 07:47:49 +0000 Subject: [Koha-bugs] [Bug 34927] Adding DMARC compatibility to mailing lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34927 --- Comment #16 from Jonathan Druart --- (In reply to Jonathan Druart from comment #15) > Still missing > koha-es > koha-gr > koha-i18n-ar > koha-oz > koha-security Done now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 08:57:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 07:57:02 +0000 Subject: [Koha-bugs] [Bug 36009] Document koha-worker --queue elastic_index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36009 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 08:57:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 07:57:05 +0000 Subject: [Koha-bugs] [Bug 36009] Document koha-worker --queue elastic_index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36009 --- Comment #1 from Magnus Enger --- Created attachment 161796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161796&action=edit Bug 36009: Document koha-worker --queue elastic_index To test: - Copy the koha-worker script to the standard location: $ sudo cp debian/scripts/koha-worker /usr/sbin/koha-worker - Check "sudo koha-worker --help" and verify elastic_index is mentioned in the list of "current queues" - See https://wiki.koha-community.org/wiki/Testing_man_pages for how to check the "man" page. There should be a new paragraph about "Current queues" under "--queue" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 09:34:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 08:34:41 +0000 Subject: [Koha-bugs] [Bug 36011] New: 2FA authentication failure is incorrectly logged Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36011 Bug ID: 36011 Summary: 2FA authentication failure is incorrectly logged Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: ola.andersson at ltu.se QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org A user failing to sign in four times with a correct username/password but incorrect 2FA passcode will incorrectly yield four records in action_logs with AUTH SUCCESS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 09:34:51 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 08:34:51 +0000 Subject: [Koha-bugs] [Bug 36011] 2FA authentication failure is incorrectly logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36011 Ola Andersson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ola.andersson at ltu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 09:35:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 08:35:38 +0000 Subject: [Koha-bugs] [Bug 36011] 2FA authentication failure is incorrectly logged as success In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36011 Ola Andersson changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|2FA authentication failure |2FA authentication failure |is incorrectly logged |is incorrectly logged as | |success -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 09:40:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 08:40:26 +0000 Subject: [Koha-bugs] [Bug 36012] New: ERM/Agreements_spec.ts is failing if run too slow (?) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36012 Bug ID: 36012 Summary: ERM/Agreements_spec.ts is failing if run too slow (?) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org koha_1 | Running: ERM/Agreements_spec.ts (3 of 13) es_1 | {"type": "server", "timestamp": "2024-02-06T16:59:14,821Z", "level": "WARN", "component": "o.e.c.r.a.DiskThresholdMonitor", "cluster.name": "docker-cluster", "node.name": "9c98971d8b48", "message": "high disk watermark [90%] exceeded on [ZlMDdHYSRcqipOaGsczI_w][9c98971d8b48][/usr/share/elasticsearch/data/nodes/0] free: 2.3gb[5.9%], shards will be relocated away from this node; currently relocating away shards totalling [0] bytes; the node is expected to continue to exceed the high disk watermark when these relocations are complete", "cluster.uuid": "wwW7XQ57T-SNI8QrMEYbPA", "node.id": "ZlMDdHYSRcqipOaGsczI_w" } koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | (http://localhost:8081/__cypress/runner/cypress_runner.js:134844:28) koha_1 | at tryCatcher (http://localhost:8081/__cypress/runner/cypress_runner.js:1807:23) koha_1 | at Promise.attempt.Promise.try (http://localhost:8081/__cypress/runner/cypress_runner.js:4315:29) koha_1 | at whenStable (http://localhost:8081/__cypress/runner/cypress_runner.js:143192:68) koha_1 | at (http://localhost:8081/__cypress/runner/cypress_runner.js:143133:14) koha_1 | at tryCatcher (http://localhost:8081/__cypress/runner/cypress_runner.js:1807:23) koha_1 | at Promise._settlePromiseFromHandler (http://localhost:8081/__cypress/runner/cypress_runner.js:1519:31) koha_1 | at Promise._settlePromise (http://localhost:8081/__cypress/runner/cypress_runner.js:1576:18) koha_1 | at Promise._settlePromise0 (http://localhost:8081/__cypress/runner/cypress_runner.js:1621:10) koha_1 | at Promise._settlePromises (http://localhost:8081/__cypress/runner/cypress_runner.js:1701:18) koha_1 | at Promise._fulfill (http://localhost:8081/__cypress/runner/cypress_runner.js:1645:18) koha_1 | at (http://localhost:8081/__cypress/runner/cypress_runner.js:5450:46) koha_1 | From Your Spec Code: koha_1 | at Context.eval (webpack://koha/./t/cypress/integration/ERM/Agreements_spec.ts:119:11)]]> koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | I do not recreate locally, is it because we need to extend the timeout? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 09:40:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 08:40:46 +0000 Subject: [Koha-bugs] [Bug 36012] ERM/Agreements_spec.ts is failing if run too slow (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36012 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com, | |pedro.amorim at ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 10:46:10 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 09:46:10 +0000 Subject: [Koha-bugs] [Bug 36012] ERM/Agreements_spec.ts is failing if run too slow (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36012 --- Comment #1 from Jonathan Druart --- This was Koha_Master/2795 I scheduled another run (2796) and now it's InfiniteScrollSelect_spec that is getting a timeout koha_1 | Running: InfiniteScrollSelect_spec.ts (1 of 13) koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 10:52:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 09:52:35 +0000 Subject: [Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755 Michaela Sieber changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Michaela Sieber --- We tested OPAC and staff and had no error messages. Thank you so much! Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 11:00:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 10:00:09 +0000 Subject: [Koha-bugs] [Bug 36012] ERM/Agreements_spec.ts is failing if run too slow (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36012 --- Comment #2 from Matt Blenkinsop --- Maybe we do need to try upping the timeout - all tests are passing locally Can we set the Jenkins run to produce and save the cypress videos? That way we may be able to see if there's anything we're missing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 11:08:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 10:08:52 +0000 Subject: [Koha-bugs] [Bug 36013] New: update_totalissues.pl should not log Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36013 Bug ID: 36013 Summary: update_totalissues.pl should not log Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Even when CataloguingLog is on, misc/cronjobs/update_totalissues.pl should not log the changes. It is useless and takes database space. Do like bulkmarcimport.pl : https://git.koha-community.org/Koha-community/Koha/src/branch/23.11.x/misc/migration_tools/bulkmarcimport.pl#L165 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 11:09:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 10:09:13 +0000 Subject: [Koha-bugs] [Bug 36013] update_totalissues.pl should not log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36013 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 11:14:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 10:14:01 +0000 Subject: [Koha-bugs] [Bug 36014] New: set library does not display the updated library Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36014 Bug ID: 36014 Summary: set library does not display the updated library Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 24786 From commit 5b1934312b87f8458de84d96421106774dbd95a8 Bug 24786: Allow setting a register for the session - [% IF ( update.updated_branch ) %] + [% IF ( update.updated_branch || update.updated_desk || update.updated_register ) %] + [% IF ( updated.updated.branch ) %] This change is wrong. It must be update.updated_branch. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 [Bug 24786] Allow setting a cash register for a login session and configuring library-default cash registers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 11:14:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 10:14:01 +0000 Subject: [Koha-bugs] [Bug 24786] Allow setting a cash register for a login session and configuring library-default cash registers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36014 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36014 [Bug 36014] set library does not display the updated library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 11:14:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 10:14:36 +0000 Subject: [Koha-bugs] [Bug 36014] set library does not display the updated library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36014 --- Comment #1 from Jonathan Druart --- Provide a patch for stables only. Master will get a fix on bug 34478. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 11:15:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 10:15:18 +0000 Subject: [Koha-bugs] [Bug 36013] update_totalissues.pl should not log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36013 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 11:15:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 10:15:20 +0000 Subject: [Koha-bugs] [Bug 36013] update_totalissues.pl should not log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36013 --- Comment #1 from Fridolin Somers --- Created attachment 161797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161797&action=edit Bug 36013: update_totalissues.pl should not log Even when CataloguingLog is on, misc/cronjobs/update_totalissues.pl should not log the changes. It is useless and takes database space. Do like bulkmarcimport.pl : https://git.koha-community.org/Koha-community/Koha/src/branch/23.11.x/misc/migration_tools/bulkmarcimport.pl#L165 Test plan : 1) Enable system preference CataloguingLog 2) Perform some issues and returns 3) Run : misc/cronjobs/update_totalissues.pl --use-stats --commit=1000 -v 4) Go to Tools > Log viewer 5) Check there are no new cataloguing logs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 12:08:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 11:08:17 +0000 Subject: [Koha-bugs] [Bug 26268] Remove items.paid for once and for all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim at ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 12:29:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 11:29:24 +0000 Subject: [Koha-bugs] [Bug 35474] Add icon for protected patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35474 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |ASSIGNED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize --- RMaint assist: Reverted from 23.05.x for 23.05.10 as this depends on an enhancement not pushed to this branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 12:29:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 11:29:30 +0000 Subject: [Koha-bugs] [Bug 35474] Add icon for protected patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35474 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 12:29:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 11:29:37 +0000 Subject: [Koha-bugs] [Bug 35474] Add icon for protected patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35474 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 12:33:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 11:33:50 +0000 Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 --- Comment #22 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #17) > A bit late, but wondering why active_orders include completed lines ? Looks > a bit strange to me.. Looking at Koha::Acquisition::Orders it feels like I might have mixed 'current' vs. 'active'. So a terminology problem. And 'filter_by_active' seems to have a wrong POD (should be 'filtering OUT orders that are not active'). We could have a problem with this embed in 'biblio.active_orders+count' in /acquisitions/orders. Please file a bug! (In reply to Marcel de Rooy from comment #20) > Yeah no problem. But couldnt you add an ->orders method and use the aqorders > relation inside. Preventing custom relations in DBIx schema? We could even do it the other way around: not having any automatic relationship generated, and only define what we are gonna use! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 12:35:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 11:35:02 +0000 Subject: [Koha-bugs] [Bug 34063] items.paidfor and deleteditems.paidfor still sometimes exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34063 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim at ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 12:50:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 11:50:32 +0000 Subject: [Koha-bugs] [Bug 35907] Add ability to log all custom report runs with or without query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35907 --- Comment #8 from Kyle M Hall --- (In reply to Brendan Lawlor from comment #7) > I tried testing this but couldn't find the log files /tmp/report-time.log > and /tmp/report-query.log > > I may be missing a step. > 1. Applied the patch > 2. Added the provided config to /koha/etc/log4perl.conf > 3. restart_all > 4. Set all Logging system prefs to 'Log' > 5. Ran some reports > 6. Check /tmp for report-time.log and report-query.log > > There were files in /tmp but none name like that. I just ran through the test plan and I can confirm it's still working as intended! Here is a video demonstration using runreport.pl: https://monosnap.com/file/CcQHcG8kTlJhvOpXxOITdWc5wj5eea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 12:53:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 11:53:12 +0000 Subject: [Koha-bugs] [Bug 34479] Clear saved patron search selections after certain actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 --- Comment #33 from Martin Renvoize --- Created attachment 161798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161798&action=edit Bug 34479: (RMaint follow-up) Correct selectors for 23.05.x We renamed patron_search_selected to table_search_selections in upstream, but missed that when backporting this bug. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 12:53:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 11:53:27 +0000 Subject: [Koha-bugs] [Bug 34479] Clear saved patron search selections after certain actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 --- Comment #34 from Martin Renvoize --- Follow-up pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 13:14:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 12:14:14 +0000 Subject: [Koha-bugs] [Bug 36015] New: New features in batch modification template management Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36015 Bug ID: 36015 Summary: New features in batch modification template management Change sponsored?: --- Product: Koha Version: 23.11 Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: infoscienceaddict at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl As we use batch record modification quite often, we apply many templates regularly. The problem is that their number has grown significantly. It would be good to arrange them in folders so that we can separate the ones about authorities from those about bibliographic records. Also, some options to sort them (i.e. alphabetically, by description, etc.) would be great. Last but not least, it would be great if we could rename an existing template could become handy. At first, we didn't use explanatory names for each template, so now it's hard to find a template in their whole batch. I hope someone else out there thinks these would be useful! Thank you! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 14:03:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 13:03:11 +0000 Subject: [Koha-bugs] [Bug 35114] Total on basketgroup can be different than basket details total In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35114 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161691|0 |1 is obsolete| | --- Comment #12 from Thibaud Guillot --- Created attachment 161799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161799&action=edit Bug 35114: Fix calculation around basketgroup and basket details Test plan: 1) I purpose a simple way to test it with new fresh data. First of all go to one of your vendor and set a discount of 9%. Then create a new basket, add to basket a new line from an empty record. Set a vendor price to 15.90 and just add this order 2) Configure the basket.pl table to show all columns, see budgeted cost and actual cost (exc or inc). There is already a difference of one cent. 3) Let's take a look at the basket groups now, for this, close this basket. Go on tab menu and select basket group. Click on new basket group. Normally you will see the new basket created on step 1. The total here is 14.47.. and when you check on basket detail it's 14.46 cause this total (from basket groups) comes from ecost exc. while total line on basket detail comes from actual cost exc. 4) Apply this patch and see changes Sponsored-by: BibLibre -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 14:11:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 13:11:19 +0000 Subject: [Koha-bugs] [Bug 35114] Total on basketgroup can be different than basket details total In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35114 --- Comment #13 from Thibaud Guillot --- Hello everyone, I've adjusted the rounding functions and their calculation. According to the OrderPriceRounding system preference, when the get_rounded_price function was called, the prices were adjusted at the wrong time. (Note: without this patch, which corrects the use of unit price in calculations, the system preference has no effect, as the unit price is retrieved beforehand and modified in JS to round it off). Lines were rounded one by one and then the total was rounded... This can lead to problems: example: - 13.44567 -> rounded to 13.45 - 2.44567 -> rounded to 2.45 total 13.44567 + 2.44567 = 15.89134 rounded to 15.89 total 13.45 + 2.45 = 15.90 so I've kept this rounding behavior on each of the lines, but I've added a total that I calculate without rounding, and then pass the corresponding roundings to the view. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 14:11:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 13:11:57 +0000 Subject: [Koha-bugs] [Bug 35114] Calculation around basket details and basketgroup not correct In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35114 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Total on basketgroup can be |Calculation around basket |different than basket |details and basketgroup not |details total |correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 14:20:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 13:20:53 +0000 Subject: [Koha-bugs] [Bug 35114] Calculation around basket details and basketgroup not correct In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35114 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161799|0 |1 is obsolete| | --- Comment #14 from Thibaud Guillot --- Created attachment 161800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161800&action=edit Bug 35114: Fix calculation around basketgroup and basket details Test plan: 1) I purpose a simple way to test it with new fresh data. First of all go to one of your vendor and set a discount of 9%. Then create a new basket, add to basket a new line from an empty record. Set a vendor price to 15.90 and just add this order 2) Configure the basket.pl table to show all columns, see budgeted cost and actual cost (exc or inc). There is already a difference of one cent. 3) Let's take a look at the basket groups now, for this, close this basket. Go on tab menu and select basket group. Click on new basket group. Normally you will see the new basket created on step 1. The total here is 14.47.. and when you check on basket detail it's 14.46 cause this total (from basket groups) comes from ecost exc. while total line on basket detail comes from actual cost exc. 4) Apply this patch and see changes Sponsored-by: BibLibre -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 14:24:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 13:24:00 +0000 Subject: [Koha-bugs] [Bug 28151] Missing documentation on variable "access_dir" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28151 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #2 from Magnus Enger --- Would it make sense to hide "Tools > Access files" from the Tools main page, if the config is not activated? As it stands now, it looks like something was supposed to be shown there, but it is not shown because someone forgot to configure something. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 14:38:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 13:38:16 +0000 Subject: [Koha-bugs] [Bug 36003] Printing list from OPAC shows "Cookies" when CookieConsent enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36003 --- Comment #1 from Martin Renvoize --- Created attachment 161801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161801&action=edit Bug 36003: Add cookie consent buttons to hidden list on print This patch adds #consentMoreInfo, #cookieConsentFooter and .consentAcceptEssential to the hidden fields for OPAC printing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 14:39:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 13:39:07 +0000 Subject: [Koha-bugs] [Bug 36003] Printing list from OPAC shows "Cookies" when CookieConsent enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36003 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Depends on| |35348 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35348 [Bug 35348] Cookie information should be available regardless of whether you are logged in or not -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 14:39:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 13:39:07 +0000 Subject: [Koha-bugs] [Bug 35348] Cookie information should be available regardless of whether you are logged in or not In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35348 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36003 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36003 [Bug 36003] Printing list from OPAC shows "Cookies" when CookieConsent enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 14:40:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 13:40:27 +0000 Subject: [Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 --- Comment #18 from Martin Renvoize --- Considering this series is a set that really aught to have been included in 23.11.00.. I'm a little disappointed they're still stuck waiting for QA :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 14:41:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 13:41:00 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 14:41:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 13:41:54 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #194 from Martin Renvoize --- There's a whole set of follow-up bugs dealt with 3 months ago that should really have been in the first point release.. why is it taking so long to work through QA queues :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 14:42:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 13:42:11 +0000 Subject: [Koha-bugs] [Bug 36003] Printing list from OPAC shows "Cookies" when CookieConsent enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36003 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 14:42:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 13:42:17 +0000 Subject: [Koha-bugs] [Bug 36003] Printing list from OPAC shows "Cookies" when CookieConsent enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36003 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 14:45:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 13:45:16 +0000 Subject: [Koha-bugs] [Bug 36013] update_totalissues.pl should not log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36013 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21487 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 14:45:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 13:45:16 +0000 Subject: [Koha-bugs] [Bug 21487] Add option to disable CataloguingLog syspref in UNIMARC_sync_date_created_with_marc_biblio.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21487 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36013 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 14:45:56 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 13:45:56 +0000 Subject: [Koha-bugs] [Bug 36013] update_totalissues.pl should not log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36013 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10326 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 14:45:56 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 13:45:56 +0000 Subject: [Koha-bugs] [Bug 10326] bulkmarcimport.pl turns off CataloguingLog sys pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10326 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36013 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 14:46:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 13:46:09 +0000 Subject: [Koha-bugs] [Bug 35972] Using Course reserves module for Research table reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #1 from Martin Renvoize --- Created attachment 161802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161802&action=edit Bug 35972: Add thesis tables feature This patch adds a new 'Thesis tables' feature to Koha based on the existing 'Course reserves' system. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 14:46:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 13:46:11 +0000 Subject: [Koha-bugs] [Bug 35972] Using Course reserves module for Research table reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #2 from Martin Renvoize --- Created attachment 161803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161803&action=edit Bug 35972: Tidy for QA scripts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 14:47:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 13:47:30 +0000 Subject: [Koha-bugs] [Bug 35972] Using Course reserves module for Research table reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from Martin Renvoize --- Attached are the commits as they currently exist. Some additional tidying and modernisation will need to take place before they would pass quality assurance, but I'm interested to get some testing done and guage interest before continuing with that work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 14:48:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 13:48:24 +0000 Subject: [Koha-bugs] [Bug 35972] Using Course reserves module for Research table reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tundun.folami at uwl.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 14:48:58 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 13:48:58 +0000 Subject: [Koha-bugs] [Bug 35972] Using Course reserves module for Research table reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 14:49:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 13:49:17 +0000 Subject: [Koha-bugs] [Bug 35972] Using Course reserves module for Research table reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 14:54:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 13:54:19 +0000 Subject: [Koha-bugs] [Bug 35969] opac-sendbasket: Improve error message, remove some logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35969 --- Comment #6 from Marcel de Rooy --- Created attachment 161804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161804&action=edit Bug 35969: (follow-up) Improve wording As suggested by David Nind. Thanks! Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:01:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:01:27 +0000 Subject: [Koha-bugs] [Bug 36016] New: TrackClicks and cleanup_database.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36016 Bug ID: 36016 Summary: TrackClicks and cleanup_database.pl Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: pierre.genty at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When TrackClicks system preferences is activated, linktracker table in database will start to grow. What about adding a --linktracker option to the cleanup_database script ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:14:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:14:05 +0000 Subject: [Koha-bugs] [Bug 35993] AddBiblio should add 005 just like ModBiblio updates it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35993 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161778|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 161805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161805&action=edit Bug 35993: Apply new routine to ModBiblioMarc Now both AddBiblio and ModBiblio will insert 005 if not present. Test plan: Run t/db_dependent/Biblio.t Add biblio record via acquistion order. Check 005 in the table biblio_metadata. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:29:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:29:39 +0000 Subject: [Koha-bugs] [Bug 35907] Add ability to log all custom report runs with or without query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35907 Brendan Lawlor changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:29:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:29:41 +0000 Subject: [Koha-bugs] [Bug 35907] Add ability to log all custom report runs with or without query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35907 Brendan Lawlor changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161458|0 |1 is obsolete| | --- Comment #9 from Brendan Lawlor --- Created attachment 161806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161806&action=edit Bug 35907: Add ability to log all custom report runs with or without query Because of the way Koha::Logger has been used to log to different categories based on the interface and caller, it can be extremely hard to log all of a particular log statement to one place. For custom report runs, the category is plack-intranet.C4::Reports::Guided when run from the web interface, cron.C4::Reports::Guided when run from runreport.pl, and plack-intranet.C4::Auth when run from svc/report. We should add a more standardized report run log, both with and without the full query, so that administrators can log all report runs to a centralized location. If an administrator were to need the "point of entry" for reports, it is easy to include via parameters in PatternLayout. Test Plan: 1) Apply this patch 2) Modify your log4perl file, add the following: log4perl.logger.reports.execute.time = INFO, REPORTTIME log4perl.appender.REPORTTIME=Log::Log4perl::Appender::File log4perl.appender.REPORTTIME.filename=/tmp/report-time.log log4perl.appender.REPORTTIME.mode=append log4perl.appender.REPORTTIME.layout=PatternLayout log4perl.appender.REPORTTIME.layout.ConversionPattern=[%d] [%p] [%P] %m%n log4perl.appender.REPORTTIME.utf8=1 log4perl.logger.reports.execute.query = INFO, REPORTQUERY log4perl.appender.REPORTQUERY=Log::Log4perl::Appender::File log4perl.appender.REPORTQUERY.filename=/tmp/report-query.log log4perl.appender.REPORTQUERY.mode=append log4perl.appender.REPORTQUERY.layout=PatternLayout log4perl.appender.REPORTQUERY.layout.ConversionPattern=[%d] [%p] [%P] %m%n log4perl.appender.REPORTQUERY.utf8=1 3) Restart all the things! 4) Run a report somehow: CLI: ./misc/cronjobs/runreport.pl 1 API: /cgi-bin/koha/svc/report?id=1 Web: /cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Run this report 5) Note the report runs are logged to /tmp/report-time.log and /tmp/report-query.log Signed-off-by: Brendan Lawlor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:29:43 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:29:43 +0000 Subject: [Koha-bugs] [Bug 35907] Add ability to log all custom report runs with or without query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35907 Brendan Lawlor changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161459|0 |1 is obsolete| | --- Comment #10 from Brendan Lawlor --- Created attachment 161807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161807&action=edit Bug 35907: Tidy execute_query Signed-off-by: Brendan Lawlor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:31:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:31:38 +0000 Subject: [Koha-bugs] [Bug 35972] Add a 'Thesis tables' feature, that builds upon Course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Using Course reserves |Add a 'Thesis tables' |module for Research table |feature, that builds upon |reserves |Course reserves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:32:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:32:24 +0000 Subject: [Koha-bugs] [Bug 35972] Add a 'Research tables' feature, that builds upon Course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a 'Thesis tables' |Add a 'Research tables' |feature, that builds upon |feature, that builds upon |Course reserves |Course reserves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:36:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:36:40 +0000 Subject: [Koha-bugs] [Bug 35907] Add ability to log all custom report runs with or without query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35907 --- Comment #11 from Brendan Lawlor --- It turned out I didn't edit the correct config file in my first test. I edited /kohadevbox/koha/etc/log4perl.conf I guess maybe that is just an example config file. Thanks for showing me where the real config file is /etc/koha/sites/kohadev/log4perl.conf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:37:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:37:14 +0000 Subject: [Koha-bugs] [Bug 35978] Extend breadcrumbs Course reserves with sections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35978 --- Comment #1 from Martin Renvoize --- Created attachment 161808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161808&action=edit Bug 35978: Add 'sections' to Course Reserves We use Section to distinguish Residential from ETF Open University; This patch adds Section to the breadcrumb and title where appropriate. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:37:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:37:24 +0000 Subject: [Koha-bugs] [Bug 35978] Extend breadcrumbs Course reserves with sections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35978 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:37:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:37:35 +0000 Subject: [Koha-bugs] [Bug 35978] Extend breadcrumbs Course reserves with sections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35978 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:40:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:40:41 +0000 Subject: [Koha-bugs] [Bug 36017] New: Dead code in admin/clone-rules Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36017 Bug ID: 36017 Summary: Dead code in admin/clone-rules Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 18936 Since commit 61628c97c245e72c750b61d9df6fa9b9100f3093 Bug 18936: (follow-up) Add cloning of circulation rules back to Koha There are some dead code in admin/clone-rules. "result" is always passed to the template. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 [Bug 18936] Move issuingrules into circulation_rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:40:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:40:41 +0000 Subject: [Koha-bugs] [Bug 18936] Move issuingrules into circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36017 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36017 [Bug 36017] Dead code in admin/clone-rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:40:51 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:40:51 +0000 Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 --- Comment #23 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #22) > Looking at Koha::Acquisition::Orders it feels like I might have mixed > 'current' vs. 'active'. So a terminology problem. And 'filter_by_active' > seems to have a wrong POD (should be 'filtering OUT orders that are not > active'). We could have a problem with this embed in > 'biblio.active_orders+count' in /acquisitions/orders. > > Please file a bug! Thanks for your feedback. I came here from bug 35994 but I may open yet another bug to address the 'intermediate concerns' as you mentioned. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:43:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:43:35 +0000 Subject: [Koha-bugs] [Bug 36017] Dead code in admin/clone-rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36017 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:43:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:43:38 +0000 Subject: [Koha-bugs] [Bug 36017] Dead code in admin/clone-rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36017 --- Comment #1 from Jonathan Druart --- Created attachment 161809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161809&action=edit Bug 36017: Remove dead code in admin/clone-rules Since commit 61628c97c245e72c750b61d9df6fa9b9100f3093 Bug 18936: (follow-up) Add cloning of circulation rules back to Koha There are some dead code in admin/clone-rules. "result" is always passed to the template. Test plan: Confirm the above and that cloning rules from the circ rules page still works correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:43:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:43:59 +0000 Subject: [Koha-bugs] [Bug 36017] Dead code in admin/clone-rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36017 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34478 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:46:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:46:46 +0000 Subject: [Koha-bugs] [Bug 36018] New: Improve consistency in Acquisition/Order(s) regarding active/current orders Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36018 Bug ID: 36018 Summary: Improve consistency in Acquisition/Order(s) regarding active/current orders Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org See also bug 24430 and bug 35994. Current should be: not cancelled. Active should be: not cancelled and not completed. At least this should be the meaning in both modules and their methods. Since active and current is still quite close, perhaps we should even think about an alternative for current. We mean not cancelled, and they could be complete. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:47:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:47:13 +0000 Subject: [Koha-bugs] [Bug 36018] Improve consistency in Acquisition/Order(s) regarding active/current orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36018 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:47:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:47:48 +0000 Subject: [Koha-bugs] [Bug 36018] Improve consistency in Acquisition/Order(s) regarding active/current orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36018 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35994, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24430 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:47:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:47:48 +0000 Subject: [Koha-bugs] [Bug 35994] Need an easy way to see if biblio record or item is still in acquisition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35994 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36018 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:47:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:47:48 +0000 Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36018 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:50:51 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:50:51 +0000 Subject: [Koha-bugs] [Bug 5316] Limit Z39.50 targets to specific users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5316 Miranda Nero changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mnero at oslri.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:52:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:52:13 +0000 Subject: [Koha-bugs] [Bug 5316] Limit Z39.50 targets to specific users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5316 --- Comment #8 from Miranda Nero --- We have one library that has a personal OCLC subscription and we would like to be able to only show the z39.50 target to just them. We currently have labeled it "TESTING - DO NOT USE" hoping that would deter other staff from using it (spoiler: it hasn't!) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:53:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:53:30 +0000 Subject: [Koha-bugs] [Bug 36005] Typo in "Your concern was successfully submitted" Staff Intranet text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36005 Brendan Lawlor changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:53:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:53:32 +0000 Subject: [Koha-bugs] [Bug 36005] Typo in "Your concern was successfully submitted" Staff Intranet text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36005 Brendan Lawlor changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161786|0 |1 is obsolete| | --- Comment #2 from Brendan Lawlor --- Created attachment 161810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161810&action=edit Bug 36005: Fixed typo in "Your concern was successfully submitted." text To test: 1. Turn on the syspref 'CatalogConcerns' 2. Go to view a record in the staff intranet and click on "New catalog concern" which is located in the "+New" dropdown. 3. Fill out the title on the form and leave everything else the same. Click on submit and notice that the message on the screen says "Your concern was sucessfully submitted." 4. Apply the patch. 5. Refresh the page and submit a new concern. Notice that the message now has "successfully" spelled correctly. 6. Sign off and have a wonderful day! :D Signed-off-by: Brendan Lawlor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:54:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:54:11 +0000 Subject: [Koha-bugs] [Bug 36019] New: Dead code in tags/review Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36019 Bug ID: 36019 Summary: Dead code in tags/review Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 20489 Since bug 20489 it is no longer possible to login with the DB user. At the time, get_template_and_user returned borrowernumber=0 in this case. In tags/review.pl we have: $borrowernumber == 0 and push @errors, {op_zero=>1}; This condition is never met, and op_zero related code can be removed in the template. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 [Bug 20489] Prevent DB user login -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:54:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:54:11 +0000 Subject: [Koha-bugs] [Bug 20489] Prevent DB user login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36019 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36019 [Bug 36019] Dead code in tags/review -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:54:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:54:18 +0000 Subject: [Koha-bugs] [Bug 36019] Dead code in tags/review In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36019 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34478 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:54:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:54:57 +0000 Subject: [Koha-bugs] [Bug 36018] Improve consistency in Acquisition/Order(s) regarding active/current orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36018 --- Comment #1 from Marcel de Rooy --- Hmm. On the other hand we quite often use filter_by_current and there is just one place where we use filter_by_active. So we could go the other way around.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:55:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:55:15 +0000 Subject: [Koha-bugs] [Bug 36018] Improve consistency in Acquisition/Order(s) regarding active/current orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36018 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:56:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:56:11 +0000 Subject: [Koha-bugs] [Bug 36019] Dead code in tags/review In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36019 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:56:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:56:14 +0000 Subject: [Koha-bugs] [Bug 36019] Dead code in tags/review In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36019 --- Comment #1 from Jonathan Druart --- Created attachment 161811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161811&action=edit Bug 36019: Remove dead code in tags/review Since bug 20489 it is no longer possible to login with the DB user. At the time, get_template_and_user returned borrowernumber=0 in this case. In tags/review.pl we have: $borrowernumber == 0 and push @errors, {op_zero=>1}; This condition is never met, and op_zero related code can be removed in the template. Test plan: Confirm the above -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:59:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 14:59:13 +0000 Subject: [Koha-bugs] [Bug 35972] Add a 'Research tables' feature, that builds upon Course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #4 from Ray Delahunty --- Wanted to see this in a sandbox, but it appears the patch failed to apply: Bug 35972 - Add a 'Research tables' feature, that builds upon Course reserves 161802 - Bug 35972: Add thesis tables feature 161803 - Bug 35972: Tidy for QA scripts Apply? [(y)es, (n)o, (i)nteractive] Applying: Bug 35972: Add thesis tables feature Using index info to reconstruct a base tree... M C4/CourseReserves.pm M koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc Falling back to patching base and 3-way merge... CONFLICT (add/add): Merge conflict in opac/opac-thesis-tables.pl Auto-merging opac/opac-thesis-tables.pl CONFLICT (add/add): Merge conflict in opac/opac-thesis-table-details.pl Auto-merging opac/opac-thesis-table-details.pl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc Auto-merging C4/CourseReserves.pm CONFLICT (content): Merge conflict in C4/CourseReserves.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 35972: Add thesis tables feature [33mhint: Use 'git am --show-current-patch=diff' to see the failed patch[m When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-35972-Add-thesis-tables-feature-xerdsj5j.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:00:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 15:00:07 +0000 Subject: [Koha-bugs] [Bug 36020] New: Port default recall notices to Template Toolkit Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Bug ID: 36020 Summary: Port default recall notices to Template Toolkit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: roadmap_24_05 Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: emily.lamancusa at montgomerycountymd.gov QA Contact: testopia at bugs.koha-community.org Blocks: 15278 The following notices relating to recalls all need to be updated to use Template Toolkit syntax: RETURN_RECALLED_ITEM PICKUP_RECALLED_ITEM RECALL_REQUESTER_DET Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:00:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 15:00:07 +0000 Subject: [Koha-bugs] [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36020 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 [Bug 36020] Port default recall notices to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:02:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 15:02:09 +0000 Subject: [Koha-bugs] [Bug 35963] Problem using some filters in the bundled items table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35963 --- Comment #1 from Julian Maurice --- Created attachment 161812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161812&action=edit Bug 35963: Fix bundled items table ordering and filtering Using the many-to-many relationship results in the table alias `me` to be used for table `item_bundles` instead of the expected table `items`. This causes ordering and filtering to fail for columns Callnumber and Barcode. Using Koha::Items->search does not have this problem. This patch also disables ordering by status because it does not work (error message is: "Cannot find Koha::Object class for return_claim'") Test plan: 1. Create an item bundle https://koha-community.org/manual/23.11/en/html/circulation.html#circulating-bundles 2. Add at least 2 items to this bundle 3. Verify that ordering/filtering by callnumber or barcode works 4. Run `prove t/db_dependent/api/v1/items/bundled_items.t` -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:02:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 15:02:20 +0000 Subject: [Koha-bugs] [Bug 35963] Problem using some filters in the bundled items table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35963 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:02:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 15:02:24 +0000 Subject: [Koha-bugs] [Bug 35963] Problem using some filters in the bundled items table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35963 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:11:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 15:11:05 +0000 Subject: [Koha-bugs] [Bug 35659] OAI Harvester In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160744|0 |1 is obsolete| | --- Comment #14 from Matthias Meusburger --- Created attachment 161813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161813&action=edit Bug 35659: OAI Harvester Test plan: - Run updatedatabase.pl - Apply the DBIC update patch - Setup an OAI repository in Administration -> OAI repositories (admin/oaiservers.pl) If the repository dataformat is in oai_dc, you can use the sample XSLT files: For Unimarc: OAIDCtoUNIMARCXML.xsl for bibliographic records AuthOAIDCtoUNIMARCXML.xsl for authorities For Marc21: OAIDCtoMARC21XML.xsl for bibliographic records AuthOAIDCtoMARC21XML.xsl for authorities If the repository dataformat is in marc-xml, you can use OAIMarcxml2KohaMarcxml.xsl for both Unimarc and Marc21. - Some repositories to test with: Bibliographic records, oai_dc: Endpoint: http://staroai.theses.fr/OAIHandler Set: ddc:260 XSLT: /koha-tmpl/intranet-tmpl/prog/en/xslt/OAIDCtoUNIMARCXML.xsl or XSLT: /koha-tmpl/intranet-tmpl/prog/en/xslt/OAIDCtoMARC21XML.xsl Authorities, oai_dc: Endpoint: https://www.idref.fr/OAI/oai.jsp Set: a XSLT: /koha-tmpl/intranet-tmpl/prog/en/xslt/AuthOAIDCtoUNIMARCXML.xsl or XSLT: /koha-tmpl/intranet-tmpl/prog/en/xslt/AuthOAIDCtoMARC21XML.xsl Authorities, marc-xml, Unimarc: Endpoint: https://www.idref.fr/OAI/oai.jsp Set: a XSLT: /koha-tmpl/intranet-tmpl/prog/en/xslt/OAIMarcxml2KohaMarcxml.xsl - Note: marc-xml harvesting will not work with HTTP::OAI::Harvester version 3.xx Version 4.xx is needed. See Bug 17704 for updating Koha default version to 4.xx - If you want to receive a report email, fill the OAI-PMH:HarvestEmailReport syspref. The model used (OAI_HARVEST_REPORT) can be edited in tools -> Notices and slips. - start a harvest with the following command: misc/cronjobs/harvest_oai.pl This script starts an OAI Harvest This script has the following parameters : -h --help: this message -v --verbose (enable output to stdout) -r --repository: id of the OAI repository -d --days: number of days to harvest from (optional) -l --list: list the OAI repositories -f --force: force harvesting (ignore records datestamps) (optional) Example: misc/cronjobs/harvest_oai.pl -r 1 -d 10 -v -f - Check the logs in the Log Viewer (tools/viewlog.pl) (CronjobLog syspref must be activated) Sponsored-by: KohaLa -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:12:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 15:12:21 +0000 Subject: [Koha-bugs] [Bug 35659] OAI Harvester In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659 --- Comment #15 from Matthias Meusburger --- (In reply to David Cook from comment #13) > (In reply to David Cook from comment #11) > > It looks like Koha::OAI::Client::Harvester is still missing unit tests > > though. I think that's going to be a QA blocker. > > At a minimum, I think the code handling "$response->next" should be in > separate unit tested functions. > Hi! I've added unit tests for record processing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:13:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 15:13:21 +0000 Subject: [Koha-bugs] [Bug 34309] Add new preference to set rules for updating damaged status on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34309 Mike Barrette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mbarrette at oslri.net --- Comment #1 from Mike Barrette --- Our libraries would LOVE this! I would also push for similar System Preferences such as UpdateDamagedStatusOnCheckin and UpdateDamagedStatusOnCheckout. That way it's customizable which statues can be cleared. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:15:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 15:15:04 +0000 Subject: [Koha-bugs] [Bug 36018] Improve consistency in Acquisition/Order(s) regarding active/current orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36018 --- Comment #2 from Marcel de Rooy --- git grep -P 'filter.*_out(?!side)' Clubs.pm:=head3 filter_out_empty Clubs.pm: my $filtered_rs = $clubs_rs->filter_out_empty; Clubs.pm:sub filter_out_empty { Holds.pm:=head3 filter_out_has_cancellation_requests Holds.pm: my $holds_without_cancellation_requests = $holds->filter_out_has_cancellation_requests; Holds.pm:sub filter_out_has_cancellation_requests { Items.pm: $result = $result->filter_out_lost; Items.pm:=head3 filter_out_lost Items.pm: my $filered_items = $items->filter_out_lost; Items.pm:sub filter_out_lost { -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:17:56 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 15:17:56 +0000 Subject: [Koha-bugs] [Bug 36018] Improve consistency in Acquisition/Order(s) regarding active/current orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36018 --- Comment #3 from Marcel de Rooy --- If filter_out_ is a pattern with consensus, then we need filter_by_current for current orders (not cancelled or completed) and filter_out_cancelled to get the current ones plus the completed ones. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:22:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 15:22:22 +0000 Subject: [Koha-bugs] [Bug 35977] Display current date in Hold starts on date on opac-reserve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 --- Comment #1 from Martin Renvoize --- Created attachment 161814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161814&action=edit Bug 35977: Set holddatefrom default to today This patch sets the holddatefrom date to today by default on the opac. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:22:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 15:22:32 +0000 Subject: [Koha-bugs] [Bug 35977] Display current date in Hold starts on date on opac-reserve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:24:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 15:24:21 +0000 Subject: [Koha-bugs] [Bug 35978] Extend breadcrumbs Course reserves with sections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35978 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:24:43 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 15:24:43 +0000 Subject: [Koha-bugs] [Bug 35978] Extend breadcrumbs Course reserves with sections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35978 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:24:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 15:24:45 +0000 Subject: [Koha-bugs] [Bug 35978] Extend breadcrumbs Course reserves with sections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35978 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161808|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 161815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161815&action=edit Bug 35978: Add 'sections' to Course Reserves We use Section to distinguish Residential from ETF Open University; This patch adds Section to the breadcrumb and title where appropriate. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:27:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 15:27:07 +0000 Subject: [Koha-bugs] [Bug 33292] Claim Return doesn't refund lost item charge when MarkLostItemsAsReturned includes "When marking an item as a return claim" and "Refund lost item fee" is on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 Brendan Lawlor changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor at clamsnet.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:27:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 15:27:24 +0000 Subject: [Koha-bugs] [Bug 27919] Split claims return from LOST In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 Brendan Lawlor changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor at clamsnet.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:33:51 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 15:33:51 +0000 Subject: [Koha-bugs] [Bug 34063] items.paidfor and deleteditems.paidfor still sometimes exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34063 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:33:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 15:33:54 +0000 Subject: [Koha-bugs] [Bug 34063] items.paidfor and deleteditems.paidfor still sometimes exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34063 --- Comment #10 from Pedro Amorim --- Created attachment 161816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161816&action=edit Bug 34063: Add system information warning If the table columns differ, we should at least provide a warning in the system information tab of the about page. Test plan: 1) Run the following SQL: alter table deleteditems add column paidfor longtext; 2) visit the issue stats page: /cgi-bin/koha/reports/issues_stats.pl 3) press 'Submit' 4) Notice it causes a 500 error. 5) Apply patch 6) Visit the about page and check the 'System information' tab 7) Notice the warning is there. 8) fix the issue, run alter table deleteditems drop column paidfor; 9) Repeat steps 2+3 confirm it no longer errors 10) Repeat step 6 and notice there's no longer a warning -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:37:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 15:37:00 +0000 Subject: [Koha-bugs] [Bug 33292] Claim Return doesn't refund lost item charge when MarkLostItemsAsReturned includes "When marking an item as a return claim" and "Refund lost item fee" is on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 Michelle Spinney changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney at clamsnet.org --- Comment #1 from Michelle Spinney --- "Having the option to refund the lost fee on claim would be helpful for many libraries." I agree with Lisette, ALL of our libraries would appreciate this. +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:38:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 15:38:45 +0000 Subject: [Koha-bugs] [Bug 34063] items.paidfor and deleteditems.paidfor still sometimes exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34063 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #11 from Pedro Amorim --- Imo this issue needs to be handled by sys admins on systems that require it fixed. I think it's very unlikely to have data in this column, and even more unlikely for this data to be actually real and utilized data, however just dropping the column entirely would open a precedent and at the end of the day, someone may in fact be using it for some odd reason. As a compromise I've submitted a patch that shows a warning in the about -> system information page to help guide sys admins in fixing it. This is just an idea, let me know if it makes sense or follow up if it you think it can be improved! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:38:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 15:38:49 +0000 Subject: [Koha-bugs] [Bug 36021] New: "Scheduled for automatic renewal" text displays even when not renewable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36021 Bug ID: 36021 Summary: "Scheduled for automatic renewal" text displays even when not renewable Change sponsored?: --- Product: Koha Version: 23.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: mirjam.vantieghem at etf.edu QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Since 23.11, on the checkouts page both in Staff client and OPAC, when a certain item is not renewable, e.g. because it is on hold or max renewals reached, the text "Scheduled for automatic renewal" still appears which is confusing. E.g. In the OPAC it says "Not renewable (on hold)", but right below it, it still says "This item is scheduled for auto renewal." In the Staff client it shows "On hold" and below that "(Scheduled for automatic renewal)". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:44:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 15:44:11 +0000 Subject: [Koha-bugs] [Bug 36019] Dead code in tags/review In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36019 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:44:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 15:44:13 +0000 Subject: [Koha-bugs] [Bug 36019] Dead code in tags/review In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36019 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161811|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 161817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161817&action=edit Bug 36019: Remove dead code in tags/review Since bug 20489 it is no longer possible to login with the DB user. At the time, get_template_and_user returned borrowernumber=0 in this case. In tags/review.pl we have: $borrowernumber == 0 and push @errors, {op_zero=>1}; This condition is never met, and op_zero related code can be removed in the template. Test plan: Confirm the above Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:44:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 15:44:59 +0000 Subject: [Koha-bugs] [Bug 36021] "Scheduled for automatic renewal" text displays even when not renewable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36021 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:51:29 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 15:51:29 +0000 Subject: [Koha-bugs] [Bug 36017] Dead code in admin/clone-rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36017 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:51:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 15:51:31 +0000 Subject: [Koha-bugs] [Bug 36017] Dead code in admin/clone-rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36017 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161809|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 161818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161818&action=edit Bug 36017: Remove dead code in admin/clone-rules Since commit 61628c97c245e72c750b61d9df6fa9b9100f3093 Bug 18936: (follow-up) Add cloning of circulation rules back to Koha There are some dead code in admin/clone-rules. "result" is always passed to the template. Test plan: Confirm the above and that cloning rules from the circ rules page still works correctly. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:08:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:08:31 +0000 Subject: [Koha-bugs] [Bug 36022] New: Add default recipient phone number country code syspref for SMS::Send driver Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36022 Bug ID: 36022 Summary: Add default recipient phone number country code syspref for SMS::Send driver Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: glasklas at gmail.com QA Contact: testopia at bugs.koha-community.org If using an international SMS::Driver it would be convenient if you could set a default country code for patron smsalertnumbers that do not include a country code, especially since Koha allows input in both formats. This will allow the user to set a default country code that will be prepended to all non interational phone numbers for the SMS::Driver->send_sms "to" parameter. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:15:33 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:15:33 +0000 Subject: [Koha-bugs] [Bug 27769] Advanced editor shouldn't break copying selected text with Ctrl+C In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27769 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:17:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:17:24 +0000 Subject: [Koha-bugs] [Bug 35248] Bookings needs unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:18:28 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:18:28 +0000 Subject: [Koha-bugs] [Bug 35248] Bookings needs unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 --- Comment #19 from Martin Renvoize --- There's still more to come here.. but I really think as people are starting to enhance and expand on bookings now we need these in sooner rather than later... setting to NSO to start getting eyes and I'll keep throwing more tests into further bugs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:18:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:18:48 +0000 Subject: [Koha-bugs] [Bug 36022] Add default recipient phone number country code syspref for SMS::Send driver In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36022 --- Comment #1 from David Gustafsson --- Created attachment 161819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161819&action=edit Bug 36022: Add default recipient SMS number country code Add SMSSendDefaultCountryCode syspref to prepend country code to non international SMS numbers. To test: TODO -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:18:58 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:18:58 +0000 Subject: [Koha-bugs] [Bug 36022] Add default recipient phone number country code syspref for SMS::Send driver In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36022 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |glasklas at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:20:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:20:48 +0000 Subject: [Koha-bugs] [Bug 35906] Add bookable option on itemtypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Depends on|29002 |35248 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 [Bug 35248] Bookings needs unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:20:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:20:48 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|35906 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 [Bug 35906] Add bookable option on itemtypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:20:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:20:48 +0000 Subject: [Koha-bugs] [Bug 35248] Bookings needs unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35906 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 [Bug 35906] Add bookable option on itemtypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:21:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:21:17 +0000 Subject: [Koha-bugs] [Bug 36022] Add default recipient phone number country code syspref for SMS::Send driver In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36022 --- Comment #2 from David Gustafsson --- Will attach a test plan once I've figured out how to test, since it's not currently possible to inspect the parameters of send_sms it's not obvious how to do this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:22:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:22:38 +0000 Subject: [Koha-bugs] [Bug 36022] Add default recipient phone number country code syspref for SMS::Send driver In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36022 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161819|0 |1 is obsolete| | --- Comment #3 from David Gustafsson --- Created attachment 161820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161820&action=edit Bug 36022: Add default recipient SMS number country code Add SMSSendDefaultCountryCode syspref to prepend country code to non international SMS numbers. To test: TODO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:23:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:23:22 +0000 Subject: [Koha-bugs] [Bug 36022] Add default recipient phone number country code syspref for SMS::Send driver In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36022 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:26:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:26:06 +0000 Subject: [Koha-bugs] [Bug 35781] [omnibus] Remove unneeded Koha::Template::Plugin methods In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35781 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Depends on| |35790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35790 [Bug 35790] Remove Koha::Template::Plugin::Biblio::CanArticleRequest -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:26:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:26:06 +0000 Subject: [Koha-bugs] [Bug 35790] Remove Koha::Template::Plugin::Biblio::CanArticleRequest In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35790 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35781 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35781 [Bug 35781] [omnibus] Remove unneeded Koha::Template::Plugin methods -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:26:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:26:18 +0000 Subject: [Koha-bugs] [Bug 35781] [omnibus] Remove unneeded Koha::Template::Plugin methods In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35781 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35787 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35787 [Bug 35787] Remove Koha::Template::Plugin::Biblio::CanBook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:26:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:26:18 +0000 Subject: [Koha-bugs] [Bug 35787] Remove Koha::Template::Plugin::Biblio::CanBook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35787 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35781 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35781 [Bug 35781] [omnibus] Remove unneeded Koha::Template::Plugin methods -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:26:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:26:54 +0000 Subject: [Koha-bugs] [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29002 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:26:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:26:54 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|35788 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:27:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:27:47 +0000 Subject: [Koha-bugs] [Bug 35248] Bookings needs unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29002 |35788 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:27:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:27:47 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|35248 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 [Bug 35248] Bookings needs unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:27:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:27:47 +0000 Subject: [Koha-bugs] [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35248 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 [Bug 35248] Bookings needs unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:40:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:40:20 +0000 Subject: [Koha-bugs] [Bug 27769] Advanced editor shouldn't break copying selected text with Ctrl+C In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27769 --- Comment #8 from Phil Ringnalda --- In case it wasn't clear, I didn't completely exhaust all possibilities for making what the code intends to do, just pass on handling the keystroke and let the browser handle it, actually work when something is selected. Since my dev install is on a Mac, I can only test by attaching a patch and driving 8 miles to test on a sandbox from a Windows machine, so I only tried the one most obvious patch. It's also entirely possible that it's a Codemirror bug which was fixed between our 5.40.2 and the current 5.65.16 (or the current version 6). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:40:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:40:55 +0000 Subject: [Koha-bugs] [Bug 35248] Bookings needs unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161651|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize --- Created attachment 161821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161821&action=edit Bug 35248: Add unit test for Koha::Item->bookings relation This patch adds a simple unit test for the 'bookings' relation accessor added to Koha::Item. Test plan 1) Run t/db_dependant/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:40:58 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:40:58 +0000 Subject: [Koha-bugs] [Bug 35248] Bookings needs unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161652|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize --- Created attachment 161822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161822&action=edit Bug 35248: Add unit tests for Koha::Item->find_booking This patch adds basic unit tests for the Koha::Item->find_booking method. Test plan 1) Run t/db_dependant/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:41:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:41:00 +0000 Subject: [Koha-bugs] [Bug 35248] Bookings needs unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161653|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize --- Created attachment 161823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161823&action=edit Bug 35248: Unit tests for CanBookBeIssued Whilst writing the test, I found a minor flaw in the logic and fixed that in CanBookBeIssued at the same time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:41:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:41:03 +0000 Subject: [Koha-bugs] [Bug 35248] Bookings needs unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161654|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize --- Created attachment 161824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161824&action=edit Bug 35248: Add unit tests for Koha::Item->check_booking This patch adds basic unit tests for the Koha::Item->check_booking method. Test plan 1) Run t/db_dependant/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:41:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:41:05 +0000 Subject: [Koha-bugs] [Bug 35248] Bookings needs unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161655|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize --- Created attachment 161825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161825&action=edit Bug 35248: Drop ->place_booking These methods were introduced and used in an earlier iteration of the code, they are no longer called from anywhere (the code in Koha::Booking->store handles all cases instead) and thus I choose to remove them rather than add unit tests for them.. They are simple methods that could be re-introduced as required at a future date. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:41:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:41:08 +0000 Subject: [Koha-bugs] [Bug 35248] Bookings needs unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161656|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize --- Created attachment 161826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161826&action=edit Bug 35248: Add test for Koha::Exceptions::Booking -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:41:10 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:41:10 +0000 Subject: [Koha-bugs] [Bug 35248] Bookings needs unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161657|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize --- Created attachment 161827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161827&action=edit Bug 35248: Remove Koha::Booking->intersects Another method left behind from an earlier iteration.. not actually called anywhere in the final submission in Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:41:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:41:13 +0000 Subject: [Koha-bugs] [Bug 35248] Bookings needs unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161658|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize --- Created attachment 161828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161828&action=edit Bug 35248: Add unit tests for Koha::Booking relations This patch adds unit tests for the relations introduced in the new Koha::Booking class. Test plan 1) Run t/db_dependent/Koha/Booking.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:41:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:41:15 +0000 Subject: [Koha-bugs] [Bug 35248] Bookings needs unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161659|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize --- Created attachment 161829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161829&action=edit Bug 35248: Add Koha::Biblio->bookings unit test This patch adds unit tests for the bookings relationship accessor on Koha::Biblio objects. Test plan 1) Run t/db_dependant/Koha/Biblio.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:41:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:41:18 +0000 Subject: [Koha-bugs] [Bug 35248] Bookings needs unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161660|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize --- Created attachment 161830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161830&action=edit Bug 35248: Add unit tests for Koha::Bibilio->check_booking This patch adds basic unit tests for Koha::Biblio->check_booking Test plan 1) Run t/db_dependent/Koha/Biblio.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:41:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:41:20 +0000 Subject: [Koha-bugs] [Bug 35248] Bookings needs unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 --- Comment #30 from Martin Renvoize --- Created attachment 161831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161831&action=edit Bug 35248: Add unit tests for Koha::Bibilio->bookable_items This patch adds basic unit tests for Koha::Biblio->bookable_items Test plan 1) Run t/db_dependent/Koha/Biblio.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:44:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:44:04 +0000 Subject: [Koha-bugs] [Bug 32693] The 'About Koha' page loads slowly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim at ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:45:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:45:19 +0000 Subject: [Koha-bugs] [Bug 32693] The 'About Koha' page loads slowly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |katrin.fischer at bsz-bw.de, | |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:46:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:46:37 +0000 Subject: [Koha-bugs] [Bug 32693] The 'About Koha' page loads slowly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 --- Comment #1 from Pedro Amorim --- Created attachment 161832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161832&action=edit Bug 32693: Proof of concept This is a PoC for discussion. Now, only the tab being viewed is processed and loaded. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:55:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 16:55:08 +0000 Subject: [Koha-bugs] [Bug 35703] Marking Lost card does not prevent patron from placing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35703 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:09:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 17:09:03 +0000 Subject: [Koha-bugs] [Bug 33887] Automatic checkin should be able to optionally fill the next hold with the returned item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33887 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:14:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 17:14:13 +0000 Subject: [Koha-bugs] [Bug 36023] New: Visibility settings configuration for the lists_addbybiblionumber pop-up window Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36023 Bug ID: 36023 Summary: Visibility settings configuration for the lists_addbybiblionumber pop-up window Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: kch-tr.lhl-consortium at nhs.net QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Change the visibility settings configuration for the lists_addbybiblionumber pop-up window that appears when adding to a public list from the cataloguing module. At the moment, the only lists visible in that window are those set with anybody who can see the list, the problem here is that this setting also allows users logged into the OPAC to make edits which our list owners don't want. Preferred outcome should be that when a list owner sets the editing option to staff only, that it also appears in the drop-down list in the virtualshelves/addbybiblionumber pop-up window when working in the staff interface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:19:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 17:19:08 +0000 Subject: [Koha-bugs] [Bug 35538] List of libraries on OPAC self registration form should sort by branchname rather than branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35538 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159986|0 |1 is obsolete| | --- Comment #3 from Emily Lamancusa --- Created attachment 161833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161833&action=edit Bug 35538: Sort OPAC self registration library list by library name This patch modifies opac-memberentry.pl so that the list of libraries is sorted by library name instead of library code. To test, apply the patch and restart services. - If using the default testing data you'll have to go to Administration -> Libraries and edit one or more libraries so that the library name is alphabetically different than the library code. e.g. Centerville -> Zanzibar. - Go the OPAC and click "Create an account" (requires the PatronSelfRegistration system preference). - Under "Home library," the dropdown of libraries should be ordered by library name. Signed-off-by: David Nind Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:20:25 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 17:20:25 +0000 Subject: [Koha-bugs] [Bug 35538] List of libraries on OPAC self registration form should sort by branchname rather than branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35538 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |emily.lamancusa at montgomeryc | |ountymd.gov QA Contact|testopia at bugs.koha-communit |emily.lamancusa at montgomeryc |y.org |ountymd.gov --- Comment #4 from Emily Lamancusa --- Looks good and QA script is happy. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:26:43 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 17:26:43 +0000 Subject: [Koha-bugs] [Bug 27769] Advanced editor shouldn't break copying selected text with Ctrl+C In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27769 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:26:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 17:26:46 +0000 Subject: [Koha-bugs] [Bug 27769] Advanced editor shouldn't break copying selected text with Ctrl+C In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27769 --- Comment #9 from Nick Clemens --- Created attachment 161834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161834&action=edit Bug 27769: Update default key mapping to copy text When implemented, the keyboard shortcuts could not use the system clipboard so Citrl-C was mapped to use the editor clipboard. As this now works with the system clipboard we should allow standard functionality and remap the Koha shortcut. This will not affect existing installations, however, they can modify the keyboard shortcut if they wish by visting: Administration->Keyboard shortcuts or Clicking the 'Redefine shortcuts' link under 'Keyboard shortcuts' in the advanced editor. To test: 1 - Apply this patch 2 - Reset all 3 - Confirm Ctrl-Alt-C is the command to 'Copy current field' in Keyboard shortcuts in the advanced editor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:26:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 17:26:48 +0000 Subject: [Koha-bugs] [Bug 27769] Advanced editor shouldn't break copying selected text with Ctrl+C In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27769 --- Comment #10 from Nick Clemens --- Created attachment 161835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161835&action=edit Bug 27769: Remove 'brief' class from advanced editor clipboard This field is intended to be a list of items copied from the editor, removing the brief class allows it to expand to 10 rows as intended. To test: 1 - Apply this patch 2 - Confirm clipboard section of advanced editor is several rows 3 - Use Ctrl-Alt-C to copy some fields 4 - Confirm you can see multiple fields in the clipboard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:26:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 17:26:57 +0000 Subject: [Koha-bugs] [Bug 27769] Advanced editor shouldn't break copying selected text with Ctrl+C In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27769 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:28:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 17:28:02 +0000 Subject: [Koha-bugs] [Bug 27769] Advanced editor shouldn't break copying selected text with Ctrl+C In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27769 --- Comment #11 from Nick Clemens --- I added a patch, I only update the default for new installs. Current users can easily remap this field currently, and it should work. We can highlight this in the release notes to let users know -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:29:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 17:29:14 +0000 Subject: [Koha-bugs] [Bug 35836] search_for_data_inconsistencies.pl - Search for loops in dependencies. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35836 Matthias Le Gac changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:29:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 17:29:15 +0000 Subject: [Koha-bugs] [Bug 35836] search_for_data_inconsistencies.pl - Search for loops in dependencies. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35836 --- Comment #7 from Matthias Le Gac --- Created attachment 161836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161836&action=edit Bug 35836 - search_for_data_inconsistencies.pl - Search for loops in dependencies. We have guarantors who guarantee individuals who are, in turn, their guarantors. It is not clear if this should be allowed (bz35421), but it works, and has been working for a while. However, it breaks with bz12532, which produces a recursion that disrupts everything. Creation of a code in search_for_data_inconsistencies.pl that identifies loops in borrower_relationships. This must work in both directions for validation. This is the first bz I've made. Here's the test plan, let me know if there's anything to improve. Test Plan: 1 - Apply the patch. 2 - Create 4 different adult users. 3 - In the terminal, navigate to the database. 4 - Insert relationships into the "borrower_relationships" table: - Example: INSERT INTO borrower_relationships (id, guarantor_id, guarantee_id, relationship) VALUES (1, 52, 53, 'father'); INSERT INTO borrower_relationships (id, guarantor_id, guarantee_id, relationship) VALUES (2, 53, 54, 'father'); INSERT INTO borrower_relationships (id, guarantor_id, guarantee_id, relationship) VALUES (3, 54, 52, 'father'); - Ensure that the relationships created form a loop of guarantors. 5 - In the terminal, navigate to your Koha environment's git repository. 6 - Change directory to "cd misc/maintenance." 7 - Run the script to detect guarantor loops: ./search_for_data_inconsistencies.pl 8 - Verify that the output provides the borrower IDs involved in the guarantor loop. *Have fun creating intricate relationships to test the script's limit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:29:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 17:29:17 +0000 Subject: [Koha-bugs] [Bug 35836] search_for_data_inconsistencies.pl - Search for loops in dependencies. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35836 --- Comment #8 from Matthias Le Gac --- Created attachment 161837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161837&action=edit Bug 35836: search_for_data_inconsistencies.pl - Search for loops in dependencies - test tidiness1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:29:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 17:29:19 +0000 Subject: [Koha-bugs] [Bug 35836] search_for_data_inconsistencies.pl - Search for loops in dependencies. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35836 --- Comment #9 from Matthias Le Gac --- Created attachment 161838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161838&action=edit Bug 35836: search_for_data_inconsistencies.pl - Search for loops in dependencies - test tidiness2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:34:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 17:34:21 +0000 Subject: [Koha-bugs] [Bug 35836] search_for_data_inconsistencies.pl - Search for loops in dependencies. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35836 Matthias Le Gac changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:49:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 17:49:54 +0000 Subject: [Koha-bugs] [Bug 35836] search_for_data_inconsistencies.pl - Search for loops in dependencies. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35836 Matthias Le Gac changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:49:56 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 17:49:56 +0000 Subject: [Koha-bugs] [Bug 35836] search_for_data_inconsistencies.pl - Search for loops in dependencies. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35836 --- Comment #10 from Matthias Le Gac --- Created attachment 161839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161839&action=edit Bug 35836: search_for_data_inconsistencies.pl - Search for loops in dependencies We have guarantors who guarantee individuals who are, in turn, their guarantors. It is not clear if this should be allowed (bz35421), but it works, and has been working for a while. However, it breaks with bz12532, which produces a recursion that disrupts everything. Creation of a code in search_for_data_inconsistencies.pl that identifies loops in borrower_relationships. This must work in both directions for validation. This is the first bz I've made. Here's the test plan, let me know if there's anything to improve. Test Plan: 1 - Apply the patch. 2 - Create 4 different adult users. 3 - In the terminal, navigate to the database. 4 - Insert relationships into the "borrower_relationships" table: - Example: INSERT INTO borrower_relationships (id, guarantor_id, guarantee_id, relationship) VALUES (1, 52, 53, 'father'); INSERT INTO borrower_relationships (id, guarantor_id, guarantee_id, relationship) VALUES (2, 53, 54, 'father'); INSERT INTO borrower_relationships (id, guarantor_id, guarantee_id, relationship) VALUES (3, 54, 52, 'father'); - Ensure that the relationships created form a loop of guarantors. 5 - In the terminal, navigate to your Koha environment's git repository. 6 - Change directory to "cd misc/maintenance." 7 - Run the script to detect guarantor loops: ./search_for_data_inconsistencies.pl 8 - Verify that the output provides the borrower IDs involved in the guarantor loop. *Have fun creating intricate relationships to test the script's limit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:49:58 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 17:49:58 +0000 Subject: [Koha-bugs] [Bug 35836] search_for_data_inconsistencies.pl - Search for loops in dependencies. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35836 --- Comment #11 from Matthias Le Gac --- Created attachment 161840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161840&action=edit Bug 35836: search_for_data_inconsistencies.pl - Search for loops in dependencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:50:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 17:50:00 +0000 Subject: [Koha-bugs] [Bug 35836] search_for_data_inconsistencies.pl - Search for loops in dependencies. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35836 --- Comment #12 from Matthias Le Gac --- Created attachment 161841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161841&action=edit Bug 35836: search_for_data_inconsistencies.pl - Search for loops in dependencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:52:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 17:52:00 +0000 Subject: [Koha-bugs] [Bug 35836] search_for_data_inconsistencies.pl - Search for loops in dependencies. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35836 Matthias Le Gac changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161351|0 |1 is obsolete| | Attachment #161836|0 |1 is obsolete| | Attachment #161837|0 |1 is obsolete| | Attachment #161838|0 |1 is obsolete| | Attachment #161839|0 |1 is obsolete| | Attachment #161840|0 |1 is obsolete| | Attachment #161841|0 |1 is obsolete| | --- Comment #13 from Matthias Le Gac --- Created attachment 161842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161842&action=edit Bug 35836: search_for_data_inconsistencies.pl - Search for loops in dependencies We have guarantors who guarantee individuals who are, in turn, their guarantors. It is not clear if this should be allowed (bz35421), but it works, and has been working for a while. However, it breaks with bz12532, which produces a recursion that disrupts everything. Creation of a code in search_for_data_inconsistencies.pl that identifies loops in borrower_relationships. This must work in both directions for validation. This is the first bz I've made. Here's the test plan, let me know if there's anything to improve. Test Plan: 1 - Apply the patch. 2 - Create 4 different adult users. 3 - In the terminal, navigate to the database. 4 - Insert relationships into the "borrower_relationships" table: - Example: INSERT INTO borrower_relationships (id, guarantor_id, guarantee_id, relationship) VALUES (1, 52, 53, 'father'); INSERT INTO borrower_relationships (id, guarantor_id, guarantee_id, relationship) VALUES (2, 53, 54, 'father'); INSERT INTO borrower_relationships (id, guarantor_id, guarantee_id, relationship) VALUES (3, 54, 52, 'father'); - Ensure that the relationships created form a loop of guarantors. 5 - In the terminal, navigate to your Koha environment's git repository. 6 - Change directory to "cd misc/maintenance." 7 - Run the script to detect guarantor loops: ./search_for_data_inconsistencies.pl 8 - Verify that the output provides the borrower IDs involved in the guarantor loop. *Have fun creating intricate relationships to test the script's limit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:52:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 17:52:01 +0000 Subject: [Koha-bugs] [Bug 35836] search_for_data_inconsistencies.pl - Search for loops in dependencies. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35836 --- Comment #14 from Matthias Le Gac --- Created attachment 161843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161843&action=edit Bug 35836: search_for_data_inconsistencies.pl - Search for loops in dependencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:52:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 17:52:03 +0000 Subject: [Koha-bugs] [Bug 35836] search_for_data_inconsistencies.pl - Search for loops in dependencies. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35836 --- Comment #15 from Matthias Le Gac --- Created attachment 161844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161844&action=edit Bug 35836: search_for_data_inconsistencies.pl - Search for loops in dependencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 19:16:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 18:16:14 +0000 Subject: [Koha-bugs] [Bug 32693] The 'About Koha' page loads slowly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 --- Comment #2 from David Nind --- Thanks Pedro! I was keen to test your PoC, but got this when trying to apply the patch: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 32693: Proof of concept .git/rebase-apply/patch:65: trailing whitespace. error: sha1 information is lacking or useless (about.pl). error: could not build fake ancestor Patch failed at 0001 Bug 32693: Proof of concept -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 19:23:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2024 18:23:36 +0000 Subject: [Koha-bugs] [Bug 35895] Reindent tags review template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35895 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161340|0 |1 is obsolete| | Attachment #161341|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 161845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161845&action=edit Bug 35895: Reindent tags review template This patch reindents the tags review template so that it has consistent indentation, with tab indentation coverted to space. The patch also adds "FILTER collapse" around the