[Koha-bugs] [Bug 35357] Item not removed from holds queue when checked out to a different patron

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35357

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Victor Grousset/tuxayo from comment #5)
> > 7) Verify the holds queue viewer no longer shows that patron and item!
> 
> The next run of misc/cronjobs/holds/build_holds_queue.pl brings back that
> patron and item in the Holds queue page. So back with the initial issue :(

I am unable to recreate that. If you can please submit a new bug report as that
would be a different bug!

> QA script unhappy:
>  WARN	t/db_dependent/HoldsQueue.t
>    WARN	  tidiness
> 		The file is less tidy than before (bad/messy lines before: 484, now: 488)

Fixed!

> minor finding:
> The test uses a record level hold instead of an item level one. It works
> because there is one item for the record. Otherwise reproducing the bug
> would depend on which item is picked. IIUC it has to be the one suggested by
> the hold queue to get the issue.
> So maybe a comment is needed to say that the test tests the case where the
> checked out item is the one suggested by the hold queue. Or make it do an
> item level hold like in the test plan.

That is correct, it is always the one suggested by the holds queue. I have
enhanced the unit tests to prove this is the case.

-- 
You are receiving this mail because:
You are watching all bug changes.