[Koha-bugs] [Bug 35969] opac-sendbasket: Improve error message, remove some logging

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35969

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #5 from David Nind <david at davidnind.com> ---
I've signed off, as I think having better messages is great.

Some suggestions:

There was an error sending the cart: No valid biblio records found.
> There was an error sending the cart: no valid records were found.

Since we do not have your email address, we cannot send a mail. We need your
email address as reply-to address.
> There was an error sending the cart: we cannot send an email as there is no email address recorded for your account (your email address is used for the reply to address).

Testing notes (using KTD):

1. Go to http://127.0.0.1:8080/cgi-bin/koha/opac-sendbasket.pl?bib_list=null
2. Log in as koha/koha
3. Add an email address to the form and click 'Send': me at example.com
4. Error message displayed: "There was an error sending the cart."
5. Note the warning in the log: /var/log/koha/kohadev/plack-opac-error.log
6. Apply the patch
7. Repeat steps 1-3
8. Note that the error displayed is now: "Since we do not have your email
address, we cannot send a mail. We need your email address as reply-to
address."

-- 
You are receiving this mail because:
You are watching all bug changes.