[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

--- Comment #22 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Marcel de Rooy from comment #17)
> A bit late, but wondering why active_orders include completed lines ? Looks
> a bit strange to me..

Looking at Koha::Acquisition::Orders it feels like I might have mixed 'current'
vs. 'active'. So a terminology problem. And 'filter_by_active' seems to have a
wrong POD (should be 'filtering OUT orders that are not active'). We could have
a problem with this embed in 'biblio.active_orders+count' in
/acquisitions/orders.

Please file a bug!

(In reply to Marcel de Rooy from comment #20)
> Yeah no problem. But couldnt you add an ->orders method and use the aqorders
> relation inside. Preventing custom relations in DBIx schema?

We could even do it the other way around: not having any automatic relationship
generated, and only define what we are gonna use!

-- 
You are receiving this mail because:
You are watching all bug changes.