[Koha-bugs] [Bug 36019] New: Dead code in tags/review

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Feb 7 15:54:11 CET 2024


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36019

            Bug ID: 36019
           Summary: Dead code in tags/review
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart+koha at gmail.com
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 20489

Since bug 20489 it is no longer possible to login with the DB user.
At the time, get_template_and_user returned borrowernumber=0 in this case.

In tags/review.pl we have:
  $borrowernumber == 0 and push @errors, {op_zero=>1};

This condition is never met, and op_zero related code can be removed in the
template.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489
[Bug 20489] Prevent DB user login
-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list