[Koha-bugs] [Bug 28657] Expand branches.branchip to allow for multiple space separated IP ranges

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28657

Michael Hafen <michael.hafen at washk12.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #156582|0                           |1
        is obsolete|                            |

--- Comment #16 from Michael Hafen <michael.hafen at washk12.org> ---
Created attachment 161872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161872&action=edit
Bug 28657: expand branches.branchip to allow for multiple ip  ranges.

[ conflicts with patch for bug 36028, so this is now dependent on that ]
change branches.branchip to a mediumtext, and remove '*' from existing branchip 
settings.
Change C4/Auth.pm from a regexp to using in_iprange() to check client address
ag
ainst branchip.  (in_iprange() doesn't work with '*' in branchip.)
Change in_iprange() to default to false (which is what the POD says it should
do
).
Change note in admin/branches.tt under branchip field to reflect changes to
bran
chip handling.
Bug 28657: (QA follow-up) Return 1 if no range, improve unit tests
Bug 28657: (Follow-up for QA) Tidy the code and make it more consident
  remove branches.tt branchip input maxlength attribute.
  Have the db_rev match the kohastructure.sql for column collation and comment.
  Use new style db_rev skeleton.
  Fix comment C4::Auth.
  Have Koha::Library->store() watch for and remove '*' from branchip.
  Add a couple more test for full coverage.

Test plan:

1. Turn on AutoLocation system preference
2. Change a branches branchip to multiple ip ranges seperated by a space,
   making sure one of the ranges includes your computers address.
3. Log out and try logging in.  The location check will fail.
4. Apply patch.  Restart plack if necessary.
5. Try logging in again.  The location check will succeed.

-- 
You are receiving this mail because:
You are watching all bug changes.