[Koha-bugs] [Bug 36025] Extended attributes clause added to patron search query even when there are no searchable attributes

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36025

--- Comment #1 from Andreas Jonsson <andreas.jonsson at kreablo.se> ---
There is also another issue in buildPatronSearchQuery that still adds the
clause. Someone is trying to use an array as a boolean value in Javascript.  (A
work related brain injury caused by excessive Perl programming?)

--- a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js
+++ b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js
@@ -650,7 +650,7 @@ function buildPatronSearchQuery(term, options) {
     q.push({ "-or": term_subquery_or });

     // Add each pattern for each extended patron attributes
-    if ( typeof options !== 'undefined' && ( (options.search_fields ==
'standard' && options.extended_attribute_types) || (
searched_attribute_fields.length > 0 ) ) && extendedPatronAttributes) {
+    if ( typeof options !== 'undefined' && ( (options.search_fields ==
'standard' && options.extended_attribute_types.length > 0) || (
searched_attribute_fields.length > 0 ) ) && extendedPatronAttributes) {
         extended_attribute_codes_to_search = (searched_attribute_fields.length
> 0) ? searched_attribute_fields : options.extended_attribute_types;
         extended_attribute_subquery_and = [];
         patterns.forEach(function (pattern, i) {

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.