[Koha-bugs] [Bug 36027] search_for_data_inconsistencies.pl - make each section optional

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Feb 8 14:51:42 CET 2024


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36027

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |pedro.amorim at ptfs-europe.co
                   |                            |m
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Failing QA here:
1) Not tidy
2) Leftover Data::Dumper import
3) Many empty new lines
4) This enhancement turns the script into an interactive script, requiring
interactive input. This change in behavior will potentially cause existing
systems running this script (as a cron or otherwise) to fail. My suggestion
here is to update the code to instead allow for params instead of turning it
interactive, e.g.:

perl misc/maintenance/search_for_data_inconsistencies.pl --items-branch
--items-status

And keep functionality of running all checks by default as is currently, this
ensures existing default functionality plus the new enhancement, instead of
changing current default functionality.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list