[Koha-bugs] [Bug 35930] <enable_plugins> variable in koha-conf breaks non-plugin module

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35930

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #162018|0                           |1
        is obsolete|                            |

--- Comment #3 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Created attachment 162019
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162019&action=edit
Bug 35930: Add guards for plugins_enabled

The 'new' method in Koha::Plugins returns undefined if
plugins are disabled.  Therefore, calls to this method
must be guarded by a check that plugins actually are enabled.

Test plan:

* Code inspection of patch, alternatively
* Activate the ill system by installing a backend such as
  koha-illbackend-libris:
  https://github.com/Libriotech/koha-illbackend-libris
* Make sure plugins are disabled in koha-conf.xml
* In the staff interface, go to ILL requests.
* The page should load without getting an error 500.

PA amended commit message: This is not related to ILL backends being plugins or
not
This is about ILL batches, where checking for metadata enrichment plugins was
missing 'enable_plugins' guard
Additionally, unrelated to batches, it's also about ILLAvailability, where
checking for ILL availabililty plugins was missing enable_plugins guard

Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.