[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796

--- Comment #104 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I've fixed a whole bunch of little issues to get this vaguely working now, but
as I run the test suit against it I see there are more issues hidden.

I've fixed some array indexing issues where your code worked in opposition to
how Koha's calendar indexes days of the week already.. but Circulation tests
still fail. This is because, as far as I can tell, your code expects every
branch to always have opening hours set.. i.e. there MUST be rows for days 0 to
6 for every branch, even if those rows have hours of null-null.  I've fixed the
database update to handle this, however the failing tests expose the lack of
treatment for this in t/lib/TestBuilder. We'll need that resolving before this
can work it's way through QA.

I'm not sure whether we should be adding this handling to TestBuilder (i.e. to
always ensure there's 7 rows per branch for any time a branch is added in
testing), or whether really we should not be making this assumption in the
first place and instead we should be allowing for missing rows in the
library_hours table.

-- 
You are receiving this mail because:
You are watching all bug changes.