[Koha-bugs] [Bug 36063] Add Holds to Pull info to intranet-main page

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063

--- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> ---
(In reply to Owen Leonard from comment #7)
> In my system with custom test data I'm seeing a mismatch between the count
> on the home page and the number of holds returned by pendingreserves.pl. I
> see that there is a lot of extra filtering going on in that script, so I
> wonder if the simple 'Koha::Holds->search( found => undef )' is not counting
> too many holds.
> 
> The other issue I see is that pendingreserves.pl has a default date range
> which makes the user's experience of what the home page reports different
> from what they see on that page by default.
> 
> In my system the home page reports 59 pending holds, pendingreserves.pl
> reports zero holds by default, and with an all-inclusive date range returns
> 31 holds.
> 
> - I think the home page count should definitely use the same (non-date)
> limits, but should it also use the same date limits?
> - Alternatively, should we remove the default date limit on
> pendingreserves.pl?

Thanks Owen. You're right, there needs to be more filters. That makes me want
to move some of the logic from pendingreserves.pl into Koha/Holds.pm (
something like 'filter_by_holds_to_pull') so it can be reused on mainpage.pl
and covered by tests. I will work up a new patch.

-- 
You are receiving this mail because:
You are watching all bug changes.