[Koha-bugs] [Bug 35361] Search filter on receive orders page crashes the system

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35361

--- Comment #10 from David Cook <dcook at prosentient.com.au> ---
(In reply to Andreas Jonsson from comment #8)
> It is not hypothetical.  If you find an invoice under Acquisitions ->
> Invoices and then "Go to receipt page" (i.e., acqui/parcel.pl) you will find
> a table with open orders.  If you type anything into the search filter, the
> above will be the sql-query generated.

In retrospect, I think that I was testing something different. I was looking
just at the column level search filters. I think you must've been table level
search filter. My mistake. 

> Since there are LEFT JOIN clauses applied after the limit have been applied,
> and several of those joins have the potential to multiply the number of
> result lines that are produced, the number of matched lines can explode.

Agreed.

> DBIx is fundamentally flawed, and I think it would be a good idea to write
> our own sql-queries and our own code for generating sql queries.

Take a look back in the git log maybe 10 years ago ;). The DBIx ORM is a
relatively new addition in the life of Koha. It replaced a lot of bespoke SQL
queries. I don't think we'll be going backwards.

However, for complex cases like this one, maybe we do need the controller to
have a more specific handler with custom SQL queries.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.