[Koha-bugs] [Bug 30987] Adding relationship to PatronQuickAddFields causes it to be added 2x

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30987

--- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> ---
The problem here seems to be that we have 2 ways of adding the Relationship
field. 

1. If  borrowerRelationship is NOT empty we assume the field should be added.
2. It can also be added via PatronQuickAddFields

I think we need to remove the logic that automatically adds the field if
borrowerRelationship is NOT empty:

104 my @relations = split /\|/,
C4::Context->preference('borrowerRelationship'), -1;
105 @relations = ('') unless @relations;
106 my $empty_relationship_allowed = grep {$_ eq ""} @relations;
107 $template->param( empty_relationship_allowed => $empty_relationship_allowed
);


We can rely on BorrowerUnwantedField, BorrowerMandatoryField, and 
PatronQuickAddFields to setup this field in the desired way.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.