[Koha-bugs] [Bug 35924] The 'checkin slip' button should not be available for patrons whose privacy is set to never

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35924

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |victor at tuxayo.net
                   |y.org                       |
                 CC|                            |victor at tuxayo.net

--- Comment #5 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
> If a patron anonymizes their checkins, the checkin slip cannot retrieve any info to print the checkin slip. 

Does that makes sense? Isn't that a bug instead?
It's just for arbitrary technical reasons that the slip can't get the info.
This info is still there on checkin, but it's immediately deleted. And the slip
is an optional checkin step that is on a separate request.

> We should not show the button in this scenario

But if nobody really complains and can do or fund work to complexify slip
handling then it's ok to at least be consistent in the current simpler slip
implementation that isn't compatible with patron privacy = never
Because that's an undisputable bug and the above is more between a bug and two
features that have not their fullest scope possible and don't work together.

So ok I get it now ^^

---

Is it possible to avoid the two times there is a magic number in the patch?
(patron.privacy < 2)

I'm not sure if it's simple from a template to access something like a constant
that would be defined in Koha/Patron.pm or Koha/Schema/Result/Borrower.pm or
somewhere relevant.
Any ideas? Magic numbers often require to go digging their meaning and the
place is often not obvious.
borrowers.privacy DB comment doesn't list the values :(

If nothing simple then at least a TT comment just next the [% IF [...] %] tag.
I can add it in a follow-up. Just hopping for better ideas that can reasonably
be done in this ticket.

-- 
You are receiving this mail because:
You are watching all bug changes.