[Koha-bugs] [Bug 36066] REST API: We should only allow deleting cancelled order lines

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36066

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #3)
> (In reply to Katrin Fischer from comment #2)

> No reason to worry. We should not allow plugins to delete in the first place
> (since Koha did not allow that yet). But I am reading the code and guess
> that it is just added in line with regular CRUD patterns. It is possible to
> cancel an order via API using ->update (PUT) and sending a modified
> orderstatus. 

But you should also update the cancellation date!

See also bug 10869 comment109. You can delete a whole basket in the interface,
but the interface takes care of cancelling etc. Since the API method ->delete
does not do that (yet), the proposed check is still fine in its current form
imo.

-- 
You are receiving this mail because:
You are watching all bug changes.