[Koha-bugs] [Bug 36021] "Scheduled for automatic renewal" text displays even when not renewable

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36021

--- Comment #2 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
(In reply to Mirjam Vantieghem from comment #0)
> Since 23.11, on the checkouts page both in Staff client and OPAC, when a
> certain item is not renewable, e.g. because it is on hold or max renewals
> reached, the text "Scheduled for automatic renewal" still appears which is
> confusing.
> 
> E.g. In the OPAC it says "Not renewable (on hold)", but right below it, it
> still says "This item is scheduled for auto renewal." In the Staff client it
> shows "On hold" and below that "(Scheduled for automatic renewal)".

Are you able to provide a detailed test plan to reproduce this?
Also current values of "No renewal before", "No automatic renewal before" and
"Automatic renewal" in the circulation rules. It may be that there is no bug
here, as both messages being shown is an expected use case, I believe.

It may be that in the situation you describe, a manual renewal is not possible
"right now" (because its on hold) but an automatic renewal  **attempt** is
still going to happen for that specific checkout when the time for the cron to
run comes, hence the message. It may be the case that the hold is cancelled in
the meantime, and in such event the automatic renewal would succeed, hopefully.

I agree that the text being presented may be confusing, but this was done for
transparency reasons, i.e. provide full information of what is going on. The
alternative would be to just show "Not renewable (on hold)" and nothing else,
but an auto renewal attempt would still take place for that checkout
eventually.

I'm not saying there is no bug here, but the above is the reasoning behind the
implementation decisions.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.