[Koha-bugs] [Bug 36137] update_totalissues.pl should always skip_holds_queue

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36137

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
Looking closer here I see a few more things:

I don't see why an if/else is needed here. We can just pass the value
$incremental to UpdateTotalIssues

-            my $ret;
-            if ( $incremental && $totalissues > 0 ) {
-                $ret = UpdateTotalIssues( $biblionumber, $totalissues );
-            }
-            else {
-                $ret = UpdateTotalIssues( $biblionumber, 0, $totalissues );
-            }

Instead this should work just as good:

+            my $ret = UpdateTotalIssues( $biblionumber, $incremental,
$totalissues, 1 );


Also the POD for skip_holds_queue is missing from C4/Biblio

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.