[Koha-bugs] [Bug 31391] Staff-side recalls

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |pedro.amorim at ptfs-europe.co
                   |                            |m

--- Comment #63 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Test plan works as described and qa script seems happy, but I don't feel
comfortable passing or failing QA here, so I'll leave that to someone else and
provide some observations instead:

Instead of adding RecallsInterface, should we consider updating UseRecalls sys
pref to:
0 - Don't use
1 - Use on OPAC only
2 - Use on staff interface only
3 - Use on both OPAC and staff interface

This would address the use-cases being covered here and not be YASP.
I understand it's more work but it seems partially redundant to have both
UseRecalls and RecallsInterface. I believe using the values I suggest above
would ease the work, since the current UseRecalls = 1 is equivalent to the
would be RecallsInterface = 'opac', although some current checks for truthy
UseRecalls would also now encompass '2' and '3', maybe not critical but just
something to consider.

--------------

Some improvements to error messaging could be considered:

Attempt to place a recall on an item not checked out, you get:
"Unable to place a recall. Check your circulation rules."
When you should get something like:
"Unable to place a recall on an item not checked out."

Attempt to place a recall on the same patron that the item is checked out to,
you get:
"Unable to place a recall. Check your circulation rules."
When you should get something like
"Unable to place recall. Item is already checked out to user X"

-- 
You are receiving this mail because:
You are watching all bug changes.