[Koha-bugs] [Bug 36027] search_for_data_inconsistencies.pl - make each section optional

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36027

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |julian.maurice at biblibre.com

--- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> ---
Passing arbitrary numbers as command line arguments is not a good UI as it's
opaque (no way to guess that "3" means "check item status") and it's very hard
to remember what each number does.
Also it can make future changes more complicated: for instance if section 3
should be removed, what should we do with this number ? Leave it unassigned and
have "gaps" in the sequence ? Re-assign it to another check and break backward
compatibility ?

IMO it's far better to have option flags. And as the default behavior is to run
all checks, those option flags should disable a specific section when given.
For instance: --skip-items-branch --skip-age-for-category.
Getopt::Long can be used for that

Also documentation in POD should be updated and a --help flag should be added
to print usage help (see Pod::Usage)

-- 
You are receiving this mail because:
You are watching all bug changes.