From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 00:17:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Dec 2023 23:17:27 +0000 Subject: [Koha-bugs] [Bug 34041] z3950 responder additional options not coming through properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34041 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from David Nind --- Testing notes (using KTD): 1. If I manually add the change to /etc/koha/sites/kohadev/z3950/config.xml and restart, I get some errors. I think the last config needs to be ? So this should be: \-\-add-item-status k -t 5 2. However, if I do that, then I can't get the z3950 responder to start using restart_all - get this: ... Error: Z39.50/SRU not running for kohadev: failed! ... I don't know enough about the Z3950 responder to test if it is running properly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 10:31:44 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 09:31:44 +0000 Subject: [Koha-bugs] [Bug 25704] With ICU chains on, searching by callnumbers does not produce accurate results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25704 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #12 from Katrin Fischer --- I can confirm that callnum:TX 724 S6 leads to 1 result callnum:callnum:TX 724 S66 has 0 results callnum,rtrn:TX 724 S6 has 5 results All seems to work as intended. We'll definitely need more information here, since we could not reproduce the issue and for the link provided we don't know expected results or current configuration. I am closing this as INVALID, but please re-open if you still have issues. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 10:32:44 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 09:32:44 +0000 Subject: [Koha-bugs] [Bug 25691] Debian packages point to /usr/share/doc/koha/README.Debian which does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25691 --- Comment #1 from Katrin Fischer --- Should we replace this with a link to the instructions on the wiki? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 10:34:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 09:34:30 +0000 Subject: [Koha-bugs] [Bug 25689] Move 'Manage OPAC problem reports' permission into tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25689 --- Comment #1 from Katrin Fischer --- Maybe with the work on the new enquiries module it will make sense to have this as a module level permissions with sub-permissions? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 10:36:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 09:36:13 +0000 Subject: [Koha-bugs] [Bug 25688] 'All libraries' terminology used on first page of circulation rules is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25688 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 8366 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 10:36:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 09:36:13 +0000 Subject: [Koha-bugs] [Bug 8366] Meaning of "All" in issuing rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8366 --- Comment #16 from Katrin Fischer --- *** Bug 25688 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 10:39:58 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 09:39:58 +0000 Subject: [Koha-bugs] [Bug 25652] Holds daily is not looking at item type when not allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25652 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #6 from Katrin Fischer --- (In reply to Catrina Berka from comment #5) > Perhaps we should consider deleting this column from the table. Its location > is misleading. Can you explain what you mean a bit more? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 10:51:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 09:51:14 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 --- Comment #74 from Katrin Fischer --- (In reply to Martin Renvoize from comment #73) > This has been on my radar for a long time. I'll jump on it first thing in > the morning and get to through QA now it rebases and signed off again. Ping? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 10:53:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 09:53:15 +0000 Subject: [Koha-bugs] [Bug 25533] Perl "not numeric" warning on the "Holds" page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25533 --- Comment #6 from Katrin Fischer --- (In reply to Andrii Nugged from comment #5) > Yes, we will re-investigate and analyze/argue or re-create the fix, few days > please :). Ping? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 11:01:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 10:01:07 +0000 Subject: [Koha-bugs] [Bug 25495] members-home.pl should allow search for exact borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25495 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 30533 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 11:01:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 10:01:07 +0000 Subject: [Koha-bugs] [Bug 30533] Add exact search option for patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30533 --- Comment #5 from Katrin Fischer --- *** Bug 25495 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 11:05:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 10:05:15 +0000 Subject: [Koha-bugs] [Bug 25474] Component Description for 'Templates' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25474 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- I am sorry this got missed. Fixed now and also verified spelling in other component descriptions is correct. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 11:20:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 10:20:24 +0000 Subject: [Koha-bugs] [Bug 25467] Improve performance of ViewPolicy filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25467 --- Comment #2 from Katrin Fischer --- Should this have been "Needs Sign-off"? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 11:23:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 10:23:50 +0000 Subject: [Koha-bugs] [Bug 25453] Koha::SearchEngine::ES In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25453 --- Comment #6 from Katrin Fischer --- What is the state of this? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 11:24:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 10:24:39 +0000 Subject: [Koha-bugs] [Bug 25446] Terminology: Replace relatives by other term? (family members, group members...) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25446 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon at ptfs-europe. | |com, | |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 11:25:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 10:25:39 +0000 Subject: [Koha-bugs] [Bug 25424] Document our exceptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25424 --- Comment #2 from Katrin Fischer --- If you give me some more pointers, I or others might be able to help in writing this up. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 11:28:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 10:28:20 +0000 Subject: [Koha-bugs] [Bug 25401] Backup/Restore functionalities for configuration tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25401 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Backup/Restore Functions |Backup/Restore | |functionalities for | |configuration tables -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 13:34:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 12:34:35 +0000 Subject: [Koha-bugs] [Bug 25366] MARC import does not have duplicate record search option for online items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25366 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 13:36:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 12:36:20 +0000 Subject: [Koha-bugs] [Bug 25345] Duplicate course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25345 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 13:43:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 12:43:59 +0000 Subject: [Koha-bugs] [Bug 25338] Koha checks items in when lost fee waived/paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25338 --- Comment #9 from Katrin Fischer --- Christopher, could you confirm bug 24474 fixed this in later versions? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 13:45:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 12:45:42 +0000 Subject: [Koha-bugs] [Bug 25328] Date formatting from JS - Remove tz handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25328 --- Comment #1 from Katrin Fischer --- Can you confirm if this still needs updating? I was not sure where to check in the code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 13:50:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 12:50:39 +0000 Subject: [Koha-bugs] [Bug 25314] Make OPAC facets collapse In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 --- Comment #19 from Katrin Fischer --- Might be nice to revisit this one :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 13:52:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 12:52:41 +0000 Subject: [Koha-bugs] [Bug 25295] Allow customization of staff interface based on login location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25295 --- Comment #6 from Katrin Fischer --- Now that we have OpacUser* options on library level, we could probably do the same for the staff interface? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 13:59:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 12:59:03 +0000 Subject: [Koha-bugs] [Bug 25289] CalculateFinesOnReturn does not affect SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25289 --- Comment #1 from Katrin Fischer --- It looks like the pref is checked in AddReturn, so that could explain it not showing up in SIP code. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 14:15:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 13:15:21 +0000 Subject: [Koha-bugs] [Bug 25243] Accessibility: 2.4.6 Headings and Labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25243 --- Comment #5 from Katrin Fischer --- I can see that all the depending bugs have been resolved - do we have any known issues here remaining? How could we identify them? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 14:16:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 13:16:30 +0000 Subject: [Koha-bugs] [Bug 25241] Accessibility: 1.4.4 Resize text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25241 --- Comment #2 from Katrin Fischer --- Is there a way we could identify this type of issues? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 14:23:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 13:23:13 +0000 Subject: [Koha-bugs] [Bug 25221] Imported records are not checked for accuracy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25221 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 14:54:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 13:54:04 +0000 Subject: [Koha-bugs] [Bug 25163] Add the ability to bulk attach items to a bib record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25163 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 14:57:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 13:57:31 +0000 Subject: [Koha-bugs] [Bug 25158] Introduce koha-memcached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25158 --- Comment #3 from Katrin Fischer --- (In reply to Magnus Enger from comment #2) > I suspect this is made obsolete by misc/bin/clear_cache.pl from Bug 20116. Should we close? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 15:32:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 14:32:04 +0000 Subject: [Koha-bugs] [Bug 25134] Return claims column should not be shown if ClaimReturnedLostValue is not set to a valid value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25134 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #10 from Katrin Fischer --- This works if both BundleLostValue and ClaimReturnedLostValue are empty. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 15:34:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 14:34:19 +0000 Subject: [Koha-bugs] [Bug 25122] Authority lookup shouldn't include non-authority fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25122 --- Comment #1 from Katrin Fischer --- Phil, can you tell if this is still valid? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 15:39:43 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 14:39:43 +0000 Subject: [Koha-bugs] [Bug 25112] Koha::CirculationRules->set_rules should handle scopes per rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25112 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25554 --- Comment #14 from Katrin Fischer --- Hos does this relate to bug 25554? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 15:39:43 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 14:39:43 +0000 Subject: [Koha-bugs] [Bug 25554] Refactor rule kinds assignments in CirculationRules.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25554 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25112 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 15:42:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 14:42:40 +0000 Subject: [Koha-bugs] [Bug 25098] automatic item modification needs report function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25098 --- Comment #8 from Katrin Fischer --- I suppose this should be logged as interface cron and item modification in the action logs. I haven't tested, but if that was the case, I think we could mark this closed? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 15:51:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 14:51:15 +0000 Subject: [Koha-bugs] [Bug 24967] Allow final user to choose ordering column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24967 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 20:58:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 19:58:01 +0000 Subject: [Koha-bugs] [Bug 34062] Additional contents with library set do not appear in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34062 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- I had a go at testing (using KTD), but I couldn't replicate the issue. When I refreshed the page, it displayed as expected - I didn't get the "This page does not exist". I was not logged in to the OPAC. Before the test plan, I: 1. Edited the Apache configuration: sudo vi /etc/apache2/sites-available/kohadev.conf 2. In the virtual host section for the OPAC () I added: SetEnv OPAC_BRANCH_DEFAULT "CPL" 3. Restarted everything (restart_all) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 22:40:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 21:40:45 +0000 Subject: [Koha-bugs] [Bug 35477] Adding non-existent items to the waiting list should display a warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35477 --- Comment #12 from Victor Grousset/tuxayo --- (In reply to Jonathan Druart from comment #11) > But this is a discussion for somewhere else. Ok, so it doesn't currently mandate it. So not failing QA for this. That was the thing that blocked me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 22:41:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 21:41:08 +0000 Subject: [Koha-bugs] [Bug 35477] Adding non-existent items to the waiting list should display a warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35477 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159611|0 |1 is obsolete| | --- Comment #13 from Victor Grousset/tuxayo --- Created attachment 160387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160387&action=edit Bug 35477: Show a warning when non-existent items are added to the waiting list Only messages "X new items added" or "No items added" were displayed. With this patch we will display: A warning with "No items added" A warning with "X new items added. Y items not found." when some items have not been added A messages "X new items added" when everything went well Signed-off-by: Matt Blenkinsop Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 22:41:10 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 21:41:10 +0000 Subject: [Koha-bugs] [Bug 35477] Adding non-existent items to the waiting list should display a warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35477 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159927|0 |1 is obsolete| | --- Comment #14 from Victor Grousset/tuxayo --- Created attachment 160388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160388&action=edit Bug 35477: (QA follow-up): tidy up code Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 22:42:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 21:42:18 +0000 Subject: [Koha-bugs] [Bug 35477] Adding non-existent items to the waiting list should display a warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35477 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #15 from Victor Grousset/tuxayo --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 23:33:10 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 22:33:10 +0000 Subject: [Koha-bugs] [Bug 27291] Change datetime format in Zebra logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27291 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114581|0 |1 is obsolete| | --- Comment #9 from David Nind --- Created attachment 160389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160389&action=edit Bug 27291: Reformat Zebra output logs This patch changes the Zebra output log time format from the default "hh:mm:ss-DD/MM" to the more standard ISO 8601 "%FT%T". This change makes the logs easier to read for both humans and machines. One benefit includes easy searching and sorting. Test plan: 1. cp debian/scripts/koha-zebra /usr/sbin/koha-zebra 2. koha-zebra --stop kohadev 3. koha-zebra --start kohadev 4. ps -efww | grep "zebrasrv" 5. Note "-m %FT%T" in the grep output 6. tail -f /var/log/koha/kohadev/zebra-output.log 7. Run a few searches like http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=ccl%3Dargawarga%3D1 or http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=e 8. Note that the timestamp in the Zebra log is formatted "2020-12-22T00:13:42" instead of like "00:13:42-22/12" Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 23:36:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 22:36:47 +0000 Subject: [Koha-bugs] [Bug 27291] Change datetime format in Zebra logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27291 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This enhancement changes release notes| |the Zebra output log time | |format from the default | |"hh:mm:ss-DD/MM" to the | |more standard ISO 8601 | |"%FT%T". | | | |This makes the | |logs easier to read for | |both humans and machines. | |One benefit includes easy | |searching and sorting. --- Comment #10 from David Nind --- Testing notes (using KTD): 1. Note the amended test plan in comment #8 (particularly to change the log level) 2. Koha package commands: use sudo in front or access shell as ktd --root --shell -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 23:37:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 22:37:31 +0000 Subject: [Koha-bugs] [Bug 27291] Change datetime format in Zebra logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27291 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 23:52:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 22:52:21 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #67 from David Cook --- (In reply to Katrin Fischer from comment #66) > > How does it work in combination with view_borrower_infos_from_any_libraries? > > Or more: how does it relate to this one? > I am just trying to get a clear picture on how this works. > Please switch back to PQA after reply, so I don't miss it. Thanks! It works the same way as it does for "edit_borrowers". The "view_borrower_infos_from_any_libraries" is handled by the API via Koha::Patron. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 23:59:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 22:59:53 +0000 Subject: [Koha-bugs] [Bug 35655] Make it possible to switch off RabbitMQ without any warns in logs/about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35655 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 00:05:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 23:05:01 +0000 Subject: [Koha-bugs] [Bug 31572] E-mail and SMS verification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31572 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- (In reply to Mwoo from comment #1) > Love this idea! Maybe it would even help keep our emails from going to the > spam folder. If your Koha emails are going to the user's spam folder, then your Koha is probably sending emails via a mail server that isn't really 'authorized' to use that email address. I've noticed a lot of Koha staff admins configure Koha to use email addresses from their institutions, but this almost always requires additional work behind the scenes to get working correctly. (The exception being if the Koha staff admin have set up the SMTP server to be their institutional SMTP server.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 00:38:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 23:38:13 +0000 Subject: [Koha-bugs] [Bug 25384] Label maker font list is not configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 00:38:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 23:38:15 +0000 Subject: [Koha-bugs] [Bug 25384] Label maker font list is not configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108377|0 |1 is obsolete| | --- Comment #22 from David Nind --- Created attachment 160390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160390&action=edit Bug 25384: Use koha-conf.xml to configure label maker font list This patch fetches the "ttf" element in koha-conf.xml, and looks for entries with a "name" attribute. If it's an existing default font, it will rename that font. If it's a new font, it will add it to the font list in the label creator pages. If you don't change anything in koha-conf.xml, then there is no behaviour change and the existing unit tests will all complete as normal. Test plan: 1) Apply patch 2) Edit koha-conf.xml and add a "name" attribute of "Times New Awesome" next to the font "type" "TR". 3) Edit koha-conf.xml and add the following entry to the "ttf" element: /usr/share/fonts/truetype/liberation/LiberationSans-Regular.ttf 4) Clear memcached (if using memcached) a. e.g. echo 'flush_all' | nc -q 1 memcached 11211 5) Restart Plack (if using Plack) a. e.g. koha-plack --restart kohadev 6) Create or edit a Label maker layout a. e.g. /cgi-bin/koha/labels/label-edit-layout.pl?op=edit&element_id=17 7) Note that "Times-Roman" now says "Times New Awesome" instead 8) Note that there is now an "Arial" option at the bottom of the list 9) Try to export a label batch using a layout using "Arial" 10) Note that the text is output with a font style similar to Arial Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 00:38:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 23:38:18 +0000 Subject: [Koha-bugs] [Bug 25384] Label maker font list is not configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108378|0 |1 is obsolete| | --- Comment #23 from David Nind --- Created attachment 160391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160391&action=edit Bug 25384: Use dclone when copying font lookup hash This patch includes the logic from Bug 25852. That is, use dclone to copy the hash used as the font lookup. While the original patch perfectly copied the top level keys, the next level down were hash references (due to Perl's inherent hash design), and changes to the 2nd level of depth would be changes to these references which would impact the original hash. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 00:54:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2024 23:54:47 +0000 Subject: [Koha-bugs] [Bug 25384] Label maker font list is not configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |dcook at prosentient.com.au |u | CC| |david at davidnind.com Text to go in the| |This enhancement lets you release notes| |configure the label maker | |font list by editing | |koha-conf.xml. It fetches | |the "ttf" element in | |koha-conf.xml, and looks | |for entries with a "name" | |attribute. | |- If it's an | |existing default font, it | |will rename that font. | |- If | |it's a new font, it will | |add it to the font list in | |the label creator pages. | |- | |If you don't change | |anything in koha-conf.xml, | |then there is no behaviour | |change. | | | |Note: To configure | |the name displayed in the | |label maker, add a name | |element in your | |koha-conf.xml in the | |section (for example: | |name="Times New Roman"). To | |add a new font, add an | |entry in the section | |(for example: /usr/share/fon | |ts/truetype/liberation/Libe | |rationSans-Regular.ttf). --- Comment #24 from David Nind --- Testing notes (using KTD): 1. The patches still apply. 2. Everything works as per the test plan. I was not sure about some of the later comments, so please feel free to change the status if any of these need addressing in this bug. I changed the assignee to David Cook, feel free to change it if that is no longer the case. I've had a go at the release notes - not sure that I've have got this right. Feel free to edit it! Just to confirm that I understand this change correctly. Before this patch, you couldn't configure how the font names were displayed (they were hard coded), but you could still add new fonts? This change now lets you configure how the fonts are displayed in the lists, and you can still add new fonts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 02:11:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 01:11:00 +0000 Subject: [Koha-bugs] [Bug 25384] Label maker font list is not configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #25 from David Cook --- (In reply to David Nind from comment #24) > Testing notes (using KTD): > > 1. The patches still apply. > > 2. Everything works as per the test plan. > > I was not sure about some of the later comments, so please feel free to > change the status if any of these need addressing in this bug. > > I changed the assignee to David Cook, feel free to change it if that is no > longer the case. > > I've had a go at the release notes - not sure that I've have got this right. > Feel free to edit it! > Thanks, David. You are a champion! I think that this change should have unit tests, so I'm going to Failed QA my own patches, unfortunately. But your work here makes me want to return and add them! I'm not in the office much in January, but I'll add it to my list! > Just to confirm that I understand this change correctly. Before this patch, > you couldn't configure how the font names were displayed (they were hard > coded), but you could still add new fonts? This change now lets you > configure how the fonts are displayed in the lists, and you can still add > new fonts. Before this patch, you couldn't configure how the font names and you couldn't add new fonts all together. You could only change the font file associated with a certain font name. So if you wanted to use a font type that wasn't in the list, you'd have to just override an existing font, and perhaps use some Javascript to change the name in the list to the appropriate name. Does that make sense? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 02:22:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 01:22:15 +0000 Subject: [Koha-bugs] [Bug 35578] Validate "Where" in OPAC Authority search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35578 --- Comment #5 from David Cook --- (In reply to Julian Maurice from comment #4) > Why do we call multi_param for marclist ? Is there any case where it makes > sense to have multiple values ? I've looked at ./koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authorities-home.tt and opac/opac-authorities-home.pl. At a glance, it's not clear why these are array variables. I've done a bit of "git blame" and basically it looks like really old legacy code that basically never made sense. I think it's out of scope for this bug, but this could certainly be refactored. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 02:53:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 01:53:32 +0000 Subject: [Koha-bugs] [Bug 35659] OAI Harvester In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au Status|Needs Signoff |Failed QA --- Comment #3 from David Cook --- This is great news! Once my January holidays are done, I can look more at these patches! At a glance, you will need to add unit tests for Koha::OAI::Client::Harvester before this can Pass QA (PERL17 in the coding guidelines), and that might require a bit of refactoring. (Missing unit tests are what ultimately bit me with bug 10662.) I think that we're not allowing function declarations in .pl scripts anymore either (for admin/oaiservers.pl) so that might need to be refactored. That said, I can't find a reference to it in the coding guidelines and the patches pass the QA scripts, so I could be wrong there. But other than that the patches are looking pretty good at a glance I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 02:54:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 01:54:12 +0000 Subject: [Koha-bugs] [Bug 35659] OAI Harvester In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659 --- Comment #4 from David Cook --- I'm having some trouble running /kohadevbox/koha/t/db_dependent/Koha/OAIServers.t as part of the QA scripts, but it might be my install. I'm going to try to refresh my ktd... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 03:10:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 02:10:49 +0000 Subject: [Koha-bugs] [Bug 35659] OAI Harvester In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659 --- Comment #5 from David Cook --- I updated my ktd and now I'm getting failures when running the QA tools, although I've got the unit test working. I notice there is a little typo in the pod in Koha/Import/Oaipmh/Authority.pm where it says "type" instead of "_type". Same with Koha/Import/Oaipmh/Biblio.pm and Koha/OaiServers.pm. Koha/OAI/Client/Harvester.pm is missing POD. I think the error for Koha/OaiServer.pm is false though. Not sure why that's getting a pod coverage error... I think the tidiness can also be ignored for the Schema files... -- qa -c 2 -v 2 testing 2 commit(s) (applied to ac02c1d 'ad Bug 35405: Remove noise from MARC:') Processing files before patches The PO directory has not been found. There is a problem in your Koha installation. at /kohadevbox/koha/Koha/I18N.pm line 197. |========================>| 27 / 27 (100.00%) Processing files after patches |========================>| 27 / 27 (100.00%) OK Koha/Import/Oaipmh/Authorities.pm FAIL Koha/Import/Oaipmh/Authority.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 FAIL Koha/Import/Oaipmh/Biblio.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK Koha/Import/Oaipmh/Biblios.pm FAIL Koha/OAI/Client/Harvester.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 FAIL Koha/OaiServer.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK Koha/OaiServers.pm FAIL Koha/Schema/Result/ImportOaipmhAuthority.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 33) FAIL Koha/Schema/Result/ImportOaipmhBiblio.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 28) FAIL Koha/Schema/Result/Oaiserver.pm FAIL pod coverage POD is missing for koha_object_class POD is missing for koha_objects_class WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 24) OK admin/oaiservers.pl OK installer/data/mysql/atomicupdate/Bug-35659.pl OK installer/data/mysql/en/mandatory/sample_notices.yml OK installer/data/mysql/kohastructure.sql OK installer/data/mysql/mandatory/sysprefs.sql OK koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc OK koha-tmpl/intranet-tmpl/prog/en/includes/oai-admin-search.inc OK koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/oaiservers.tt OK koha-tmpl/intranet-tmpl/prog/en/xslt/AuthOAIDCtoMARC21XML.xsl OK koha-tmpl/intranet-tmpl/prog/en/xslt/AuthOAIDCtoUNIMARCXML.xsl OK koha-tmpl/intranet-tmpl/prog/en/xslt/OAIDCtoMARC21XML.xsl OK koha-tmpl/intranet-tmpl/prog/en/xslt/OAIDCtoUNIMARCXML.xsl OK koha-tmpl/intranet-tmpl/prog/en/xslt/OAIMarcxml2KohaMarcxml.xsl OK misc/cronjobs/harvest_oai.pl OK t/db_dependent/Koha/OAIServers.t Processing additional checks * Commit title does not start with 'Bug XXXXX: ' - 44b002f8cc Running tests (1) * Proving /kohadevbox/koha/t/db_dependent/Koha/OAIServers.t OK! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 03:18:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 02:18:19 +0000 Subject: [Koha-bugs] [Bug 25221] Imported records are not checked for accuracy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25221 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 03:25:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 02:25:12 +0000 Subject: [Koha-bugs] [Bug 25467] Improve performance of ViewPolicy filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25467 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 03:26:23 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 02:26:23 +0000 Subject: [Koha-bugs] [Bug 24261] Google openID Authentication drops requested URL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24261 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- *** This bug has been marked as a duplicate of bug 34164 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 03:26:23 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 02:26:23 +0000 Subject: [Koha-bugs] [Bug 34164] OAuth2/OIDC should redirect to page that initiated login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34164 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mihai.bojonca at tcmi.edu --- Comment #2 from David Cook --- *** Bug 24261 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 04:08:34 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 03:08:34 +0000 Subject: [Koha-bugs] [Bug 25384] Label maker font list is not configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement lets you |This enhancement lets you release notes|configure the label maker |configure the label maker |font list by editing |font list and add new |koha-conf.xml. It fetches |fonts. It fetches the |the "ttf" element in |section from koha-conf.xml, |koha-conf.xml, and looks |and looks for entries with |for entries with a "name" |a "name" attribute: |attribute. |- For |- If it's an |an existing default font, |existing default font, it |it will rename that font in |will rename that font. |the font list. |- If |- For a new |it's a new font, it will |font, it will add it to the |add it to the font list in |font list in the label |the label creator pages. |creator pages. |- |- If you |If you don't change |don't change anything in |anything in koha-conf.xml, |koha-conf.xml, then there |then there is no behaviour |is no behaviour change. |change. | | |Notes: |Note: To configure |1. To configure the |the name displayed in the |name displayed in the label |label maker, add a name |maker font list, add a name |element in your |element in koha-conf.xml to |koha-conf.xml in the |the font in the |section (for example: |section (for example: |name="Times New Roman"). To |name="Times New Roman"). |add a new font, add an |2. |entry in the section |To add a new font, add an |(for example: section |type="A" |(for example: /usr/share/fon |type="A" |ts/truetype/liberation/Libe |name="Arial">/usr/share/fon |rationSans-Regular.ttf). |rationSans-Regular.ttf). --- Comment #26 from David Nind --- (In reply to David Cook from comment #25) > Does that make sense? Thanks David, it does! Have a good break over January. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 08:27:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 07:27:53 +0000 Subject: [Koha-bugs] [Bug 35659] OAI Harvester In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 09:24:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 08:24:01 +0000 Subject: [Koha-bugs] [Bug 34686] reserve_id should be linked in tmp_holdsqueue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34686 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #7 from Katrin Fischer --- (In reply to Nick Clemens from comment #6) > We have this information in the hold_fill_targets, what is the use case for > adding it here? We didn't know about hold_fill_targets at the time. I think using it to create the link will be enough. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 10:37:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 09:37:53 +0000 Subject: [Koha-bugs] [Bug 35679] New: dateofbirthrequired column from categories table should be renamed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35679 Bug ID: 35679 Summary: dateofbirthrequired column from categories table should be renamed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: pedro.amorim at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org git grep dateofbirthrequired The column dateofbirthrequired in the categories table has a confusing name. It sort of implies a boolean (i.e. whether date of birth is required or not), but it's actually utilized as a lower age limit check in the business logic. The column's comment states "the minimum age required for the patron category" which is how the data in this column is utilized. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 10:37:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 09:37:53 +0000 Subject: [Koha-bugs] [Bug 26297] Rest API: add a route to list patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35679 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 10:38:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 09:38:30 +0000 Subject: [Koha-bugs] [Bug 26297] Rest API: add a route to list patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 --- Comment #17 from Pedro Amorim --- (In reply to Katrin Fischer from comment #16) > Hi Pedro, as we have such a super specific column name here... we could just > update the reports using the column maybe? I am not opposed to fixing the > database in this case, just wonder if want to maybe do it separately from > this bug? Hi Katrin, thank you. I've added bug 35679. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 11:30:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 10:30:46 +0000 Subject: [Koha-bugs] [Bug 33431] Make code use C4::Context->yaml_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33431 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 11:30:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 10:30:49 +0000 Subject: [Koha-bugs] [Bug 33431] Make code use C4::Context->yaml_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33431 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160281|0 |1 is obsolete| | --- Comment #13 from Pedro Amorim --- Created attachment 160392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160392&action=edit Bug 33431: Make C4::Circulation use C4::Context->yaml_preference This patch removes manual YAML handling for sysprefs in C4::Circulation. It also makes C4::Context->yaml_preference not warn when undef is retrieved from the sysprefs. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/Circulation* => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: David Nind Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 11:30:51 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 10:30:51 +0000 Subject: [Koha-bugs] [Bug 33431] Make code use C4::Context->yaml_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33431 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160282|0 |1 is obsolete| | --- Comment #14 from Pedro Amorim --- Created attachment 160393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160393&action=edit Bug 33431: Make C4::Record use C4::Context->yaml_preference This patch makes what the title says. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/Rec* => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 11:30:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 10:30:54 +0000 Subject: [Koha-bugs] [Bug 33431] Make code use C4::Context->yaml_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33431 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160283|0 |1 is obsolete| | --- Comment #15 from Pedro Amorim --- Created attachment 160394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160394&action=edit Bug 33431: Fix remaining cases This patch tweaks three remaining cases, that are not covered by tests. To test: 1. Apply this patch 2. Make use of those places => SUCCESS: No behavior change Signed-off-by: David Nind Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 11:35:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 10:35:20 +0000 Subject: [Koha-bugs] [Bug 30260] Script which checks index should also check if the zebraqueue has uncommitted records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30260 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 11:35:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 10:35:24 +0000 Subject: [Koha-bugs] [Bug 30260] Script which checks index should also check if the zebraqueue has uncommitted records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30260 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131532|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 160395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160395&action=edit Bug 30260: Add is_indexer_working check Function checks if the zebraqueue has rows that are not 'done' Will depend on a change in checkindex.sh which implements the check: https://git.koha-community.org/Koha-community/global/src/branch/master/koha-zebra/checkindex.sh To test: 1. disable the indexer sudo koha-indexer --stop INSTANCENAME 2. catalogue 5 new records 3. confirm they don't show in any search results 4. in your terminal, go to the shell sudo koha-shell INSTANCENAME 5. run the new script. run with -v for verbose or --rows X to specify how many uncommitted records should be checked for. 5 is the default perl misc/maintenance/check_zebraqueue.pl 6. confirm the script returns that the indexer is not working. The function in koha-functions.sh is required for the pending change to checkindex.sh Sponsored-by: Catalyst IT Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 11:38:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 10:38:01 +0000 Subject: [Koha-bugs] [Bug 35680] New: YAML system preferences cause error if syspref data is not YAML string Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35680 Bug ID: 35680 Summary: YAML system preferences cause error if syspref data is not YAML string Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: pedro.amorim at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org If a YAML preference has a string instead of the expected format, it'll cause an error - tested with RisExportAdditionalFields and ILLModuleDisclaimerByType but I'm sure others may cause this too. To reproduce: 1) Add 'string' to RisExportAdditionalFields sys pref 2) Visit RIS export link: /cgi-bin/koha/opac-export.pl?op=export&bib=262&format=ris 3) Notice the error Can't use string ("string") as a HASH ref while "strict refs" in use at /kohadevbox/koha/C4/Ris.pm line 132 Not critical, but ideally an error like this should not happen in the event that a system preference has wrong data in it. Adding bug 33431 as "See also" even though it's not the cause of the issue - as the test plans info there may also help here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 11:38:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 10:38:01 +0000 Subject: [Koha-bugs] [Bug 33431] Make code use C4::Context->yaml_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33431 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35680 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 11:38:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 10:38:17 +0000 Subject: [Koha-bugs] [Bug 30260] Script which checks index should also check if the zebraqueue has uncommitted records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30260 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #8 from David Nind --- Patch still applies and it worked for me: I had to add 6 new records for the default of 5 to work. Maybe check with Jonathan about the repo - probably something to do with access when we changed to Gitea. Maybe the repository should be added to gitlab.com/koha-community -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 12:06:10 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 11:06:10 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 Anneli Österman changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman at koha-suomi. | |fi --- Comment #40 from Anneli Österman --- Some notes: - If you add a new notice to Patrons (MEMBERS) category, they do not show up in Add message email drop down. Test plan does not apply in this case. - If you add a new notice to "Add message" category, they show up in Add message email drop down. There is no mention of this category in the test plan. - When you choose a notice to send, you cannot see it's content. You can see it only after it is saved to message queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 12:17:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 11:17:55 +0000 Subject: [Koha-bugs] [Bug 35587] Items lose their lost status when check-in triggers a transfer even though BlockReturnOfLostItems is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35587 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 12:17:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 11:17:57 +0000 Subject: [Koha-bugs] [Bug 35587] Items lose their lost status when check-in triggers a transfer even though BlockReturnOfLostItems is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35587 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160323|0 |1 is obsolete| | --- Comment #9 from Pedro Amorim --- Created attachment 160396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160396&action=edit Bug 35587: Do not trigger transfer if lost item returned and BlockReturnOfLostItems enabled This fixes current buggy behaviour - when BlockReturnOfLostItems is enabled, no transfer should be triggered and the lost status should be retained. To test: 1. Go to Koha Administration -> Global system preferences 2. Set the BlockReturnOfLostItems system preference to Block 3. Enable the AutomaticItemReturn system preference (this is simply to make testing a bit faster) 4. Take note of your logged in library 5. Search for an item where the home library is NOT the same as your logged in library 6. Edit this item and give it a lost status 7. Check in the item 8. Notice the item is returned and a transfer is automatically triggered 9. If you go to the item record page, the lost status has been remove 10. Apply the patch and restart services 11. Edit the item again and give it a lost status. This will also cancel the transfer 12. Check in the item 13. Confirm the transfer is NOT triggered and the lost status is retained as expected. 14. Go back to system preferences and disable the BlockReturnOfLostItems system preference (set to "Don't block") 15. Check in the item 16. Confirm the transfer is triggered and lost status is removed 17. Confirm tests pass prove t/db_dependent/Circulation/Returns.t prove t/db_dependent/Circulation/Branch.t Sponsored-by: Pymble Ladies' College Signed-off-by: Esther Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 12:18:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 11:18:00 +0000 Subject: [Koha-bugs] [Bug 35587] Items lose their lost status when check-in triggers a transfer even though BlockReturnOfLostItems is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35587 --- Comment #10 from Pedro Amorim --- Created attachment 160397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160397&action=edit Bug 35587: (QA follow-up): QA script tidy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 12:18:44 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 11:18:44 +0000 Subject: [Koha-bugs] [Bug 35587] Items lose their lost status when check-in triggers a transfer even though BlockReturnOfLostItems is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35587 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160396|0 |1 is obsolete| | --- Comment #11 from Pedro Amorim --- Created attachment 160398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160398&action=edit Bug 35587: Do not trigger transfer if lost item returned and BlockReturnOfLostItems enabled This fixes current buggy behaviour - when BlockReturnOfLostItems is enabled, no transfer should be triggered and the lost status should be retained. To test: 1. Go to Koha Administration -> Global system preferences 2. Set the BlockReturnOfLostItems system preference to Block 3. Enable the AutomaticItemReturn system preference (this is simply to make testing a bit faster) 4. Take note of your logged in library 5. Search for an item where the home library is NOT the same as your logged in library 6. Edit this item and give it a lost status 7. Check in the item 8. Notice the item is returned and a transfer is automatically triggered 9. If you go to the item record page, the lost status has been remove 10. Apply the patch and restart services 11. Edit the item again and give it a lost status. This will also cancel the transfer 12. Check in the item 13. Confirm the transfer is NOT triggered and the lost status is retained as expected. 14. Go back to system preferences and disable the BlockReturnOfLostItems system preference (set to "Don't block") 15. Check in the item 16. Confirm the transfer is triggered and lost status is removed 17. Confirm tests pass prove t/db_dependent/Circulation/Returns.t prove t/db_dependent/Circulation/Branch.t Sponsored-by: Pymble Ladies' College Signed-off-by: Esther Signed-off-by: Kelly Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 12:18:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 11:18:47 +0000 Subject: [Koha-bugs] [Bug 35587] Items lose their lost status when check-in triggers a transfer even though BlockReturnOfLostItems is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35587 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160397|0 |1 is obsolete| | --- Comment #12 from Pedro Amorim --- Created attachment 160399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160399&action=edit Bug 35587: (QA follow-up): QA script tidy Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 12:29:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 11:29:24 +0000 Subject: [Koha-bugs] [Bug 35392] HTML in translatable string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 --- Comment #19 from Pedro Amorim --- (In reply to Katrin Fischer from comment #18) > The translation is one issue, but there is another: > For usability and accessibility we should always put the link on meaningful > words, so no links like 'here' or 'click here'. People know that they can > click links and screen readers will be happier reading something that > reveals the purpose of a link. > > Maybe this would work? > > '
  • Job for uploaded file has been queued. href="/cgi-bin/koha/admin/background_jobs.pl?op=view&id=%s" > target="_blank">Check progress
    • ' > > The span I think would break this into 2 strings for translation. > > Do we have another translation issue here? > > + { short: "Jan", description: "January", value: 1, active: true > }, > + { short: "Feb", description: "February", value: 2, active: true > }, > + { short: "Mar", description: "March", value: 3, active: true }, > + { short: "Apr", description: "April", value: 4, active: true }, Katrin, these are very good points, however can we please open one (or two?) new bugs for these issues you mention? The original problem here has to do with HTML being present in a translatable string, whereas I believe what you're referring to are possibly different problems: 1) Usability: "Click here" link in ERM usage statistics background job dialog should be handled differently 2) Possible problem with month names translatability in ERM usage statistics reports (please provide a test plan) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 12:57:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 11:57:09 +0000 Subject: [Koha-bugs] [Bug 35539] Remove unused columns from categories table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35539 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26297 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 [Bug 26297] Rest API: add a route to list patron categories -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 12:57:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 11:57:09 +0000 Subject: [Koha-bugs] [Bug 26297] Rest API: add a route to list patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35539 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35539 [Bug 35539] Remove unused columns from categories table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 13:34:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 12:34:46 +0000 Subject: [Koha-bugs] [Bug 25467] Improve performance of ViewPolicy filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25467 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #3 from Nick Clemens --- (In reply to Katrin Fischer from comment #2) > Should this have been "Needs Sign-off"? I think it re -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 13:35:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 12:35:22 +0000 Subject: [Koha-bugs] [Bug 25467] Improve performance of ViewPolicy filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25467 --- Comment #4 from Nick Clemens --- I think it requires unit tests, I have no idea if this code is still relevant -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 13:36:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 12:36:26 +0000 Subject: [Koha-bugs] [Bug 35539] Remove unused columns from categories table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35539 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35679 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 13:36:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 12:36:26 +0000 Subject: [Koha-bugs] [Bug 35679] dateofbirthrequired column from categories table should be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35679 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35539 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 13:49:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 12:49:27 +0000 Subject: [Koha-bugs] [Bug 35539] Remove unused columns from categories table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35539 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 13:49:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 12:49:30 +0000 Subject: [Koha-bugs] [Bug 35539] Remove unused columns from categories table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35539 --- Comment #5 from Pedro Amorim --- Created attachment 160400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160400&action=edit Bug 35539: [DONT PUSH] dbic Removal of bulk Removal of finetype Removal of issuelimit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 13:49:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 12:49:32 +0000 Subject: [Koha-bugs] [Bug 35539] Remove unused columns from categories table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35539 --- Comment #6 from Pedro Amorim --- Created attachment 160401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160401&action=edit Bug 35539: Remove 'bulk' column/field from categories table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 13:49:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 12:49:35 +0000 Subject: [Koha-bugs] [Bug 35539] Remove unused columns from categories table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35539 --- Comment #7 from Pedro Amorim --- Created attachment 160402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160402&action=edit Bug 35539: Remove 'finetype' column/field from categories table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 13:49:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 12:49:38 +0000 Subject: [Koha-bugs] [Bug 35539] Remove unused columns from categories table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35539 --- Comment #8 from Pedro Amorim --- Created attachment 160403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160403&action=edit Bug 35539: Remove 'issuelimit' column/field from categories table -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 13:49:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 12:49:40 +0000 Subject: [Koha-bugs] [Bug 35539] Remove unused columns from categories table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35539 --- Comment #9 from Pedro Amorim --- Created attachment 160404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160404&action=edit Bug 35539: Atomicupdate Removal of 'bulk' column Removal of 'finetype' column Removal of 'issuelimit' column Test plan, k-t-d: 1) Add data to the relevant columns, run the following mysql: update categories set bulk = 1; update categories set finetype = 1; update categories set issuelimit = 1; 2) Run updatedatabase, notice it shows a warning and does not update the database 3) Clean up the data, run the folllowing mysql: update categories set bulk = null; update categories set finetype = null; update categories set issuelimit = null; 4) Run updatedatabase again, notice it updates the database as intended Run: t/db_dependent/Circulation/GetHardDueDate.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 13:50:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 12:50:42 +0000 Subject: [Koha-bugs] [Bug 35539] Remove unused columns from categories table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35539 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pedro.amorim at ptfs-europe.co |ity.org |m Component|Patrons |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 13:51:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 12:51:42 +0000 Subject: [Koha-bugs] [Bug 34575] Patron search results: Customise the fields displayed in Name column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34575 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pedro.amorim at ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 13:52:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 12:52:41 +0000 Subject: [Koha-bugs] [Bug 35570] Add a generic master form in ILL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pedro.amorim at ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 14:25:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 13:25:55 +0000 Subject: [Koha-bugs] [Bug 26297] Rest API: add a route to list patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 --- Comment #18 from Martin Renvoize --- Comment on attachment 159955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159955 Bug 26297: (QA Follow-up); Review of attachment 159955: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=26297&attachment=159955) ----------------------------------------------------------------- ::: api/v1/swagger/definitions/patron_category.yaml @@ +35,2 @@ > type: > - boolean Is it really a boolean.. the comments suggest it should be an int? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 14:46:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 13:46:45 +0000 Subject: [Koha-bugs] [Bug 35539] Remove unused columns from categories table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35539 --- Comment #10 from Martin Renvoize --- Comment on attachment 160404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160404 Bug 35539: Atomicupdate Review of attachment 160404: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=35539&attachment=160404) ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/bug_35539.pl @@ +15,5 @@ > + SELECT bulk FROM categories; > + | > + ); > + if ($bulkdata) { > + say $out YELLOW, We'll need to test how this looks in the UI.. it's a nice addition for the console output, but not everyone runs their updates this way.. many use the web UI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 14:51:25 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 13:51:25 +0000 Subject: [Koha-bugs] [Bug 35663] opac-privacy.pl wording is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35663 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 14:59:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 13:59:12 +0000 Subject: [Koha-bugs] [Bug 35663] opac-privacy.pl wording is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35663 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 14:59:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 13:59:14 +0000 Subject: [Koha-bugs] [Bug 35663] opac-privacy.pl wording is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35663 --- Comment #5 from Owen Leonard --- Created attachment 160405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160405&action=edit Bug 35663: Reword default privacy option in opac-privacy.pl This patch updates the description of the OPAC privacy page, replacing: "Default: keep my history according to local laws. This is the default option : the library will keep your history for the duration permitted by local laws." ...with: "Default: keep my history according to library policy. This is the default option : the library will keep your history for the duration set by library policy." This correctly reflects the fact that privacy is managed according to a Koha cron configuration. To test, apply the patch and make sure the OPACPrivacy and related preferences are enabled. - Log in to the OPAC and click the "Privacy" tab in the left-hand sidebar. - Confirm that the description of the default privacy option is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 15:11:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 14:11:39 +0000 Subject: [Koha-bugs] [Bug 35398] EDI: Fix support for LRP (Library Rotation Plan) for Koha with Stock Rotation enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35398 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 15:11:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 14:11:41 +0000 Subject: [Koha-bugs] [Bug 35398] EDI: Fix support for LRP (Library Rotation Plan) for Koha with Stock Rotation enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35398 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160352|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 160406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160406&action=edit Bug 35398: Fix LRP support for EDI orders with single items This patch corrects a mistake in the original implementaiton of bug 20595 where we introduced support for the LRP segments being used to automatically assign items ordered via EDI to stock rotation plans. Signed-off-by: Sophie Halden Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 15:11:51 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 14:11:51 +0000 Subject: [Koha-bugs] [Bug 35398] EDI: Fix support for LRP (Library Rotation Plan) for Koha with Stock Rotation enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35398 --- Comment #7 from Kyle M Hall --- Created attachment 160407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160407&action=edit Bug 35398: (QA follow-up) Tidy code Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 15:46:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 14:46:47 +0000 Subject: [Koha-bugs] [Bug 35663] opac-privacy.pl wording is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35663 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 15:46:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 14:46:49 +0000 Subject: [Koha-bugs] [Bug 35663] opac-privacy.pl wording is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35663 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160405|0 |1 is obsolete| | --- Comment #6 from Lucas Gass --- Created attachment 160408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160408&action=edit Bug 35663: Reword default privacy option in opac-privacy.pl This patch updates the description of the OPAC privacy page, replacing: "Default: keep my history according to local laws. This is the default option : the library will keep your history for the duration permitted by local laws." ...with: "Default: keep my history according to library policy. This is the default option : the library will keep your history for the duration set by library policy." This correctly reflects the fact that privacy is managed according to a Koha cron configuration. To test, apply the patch and make sure the OPACPrivacy and related preferences are enabled. - Log in to the OPAC and click the "Privacy" tab in the left-hand sidebar. - Confirm that the description of the default privacy option is correct. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 15:47:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 14:47:55 +0000 Subject: [Koha-bugs] [Bug 34136] Add ability to render a report using a notice template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34136 --- Comment #16 from Kyle M Hall --- (In reply to Caroline Cyr La Rose from comment #15) > (In reply to Katrin Fischer from comment #8) > > > > > * We absolutely need documentation for this: Needs to be added to print, > > uses a 'data' object with the db columns etc. > > For the manual, I only reproduced the example that was here as I don't know > a lot of TT except the very basic basics. We should definitely have a wiki > page about this... Agreed. A library of report/template combos would be very useful. The only times I've used this feature so far are so specific as to be useless to other libraries. I do wonder if we should have an optional template section on the existing reports library wiki page, or if we should start a separate page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 15:49:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 14:49:37 +0000 Subject: [Koha-bugs] [Bug 35663] opac-privacy.pl wording is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35663 --- Comment #7 from Lucas Gass --- Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 16:23:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 15:23:01 +0000 Subject: [Koha-bugs] [Bug 35681] New: Add support for colored messages in the output of updatedatabase Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Bug ID: 35681 Summary: Add support for colored messages in the output of updatedatabase Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com We could use Term::ANSIColor in our database revisions to aid in highlighting different outputs, but in doing so we introduce escape sequences that look 'nasty' in the browser representation. We should add support for those sequences, allowing the same end user experience via browser or terminal. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 16:31:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 15:31:06 +0000 Subject: [Koha-bugs] [Bug 34062] Additional contents with library set do not appear in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34062 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #4 from Lucas Gass --- This only deals with opac-page.pl ( custom page) but the test plan refers to additional contents. What about HTML customization and News? Also, I experience the same as David did: "I had a go at testing (using KTD), but I couldn't replicate the issue." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 16:55:28 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 15:55:28 +0000 Subject: [Koha-bugs] [Bug 35682] New: Provide ability to specify color in DB upgrades Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35682 Bug ID: 35682 Summary: Provide ability to specify color in DB upgrades Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: pedro.amorim at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 17:01:44 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 16:01:44 +0000 Subject: [Koha-bugs] [Bug 35682] Provide ability to specify color in DB upgrades In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35682 --- Comment #1 from Pedro Amorim --- Created attachment 160409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160409&action=edit Bug 35682: [TEST ONLY]: This is a dummy dbrev to force an update -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 17:01:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 16:01:47 +0000 Subject: [Koha-bugs] [Bug 35682] Provide ability to specify color in DB upgrades In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35682 --- Comment #2 from Pedro Amorim --- Created attachment 160410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160410&action=edit Bug 35682: WIP Attemp to move colors from terminal into nice HTML You need to manually set version in Koha.pm to something before the test dbrev here. Version systempreference also needs to match the above (no action needed if testing for the first time) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 17:02:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 16:02:08 +0000 Subject: [Koha-bugs] [Bug 35539] Remove unused columns from categories table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35539 --- Comment #11 from Pedro Amorim --- (In reply to Martin Renvoize from comment #10) > We'll need to test how this looks in the UI.. it's a nice addition for the > console output, but not everyone runs their updates this way.. many use the > web UI Fair point, after testing an upgrade through the browser, the ANSI codes are printed in the web UI and it doesn't look good. I gave a shot trying to grab the colors coming from the terminal and converting them to HTML (using HTML::FromANSI) but this seems to create more problems than it solves. The idea here was to highlight - in a different color - that some action is required, before or following this upgrade. I've posted my WIP at bug 35682 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 17:02:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 16:02:16 +0000 Subject: [Koha-bugs] [Bug 35539] Remove unused columns from categories table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35539 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35682 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 17:02:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 16:02:16 +0000 Subject: [Koha-bugs] [Bug 35682] Provide ability to specify color in DB upgrades In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35682 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35539 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 17:02:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 16:02:38 +0000 Subject: [Koha-bugs] [Bug 35682] Provide ability to specify color in DB upgrades In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35682 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 17:04:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 16:04:11 +0000 Subject: [Koha-bugs] [Bug 35682] Provide ability to specify color in DB upgrades In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35682 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160410|0 |1 is obsolete| | --- Comment #3 from Pedro Amorim --- Created attachment 160411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160411&action=edit Bug 35682: WIP Attemp to move colors from terminal into nice HTML You need to manually set version in Koha.pm to something before the test dbrev here. Version systempreference also needs to match the above (no action needed if testing for the first time) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 17:52:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 16:52:21 +0000 Subject: [Koha-bugs] [Bug 29905] Superlibrarians should be able to delete any patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29905 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 18:04:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 17:04:04 +0000 Subject: [Koha-bugs] [Bug 19616] Add MARC21 505$g - Formatted Contents Note / Miscellaneous information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19616 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35675 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35675 [Bug 35675] Marc 505 extra punctuation at the end of the data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 18:04:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 17:04:04 +0000 Subject: [Koha-bugs] [Bug 35675] Marc 505 extra punctuation at the end of the data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35675 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Depends on| |19616 --- Comment #1 from Owen Leonard --- Looks like this CSS was added by Bug 19616 but I'm not sure if something has changed and it isn't working the way it was in 20.11. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19616 [Bug 19616] Add MARC21 505$g - Formatted Contents Note / Miscellaneous information -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 18:20:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 17:20:41 +0000 Subject: [Koha-bugs] [Bug 26297] Rest API: add a route to list patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 --- Comment #19 from Pedro Amorim --- Created attachment 160412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160412&action=edit Bug 26297: Update API spec lower_age_limit is a number, not a boolean -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 18:22:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 17:22:11 +0000 Subject: [Koha-bugs] [Bug 26297] Rest API: add a route to list patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 --- Comment #20 from Pedro Amorim --- (In reply to Martin Renvoize from comment #18) > Comment on attachment 159955 [details] [review] > Bug 26297: (QA Follow-up); > > Review of attachment 159955 [details] [review]: > ----------------------------------------------------------------- > > ::: api/v1/swagger/definitions/patron_category.yaml > @@ +35,2 @@ > > type: > > - boolean > > Is it really a boolean.. the comments suggest it should be an int? Well spotted thanks! I completely missed this. It made sense and worked when I first wrote the patch turning it into boolean on schema files, but that was wrong ( and now obsolete) so this API spec needed updating. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 18:35:34 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 17:35:34 +0000 Subject: [Koha-bugs] [Bug 35539] Remove unused columns from categories table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35539 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 18:35:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 17:35:37 +0000 Subject: [Koha-bugs] [Bug 35539] Remove unused columns from categories table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35539 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160400|0 |1 is obsolete| | --- Comment #12 from David Nind --- Created attachment 160413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160413&action=edit Bug 35539: [DONT PUSH] dbic Removal of bulk Removal of finetype Removal of issuelimit Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 18:35:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 17:35:40 +0000 Subject: [Koha-bugs] [Bug 35539] Remove unused columns from categories table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35539 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160401|0 |1 is obsolete| | --- Comment #13 from David Nind --- Created attachment 160414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160414&action=edit Bug 35539: Remove 'bulk' column/field from categories table Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 18:35:43 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 17:35:43 +0000 Subject: [Koha-bugs] [Bug 35539] Remove unused columns from categories table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35539 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160402|0 |1 is obsolete| | --- Comment #14 from David Nind --- Created attachment 160415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160415&action=edit Bug 35539: Remove 'finetype' column/field from categories table Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 18:35:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 17:35:46 +0000 Subject: [Koha-bugs] [Bug 35539] Remove unused columns from categories table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35539 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160403|0 |1 is obsolete| | --- Comment #15 from David Nind --- Created attachment 160416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160416&action=edit Bug 35539: Remove 'issuelimit' column/field from categories table Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 18:35:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 17:35:49 +0000 Subject: [Koha-bugs] [Bug 35539] Remove unused columns from categories table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35539 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160404|0 |1 is obsolete| | --- Comment #16 from David Nind --- Created attachment 160417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160417&action=edit Bug 35539: Atomicupdate Removal of 'bulk' column Removal of 'finetype' column Removal of 'issuelimit' column Test plan, k-t-d: 1) Add data to the relevant columns, run the following mysql: update categories set bulk = 1; update categories set finetype = 1; update categories set issuelimit = 1; 2) Run updatedatabase, notice it shows a warning and does not update the database 3) Clean up the data, run the folllowing mysql: update categories set bulk = null; update categories set finetype = null; update categories set issuelimit = null; 4) Run updatedatabase again, notice it updates the database as intended Run: t/db_dependent/Circulation/GetHardDueDate.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 18:37:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 17:37:30 +0000 Subject: [Koha-bugs] [Bug 35683] New: Record Detail View should more accurately display the material type Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35683 Bug ID: 35683 Summary: Record Detail View should more accurately display the material type Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: esther.melander at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl The record detail view appears to pull the Material Type display information from the 000 Leader space 6. This needs more consistency and a better reflection of the material type. Some examples: Projected medium = Film Language Material = Text Mixed materials = Mixed Materials Musical Sound Recording = Music Nonmusical Sound Recording = Sound Manuscript language Material = Text Notated Music = Score Some of these make sense, but others could cause confusion. For example the term Film could imply a motion picture or a 35mm film. Perhaps it would be better if the display replicated the text in space 6. It may be difficult to have better precision with the language because of the continual changing of the definitions over time. To further add to the discussion, if more specificity is wanted, then the 007 could also be used as a check for the display. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 18:44:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 17:44:42 +0000 Subject: [Koha-bugs] [Bug 35684] New: Koha XSLT material type icons documentation needs updating Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35684 Bug ID: 35684 Summary: Koha XSLT material type icons documentation needs updating Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: esther.melander at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The manual needs updating for the material types. For example, Notated Music, Cartographic Materials, Projected Medium, material type icons in Koha but are not included in the manual. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 18:46:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 17:46:00 +0000 Subject: [Koha-bugs] [Bug 28166] Optionally add MARC fields to authority search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Rasa Satinskiene changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Rasa Satinskiene contact| | CC| |rasa.satinskiene at ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 18:53:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 17:53:04 +0000 Subject: [Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 18:53:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 17:53:06 +0000 Subject: [Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151428|0 |1 is obsolete| | --- Comment #10 from Lucas Gass --- Created attachment 160418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160418&action=edit Bug 33639: Make add item to item group work from additem.pl To test: 1, Create one or more item groups for a bib if needed 2. Create a new item, and at the bottom of the 'Add item' screen, select the item group to which you want this item added. Save. 3. On the Normal tab, see that the item has not been added to the item group you selected. 4. APPLY PATCH, restart_all 5. Try 1-3 again but this time the item should succesffuly be added to the item group. 6. Add a new item and to the same record and this time try the 'Create a new item group' from the dropdown. 7. Name the new item group. 8. Make sure it is correctly added to the item group. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 18:55:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 17:55:03 +0000 Subject: [Koha-bugs] [Bug 35683] Record Detail View should more accurately display the material type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35683 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 19:02:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 18:02:18 +0000 Subject: [Koha-bugs] [Bug 35461] Renew All 66 SIP server response messages produce HASH content in replies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35461 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 19:02:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 18:02:21 +0000 Subject: [Koha-bugs] [Bug 35461] Renew All 66 SIP server response messages produce HASH content in replies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35461 --- Comment #1 from Kyle M Hall --- Created attachment 160419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160419&action=edit Bug 35461: Add unit tests Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 19:02:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 18:02:26 +0000 Subject: [Koha-bugs] [Bug 35461] Renew All 66 SIP server response messages produce HASH content in replies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35461 --- Comment #2 from Kyle M Hall --- Created attachment 160420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160420&action=edit Bug 35461: Fix function call parameters causing the HASH to show in the renew all responses "Renew All" -function aka. 65-66-messages work like this: 66-return messages has renewed items in BM-fields and non-renewables go into BN-fields. If all items were renewable, then the reply message looks like: Reply: 13.07.2022 10:06:17:530 OUTESTI1 6610005000020220713 100616AOOUPK|BM564N15977171|BM564N09203960|BM564N23261720|BM564N25161958|BM564N23455012|C4::SIP::SIPServer=HASHC4::SIP::SIPServer=HASHAY6AZCEFE If items include renewables and non-renewables, the response includes the renewed items first, then a HASH mixed into the first BN-field, then rest of the renewed ones like they should show in BN-fields and after that, anohter HASH: 13.07.2022 14:41:32:610 OUTESTI1 6610003000420220713 144130AOOUPK|BM564N23455012|BM564N23261720|BM564N25161958|C4::SIP::SIPServer=HASHBN564N09203960|BN564N04191259|BN564N15977171|BN564N13788332|C4::SIP::SIPServer=HASHAY8AZC7C5 If all loans were unrenewable (this test included just one item), you first get a HASH in a BN-field, and another at the end. 13.07.2022 14:49:00:037 OUTESTI1 6610000000120220713 144858AOOUPK|C4::SIP::SIPServer=HASHBN564N19874533|C4::SIP::SIPServer=HASHAY9AZDD3B Our self checkout/checkin machine can handle/parse these reply messages correctly, but this might not be the case with all self checkout/checkin devices. Test Plan: 1) Unit test patch 2) prove t/db_dependent/SIP/Message.t 3) Note failures 4) Apply this patch 5) prove t/db_dependent/SIP/Message.t 6) Tests pass! Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 19:07:10 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 18:07:10 +0000 Subject: [Koha-bugs] [Bug 35461] Renew All 66 SIP server response messages produce HASH content in replies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35461 --- Comment #3 from Kyle M Hall --- Created attachment 160421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160421&action=edit Bug 35461: Tidy code Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 19:18:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 18:18:12 +0000 Subject: [Koha-bugs] [Bug 25122] Authority lookup shouldn't include non-authority fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25122 --- Comment #2 from Phil Ringnalda --- Still valid, nothing has changed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 19:24:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 18:24:16 +0000 Subject: [Koha-bugs] [Bug 33640] Adding new item group from item additem.pl does nothing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33640 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Lucas Gass --- *** This bug has been marked as a duplicate of bug 33639 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 19:24:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 18:24:16 +0000 Subject: [Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 --- Comment #11 from Lucas Gass --- *** Bug 33640 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 19:25:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 18:25:19 +0000 Subject: [Koha-bugs] [Bug 34234] Item groups dropdown in detail page modal does not respect display order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34234 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24857 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 [Bug 24857] Add ability to group items for records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 19:25:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 18:25:19 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34234 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34234 [Bug 34234] Item groups dropdown in detail page modal does not respect display order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 19:35:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 18:35:07 +0000 Subject: [Koha-bugs] [Bug 29285] UI tests: Selenium 4 support or setup Cypress to make them rewritable with it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29285 --- Comment #3 from Victor Grousset/tuxayo --- > Yes because Firefox is stuck at some old version In case someone needs the info, it's Firefox 92, from September 2021. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 20:10:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 19:10:31 +0000 Subject: [Koha-bugs] [Bug 35581] ILL Koha classes are not consistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 20:10:34 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 19:10:34 +0000 Subject: [Koha-bugs] [Bug 35581] ILL Koha classes are not consistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159863|0 |1 is obsolete| | --- Comment #12 from David Nind --- Created attachment 160422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160422&action=edit Bug 35581: Illbackend.pm -> ILL/Backend.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 20:10:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 19:10:37 +0000 Subject: [Koha-bugs] [Bug 35581] ILL Koha classes are not consistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159864|0 |1 is obsolete| | --- Comment #13 from David Nind --- Created attachment 160423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160423&action=edit Bug 35581: Illbatch.pm -> ILL/Batch.pm Illbatches.pm -> ILL/Batches.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 20:10:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 19:10:40 +0000 Subject: [Koha-bugs] [Bug 35581] ILL Koha classes are not consistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159865|0 |1 is obsolete| | --- Comment #14 from David Nind --- Created attachment 160424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160424&action=edit Bug 35581: Illbatchstatus.pm -> ILL/Batch/status.pm Illbatchstatuses.pm -> ILL/Batch/Statuses.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 20:10:43 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 19:10:43 +0000 Subject: [Koha-bugs] [Bug 35581] ILL Koha classes are not consistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159866|0 |1 is obsolete| | --- Comment #15 from David Nind --- Created attachment 160425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160425&action=edit Bug 35581: Illcomment.pm -> ILL/Comment.pm Illcomments.pm -> ILL/Comments.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 20:10:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 19:10:46 +0000 Subject: [Koha-bugs] [Bug 35581] ILL Koha classes are not consistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159867|0 |1 is obsolete| | --- Comment #16 from David Nind --- Created attachment 160426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160426&action=edit Bug 35581: Illrequestattribute.pm -> ILL/Request/Attribute.pm Illrequestattributes.pm -> ILL/Request/Attributes.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 20:10:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 19:10:49 +0000 Subject: [Koha-bugs] [Bug 35581] ILL Koha classes are not consistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159868|0 |1 is obsolete| | --- Comment #17 from David Nind --- Created attachment 160427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160427&action=edit Bug 35581: Koha/Illrequest/Workflow.pm -> Koha/ILL/Request/Workflow.pm Koha/Illrequest/Workflow/Availability.pm -> Koha/ILL/Request/Workflow/Availability.pm Koha/Illrequest/Workflow/TypeDisclaimer.pm -> Koha/ILL/Request/Workflow/TypeDisclaimer.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 20:10:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 19:10:52 +0000 Subject: [Koha-bugs] [Bug 35581] ILL Koha classes are not consistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159869|0 |1 is obsolete| | --- Comment #18 from David Nind --- Created attachment 160428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160428&action=edit Bug 35581: Koha/Illrequest/Config.pm -> Koha/ILL/Request/Config.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 20:10:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 19:10:55 +0000 Subject: [Koha-bugs] [Bug 35581] ILL Koha classes are not consistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159870|0 |1 is obsolete| | --- Comment #19 from David Nind --- Created attachment 160429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160429&action=edit Bug 35581: Koha/Illrequest/Logger.pm -> Koha/ILL/Request/Logger.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 20:10:58 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 19:10:58 +0000 Subject: [Koha-bugs] [Bug 35581] ILL Koha classes are not consistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159871|0 |1 is obsolete| | --- Comment #20 from David Nind --- Created attachment 160430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160430&action=edit Bug 35581: Koha/Illrequest/SupplierUpdate.pm -> Koha/ILL/Request/SupplierUpdate.pm Koha/Illrequest/SupplierUpdateProcessor.pm -> Koha/ILL/Request/SupplierUpdateProcessor.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 20:11:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 19:11:02 +0000 Subject: [Koha-bugs] [Bug 35581] ILL Koha classes are not consistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159872|0 |1 is obsolete| | --- Comment #21 from David Nind --- Created attachment 160431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160431&action=edit Bug 35581: Koha/Illrequest.pm -> Koha/ILL/Request.pm Koha/Illrequests.pm -> Koha/ILL/Requests.pm Merged: t/db_dependent/Koha/Illrequests.t t/db_dependent/Illrequests.t Into: t/db_dependent/Koha/ILL/Requests.t ILL classes file structure is, for the most part, around 7 years old and doesn't follow a strict logic. It's so confusing that some test files exist redundantly. This housekeeping should help future work in regards to ISO18626 to add Koha as a supplying agency instead of just requesting agency, as is now. It should also help future housekeeping of moving backend related logic out of the Illrequest.pm into Illbackend.pm (now ILL/Request.pm and ILL/Backend.pm as of this patchset). It should also help in structuring the addition of a master generic form (see bug 35570) This patchset will require existing backends to be updated to match the new class names and structure, if they invoke them. Test plan, k-t-d, run tests: prove t/db_dependent/api/v1/ill_* prove t/db_dependent/Koha/ILL/* Test plan, k-t-d, manual: 1) Install FreeForm, enable ILL module, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) You'll have to switch the FreeForm repo to the one compatible with this work, like: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout reorganize_ILL 3) Do some generic ILL testing: 3.1) Create a request 3.2) Add a comment to a request 3.3) Edit a request 3.4) Edit a request's item metadata 3.5) Confirm a request 3.6) List requests 3.7) Filter requests list using left side filters 4) Install a metadata enrichment plugin: https://github.com/PTFS-Europe/koha-plugin-api-pubmed 4.1) Create an ILL batch and insert a pubmedid like 123 4.2) Add the request and finish batch 5) Verify all of the above works as expected Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 20:11:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 19:11:05 +0000 Subject: [Koha-bugs] [Bug 35581] ILL Koha classes are not consistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159873|0 |1 is obsolete| | --- Comment #22 from David Nind --- Created attachment 160432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160432&action=edit Bug 35581: QA Follow-up: Fix tidy warnings Fix forbidden pattern: Incorrect license statement (using postal address) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 20:17:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 19:17:41 +0000 Subject: [Koha-bugs] [Bug 35581] ILL Koha classes are not consistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #23 from David Nind --- Testing notes (using KTD): 1. Tests pass. 2. Also tested manually as per the test plan. For the PUBMED plugin, I created a request using these details: - Type: Journal article - Title: Regeneration of the heart - PMID: 22095736 (used when creating the batch) I'm not so familiar with the workflow for ILL requests, so it may be useful to have someone that is to add their sign off as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 20:46:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 19:46:35 +0000 Subject: [Koha-bugs] [Bug 19605] ILL backends should be pluggable through regular Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 20:46:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 19:46:38 +0000 Subject: [Koha-bugs] [Bug 19605] ILL backends should be pluggable through regular Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158068|0 |1 is obsolete| | --- Comment #12 from David Nind --- Created attachment 160433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160433&action=edit Bug 19605: Add 'ill_backend' plugin category Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 20:46:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 19:46:41 +0000 Subject: [Koha-bugs] [Bug 19605] ILL backends should be pluggable through regular Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158069|0 |1 is obsolete| | --- Comment #13 from David Nind --- Created attachment 160434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160434&action=edit Bug 19605: Update expandTemplate to expand_template method name Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 20:46:44 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 19:46:44 +0000 Subject: [Koha-bugs] [Bug 19605] ILL backends should be pluggable through regular Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158070|0 |1 is obsolete| | --- Comment #14 from David Nind --- Created attachment 160435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160435&action=edit Bug 19605: Add support for ILL backends as plugins This is designed to maintain existing functionality of loading ILL backends through the backend_dir config (default Koha/Illbackends/). A check for a plugin of a given backend name takes precedence over a backend of the same name loaded the old way through backend_dir, this means that if this happens, the backend plugin is used and NOT the backend present in backend_dir. Old backend_dir backends AND new backend plugins coexist. Test plan, k-t-d: 1) Enable ILLModule and install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Install the plugin ILL backend example .kpz located at: https://github.com/ammopt/koha-ill-backend-plugin/releases/tag/1.0.0 3) koha-plack --restart kohadev 4) Visit ILL requests: /cgi-bin/koha/ill/ill-requests.pl 5) Click "+ New ILL request". Notice it lists 'FreeForm' and 'PluginBackend' 6) Click 'PluginBackend'. Enter a '123' in pubmedid, '42' in cardnumber and pick a library. Click 'Marke request' 7) Notice the request is created successfully. 8) Visit plugins: /cgi-bin/koha/plugins/plugins-home.pl 9) Click "View plugin by class". Pick "ill backend plugins". Notice the correct plugin is listed. 10) Click "configure" on the ILL backend plugin. Notice it's a normal plugin configuration page Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 21:10:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 20:10:40 +0000 Subject: [Koha-bugs] [Bug 35648] Allow sorting of patron categories in Overdue notice/status triggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Version|unspecified |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 21:17:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 20:17:40 +0000 Subject: [Koha-bugs] [Bug 35680] YAML system preferences cause error if syspref data is not YAML string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35680 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 21:37:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 20:37:13 +0000 Subject: [Koha-bugs] [Bug 35461] Renew All 66 SIP server response messages produce HASH content in replies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35461 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- The tests pass for me with only the 'Add unit tests' patch. The test plan says that it shouldn't. Is this an issue for sign off (they also pass after applying all the patches)? Note: This was on master. I tried on 22.11, but the patch doesn't apply, prove -v t/db_dependent/SIP/Message.t t/db_dependent/SIP/Message.t .. 1..18 # Subtest: Testing Patron Status Request V2 1..13 ok 1 - At least we got a response. ok 2 - Response code fine ok 3 - Verified institution id ok 4 - Verified patron id ok 5 - Verified patron name ok 6 - Verified code BL ok 7 - Verified code CQ ok 8 - Verified non-empty screen message ok 9 - Verified code CQ for wrong pw ok 10 - code CQ should be N for empty AD ok 11 - Verified code BL for wrong cardnumber ok 12 - Name should be empty now ok 13 - But we have a screen msg ok 1 - Testing Patron Status Request V2 # Subtest: Testing Patron Info Request V2 1..32 ok 1 - At least we got a response. ok 2 - Response code fine ok 3 - Verified institution id ok 4 - Verified patron id ok 5 - Verified patron name ok 6 - Verified code BL ok 7 - Verified code CQ ok 8 - Checked existence of fee limit ok 9 - Address in BD ok 10 - Verified email in BE ok 11 - Verified home phone in BF ok 12 - We have a screen msg ok 13 - Check customized patron name ok 14 - Home address successfully stripped from response ok 15 - Email address successfully stripped from response ok 16 - Home phone successfully stripped from response ok 17 - Date of birth successfully stripped from response ok 18 - Home address successfully stripped from response ok 19 - Email address successfully retained in response ok 20 - Home phone successfully retained in from response ok 21 - Date of birth successfully stripped from response ok 22 - Home address successfully stripped from response ok 23 - Email address successfully stripped from response ok 24 - Home phone successfully retained in from response ok 25 - Date of birth successfully stripped from response ok 26 - code CQ should be N for empty AD ok 27 - code CQ should be Y if empty AD allowed ok 28 - Patron account not locked already ok 29 - Patron account is not locked by patron info messages with empty password ok 30 - Verified code BL for wrong cardnumber ok 31 - Name should be empty now ok 32 - But we have a screen msg ok 2 - Testing Patron Info Request V2 # Subtest: Checkout V2 1..8 ok 1 - Check screen msg ok 2 - Item was not checked out (prevcheckout_block_checkout enabled) ok 3 - Item was checked out (prevcheckout_block_checkout disabled) ok 4 - Found AH field as timestamp in response ok 5 - Found AH field as SQL date in response ok 6 - Check screen msg ok 7 - Item was not checked out (item type matched blocked_item_types) ok 8 - Item was checked out successfully ok 3 - Checkout V2 # Subtest: Test checkout desensitize 1..6 ok 1 - Desensitize flag was not set for patron category in inhouse_patron_categories ok 2 - Desensitize flag was set for patron category not in inhouse_patron_categories ok 3 - Desensitize flag was set for empty inhouse_patron_categories ok 4 - Desensitize flag was not set for itemtype in inhouse_item_types ok 5 - Desensitize flag was set for item type not in inhouse_item_types ok 6 - Desensitize flag was set for empty inhouse_item_types ok 4 - Test checkout desensitize # Subtest: Test renew desensitize 1..6 ok 1 - Desensitize flag was not set for patron category in inhouse_patron_categories ok 2 - Desensitize flag was set for patron category not in inhouse_patron_categories ok 3 - Desensitize flag was set for empty inhouse_patron_categories ok 4 - Desensitize flag was set for item type not in inhouse_item_types ok 5 - Desensitize flag was set for empty inhouse_item_types ok 6 - Desensitize flag was not set for itemtype in inhouse_item_types ok 5 - Test renew desensitize # Subtest: Test renew desensitize 1..3 ok 1 - Found corrent BM for item renewed successfully ok 2 - Found corrent BN for item not renewed ok 3 - String 'C4::SIP::SIPServer' not found in reponse ( Bug 35461 ) ok 6 - Test renew desensitize # Subtest: Checkin V2 1..40 ok 1 - Checkin of invalid item with two warnings ok 2 - Response code fine ok 3 - OK flag is false ok 4 - Alert flag is set ok 5 - Check screen msg ok 6 - Check that AQ is in the response ok 7 - OK flag is false when checking in an item that was not checked out ok 8 - Alert flag is set ok 9 - Check screen msg ok 10 - OK flag is true now with checked_in_ok flag set when checking in an item that was not checked out ok 11 - Alert flag no longer set ok 12 - No screen msg ok 13 - Alert flag is set with check_in_ok, item is checked in but needs transfer ok 14 - Got FID_ALERT_TYPE (CV) field with value 04 ( needs transfer ) ok 15 - No FID_ALERT_TYPE (CV) field ok 16 - FID_ALERT_TYPE (CV) field is 00 ok 17 - Checkin without CV triggers alert flag when cv_triggers_alert is off ok 18 - Checkin without CV does not trigger alert flag when cv_triggers_alert is on ok 19 - No FID_DESTINATION_LOCATION (CT) field ok 20 - FID_DESTINATION_LOCATION (CT) field is empty but present ok 21 - OK flag is false when we check in at the wrong branch and we do not allow it ok 22 - Alert flag is set ok 23 - Check screen msg ok 24 - DBIx error on duplicate issue_id ok 25 - OK flag is false when we encounter data corruption in old_issues ok 26 - Alert flag is set ok 27 - Check screen msg ok 28 - OK flag is true when we checkin after removing the duplicate ok 29 - Alert flag is not set ok 30 - Issue record is gone now ok 31 - Item is checked out ok 32 - Hold was created successfully ok 33 - OK flag is false when we check in an item on hold and we do not allow it ok 34 - Alert flag is set ok 35 - Item was not checked in ok 36 - Hold was not marked as found by SIP when holds_block_checkin enabled ok 37 - OK flag is true when we check in an item on hold and we allow it but do not capture it ok 38 - Alert flag is set ok 39 - Item was checked in ok 40 - Hold was not marked as found by SIP when holds_get_captured disabled ok 7 - Checkin V2 # Subtest: Test hold_patron_bcode 1..2 ok 1 - SIP item with no hold returns empty string ok 2 - maybe_add returns empty string for SIP item with no hold returns empty string ok 8 - Test hold_patron_bcode # Subtest: UseLocationAsAQInSIP syspref tests 1..2 ok 1 - When UseLocationAsAQInSIP is not set SIP item has permanent_location set to value of homebranch ok 2 - When UseLocationAsAQInSIP is set SIP item has permanent_location set to value of item permanent_location ok 9 - UseLocationAsAQInSIP syspref tests # Subtest: hold_patron_name() tests 1..3 ok 1 - SIP item with no hold returns empty string for patron name ok 2 - maybe_add returns empty string for SIP item with no hold returns empty string ok 3 - maybe_add will create the field of the string '0' ok 10 - hold_patron_name() tests # Subtest: Lastseen response 1..6 ok 1 - At least we got a response. ok 2 - Response code fine ok 3 - Last seen not updated if not tracking patrons ok 4 - At least we got a response. ok 5 - Response code fine ok 6 - Last seen updated if tracking patrons ok 11 - Lastseen response # Subtest: Test patron_status_string 1..9 ok 1 - Found 2 checkouts for this patron ok 2 - Found 2 lost checkouts for this patron ok 3 - lost_block_checkout = 0 does not block checkouts with 2 lost checkouts ok 4 - lost_block_checkout = 0 does not block checkouts with 2 lost checkouts ok 5 - lost_block_checkout = 1 does block checkouts with 2 lost checkouts ok 6 - lost_block_checkout = 2 does block checkouts with 2 lost checkouts ok 7 - lost_block_checkout = 3 does not block checkouts with 2 lost checkouts ok 8 - lost_block_checkout = 2, lost_block_checkout_value = 2 does not block checkouts with 2 lost checkouts where only 1 has itemlost = 2 ok 9 - lost_block_checkout = 2, lost_block_checkout_value = 2 does block checkouts with 2 lost checkouts where only 1 has itemlost = 2 ok 12 - Test patron_status_string # Subtest: Test build_additional_item_fields_string 1..2 ok 1 - Attribute field generated correctly with single param ok 2 - Attribute field generated correctly with multiple params ok 13 - Test build_additional_item_fields_string # Subtest: Test build_custom_field_string 1..2 ok 1 - Attribute field generated correctly with single param ok 2 - Attribute field generated correctly with multiple params ok 14 - Test build_custom_field_string # Subtest: Test cr_item_field 1..8 ok 1 - Found correct CR field in response ok 2 - datelastseen remains unchanged ok 3 - datelastseen updated ok 4 - item remains lost ok 5 - datelastseen updated ok 6 - item is no longer lost ok 7 - Found correct CR field in response ok 8 - Found correct CR field in response ok 15 - Test cr_item_field # Subtest: Patron info summary > 5 should not crash server 1..22 ok 1 - At least we got a response. ok 2 - Response code fine ok 3 - At least we got a response. ok 4 - Response code fine ok 5 - At least we got a response. ok 6 - Response code fine ok 7 - At least we got a response. ok 8 - Response code fine ok 9 - At least we got a response. ok 10 - Response code fine ok 11 - At least we got a response. ok 12 - Response code fine ok 13 - At least we got a response. ok 14 - Response code fine ok 15 - At least we got a response. ok 16 - Response code fine ok 17 - At least we got a response. ok 18 - Response code fine ok 19 - At least we got a response. ok 20 - Response code fine ok 21 - At least we got a response. ok 22 - Response code fine ok 16 - Patron info summary > 5 should not crash server # Subtest: SC status tests 1..2 ok 1 - At least we got a response. ok 2 - Dies if sip user cannot be found ok 17 - SC status tests # Subtest: test_allow_additional_materials_checkout 1..4 ok 1 - Check screen msg ok 2 - Item was not checked out (allow_additional_materials_checkout disabled) ok 3 - Check screen msg ok 4 - Item was checked out (allow_additional_materials_checkout enabled ok 18 - test_allow_additional_materials_checkout ok All tests successful. Files=1, Tests=18, 8 wallclock secs ( 0.04 usr 0.01 sys + 5.43 cusr 1.05 csys = 6.53 CPU) Result: PASS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 21:47:28 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 20:47:28 +0000 Subject: [Koha-bugs] [Bug 35461] Renew All 66 SIP server response messages produce HASH content in replies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35461 --- Comment #5 from Kyle M Hall --- Created attachment 160436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160436&action=edit Bug 35461: (QA follow-up) Fix unit test -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 21:49:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 20:49:24 +0000 Subject: [Koha-bugs] [Bug 35461] Renew All 66 SIP server response messages produce HASH content in replies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35461 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160419|0 |1 is obsolete| | Attachment #160420|0 |1 is obsolete| | Attachment #160421|0 |1 is obsolete| | Attachment #160436|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 160437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160437&action=edit Bug 35461: Add unit tests Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 21:49:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 20:49:32 +0000 Subject: [Koha-bugs] [Bug 35461] Renew All 66 SIP server response messages produce HASH content in replies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35461 --- Comment #7 from Kyle M Hall --- Created attachment 160438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160438&action=edit Bug 35461: Fix function call parameters causing the HASH to show in the renew all responses "Renew All" -function aka. 65-66-messages work like this: 66-return messages has renewed items in BM-fields and non-renewables go into BN-fields. If all items were renewable, then the reply message looks like: Reply: 13.07.2022 10:06:17:530 OUTESTI1 6610005000020220713 100616AOOUPK|BM564N15977171|BM564N09203960|BM564N23261720|BM564N25161958|BM564N23455012|C4::SIP::SIPServer=HASHC4::SIP::SIPServer=HASHAY6AZCEFE If items include renewables and non-renewables, the response includes the renewed items first, then a HASH mixed into the first BN-field, then rest of the renewed ones like they should show in BN-fields and after that, anohter HASH: 13.07.2022 14:41:32:610 OUTESTI1 6610003000420220713 144130AOOUPK|BM564N23455012|BM564N23261720|BM564N25161958|C4::SIP::SIPServer=HASHBN564N09203960|BN564N04191259|BN564N15977171|BN564N13788332|C4::SIP::SIPServer=HASHAY8AZC7C5 If all loans were unrenewable (this test included just one item), you first get a HASH in a BN-field, and another at the end. 13.07.2022 14:49:00:037 OUTESTI1 6610000000120220713 144858AOOUPK|C4::SIP::SIPServer=HASHBN564N19874533|C4::SIP::SIPServer=HASHAY9AZDD3B Our self checkout/checkin machine can handle/parse these reply messages correctly, but this might not be the case with all self checkout/checkin devices. Test Plan: 1) Unit test patch 2) prove t/db_dependent/SIP/Message.t 3) Note failures 4) Apply this patch 5) prove t/db_dependent/SIP/Message.t 6) Tests pass! Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 21:50:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 20:50:14 +0000 Subject: [Koha-bugs] [Bug 35461] Renew All 66 SIP server response messages produce HASH content in replies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35461 --- Comment #8 from Kyle M Hall --- (In reply to David Nind from comment #4) > The tests pass for me with only the 'Add unit tests' patch. > > The test plan says that it shouldn't. > > Is this an issue for sign off (they also pass after applying all the > patches)? Fixed the bad test and squashed those changes into the original patch set! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 21:54:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 20:54:54 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #1 from Martin Renvoize --- Created attachment 160439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160439&action=edit Bug 35681: [TEST ONLY]: This is a dummy dbrev to force an update This patch adds an atomic update file and also an equivilent db_rev and increments the Koha.pm version too. Use it to test the output of updatedatebase, run via console or via the browser. Test plan 1) Start KTD without the patches applied. 2) Apply this test patch 3) Run the detabase updates via the console and confirm it looks reasonable and is colored. 4) Reset the database version in ktd `koha-mysql kohadev` `UPDATE systempreferences SET value = '23.1200002';` 5) Run the database updates via the browser; `http://localhost:8081/cgi-bin/koha/installer/install.pl?step=3&op=updatestructure` 6) Confirm the presence of weird looking escape characters on screen. 7) Apply the next patch and run through steps 3 to 5 again, this time confirming the browser output looks good. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 21:54:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 20:54:57 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #2 from Martin Renvoize --- Created attachment 160440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160440&action=edit Bug 35681: Allow for ANSI color in database updates This patch adds support for colored output in database updates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 22:01:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 21:01:05 +0000 Subject: [Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 22:01:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 21:01:08 +0000 Subject: [Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160418|0 |1 is obsolete| | --- Comment #12 from David Nind --- Created attachment 160441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160441&action=edit Bug 33639: Make add item to item group work from additem.pl To test: 1, Create one or more item groups for a bib if needed 2. Create a new item, and at the bottom of the 'Add item' screen, select the item group to which you want this item added. Save. 3. On the Normal tab, see that the item has not been added to the item group you selected. 4. APPLY PATCH, restart_all 5. Try 1-3 again but this time the item should succesffuly be added to the item group. 6. Add a new item and to the same record and this time try the 'Create a new item group' from the dropdown. 7. Name the new item group. 8. Make sure it is correctly added to the item group. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 22:11:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 21:11:26 +0000 Subject: [Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This fixes adding a new release notes| |item to an item group (when | |using the item groups | |feature - EnableItemGroups | |system preference). before | |this fix, even if you | |selected an item group, it | |was not added to it. --- Comment #13 from David Nind --- Testing notes (using KTD): 1. Enable the EnableItemGroups system preference. 2. enumchron issue noted in previous comments: after selecting New item, I added a value for serial enumeration, a call number, and a barcode. Under the "Add item group" it defaults to "Do not add to item group" - selecting a group does not change the value already entered in h - Serial enumeration / chronology. So I'm assuming that this is no longer an issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 22:24:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 21:24:53 +0000 Subject: [Koha-bugs] [Bug 35570] Add a generic master form in ILL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #9 from David Nind --- I applied the first three patches (I didn't apply the last two - Prevent use of ILL module if deprecated FreeForm backend is installed + QA follow-up). When I run the database update it says nothing should happen (Step 1, Atomicupdate patch), but I get: updatedatabase DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35570.pl [21:14:02]: Bug 35570 - Update 'FreeForm' ILL backend to 'Standard' Bug 35570: Finished database update. I'm confused about the sequence to test this.... is it: - Run through the test plan in the 'Atomicupdate' patch - Apply the remaining two patches - Run through the test plan in the 'Prevent use of ILL module if deprecated FreeForm backend is installed' patch Or something else? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 22:37:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 21:37:22 +0000 Subject: [Koha-bugs] [Bug 35461] Renew All 66 SIP server response messages produce HASH content in replies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35461 --- Comment #9 from David Nind --- I hope I haven't confused things.... With the unit tests patch, the tests fail (as expected): prove t/db_dependent/SIP/Message.t t/db_dependent/SIP/Message.t .. 5/18 # Failed test at t/db_dependent/SIP/Message.t line 1399. # got: '61' # expected: 'String 'HASH(' not found in reponse ( Bug 35461 )' # Looks like you failed 1 test of 3. # Failed test 'Test renew desensitize' # at t/db_dependent/SIP/Message.t line 106. t/db_dependent/SIP/Message.t .. 18/18 # Looks like you failed 1 test of 18. t/db_dependent/SIP/Message.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/18 subtests Test Summary Report ------------------- t/db_dependent/SIP/Message.t (Wstat: 256 Tests: 18 Failed: 1) Failed test: 6 Non-zero exit status: 1 Files=1, Tests=18, 7 wallclock secs ( 0.04 usr 0.00 sys + 5.08 cusr 1.11 csys = 6.23 CPU) Result: FAIL After applying the main patch, I'm still getting test failures: prove t/db_dependent/SIP/Message.t t/db_dependent/SIP/Message.t .. 5/18 # Failed test at t/db_dependent/SIP/Message.t line 1399. # got: '-2' # expected: 'String 'HASH(' not found in reponse ( Bug 35461 )' # Looks like you failed 1 test of 3. # Failed test 'Test renew desensitize' # at t/db_dependent/SIP/Message.t line 106. t/db_dependent/SIP/Message.t .. 17/18 # Looks like you failed 1 test of 18. t/db_dependent/SIP/Message.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/18 subtests Test Summary Report ------------------- t/db_dependent/SIP/Message.t (Wstat: 256 Tests: 18 Failed: 1) Failed test: 6 Non-zero exit status: 1 Files=1, Tests=18, 8 wallclock secs ( 0.03 usr 0.01 sys + 5.44 cusr 1.06 csys = 6.54 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 23:12:43 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 22:12:43 +0000 Subject: [Koha-bugs] [Bug 35392] HTML in translatable string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 --- Comment #20 from Katrin Fischer --- I would need to test this, but I think it's not unproblematic for translations: + '" target="_blank">' + + __("click here") + + " " + + __("to check its progress.") + + "" This will make it 2 separate strings in the po file. This is often quite hard to translate, maybe nicer with Weblate that keeps more of the sequence, but they could end up in 2 different spots of a big file. That's why I was suggesting to rephrase AND get rid of the click here the same time by making the link something like "Check progress". This bug is about improving translatability for a specific string, so I think not totally out of scope. > + { short: "Mar", description: "March", value: 3, active: true }, > + { short: "Apr", description: "April", value: 4, active: true }, For the second: I have no idea where it appears in the ERM module, so hard to provide a test plan right now. The code just looked very suspicious. But totally agree it should be on a separate bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 23:18:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 22:18:36 +0000 Subject: [Koha-bugs] [Bug 35659] OAI Harvester In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659 --- Comment #6 from Katrin Fischer --- We are still missing supporters for this in the road map: https://wiki.koha-community.org/wiki/Road_map_24.05 *hint* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 23:25:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 22:25:40 +0000 Subject: [Koha-bugs] [Bug 35659] OAI Harvester In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659 --- Comment #7 from David Cook --- (In reply to Katrin Fischer from comment #6) > We are still missing supporters for this in the road map: > https://wiki.koha-community.org/wiki/Road_map_24.05 *hint* I've just added myself. Hopefully someone else can jump on board too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 23:26:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 22:26:40 +0000 Subject: [Koha-bugs] [Bug 35683] Record Detail View should more accurately display the material type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35683 --- Comment #1 from Katrin Fischer --- The code for this is quite complicated, but I think the goal here was to use terms targeted to the users. I think some of the MARC terminology would be really hard to understand for library patrons. There is some documentation on the icons in the manual. I am not sure how complete it is, but maybe it would be a good starting point for discussion: https://koha-community.org/manual/latest/en/html/cataloging.html#material-type-cataloging-guide-label -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 23:27:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 22:27:30 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 23:27:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 22:27:37 +0000 Subject: [Koha-bugs] [Bug 35684] Koha XSLT material type icons documentation needs updating In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35684 --- Comment #1 from Katrin Fischer --- I had just looked it up, I think Esther is referring to this page: https://koha-community.org/manual/latest/en/html/cataloging.html#material-type-cataloging-guide-label -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 00:29:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 23:29:47 +0000 Subject: [Koha-bugs] [Bug 35539] Remove unused columns from categories table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35539 --- Comment #17 from Martin Renvoize --- Hmm, I'm not seeing the "reset" being called in the db update. As in, ANSIColor resets.. i'd suggest using the `colored()` method alternatively, as it automatically wrapped the strings with a reset at the end working well with `say`. Or you might use AUTORESET instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 00:51:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2024 23:51:01 +0000 Subject: [Koha-bugs] [Bug 9567] Favorite reports per user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9567 --- Comment #7 from Christopher Brannon --- (In reply to Cab Vinton from comment #2) > Here's a temporary workaround -- Use MySQL's comment syntax & a unique > string within the body of the report to identify favorite reports (initials, > passphrase, etc.) > > For example: > > /* JTG */ > > /* JTG FMV */ > > /* rugbytuna */ One major reason this doesn't work well is that it requires either everyone to have editing capabilities to mark a report as their favorite, or some poor editor person has to be the schmuck to do it for them. This work around works for me, but not for everyone else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 01:20:34 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 00:20:34 +0000 Subject: [Koha-bugs] [Bug 9567] Favorite reports per user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9567 --- Comment #8 from Christopher Brannon --- If a table was kept for something like this, it could go much further than just favorite reports. For example, lets call this the 'follow_me' table. Maybe the 'follow_me' table has the following columns: borrowerid | tableid | function | object - The borrowerid would be straight forward: who this is for. - The tableid would reference the table this has the effect on. So, for example, the 'table_reports' - The function in this case would be 'favorites' - The object would be the 'report_id'. The same 'follow_me' table could also be used down the road to record other settings you want to remain consistent wherever you go. So maybe you want some columns on the check-out table to be different than the default. - The borrowerid again indicates who this is for. - The tableid would reference the 'issues-table'. - The function would be maybe 'hide' if you want a particular column always hidden, or 'show' if you always want it to show. - The object would be a reference to the particular column, such as price. I'm not sure how the current columns are identified with the current settings, but you would probably use whatever is used in the settings already for consistency. Maybe a cataloger only wants to see certain shelving locations, instead of seeing everything available. Or maybe the desk and register could be saved in this table as well. I hope that makes sense. I'm just trying to think of a way something of this nature could be more useful and practical down the road for more than one thing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 01:27:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 00:27:16 +0000 Subject: [Koha-bugs] [Bug 34234] Item groups dropdown in detail page modal does not respect display order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34234 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 01:27:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 00:27:18 +0000 Subject: [Koha-bugs] [Bug 34234] Item groups dropdown in detail page modal does not respect display order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34234 --- Comment #9 from Lucas Gass --- Created attachment 160442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160442&action=edit Bug 34234: add a unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 09:39:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 08:39:01 +0000 Subject: [Koha-bugs] [Bug 35573] Koha is no correctly warning of overridden items when placing a hold if AllowHoldPolicyOverride In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35573 pierre.genty at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.genty at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 09:39:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 08:39:12 +0000 Subject: [Koha-bugs] [Bug 25453] Koha::SearchEngine::ES In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25453 --- Comment #7 from Frédéric Demians --- (In reply to Katrin Fischer from comment #6) > What is the state of this? It's a dead-end. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 09:39:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 08:39:22 +0000 Subject: [Koha-bugs] [Bug 25453] Koha::SearchEngine::ES In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25453 Frédéric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |BLOCKED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 10:29:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 09:29:20 +0000 Subject: [Koha-bugs] [Bug 35570] Add a generic master form in ILL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #10 from Pedro Amorim --- (In reply to David Nind from comment #9) > I applied the first three patches (I didn't apply the last two - Prevent use > of ILL module if deprecated FreeForm backend is installed + QA follow-up). > > When I run the database update it says nothing should happen (Step 1, > Atomicupdate patch), but I get: > > updatedatabase > DEV atomic update > /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35570.pl [21:14:02]: > Bug 35570 - Update 'FreeForm' ILL backend to 'Standard' > Bug 35570: Finished database update. > > I'm confused about the sequence to test this.... is it: > - Run through the test plan in the 'Atomicupdate' patch > - Apply the remaining two patches > - Run through the test plan in the 'Prevent use of ILL module if deprecated > FreeForm backend is installed' patch > > Or something else? Hi David, thank you so much for looking and your outstanding testing. The test plan is indeed a bit confusing, apologies. But you're correct in the order it should be tested. > Bug 35570 - Update 'FreeForm' ILL backend to 'Standard' > Bug 35570: Finished database update. The above messages are standard and should always show, even if no 'FreeForm' data was found - i.e. nothing was updated in the database - it at least verified successfully IF something needed to be updated. In the case something is actually updated, you'll see the following messages: - Updated ILL batches from 'FreeFom' to 'Standard" - Updated ILL request attributes from 'FreeForm' to 'Standard" - Updated ILL requests from 'FreeForm' to 'Standard For the atomicupdate test plan, you should also get an extra message related to existing SQL reports that contain the word 'FreeForm'. I hope this helps makes things clearer and, again, thank you very much! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 10:37:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 09:37:20 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160439|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 160443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160443&action=edit Bug 35681: [TEST ONLY]: This is a dummy dbrev to force an update This patch adds an atomic update file and also an equivilent db_rev and increments the Koha.pm version too. Use it to test the output of updatedatebase, run via console or via the browser. Test plan 1) Start KTD without the patches applied. 2) Apply this test patch 3) Run the detabase updates via the console and confirm it looks reasonable and is colored. 4) Reset the database version in ktd `koha-mysql kohadev` `UPDATE systempreferences SET value = '23.1200002';` 5) Run the database updates via the browser; `http://localhost:8081/cgi-bin/koha/installer/install.pl?step=3&op=updatestructure` 6) Confirm the presence of weird looking escape characters on screen. 7) Apply the next patch and run through steps 3 to 5 again, this time confirming the browser output looks good. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 10:37:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 09:37:22 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160440|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 160444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160444&action=edit Bug 35681: Allow for ANSI color in database updates This patch adds support for colored output in database updates. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 10:38:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 09:38:57 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #5 from Martin Renvoize --- Created attachment 160445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160445&action=edit Bug 35681: Add new perl dependancy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 10:39:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 09:39:20 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 10:39:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 09:39:24 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 10:41:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 09:41:06 +0000 Subject: [Koha-bugs] [Bug 35682] Provide ability to specify color in DB upgrades In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35682 --- Comment #4 from Martin Renvoize --- I did my own version of this in bug 35681.. The main differences are: I use HTML::FromANSI::Tiny as I felt it more recently maintained and simpler (Neither module is packaged :( ) and I put the manipulations into the controller as aposed to the low level attempt here.. the reason for that is to prevent munging of the data for command line outputs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 10:48:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 09:48:30 +0000 Subject: [Koha-bugs] [Bug 35682] Provide ability to specify color in DB upgrades In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35682 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35681 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 10:48:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 09:48:30 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35682 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 10:48:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 09:48:40 +0000 Subject: [Koha-bugs] [Bug 35539] Remove unused columns from categories table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35539 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35681 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 10:48:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 09:48:40 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35539 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 11:25:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 10:25:26 +0000 Subject: [Koha-bugs] [Bug 35539] Remove unused columns from categories table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35539 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35681 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 [Bug 35681] Add support for colored messages in the output of updatedatabase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 11:25:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 10:25:26 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35539 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35539 [Bug 35539] Remove unused columns from categories table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 11:25:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 10:25:49 +0000 Subject: [Koha-bugs] [Bug 35539] Remove unused columns from categories table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35539 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160417|0 |1 is obsolete| | --- Comment #18 from Pedro Amorim --- Created attachment 160446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160446&action=edit Bug 35539: Atomicupdate Removal of 'bulk' column Removal of 'finetype' column Removal of 'issuelimit' column Test plan, k-t-d: 1) Add data to the relevant columns, run the following mysql: update categories set bulk = 1; update categories set finetype = 1; update categories set issuelimit = 1; 2) Run updatedatabase, notice it shows a warning and does not update the database 3) Clean up the data, run the folllowing mysql: update categories set bulk = null; update categories set finetype = null; update categories set issuelimit = null; 4) Run updatedatabase again, notice it updates the database as intended Run: t/db_dependent/Circulation/GetHardDueDate.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 11:27:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 10:27:32 +0000 Subject: [Koha-bugs] [Bug 35539] Remove unused columns from categories table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35539 --- Comment #19 from Pedro Amorim --- I've updated the atomicupdate to use updatedatabase report colors work from bug 35681. Colors should now be correctly applied only to the lines they're meant to apply, and be correctly shown in update reports in both CLI and browser UI. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 11:31:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 10:31:48 +0000 Subject: [Koha-bugs] [Bug 35682] Provide ability to specify color in DB upgrades In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35682 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Pedro Amorim --- *** This bug has been marked as a duplicate of bug 35681 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 11:31:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 10:31:48 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim at ptfs-europe.co | |m --- Comment #6 from Pedro Amorim --- *** Bug 35682 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 11:32:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 10:32:45 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160443|0 |1 is obsolete| | --- Comment #7 from Pedro Amorim --- Created attachment 160447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160447&action=edit Bug 35681: [TEST ONLY]: This is a dummy dbrev to force an update This patch adds an atomic update file and also an equivilent db_rev and increments the Koha.pm version too. Use it to test the output of updatedatebase, run via console or via the browser. Test plan 1) Start KTD without the patches applied. 2) Apply this test patch 3) Run the detabase updates via the console and confirm it looks reasonable and is colored. 4) Reset the database version in ktd `koha-mysql kohadev` `UPDATE systempreferences SET value = '23.1200002';` 5) Run the database updates via the browser; `http://localhost:8081/cgi-bin/koha/installer/install.pl?step=3&op=updatestructure` 6) Confirm the presence of weird looking escape characters on screen. 7) Apply the next patch and run through steps 3 to 5 again, this time confirming the browser output looks good. Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 11:32:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 10:32:48 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160444|0 |1 is obsolete| | --- Comment #8 from Pedro Amorim --- Created attachment 160448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160448&action=edit Bug 35681: Allow for ANSI color in database updates This patch adds support for colored output in database updates. Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 11:32:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 10:32:50 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160445|0 |1 is obsolete| | --- Comment #9 from Pedro Amorim --- Created attachment 160449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160449&action=edit Bug 35681: Add new perl dependancy Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 11:34:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 10:34:27 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #10 from Pedro Amorim --- Adding my SO as having tested but leaving as 'Needs Sign-off' for independent party. If testing on k-t-d the new cpanfile dependency can be installed individually: sudo cpanm HTML::FromANSI::Tiny -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 11:40:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 10:40:17 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Ray Delahunty changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 11:48:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 10:48:13 +0000 Subject: [Koha-bugs] [Bug 35392] HTML in translatable string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 --- Comment #21 from Pedro Amorim --- Created attachment 160450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160450&action=edit Bug 35392: (QA follow-up): Fix 'click here' and 'to check its progress' being 2 seperate translatable strings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 11:49:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 10:49:52 +0000 Subject: [Koha-bugs] [Bug 35392] HTML in translatable string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 --- Comment #22 from Pedro Amorim --- Created attachment 160451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160451&action=edit label demo (In reply to Katrin Fischer from comment #20) > This will make it 2 separate strings in the po file. This is often quite > hard to translate, maybe nicer with Weblate that keeps more of the sequence, > but they could end up in 2 different spots of a big file. That's why I was > suggesting to rephrase AND get rid of the click here the same time by making > the link something like "Check progress". Fair point, I've submitted a follow patch please take a look when convenient. Submitting a picture here of how it looks in the UI for both situations (new harvest job and file upload job). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 12:19:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 11:19:04 +0000 Subject: [Koha-bugs] [Bug 35570] Add a generic master form in ILL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #11 from Pedro Amorim --- Created attachment 160452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160452&action=edit Bug 35570: QA follow-up: Update updatedatabase report colors to base on bug 35681 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 12:19:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 11:19:24 +0000 Subject: [Koha-bugs] [Bug 35570] Add a generic master form in ILL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35681 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 [Bug 35681] Add support for colored messages in the output of updatedatabase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 12:19:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 11:19:24 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35570 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 [Bug 35570] Add a generic master form in ILL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 12:25:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 11:25:05 +0000 Subject: [Koha-bugs] [Bug 35307] Expired holds are missing an input, so updating holds causes loss of data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35307 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.06 |23.05.06,22.11.13 released in| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 12:25:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 11:25:42 +0000 Subject: [Koha-bugs] [Bug 35254] Adding files to basket from a staged file uses wrong inputs for order information when not all records are selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35254 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.06 |23.11.00,23.05.06,22.11.13 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 12:27:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 11:27:49 +0000 Subject: [Koha-bugs] [Bug 35461] Renew All 66 SIP server response messages produce HASH content in replies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35461 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160437|0 |1 is obsolete| | Attachment #160438|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 160453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160453&action=edit Bug 35461: Add unit tests Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 12:27:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 11:27:57 +0000 Subject: [Koha-bugs] [Bug 35461] Renew All 66 SIP server response messages produce HASH content in replies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35461 --- Comment #11 from Kyle M Hall --- Created attachment 160454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160454&action=edit Bug 35461: Fix function call parameters causing the HASH to show in the renew all responses "Renew All" -function aka. 65-66-messages work like this: 66-return messages has renewed items in BM-fields and non-renewables go into BN-fields. If all items were renewable, then the reply message looks like: Reply: 13.07.2022 10:06:17:530 OUTESTI1 6610005000020220713 100616AOOUPK|BM564N15977171|BM564N09203960|BM564N23261720|BM564N25161958|BM564N23455012|C4::SIP::SIPServer=HASHC4::SIP::SIPServer=HASHAY6AZCEFE If items include renewables and non-renewables, the response includes the renewed items first, then a HASH mixed into the first BN-field, then rest of the renewed ones like they should show in BN-fields and after that, anohter HASH: 13.07.2022 14:41:32:610 OUTESTI1 6610003000420220713 144130AOOUPK|BM564N23455012|BM564N23261720|BM564N25161958|C4::SIP::SIPServer=HASHBN564N09203960|BN564N04191259|BN564N15977171|BN564N13788332|C4::SIP::SIPServer=HASHAY8AZC7C5 If all loans were unrenewable (this test included just one item), you first get a HASH in a BN-field, and another at the end. 13.07.2022 14:49:00:037 OUTESTI1 6610000000120220713 144858AOOUPK|C4::SIP::SIPServer=HASHBN564N19874533|C4::SIP::SIPServer=HASHAY9AZDD3B Our self checkout/checkin machine can handle/parse these reply messages correctly, but this might not be the case with all self checkout/checkin devices. Test Plan: 1) Unit test patch 2) prove t/db_dependent/SIP/Message.t 3) Note failures 4) Apply this patch 5) prove t/db_dependent/SIP/Message.t 6) Tests pass! Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 12:30:23 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 11:30:23 +0000 Subject: [Koha-bugs] [Bug 35461] Renew All 66 SIP server response messages produce HASH content in replies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35461 --- Comment #12 from Kyle M Hall --- (In reply to David Nind from comment #9) > I hope I haven't confused things.... > Nope, the unit test was missing a comma causing it to fail all the time and in my haste I didn't re-test the "fixed" version against the patch to ensure it passed afterward! It's ready to test again! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 12:50:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 11:50:22 +0000 Subject: [Koha-bugs] [Bug 35648] Allow sorting of patron categories in Overdue notice/status triggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 12:50:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 11:50:24 +0000 Subject: [Koha-bugs] [Bug 35648] Allow sorting of patron categories in Overdue notice/status triggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 --- Comment #1 from Owen Leonard --- Created attachment 160455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160455&action=edit Bug 35648: Allow sorting of patron categories in Overdue notice/status triggers This patch adds a basic DataTables configuration to the table of patron categories on the Overdue notice/status triggers page. The table can be sorted by patron category and can be filtered. To test, apply the patch and go to Tools -> Overdue notice/status triggers. - Confirm that the table of patron categories is sorted by default by patron category - Other columns should not be sortable - You should see a search field above the table which works to filter by patron category. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 12:54:33 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 11:54:33 +0000 Subject: [Koha-bugs] [Bug 35685] New: ILL - OPAC request creation error if submitted empty while ILLModuleDisclaimerByType is in use Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35685 Bug ID: 35685 Summary: ILL - OPAC request creation error if submitted empty while ILLModuleDisclaimerByType is in use Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: pedro.amorim at ptfs-europe.com Reporter: pedro.amorim at ptfs-europe.com CC: pedro.amorim at ptfs-europe.com Depends on: 33716 To reproduce: 1) Install FreeForm and enable ILLModule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Configure ILLModuleDisclaimerByType, visit: /cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=ILLModuleDisclaimerByType Click "edit" and paste the example code into the sys pref value 3) Create a new OPAC ILL request, visit: /cgi-bin/koha/opac-illrequests.pl?method=create&backend=FreeForm 4) Dont put a type or branch, click 'Create', on the next screen click 'Submit' 5) Notice it explodes 6) Apply patch and repeat. It no longer explodes and now shows an error message. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 [Bug 33716] ILL - Allow for a disclaimer stage per request type -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 12:54:33 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 11:54:33 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35685 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35685 [Bug 35685] ILL - OPAC request creation error if submitted empty while ILLModuleDisclaimerByType is in use -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 13:01:51 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 12:01:51 +0000 Subject: [Koha-bugs] [Bug 35685] ILL - OPAC request creation error if submitted empty while ILLModuleDisclaimerByType is in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35685 --- Comment #1 from Pedro Amorim --- Created attachment 160456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160456&action=edit Bug 35685: Fix after creation actions Test plan: 1) Install FreeForm and enable ILLModule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Configure ILLModuleDisclaimerByType, visit: /cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=ILLModuleDisclaimerByType Click "edit" and paste the example code into the sys pref value 3) Create a new OPAC ILL request, visit: /cgi-bin/koha/opac-illrequests.pl?method=create&backend=FreeForm 4) Dont put a type or branch, click 'Create', on the next screen click 'Submit' 5) Notice it explodes 6) Apply patch and repeat. It no longer explodes and now shows an error message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 13:01:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 12:01:59 +0000 Subject: [Koha-bugs] [Bug 35685] ILL - OPAC request creation error if submitted empty while ILLModuleDisclaimerByType is in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35685 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 13:02:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 12:02:12 +0000 Subject: [Koha-bugs] [Bug 35569] Remember user-selected columns in records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35569 --- Comment #2 from Piia Semenoff --- I meant this page: cgi-bin/koha/catalogue/detail.pl?biblionumber= and there the columns of the holdings table. When you make a search and you go through records of the results, it's easier if the columns of the holdings table stay as selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 13:02:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 12:02:35 +0000 Subject: [Koha-bugs] [Bug 35685] ILL - OPAC request creation error if submitted empty while ILLModuleDisclaimerByType is in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35685 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |magnus at libriotech.no, | |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 13:07:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 12:07:50 +0000 Subject: [Koha-bugs] [Bug 35570] Add a generic master form in ILL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #12 from Pedro Amorim --- Created attachment 160457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160457&action=edit Bug 35570: (QA follow-up): Add FreeForm fix from https://github.com/PTFS-Europe/koha-ill-freeform/commit/9c9da5ff2815fb6ce0af0181341dea5ce8c3bb2e into this work. This is to keep this work up to date with latest FreeForm's fixes. See bug 35685 for context and test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 13:29:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 12:29:20 +0000 Subject: [Koha-bugs] [Bug 33171] Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159429|0 |1 is obsolete| | Attachment #159430|0 |1 is obsolete| | --- Comment #13 from Nick Clemens --- Created attachment 160458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160458&action=edit Bug 33171: Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder Some libraries would like to use the following item fields with the MarcItemFieldsToOrder system preference: * coded_location_qualifier * barcode * enumchron Test Plan: 1) Set up MarcItemFieldsToOrder, verify it is functioning 2) Test coded_location_qualifier, barcode, and enumchron 3) Note the fields are imported and set for the items Signed-off-by: Matt Blenkinsop Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 13:29:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 12:29:22 +0000 Subject: [Koha-bugs] [Bug 33171] Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 --- Comment #14 from Nick Clemens --- Created attachment 160459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160459&action=edit Bug 33171: Fix missing price when mapped from MarcItemFieldsToOrder This patch fixes an issue where the price is not passed to the UI when read from MarcItemFieldsToOrder. Test plan: 1) In Administration, copy and paste the following into MarcItemFieldsToOrder: quantity: 975$q budget_code: 975$h price: 975$p itype: 975$y coded_location_qualifier: 975$a barcode: 975$b enumchron: 975$c 2) Save 3) Navigate to Acquisitions and find a basket 4) Click Add to basket and select From a new file 5) Choose the file attached to this bug 6) Upload file and click Stage for import 7) Click Add staged files to basket once the job is finished 8) Check the box next to the record 9) The price should show 10.00 under Item record 1 10) coded location qualifier, barcode, enumchron should also have values as per the other commit on this bug 11) Save and import, the basket should not have a value of 0 as the price has been read correctly 12) Check the database, the newest item should have values for price, coded_location_qualifier, barcode and enumchron Signed-off-by: Matt Blenkinsop Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 13:41:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 12:41:46 +0000 Subject: [Koha-bugs] [Bug 35487] Add a selective dissemination of information module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35487 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 14:07:34 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 13:07:34 +0000 Subject: [Koha-bugs] [Bug 35686] New: Case missing from installer step 3 template title Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 Bug ID: 35686 Summary: Case missing from installer step 3 template title Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/installer/install.pl?step=3&op=updatestr ucture OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com There is a case missing from the conditionals around title display for the installer's step 3. When you're on the "Updating database structure" step the first part of the page title is empty: " > Web installer > Koha" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 14:14:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 13:14:24 +0000 Subject: [Koha-bugs] [Bug 35310] Current renewals 'view' link doesnt work if renewals correspond to an item no longer checked out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35310 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.02 released in| | --- Comment #40 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 14:14:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 13:14:26 +0000 Subject: [Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #15 from Nick Clemens --- Using the settings and test file from bug 34645 I expect to get 8 items - I only get 2. I suspect there is a problem in _get_MarcItemFieldsToOrder_syspref_data as it builds an array, but only returns a single: return $result[0]; Two routines that are used have not been imported: + GetImportBatchRangeDesc + GetNumberOfNonZ3950ImportBatches Why not use C4::Context->yaml_preference in the _get_MarcItem... subroutines? Can you provide a test plan with sample data (feel free to steal from 34645) we should test with a file with multiple records and multiple orders per record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 14:16:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 13:16:09 +0000 Subject: [Koha-bugs] [Bug 35498] SQL auto-complete should not prevent use of tab for spacing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #13 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 14:16:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 13:16:57 +0000 Subject: [Koha-bugs] [Bug 35428] gulp po tasks do not clean temporary files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35428 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 14:40:10 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 13:40:10 +0000 Subject: [Koha-bugs] [Bug 35556] selenium/administration_tasks.t failing if too many patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35556 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.02 released in| | --- Comment #3 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 14:44:56 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 13:44:56 +0000 Subject: [Koha-bugs] [Bug 35487] Add a selective dissemination of information module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35487 --- Comment #3 from Tomás Cohen Arazi --- Saved search terms or expressions feel unreliable in terms of validating what's going to be sent. In my opinion, this should be implemented on top of lists. That said, I suggest: - Add a notice template. - Add a 'tool' for managing the list-notice mapping and some configuration (e.g. allowing a reviewer to approve, date for sending, etc). - A nightly cronjob should be set to send approved notices with some frequency. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 14:46:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 13:46:42 +0000 Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 --- Comment #53 from Jonathan Druart --- (In reply to Mohd Hafiz Yusoff from comment #52) > Upgrade from Koha 23.05 to 23.11 and get this error > > Upgrade to 23.06.00.013 [01:38:28]: Bug 28966 - Holds queue view too slow > to load for large numbers of holds > ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot change > column 'itemnumber': used in a foreign key constraint > 'tmp_holdsqueue_ibfk_1' at /usr/share/koha/lib/C4/Installer.pm line 741 Also reported on the French mailing list: https://groupes.renater.fr/sympa/arc/koha.infos/2024-01/msg00000.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 14:53:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 13:53:47 +0000 Subject: [Koha-bugs] [Bug 35634] Permissions mismatch for vendor issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35634 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 14:53:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 13:53:49 +0000 Subject: [Koha-bugs] [Bug 35634] Permissions mismatch for vendor issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35634 --- Comment #1 from Jonathan Druart --- Created attachment 160460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160460&action=edit Bug 35634: (bug 33105 follow-up) fix typo issues_manage vs issue_manage issue_manage inserted into the DB but issues_manage is tested in the controller script. Test plan: git grep issues_manage should no longer return any results -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 14:54:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 13:54:21 +0000 Subject: [Koha-bugs] [Bug 35634] Permissions mismatch for vendor issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35634 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 14:57:51 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 13:57:51 +0000 Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 --- Comment #54 from Kyle M Hall --- (In reply to Jonathan Druart from comment #53) > (In reply to Mohd Hafiz Yusoff from comment #52) > > Upgrade from Koha 23.05 to 23.11 and get this error > > > > Upgrade to 23.06.00.013 [01:38:28]: Bug 28966 - Holds queue view too slow > > to load for large numbers of holds > > ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot change > > column 'itemnumber': used in a foreign key constraint > > 'tmp_holdsqueue_ibfk_1' at /usr/share/koha/lib/C4/Installer.pm line 741 > > Also reported on the French mailing list: > https://groupes.renater.fr/sympa/arc/koha.infos/2024-01/msg00000.html I wonder if this is mysql or mariadb version specific. Not getting that error on 10.5.22-MariaDB -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:05:44 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:05:44 +0000 Subject: [Koha-bugs] [Bug 35687] New: Upgrade to 23.06.00.013 may fail Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687 Bug ID: 35687 Summary: Upgrade to 23.06.00.013 may fail Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org There are reports that this update triggers the error Cannot change column 'itemnumber': used in a foreign key constraint 'tmp_holdsqueue_ibfk_1' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:05:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:05:48 +0000 Subject: [Koha-bugs] [Bug 35468] Bookings permission mismatch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35468 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #26 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:05:51 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:05:51 +0000 Subject: [Koha-bugs] [Bug 35687] Upgrade to 23.06.00.013 may fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28966 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 [Bug 28966] Holds queue viewer too slow to load for large numbers of holds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:05:51 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:05:51 +0000 Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35687 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687 [Bug 35687] Upgrade to 23.06.00.013 may fail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:06:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:06:08 +0000 Subject: [Koha-bugs] [Bug 35687] Upgrade to 23.06.00.013 may fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28966 | Depends on| |28966 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 [Bug 28966] Holds queue viewer too slow to load for large numbers of holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:06:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:06:08 +0000 Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35687 Depends on|35687 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687 [Bug 35687] Upgrade to 23.06.00.013 may fail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:06:56 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:06:56 +0000 Subject: [Koha-bugs] [Bug 35488] Placing a hold on the OPAC takes the user to their account page, but does not activate the holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35488 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.02 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:07:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:07:41 +0000 Subject: [Koha-bugs] [Bug 25328] Date formatting from JS - Remove tz handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25328 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #2 from Martin Renvoize --- Pretty sure the API consistently returnd RFC dates now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:09:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:09:00 +0000 Subject: [Koha-bugs] [Bug 35687] Upgrade to 23.06.00.013 may fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:09:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:09:02 +0000 Subject: [Koha-bugs] [Bug 35687] Upgrade to 23.06.00.013 may fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687 --- Comment #1 from Kyle M Hall --- Created attachment 160461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160461&action=edit Bug 35687 - Upgrade to 23.06.00.013 may fail There are reports that this update triggers the error Cannot change column 'itemnumber': used in a foreign key constraint 'tmp_holdsqueue_ibfk_1' Test Plan: 1) Upgrade to post 23.06.00.013 2) Note the failure 3) Apply this patch set 4) Run updatedatabase.pl 5) Update should succeed! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:09:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:09:12 +0000 Subject: [Koha-bugs] [Bug 35687] Upgrade to 23.06.00.013 may fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:09:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:09:19 +0000 Subject: [Koha-bugs] [Bug 35687] Upgrade to 23.06.00.013 may fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |blocker -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:09:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:09:38 +0000 Subject: [Koha-bugs] [Bug 35492] Suspending/unsuspending a hold on the OPAC takes the user to their account page, but does not activate the holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35492 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.02 released in| | --- Comment #6 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:09:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:09:53 +0000 Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 --- Comment #55 from Kyle M Hall --- (In reply to Kyle M Hall from comment #54) > (In reply to Jonathan Druart from comment #53) > > (In reply to Mohd Hafiz Yusoff from comment #52) > > > Upgrade from Koha 23.05 to 23.11 and get this error > > > > > > Upgrade to 23.06.00.013 [01:38:28]: Bug 28966 - Holds queue view too slow > > > to load for large numbers of holds > > > ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot change > > > column 'itemnumber': used in a foreign key constraint > > > 'tmp_holdsqueue_ibfk_1' at /usr/share/koha/lib/C4/Installer.pm line 741 > > > > Also reported on the French mailing list: > > https://groupes.renater.fr/sympa/arc/koha.infos/2024-01/msg00000.html > > I wonder if this is mysql or mariadb version specific. Not getting that > error on 10.5.22-MariaDB Filed a new bug report at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:10:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:10:00 +0000 Subject: [Koha-bugs] [Bug 35495] Cancelling a hold on the OPAC takes the user to their account page, but does not activate the holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35495 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.02 released in| | --- Comment #6 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:11:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:11:04 +0000 Subject: [Koha-bugs] [Bug 35496] Placing an article request on the OPAC takes the user to their account page, but does not activate the article request tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35496 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.02 released in| | --- Comment #7 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:12:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:12:24 +0000 Subject: [Koha-bugs] [Bug 21482] Create a "landing page" for ILL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21482 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:15:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:15:36 +0000 Subject: [Koha-bugs] [Bug 35507] Fix handling plugins in unit tests causing random failures on Jenkins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.02 released in| | --- Comment #68 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:18:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:18:09 +0000 Subject: [Koha-bugs] [Bug 18139] 'Too many checked out' can confuse librarians In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #34 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:19:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:19:48 +0000 Subject: [Koha-bugs] [Bug 35476] Submit button for adding new processings is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35476 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:21:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:21:41 +0000 Subject: [Koha-bugs] [Bug 35523] Fix doubled up quotes in cash register deletion confirmation message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35523 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:22:34 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:22:34 +0000 Subject: [Koha-bugs] [Bug 35524] Terminology: Bookseller in basket group CSV export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35524 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.02 released in| | --- Comment #6 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:22:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:22:53 +0000 Subject: [Koha-bugs] [Bug 35524] Terminology: Bookseller in basket group CSV export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35524 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:23:44 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:23:44 +0000 Subject: [Koha-bugs] [Bug 35525] Spelling: SMS is an abbreviation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35525 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.02 released in| | --- Comment #6 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:24:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:24:47 +0000 Subject: [Koha-bugs] [Bug 35526] Terminology: Id, sushi and counter are abbreviations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35526 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #5 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:25:28 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:25:28 +0000 Subject: [Koha-bugs] [Bug 35528] Avoid 'click' for links in system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35528 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.02 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:27:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:27:07 +0000 Subject: [Koha-bugs] [Bug 35687] Upgrade to 23.06.00.013 may fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:27:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:27:55 +0000 Subject: [Koha-bugs] [Bug 35687] Upgrade to 23.06.00.013 may fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart --- Shouldn't this be done before the problematic DB rev? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:28:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:28:54 +0000 Subject: [Koha-bugs] [Bug 35687] Upgrade to 23.06.00.013 may fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687 --- Comment #3 from Kyle M Hall --- (In reply to Jonathan Druart from comment #2) > Shouldn't this be done before the problematic DB rev? If someone has already upgraded past that db rev this one will fix it. It's a good idea to fix the existing rev as well though. I'll post a followup. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:32:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:32:18 +0000 Subject: [Koha-bugs] [Bug 35687] Upgrade to 23.06.00.013 may fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687 --- Comment #4 from Kyle M Hall --- Created attachment 160462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160462&action=edit Bug 35687: Fix db rev for 23.06.00.013 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:34:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:34:49 +0000 Subject: [Koha-bugs] [Bug 35504] Release team 24.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:34:51 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:34:51 +0000 Subject: [Koha-bugs] [Bug 35504] Release team 24.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159915|0 |1 is obsolete| | --- Comment #18 from Lucas Gass --- Created attachment 160463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160463&action=edit Bug 35504: New cycle, new team :) Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:34:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:34:53 +0000 Subject: [Koha-bugs] [Bug 35504] Release team 24.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159916|0 |1 is obsolete| | --- Comment #19 from Lucas Gass --- Created attachment 160464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160464&action=edit Bug 35504: Typo fix Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:34:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:34:55 +0000 Subject: [Koha-bugs] [Bug 35504] Release team 24.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159917|0 |1 is obsolete| | --- Comment #20 from Lucas Gass --- Created attachment 160465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160465&action=edit Bug 35504: Corrections to team Correction of 'advocate' to 'advocates' to ensure they appear in the team. Addition of 'website' and 'wiki' handling to ensure they also appear in the team. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:34:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:34:57 +0000 Subject: [Koha-bugs] [Bug 35504] Release team 24.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159918|0 |1 is obsolete| | --- Comment #21 from Lucas Gass --- Created attachment 160466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160466&action=edit Bug 35504: Add ktd maintainer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:38:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:38:30 +0000 Subject: [Koha-bugs] [Bug 35686] Case missing from installer step 3 template title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:38:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:38:32 +0000 Subject: [Koha-bugs] [Bug 35686] Case missing from installer step 3 template title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 --- Comment #1 from Owen Leonard --- Created attachment 160467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160467&action=edit Bug 35686: Case missing from installer step 3 template title This patch adds a missing case to the display of the title on step 3 of the web installer. This resulted in an empty first part of the title: " > Web installer > Koha" To test, apply the patch and reset the database version from the command line in Koha Testing Docker: > koha-mysql kohadev > UPDATE systempreferences SET value = '23.1200002 WHERE variable = 'version'; > quit > Restart all - Go to the staff interface. You should be taken to the web installer. - Log in to the web installer and proceed through until you get to the "Updating database structure" page. - Confirm that the page title is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:45:43 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:45:43 +0000 Subject: [Koha-bugs] [Bug 35413] Terminology: differentiate issues for vendor issues and serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35413 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #9 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:46:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:46:46 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #11 from Owen Leonard --- It looks like the HTML is generated by HTML::FromANSI::Tiny? Something in red is a warning It would be preferable to have it use a class instead of a style attribute so that we can customize the colors. The default red, yellow, and white options do not have adequate contrast on a white background. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:47:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:47:00 +0000 Subject: [Koha-bugs] [Bug 25691] Debian packages point to /usr/share/doc/koha/README.Debian which does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25691 --- Comment #2 from Jonathan Druart --- (In reply to Katrin Fischer from comment #1) > Should we replace this with a link to the instructions on the wiki? Yes, I think so. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:48:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:48:59 +0000 Subject: [Koha-bugs] [Bug 35574] Bookings page should require only manage_bookings permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #23 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:49:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:49:57 +0000 Subject: [Koha-bugs] [Bug 35489] Holds on items with no barcode are missing an input for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.02 released in| | --- Comment #7 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:50:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:50:14 +0000 Subject: [Koha-bugs] [Bug 33217] Allow different default sorting when click author links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33217 Rasa Satinskiene changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rasa.satinskiene at ptfs-europ | |e.com Documentation| |Rasa Satinskiene contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:51:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:51:20 +0000 Subject: [Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844 --- Comment #49 from Jonathan Druart --- (In reply to Katrin Fischer from comment #48) > Maybe we could extend the relationship later. At the moment we create an > order from a suggestion, so a 1:1 makes sense. > > When I tested this my main concern was to ensure that the suggestions > existing previously to this fix would still work, patrons receiving emails > etc. Did you take a look at that aspect? Yes, but didn't fix it. Seen comment 35? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:51:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:51:48 +0000 Subject: [Koha-bugs] [Bug 35204] REST API: POST endpoint /auth/password/validation dies on patron with expired password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35204 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.02 released in| | --- Comment #15 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:51:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:51:53 +0000 Subject: [Koha-bugs] [Bug 25446] Terminology: Replace relatives by other term? (family members, group members...) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25446 --- Comment #1 from Caroline Cyr La Rose --- Linked accounts maybe? If we want to change relatives, I would avoid anything family related. Although there is no way that I know of to link accounts without the guarantor/guarantee relationship. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:53:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:53:27 +0000 Subject: [Koha-bugs] [Bug 35405] MarcAuthorities: Use of uninitialized value $tag in hash element at MARC/Record.pm line 202. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35405 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:53:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:53:50 +0000 Subject: [Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35405 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35405 [Bug 35405] MarcAuthorities: Use of uninitialized value $tag in hash element at MARC/Record.pm line 202. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:53:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:53:50 +0000 Subject: [Koha-bugs] [Bug 35405] MarcAuthorities: Use of uninitialized value $tag in hash element at MARC/Record.pm line 202. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35405 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:54:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:54:20 +0000 Subject: [Koha-bugs] [Bug 33036] REST API: Merge biblio records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:54:23 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:54:23 +0000 Subject: [Koha-bugs] [Bug 33036] REST API: Merge biblio records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159191|0 |1 is obsolete| | Attachment #159826|0 |1 is obsolete| | Attachment #159827|0 |1 is obsolete| | Attachment #159828|0 |1 is obsolete| | Attachment #159829|0 |1 is obsolete| | Attachment #160302|0 |1 is obsolete| | --- Comment #45 from Jonathan Druart --- Created attachment 160468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160468&action=edit Bug 33036: REST API: Merge biblio records implements merging of records + attached items, subscriptions etc via the API as an alternative to the web interface: cgi-bin/koha/cataloguing/merge.pl This is a slightly improved version of Zenos patch: I (domm) have converted the code in Koha::Biblio to a more DBICy style and packed it into a transaction (as requested in Comment 23) Even the QA script is happy now! To test: 1) you need an API user with the permissions "editcatalogue" 2) two records: one to be merged into (with biblio_id, eg 262) and another one from which to merge (with biblio_id_to_merge, eg 9) which will be deleted! both records may/should have items, subscription, subscriptionhistory, serial, suggestions orders and holds 3) check both records via the web 4) Apply patch 5) Write a JSON file with inside the field 'biblio_id_to_merge' and the biblionumber from wihich to merge. As example: { "biblio_id_to_merge" : 9 } 6) Execute an API call with correct headers and location. For example: curl -s -u koha:koha --header "Content-Type: application/json" --header "Accept: application/marc-in-json" --request POST "http://127.0.0.1:8080/api/v1/biblios/262/merge" -d @file.json You must to setup the headers and to use a json file with parameters 7) The record with the id 9 is deleted now, the record with 262 has all items, etc attached, the return is: return code 200 and the changed record 262 in marc-in-json format 8) It is possible to override biblio data with an external bib record. You need to put external bib record into the json file in marc-in-json format. To write use the json file uploaded as example You need to fill the fields 'rules' and 'datarecord'. The field 'rules' must contains 'override_ext' To do the call: curl -s -u koha:koha --header "Content-Type: application/json" --header "Accept: application/marc-in-json" --request POST "http://127.0.0.1:8080/api/v1/biblios/XXX/merge" -d @file_with_recod.json 9) The record in 'biblio_id_to_merge' is deleted now, in biblio XXX now there are the bibliographic data of field 'datarecord' of json file, the return is: return code 200 and the changed record XXX in marc-in-json format 10) Go into intranet and do a search. Select two or (better) more record. 11) Merge them; merge must be a success. 12) Test with prove -v t/db_dependent/Koha/Biblio.t 13) Test with prove -v t/db_dependent/api/v1/biblios.t To test with curl the step 8 you can customize the json file attached in bugzilla. The marc-in-json record inside follows the MAR21 standard Sponsored-by: Technische Hochschule Wildau Co-authored-by: Zeno Tajoli Co-authored-by: Thomas Klausner Co-authored-by: Mark Hofstetter <> Signed-off-by: Jan Kissig Bug 33036: Update of test number. File ../biblios.t was update with a new subutest. So we need this update to have a 'OK' after test running. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:54:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:54:26 +0000 Subject: [Koha-bugs] [Bug 33036] REST API: Merge biblio records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036 --- Comment #46 from Jonathan Druart --- Created attachment 160469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160469&action=edit Bug 33036: Improve merge_with tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:54:29 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:54:29 +0000 Subject: [Koha-bugs] [Bug 33036] REST API: Merge biblio records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036 --- Comment #47 from Jonathan Druart --- Created attachment 160470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160470&action=edit Bug 33036: Add more tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:54:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:54:32 +0000 Subject: [Koha-bugs] [Bug 33036] REST API: Merge biblio records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036 --- Comment #48 from Jonathan Druart --- Created attachment 160471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160471&action=edit Bug 33036: Use Koha::Objects Better to use Koha::Objects everywhere and have the same pattern for the different related objects. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:54:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:54:35 +0000 Subject: [Koha-bugs] [Bug 33036] REST API: Merge biblio records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036 --- Comment #49 from Jonathan Druart --- Created attachment 160472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160472&action=edit Bug 33036: Improve REST API controller Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:55:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:55:15 +0000 Subject: [Koha-bugs] [Bug 35216] Use return variable names from CanBookBeIssued in circulation.pl for consistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35216 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.02 released in| | --- Comment #29 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:57:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:57:17 +0000 Subject: [Koha-bugs] [Bug 35309] Remove DT's fnSetFilteringDelay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35309 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.02 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:58:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 14:58:24 +0000 Subject: [Koha-bugs] [Bug 35688] New: RFID Envisionware Software Requires Static Page Title Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35688 Bug ID: 35688 Summary: RFID Envisionware Software Requires Static Page Title Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: eliana at flo.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When attempting to perform batch check-ins in Koha's circulation module, Envisionware's Staff Link software is automatically paused when it detects a change in page title. After submitting a check-in the page title changes to reflect the title of the item you're checking in. For example: Expected window: Check in › Circulation › Koha Actual window: Check in The killer department : › Circulation › Koha If the page title were to stay "Check in > Circulation > Koha" the Staff Link software would successfully check in multiple items (according to Envisionware). We've been able to successfully perform batch check outs because the page title stays static. Possibly related to bug #31512, but that bug didn't mention page titles, so I'm bringing it to the community's attention here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 16:05:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 15:05:07 +0000 Subject: [Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.02 released in| | --- Comment #54 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 16:08:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 15:08:15 +0000 Subject: [Koha-bugs] [Bug 33847] Database update replaces undefined rules with defaults rather than the value that would be used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #26 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 16:09:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 15:09:11 +0000 Subject: [Koha-bugs] [Bug 35491] Reverting waiting status for holds is not logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35491 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.02 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 16:18:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 15:18:09 +0000 Subject: [Koha-bugs] [Bug 35487] Add a selective dissemination of information module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35487 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Seeking sponsor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 16:22:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 15:22:21 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #12 from Pedro Amorim --- Created attachment 160473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160473&action=edit Bug 35681: Use CSS class instead of inline style -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 16:25:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 15:25:30 +0000 Subject: [Koha-bugs] [Bug 35592] Missing closing div tag in bookings alert in circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35592 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | Patch complexity|--- |Trivial patch CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #7 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 16:27:51 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 15:27:51 +0000 Subject: [Koha-bugs] [Bug 35600] Prevent checkouts table to flicker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35600 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.02 released in| | --- Comment #10 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 16:28:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 15:28:35 +0000 Subject: [Koha-bugs] [Bug 35417] Update breadcrumbs and page titles for vendor issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35417 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 16:29:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 15:29:53 +0000 Subject: [Koha-bugs] [Bug 34644] Add clarifying text to sysprefs to indicate that MarcFieldsToOrder is a fallback to MarcItemFieldsToOrder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34644 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.02 released in| | --- Comment #18 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 16:31:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 15:31:14 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #33 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 16:32:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 15:32:50 +0000 Subject: [Koha-bugs] [Bug 35493] Housebound roles show as a collapsed field option when checked in CollapseFieldsPatronAddForm, even if housebound is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35493 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.02 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 16:33:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 15:33:39 +0000 Subject: [Koha-bugs] [Bug 35455] ICU does not strip = when indexing/searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35455 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.02 released in| | --- Comment #9 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 16:34:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 15:34:30 +0000 Subject: [Koha-bugs] [Bug 35529] Avoid 'click' for links in library administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35529 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.02 released in| | --- Comment #5 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 16:36:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 15:36:21 +0000 Subject: [Koha-bugs] [Bug 35619] Change password form in patron account has misaligned validation errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35619 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 16:37:10 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 15:37:10 +0000 Subject: [Koha-bugs] [Bug 35547] When using "Add to a list" button with more than 10 lists, "staff only" does not show up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35547 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | Patch complexity|--- |Trivial patch CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #7 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 16:39:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 15:39:41 +0000 Subject: [Koha-bugs] [Bug 35557] LoadResultsCovers is not used (staff) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35557 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 16:46:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 15:46:01 +0000 Subject: [Koha-bugs] [Bug 31297] Cannot add new subscription patterns from edit subscription page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31297 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.02 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #12 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 16:51:43 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 15:51:43 +0000 Subject: [Koha-bugs] [Bug 35658] Typo in /patrons/:patron_id/holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35658 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Severity|normal |major --- Comment #2 from Jonathan Druart --- Upping severity, I lost hours on this... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:00:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:00:45 +0000 Subject: [Koha-bugs] [Bug 14156] Add id tags to each MARC note in the display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14156 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35689 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35689 [Bug 35689] Add id and classes to each MARC note in OPAC bibliographic details -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:00:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:00:45 +0000 Subject: [Koha-bugs] [Bug 35689] New: Add id and classes to each MARC note in OPAC bibliographic details Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35689 Bug ID: 35689 Summary: Add id and classes to each MARC note in OPAC bibliographic details Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 14156 Same as Bug 14156 but in the OPAC. Add an id and class attributes to each note in the title notes tab. Replacing this HTML:

    Antonio Chavarrias

    Tristan Ulloa, Unax Ugalde

    The great virtue in this film is the persistent sense that something pretty bad is on it's way.

    With this:

    Antonio Chavarrias

    Tristan Ulloa, Unax Ugalde

    The great virtue in this film is the persistent sense that something pretty bad is on it's way.

    Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14156 [Bug 14156] Add id tags to each MARC note in the display -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:02:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:02:26 +0000 Subject: [Koha-bugs] [Bug 28012] Error on saving new numbering pattern In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28012 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:02:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:02:59 +0000 Subject: [Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #45 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:04:33 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:04:33 +0000 Subject: [Koha-bugs] [Bug 35579] marcrecord2csv searches authorised values inefficiently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35579 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.02 released in| | --- Comment #18 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:07:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:07:05 +0000 Subject: [Koha-bugs] [Bug 35689] Add id and classes to each MARC note in OPAC bibliographic details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35689 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:07:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:07:06 +0000 Subject: [Koha-bugs] [Bug 35689] Add id and classes to each MARC note in OPAC bibliographic details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35689 --- Comment #1 from Owen Leonard --- Created attachment 160474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160474&action=edit Bug 35689: Add id and classes to each MARC note in OPAC bibliographic details Building on Bug 14156, this patch updates the OPAC bibliographic detail page's display of MARC notes to add the tag number in both a class (for consistent styling across the same tag number) and id (for unique styling for each repeated tag). To test: - As a quick test for custom CSS, go to Administration -> System preferences and locate the OPACUserCSS preference. - Add this testing CSS: .marcnote { font-size:140%; font-family: serif; } .marcnote-500 { background-color: #66FFCC; } .marcnote-511 { background-color: #99FFFF; } .marcnote-520 { background-color: #CCFF00; } .marcnote-521 { background-color: #CCFFFF; } .marcnote-538 { background-color: #FFCCCC; } .marcnote-546 { background-color: #FFFFCC; } - Locate a record with multiple notes fields. In the sample data, record 46, "Viridiana" is a good example which works well with the above CSS. - On the bibliographic detail page for the record, click the "Descriptions" tab. - Each MARC note should be colored according to the tag it comes from. - Inspect the HTML to confirm that each paragraph also has its own unique ID. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:11:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:11:39 +0000 Subject: [Koha-bugs] [Bug 35689] Add id and classes to each MARC note in OPAC bibliographic details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35689 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:11:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:11:41 +0000 Subject: [Koha-bugs] [Bug 35689] Add id and classes to each MARC note in OPAC bibliographic details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35689 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160474|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 160475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160475&action=edit Bug 35689: Add id and classes to each MARC note in OPAC bibliographic details Building on Bug 14156, this patch updates the OPAC bibliographic detail page's display of MARC notes to add the tag number in both a class (for consistent styling across the same tag number) and id (for unique styling for each repeated tag). To test: - As a quick test for custom CSS, go to Administration -> System preferences and locate the OPACUserCSS preference. - Add this testing CSS: .marcnote { font-size:140%; font-family: serif; } .marcnote-500 { background-color: #66FFCC; } .marcnote-511 { background-color: #99FFFF; } .marcnote-520 { background-color: #CCFF00; } .marcnote-521 { background-color: #CCFFFF; } .marcnote-538 { background-color: #FFCCCC; } .marcnote-546 { background-color: #FFFFCC; } - Locate a record with multiple notes fields. In the sample data, record 46, "Viridiana" is a good example which works well with the above CSS. - On the bibliographic detail page for the record, click the "Descriptions" tab. - Each MARC note should be colored according to the tag it comes from. - Inspect the HTML to confirm that each paragraph also has its own unique ID. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:13:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:13:36 +0000 Subject: [Koha-bugs] [Bug 35634] Permissions mismatch for vendor issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35634 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:13:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:13:38 +0000 Subject: [Koha-bugs] [Bug 35634] Permissions mismatch for vendor issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35634 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160460|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 160476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160476&action=edit Bug 35634: (bug 33105 follow-up) fix typo issues_manage vs issue_manage issue_manage inserted into the DB but issues_manage is tested in the controller script. Test plan: git grep issues_manage should no longer return any results Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:15:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:15:40 +0000 Subject: [Koha-bugs] [Bug 34062] Additional contents with library set do not appear in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34062 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Lucas Gass --- FQA until we get some feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:22:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:22:01 +0000 Subject: [Koha-bugs] [Bug 35648] Allow sorting of patron categories in Overdue notice/status triggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |lucas at bywatersolutions.com --- Comment #2 from Lucas Gass --- Owen, This is nice but the dataTable only applies to the first table. The 2nd and 3rd table do not become dataTables. We actually have invalid HTML on this page because the table ID is reused ( #overduerulest ) Should a separate bug be filed for that? Or can we deal with it here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:24:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:24:08 +0000 Subject: [Koha-bugs] [Bug 35588] marcrecord2csv retrieves authorised values incorrectly for fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35588 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:25:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:25:03 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160148|0 |1 is obsolete| | --- Comment #88 from Martin Renvoize --- Created attachment 160477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160477&action=edit Bug 29440: Refactor and clean up bulkmarcimport.pl To test: 1) Import biblios using ./bulkmarcimport.pl -v -b -file biblios.mrc -insert -update -c=MARC21 -match "control-number,001" -n=1 -l "/tmp/import.log" 2) Verify in /tmp/import.log that one biblio has been inserted 3) Import again without the "-n" option, verify that one biblio has been updated and the rest inserted 4) In the staff interface search the catalog for some string appearing in the imported biblios to verify records have been indexed 5) View/edit some of the biblios the staff interface to very have been properly imported 6) Import authorities using ./bulkmarcimport.pl -v -m=MARCXML -a -file authorities.xml -insert -update -c=MARC21 -keepids="024a" -match "heading-main,100a" -l "/tmp/import.log" -yaml="/tmp/ids.yml" 7) Go to the authorities page and find the imported authority by for example search for a 400 or 100 field value. Verify that the 001 field of the incoming record has been moved to 024a. Also check that the value of 024a appear as a key in /tmp/ids.yml. 8) Edit the authorities.xml file and change the value of field 400a 9) Import authorities again using the same options 10) Verify that the 400a field of the authority in Koha has not been updated (the import was skippped since revision did not change) 11) Edit authorities.xml, replace the value of field 005 in the file with field 005 of the authority in Koha incremented by one 12) Import again with the same options 13) Verify that the 400a field of the authority in Koha now have been updated Signed-off-by: Michał Kula <148193449+mkibp at users.noreply.github.com> Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:25:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:25:06 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160149|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize --- Created attachment 160478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160478&action=edit Bug 29440: Make authorities import behavior consistent with biblios The current behavior for when importing authorities, when match option is enabled, is to insert as a new authority fetching from db fails. This is both a bit confusing and not consistent with the biblio case where an error is generated. Also clean up error and log messages so both messages/errors and when messages/errors are issued are more consistent for the biblio and authority case. Signed-off-by: Frank Hansen Signed-off-by: Michał Kula <148193449+mkibp at users.noreply.github.com> Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:25:10 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:25:10 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160150|0 |1 is obsolete| | --- Comment #90 from Martin Renvoize --- Created attachment 160479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160479&action=edit Bug 29440: Fix QA-tool issues Signed-off-by: Michał Kula <148193449+mkibp at users.noreply.github.com> Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:25:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:25:13 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160151|0 |1 is obsolete| | --- Comment #91 from Martin Renvoize --- Created attachment 160480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160480&action=edit Bug 29440: defer biblio autolinking until records are indexed Signed-off-by: Michał Kula <148193449+mkibp at users.noreply.github.com> Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:25:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:25:16 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160152|0 |1 is obsolete| | --- Comment #92 from Martin Renvoize --- Created attachment 160481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160481&action=edit Bug 29440: replace usage of removed GetMarcBiblio Signed-off-by: Michał Kula <148193449+mkibp at users.noreply.github.com> Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:25:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:25:20 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160153|0 |1 is obsolete| | --- Comment #93 from Martin Renvoize --- Created attachment 160482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160482&action=edit Bug 29440: Remove pointless call to _strip_item_fields Signed-off-by: Michał Kula <148193449+mkibp at users.noreply.github.com> Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:25:23 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:25:23 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160154|0 |1 is obsolete| | --- Comment #94 from Martin Renvoize --- Created attachment 160483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160483&action=edit Bug 29440: Rename $modify_biblio_marc_options to $mod_bilbio_options This variable actually contains ModBibio options and ModifyBiblioMarc accepts a subset of these Signed-off-by: Michał Kula <148193449+mkibp at users.noreply.github.com> Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:25:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:25:26 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160155|0 |1 is obsolete| | --- Comment #95 from Martin Renvoize --- Created attachment 160484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160484&action=edit Bug 29440: Only log items has been inserted if actually have been so, and remove extra out of place logging of record insertion Signed-off-by: Michał Kula <148193449+mkibp at users.noreply.github.com> Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:25:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:25:30 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160156|0 |1 is obsolete| | --- Comment #96 from Martin Renvoize --- Created attachment 160485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160485&action=edit Bug 29440: Replace removed syspref BiblioAddsAuthorities with AutoLinkBiblios Signed-off-by: Michał Kula <148193449+mkibp at users.noreply.github.com> Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:25:34 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:25:34 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160157|0 |1 is obsolete| | --- Comment #97 from Martin Renvoize --- Created attachment 160486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160486&action=edit Bug 29440: Fix AddBiblio/ModBiblio options args Signed-off-by: Michał Kula <148193449+mkibp at users.noreply.github.com> Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:25:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:25:37 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 --- Comment #98 from Martin Renvoize --- Created attachment 160487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160487&action=edit Bug 29440: (QA follow-up) Fix tidy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:25:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:25:59 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #99 from Martin Renvoize --- Happy new year.. Passing QA at last. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:26:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:26:22 +0000 Subject: [Koha-bugs] [Bug 35618] catalogue/showelastic.pl uses deprecated/removed parameter "type" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35618 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #7 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:27:23 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:27:23 +0000 Subject: [Koha-bugs] [Bug 28012] Error on saving new numbering pattern In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28012 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.02 released in| | --- Comment #31 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:32:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:32:04 +0000 Subject: [Koha-bugs] [Bug 34585] "When to charge" columns value not copied when editing circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34585 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:32:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:32:06 +0000 Subject: [Koha-bugs] [Bug 34585] "When to charge" columns value not copied when editing circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34585 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160370|0 |1 is obsolete| | --- Comment #7 from Lucas Gass --- Created attachment 160488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160488&action=edit Bug 34585: Fix behaviour of select dropdowns when editing circulation rules When chancing rule to edit via "Edit" button in circulation rules table, dropdown values aren't always changed correctly. Pressing "Edit" first time works, but after that previous rules values persist. Same happens when one tries to clear edit row, values aren't set to default values. This happens with every input with a dropdown in it. This mostly happanes because we set attribute "selected" to selected options, but never clear them which leads to values persisting. In columns "Patron category" and "Itemtype" value "All", or "*" as it is in code, doesn't match to any existing values from database and can't be changed via pressing "Edit" button. To reproduce: 1. Select a rule to edit and then select another rule to edit. 2. Repeat this couple of times and observe what values dropdowns fields display in edit row. => Selected values in dropdowns aren't always changed based on rule that you are currently editing. Instead after changing rule couple of times value doesn't change at all. 3. Press "Clear" button to return edit rows values back to default values. => Values in dropdowns aren't set back as default, instead they have same values as rule you edited before pressing "Clear". After reproducing problem, apply this patch and proceed to test "Clear" and "Edit" buttons. To test "Edit" button: 1. Again, select a rule to edit and then select a another rule to edit. 2. Observe what values dropdowns fields display in edit row. => Confirm that values are changed based on rule that you are currently editing and this behaviour doesn't change after selecting new rule to edit couple of times. To test "Clear" button: 1. Press "Clear" button. => Values in dropdowns should now be set as default values. Sponsored-by: Koha-Suomi Oy Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:32:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:32:18 +0000 Subject: [Koha-bugs] [Bug 34284] Customize the Accountlines Description: Lost Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34284 Sryan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sryan at lewistonschools.net --- Comment #2 from Sryan --- Amending this feature (overdue fine description notice) to include lost and damaged items would be incredibly helpful in a consortium to maintain more information after items are deleted. Would love to see this come to fruition. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:38:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:38:03 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160158|0 |1 is obsolete| | --- Comment #75 from Martin Renvoize --- Created attachment 160489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160489&action=edit Bug 25539: Remove AddBiblio option "defer_marc_save" Items are no longer embedded in the MARCXML and because of this the MARC data does not need to be saved once more after changing record items data. The "defer_marc_save" is no longer needed since bulkmarcimport.pl was the only place this option was utilized in order to resave MARC data after possibly changing items data. There is also a bug bulkmarcimport.pl where the record data is re-saved without stripping items if duplicate items are found and the dedup barcodes option is enabled that is resolved by this change. This change enables MARC Overlay rules to be enabled for bulkmarkcimport.pl as using the defer_marc option would previously effectively bypass any defined rules. To test 1) Apply patch 29440 (which this depends on), but no not yet apply this patch 2) Remove comments around "bulkmarcimport: _("bulkmarcimport.pl")," in koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt line 463 3) Enable MARC overlay rules and add a rule (with source => "*" or 'bulkmarcimport') to protect some field. 4) Import a biblio using the bulkmarcimport script. Overlay rules will only be applied on updates so a match condition matching the record in Koha when bulkmarcimport.pl is run the next time for the same record needs to be supplied (for example -match "control-number,001") 5) Edit the imported biblio and change the value of the protected field 6) Run bulkmarcimport with the same parameters as in 4) and verify the the field that should have been protected has been overwritten 7) Revert changes for line 463 in marc-overlay-rules.tt (or will result in conflict applying the patch), apply the patch and repeat steps 4-5, verify that the field now was protected from being overwritten. Signed-off-by: Michał Kula <148193449+mkibp at users.noreply.github.com> Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:38:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:38:07 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160159|0 |1 is obsolete| | --- Comment #76 from Martin Renvoize --- Created attachment 160490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160490&action=edit Bug 25539: Strip items when adding new biblio to preserve previous behaviour of the script Signed-off-by: Michał Kula <148193449+mkibp at users.noreply.github.com> Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:38:10 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:38:10 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160160|0 |1 is obsolete| | --- Comment #77 from Martin Renvoize --- Created attachment 160491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160491&action=edit Bug 25539: Enable bulkmarcimport overlay context Signed-off-by: Michał Kula <148193449+mkibp at users.noreply.github.com> Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:38:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:38:22 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:39:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:39:02 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 --- Comment #78 from Martin Renvoize --- *** Bug 35075 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:39:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:39:02 +0000 Subject: [Koha-bugs] [Bug 35075] "bulkmarcimport" source missing in Marc Overlay Rules settings page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35075 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|BLOCKED |RESOLVED --- Comment #5 from Martin Renvoize --- *** This bug has been marked as a duplicate of bug 25539 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:40:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:40:30 +0000 Subject: [Koha-bugs] [Bug 29654] Add option to bulkmarimport.pl for matching on original id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29654 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:41:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:41:22 +0000 Subject: [Koha-bugs] [Bug 30349] Cleanup bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30349 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25539 CC| |martin.renvoize at ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 [Bug 25539] Remove AddBiblio "defer_marc_save" option -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:41:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:41:22 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30349 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30349 [Bug 30349] Cleanup bulkmarcimport.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:56:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:56:20 +0000 Subject: [Koha-bugs] [Bug 30349] Cleanup bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30349 --- Comment #7 from Martin Renvoize --- Created attachment 160492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160492&action=edit Bug 30349: Tidy bulkmarcimport.pl to fix indentations Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:56:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:56:22 +0000 Subject: [Koha-bugs] [Bug 30349] Cleanup bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30349 --- Comment #8 from Martin Renvoize --- Created attachment 160493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160493&action=edit Bug 30349: Use double dash for multi character option names Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:56:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:56:24 +0000 Subject: [Koha-bugs] [Bug 30349] Cleanup bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30349 --- Comment #9 from Martin Renvoize --- Created attachment 160494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160494&action=edit Bug 30349: More double dashes Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:57:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:57:05 +0000 Subject: [Koha-bugs] [Bug 30349] Cleanup bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30349 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132127|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:57:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:57:12 +0000 Subject: [Koha-bugs] [Bug 30349] Cleanup bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30349 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132128|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:57:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:57:19 +0000 Subject: [Koha-bugs] [Bug 30349] Cleanup bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30349 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132130|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:57:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:57:24 +0000 Subject: [Koha-bugs] [Bug 30349] Cleanup bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30349 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:57:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 16:57:48 +0000 Subject: [Koha-bugs] [Bug 30349] Cleanup bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30349 --- Comment #10 from Martin Renvoize --- Rebased, added proper commit lines and signed off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 18:08:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 17:08:27 +0000 Subject: [Koha-bugs] [Bug 31572] E-mail and SMS verification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31572 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 18:08:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 17:08:39 +0000 Subject: [Koha-bugs] [Bug 19501] New list category to restrict specific lists to staff & hide from OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 18:09:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 17:09:05 +0000 Subject: [Koha-bugs] [Bug 31572] E-mail and SMS verification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31572 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 18:09:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 17:09:09 +0000 Subject: [Koha-bugs] [Bug 19501] New list category to restrict specific lists to staff & hide from OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 18:10:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 17:10:22 +0000 Subject: [Koha-bugs] [Bug 35646] Allow using the publication date parts for serial numbering In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35646 Dani Elder changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danielle.elder at law.utexas.e | |du -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 18:18:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 17:18:50 +0000 Subject: [Koha-bugs] [Bug 35509] Make SQL autocomplete an optional feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35509 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 18:20:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 17:20:08 +0000 Subject: [Koha-bugs] [Bug 35676] OPAC search results - link for "Check for suggestions" generates a blank page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35676 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 18:20:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 17:20:18 +0000 Subject: [Koha-bugs] [Bug 32968] Create granular permissions for ERM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 18:27:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 17:27:17 +0000 Subject: [Koha-bugs] [Bug 35648] Allow sorting of patron categories in Overdue notice/status triggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #3 from Owen Leonard --- Thanks Lucas, that was a dumb oversight. I will redo the patch and correct the ID error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 18:28:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 17:28:17 +0000 Subject: [Koha-bugs] [Bug 35672] Update and Run SQL button should save changes even if report fails to run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35672 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 18:28:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 17:28:59 +0000 Subject: [Koha-bugs] [Bug 35672] Update and Run SQL button should save changes even if report fails to run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35672 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org --- Comment #1 from George Williams (NEKLS) --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 18:33:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 17:33:39 +0000 Subject: [Koha-bugs] [Bug 35672] Update and Run SQL button should save changes even if report fails to run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35672 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #2 from Barbara Johnson --- +1 as well -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 18:56:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 17:56:36 +0000 Subject: [Koha-bugs] [Bug 35690] New: Searching patrons with contains does not provide relevant results Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35690 Bug ID: 35690 Summary: Searching patrons with contains does not provide relevant results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: Laura.escamilla at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Example: In this example the library has the PatronSearchMethod system preference set to 'contains'. They attempted to search for a patron named 'Don Smith' but the primary search results are showing names such as 'Brandon Smith' and patrons who are located at their 'Smith Public Library' such as 'Madonna Jones - Smith Public Library'. It would be ideal if the search results showed relevant patrons first before suggesting patrons located at their 'Smith Public Library'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 18:57:44 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 17:57:44 +0000 Subject: [Koha-bugs] [Bug 35648] Allow sorting of patron categories in Overdue notice/status triggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 18:57:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 17:57:46 +0000 Subject: [Koha-bugs] [Bug 35648] Allow sorting of patron categories in Overdue notice/status triggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160455|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 160495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160495&action=edit Bug 35648: Allow sorting of patron categories in Overdue notice/status triggers This patch adds a basic DataTables configuration to the table of patron categories on the Overdue notice/status triggers page. The table can be sorted by patron category and can be filtered. To test, apply the patch and go to Tools -> Overdue notice/status triggers. - Confirm that the table of patron categories is sorted by default by patron category - Other columns should not be sortable - You should see a search field above the table which works to filter by patron category. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 19:27:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 18:27:37 +0000 Subject: [Koha-bugs] [Bug 35461] Renew All 66 SIP server response messages produce HASH content in replies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35461 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 19:27:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 18:27:40 +0000 Subject: [Koha-bugs] [Bug 35461] Renew All 66 SIP server response messages produce HASH content in replies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35461 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160453|0 |1 is obsolete| | --- Comment #13 from David Nind --- Created attachment 160496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160496&action=edit Bug 35461: Add unit tests Signed-off-by: Kyle M Hall Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 19:27:43 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 18:27:43 +0000 Subject: [Koha-bugs] [Bug 35461] Renew All 66 SIP server response messages produce HASH content in replies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35461 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160454|0 |1 is obsolete| | --- Comment #14 from David Nind --- Created attachment 160497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160497&action=edit Bug 35461: Fix function call parameters causing the HASH to show in the renew all responses "Renew All" -function aka. 65-66-messages work like this: 66-return messages has renewed items in BM-fields and non-renewables go into BN-fields. If all items were renewable, then the reply message looks like: Reply: 13.07.2022 10:06:17:530 OUTESTI1 6610005000020220713 100616AOOUPK|BM564N15977171|BM564N09203960|BM564N23261720|BM564N25161958|BM564N23455012|C4::SIP::SIPServer=HASHC4::SIP::SIPServer=HASHAY6AZCEFE If items include renewables and non-renewables, the response includes the renewed items first, then a HASH mixed into the first BN-field, then rest of the renewed ones like they should show in BN-fields and after that, anohter HASH: 13.07.2022 14:41:32:610 OUTESTI1 6610003000420220713 144130AOOUPK|BM564N23455012|BM564N23261720|BM564N25161958|C4::SIP::SIPServer=HASHBN564N09203960|BN564N04191259|BN564N15977171|BN564N13788332|C4::SIP::SIPServer=HASHAY8AZC7C5 If all loans were unrenewable (this test included just one item), you first get a HASH in a BN-field, and another at the end. 13.07.2022 14:49:00:037 OUTESTI1 6610000000120220713 144858AOOUPK|C4::SIP::SIPServer=HASHBN564N19874533|C4::SIP::SIPServer=HASHAY9AZDD3B Our self checkout/checkin machine can handle/parse these reply messages correctly, but this might not be the case with all self checkout/checkin devices. Test Plan: 1) Unit test patch 2) prove t/db_dependent/SIP/Message.t 3) Note failures 4) Apply this patch 5) prove t/db_dependent/SIP/Message.t 6) Tests pass! Signed-off-by: Kyle M Hall Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 19:35:25 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 18:35:25 +0000 Subject: [Koha-bugs] [Bug 35461] Renew All 66 SIP server response messages produce HASH content in replies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35461 --- Comment #15 from David Nind --- (In reply to Kyle M Hall from comment #12) > Nope, the unit test was missing a comma causing it to fail all the time and > in my haste I didn't re-test the "fixed" version against the patch to ensure > it passed afterward! It's ready to test again! Those pesky commas! 8-; Thanks Kyle. Now signed off! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 19:37:43 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 18:37:43 +0000 Subject: [Koha-bugs] [Bug 35691] New: Remove the AUTO_RENEWALS notice in favor of AUTO_RENEWALS_DGST Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35691 Bug ID: 35691 Summary: Remove the AUTO_RENEWALS notice in favor of AUTO_RENEWALS_DGST Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org In my opinion the AUTO_RENEWALS notice is unnecessary since we have the digestible version (AUTO_RENEWALS_DGST). In my experience almost nobody wants the non-digestible version and many patrons are annoyed when they are sent multiple notifications undigested. And less emails per recipient is good. However, maybe I am missing a good use case for non-digestible auto renewal notices? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 19:37:56 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 18:37:56 +0000 Subject: [Koha-bugs] [Bug 35691] Remove the AUTO_RENEWALS notice in favor of AUTO_RENEWALS_DGST In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35691 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 19:54:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 18:54:04 +0000 Subject: [Koha-bugs] [Bug 35648] Allow sorting of patron categories in Overdue notice/status triggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 19:54:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 18:54:06 +0000 Subject: [Koha-bugs] [Bug 35648] Allow sorting of patron categories in Overdue notice/status triggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160495|0 |1 is obsolete| | --- Comment #5 from Lucas Gass --- Created attachment 160498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160498&action=edit Bug 35648: Allow sorting of patron categories in Overdue notice/status triggers This patch adds a basic DataTables configuration to the table of patron categories on the Overdue notice/status triggers page. The table can be sorted by patron category and can be filtered. To test, apply the patch and go to Tools -> Overdue notice/status triggers. - Confirm that the table of patron categories is sorted by default by patron category - Other columns should not be sortable - You should see a search field above the table which works to filter by patron category. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 20:28:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 19:28:38 +0000 Subject: [Koha-bugs] [Bug 35690] Searching patrons with contains does not provide relevant results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35690 Michael Adamyk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madamyk at ckls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 20:34:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 19:34:18 +0000 Subject: [Koha-bugs] [Bug 26912] Expired staff accounts can still log in to Koha staff intranet, SIP, API, etc. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26912 Michael Adamyk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madamyk at ckls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 20:39:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 19:39:12 +0000 Subject: [Koha-bugs] [Bug 35692] New: ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 Bug ID: 35692 Summary: ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It looks like between bug 30407 and bug 25560 we lost the line that made the update conditional: $item->notforloan($rules->{$key})->store({ log_action => 0, skip_record_index => 1, skip_holds_queue => 1 }) unless $rules->{$key} eq 'ONLYMESSAGE'; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 20:39:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 19:39:30 +0000 Subject: [Koha-bugs] [Bug 35692] ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30407, 25560 Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 [Bug 30407] Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 20:39:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 19:39:30 +0000 Subject: [Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35692 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 [Bug 35692] ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 20:39:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 19:39:30 +0000 Subject: [Koha-bugs] [Bug 30407] Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35692 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 [Bug 35692] ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 20:51:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 19:51:59 +0000 Subject: [Koha-bugs] [Bug 35692] ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 20:52:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 19:52:01 +0000 Subject: [Koha-bugs] [Bug 35692] ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 --- Comment #1 from Nick Clemens --- Created attachment 160499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160499&action=edit Bug 35692: Unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 20:52:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 19:52:02 +0000 Subject: [Koha-bugs] [Bug 35692] ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 --- Comment #2 from Nick Clemens --- Created attachment 160500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160500&action=edit Bug 35692: Do not update not for loan status if ONLYMESSAGE is provided To test: 1 - Set UpdateNotForLoanStatusOnCheckin to: _ALL_: -1: ONLYMESSAGE 2 - Set an item in the catalog as -1/Ordered 3 - Check the item in 4 - Confirm you see the message 5 - View the record details 6 - Item is now for loan 7 - Check item in again, no message 8 - Apply patch, restart all 9 - Set item as not for loan -1/Ordered 10 - Check item in, you see the message 11 - Check it in again, still see message 12 - Check the detail page, item still marked as ordered -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 21:14:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 20:14:37 +0000 Subject: [Koha-bugs] [Bug 35692] ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley at catalyst.net.nz --- Comment #3 from Alex Buckley --- Hi Nick, I noticed that too! I submitted a patchset in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 but happy for your patchset to be upstreamed instead :) Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 21:32:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 20:32:39 +0000 Subject: [Koha-bugs] [Bug 35666] Make it possible to cancel the transfer of the item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35666 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 21:47:29 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 20:47:29 +0000 Subject: [Koha-bugs] [Bug 34575] Patron search results: Customise the fields displayed in Name column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34575 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 21:53:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 20:53:52 +0000 Subject: [Koha-bugs] [Bug 35672] Update and Run SQL button should save changes even if report fails to run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35672 Dave changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ddaghita at mckinneytexas.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 21:56:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 20:56:38 +0000 Subject: [Koha-bugs] [Bug 21314] Koha enforces three (3) character password length even if RequireStrongPassword is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21314 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #16 from Christopher Brannon --- (In reply to Marcel de Rooy from comment #10) > + if ( C4::Context->preference('RequireStrongPassword') ) { > + $minPasswordLength = 3 if $minPasswordLength < 3; > + } > > How strong is that? LOL > Imo we should enforce at least 8 chars or so, and educate users that > security has a price. Our library practices similar methods, and we've run into this issue as well. I've never liked software that tells users how to enforce their security. The options should be there, and how secure or insecure they choose to run it should be up to them. However, there are bugs, like https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462 that focus on improving things in another way, which would give us more flexibility and options. It just feels like libraries are being forced to bend to the will of programmers based on personal opinions. There are a lot of minimum values that could be forced on libraries and their patrons, but that should be the choice of the library, not the program. Imo, our default passwords SHOULD be stronger. But I don't get to make that decision, so why should a developer? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 22:17:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 21:17:21 +0000 Subject: [Koha-bugs] [Bug 34200] Lists and merge catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34200 --- Comment #10 from Christopher Brannon --- I agree that this is an incomplete merge, and is a bug. It is definitely not a desired (and I doubt intended) result. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 23:15:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 22:15:57 +0000 Subject: [Koha-bugs] [Bug 35692] ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 23:15:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 22:15:59 +0000 Subject: [Koha-bugs] [Bug 35692] ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160499|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 160501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160501&action=edit Bug 35692: Unit test Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 23:16:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 22:16:02 +0000 Subject: [Koha-bugs] [Bug 35692] ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160500|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 160502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160502&action=edit Bug 35692: Do not update not for loan status if ONLYMESSAGE is provided To test: 1 - Set UpdateNotForLoanStatusOnCheckin to: _ALL_: -1: ONLYMESSAGE 2 - Set an item in the catalog as -1/Ordered 3 - Check the item in 4 - Confirm you see the message 5 - View the record details 6 - Item is now for loan 7 - Check item in again, no message 8 - Apply patch, restart all 9 - Set item as not for loan -1/Ordered 10 - Check item in, you see the message 11 - Check it in again, still see message 12 - Check the detail page, item still marked as ordered Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 23:27:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 22:27:22 +0000 Subject: [Koha-bugs] [Bug 35658] Typo in /patrons/:patron_id/holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35658 --- Comment #3 from Katrin Fischer --- I am sorry, holidays got in the way - it's next on my 'push list' already. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 23:40:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 22:40:49 +0000 Subject: [Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844 --- Comment #50 from Katrin Fischer --- (In reply to Jonathan Druart from comment #49) > (In reply to Katrin Fischer from comment #48) > > Maybe we could extend the relationship later. At the moment we create an > > order from a suggestion, so a 1:1 makes sense. > > > > When I tested this my main concern was to ensure that the suggestions > > existing previously to this fix would still work, patrons receiving emails > > etc. Did you take a look at that aspect? > > Yes, but didn't fix it. Seen comment 35? Yes, but ... I think we need to fix this, but I also think we can't break existing suggestions especially since it involves a service the library provides to their patrons and they can't really fix it in the GUI either. Too late today, but we should give this some more thought. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 23:41:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 22:41:13 +0000 Subject: [Koha-bugs] [Bug 35693] New: Granular Permissions to Everything Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35693 Bug ID: 35693 Summary: Granular Permissions to Everything Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com I don't know exactly how to file this. Koha is growing all the time and new features are always being added, but they are often being added with very little permission granularity. Often the permissions are too broad. For example, the newer pages under additional-contents.pl is under the entire umbrella of one permission for the user, and gives them access to ALL pages, ALL news, and ALL HTML customizations. I am hoping that Koha will start thinking more about roles in the library, and allowing us to give specific people access to specific pages, customizations, etc. This goes even further with who can override things. We don't have a lot of control over who can do what specific things. Maybe there is a bug on this topic already? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 23:44:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 22:44:12 +0000 Subject: [Koha-bugs] [Bug 31617] Allow manual editing of suggestions.biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31617 Kris changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kbecker at jcls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 23:44:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 22:44:52 +0000 Subject: [Koha-bugs] [Bug 35694] New: Give pages the option to be a page or modal Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35694 Bug ID: 35694 Summary: Give pages the option to be a page or modal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org Currently, you can only display pages as pages. However, there is a preview button that shows the content in a modal. I think that some of the content would be better as a modal. It would be great if we could specify whether the content is displayed as a page or as a modal. I do get that this depends on the page it is linked from, but would imagine there are ways to deal with this. I've created modals on pages via jQuery with no problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 23:53:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 22:53:37 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 23:53:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 22:53:40 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160447|0 |1 is obsolete| | --- Comment #13 from David Nind --- Created attachment 160503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160503&action=edit Bug 35681: [TEST ONLY]: This is a dummy dbrev to force an update This patch adds an atomic update file and also an equivilent db_rev and increments the Koha.pm version too. Use it to test the output of updatedatebase, run via console or via the browser. Test plan 1) Start KTD without the patches applied. 2) Apply this test patch 3) Run the detabase updates via the console and confirm it looks reasonable and is colored. 4) Reset the database version in ktd `koha-mysql kohadev` `UPDATE systempreferences SET value = '23.1200002';` 5) Run the database updates via the browser; `http://localhost:8081/cgi-bin/koha/installer/install.pl?step=3&op=updatestructure` 6) Confirm the presence of weird looking escape characters on screen. 7) Apply the next patch and run through steps 3 to 5 again, this time confirming the browser output looks good. Signed-off-by: Pedro Amorim Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 23:53:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 22:53:42 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160448|0 |1 is obsolete| | --- Comment #14 from David Nind --- Created attachment 160504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160504&action=edit Bug 35681: Allow for ANSI color in database updates This patch adds support for colored output in database updates. Signed-off-by: Pedro Amorim Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 23:53:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 22:53:45 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160449|0 |1 is obsolete| | --- Comment #15 from David Nind --- Created attachment 160505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160505&action=edit Bug 35681: Add new perl dependancy Signed-off-by: Pedro Amorim Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 23:53:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 22:53:47 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160473|0 |1 is obsolete| | --- Comment #16 from David Nind --- Created attachment 160506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160506&action=edit Bug 35681: Use CSS class instead of inline style Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 23:55:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 22:55:53 +0000 Subject: [Koha-bugs] [Bug 35695] New: Remove useless item group code from cataloging_additem.js Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35695 Bug ID: 35695 Summary: Remove useless item group code from cataloging_additem.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl As I worked on Bug 33639 I noticed some code in cataloging_additem.js that doesn't work/isn't needed: 137 $('#item-group-add-or-create-form-select').on('change', function() { 138 if ( ! $('input.items-enumchron').val() ) { 139 let item_group_selector = '#item-group-' + $(this).val(); 140 let enumchron = $(item_group_selector).val(); 141 $('input.items-enumchron').val( enumchron ); 142 } 143 }); The selectors are bad and it would be easy to make them work. But I don't see any reason why item groups should be updating the items.enumchron field. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 23:56:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 22:56:06 +0000 Subject: [Koha-bugs] [Bug 35695] Remove useless item group code from cataloging_additem.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35695 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33639 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 [Bug 33639] Adding item to item group from 'Add item' screen doesn't work -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 23:56:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 22:56:06 +0000 Subject: [Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35695 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35695 [Bug 35695] Remove useless item group code from cataloging_additem.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 23:57:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 22:57:41 +0000 Subject: [Koha-bugs] [Bug 35696] New: Transit status not properly updated for items advanced in Stock Rotation tool Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35696 Bug ID: 35696 Summary: Transit status not properly updated for items advanced in Stock Rotation tool Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: heather at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Created attachment 160507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160507&action=edit Transit status of stock rotation items 23.05.06 While using the stock rotation tool in the Cataloging module, when items in rotas are advanced to the next stage, the status is not updating properly. In a proper status update for advancing items, the status reads "Transit pending from XX branch to YY branch since mm/dd/yyyy" which displays in 22.11.10. In 23.05.06, the status updates to show "Transit is pending from XX branch to YY branch since Available". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 00:00:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 23:00:38 +0000 Subject: [Koha-bugs] [Bug 35695] Remove useless item group code from cataloging_additem.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35695 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 00:00:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 23:00:40 +0000 Subject: [Koha-bugs] [Bug 35695] Remove useless item group code from cataloging_additem.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35695 --- Comment #1 from Lucas Gass --- Created attachment 160508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160508&action=edit Bug 35695: Remove useless JS from cataloging_additem.js To test: 1. APPLY PATCH 2. Turn on EnableItemGroups 3. Go to a record with item groups, or create some. 4. Add an item, making sure items can be added to a group. ( Bug 33639 must be applied ) If I am wrong and this code should stay, tell me. I'll fix the jQuery instead of removing it. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 00:00:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 23:00:57 +0000 Subject: [Koha-bugs] [Bug 35695] Remove useless item group code from cataloging_additem.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35695 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 00:08:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2024 23:08:18 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This enhancement adds release notes| |support for colored | |messages for Koha database | |updates, in both the | |terminal and browser. | | | |These new CSS classes are | |used: | |.updatedatabase-report-red | |for warnings | |.updatedatabase-report-gree | |n for ? | |.updatedatabase-report-yell | |ow where action is | |required | |.updatedatabase-report-blue | | for information --- Comment #17 from David Nind --- Testing notes (using KTD): 1. To get the colours to show in the browser update after applying the patches: yarn build 2. Not a biggy, or a showstopper, but maybe the class names could be more semantic? Not sure if there are any rules/guidelines for this. .updatedatabase-report-red -warning .updatedatabase-report-green -? (not sure for this one) .updatedatabase-report-yellow -action-required .updatedatabase-report-blue -information 3. Also, there is no class .updatedatabase-report-white -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 07:52:56 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 06:52:56 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #18 from Martin Renvoize --- That sounds trivial, but is actually rather difficult due to the way they're created. I'd like to eventually switch them to use the standard bookstrap classes, it right now there no way to achieve it with the library we're using to convert ansi to html. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 07:55:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 06:55:52 +0000 Subject: [Koha-bugs] [Bug 35697] New: Checkingout books causes a error 500 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35697 Bug ID: 35697 Summary: Checkingout books causes a error 500 Change sponsored?: --- Product: Koha Version: 23.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: jmpinpin.cca at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 160509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160509&action=edit Error 500 upon check out of book/library material KOHA VER. 23.11.00 - January update Checkingout books causes a error 500, pressing the "Check out" botton with a blank barcode causes to redirect to print issuequick slip. I tested this on our system, and replicated the same issue on KOHA Demo website. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 08:28:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 07:28:02 +0000 Subject: [Koha-bugs] [Bug 35625] Add support for system flag to additional fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35625 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #9 from Jonathan Druart --- The purpose of this table/ft was to add specific data. Flagging a fields as "is mandatory for the system to work correctly" is wrong by design IMO. It should be a column in the original table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 08:33:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 07:33:07 +0000 Subject: [Koha-bugs] [Bug 35614] Update cpanfile for Mojolicious::Plugin::OpenAPI v5.09 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 --- Comment #6 from Jonathan Druart --- What does it mean for the package manager? We need more info here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 08:38:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 07:38:30 +0000 Subject: [Koha-bugs] [Bug 35614] Update cpanfile for Mojolicious::Plugin::OpenAPI v5.09 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 --- Comment #7 from Jonathan Druart --- libjson-validator-perl buster (oldoldstable) 3.06+dfsg-1: all bullseye (oldstable) 4.14+dfsg-1: all bookworm (stable) 5.14+dfsg-1: all trixie (testing) 5.14+dfsg-1: all sid (unstable) 5.14+dfsg-1: all focal (20.04LTS) 3.23+dfsg-1: all jammy (22.04LTS) 5.05+dfsg-1: all lunar (23.04) 5.13+dfsg-1: all mantic (23.10) 5.14+dfsg-1: all libmojolicious-plugin-openapi-perl bullseye (oldstable) 3.41-1: all bookworm (stable) 5.09-1: all trixie (testing) 5.09-1: all sid (unstable) 5.09-1: all focal (20.04LTS) 2.21-1: all jammy (22.04LTS) 5.02-1: all lunar (23.04) 5.09-1: all mantic (23.10) 5.09-1: all So we still need to package our own. Mason, are you ok with that? We would need to remove the '-really' and provide JSON::Validator 5.14 and Mojolicious::Plugin::OpenAPI 5.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 08:43:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 07:43:01 +0000 Subject: [Koha-bugs] [Bug 35629] Redundant code in includes/patron-search.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35629 --- Comment #8 from Jonathan Druart --- Definitely a bad rebase conflict resolution. Thanks, Pedro! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 09:45:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 08:45:14 +0000 Subject: [Koha-bugs] [Bug 35392] HTML in translatable string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #23 from Jonathan Druart --- Can we get a simple version of this fix for backport, please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 09:51:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 08:51:42 +0000 Subject: [Koha-bugs] [Bug 35625] Add support for system flag to additional fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35625 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim at ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 09:52:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 08:52:14 +0000 Subject: [Koha-bugs] [Bug 32162] erm_eholdings_packages_agreements does not have a primary key In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35338 --- Comment #11 from Jonathan Druart --- (In reply to Jonathan Druart from comment #10) > (In reply to Nick Clemens from comment #9) > > (In reply to Jonathan Druart from comment #8) > > > What's the version of the DBMS, Nick? > > > > Server version: 5.7.12 MySQL Community Server (GPL) > > If this is a MySQL 5.7 thing, are we still supporting it? > > See also bug 29805. See bug 35338. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35338 [Bug 35338] Error in SQL syntax when upgrading to 22.06.00.084 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 09:52:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 08:52:14 +0000 Subject: [Koha-bugs] [Bug 35338] Error in SQL syntax when upgrading to 22.06.00.084 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35338 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32162 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162 [Bug 32162] erm_eholdings_packages_agreements does not have a primary key -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 09:52:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 08:52:52 +0000 Subject: [Koha-bugs] [Bug 35338] Error in SQL syntax when upgrading to 22.06.00.084 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35338 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- >From bug 32162 (In reply to Nick Clemens from comment #9) > (In reply to Jonathan Druart from comment #8) > > What's the version of the DBMS, Nick? > > Server version: 5.7.12 MySQL Community Server (GPL) If this is a MySQL 5.7 thing, are we still supporting it? See also bug 29805. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 09:53:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 08:53:55 +0000 Subject: [Koha-bugs] [Bug 35698] New: Wrong bug number in db_revs/220600084.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35698 Bug ID: 35698 Summary: Wrong bug number in db_revs/220600084.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 32162 Should be 32162, not 31162. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162 [Bug 32162] erm_eholdings_packages_agreements does not have a primary key -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 09:53:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 08:53:55 +0000 Subject: [Koha-bugs] [Bug 32162] erm_eholdings_packages_agreements does not have a primary key In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35698 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35698 [Bug 35698] Wrong bug number in db_revs/220600084.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 09:54:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 08:54:40 +0000 Subject: [Koha-bugs] [Bug 35698] Wrong bug number in db_revs/220600084.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35698 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 09:54:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 08:54:42 +0000 Subject: [Koha-bugs] [Bug 35698] Wrong bug number in db_revs/220600084.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35698 --- Comment #1 from Jonathan Druart --- Created attachment 160510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160510&action=edit Bug 35698: (bug 32162 follow-up) fix bug number in db rev Should be 32162, not 31162. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 09:55:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 08:55:03 +0000 Subject: [Koha-bugs] [Bug 35698] Wrong bug number in db_revs/220600084.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35698 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 09:55:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 08:55:08 +0000 Subject: [Koha-bugs] [Bug 35698] Wrong bug number in db_revs/220600084.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35698 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 09:55:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 08:55:31 +0000 Subject: [Koha-bugs] [Bug 32162] erm_eholdings_packages_agreements does not have a primary key In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162 --- Comment #12 from Jonathan Druart --- (In reply to Nick Clemens from comment #7) > Bug number also wrong in the update file Oops, fixed on bug 35698. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 09:55:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 08:55:36 +0000 Subject: [Koha-bugs] [Bug 32162] erm_eholdings_packages_agreements does not have a primary key In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 10:07:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 09:07:16 +0000 Subject: [Koha-bugs] [Bug 35218] No tests for /erm/sushi_service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35218 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #9 from Jonathan Druart --- 10:01 < Joubu> t/db_dependent/api/v1/erm_sushi_services.t is failing because it compares an expected output with https://registry.projectcounter.org/api/v1/sushi-service/b94bc981-fa16-4bf6-ba5f-6c113f7ffa0b/ 10:01 < Joubu> and there is "migrations" there 10:01 < Joubu> which may have been added recently 10:01 < Joubu> this test is really bad (ie. depending on an external resource) 10:02 < Joubu> unless it's what we want, but it's not clear what the test is actually testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 10:09:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 09:09:24 +0000 Subject: [Koha-bugs] [Bug 24326] Remove advance_notices_digest.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24326 --- Comment #5 from Jonathan Druart --- See comment 0: > the cronjob script is run outside the transaction and so changes are effective. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 10:11:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 09:11:57 +0000 Subject: [Koha-bugs] [Bug 35699] New: Wiki not sending emails for password reset / account verification Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35699 Bug ID: 35699 Summary: Wiki not sending emails for password reset / account verification Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Project website Assignee: wizzyrea at gmail.com Reporter: katrin.fischer at bsz-bw.de CC: david at davidnind.com, koha at trust-box.at, tomascohen at gmail.com It looks like we have a problem with the emails on the wiki again. Neither the password reset nor the account confirmation email were received. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 10:12:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 09:12:14 +0000 Subject: [Koha-bugs] [Bug 35699] Wiki not sending emails for password reset / account verification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35699 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|wizzyrea at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 10:21:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 09:21:45 +0000 Subject: [Koha-bugs] [Bug 25424] Document our exceptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25424 --- Comment #3 from Jonathan Druart --- What kind of pointers do you need? We need to make Koha::Exceptions namespace more consistent: the naming, the tree, the display of the exception (parameter, errors, stacktrace), etc. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 10:48:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 09:48:55 +0000 Subject: [Koha-bugs] [Bug 35697] Checkingout books causes a error 500 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35697 --- Comment #1 from Katrin Fischer --- Please verify that your item has complete information. It needs: * an itemtype (MARC21 $y) * a homebranch (MARC21 $a) * a holdingbranch (MARC21 $b) If the item is complete, it would help to get the full error from the server logs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 11:04:25 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 10:04:25 +0000 Subject: [Koha-bugs] [Bug 9725] Add support to notices for hourly loans In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9725 Ray Delahunty changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk --- Comment #1 from Ray Delahunty --- In the meantime we are using the patron_emailer_pl functionality to send 'late' notices for hourly loans. For example when a laptop loaned for 5 hours goes late, the email is sent within a few minutes. OK it means running the emailer script often: */5 * * * * /usr/share/koha/bin/cronjobs/patron_emailer.pl --report 974 --notice ODUE_LAPTOP --module circulation --commit Better than nothing, I suppose. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 11:16:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 10:16:27 +0000 Subject: [Koha-bugs] [Bug 35699] Wiki not sending emails for password reset / account verification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35699 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34637 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34637 [Bug 34637] Wiki - email notifications aren't being sent (account registrations, password resets, etc.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 11:16:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 10:16:27 +0000 Subject: [Koha-bugs] [Bug 34637] Wiki - email notifications aren't being sent (account registrations, password resets, etc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34637 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35699 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35699 [Bug 35699] Wiki not sending emails for password reset / account verification -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 11:17:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 10:17:15 +0000 Subject: [Koha-bugs] [Bug 34637] Wiki - email notifications aren't being sent (account registrations, password resets, etc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34637 --- Comment #8 from Katrin Fischer --- I filed bug 35699 before finding this one. I have reports again of the emails not arriving (neither password reset nor account registrations). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 11:25:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 10:25:09 +0000 Subject: [Koha-bugs] [Bug 24383] koha-create doesn't restart / empty memcached causing installer fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24383 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31124, 6416 --- Comment #4 from Jonathan Druart --- Once we have fixed the other koha-remove bugs, it should be trivial to fix. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6416 [Bug 6416] koha-remove fails when dropping user https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31124 [Bug 31124] koha-remove fails to remove long_tasks queue daemon, so koha-create for same user fails -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 11:25:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 10:25:09 +0000 Subject: [Koha-bugs] [Bug 6416] koha-remove fails when dropping user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6416 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24383 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24383 [Bug 24383] koha-create doesn't restart / empty memcached causing installer fail -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 11:25:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 10:25:09 +0000 Subject: [Koha-bugs] [Bug 31124] koha-remove fails to remove long_tasks queue daemon, so koha-create for same user fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31124 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24383 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24383 [Bug 24383] koha-create doesn't restart / empty memcached causing installer fail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 11:25:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 10:25:45 +0000 Subject: [Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 --- Comment #16 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #14) > Found some tactics that seem effective on test 'Encoding in session > variables' > and test 'Display circulation table correctly' Which ones? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 11:28:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 10:28:31 +0000 Subject: [Koha-bugs] [Bug 35625] Add support for system flag to additional fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35625 --- Comment #10 from Pedro Amorim --- Hey, adding my 2 cents here in what I hope to be a constructive addition. (In reply to Jonathan Druart from comment #9) > The purpose of this table/ft was to add specific data. Flagging a fields as > "is mandatory for the system to work correctly" is wrong by design IMO. It > should be a column in the original table. I can definitely see where this argument is coming from, although I don't 100% agree with it being wrong by design. This is still specific data, it's just additional fields that Koha's code will rely on and can't be removed. Some of the alternatives here are: - Add the columns page_url and biblio_id to the ticket table, even though only ticket.source=catalog will use the biblio_id column and only ticket.source=opac_problem will use the page_url, this would get more and more confusing and hard to maintain as we go in the future (i.e. every new single type of ticket will potentially require new niche fields for their own). - Add a new 'tickets_attributes' table (and have this be the 4th relational metadata table we have in Koha, alongside additional_fields, patron_attributes and illrequestattributes. This would allow for a ticket of source=catalog to have the biblio_id and the ticket of source=opac_problem to have the page_url, without adding new columns to the table and making it flexible enough for future ticket types (sources). The problem here is that all this logic already exists in additional_fields. - Have a 'other_stuff' column in the tickets table that would store a json object that could store whatever in it and logic would handle what it wants to retrieve/store depending on the ticket.source (like plugin_data). This is not ideal either. ---- The advantages of having an additional_field:is_system are: - This is_system additional_field will automatically benefit from all the features from additional_fields (it may potentially be an authorized value list, repeatable, searchable, filterable, and so on) AND it would not pollute the tickets table (or any other table that would need to make use of this) with niche fields only used by some instantiations of the table, and not others. - Existing code from additional_fields is reused, thus any future fixes and enhancements also benefit this is_system additional_field. Whereas in any of the alternatives above if you need a specific field to be searchable on the datatable for example you will need to update the data table code. By using the additional_fields with is_system, the programmer just needs to set the field as searchable and nothing else needs to be done, again, benefiting from the additional_fields native features. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 11:30:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 10:30:20 +0000 Subject: [Koha-bugs] [Bug 35699] Wiki not sending emails for password reset / account verification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35699 Hamilton Dwight Walker changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |dwight at wwwalker.com.au --- Comment #1 from Hamilton Dwight Walker --- *** This bug has been marked as a duplicate of bug 34637 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 11:30:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 10:30:20 +0000 Subject: [Koha-bugs] [Bug 34637] Wiki - email notifications aren't being sent (account registrations, password resets, etc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34637 Hamilton Dwight Walker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Hamilton Dwight Walker --- *** Bug 35699 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 11:43:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 10:43:55 +0000 Subject: [Koha-bugs] [Bug 35070] Koha plugins implementing "background_jobs" hook can't provide view template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35070 --- Comment #16 from Katrin Fischer --- FAIL t/lib/plugins/Koha/Plugin/Test/inc/csrf-token.inc FAIL filters missing_filter at line 2 ([%~ 'OVERRIDE' ~%]) Will fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 11:45:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 10:45:45 +0000 Subject: [Koha-bugs] [Bug 35700] New: Holds reminder cronjob --triggered switch does not work as intended if the day to send notice hits concurrent holidays Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35700 Bug ID: 35700 Summary: Holds reminder cronjob --triggered switch does not work as intended if the day to send notice hits concurrent holidays Change sponsored?: --- Product: Koha Version: 23.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: lmstrand at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz If the calendar has concurrent holidays, when holds_reminder.pl cronjob is being ran daily with the --triggered switch and the day the notice should be sent lands on a holiday which is repeated the following days, the cronjob sends holds reminders until the holiday period ends. To reproduce: Reserve an item, receive it at a branch where the reserve was made to. Move the waitingdate and reservedate of the reserve to x days before the reserve was made in the database. Add holidays (single non-repeated days) to the calendar so that the first holiday lands on a date when the hold reminder should be sent. Set up the cronjob to run so that the --days trigger matches the first added holiday using also the --triggered switch: holds_reminder.pl -v --days x --triggered --holidays -c for example. Check that the x:th day from the reserve's waitingdate is a holiday, and the date has following days set as holidays as well. Notice that on the following day/days of the first sent reminder, the message is sent again. Same happens the following holidays. It seems the notice is sent also if there is a repeated holiday following the first single day holiday the message was sent (like if saturdays and sundays were repeated holidays). I guess this could be reproduced easier by moving your system date forward and running the cronscript again. I couldn't reproduce the same bug when moving back the waitingdate of the reserve to simulate a day had passed since the first message for some reason. Notice that modifying the holidays use a cache, so just making changes to the database is not enough for the cronscript to notice the changes made. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 11:46:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 10:46:06 +0000 Subject: [Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 --- Comment #17 from Jonathan Druart --- Created attachment 160511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160511&action=edit Bug 35506: Trying to fix selenium error: Can't call method "get_text" Just a guess, we should wait for the ajax response before looking for the element in the table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 12:08:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 11:08:03 +0000 Subject: [Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha at gmail. |koha-bugs at lists.koha-commun |com |ity.org --- Comment #51 from Jonathan Druart --- I am not willing to write the DB rev to adjust the existing entries. I would like help here please. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 12:09:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 11:09:26 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|jonathan.druart+koha at gmail. |koha-bugs at lists.koha-commun |com |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 12:11:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 11:11:42 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha at gmail. |koha-bugs at lists.koha-commun |com |ity.org --- Comment #110 from Jonathan Druart --- See bug 24977 comment 9, it was the last movement for this. I am out however. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 12:15:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 11:15:18 +0000 Subject: [Koha-bugs] [Bug 34637] Wiki - email notifications aren't being sent (account registrations, password resets, etc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34637 Rudolf Byker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rudolfbyker at gmail.com --- Comment #10 from Rudolf Byker --- As discussed on IRC today: I'm trying to get into the wiki to make some edits, but I can't (re)set my passwords, since no e-mails are arriving (I checked the spam folder of course). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 12:16:29 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 11:16:29 +0000 Subject: [Koha-bugs] [Bug 30777] stockrotationitems table could store additional information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30777 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Martin Renvoize --- Do you mean in the database table itself.. or rather in the display somewhere Lisette? We have all this information already available in other tables I believe, so we should be able to expose it in a few places should you want to. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 12:16:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 11:16:49 +0000 Subject: [Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 Rudolf Byker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rudolfbyker at gmail.com --- Comment #69 from Rudolf Byker --- Here is my script to fix old installations before upgrading: https://pastebin.com/5ujqW3H0 I'll add it to https://wiki.koha-community.org/wiki/Database_row_format once I can get into the wiki (see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34637#c10 ). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 12:20:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 11:20:11 +0000 Subject: [Koha-bugs] [Bug 35625] Add support for system flag to additional fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35625 --- Comment #11 from Jonathan Druart --- Then maybe you need 2 different DB tables. One perl module (generic ticket) that will be inherited by the two specific ticket modules. It's not a bad thing to have different DB tables when your objects are different. Then if you need repeatable fields, you create yet another table with 1-n relationship. It's... relational models and database normalization ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:00:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:00:40 +0000 Subject: [Koha-bugs] [Bug 35392] HTML in translatable string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159279|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:00:44 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:00:44 +0000 Subject: [Koha-bugs] [Bug 35392] HTML in translatable string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159280|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:00:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:00:47 +0000 Subject: [Koha-bugs] [Bug 35392] HTML in translatable string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159281|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:00:51 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:00:51 +0000 Subject: [Koha-bugs] [Bug 35392] HTML in translatable string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159283|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:00:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:00:55 +0000 Subject: [Koha-bugs] [Bug 35392] HTML in translatable string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160450|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:00:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:00:59 +0000 Subject: [Koha-bugs] [Bug 35392] HTML in translatable string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160451|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:01:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:01:46 +0000 Subject: [Koha-bugs] [Bug 35392] HTML in translatable string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 --- Comment #24 from Pedro Amorim --- Created attachment 160512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160512&action=edit Bug 35392: Fix HTML in translatable string -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:01:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:01:49 +0000 Subject: [Koha-bugs] [Bug 35392] HTML in translatable string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 --- Comment #25 from Pedro Amorim --- Created attachment 160513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160513&action=edit Bug 35392: Update tests Run: yarn cypress run --spec "t/cypress/integration/ERM/DataProviders_spec.ts" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:11:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:11:26 +0000 Subject: [Koha-bugs] [Bug 35625] Add support for system flag to additional fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35625 --- Comment #12 from Pedro Amorim --- (In reply to Jonathan Druart from comment #11) > Then maybe you need 2 different DB tables. > > One perl module (generic ticket) that will be inherited by the two specific > ticket modules. > > It's not a bad thing to have different DB tables when your objects are > different. Then if you need repeatable fields, you create yet another table > with 1-n relationship. It's... relational models and database normalization > ;) Yes but you're highlighting exactly why this approach is worth considering in the first place. Why re-implement anything that's already been implemented at the additional_fields level? We already have patron_custom_attributes and additional_fields, 2 implementations of what is essentially the same thing, but now need to be maintained and supported individually. This is exactly what we're aiming to prevent here: implement yet another redundant metadata table that needs to do something that's already implemented in Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:13:23 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:13:23 +0000 Subject: [Koha-bugs] [Bug 35392] HTML in translatable string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:20:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:20:09 +0000 Subject: [Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 --- Comment #1 from Martin Renvoize --- Created attachment 160514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160514&action=edit Bug 35100: Unit tests This patch adds a unit test to ensure StockrotationAdvance transfers are not cancelled from request_transfer when called with 'replace'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:20:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:20:12 +0000 Subject: [Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 --- Comment #2 from Martin Renvoize --- Created attachment 160515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160515&action=edit Bug 35100: Prevent StockrotationAdvance transfers from being cancelled ModItemTransfer is still very heavy handed and outright overrules existing transfers in the queue. For StockrotationAdvance transfers it's important that they remain in the queue to get actioned later, even if a higher precident transfer is actions in the interim. This patch adds a clause to the cancellation call within request_transfer such that StockrationAdvance transfers are left in tact for the next time the item is checked in. Test plan 1) Item is added to stock rotation 2) The cronjob creates a 'StockRotationAdvance' transfer 3) The item is checked in, which initiates the transfer, however, a hold is triggered 4) The hold is confirmed, which replaces the StockRotationAdvance 5) The item is checked out 6) The item is checked in, which initiates the transfer again 6) The item is checked in at it's destination and the StockrotationAdvance transfer has the proper date arrived date set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:20:43 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:20:43 +0000 Subject: [Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22160 Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 [Bug 22160] OMNIBUS: Transfers enhancements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:20:43 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:20:43 +0000 Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35100 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:22:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:22:41 +0000 Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Martin Renvoize --- https://gitlab.com/mrenvoize/Koha/-/merge_requests/1 still details some of the missing pieces here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:29:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:29:52 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132212|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize --- Created attachment 160516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160516&action=edit Bug 28294: Add 'WrongTransfer' to transfer reason enum This patch adds the 'WrongTransfer' value to the 'reason' enum in the branchtransfers table. This is so we can use it as a reason for the subsequent transfer when a trainsfer is triggered by a checkin at an incorrect branch after transfer has been initiated. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:29:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:29:55 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132213|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize --- Created attachment 160517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160517&action=edit Bug 28294: Add Koha::Item::Transfer->remedy method and use in updateWrongTransfer This patch is an interim patch to prove that the new remedy method achieves the same as updateWrongTransfer. Test plan 1/ Run t/db_dependant/Circulation.t before and after applying this patch. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:29:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:29:57 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132214|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize --- Created attachment 160518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160518&action=edit Bug 28294: Unit Tests This patch adds unit tests for the new 'remedy' method we are introducing to Koha::Item::Transfer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:30:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:30:00 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132215|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize --- Created attachment 160519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160519&action=edit Bug 28294: Remove use of updateWrongTransfer This patch removes the last remaining use of updateWrongTransfer. Test plan 1/ git grep updateWrongTransfer to confirm there are no more uses of the method. 2/ Confirm an incorrect transfer still behaves as expected at circulation returns. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:30:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:30:03 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132216|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize --- Created attachment 160520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160520&action=edit Bug 28294: Remove updateWrongTransfer method This patch removes the updateWrongTransfer method entirely from C4/Circulation.pm. Test plan 1/ Confirm that there are no longer any mentions of updateWrongTransfer in the codebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:30:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:30:06 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132217|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize --- Created attachment 160521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160521&action=edit Bug 28294: Remove unit tests for updateWrongTransfer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:31:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:31:54 +0000 Subject: [Koha-bugs] [Bug 35625] Add support for system flag to additional fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35625 --- Comment #13 from Jonathan Druart --- Then maybe this needs to be abstracted, to make it more flexible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:36:44 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:36:44 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 --- Comment #45 from Martin Renvoize --- Rebased, but not I'm revisiting the code I'm wondering why it's needed.. I think we could perhaps just replace the call to updateWrongTransfer with a call to request_transfer instead (and pass 'replace' in with a reason of 'wrongTransfer'). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:38:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:38:14 +0000 Subject: [Koha-bugs] [Bug 31199] selenium/patrons_search.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31199 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35396 --- Comment #30 from Jonathan Druart --- Waiting for bug 35396 before getting back to this one. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35396 [Bug 35396] Replace Datatables' column filters throttling with input timeout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:38:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:38:14 +0000 Subject: [Koha-bugs] [Bug 35396] Replace Datatables' column filters throttling with input timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35396 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31199 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31199 [Bug 31199] selenium/patrons_search.t is failing randomly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:41:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:41:11 +0000 Subject: [Koha-bugs] [Bug 34900] The translation of the string "The " should depend on context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:41:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:41:15 +0000 Subject: [Koha-bugs] [Bug 34900] The translation of the string "The " should depend on context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159501|0 |1 is obsolete| | Attachment #159502|0 |1 is obsolete| | Attachment #159503|0 |1 is obsolete| | Attachment #160070|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart --- Created attachment 160522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160522&action=edit Bug 34900: Simplify text of about page license information This patch simplifies the language describing third-party libraries and their licenses so that translation are not so complicated. The patch also removes information about some assets which are no longer part of Koha. The license information now lists only the library name, version (if possible) and license. To test, apply the patch and go to the about page in the staff interface. Open the "Licenses" tab and check the content. Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:41:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:41:18 +0000 Subject: [Koha-bugs] [Bug 34900] The translation of the string "The " should depend on context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 --- Comment #27 from Jonathan Druart --- Created attachment 160523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160523&action=edit Bug 34900: (follow-up) Correct last entry Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:41:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:41:21 +0000 Subject: [Koha-bugs] [Bug 34900] The translation of the string "The " should depend on context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 --- Comment #28 from Jonathan Druart --- Created attachment 160524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160524&action=edit Bug 34900: (follow-up) List alphabetically and tidy ups Listed in alphabetical order (except for Koha, which is listed at the start). Tidy ups and consistency changes: - end of each entry: remove full stops - separator between software and license: use a colon - headings for software/library name: use sentence case unless a noun, abbreviation, or the actual software name - http and https: use https where site uses it - URLs: update where required - license names: use consistent full names with title case Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:41:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:41:24 +0000 Subject: [Koha-bugs] [Bug 34900] The translation of the string "The " should depend on context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 --- Comment #29 from Jonathan Druart --- Created attachment 160525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160525&action=edit Bug 34900: (follow-up) Add version information to more entries Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:43:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:43:11 +0000 Subject: [Koha-bugs] [Bug 35584] Missing licenses in about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:43:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:43:15 +0000 Subject: [Koha-bugs] [Bug 35584] Missing licenses in about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160231|0 |1 is obsolete| | Attachment #160232|0 |1 is obsolete| | Attachment #160233|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 160526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160526&action=edit Bug 35584: Add missing licenses to about page This patch adds license information to the about page which was missing for several JavaScript libraries. The patch also makes a minor change to CSS to improve alignment of content in the licenses tab. One library, vis-timeline-graph2d.min.js, lacked the correct version information in the source. This information has been added. To test, apply the patch and rebuild the staff interface CSS. - Go to the about page and open the "Licenses" tab. - Confirm that the information looks correct. Signed-off-by: David Nind Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:43:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:43:17 +0000 Subject: [Koha-bugs] [Bug 35584] Missing licenses in about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 --- Comment #10 from Jonathan Druart --- Created attachment 160527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160527&action=edit Bug 35584: (follow-up) Add license information and fix sort order Add license information and links. Put in alphabetical order. Signed-off-by: David Nind Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:43:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:43:20 +0000 Subject: [Koha-bugs] [Bug 35584] Missing licenses in about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 --- Comment #11 from Jonathan Druart --- Created attachment 160528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160528&action=edit Bug 35584: (QA follow-up): Typo fix: GreBox -> Greybox Capitalization fix: JavaScript case Order to match header fix: jsTree jQuery -> jQuery jsTree Capitalization fix: treetable -> Treetable capitalization Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:48:10 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:48:10 +0000 Subject: [Koha-bugs] [Bug 35643] Upgrade HC Sticky library from v2.2.3 to v2.2.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35643 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #3 from Jonathan Druart --- Noting, but not coming from this patch: https://snipboard.io/w431b6.jpg There is a gap between the 2 headers (OPAC) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:48:44 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:48:44 +0000 Subject: [Koha-bugs] [Bug 35643] Upgrade HC Sticky library from v2.2.3 to v2.2.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35643 --- Comment #4 from Jonathan Druart --- Coming from the rule margin-top: 3px on .selections-toolbar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:53:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:53:02 +0000 Subject: [Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844 --- Comment #52 from Katrin Fischer --- OK, I am not sure I could write it either, but the first step is to make a plan. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:59:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:59:16 +0000 Subject: [Koha-bugs] [Bug 35643] Upgrade HC Sticky library from v2.2.3 to v2.2.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35643 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 13:59:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 12:59:19 +0000 Subject: [Koha-bugs] [Bug 35643] Upgrade HC Sticky library from v2.2.3 to v2.2.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35643 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160299|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 160529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160529&action=edit Bug 35643: Upgrade HC Sticky library from v2.2.3 to v2.2.7 This patch upgrades the HC Sticky library in the OPAC and staff interface to the latest version, 2.2.7. The file is moved to its own directory for consistency's sake. To test, apply the patch and clear your browser cache if ncessary. Test pages in the OPAC and staff interface which use the "sticky" heading feature. As you scroll down the header should "stick" to the top of the viewport. For example: - Administration -> System preferences - Catalog -> Search results - Cataloging -> Basic MARC editor - Patrons -> Add or edit patron - Lists -> List contents In the OPAC: - Catalog search results - Lists -> List contents Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 14:11:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 13:11:39 +0000 Subject: [Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 Hammat wele changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160126|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 14:13:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 13:13:02 +0000 Subject: [Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 14:13:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 13:13:04 +0000 Subject: [Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160301|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 160530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160530&action=edit Bug 35086: Add chunk_size option to elasticsearch configuration Whne performing batch operations we can send a large numebr of records for reindexing at once. Currently this can create requetss that are too large for Elasticsearch to process. We need to break these requests into chunks/ This patch adds a chunk_size configuration to the elasticsearch stanza in koha-conf.xml If blank we default to 5000. To test: 0 - Have Koha using Elasticsearch 1 - Create and download a report of all barcodes: SELECT barcode FROM items 2 - Batch modify these items 3 - Note a single ESindexing job is created 4 - Create and download a report of all authority ids: SELECT auth_header.authid FROM auth_header 5 - Setup a marc modification template, and batch modify all the authorities 6 - Again note a single ES backgorund job is created 7 - Apply patch 8 - Repeat the modifications above - you still get a single job 9 - Edit koha-conf.xml and add 250 to elasticsearch stanza 10 - Repeat modifications - you now get several background ES jobs 11 - prove -v t/db_dependent/Koha/SearchEngine/Elasticsearch/Indexer.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 14:13:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 13:13:06 +0000 Subject: [Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086 --- Comment #7 from Nick Clemens --- Created attachment 160531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160531&action=edit Bug 35086: Also split chunks when indexing from background job The es background indexer is designed to combine background jobs when started based on the 'batch_size' option. While this is helpful for combining individual updates, it can be problematic when there are several large batch modifications, or when worker has stopped and is restarted. This patch uses the same logic as in the indexer to split the chunks that are sent directly for indexing. To test: 1 - Follow test plan on previous patch 2 - Confirm items are correctly indexed and jobs marked -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 14:13:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 13:13:09 +0000 Subject: [Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086 --- Comment #8 from Nick Clemens --- Created attachment 160532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160532&action=edit Bug 35086: Tidy tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 14:23:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 13:23:11 +0000 Subject: [Koha-bugs] [Bug 35477] Adding non-existent items to the waiting list should display a warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35477 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160387|0 |1 is obsolete| | Attachment #160388|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart --- Created attachment 160533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160533&action=edit Bug 35477: Show a warning when non-existent items are added to the waiting list Only messages "X new items added" or "No items added" were displayed. With this patch we will display: A warning with "No items added" A warning with "X new items added. Y items not found." when some items have not been added A messages "X new items added" when everything went well Signed-off-by: Matt Blenkinsop Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 14:23:25 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 13:23:25 +0000 Subject: [Koha-bugs] [Bug 35477] Adding non-existent items to the waiting list should display a warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35477 --- Comment #17 from Jonathan Druart --- Tidying inline. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 14:28:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 13:28:46 +0000 Subject: [Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 --- Comment #18 from Hammat wele --- Created attachment 160534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160534&action=edit Bug 33317: (follow-up) Perltidy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 14:30:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 13:30:21 +0000 Subject: [Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 Hammat wele changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 14:32:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 13:32:26 +0000 Subject: [Koha-bugs] [Bug 35342] Use a Makefile to manage PO files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35342 --- Comment #4 from Jonathan Druart --- Could you consider providing a perl script instead? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 14:36:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 13:36:17 +0000 Subject: [Koha-bugs] [Bug 35342] Use a Makefile to manage PO files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35342 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35332 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 14:36:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 13:36:17 +0000 Subject: [Koha-bugs] [Bug 35332] gulp po:update (may) generates incorrect Koha-messages.pot In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35332 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35342 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 14:38:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 13:38:45 +0000 Subject: [Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha at gmail. |pedro.amorim at ptfs-europe.co |com |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 14:51:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 13:51:31 +0000 Subject: [Koha-bugs] [Bug 35342] Use a Makefile to manage PO files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35342 --- Comment #5 from Julian Maurice --- (In reply to Jonathan Druart from comment #4) > Could you consider providing a perl script instead? :) Why ? I remember we talked about the readability issue on IRC but that can be fixed. Is there something else ? A Makefile seems like the best tool for this job -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 15:42:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 14:42:45 +0000 Subject: [Koha-bugs] [Bug 32233] Cannot add a guarantor when patron attributes have certain characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32233 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #6 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 32675 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 15:42:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 14:42:45 +0000 Subject: [Koha-bugs] [Bug 32675] Cannot add a guarantor when there is a single quote in the guarantor attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32675 --- Comment #15 from Jonathan Druart --- *** Bug 32233 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 15:44:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 14:44:09 +0000 Subject: [Koha-bugs] [Bug 35461] Renew All 66 SIP server response messages produce HASH content in replies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35461 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 15:53:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 14:53:35 +0000 Subject: [Koha-bugs] [Bug 35701] New: Cannot use i18n.inc from MACRO block? Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35701 Bug ID: 35701 Summary: Cannot use i18n.inc from MACRO block? Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Not sure what's going on, but I am experiencing something weird. Add [% SET xxx = t("foo") %] console.log("[% xxx %]"); inside a js include [% MACRO jsinclude BLOCK %] And you will see "Ms", instead of "foo". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 15:53:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 14:53:49 +0000 Subject: [Koha-bugs] [Bug 35701] Cannot use i18n.inc from MACRO block? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35701 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 15:56:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 14:56:03 +0000 Subject: [Koha-bugs] [Bug 35701] Cannot use i18n.inc from MACRO block? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35701 --- Comment #1 from Jonathan Druart --- Created attachment 160535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160535&action=edit Bug 35701: DO NOT PUSH - to recreate the problem Hit http://localhost:8081/cgi-bin/koha/members/memberentry.pl open the console See "Ms", while we expect "foo" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:01:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:01:02 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 --- Comment #46 from Martin Renvoize --- Created attachment 160536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160536&action=edit Bug 28294: [ALT] Remove updateWrongTransfer This patch removes the last remaining use of updateWrongTransfer and the method itself. We replace it with a call to request_transfer that passes the 'replace' reason of 'WrongTransfer' through to Koha::Item::Transfer->cancel. Test plan 1/ git grep updateWrongTransfer to confirm there are no more uses of the method. 2/ Confirm an incorrect transfer still behaves as expected at circulation returns. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:02:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:02:14 +0000 Subject: [Koha-bugs] [Bug 35701] Cannot use i18n.inc from MACRO block? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35701 --- Comment #2 from Julian Maurice --- There's a [% FOREACH t ... %] earlier in the same file. It probably overrides the t function. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:13:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:13:09 +0000 Subject: [Koha-bugs] [Bug 35702] New: Reduce DB calls when performing authorities merge Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35702 Bug ID: 35702 Summary: Reduce DB calls when performing authorities merge Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org We are individually fetching each biblio, we can do this in a single call We also fetch the frameworkcode from the DB for each biblio - we can just use the field from the object we have already fetched -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:15:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:15:13 +0000 Subject: [Koha-bugs] [Bug 35702] Reduce DB calls when performing authorities merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35702 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:15:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:15:15 +0000 Subject: [Koha-bugs] [Bug 35702] Reduce DB calls when performing authorities merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35702 --- Comment #1 from Nick Clemens --- Created attachment 160537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160537&action=edit Bug 35702: Use framework code from biblio object -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:15:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:15:17 +0000 Subject: [Koha-bugs] [Bug 35702] Reduce DB calls when performing authorities merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35702 --- Comment #2 from Nick Clemens --- Created attachment 160538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160538&action=edit Bug 35702: Fetch biblios at once and loop Test plan: prove -v t/db_dependent/Authority/Merge.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:16:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:16:47 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #47 from Martin Renvoize --- I like the alternative a lot better.. simpler DRYer code. Setting back to NSO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:17:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:17:15 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160516|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:17:25 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:17:25 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160517|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:17:34 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:17:34 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160518|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:17:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:17:42 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160519|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:17:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:17:50 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160520|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:18:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:18:03 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160521|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:20:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:20:01 +0000 Subject: [Koha-bugs] [Bug 35701] Cannot use i18n.inc from MACRO block? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35701 --- Comment #3 from Jonathan Druart --- erk good catch, I searched for "t = "! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:20:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:20:54 +0000 Subject: [Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:20:56 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:20:56 +0000 Subject: [Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150420|0 |1 is obsolete| | Attachment #158820|0 |1 is obsolete| | Attachment #160534|0 |1 is obsolete| | --- Comment #19 from Owen Leonard --- Created attachment 160539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160539&action=edit Bug 33317: Add system preference to set meta robots for the OPAC Websites must have a robots meta tag to improve search engine crawling, so we could tell search engines to not index OPAC pages for example. To test: 1) Look at opac-main source and see that meta name=robots is missing. 2) Apply patch. 3) Run ./installer/data/mysql/updatedatabase.pl 4) Go to system preferences > OPAC and add some directives to OpacMetaRobots (ex: noindex,nofollow). 5) Look at opac-main source and confirm that meta name=robots now has content equal to the text set in the OpacMetaRobots system preference. 6) This should Prevent search engines from indexing Opac pages (if OpacMetaRobots is set to noindex) Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:20:58 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:20:58 +0000 Subject: [Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 --- Comment #20 from Owen Leonard --- Created attachment 160540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160540&action=edit Bug 33317: Using checkoxes in OpacMetaRobots preference system to prevent incorrect data entry Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:21:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:21:01 +0000 Subject: [Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 --- Comment #21 from Owen Leonard --- Created attachment 160541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160541&action=edit Bug 33317: (follow-up) Perltidy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:23:34 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:23:34 +0000 Subject: [Koha-bugs] [Bug 35701] Cannot use i18n.inc from MACRO block? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35701 --- Comment #4 from Jonathan Druart --- Thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:24:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:24:18 +0000 Subject: [Koha-bugs] [Bug 30745] ES : Search never return result using after-date and/or before-date in labels/label-item-search.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Marie-Luce Laflamme changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie-luce.laflamme at inlibro | |.com --- Comment #18 from Marie-Luce Laflamme --- Is there a kind volunteer who could spare some time to test this rebased patch? Your feedback is much appreciated. Cheers! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:34:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:34:08 +0000 Subject: [Koha-bugs] [Bug 35694] Give pages the option to be a page or modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35694 Brendan Lawlor changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor at clamsnet.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:37:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:37:50 +0000 Subject: [Koha-bugs] [Bug 34234] Item groups dropdown in detail page modal does not respect display order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34234 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160442|0 |1 is obsolete| | --- Comment #10 from Lucas Gass --- Created attachment 160542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160542&action=edit Bug 34234: add a unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:44:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:44:27 +0000 Subject: [Koha-bugs] [Bug 35584] Missing licenses in about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #12 from Katrin Fischer --- It looks like a double up: jQuery UI Virtual Keyboard Virtual Keyboard Same version and link? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:53:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:53:35 +0000 Subject: [Koha-bugs] [Bug 34900] The translation of the string "The " should depend on context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:53:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:53:37 +0000 Subject: [Koha-bugs] [Bug 34900] The translation of the string "The " should depend on context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 --- Comment #30 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:53:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:53:39 +0000 Subject: [Koha-bugs] [Bug 35070] Koha plugins implementing "background_jobs" hook can't provide view template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35070 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:53:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:53:40 +0000 Subject: [Koha-bugs] [Bug 35070] Koha plugins implementing "background_jobs" hook can't provide view template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35070 --- Comment #17 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:53:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:53:42 +0000 Subject: [Koha-bugs] [Bug 35477] Adding non-existent items to the waiting list should display a warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35477 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:53:43 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:53:43 +0000 Subject: [Koha-bugs] [Bug 35477] Adding non-existent items to the waiting list should display a warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35477 --- Comment #18 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:53:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:53:45 +0000 Subject: [Koha-bugs] [Bug 35658] Typo in /patrons/:patron_id/holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35658 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:53:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:53:46 +0000 Subject: [Koha-bugs] [Bug 35658] Typo in /patrons/:patron_id/holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35658 --- Comment #4 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:53:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:53:48 +0000 Subject: [Koha-bugs] [Bug 35698] Wrong bug number in db_revs/220600084.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35698 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:53:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 15:53:49 +0000 Subject: [Koha-bugs] [Bug 35698] Wrong bug number in db_revs/220600084.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35698 --- Comment #2 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:05:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 16:05:36 +0000 Subject: [Koha-bugs] [Bug 34234] Item groups dropdown in detail page modal does not respect display order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34234 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160542|0 |1 is obsolete| | --- Comment #11 from Lucas Gass --- Created attachment 160543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160543&action=edit Bug 34234: add a unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:10:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 16:10:27 +0000 Subject: [Koha-bugs] [Bug 29471] MARC21: 520 - Summary etc. doesn't display in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:10:34 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 16:10:34 +0000 Subject: [Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:10:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 16:10:40 +0000 Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:10:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 16:10:47 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:10:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 16:10:54 +0000 Subject: [Koha-bugs] [Bug 32391] [DOCS] Reorganise the manual contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32391 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:13:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 16:13:45 +0000 Subject: [Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |lucas at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:15:43 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 16:15:43 +0000 Subject: [Koha-bugs] [Bug 33960] Add ability to retrieve deleted biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #37 from Owen Leonard --- I'm getting a couple warnings and a fail from the qa tool. Can you check? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:15:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 16:15:52 +0000 Subject: [Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 --- Comment #22 from Lucas Gass --- Looks good now, passing QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:16:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 16:16:32 +0000 Subject: [Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:16:34 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 16:16:34 +0000 Subject: [Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160539|0 |1 is obsolete| | --- Comment #23 from Lucas Gass --- Created attachment 160544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160544&action=edit Bug 33317: Add system preference to set meta robots for the OPAC Websites must have a robots meta tag to improve search engine crawling, so we could tell search engines to not index OPAC pages for example. To test: 1) Look at opac-main source and see that meta name=robots is missing. 2) Apply patch. 3) Run ./installer/data/mysql/updatedatabase.pl 4) Go to system preferences > OPAC and add some directives to OpacMetaRobots (ex: noindex,nofollow). 5) Look at opac-main source and confirm that meta name=robots now has content equal to the text set in the OpacMetaRobots system preference. 6) This should Prevent search engines from indexing Opac pages (if OpacMetaRobots is set to noindex) Signed-off-by: Owen Leonard Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:16:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 16:16:37 +0000 Subject: [Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160540|0 |1 is obsolete| | --- Comment #24 from Lucas Gass --- Created attachment 160545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160545&action=edit Bug 33317: Using checkoxes in OpacMetaRobots preference system to prevent incorrect data entry Signed-off-by: Owen Leonard Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:16:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 16:16:39 +0000 Subject: [Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160541|0 |1 is obsolete| | --- Comment #25 from Lucas Gass --- Created attachment 160546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160546&action=edit Bug 33317: (follow-up) Perltidy Signed-off-by: Owen Leonard Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:20:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 16:20:50 +0000 Subject: [Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds a new release notes| |system preference, | |OpacMetaRobots which allows | |libraries to tell search | |engine robots how to crawl | |and index OPAC pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:27:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 16:27:04 +0000 Subject: [Koha-bugs] [Bug 35703] New: Marking Lost card does not prevent patron from placing holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35703 Bug ID: 35703 Summary: Marking Lost card does not prevent patron from placing holds Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kkrueger at cuyahogalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 160547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160547&action=edit PatronAccountFlags On a patron's account page, under Library use > Patron account flags, the description above the account flags reads "Setting a value here will prevent patron from circulating materials and placing holds on the OPAC" We have found that setting the Lost card flag does not prevent a patron from placing holds. Ideally, the functionality of the flag should be updated so that holds are prevented by this flag, or the description of the flag should be updated to remove mention of holds. Having the ability to prevent patrons with a particular designation (restricted, lost, etc.) from placing holds as well as checking out or renewing would be helpful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:28:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 16:28:45 +0000 Subject: [Koha-bugs] [Bug 35696] Transit status not properly updated for items advanced in Stock Rotation tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35696 --- Comment #1 from Martin Renvoize --- Created attachment 160548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160548&action=edit Bug 35696: Fix regression caused by bug 33167 A case was missed when switching from item.transfer.field to just transfer.field. This meant that the daterequested date wasn't getting filled properly in the UI. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:29:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 16:29:50 +0000 Subject: [Koha-bugs] [Bug 35696] Transit status not properly updated for items advanced in Stock Rotation tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35696 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160548|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 160549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160549&action=edit Bug 35696: Fix regression caused by bug 33167 A case was missed when switching from item.transfer.field to just transfer.field. This meant that the daterequested date wasn't getting filled properly in the UI. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:31:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 16:31:30 +0000 Subject: [Koha-bugs] [Bug 35696] Transit status not properly updated for items advanced in Stock Rotation tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35696 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|normal |major Status|NEW |Needs Signoff Depends on| |33167 Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com --- Comment #3 from Martin Renvoize --- This is affecting all pending transfers.. it's just that stockrotation is the most obvious case where an item can be pending but not in transit. It's caused by bug 33167 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 [Bug 33167] Cleanup staff interface catalog details page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:31:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 16:31:30 +0000 Subject: [Koha-bugs] [Bug 33167] Cleanup staff interface catalog details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35696 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35696 [Bug 35696] Transit status not properly updated for items advanced in Stock Rotation tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:36:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 16:36:21 +0000 Subject: [Koha-bugs] [Bug 35694] Give pages the option to be a page or modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35694 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #1 from Lucas Gass --- Couldn't one just build a modal inside of a custom page? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:41:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 16:41:03 +0000 Subject: [Koha-bugs] [Bug 35692] ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 --- Comment #6 from Alex Buckley --- Hi Nick, There is one difference between this and bug 35293 (the patchset I wrote) and that is 35293 re-adds the reference to ONLYMESSAGE into the UpdateNotForLoanStatusOnCheckin system preference which was also lost between bug 30407 and bug 25560 : https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160361 Would you like me to copy that patch over to your bug report here? Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:43:44 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 16:43:44 +0000 Subject: [Koha-bugs] [Bug 35696] Transit status not properly updated for items advanced in Stock Rotation tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35696 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #4 from Lucas Gass --- Fix works good and is trivial. I think this can go straight PQA, let's get this fix in asap! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:44:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 16:44:19 +0000 Subject: [Koha-bugs] [Bug 35696] Transit status not properly updated for items advanced in Stock Rotation tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35696 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160549|0 |1 is obsolete| | --- Comment #5 from Lucas Gass --- Created attachment 160550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160550&action=edit Bug 35696: Fix regression caused by bug 33167 A case was missed when switching from item.transfer.field to just transfer.field. This meant that the daterequested date wasn't getting filled properly in the UI. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:44:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 16:44:40 +0000 Subject: [Koha-bugs] [Bug 35696] Transit status not properly updated for items advanced in Stock Rotation tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35696 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version|23.05 |master Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:44:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 16:44:47 +0000 Subject: [Koha-bugs] [Bug 35696] Transit status not properly updated for items advanced in Stock Rotation tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35696 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:48:25 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 16:48:25 +0000 Subject: [Koha-bugs] [Bug 22567] Stock rotation manage rotas should show items current and desired locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22567 --- Comment #5 from Martin Renvoize --- Created attachment 160551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160551&action=edit Bug 22567: Add transfer details to stockrotation page This patch adds any pending/current transfer details into the stockrotation item management page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:48:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 16:48:42 +0000 Subject: [Koha-bugs] [Bug 22567] Stock rotation manage rotas should show items current and desired locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22567 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:48:56 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 16:48:56 +0000 Subject: [Koha-bugs] [Bug 22567] Stock rotation manage rotas should show items current and desired locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22567 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:49:10 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 16:49:10 +0000 Subject: [Koha-bugs] [Bug 22567] Stock rotation manage rotas should show items current and desired locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22567 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:49:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 16:49:18 +0000 Subject: [Koha-bugs] [Bug 22567] Stock rotation manage rotas should show items current and desired locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22567 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 18:21:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 17:21:49 +0000 Subject: [Koha-bugs] [Bug 35673] A booking impacts due date of other checked out items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35673 Esther Melander changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #3 from Esther Melander --- After further testing, it appears the behavior I was seeing was due to a library specific circulation rule with 0 days for loan length. Removing that rule removed the behavior. Marking this as resolved for now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 18:26:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 17:26:08 +0000 Subject: [Koha-bugs] [Bug 25446] Terminology: Replace relatives by other term? (family members, group members...) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25446 --- Comment #2 from Aude Charillon --- I've seen the term "Linked accounts" used elsewhere and it works. I quite like "relatives" because I tend to interpret it in a wider sense - people who have some relation to each other - rather than as "blood relatives". But a native English speaker may have a different point of view! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 18:31:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 17:31:48 +0000 Subject: [Koha-bugs] [Bug 35692] ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 --- Comment #7 from Nick Clemens --- (In reply to Alex Buckley from comment #6) > Hi Nick, > > There is one difference between this and bug 35293 (the patchset I wrote) > and that is 35293 re-adds the reference to ONLYMESSAGE into the > UpdateNotForLoanStatusOnCheckin system preference which was also lost > between bug 30407 and bug 25560 : > https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160361 > > Would you like me to copy that patch over to your bug report here? > > Thanks, > Alex Hi Alex, either way works, you could also just copy my unit test over to the other and then mark them duplicate. I didn't see yours initially because the depends on wasn't marked :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 18:37:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 17:37:24 +0000 Subject: [Koha-bugs] [Bug 25446] Terminology: Replace relatives by other term? (family members, group members...) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25446 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #3 from Katrin Fischer --- (In reply to Aude Charillon from comment #2) > I've seen the term "Linked accounts" used elsewhere and it works. > > I quite like "relatives" because I tend to interpret it in a wider sense - > people who have some relation to each other - rather than as "blood > relatives". But a native English speaker may have a different point of view! Hi Aude, that's interesting! I didn't look at it like that, as I automatically "translate" it to another term in German. Maybe we should consider using a different German translation :) I'd also be interested to get some native speaker opinions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 18:54:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 17:54:16 +0000 Subject: [Koha-bugs] [Bug 33960] Add ability to retrieve deleted biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #38 from Nick Clemens --- (In reply to Owen Leonard from comment #37) > I'm getting a couple warnings and a fail from the qa tool. Can you check? You can ignore the fail, the warnings should be cleared by tidy patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 19:10:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 18:10:49 +0000 Subject: [Koha-bugs] [Bug 35310] Current renewals 'view' link doesnt work if renewals correspond to an item no longer checked out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35310 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | CC| |lucas at bywatersolutions.com --- Comment #41 from Lucas Gass --- Backported to 23.05.x for upcoming 23.07.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 19:13:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 18:13:19 +0000 Subject: [Koha-bugs] [Bug 35498] SQL auto-complete should not prevent use of tab for spacing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #14 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 19:15:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 18:15:06 +0000 Subject: [Koha-bugs] [Bug 35428] gulp po tasks do not clean temporary files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35428 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 19:37:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 18:37:57 +0000 Subject: [Koha-bugs] [Bug 35694] Give pages the option to be a page or modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35694 --- Comment #2 from Christopher Brannon --- You could, if you want the modal on top of that page. But if you want the modal to pop up on some pre-existing page, it would need a little more work. Like if I was going to add some information that pops up from the Circulation page or Cataloging page, where I don't want to navigate away, and instead just have that information come up wherever that link was, that would be a little more complex. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 19:41:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 18:41:55 +0000 Subject: [Koha-bugs] [Bug 35556] selenium/administration_tasks.t failing if too many patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35556 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #4 from Lucas Gass --- Jonathan, It looks like this code already exists on 23.05? But how could that be? Please advise. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 19:43:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 18:43:20 +0000 Subject: [Koha-bugs] [Bug 35468] Bookings permission mismatch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35468 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #27 from Lucas Gass --- Dependencies missing for 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 19:47:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 18:47:03 +0000 Subject: [Koha-bugs] [Bug 35488] Placing a hold on the OPAC takes the user to their account page, but does not activate the holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35488 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 19:48:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 18:48:46 +0000 Subject: [Koha-bugs] [Bug 35492] Suspending/unsuspending a hold on the OPAC takes the user to their account page, but does not activate the holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35492 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | --- Comment #7 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 19:50:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 18:50:30 +0000 Subject: [Koha-bugs] [Bug 35495] Cancelling a hold on the OPAC takes the user to their account page, but does not activate the holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35495 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | --- Comment #7 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 19:51:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 18:51:50 +0000 Subject: [Koha-bugs] [Bug 35496] Placing an article request on the OPAC takes the user to their account page, but does not activate the article request tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35496 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | --- Comment #8 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 20:00:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 19:00:11 +0000 Subject: [Koha-bugs] [Bug 33960] Add ability to retrieve deleted biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160002|0 |1 is obsolete| | --- Comment #39 from Nick Clemens --- Created attachment 160552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160552&action=edit Bug 33960: Tidy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 20:25:29 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 19:25:29 +0000 Subject: [Koha-bugs] [Bug 35293] Regression: Bug 33390 (QA follow-up) patch overwrote the template changes to bug 25560 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 20:25:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 19:25:31 +0000 Subject: [Koha-bugs] [Bug 35293] Regression: Bug 33390 (QA follow-up) patch overwrote the template changes to bug 25560 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160361|0 |1 is obsolete| | Attachment #160362|0 |1 is obsolete| | --- Comment #15 from Nick Clemens --- Created attachment 160553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160553&action=edit Bug 35293: Add ONLYMESSAGE back into UpdateNotForLoanStatusOnCheckin syspref description Sponsored-by: Catalyst IT, New Zealand Signed-off-by: Anneli Österman Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 20:25:33 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 19:25:33 +0000 Subject: [Koha-bugs] [Bug 35293] Regression: Bug 33390 (QA follow-up) patch overwrote the template changes to bug 25560 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 --- Comment #16 from Nick Clemens --- Created attachment 160554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160554&action=edit Bug 35293: Re-implement bug 30407 functionality To test: 1. Set a book items notforloan status as -1 and set the AllowNotForLoanOverride system preference to 'Allow' 2. Add the following lines to UpdateNotForLoanStatusOnCheckin (the formatting and indentation is important to keep): BK: -1: ONLYMESSAGE 3. Check a book item out for patron. 4. Check book item in. => Description of notforloan status should be displayed under 'Check in message'. => Confirm notforloan status HAS changed. 5. Apply patch and update database if needed 6. Set book items notforloan status as -1 (or create new one) 7. Check book item out for patron. 8. Check book item in. => Description of notforloan status should be displayed under 'Check in message'. => Confirm notforloan status HAS NOT changed. Also prove t/db_dependent/Circulation/issue.t Sponsored-by: Catalyst IT, New Zealand Signed-off-by: Anneli Österman Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 20:25:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 19:25:35 +0000 Subject: [Koha-bugs] [Bug 35293] Regression: Bug 33390 (QA follow-up) patch overwrote the template changes to bug 25560 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 --- Comment #17 from Nick Clemens --- Created attachment 160555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160555&action=edit Bug 35293: (follow-up) Handle all rules as well Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 20:25:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 19:25:37 +0000 Subject: [Koha-bugs] [Bug 35293] Regression: Bug 33390 (QA follow-up) patch overwrote the template changes to bug 25560 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 --- Comment #18 from Nick Clemens --- Created attachment 160556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160556&action=edit Bug 35293: Unit test Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 20:25:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 19:25:49 +0000 Subject: [Koha-bugs] [Bug 35692] ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Signed Off |RESOLVED --- Comment #8 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 35293 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 20:25:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 19:25:49 +0000 Subject: [Koha-bugs] [Bug 35293] Regression: Bug 33390 (QA follow-up) patch overwrote the template changes to bug 25560 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #19 from Nick Clemens --- *** Bug 35692 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 20:26:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 19:26:14 +0000 Subject: [Koha-bugs] [Bug 35293] Regression: Bug 33390 (QA follow-up) patch overwrote the template changes to bug 25560 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30407, 25560 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 [Bug 30407] Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 20:26:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 19:26:14 +0000 Subject: [Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35293 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 [Bug 35293] Regression: Bug 33390 (QA follow-up) patch overwrote the template changes to bug 25560 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 20:26:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 19:26:14 +0000 Subject: [Koha-bugs] [Bug 30407] Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35293 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 [Bug 35293] Regression: Bug 33390 (QA follow-up) patch overwrote the template changes to bug 25560 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 20:27:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 19:27:18 +0000 Subject: [Koha-bugs] [Bug 35684] Koha XSLT material type icons documentation needs updating In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35684 --- Comment #2 from Esther Melander --- Some additional documentation is needed to also explain how to trigger Article, and Sets Material Type. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 20:34:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 19:34:15 +0000 Subject: [Koha-bugs] [Bug 35692] ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 --- Comment #9 from Alex Buckley --- (In reply to Nick Clemens from comment #7) > (In reply to Alex Buckley from comment #6) > > Hi Nick, > > > > There is one difference between this and bug 35293 (the patchset I wrote) > > and that is 35293 re-adds the reference to ONLYMESSAGE into the > > UpdateNotForLoanStatusOnCheckin system preference which was also lost > > between bug 30407 and bug 25560 : > > https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160361 > > > > Would you like me to copy that patch over to your bug report here? > > > > Thanks, > > Alex > > Hi Alex, either way works, you could also just copy my unit test over to the > other and then mark them duplicate. I didn't see yours initially because the > depends on wasn't marked :-) Thanks so much Nick for making those changes! Apologies for not marking the depends on for bug 35293 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:06:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:06:24 +0000 Subject: [Koha-bugs] [Bug 35507] Fix handling plugins in unit tests causing random failures on Jenkins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #69 from Lucas Gass --- Doesn't apply cleanly to 23.05.x, no backport. If needed please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:08:28 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:08:28 +0000 Subject: [Koha-bugs] [Bug 18139] 'Too many checked out' can confuse librarians In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |lucas at bywatersolutions.com --- Comment #35 from Lucas Gass --- Doesn't apply cleanly to 23.05.x, will not backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:10:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:10:03 +0000 Subject: [Koha-bugs] [Bug 35476] Submit button for adding new processings is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35476 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #10 from Lucas Gass --- Not needed in 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:13:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:13:37 +0000 Subject: [Koha-bugs] [Bug 35523] Fix doubled up quotes in cash register deletion confirmation message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35523 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #8 from Lucas Gass --- Not needed in 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:15:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:15:01 +0000 Subject: [Koha-bugs] [Bug 35524] Terminology: Bookseller in basket group CSV export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35524 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #7 from Lucas Gass --- Doesn't apply cleanly in 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:16:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:16:17 +0000 Subject: [Koha-bugs] [Bug 35525] Spelling: SMS is an abbreviation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35525 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass --- Doesn't apply cleanly to 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:17:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:17:06 +0000 Subject: [Koha-bugs] [Bug 35526] Terminology: Id, sushi and counter are abbreviations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35526 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com Resolution|--- |FIXED --- Comment #6 from Lucas Gass --- Doesn't apply cleanly to 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:18:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:18:22 +0000 Subject: [Koha-bugs] [Bug 35528] Avoid 'click' for links in system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35528 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #6 from Lucas Gass --- Doesn't apply cleanly to 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:18:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:18:22 +0000 Subject: [Koha-bugs] [Bug 35527] [Omnibus] Accessibility: Don't use "Click" in link descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35527 Bug 35527 depends on bug 35528, which changed state. Bug 35528 Summary: Avoid 'click' for links in system preferences https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35528 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:20:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:20:09 +0000 Subject: [Koha-bugs] [Bug 35413] Terminology: differentiate issues for vendor issues and serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35413 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #10 from Lucas Gass --- Doesn't apply cleanly to 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:21:10 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:21:10 +0000 Subject: [Koha-bugs] [Bug 35574] Bookings page should require only manage_bookings permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |lucas at bywatersolutions.com --- Comment #24 from Lucas Gass --- Missing dependencies for 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:23:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:23:04 +0000 Subject: [Koha-bugs] [Bug 35489] Holds on items with no barcode are missing an input for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass --- Please rebase this for 23.05.x if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:25:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:25:22 +0000 Subject: [Koha-bugs] [Bug 35204] REST API: POST endpoint /auth/password/validation dies on patron with expired password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35204 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #16 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:28:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:28:52 +0000 Subject: [Koha-bugs] [Bug 35405] MarcAuthorities: Use of uninitialized value $tag in hash element at MARC/Record.pm line 202. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35405 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:30:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:30:55 +0000 Subject: [Koha-bugs] [Bug 35216] Use return variable names from CanBookBeIssued in circulation.pl for consistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35216 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com Resolution|--- |FIXED --- Comment #30 from Lucas Gass --- Doesn't apply clean to 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:31:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:31:18 +0000 Subject: [Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:31:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:31:20 +0000 Subject: [Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160514|0 |1 is obsolete| | Attachment #160515|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 160557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160557&action=edit Bug 35100: Unit tests This patch adds a unit test to ensure StockrotationAdvance transfers are not cancelled from request_transfer when called with 'replace'. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:31:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:31:22 +0000 Subject: [Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 --- Comment #4 from Nick Clemens --- Created attachment 160558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160558&action=edit Bug 35100: Prevent StockrotationAdvance transfers from being cancelled ModItemTransfer is still very heavy handed and outright overrules existing transfers in the queue. For StockrotationAdvance transfers it's important that they remain in the queue to get actioned later, even if a higher precident transfer is actions in the interim. This patch adds a clause to the cancellation call within request_transfer such that StockrationAdvance transfers are left in tact for the next time the item is checked in. Test plan 1) Item is added to stock rotation 2) The cronjob creates a 'StockRotationAdvance' transfer 3) The item is checked in, which initiates the transfer, however, a hold is triggered 4) The hold is confirmed, which replaces the StockRotationAdvance 5) The item is checked out 6) The item is checked in, which initiates the transfer again 6) The item is checked in at it's destination and the StockrotationAdvance transfer has the proper date arrived date set. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:32:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:32:50 +0000 Subject: [Koha-bugs] [Bug 35309] Remove DT's fnSetFilteringDelay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35309 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | --- Comment #8 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:35:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:35:50 +0000 Subject: [Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | --- Comment #55 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:36:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:36:06 +0000 Subject: [Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 --- Comment #5 from Nick Clemens --- To recreate: 1 - Create a rota, CPL->FFL->IPT 2 - Add an item from Midway to the rota 3 - perl misc/cronjobs/stockrotation.pl -x 4 - Check the db - you have a stock roation transfer to CPL 5 - Place a hold for pickup at Union 6 - Check the item in at midway, confirm the hold and transfer 7 - Note there are 2 transfers in the DB, one for the and one for stock rotation I am signing this off as it does fix the problem, there are 2 issues to note though: - The pop for the holds transfer correctly shows where to transfer the item, however, it shows the reason as 'StockRotation' when it should be 'Reserve' - After the transfer is created for the hold, 2 transfers exist - the original stock rotation, and the hold transfer. The detail page seems to look at the earliest, so the item shows it is in transit to the rotation branch, rather than the branch of the request we are trying to fill - this will cause confusion and delay -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:39:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:39:39 +0000 Subject: [Koha-bugs] [Bug 22567] Stock rotation manage rotas should show items current and desired locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22567 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:39:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:39:41 +0000 Subject: [Koha-bugs] [Bug 22567] Stock rotation manage rotas should show items current and desired locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22567 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160551|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 160559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160559&action=edit Bug 22567: Add transfer details to stockrotation page This patch adds any pending/current transfer details into the stockrotation item management page. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:40:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:40:15 +0000 Subject: [Koha-bugs] [Bug 33847] Database update replaces undefined rules with defaults rather than the value that would be used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #27 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:49:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:49:02 +0000 Subject: [Koha-bugs] [Bug 35491] Reverting waiting status for holds is not logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35491 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | --- Comment #7 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:49:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:49:45 +0000 Subject: [Koha-bugs] [Bug 35592] Missing closing div tag in bookings alert in circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35592 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #8 from Lucas Gass --- Missing dependencies for 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:52:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:52:47 +0000 Subject: [Koha-bugs] [Bug 35600] Prevent checkouts table to flicker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35600 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #11 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:53:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:53:47 +0000 Subject: [Koha-bugs] [Bug 35417] Update breadcrumbs and page titles for vendor issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35417 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass --- Doesn't apply cleanly to 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:56:28 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:56:28 +0000 Subject: [Koha-bugs] [Bug 34644] Add clarifying text to sysprefs to indicate that MarcFieldsToOrder is a fallback to MarcItemFieldsToOrder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34644 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #19 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:57:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:57:21 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Needs documenting --- Comment #34 from Lucas Gass --- Missing dependencies for 23.05.08, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 21:59:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 20:59:22 +0000 Subject: [Koha-bugs] [Bug 35493] Housebound roles show as a collapsed field option when checked in CollapseFieldsPatronAddForm, even if housebound is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35493 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #8 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 22:01:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 21:01:18 +0000 Subject: [Koha-bugs] [Bug 35455] ICU does not strip = when indexing/searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35455 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 22:02:23 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 21:02:23 +0000 Subject: [Koha-bugs] [Bug 35529] Avoid 'click' for links in library administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35529 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #6 from Lucas Gass --- Doesn't apply clean to 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 22:02:23 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 21:02:23 +0000 Subject: [Koha-bugs] [Bug 35527] [Omnibus] Accessibility: Don't use "Click" in link descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35527 Bug 35527 depends on bug 35529, which changed state. Bug 35529 Summary: Avoid 'click' for links in library administration https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35529 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 22:04:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 21:04:27 +0000 Subject: [Koha-bugs] [Bug 35619] Change password form in patron account has misaligned validation errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35619 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | --- Comment #6 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 22:05:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 21:05:30 +0000 Subject: [Koha-bugs] [Bug 33722] Cannot see existing public lists from virtualshelves/addbybiblionumber.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #14 from Lucas Gass --- *** This bug has been marked as a duplicate of bug 35547 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 22:05:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 21:05:30 +0000 Subject: [Koha-bugs] [Bug 35547] When using "Add to a list" button with more than 10 lists, "staff only" does not show up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35547 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass --- *** Bug 33722 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 22:06:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 21:06:39 +0000 Subject: [Koha-bugs] [Bug 35547] When using "Add to a list" button with more than 10 lists, "staff only" does not show up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35547 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | --- Comment #9 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 22:06:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 21:06:50 +0000 Subject: [Koha-bugs] [Bug 35547] When using "Add to a list" button with more than 10 lists, "staff only" does not show up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35547 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33722 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 [Bug 33722] Cannot see existing public lists from virtualshelves/addbybiblionumber.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 22:06:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 21:06:50 +0000 Subject: [Koha-bugs] [Bug 33722] Cannot see existing public lists from virtualshelves/addbybiblionumber.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|35547 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35547 [Bug 35547] When using "Add to a list" button with more than 10 lists, "staff only" does not show up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 22:09:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 21:09:50 +0000 Subject: [Koha-bugs] [Bug 35557] LoadResultsCovers is not used (staff) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35557 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #8 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 22:14:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 21:14:19 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #35 from Caroline Cyr La Rose --- There is nothing to add to the manual for this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 22:22:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 21:22:09 +0000 Subject: [Koha-bugs] [Bug 35704] New: Parent and child itemtype hold limits not enforced as expected Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35704 Bug ID: 35704 Summary: Parent and child itemtype hold limits not enforced as expected Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: lisette.scheer at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Similar to bug 30324, the hold limits aren't enforced for parent/child item types. A parent limit doesn't seem to matter at all in this case. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 22:23:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 21:23:02 +0000 Subject: [Koha-bugs] [Bug 35704] Parent and child itemtype hold limits not enforced as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35704 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30324 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 22:23:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 21:23:02 +0000 Subject: [Koha-bugs] [Bug 30324] Parent and child itemtype checkout limits not enforced as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30324 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35704 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 22:34:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 21:34:52 +0000 Subject: [Koha-bugs] [Bug 35705] New: Add option to force patrons to receive digested notices Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35705 Bug ID: 35705 Summary: Add option to force patrons to receive digested notices Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: andrewfh at dubcolib.org QA Contact: testopia at bugs.koha-community.org We'd like to require all of our patrons who elect to receive due, pre-due, or hold available notices to receive the digested versions of those notices. It's currently possible to use jQuery to force the "Digest Only" box to be checked on patron edits, but it'd be better to have this defined in a system preference or something more formal. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 22:35:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 21:35:21 +0000 Subject: [Koha-bugs] [Bug 35705] Add option to force patrons to receive digested notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35705 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 22:39:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 21:39:37 +0000 Subject: [Koha-bugs] [Bug 30318] Cannot override default patron messaging preferences when creating a patron in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 22:52:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 21:52:31 +0000 Subject: [Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 22:52:34 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 21:52:34 +0000 Subject: [Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160530|0 |1 is obsolete| | --- Comment #9 from David Nind --- Created attachment 160560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160560&action=edit Bug 35086: Add chunk_size option to elasticsearch configuration Whne performing batch operations we can send a large numebr of records for reindexing at once. Currently this can create requetss that are too large for Elasticsearch to process. We need to break these requests into chunks/ This patch adds a chunk_size configuration to the elasticsearch stanza in koha-conf.xml If blank we default to 5000. To test: 0 - Have Koha using Elasticsearch 1 - Create and download a report of all barcodes: SELECT barcode FROM items 2 - Batch modify these items 3 - Note a single ESindexing job is created 4 - Create and download a report of all authority ids: SELECT auth_header.authid FROM auth_header 5 - Setup a marc modification template, and batch modify all the authorities 6 - Again note a single ES backgorund job is created 7 - Apply patch 8 - Repeat the modifications above - you still get a single job 9 - Edit koha-conf.xml and add 250 to elasticsearch stanza 10 - Repeat modifications - you now get several background ES jobs 11 - prove -v t/db_dependent/Koha/SearchEngine/Elasticsearch/Indexer.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 22:52:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 21:52:37 +0000 Subject: [Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160531|0 |1 is obsolete| | --- Comment #10 from David Nind --- Created attachment 160561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160561&action=edit Bug 35086: Also split chunks when indexing from background job The es background indexer is designed to combine background jobs when started based on the 'batch_size' option. While this is helpful for combining individual updates, it can be problematic when there are several large batch modifications, or when worker has stopped and is restarted. This patch uses the same logic as in the indexer to split the chunks that are sent directly for indexing. To test: 1 - Follow test plan on previous patch 2 - Confirm items are correctly indexed and jobs marked Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 22:52:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 21:52:40 +0000 Subject: [Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160532|0 |1 is obsolete| | --- Comment #11 from David Nind --- Created attachment 160562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160562&action=edit Bug 35086: Tidy tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 23:08:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 22:08:54 +0000 Subject: [Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086 --- Comment #12 from David Nind --- Here are the list of jobs from testing using a freshly started KTD: 0000-1316 - Before patch, for both item modification and authority record changes 1317-1318 - After patch, no chunking, item modifications 1319-2632 - After patch, no chunking, authority record changes ==> no change (as expected) to number of jobs after patch applied and no chunking set 2633-2635 - After patch, chunking (250), item modifications . 1 job for batch item modifications, 2 jobs for elastic search updates (1 batch of 250 and 1 batch of 161) 2636-3955 - After patch, chunking (250), authority record changes . 2636 - Batch authority record modification . 2637-3948 - Elasticsearch index updates for 1,312 individual bibliographic record updates . 3949-3955 - 6 batches of 250, 1 batch of 206 I'm assuming this is what is expected, feel free to change the bug status if it isn't. Testing notes: 1. I tested using ES8 (ktd --es8 up). 2. For the modification of bibliographic records, I updated the 'z - Public note' with some text. 3. For the modification of authority records, I had a rule to add some text to 680$i subfield. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 23:24:10 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 22:24:10 +0000 Subject: [Koha-bugs] [Bug 30260] Script which checks index should also check if the zebraqueue has uncommitted records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30260 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131582|0 |1 is obsolete| | --- Comment #9 from Aleisha Amohia --- Comment on attachment 131582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131582 Bug 30260: [GLOBAL REPO] Implement is_indexer_working check This patch has now been pushed to the global repo, so the other patch can be pushed to Koha. https://git.koha-community.org/Koha-community/global/commit/72308768457017c3ff48543c9a52295a064a7253 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 00:00:58 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 23:00:58 +0000 Subject: [Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 --- Comment #18 from Victor Grousset/tuxayo --- > Created attachment > Just a guess, we should wait for the ajax response before looking for > the element in the table. Wait, I'm really on this! Yes, that's one of things, at this same place. What is DT_delay for? (In reply to Jonathan Druart from comment #16) > (In reply to Victor Grousset/tuxayo from comment #14) > > Found some tactics that seem effective on test 'Encoding in session > > variables' > > and test 'Display circulation table correctly' > > Which ones? https://gitlab.com/tuxayo/Koha/-/commits/bug-35506-selenium-regressions.t-failing-randomly Here is a summary of what my WIP patch has: - After asking in Selenium and JavaScript chats, there must be added a way to know if a button is ready to be clicked on. Because $(document).ready() content is long enough so that Selenium can be faster to click on the button before it has it's callback set. The proper thing is something telling the users that the page is still loading or visibly showing that the button isn't ready. For lack of time to go for something on the UI side with a lot of uncertainties, setting a flag at the end of $(document).ready() is one line way to cover a whole page regardless of how many problematic buttons there are. So the idea is to set in the JS window._pageFullyReady and having the tests wait (with wait_for_page_fully_ready()) for it like wait_for_ajax does. And that can be used on other page by adding the same flag in their $(document).ready() callback. - Next, so yes wait_for_ajax is needed, but in the +2000 runs I did, dozens of times I got way more than 10 sec wait (noted in the comments next to the calls). For this I had to make max_retries a variable and not a constant so I started doing a getter/setter and messed things up with confusing various ways to do it in Perl and finally noticed that we had __PACKAGE__->mk_accessors ^^" - A weird thing about having to reload the checkouts page because it's not refreshed after doing a checkout! (more details in the code comment) - Needing wait_for_ajax to output a stack trace (can't even know which call fail otherwise) and take a screenshot on timeout So it's almost done. Questions: 1. What is DT_delay for? 2. I only though of it just now: instead of having the flag window._pageFullyReady, should the problematic buttons be hidden in the HTML? (and maybe have a dummy button with a loading icon in place to show the user that stuff it loading) And then the stuff in $(document).ready() makes them visible after setting the onclick callback. And the test just waits for the button to be visible instead of the flag to be set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 00:25:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 23:25:15 +0000 Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an effective_name method to patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Suzanne changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |smhodson123extra at yahoo.com --- Comment #52 from Suzanne --- Wow! There has been a lot of work on this! We are interested in being able to have the patron record show "Preferred Name" in quotation marks in the first position followed by first and middle names and then last name. So, for example, it might show as "Sammy" Suzanne Michelle Hodson, with everything being searchable and all showing up on the patron record side bar. My idea would be to let registering patrons fill in the first and middle name field and also the preferred name field and have them show up in that order on Koha, or let libraries choose how they would like the names to show up or whether to have them hidden, if that is possible. Thanks for the great efforts on this! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 00:36:58 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 23:36:58 +0000 Subject: [Koha-bugs] [Bug 35685] ILL - OPAC request creation error if submitted empty while ILLModuleDisclaimerByType is in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35685 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 00:37:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 23:37:01 +0000 Subject: [Koha-bugs] [Bug 35685] ILL - OPAC request creation error if submitted empty while ILLModuleDisclaimerByType is in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35685 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160456|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 160563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160563&action=edit Bug 35685: Fix after creation actions Test plan: 1) Install FreeForm and enable ILLModule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Configure ILLModuleDisclaimerByType, visit: /cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=ILLModuleDisclaimerByType Click "edit" and paste the example code into the sys pref value 3) Create a new OPAC ILL request, visit: /cgi-bin/koha/opac-illrequests.pl?method=create&backend=FreeForm 4) Dont put a type or branch, click 'Create', on the next screen click 'Submit' 5) Notice it explodes 6) Apply patch and repeat. It no longer explodes and now shows an error message. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 00:38:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2024 23:38:00 +0000 Subject: [Koha-bugs] [Bug 35685] ILL - OPAC request creation error if submitted empty while ILLModuleDisclaimerByType is in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35685 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- This does fix the issue, and I have signed off. However, some comments - not sure how hard these are to do or whether it depends on the ILL plugin (I'm assuming this is the case): 1. If the "Destination library" is not selected, then the message at the top says: "Please Note: Branch is a mandatory field.". In my view the error should match the UI, that is, instead of "Branch" it should say "Destination library is required" 2. The normal UI for forms in the OPAC (from what I can see) is to have "Required" under the field name, and then a message if mandatory fields are not completed. I assume that this depends on how the ILL plugin works/coded though. Testing notes (using KTD): 1. Make the ILL request using the OPAC! . Go to the OPAC . Log in as a patron . Make the request using the "Interlibrary loan requests" tab/section -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 01:05:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 00:05:04 +0000 Subject: [Koha-bugs] [Bug 33430] Suggestions.pl with several hundred items causes a slow loading screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Felicity Brown changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |felicity.brown at montgomeryco | |untymd.gov --- Comment #3 from Felicity Brown --- Would it be possible to have batch changes made by queuing them, like we have for batch item modification? So we could continue to work on other purchase suggestions while the last set of edits are updating? I find it grinds particularly badly when I'm trying to update several records from a page to assign a manager to them. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 06:40:58 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 05:40:58 +0000 Subject: [Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 --- Comment #19 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #18) > So it's almost done. Questions: > 1. What is DT_delay for? We want to make sure the AJAX request is there. In some cases (see bug 35284), the wait_for_ajax was called but the AJAX request was not triggered yet, so we didn't wait for it to finished. > 2. I only though of it just now: instead of having the flag > window._pageFullyReady, should the problematic buttons be hidden in the > HTML? (and maybe have a dummy button with a loading icon in place to show > the user that stuff it loading) And then the stuff in $(document).ready() > makes them visible after setting the onclick callback. And the test just > waits for the button to be visible instead of the flag to be set. We should not need more than wait_for_ajax here IMO. If it takes more than 10 sec then there is something wrong somewhere else. We could extend the delay specifically for this call. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 06:42:51 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 05:42:51 +0000 Subject: [Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086 --- Comment #13 from Jonathan Druart --- you have 500 in conf and 5000 in pm, is that expected? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 06:51:33 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 05:51:33 +0000 Subject: [Koha-bugs] [Bug 35556] selenium/administration_tasks.t failing if too many patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35556 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED Depends on| |35263 --- Comment #5 from Jonathan Druart --- It's not needed on 23.05 actually. Bug 35263 introduced some additional code in this block. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35263 [Bug 35263] Cannot update patron categories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 06:51:33 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 05:51:33 +0000 Subject: [Koha-bugs] [Bug 35263] Cannot update patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35263 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35556 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35556 [Bug 35556] selenium/administration_tasks.t failing if too many patron categories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 07:40:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 06:40:14 +0000 Subject: [Koha-bugs] [Bug 35514] Total prices not updated when importing records from staged file with multiple items added In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159656|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes --- Created attachment 160564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160564&action=edit Bug 35514: Fix costs update when adding multiple items from staged file Test plan: 1) Stage a file with records 2) Create a basket and add order line from imported records to go on neworderempty.pl 3) Choose to add one item and repeat the operation 4) See on form that the total cost is updated without update vendor price 5) Now add multiple items, for example, "2" you will see that the total cost is not updated and if you save "0" price will be set 6) Apply this patch and repeat step 5 Signed-off-by: Michał Dudzik -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 07:41:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 06:41:50 +0000 Subject: [Koha-bugs] [Bug 35514] Total prices not updated when importing records from staged file with multiple items added In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514 Michal Dudzik changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dudzikmichal at wp.pl Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 08:09:51 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 07:09:51 +0000 Subject: [Koha-bugs] [Bug 35070] Koha plugins implementing "background_jobs" hook can't provide view template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35070 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #18 from Jonathan Druart --- t/db_dependent/selenium/00-onboarding.t is failing I am seeing this in the logs: DBIx::Class::Storage::DBI::_dbh_execute(): Table 'koha_kohadev.plugin_data' doesn't exist at /kohadevbox/koha/Koha/Plugins.pm line 122 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 DBIx::Class::Exception::throw('DBIx::Class::Exception', 'Table \'koha_kohadev.plugin_data\' doesn\'t exist', 0) called at /usr/share/perl5/DBIx/Class/Schema.pm line 1118 DBIx::Class::Schema::throw_exception('Koha::Schema=HASH(0x55fc8aec4730)', 'Table \'koha_kohadev.plugin_data\' doesn\'t exist') called at /usr/share/perl5/DBIx/Class/Storage.pm line 113 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 08:09:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 07:09:55 +0000 Subject: [Koha-bugs] [Bug 35070] Koha plugins implementing "background_jobs" hook can't provide view template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35070 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 08:40:23 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 07:40:23 +0000 Subject: [Koha-bugs] [Bug 35070] Koha plugins implementing "background_jobs" hook can't provide view template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35070 --- Comment #19 from Julian Maurice --- Should we add a followup here or on a new bug report ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 08:47:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 07:47:42 +0000 Subject: [Koha-bugs] [Bug 35172] Order receiving error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35172 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud at orex.es --- Comment #4 from Hugo Agud --- Good morning, I have suffer the same issue... I have checked that this only happens in some orders, then it must be some metadata issue (my point of view) I have dumped database and restored in koha 23.11 and worked fine...caming back to 22.05 I have checked logs in koha 22.05.* [2024/01/05 01:18:13] [ERROR] GET /api/v1/acquisitions/orders: unhandled excepti on (Mojo::Exception)<> Koha::REST::Plugin::Exceptions::__ANON __ /usr/share/koha/lib/Koha/REST/Plugin/Exceptions.pm (73) I suspect it is an issue with metadata of the orders, checimg the code sub to_api { my ($self, $args) = @_; my $response = $self->SUPER::to_api($args); my $biblioitem = $self->biblioitem; I suspect it could be the biblioitem data, not presented in some recordS? I have added a else condition to ignore if there is no biblioitem I have edited the code and add a log warn [2024/01/05 01:43:10] [WARN] Biblio with biblionumber 13250 does not have a valid biblioitem object at /usr/share/koha/lib/Koha/Biblio.pm line 1108. And it works... I can confirm that there is no biblioitem with that biblionumber.. then it is a metadata issue -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 09:01:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 08:01:18 +0000 Subject: [Koha-bugs] [Bug 35701] Cannot use i18n.inc from MACRO block? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35701 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com Status|NEW |ASSIGNED Severity|major |trivial -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 09:07:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 08:07:16 +0000 Subject: [Koha-bugs] [Bug 35070] Koha plugins implementing "background_jobs" hook can't provide view template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35070 --- Comment #20 from Julian Maurice --- Created attachment 160565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160565&action=edit Bug 35070: Fix get_enabled_plugins when database is not created yet Koha::Plugins::get_enabled_plugins is called by Koha::Plugins::call which is called by C4::Templates->new, which is used in the web installer when the database is not created yet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 09:09:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 08:09:08 +0000 Subject: [Koha-bugs] [Bug 35070] Koha plugins implementing "background_jobs" hook can't provide view template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35070 --- Comment #21 from Julian Maurice --- I didn't try t/db_dependent/selenium/00-onboarding.t but I was able to reproduce the error by running the web installer. After the patch I was able to complete the installation and the onboarding process. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 10:06:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 09:06:42 +0000 Subject: [Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 --- Comment #6 from Martin Renvoize --- Thanks for the testing Nick, I had a feeling we might have some straggling issues from this so it got me digging back into the transfers tree.. at least some of those issues have my attention already. I'll post once I've identified the relevant bugs and code :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 10:15:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 09:15:46 +0000 Subject: [Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 --- Comment #7 from Martin Renvoize --- Hmm.. this sounds like the order_by in the relation isn't catching properly :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 10:31:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 09:31:19 +0000 Subject: [Koha-bugs] [Bug 35706] New: Typo "Amoung" in manual Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35706 Bug ID: 35706 Summary: Typo "Amoung" in manual Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Amount tendered: enter the actual amount handed to you by the patron. The amount tendered must be equal or greater than 'Amoung being paid'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 10:37:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 09:37:02 +0000 Subject: [Koha-bugs] [Bug 35685] ILL - OPAC request creation error if submitted empty while ILLModuleDisclaimerByType is in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35685 --- Comment #4 from Pedro Amorim --- (In reply to David Nind from comment #3) > This does fix the issue, and I have signed off. > > However, some comments - not sure how hard these are to do or whether it > depends on the ILL plugin (I'm assuming this is the case): > > 1. If the "Destination library" is not selected, then the message at the top > says: "Please Note: Branch is a mandatory field.". In my view the error > should match the UI, that is, instead of "Branch" it should say "Destination > library is required" > > 2. The normal UI for forms in the OPAC (from what I can see) is to have > "Required" under the field name, and then a message if mandatory fields are > not completed. I assume that this depends on how the ILL plugin works/coded > though. Hi David, thanks for testing! Your assumptions are correct. The form and its behavior is dependent on the specific ILL backend which the request is being created to, in this example it's FreeForm. In bug 35570 I'm submitting work to add FreeForm to Koha core, to become a backend available out of the box instead of it being required to install an external one in order to make use of the ILL module. I mention bug 35570 because once that's gone through, these sort of enhancements can be worked directly into Koha, and have at least the Koha native backend be consistent with everything else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 10:41:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 09:41:05 +0000 Subject: [Koha-bugs] [Bug 35706] Typo "Amoung" in manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35706 --- Comment #1 from Katrin Fischer --- There is another a little below: Change to give: if the amount tendered is greater than the amoung being paid -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 10:55:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 09:55:37 +0000 Subject: [Koha-bugs] [Bug 25253] Allow to apply modification template when exporting checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25253 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #3 from Fridolin Somers --- Must be applyed on top of Bug 24679 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 11:07:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 10:07:50 +0000 Subject: [Koha-bugs] [Bug 35685] ILL - OPAC request creation error if submitted empty while ILLModuleDisclaimerByType is in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35685 --- Comment #5 from David Nind --- (In reply to Pedro Amorim from comment #4) ... > Hi David, thanks for testing! > Your assumptions are correct. The form and its behavior is dependent on the > specific ILL backend which the request is being created to, in this example > it's FreeForm. > > In bug 35570 I'm submitting work to add FreeForm to Koha core, to become a > backend available out of the box instead of it being required to install an > external one in order to make use of the ILL module. > I mention bug 35570 because once that's gone through, these sort of > enhancements can be worked directly into Koha, and have at least the Koha > native backend be consistent with everything else. Thanks Pedro! I'll look at signing that one off over the next few days. I'll keep an eye out for other ILL bugs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 11:39:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 10:39:03 +0000 Subject: [Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 --- Comment #8 from Martin Renvoize --- Nope, the ordering works.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 12:04:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 11:04:49 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_6473=5D_Test_bug_for_Git-bz_?= =?utf-8?b?4pyUIOKdpCDimIU=?= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #271 from Slava Shishkin --- Created attachment 160566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160566&action=edit Bug 6473 - 3th Test bug for Git-bz ✔ ❤ ★ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 12:14:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 11:14:04 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_6473=5D_Test_bug_for_Git-bz_?= =?utf-8?b?4pyUIOKdpCDimIU=?= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Slava Shishkin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160566|0 |1 is obsolete| | --- Comment #272 from Slava Shishkin --- Created attachment 160567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160567&action=edit Bug 6473 - 3th Test bug for Git-bz ✔ ❤ ★ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 12:18:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 11:18:00 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_6473=5D_Test_bug_for_Git-bz_?= =?utf-8?b?4pyUIOKdpCDimIU=?= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Slava Shishkin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160567|0 |1 is obsolete| | --- Comment #273 from Slava Shishkin --- Created attachment 160568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160568&action=edit Bug 6473 - 3th Test bug for Git-bz ✔ ❤ ★ - test line for the commit message - and one more test line for message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 13:08:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 12:08:31 +0000 Subject: [Koha-bugs] [Bug 35707] New: Item statuses in the holdings table on biblio details should appear one per line Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35707 Bug ID: 35707 Summary: Item statuses in the holdings table on biblio details should appear one per line Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The item status field may contain more than one status message, but currently, those messages are one after the other as opposed to one above the other. It would be clearer to display them one above the other. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 13:09:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 12:09:18 +0000 Subject: [Koha-bugs] [Bug 35707] Item statuses in the holdings table on biblio details should appear one per line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35707 --- Comment #1 from Martin Renvoize --- Created attachment 160569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160569&action=edit Current display -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 13:09:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 12:09:59 +0000 Subject: [Koha-bugs] [Bug 35707] Item statuses in the holdings table on biblio details should appear one per line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35707 --- Comment #2 from Martin Renvoize --- Created attachment 160570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160570&action=edit Proposed change -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 13:16:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 12:16:36 +0000 Subject: [Koha-bugs] [Bug 35707] Item statuses in the holdings table on biblio details should appear one per line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35707 --- Comment #3 from Martin Renvoize --- Created attachment 160571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160571&action=edit Bug 35707: Add clearfix to item statuses This patch adds the clearfix class to each of item status/availabiliy spans. This has the effect of pushing each status onto it's own line. Test plan 1) Add an item to stockrotation and trigger the first transfer 2) Place a hold on the item 3) Note that you will now see two status's, one above the other as displayed in the screenshots attached to the bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 13:17:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 12:17:09 +0000 Subject: [Koha-bugs] [Bug 35707] Item statuses in the holdings table on biblio details should appear one per line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35707 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 13:17:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 12:17:26 +0000 Subject: [Koha-bugs] [Bug 35707] Item statuses in the holdings table on biblio details should appear one per line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35707 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com, | |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 14:05:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 13:05:19 +0000 Subject: [Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086 --- Comment #14 from Nick Clemens --- Created attachment 160572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160572&action=edit Bug 35086: (follow-up) Use 5000 as example in conf file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 14:06:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 13:06:06 +0000 Subject: [Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086 --- Comment #15 from Nick Clemens --- (In reply to Jonathan Druart from comment #13) > you have 500 in conf and 5000 in pm, is that expected? 500 seemed a more reasonable size in my head, but 5000 is more consistent with our default indexing so I updated it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 14:08:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 13:08:09 +0000 Subject: [Koha-bugs] [Bug 35587] Items lose their lost status when check-in triggers a transfer even though BlockReturnOfLostItems is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35587 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 14:08:10 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 13:08:10 +0000 Subject: [Koha-bugs] [Bug 35587] Items lose their lost status when check-in triggers a transfer even though BlockReturnOfLostItems is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35587 --- Comment #13 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 14:08:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 13:08:12 +0000 Subject: [Koha-bugs] [Bug 35629] Redundant code in includes/patron-search.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35629 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 14:08:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 13:08:14 +0000 Subject: [Koha-bugs] [Bug 35629] Redundant code in includes/patron-search.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35629 --- Comment #9 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 14:08:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 13:08:15 +0000 Subject: [Koha-bugs] [Bug 35696] Transit status not properly updated for items advanced in Stock Rotation tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35696 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 14:08:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 13:08:17 +0000 Subject: [Koha-bugs] [Bug 35696] Transit status not properly updated for items advanced in Stock Rotation tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35696 --- Comment #6 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 14:09:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 13:09:57 +0000 Subject: [Koha-bugs] [Bug 35708] New: System parameter AutoRenewalNotices defaults to deprecated option Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 Bug ID: 35708 Summary: System parameter AutoRenewalNotices defaults to deprecated option Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: anke.bruns at gwdg.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When installing Koha, the deprecated option "(Deprecated) according to --send-notices cron switch" is set by default in the system preference "AutoRenewalNotices". It would be nicer to have another option as default, e.g. "according to patron messaging preferences" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 14:10:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 13:10:31 +0000 Subject: [Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 Anke Bruns changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |anke.bruns at gwdg.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 14:21:23 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 13:21:23 +0000 Subject: [Koha-bugs] [Bug 35598] selenium/authentication_2fa.t is still failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35598 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 14:24:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 13:24:05 +0000 Subject: [Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29234 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29234 [Bug 29234] Transfers generated by stock rotation alert but do not initiate at checkin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 14:24:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 13:24:05 +0000 Subject: [Koha-bugs] [Bug 29234] Transfers generated by stock rotation alert but do not initiate at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29234 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35100 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 14:28:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 13:28:06 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 --- Comment #79 from Katrin Fischer --- Hm, a bugfix depending on an enhancement can be an issue as it makes backporting hard or impossible. Any chance we could get a bugfix for the stable versions independent of bug 29440? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 14:30:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 13:30:35 +0000 Subject: [Koha-bugs] [Bug 35709] New: Renew selected items button is inactive when overdue items are preselected automatically Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35709 Bug ID: 35709 Summary: Renew selected items button is inactive when overdue items are preselected automatically Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: anneli.osterman at koha-suomi.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Renew or checkin selected items button were seperated to two buttons (wich is great). When you go to patron's checkouts and there are overdue items, they are selected automatically for renewal (as previously). But now the Renew selected items button is inactive and you have to click one of the overdue items on the Renew colum to activate the button. And click it again to renew that one too. This happens in both cgi-bin/koha/members/moremember.pl and cgi-bin/koha/circ/circulation.pl pages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 14:38:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 13:38:49 +0000 Subject: [Koha-bugs] [Bug 35489] Holds on items with no barcode are missing an input for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 --- Comment #9 from Nick Clemens --- Created attachment 160573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160573&action=edit Bug 35489: [23.05.x] Add a hidden input for itemnumber even if item has no barcode This page is a single form, all fields must have inputs to avoid data loss/mismatch To test: 1 - Find a record in the catalog and add or edit items to have one item with a barcode and one without 2 - Place an item level hold on the item with no barcode 3 - Place another hold for a different patron on the item with a barcode 4 - From the holds table add an expiration date to the hold with a barcode and save 5 - Note the hold on the item with no barcode is now on the item with a barcode and the other hold is now a next available hold 6 - Delete the holds 7 - Apply patch 8 - Repeat 2-4 9 - Confirm the itemnumbers for the holds have not changed Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 14:38:56 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 13:38:56 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 --- Comment #80 from M --- I don't think that it would be viable at all at this point... Imo they should be either backported both or neither of them. Otherwise I'm not even sure if it applies to the original unpatched scripts without breakage or side-effects. I don't think cherry-picking only parts of this for backport is worth it. Not to mention that commit "Enable bulkmarcimport overlay context" itself also depends on fixes from the refactor made in the other bug. If we're extra-careful, it could be even dubious if they should be backported at all, in case someone might currently depend on old slightly broken behavior of the scripts, such as having "*" overlay rules that were completely ignored despite code suggesting otherwise. I previously suggested merging it as bugfix in November, but before 23.11 was actually officially released. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 14:48:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 13:48:54 +0000 Subject: [Koha-bugs] [Bug 35709] Renew selected items button is inactive when overdue items are preselected automatically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35709 --- Comment #1 from Anneli Österman --- Created attachment 160574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160574&action=edit Renew selected items button is inactive Screenshot -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 14:56:58 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 13:56:58 +0000 Subject: [Koha-bugs] [Bug 35704] Parent and child itemtype hold limits not enforced as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35704 --- Comment #1 from Katrin Fischer --- The parent/child itemtype feature is currently only used for the number of checkouts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:00:33 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 14:00:33 +0000 Subject: [Koha-bugs] [Bug 35070] Koha plugins implementing "background_jobs" hook can't provide view template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35070 --- Comment #22 from Katrin Fischer --- Pushed the follow-up to master. Thanks for taking care of this so quickly! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:10:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 14:10:27 +0000 Subject: [Koha-bugs] [Bug 35695] Remove useless item group code from cataloging_additem.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35695 hebah at bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:26:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 14:26:07 +0000 Subject: [Koha-bugs] [Bug 35710] New: Indexing problem with "&" symbol in Zebra. Some biblio-records with "&" symbol are not searching Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35710 Bug ID: 35710 Summary: Indexing problem with "&" symbol in Zebra. Some biblio-records with "&" symbol are not searching Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs at lists.koha-community.org Reporter: yuriy.kotsyuk at oa.edu.ua I find a problem in my academy koha instance. My librarians can't find some biblio-records. I check database and figured out that records looks good. So, I decided to rebuild zebra index. During rebuilding where a lot of errors. Simple analyses show, that problem was with "&" symbol. Example below: ... Wide character in warn at /usr/share/koha/lib/C4/Biblio.pm line 1199. problem with :423324 : :42: parser error : xmlParseEntityRef: no name Norton & Company ^ 00516nam a22002177a 4500 UA-OsUOA 133930 ta 20181112b un ||||| |||| 00| 0 ukr d 51 BK UA-OsUOA eng UA-OsUOA UA-OsUOA The Principles of Mathematics B. Russell 535 p. с. 2 eng 51 New York Norton & Company 1951 51 Математика UDC 423324 423324 2 Юрій Анатолійович Коцюк error retrieving biblio 423324 at /usr/share/koha/bin/migration_tools/rebuild_zebra.pl line 686. ... One more example: ... Wide character in warn at /usr/share/koha/lib/C4/Biblio.pm line 1199. problem with :423001 : :43: parser error : EntityRef: expecting ';' http://zt.knteu.kiev.ua/index.php?option=com_content&view ^ :43: parser error : EntityRef: expecting ';' ld code="u">http://zt.knteu.kiev.ua/index.php?option=com_content&view=article&id ^ :43: parser error : EntityRef: expecting ';' http://zt.knteu.kiev.ua/index.php?option=com_content&view=article&id=2349&Itemid ^ :43: parser error : EntityRef: expecting ';' .knteu.kiev.ua/index.php?option=com_content&view=article&id=2349&Itemid=721&lang ^ ... It's looks like script try use ampersand sequence... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:37:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 14:37:55 +0000 Subject: [Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 Anke Bruns changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.11 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:37:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 14:37:55 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #68 from Katrin Fischer --- I reviewed the patch more closely today and tested. We'll need some more small fixes: 1) + bug_number => "BUG_30230", This is wrong and should be just 30230. 2) Please add view to the permission descriptions in the SQL and template file: + "INSERT IGNORE INTO permissions (module_bit, code, description) VALUES (4, 'list_borrowers', 'Search and list patrons')" 3) In the main navigation (not start page, but on top) the Patrons module is missing with only catalogue and list_borrowers permission. I quite like the way how this lets you limit patron search to your own library in combination with library groups. When view_borrower_infos_from_any_libraries is added, I can search them all. But I am not required to also give edit_borrowers. This is nice. Please help to finish this! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:37:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 14:37:59 +0000 Subject: [Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 Anke Bruns changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anke.bruns at gwdg.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:40:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 14:40:27 +0000 Subject: [Koha-bugs] [Bug 35293] Regression: Bug 33390 (QA follow-up) patch overwrote the template changes to bug 25560 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:44:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 14:44:16 +0000 Subject: [Koha-bugs] [Bug 35711] New: Compatibility levels before 10 are deprecated Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35711 Bug ID: 35711 Summary: Compatibility levels before 10 are deprecated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: mtj at kohaaloha.com Seeing this when trying to build custom packages: dh clean --fail-missing --with bash-completion dh: warning: Compatibility levels before 10 are deprecated (level 9 in use) dh_auto_clean -O--fail-missing dh_auto_clean: warning: Compatibility levels before 10 are deprecated (level 9 in use) dh_clean -O--fail-missing dh_clean: warning: Compatibility levels before 10 are deprecated (level 9 in use) No idea what it means, but see bug 18908 for a similar fix. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:44:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 14:44:26 +0000 Subject: [Koha-bugs] [Bug 35711] Compatibility levels before 10 are deprecated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35711 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18908 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:44:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 14:44:26 +0000 Subject: [Koha-bugs] [Bug 18908] Warning "Compatibility levels before 9 are deprecated" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18908 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35711 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:50:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 14:50:16 +0000 Subject: [Koha-bugs] [Bug 35504] Release team 24.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 --- Comment #22 from Katrin Fischer --- I think we didn't get the wiki bit right, it currently still lists me (I haven't signed up :) ), and we are missing George Williams and Mason James, but we should have them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:50:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 14:50:19 +0000 Subject: [Koha-bugs] [Bug 35712] New: Record issue_id in old_reserves for completed holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35712 Bug ID: 35712 Summary: Record issue_id in old_reserves for completed holds Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: andrewfh at dubcolib.org QA Contact: testopia at bugs.koha-community.org CC: nick at bywatersolutions.com There is not currently a direct data linkage between a filled hold in old_reserves and the checkout that filled it in (old_)issues. It'd be helpful if we could put the issue_id into the old_reserves table to make that explicit. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:51:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 14:51:27 +0000 Subject: [Koha-bugs] [Bug 35713] New: Update or remove debian/docs/LEEME.Debian? Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35713 Bug ID: 35713 Summary: Update or remove debian/docs/LEEME.Debian? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: mtj at kohaaloha.com The file was added by bug 7197 in 2011, but has never been updated. I don't know Spanish, but I have a hunch it might need an update after all these years. Or maybe it can be removed? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:52:56 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 14:52:56 +0000 Subject: [Koha-bugs] [Bug 35504] Release team 24.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 --- Comment #23 from Katrin Fischer --- Out of interest - how do the entries sort? I notice that it's not alphabetic, but also not following the sequence of the YAML file (for me RM is last QAM is first, but in the file RM would be first and QAM somehwere in the middle) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:53:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 14:53:03 +0000 Subject: [Koha-bugs] [Bug 35504] Release team 24.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 16:15:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 15:15:46 +0000 Subject: [Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 --- Comment #20 from Victor Grousset/tuxayo --- (In reply to Jonathan Druart from comment #19) > > 1. What is DT_delay for? > > We want to make sure the AJAX request is there. In some cases (see bug > 35284), the wait_for_ajax was called but the AJAX request was not triggered > yet, so we didn't wait for it to finished. Ouch, yet another bad thing that can happen >_< Thankfully, I had no sign of that happening in my +2000 runs. But it might happen on the CI thanks to Murphy's law. So I added it in my WIP patch. ----- > > 2. I only though of it just now: instead of having the flag > > window._pageFullyReady, should the problematic buttons be hidden in the > > HTML? (and maybe have a dummy button with a loading icon in place to show > > the user that stuff it loading) And then the stuff in $(document).ready() > > makes them visible after setting the onclick callback. And the test just > > waits for the button to be visible instead of the flag to be set. > > We should not need more than wait_for_ajax here IMO. That's not what is happening here. The wait_for_page_fully_ready uses are for distinct places than wait_for_ajax. Each time it's about not clicking the "Show checkouts" button before it's callback is set. So no XHR involved here to wait for as an alternative. > If it takes more than > 10 sec then there is something wrong somewhere else. That's another thing than the use of wait_for_page_fully_ready. At least on my machine, the XHR can indeed take more than 10 sec to return (and still work), many times over all my runs. I'm not sure there is really a problem other than a perfect storm that makes the request horribly slow sometimes. > We could extend the > delay specifically for this call. That's precisely what it done in my patch. That's why I had to turn max_retries from a constant to a field with accessors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 16:16:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 15:16:09 +0000 Subject: [Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160511|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 16:16:25 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 15:16:25 +0000 Subject: [Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gitlab.com/tuxayo/K | |oha/-/commits/bug-35506-sel | |enium-regressions.t-failing | |-randomly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 16:18:56 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 15:18:56 +0000 Subject: [Koha-bugs] [Bug 30681] Allow overlay protection of MARC data by subfield In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30681 Rhonda Kuiper changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuiper at roundrocktexas.gov --- Comment #2 from Rhonda Kuiper --- I agree that protecting MARC information on a subfield level would be WONDERFUL! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 16:32:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 15:32:30 +0000 Subject: [Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 --- Comment #21 from Jonathan Druart --- window._pageFullyReady I don't understand how this is useful. Selenium should wait for the page to be loaded before starting the tests. If it's because of async statements, then this won't help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 16:53:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 15:53:55 +0000 Subject: [Koha-bugs] [Bug 35714] New: Clicking Print slips when no letter template selected causes error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35714 Bug ID: 35714 Summary: Clicking Print slips when no letter template selected causes error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Preservation Assignee: koha-bugs at lists.koha-community.org Reporter: aude.charillon at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: jonathan.druart+koha at gmail.com In the preservation module, a "Letter template for printing slip" can be selected when creating a processing. This is not a required field; the field is blank by default. When viewing a train that uses a processing where no letter template have been specified, I still see the Print slips button in the Items table actions. When I select items, the button becomes clickable. When I click on it, I get an error page (probably because there is no specified notice for Koha to use!) On master, the error page starts with the lines: Error trace No letter_code at /kohadevbox/koha/preservation/print_slip.pl line 45. at /usr/lib/aarch64-linux-gnu/perl-base/Carp.pm line 289 On a system recently upgraded to 23.11, I am getting a 500 error at /cgi-bin/koha/preservation/print_slip.pl?train_item_id=1&train_item_id=2_blank It would be better if either: - the "Letter template for printing slip" field had the Train item slip selected by default; - or, the Print slip button didn't appear at all when no letter templates are selected in the processing settings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 17:01:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 16:01:53 +0000 Subject: [Koha-bugs] [Bug 35715] New: Pick items to add to train directly from those in the waiting list Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35715 Bug ID: 35715 Summary: Pick items to add to train directly from those in the waiting list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Preservation Assignee: koha-bugs at lists.koha-community.org Reporter: aude.charillon at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: jonathan.druart+koha at gmail.com In the preservation module, you have to add your items to the waiting list before you can add them to a train. When adding items to a train from the Trains > Show train page (at /cgi-bin/koha/preservation/trains/1/items/add), the only option is to scan the item's barcode. I understand that makes sense for library staff who are located close to the physical items. However, it would be very useful if all the items in the waiting list could also be displayed on this page, so staff could select them from the list instead of re-scanning all the ones they need. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 17:11:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 16:11:19 +0000 Subject: [Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 --- Comment #9 from Martin Renvoize --- Created attachment 160575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160575&action=edit Bug 35100: Various fixes 1) Don't automagically always set a transfer to in transit on checkin.. wait for the user to actually confirm that's the case 2) New transfers triggered by a hold should take precidence, so hide transfers for any other reason from display 3) Remove current_branchtransfers prefect from detail.pl as doing a prefetch completely nukes the order_by that this transfer method relies heavily upon to get the right modified FIFO transfer of the queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 17:31:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 16:31:03 +0000 Subject: [Koha-bugs] [Bug 35155] MARCOverlayRules syspref not in manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35155 Esther Melander changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander at bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 17:44:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 16:44:40 +0000 Subject: [Koha-bugs] [Bug 35515] Change occurences of "Global system preferences" to "System preferences" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35515 Rasa Satinskiene changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/772 Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #4 from Rasa Satinskiene --- Manual updated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 17:45:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 16:45:50 +0000 Subject: [Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 --- Comment #22 from Victor Grousset/tuxayo --- (In reply to Jonathan Druart from comment #21) > window._pageFullyReady > > I don't understand how this is useful. Selenium should wait for the page to > be loaded before starting the tests. No, it's not about the page to be loaded. It's about $(document).ready() to have finished all it's content. The event Selenium waits for is the same as the one $(document).ready() waits for IIUC. So they both start at the same time and from time to time, Selenium reaches the "Show checkouts" button before $(document).ready() {[...]} has reached the point where it give the button it's callback. So Selenium click on an inactive button and nothing happens. That's what I understood from the screenshots showing the button looking like blocked in the pressed position and Koha no doing the expected action. And it seems confirmed by the usage of window._pageFullyReady preventing the issue. > If it's because of async statements, then this won't help. I don't know if the following is async, whether attaching the callback is async. But by the time it reaches setting window._pageFullyReady. Then the button is functional and all works as expected. $('#issues-table-load-now-button').click(function(){ [....] }); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 17:49:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 16:49:05 +0000 Subject: [Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 --- Comment #23 from Victor Grousset/tuxayo --- I commented the calls to wait_for_page_fully_ready and after 7 run, I got again this error: Can't call method "get_text" on an undefined value at t/db_dependent/selenium/regressions.t line 349. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 18:00:44 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 17:00:44 +0000 Subject: [Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 --- Comment #24 from Victor Grousset/tuxayo --- After rerunning 2 times, I got the other error # Failed test 'Checkouts table must be correctly aligned' # at t/db_dependent/selenium/regressions.t line 213. # got: '' # expected: '1' # thead: 0 ; tfoot: 18 ; tbody: 0 So the two main errors of this ticket are fixed by wait_for_page_fully_ready. I'm not even sure wait_for_ajax fixed anything the CI was hitting. But anyway, I needed them on my PC to be able to do a lot of runs of 'Encoding in session variables' and 'Checkouts table must be correctly aligned' without having interruptions due to long XHR responses. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 18:09:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 17:09:09 +0000 Subject: [Koha-bugs] [Bug 35716] New: Duplicated assets in both koha-tmpl/intra-tmpl and koha-tmpl/opac-tmpl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35716 Bug ID: 35716 Summary: Duplicated assets in both koha-tmpl/intra-tmpl and koha-tmpl/opac-tmpl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: pedro.amorim at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: jonathan.druart+koha at gmail.com, julian.maurice at biblibre.com, m.de.rooy at rijksmuseum.nl, martin.renvoize at ptfs-europe.com, tomascohen at gmail.com There are some JS assets duplicated in koha-tmpl/intra-tmpl and koha-tmpl/opac-tmpl. 100% match: ./koha-tmpl/opac-tmpl/bootstrap/js/i18n.js ./koha-tmpl/intranet-tmpl/js/i18n.js 100% match: ./koha-tmpl/opac-tmpl/bootstrap/js/Gettext.js ./koha-tmpl/intranet-tmpl/js/Gettext.js ~95% match: ./koha-tmpl/opac-tmpl/bootstrap/js/coce.js ./koha-tmpl/intranet-tmpl/js/coce.js ~95% match: ./koha-tmpl/opac-tmpl/bootstrap/js/cookieconsent.js ./koha-tmpl/intranet-tmpl/prog/js/cookieconsent.js ~80% match: ./koha-tmpl/opac-tmpl/bootstrap/js/ill-availability.js ./koha-tmpl/intranet-tmpl/prog/js/ill-availability.js ~50% match: ./koha-tmpl/opac-tmpl/bootstrap/js/basket.js ./koha-tmpl/intranet-tmpl/prog/js/basket.js Some of the differences in the above pairs may have been due to requirements specific to only staff or to only OPAC, or it may also have been the case that they have fallen out of sync over the years with some enhancements being added to one of the pair and not the other. I don't know what the best solution for this would be (if one is needed) but developing bug 35604 I need to have the same JS file on both intra and OPAC and feels bad to have to copy the same file to 2 different places. I'm only looking for JS files but I know this is also the case for images, maybe some CSS and other assets. Could we consider having a koha-tmpl/shared-tmpl directory, or have some of these overlapping assets only exist once and have them be duplicated for each interface during build, or yet another better option? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 18:14:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 17:14:11 +0000 Subject: [Koha-bugs] [Bug 25159] Action logs should be stored in JSON ( and as a diff of the change ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Angela Berrett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |angela.berrett at familysearch | |.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 18:21:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 17:21:39 +0000 Subject: [Koha-bugs] [Bug 25163] Add the ability to bulk attach items to a bib record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25163 Angela Berrett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |angela.berrett at familysearch | |.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 18:35:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 17:35:12 +0000 Subject: [Koha-bugs] [Bug 35704] Add hold limits to Parent Child Item Types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35704 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Parent and child itemtype |Add hold limits to Parent |hold limits not enforced as |Child Item Types |expected | --- Comment #2 from Lisette Scheer --- ah, I misunderstood. I'm renaming this into an enhancement request: Parent and child itemtype hold limits not enforced as expected -> Add hold limits to Parent Child Item Types -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 19:23:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 18:23:37 +0000 Subject: [Koha-bugs] [Bug 35691] Remove the AUTO_RENEWALS notice in favor of AUTO_RENEWALS_DGST In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35691 Kristi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger at cuyahogalibrary.or | |g --- Comment #1 from Kristi --- There are power users that like to receive single notifications for other types of notices like hold filled. The non-digestible version of this remains, so I would suggest both options (single or digests only) to remain for autorenewal notices. Unless, unlike hold filled, there is only one possible time per day that the autorenewal message would be sent out? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 19:54:28 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 18:54:28 +0000 Subject: [Koha-bugs] [Bug 35717] New: Add an ordernumber column to suggestions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Bug ID: 35717 Summary: Add an ordernumber column to suggestions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org This is bug 28844 reworked with the relationship defined in the reverse way. There can be multiple suggestions for the same title currently (the check for duplicate suggestions includes the suggestedby field in the search, so only a single patron is prevented from requesting the same book twice) While we can order only from a single suggestion, bug 19358 and 31632 seek to allow linking multiple suggestions to an order, I believe we need to define the relationship this way now, to allow for future changes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 19:56:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 18:56:59 +0000 Subject: [Koha-bugs] [Bug 35717] Add an ordernumber column to suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 19:57:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 18:57:01 +0000 Subject: [Koha-bugs] [Bug 35717] Add an ordernumber column to suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #1 from Nick Clemens --- Created attachment 160576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160576&action=edit Bug 35717: DB changes Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 19:57:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 18:57:03 +0000 Subject: [Koha-bugs] [Bug 35717] Add an ordernumber column to suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #2 from Nick Clemens --- Created attachment 160577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160577&action=edit Bug 35717: DBIC schema changes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 19:57:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 18:57:05 +0000 Subject: [Koha-bugs] [Bug 35717] Add an ordernumber column to suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #3 from Nick Clemens --- Created attachment 160578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160578&action=edit Bug 35717: Add link between suggestions and orders Signed-off-by: Nick Clemens -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 19:57:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 18:57:07 +0000 Subject: [Koha-bugs] [Bug 35717] Add an ordernumber column to suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #4 from Nick Clemens --- Created attachment 160579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160579&action=edit Bug 35717: Remove GetSuggestionInfoFromBiblionumber Signed-off-by: Nick Clemens -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 19:57:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 18:57:09 +0000 Subject: [Koha-bugs] [Bug 35717] Add an ordernumber column to suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #5 from Nick Clemens --- Created attachment 160580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160580&action=edit Bug 35717: Replace GetSuggestionFromBiblionumber Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 19:57:10 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 18:57:10 +0000 Subject: [Koha-bugs] [Bug 35717] Add an ordernumber column to suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #6 from Nick Clemens --- Created attachment 160581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160581&action=edit Bug 35717: Remove GetSuggestionFromBiblionumber Signed-off-by: Nick Clemens -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 19:57:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 18:57:12 +0000 Subject: [Koha-bugs] [Bug 35717] Add an ordernumber column to suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #7 from Nick Clemens --- Created attachment 160582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160582&action=edit Bug 35717: Adjust other calls Signed-off-by: Nick Clemens -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 19:57:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 18:57:14 +0000 Subject: [Koha-bugs] [Bug 35717] Add an ordernumber column to suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #8 from Nick Clemens --- Created attachment 160583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160583&action=edit Bug 35717: Tidy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 20:00:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 19:00:00 +0000 Subject: [Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35717 --- Comment #53 from Nick Clemens --- I reworked this with the relationship built the other way on bug 35717 I can attempt the update there, however, I think a better path is to allow a GUI way for the suggestions to be correctly linked, or to attempt to update and provide a way to correct if needed. I will be working on 19358 and 31632 this cycle which will be part of the GUI. Please let me know if we can agree to continue this work on 35717 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 20:00:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 19:00:00 +0000 Subject: [Koha-bugs] [Bug 35717] Add an ordernumber column to suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28844 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 20:00:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 19:00:13 +0000 Subject: [Koha-bugs] [Bug 35717] Add an ordernumber column to suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 20:04:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 19:04:18 +0000 Subject: [Koha-bugs] [Bug 35718] New: Remove ES6 warnings from JavaScript system preferences Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35718 Bug ID: 35718 Summary: Remove ES6 warnings from JavaScript system preferences Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When using any of the UserJS system preferences there are warnings if you use any ES6 features/syntax. To recreate: 1. Add some JS like this to any of the UserJS system preferences: $(document).ready( function() { let something = 1; const another_thing = 2; let an_arrow_function = (a, b) => a + b; console.log( an_arrow_function(something, another_thing) ); }); 2. Notice the icons and warnings to the left of the line numbers: let is available in ES6 const is available in ES6 arrow_function_syntax is available in ES6 ES6 syntax is pretty commonly used now, I don't think we need those warnings. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 20:07:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 19:07:11 +0000 Subject: [Koha-bugs] [Bug 35718] Remove ES6 warnings from JavaScript system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35718 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 20:07:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 19:07:13 +0000 Subject: [Koha-bugs] [Bug 35718] Remove ES6 warnings from JavaScript system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35718 --- Comment #1 from Lucas Gass --- Created attachment 160584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160584&action=edit Bug 35718: Remove ES6 warns from JS system preferences To test: 1. Add some JS like this to any of the UserJS system preferences: $(document).ready( function() { let something = 1; const another_thing = 2; let an_arrow_function = (a, b) => a + b; console.log( an_arrow_function(something, another_thing) ); }); 2. Notice the icons and warnings to the left of the line numbers: let is available in ES6 const is available in ES6 arrow_function_syntax is available in ES6 3. APPLY PATCH 4. Try steps 1 and 2 again, the warnings should be gone. 5. Check that the JavaScript still works, in my example it should console.log 3. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 20:19:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 19:19:04 +0000 Subject: [Koha-bugs] [Bug 35687] Upgrade to 23.06.00.013 may fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #5 from David Nind --- I'd like to test, but I'm not sure of the exact steps for step 1 of the test plan (using KTD). This is what I tried, but I couldn't trigger the error: 1. Koha repository - checkout 23.05.x: git checkout 23.05.x 2. KTD: start up as normal (I didn't change the KOHA_IMAGE in .env) 3. From the KTD shell check out 23.11.x: ktd --shell git checkout 23.11.x 4. Restart everything: restart_all 5. Go to the staff interface 6. Upgrade starts - Use koha_kohadev as the user and password as the password - Grant more privileges to the koha_kohadev user: . mysql -uroot -ppassword -hkoha-db-1 . use mysql . grant all on koha_kohadev.* to koha_kohadev; . flush privileges; 7. No errors when updating the database structure I also tried using an earlier version: 1. Koha repository - checkout 22.11.x: git checkout 22.11.x 2. KTD - change KOHA_IMAGE in .env: . edit .env: KOHA_IMAGE=22.11 . ktd pull . ktd up ... same as above - step 3 onwards Do I have to manually alter the database tables so the conditions for the error to occur are in place before the upgrade? Happy to try again, otherwise I will leave to someone who is more familiar with how to work with different versions of Koha using KTD and doing upgrades. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 20:34:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 19:34:31 +0000 Subject: [Koha-bugs] [Bug 32551] API requests don't carry language related information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32551 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 20:34:33 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 19:34:33 +0000 Subject: [Koha-bugs] [Bug 32551] API requests don't carry language related information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32551 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160358|0 |1 is obsolete| | Attachment #160359|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 160585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160585&action=edit Bug 32551: Regression tests Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 20:34:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 19:34:35 +0000 Subject: [Koha-bugs] [Bug 32551] API requests don't carry language related information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32551 --- Comment #9 from Nick Clemens --- Created attachment 160586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160586&action=edit Bug 32551: HTTP_ACCEPT_LANGUAGE legacy CGI variable not set in Mojolicious This patch addresses the fact some of our code still relies on those CGI-era ENV variables. In particular, C4::Laguages::getlanguage expects it to calculate the most suitable language. As this is reported as required, I provide a fix. I did a `git grep HTTP_` on the codebase, and the only other occurences are: * C4::Output (HTTP_X_REQUESTED_WITH) * C4::Context (HTTP_USER_AGENT, HTTP_X_FORWARDED_FOR) * C4::Auth_with_shibboleth (using HTTP_ variables for matchpoints) * Some handling on the 'Koha as a Mojo app' code * Some .pl script not relevant to this report I decided to limit this patch to the requested header which seems harmless. I leave the other cases. To test: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ qa -c 1 => FAIL: Tests fail! 3. Apply this patch 4. Run: k$ qa -c 2 => SUCCESS: Tests pass! All green! 5. Sign off :-D Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 20:38:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 19:38:09 +0000 Subject: [Koha-bugs] [Bug 35650] 'Check the logs' string dot-inconsistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35650 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 20:38:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 19:38:11 +0000 Subject: [Koha-bugs] [Bug 35650] 'Check the logs' string dot-inconsistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35650 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160303|0 |1 is obsolete| | Attachment #160304|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 160587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160587&action=edit Bug 35650: Standardize on 'Check the logs for details.' This patch makes the 'Check the logs..' messages more consistent across the codebase. To test: 1. Run: $ git grep -e 'Check the logs\"' -e 'Check the logs<' -e 'Check the logs\.' => FAIL: Several forms show up 2. Apply this patch 3. Repeat 1 => SUCCESS: Empty result. 4. Run: $ git grep -e 'Check the logs for details\.' => SUCCESS: Consisten results show 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 20:38:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 19:38:13 +0000 Subject: [Koha-bugs] [Bug 35650] 'Check the logs' string dot-inconsistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35650 --- Comment #7 from Nick Clemens --- Created attachment 160588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160588&action=edit Bug 35650: (follow-up) Other cases found while editing files for the main patch, I noticed some tiny cases. Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 20:40:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 19:40:38 +0000 Subject: [Koha-bugs] [Bug 35634] Permissions mismatch for vendor issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35634 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 20:40:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 19:40:40 +0000 Subject: [Koha-bugs] [Bug 35634] Permissions mismatch for vendor issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35634 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160476|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 160589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160589&action=edit Bug 35634: (bug 33105 follow-up) fix typo issues_manage vs issue_manage issue_manage inserted into the DB but issues_manage is tested in the controller script. Test plan: git grep issues_manage should no longer return any results Signed-off-by: Lucas Gass Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 20:44:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 19:44:54 +0000 Subject: [Koha-bugs] [Bug 35717] Add an ordernumber column to suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 20:50:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 19:50:13 +0000 Subject: [Koha-bugs] [Bug 35452] Provide more info when using Link authorities automatically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35452 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 20:50:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 19:50:15 +0000 Subject: [Koha-bugs] [Bug 35452] Provide more info when using Link authorities automatically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35452 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159416|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 160590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160590&action=edit Bug 35452: Provide more info when using Link authorities automatically Test plan 1 Edit a record and add several 7xx and 6xx 2 Click on Link authorities automatically and check that the result only shows the field numbers 3 Apply patch, restart services 4 Click on Link authorities automatically and check that the result shows the field numbers and the info of the entry Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 21:09:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 20:09:01 +0000 Subject: [Koha-bugs] [Bug 35707] Item statuses in the holdings table on biblio details should appear one per line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35707 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #4 from David Nind --- Sometimes things move too quickly 8-(.. git bz apply 35707 Bug 35707 - Item statuses in the holdings table on biblio details should appear one per line 160571 - Bug 35707: Add clearfix to item statuses Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 35707: Add clearfix to item statuses Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 35707: Add clearfix to item statuses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 21:15:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 20:15:37 +0000 Subject: [Koha-bugs] [Bug 35328] Add a notes pop-up for authority records to authority search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35328 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 21:15:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 20:15:39 +0000 Subject: [Koha-bugs] [Bug 35328] Add a notes pop-up for authority records to authority search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35328 --- Comment #3 from Nick Clemens --- Created attachment 160591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160591&action=edit Bug 35328: Add a notes pop-up for authority records to authority search results This enhancement makes authority record notes (6xx) more accessible in a special Notes pop-up, available in all authority search result lists. To test: 1) In the staff interface, go to the Authorities module and conduct a search. Any records with 6xx fields should show with an italicised Notes link under the heading. Click on the Notes link for each record and confirm the correct notes for that record show. 2) Test this in the following staff interface pages: - authority plugin when cataloguing a biblio record - batch authority record modification - batch authority record deletion 3) Test the Notes pop-up is available in the OPAC authority search 4) Confirm the Notes link does NOT show if there is no 6xx field in the record Sponsored-by: Education Services Australia SCIS Signed-off-by: Phil Ringnalda Signed-off-by: Nick Clemens bsoletes: 158959 - Bug 35328: Add a notes pop-up for authority records to authority search results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 21:16:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 20:16:59 +0000 Subject: [Koha-bugs] [Bug 35328] Add a notes pop-up for authority records to authority search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35328 Phil Ringnalda changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158959|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 21:22:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 20:22:18 +0000 Subject: [Koha-bugs] [Bug 25835] Include overdue report (under circulation module) as a staff permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25835 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 21:22:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 20:22:20 +0000 Subject: [Koha-bugs] [Bug 25835] Include overdue report (under circulation module) as a staff permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25835 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159364|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 160592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160592&action=edit Bug 25835: Include overdues with fines in overdues_report permission To test: 1 - have a user with circulate_remaining_permissions but not overdues_report 2 - confirm user can see and run Overdues with Fines 3 - apply patch 4 - confirm user can no longer see links to Overdues with Fines or load the page directly by entering the url 5 - confirm a user with overdues_report or greate permission can see and use the tool Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 21:22:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 20:22:40 +0000 Subject: [Koha-bugs] [Bug 35686] Case missing from installer step 3 template title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 21:22:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 20:22:42 +0000 Subject: [Koha-bugs] [Bug 35686] Case missing from installer step 3 template title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160467|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 160593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160593&action=edit Bug 35686: Case missing from installer step 3 template title This patch adds a missing case to the display of the title on step 3 of the web installer. This resulted in an empty first part of the title: " > Web installer > Koha" To test, apply the patch and reset the database version from the command line in Koha Testing Docker: > koha-mysql kohadev > UPDATE systempreferences SET value = '23.1200002 WHERE variable = 'version'; > quit > Restart all - Go to the staff interface. You should be taken to the web installer. - Log in to the web installer and proceed through until you get to the "Updating database structure" page. - Confirm that the page title is correct. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 21:23:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 20:23:09 +0000 Subject: [Koha-bugs] [Bug 35641] Reduce DB calls when performing inventory on a list of barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35641 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 21:34:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 20:34:04 +0000 Subject: [Koha-bugs] [Bug 35691] Remove the AUTO_RENEWALS notice in favor of AUTO_RENEWALS_DGST In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35691 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #2 from Lucas Gass --- (In reply to Kristi from comment #1) > There are power users that like to receive single notifications for other > types of notices like hold filled. The non-digestible version of this > remains, so I would suggest both options (single or digests only) to remain > for autorenewal notices. > > Unless, unlike hold filled, there is only one possible time per day that the > autorenewal message would be sent out? Thanks for the feedback! Autorenewals, via automatic_renewals.pl, do typically only once a day. It sounds like there are users who prefer the non-digest version! We can mark this as RESOLVED - WONT FIX. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 21:34:34 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 20:34:34 +0000 Subject: [Koha-bugs] [Bug 35686] Case missing from installer step 3 template title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes a web browser release notes| |page title for the web | |installer - from " > Web | |installer > Koha" to | |"Updating database | |structure > Web installer | |> Koha". CC| |david at davidnind.com --- Comment #3 from David Nind --- Does the title displayed on the page need updating as well? Most pages have this title pattern, for example: Web installer › Update database On the page that this bug fixes, the page title is just: Updating database structure Should this be: Web installer › Updating database structure Testing notes using KTD: 1. I used this statement to update the version: UPDATE systempreferences SET value = '23.1200000' WHERE variable = 'version'; 2. Restart everything: restart_all 3. Go to the staff interface 4. Upgrade starts - Use koha_kohadev as the user and password as the password - Grant more privileges to the koha_kohadev user: . mysql -uroot -ppassword -hkoha-db-1 . use mysql . grant all on koha_kohadev.* to koha_kohadev; . flush privileges; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 21:47:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 20:47:15 +0000 Subject: [Koha-bugs] [Bug 25159] Action logs should be stored in JSON ( and as a diff of the change ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Laura O'Neil changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laura at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 21:57:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 20:57:37 +0000 Subject: [Koha-bugs] [Bug 15461] Add staff equivalent for OpacLocationOnDetail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461 --- Comment #6 from Andrew Fuerste-Henry --- Giving this a bump after confirming I don't have the skills to write it myself. We've got a floating collection and would love to hide Home Library in the intranet, but cannot do so without also hiding the shelving location. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 22:03:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 21:03:48 +0000 Subject: [Koha-bugs] [Bug 35695] Remove useless item group code from cataloging_additem.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35695 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 22:03:51 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 21:03:51 +0000 Subject: [Koha-bugs] [Bug 35695] Remove useless item group code from cataloging_additem.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35695 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160508|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 160594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160594&action=edit Bug 35695: Remove useless JS from cataloging_additem.js To test: 1. APPLY PATCH 2. Turn on EnableItemGroups 3. Go to a record with item groups, or create some. 4. Add an item, making sure items can be added to a group. ( Bug 33639 must be applied ) If I am wrong and this code should stay, tell me. I'll fix the jQuery instead of removing it. :) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 22:06:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 21:06:47 +0000 Subject: [Koha-bugs] [Bug 35717] Add an ordernumber column to suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #9 from Andrew Fuerste-Henry --- Test plan: 1 - apply patch, reset_all 2 - create purchase suggestion 3 - accept purchase suggestion 4 - create and receive order from suggestion 5 - confirm that notices were generated as suggestion is accepted, ordered, received 6 - confirm that order number is present in suggestions data Anything else I need to check here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 22:10:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 21:10:37 +0000 Subject: [Koha-bugs] [Bug 35695] Remove useless item group code from cataloging_additem.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35695 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Testing notes (using KTD): 1. I added and edited groups, and added items to groups (both from the normal page view, and when adding new items). 2. No differences or errors noted before and after the patch was applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 22:35:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 21:35:11 +0000 Subject: [Koha-bugs] [Bug 35717] Add an ordernumber column to suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #10 from Andrew Fuerste-Henry --- Test plan: 1 - apply patch, reset_all 2 - create purchase suggestion 3 - accept purchase suggestion 4 - create and receive order from suggestion 5 - confirm that notices were generated as suggestion is accepted, ordered, received 6 - confirm that order number is present in suggestions data 7 - submit a second suggestion, accept it, create order from it 8 - cancel order from suggestion, confirm suggestion status reverts from "Ordered" to "Accepted" and order number is removed from suggestion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 22:35:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 21:35:53 +0000 Subject: [Koha-bugs] [Bug 35717] Add an ordernumber column to suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Andrew Fuerste-Henry --- Hi these patches applied, I'm getting an error when attempting to receive an order tied to a suggestion. It looks like maybe an undefined basket number? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 22:39:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 21:39:06 +0000 Subject: [Koha-bugs] [Bug 35719] New: Specify which libraries the loggedinlibrary permission allows patron to switch between Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35719 Bug ID: 35719 Summary: Specify which libraries the loggedinlibrary permission allows patron to switch between Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Koha has always been to broad in what libraries a staff member can switch to. Now that we have the loggedinlibraries permission, it would be good to take this to the next level and set what libraries the user can switch between. I envision an button next to this permission that, when clicked, brings up a modal listing all defined branches and a check box next to each. Admin would pick which libraries the staff member can switch between. with the loggedinlibraries permission active, the user would see the library dropdown, but only the libraries checked in the permission would be active selections. We could either remove or deactivate the choices the staff member is not allowed to choose from. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 23:45:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2024 22:45:11 +0000 Subject: [Koha-bugs] [Bug 27595] Place holds for patrons on accepted purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Dave changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ddaghita at mckinneytexas.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 10:42:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 09:42:19 +0000 Subject: [Koha-bugs] [Bug 35710] Indexing problem with "&" symbol in Zebra. Some biblio-records with "&" symbol are not searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35710 --- Comment #1 from Katrin Fischer --- Hi Yuriy, 21.05 is very old and no longer maintained. I suggest that you do a test in a newer version of Koha if the problem still remains. You could use a Koha sandbox or one of the publicly available demo installations. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 11:02:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 10:02:48 +0000 Subject: [Koha-bugs] [Bug 24326] Remove advance_notices_digest.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24326 --- Comment #6 from Katrin Fischer --- I didn't find any occurrence of RUN_TESTS_AND_EXIT in the codebase, so not sure if we have done similar before, but if we can make sure these are only run on by the automated tests, it would be helpful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 11:03:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 10:03:27 +0000 Subject: [Koha-bugs] [Bug 25424] Document our exceptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25424 --- Comment #4 from Katrin Fischer --- It sounds more like a clean-up than a documentation job. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 11:03:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 10:03:45 +0000 Subject: [Koha-bugs] [Bug 25453] Koha::SearchEngine::ES In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25453 --- Comment #8 from Katrin Fischer --- (In reply to Frédéric Demians from comment #7) > (In reply to Katrin Fischer from comment #6) > > What is the state of this? > > It's a dead-end. Should we close then? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 11:05:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 10:05:38 +0000 Subject: [Koha-bugs] [Bug 24334] Barcode should be included in Marcitemfieldstoorder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24334 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 33171 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 11:05:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 10:05:38 +0000 Subject: [Koha-bugs] [Bug 33171] Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com --- Comment #15 from Katrin Fischer --- *** Bug 24334 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 11:13:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 10:13:16 +0000 Subject: [Koha-bugs] [Bug 35693] Granular Permissions to Everything In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35693 --- Comment #1 from Katrin Fischer --- We are certainly due a permission clean-up and I there are a lot of bugs when you look for 'permission' that we could put here to make this an omnibus bug. One thing we might want to think about is moving away from the mix of borrowers.flags and the permissions table to give us a better base to order and group permissions. As a topic for discussion, it might be better suited for the mailing list or developer meetings. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 11:16:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 10:16:01 +0000 Subject: [Koha-bugs] [Bug 35688] RFID Envisionware Software Requires Static Page Title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35688 --- Comment #1 from Katrin Fischer --- Hi Eliana, have you checked with your support provider if you maybe can use a wildcard/truncation in the software settings? If you could tell the software to look or a page title of "Check in > Circulation*" that could solve your issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 11:21:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 10:21:54 +0000 Subject: [Koha-bugs] [Bug 35569] Remember user-selected columns in holdings table on staff detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35569 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22276 Summary|Remember user-selected |Remember user-selected |columns in records |columns in holdings table | |on staff detail page Version|unspecified |master --- Comment #3 from Katrin Fischer --- Hi Piia, I am changing the bug title to make it about this table. I think we need to make it happen table by table right now. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276 [Bug 22276] Add client storage of user-selected DataTables configuration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 11:21:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 10:21:54 +0000 Subject: [Koha-bugs] [Bug 22276] Add client storage of user-selected DataTables configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35569 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35569 [Bug 35569] Remember user-selected columns in holdings table on staff detail page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 11:57:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 10:57:46 +0000 Subject: [Koha-bugs] [Bug 24613] SIP reports unable to checkin withdrawn item if not checked out and checked_in_ok set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24613 --- Comment #1 from Katrin Fischer --- I am not sure if this is still valid, but behavior should probably take BlockReturnOfWithdrawnItems into account. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 11:57:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 10:57:55 +0000 Subject: [Koha-bugs] [Bug 24613] SIP reports unable to checkin withdrawn item if not checked out and checked_in_ok set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24613 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff interface |SIP2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 12:01:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 11:01:04 +0000 Subject: [Koha-bugs] [Bug 24626] error en RunSQL.pm line 273. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24626 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- This has been reported almost 4 years ago and was more of a support request. Closing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 12:17:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 11:17:40 +0000 Subject: [Koha-bugs] [Bug 24628] Fine grained control over hold/auto-renew notice recipients In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24628 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fine grained control over |Fine grained control over |reserve notice recipients |hold/auto-renew notice | |recipients --- Comment #1 from Katrin Fischer --- It feels like this should be 2 bug reports perhaps? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 12:20:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 11:20:49 +0000 Subject: [Koha-bugs] [Bug 24632] Plugins should support simple signing for security/verifiability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24632 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 12:24:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 11:24:12 +0000 Subject: [Koha-bugs] [Bug 24645] Review implementation checklist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24645 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs documenting -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 12:27:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 11:27:47 +0000 Subject: [Koha-bugs] [Bug 24656] Koha should not allow creating partial cents fines/fees that cannot be paid in currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24656 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24655 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 12:27:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 11:27:47 +0000 Subject: [Koha-bugs] [Bug 24655] RoundFinesAtPayment can leave partial cent credits on patrons account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24655 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24656 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 12:29:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 11:29:08 +0000 Subject: [Koha-bugs] [Bug 24659] Improve Patron Notice Status options to be more clear to staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24659 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 12:32:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 11:32:09 +0000 Subject: [Koha-bugs] [Bug 24667] Display the home location of the item in search results in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24667 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Displaying the Home |Display the home location |Location of the Item from |of the item in search |Search Results in Staff |results in the staff |Client |interface Version|19.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 12:54:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 11:54:46 +0000 Subject: [Koha-bugs] [Bug 35659] OAI Harvester In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #8 from Koha Team University Lyon 3 --- (In reply to Katrin Fischer from comment #6) > We are still missing supporters for this in the road map: > https://wiki.koha-community.org/wiki/Road_map_24.05 *hint* Add myself as supporter :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 14:12:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 13:12:03 +0000 Subject: [Koha-bugs] [Bug 24678] Add missing search fields to Elasticsearch mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24678 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Katrin Fischer --- All dependent bugs have been closed fixed, closing this one as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 14:17:51 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 13:17:51 +0000 Subject: [Koha-bugs] [Bug 24687] Installation errors in Koha-common In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24687 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #3 from Katrin Fischer --- There has been no new information on this bug in 4 years and no feedback to Mason's suggestions. Closing INVALID for now, please reopen if you still experience any issues. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 14:23:29 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 13:23:29 +0000 Subject: [Koha-bugs] [Bug 24714] Include ISBN tag in search result items even if no in-built Enhanced Content service for cover images is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24714 --- Comment #1 from Katrin Fischer --- You can add some code to OpacSearchForTitleIn to add an invisible HTML element to the page containing the {ISBN} placeholder. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 14:29:58 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 13:29:58 +0000 Subject: [Koha-bugs] [Bug 24718] Introduce hour-based holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 --- Comment #66 from Katrin Fischer --- We now have the base for a booking feature in Koha. It could make sense to build this functionality on top of that now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 14:35:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 13:35:26 +0000 Subject: [Koha-bugs] [Bug 24731] Privacy concerns in Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24731 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23660 --- Comment #4 from Katrin Fischer --- Maybe bug 23660 would be an option? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 14:35:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 13:35:26 +0000 Subject: [Koha-bugs] [Bug 23660] Add system preference to remove message body from sent notices after notice status switches to sent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23660 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24731 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 14:38:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 13:38:17 +0000 Subject: [Koha-bugs] [Bug 24738] Online registration confirmation/clarification when same email address is used multiple times In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24738 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Katrin Fischer --- I think this bug describes 2 things: * Show a message that an email has already been registered: We should not do this, as it would give away that the email address exists and is a user at the library. This is a privacy concern. * Sent an email to verify: we already have email verification for self registration that works this way. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 14:45:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 13:45:40 +0000 Subject: [Koha-bugs] [Bug 24761] Caching issues in scripts running in daemon mode [OMNIBUS] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24761 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #5 from Katrin Fischer --- It looks like all linked bugs here have been closed/resolved now. Closing this one as well, please re-open if I missed something. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 14:52:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 13:52:08 +0000 Subject: [Koha-bugs] [Bug 24778] Move from Memcached to Redis to solve L1 caching issues? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24778 --- Comment #1 from Katrin Fischer --- This was filed almost 4 years ago - have we come to a decision about this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 16:05:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 15:05:42 +0000 Subject: [Koha-bugs] [Bug 24785] Search result column localization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24785 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 16:05:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 15:05:49 +0000 Subject: [Koha-bugs] [Bug 35710] Indexing problem with "&" symbol in Zebra. Some biblio-records with "&" symbol are not searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35710 --- Comment #2 from Yuriy Kotsyuk --- I can add new records without problem, even it has "&" symbol... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 16:07:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 15:07:37 +0000 Subject: [Koha-bugs] [Bug 24796] No test coverage for getting translations from templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24796 --- Comment #1 from Katrin Fischer --- Is this still valid? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 16:10:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 15:10:16 +0000 Subject: [Koha-bugs] [Bug 24797] xx-XX-messages.po line numbers are not correct In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24797 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- I just re-tested this and the lines match exactly with the template file: 7719 #: koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt:235 7720 #: koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt:498 7721 #, fuzzy 7722 msgctxt "purchase suggestion created by" 7723 msgid "Created by:" 7724 msgstr "Erstellt von:" I believe this has been fixed on another bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 16:11:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 15:11:47 +0000 Subject: [Koha-bugs] [Bug 24799] Add withdrawn status for serial issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24799 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |23.11 Summary|add withdrawn status for |Add withdrawn status for |issues |serial issues --- Comment #4 from Katrin Fischer --- We do have a "Deleted" status and some missing/lost values. Also "not available". Maybe one of those could be used? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 16:11:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 15:11:55 +0000 Subject: [Koha-bugs] [Bug 24799] Add withdrawn status for serial issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24799 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|23.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 16:27:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 15:27:02 +0000 Subject: [Koha-bugs] [Bug 35710] Indexing problem with "&" symbol in Zebra. Some biblio-records with "&" symbol are not searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35710 --- Comment #3 from Yuriy Kotsyuk --- Also, I found an “incorrect” record through the database and changed the “&” symbol to “ZZZ” (it’s a rare combination). Then I rebuilt the index. This record was indexed correctly and was found by the usual search. Next, I used the librarian interface to change “ZZZ” back to “&” symbol. After these operations, I got a really correct searchable bib-record. I’m not really sure that the problem is with the old koha version… -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 16:48:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 15:48:50 +0000 Subject: [Koha-bugs] [Bug 24835] Bad PCDATA explodes search with a Software ERROR. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24835 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Katrin Fischer --- (In reply to Lisa Beinhoff from comment #2) > We are running 19.05.05.000. 19.05.05 is no longer maintained, but newer versions have much improved handling for bad records. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 16:52:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 15:52:31 +0000 Subject: [Koha-bugs] [Bug 24843] Allow change of framework via batch record modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24843 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 17:20:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 16:20:36 +0000 Subject: [Koha-bugs] [Bug 24906] Problems with automatic saving the name and id of creator and who modifies the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24906 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Problems with automatic |Problems with automatic |saving the name and id of |saving the name and id of |creator and who modifies |creator and who modifies |the catolog |the catalog -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 17:23:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 16:23:48 +0000 Subject: [Koha-bugs] [Bug 24912] Generate SQL from YAML installer files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24912 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Generate sql from yaml |Generate SQL from YAML |installer files |installer files --- Comment #10 from Katrin Fischer --- Is this one still needed now that we already moved all the installers to YAML? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 17:24:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 16:24:40 +0000 Subject: [Koha-bugs] [Bug 24914] Saving a record as MARC (Unicode/UTF-8, Standard) remove items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24914 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- (In reply to Katrin Fischer from comment #1) > But wouldn't that be the expected behavior as the 952 is not standard? Would > it help if we changed the decriptions including "without item data" somehow? Never got a reply, closing invalid (at least it might draw attention ;) ) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 17:30:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 16:30:40 +0000 Subject: [Koha-bugs] [Bug 24969] ILS-DI allows cancellation of waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24969 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ILSDI allows cancellation |ILS-DI allows cancellation |of waiting holds |of waiting holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 17:58:10 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 16:58:10 +0000 Subject: [Koha-bugs] [Bug 25043] Use of union in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25043 --- Comment #6 from Katrin Fischer --- Still valid? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 18:35:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 17:35:49 +0000 Subject: [Koha-bugs] [Bug 1724] Add option to force search for existing items before placing order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1724 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #4 from Katrin Fischer --- There hasn't been much interest for this one in the 13 years it has been around. I am closing WONTFIX, please re-open if you are still interested. Personally, I'd prefer improving our duplicate checks instead of enforching a manual search step. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 18:36:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 17:36:52 +0000 Subject: [Koha-bugs] [Bug 1707] Search for patron '%' returns all results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 --- Comment #17 from Katrin Fischer --- Could we close this with the "new" API based patron search? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 19:24:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 18:24:20 +0000 Subject: [Koha-bugs] [Bug 35713] Update or remove debian/docs/LEEME.Debian? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35713 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 19:24:23 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 18:24:23 +0000 Subject: [Koha-bugs] [Bug 35713] Update or remove debian/docs/LEEME.Debian? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35713 --- Comment #1 from Katrin Fischer --- Created attachment 160595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160595&action=edit Bug 35713: Remove outdated debian/docs/LEEME.Debian file This removes the LEEME.Debian README file from the docs directory. We don't even have an English README here as we usually refer to the wiki for installation instructions. It makes sense to remove it from the codebase. To test: * Verify that the file is removed * Verify that all references to the file have been removed as well Example: git grep LEEME -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 19:25:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 18:25:00 +0000 Subject: [Koha-bugs] [Bug 35713] Remove debian/docs/LEEME.Debian In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35713 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | Summary|Update or remove |Remove |debian/docs/LEEME.Debian? |debian/docs/LEEME.Debian -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 19:30:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 18:30:02 +0000 Subject: [Koha-bugs] [Bug 35702] Reduce DB calls when performing authorities merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35702 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 19:30:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 18:30:05 +0000 Subject: [Koha-bugs] [Bug 35702] Reduce DB calls when performing authorities merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35702 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160537|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 160596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160596&action=edit Bug 35702: Use framework code from biblio object Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 19:30:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 18:30:07 +0000 Subject: [Koha-bugs] [Bug 35702] Reduce DB calls when performing authorities merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35702 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160538|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 160597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160597&action=edit Bug 35702: Fetch biblios at once and loop Test plan: prove -v t/db_dependent/Authority/Merge.t Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 19:35:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 18:35:02 +0000 Subject: [Koha-bugs] [Bug 35713] Remove debian/docs/LEEME.Debian In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35713 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 19:35:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 18:35:04 +0000 Subject: [Koha-bugs] [Bug 35713] Remove debian/docs/LEEME.Debian In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35713 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160595|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 160598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160598&action=edit Bug 35713: Remove outdated debian/docs/LEEME.Debian file This removes the LEEME.Debian README file from the docs directory. We don't even have an English README here as we usually refer to the wiki for installation instructions. It makes sense to remove it from the codebase. To test: * Verify that the file is removed * Verify that all references to the file have been removed as well Example: git grep LEEME Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 20:18:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 19:18:47 +0000 Subject: [Koha-bugs] [Bug 35706] Typo "Amoung" in manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35706 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/810 Status|NEW |Needs documenting Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 20:30:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 19:30:08 +0000 Subject: [Koha-bugs] [Bug 25691] Debian packages point to /usr/share/doc/koha/README.Debian which does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25691 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 20:30:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 19:30:11 +0000 Subject: [Koha-bugs] [Bug 25691] Debian packages point to /usr/share/doc/koha/README.Debian which does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25691 --- Comment #3 from Katrin Fischer --- Created attachment 160599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160599&action=edit Bug 25691: Replace link to non-existing README with wiki link This doesn't update the occurrence in the control file as it says in control.in: To test: * Verify all occurrences of the README file have been updated. Exceptions: * control (see above) * changelog -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 20:30:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 19:30:13 +0000 Subject: [Koha-bugs] [Bug 25691] Debian packages point to /usr/share/doc/koha/README.Debian which does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25691 --- Comment #4 from Katrin Fischer --- Created attachment 160600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160600&action=edit Bug 25691: (follow-up) Update control file with wiki link This is in case it's needed anyway (see comment on previous patch) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 20:30:25 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 19:30:25 +0000 Subject: [Koha-bugs] [Bug 25691] Debian packages point to /usr/share/doc/koha/README.Debian which does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25691 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 20:39:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 19:39:07 +0000 Subject: [Koha-bugs] [Bug 35602] Typo: AutoMemberNum In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35602 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 20:43:33 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 19:43:33 +0000 Subject: [Koha-bugs] [Bug 35602] Typo: AutoMemberNum In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35602 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 20:43:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 19:43:35 +0000 Subject: [Koha-bugs] [Bug 35602] Typo: AutoMemberNum In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35602 --- Comment #1 from Katrin Fischer --- Created attachment 160601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160601&action=edit Bug 35602: Fix typo AutoMemberNum The correct spelling is autoMemberNum. To test: * Enable autoMemberNum system preference * Set cardnumber to mandatory in BorrowerMandatoryField * Add a new patron account * Verify correct spelling in hint below cardnumber input field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 20:45:33 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 19:45:33 +0000 Subject: [Koha-bugs] [Bug 35375] Capitalization: Report Release In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35375 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- Already fixed as part of another bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 20:46:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 19:46:17 +0000 Subject: [Koha-bugs] [Bug 35323] Terminology: Add additional elements to the "More Searches" bar... In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35323 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 20:52:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 19:52:31 +0000 Subject: [Koha-bugs] [Bug 35323] Terminology: Add additional elements to the "More Searches" bar... In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35323 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 20:52:33 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 19:52:33 +0000 Subject: [Koha-bugs] [Bug 35323] Terminology: Add additional elements to the "More Searches" bar... In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35323 --- Comment #3 from Katrin Fischer --- Created attachment 160602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160602&action=edit Bug 35323: Fix hint for OpacMoreSearches HTML customization There was some confusion on where this content appears. This patch fixes the description shown as hint in the HTML customizations tool when when the OpacMoreSearches entry is selected. To test: * Before appyling the patch * Add a new HTML customization for OpacMoreSearches * Verif hint showing below the pull down * Set a title and a publication date in the past * Enter a short text, like "Koha" as content * Save * Go to the OPAC, verify text shows in the navigation * Apply patch * Verify hint is now correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 20:53:23 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 19:53:23 +0000 Subject: [Koha-bugs] [Bug 35300] Add page-section to table of invoice files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35300 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 20:59:25 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 19:59:25 +0000 Subject: [Koha-bugs] [Bug 35300] Add page-section to table of invoice files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35300 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 20:59:28 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 19:59:28 +0000 Subject: [Koha-bugs] [Bug 35300] Add page-section to table of invoice files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35300 --- Comment #1 from Katrin Fischer --- Created attachment 160603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160603&action=edit Bug 35300: Add page-section to invoice files page To test: * Enable AcqEnableFiles system preference * Go to acquisitions * Search for a vendor and receive shipment * Enter an invoice number and create new invoice * Finish receive * Click on 'manage invice files' link * Upload a sample file * Verify the table is missing the usual white background * Apply patch * Verify the the table now displays with the usual white background -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 21:00:23 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 20:00:23 +0000 Subject: [Koha-bugs] [Bug 35394] Tone down "!!A booking exists!!" a bit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35394 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 21:21:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 20:21:11 +0000 Subject: [Koha-bugs] [Bug 35683] Record Detail View should more accurately display the material type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35683 Jack changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 CC| |jmorash at sbhrs.org --- Comment #2 from Jack --- Showing Film for a DVD is not useful, it is confusing to patrons. Use of 000, 007 & 008 allows you to accurately show the Material Type being used. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 21:23:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 20:23:15 +0000 Subject: [Koha-bugs] [Bug 35394] Tone down "!!A booking exists!!" a bit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35394 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Katrin Fischer --- Fixing the message is easy, but I have trouble coming up with a test plan to trigger it in the GUI. The only one I see is: Due for another patron booking by: 01/05/2024 I have tried with a patron without force_checkouts and made sure my attempted loan was within the booking period. I am not sure how to trigger the issuingimpossible case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 21:30:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 20:30:31 +0000 Subject: [Koha-bugs] [Bug 35395] Update description of DefaultPatronSearchMethod In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35395 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 21:30:33 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 20:30:33 +0000 Subject: [Koha-bugs] [Bug 35395] Update description of DefaultPatronSearchMethod In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35395 --- Comment #1 from Katrin Fischer --- Created attachment 160604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160604&action=edit Bug 35395: Update DefaultPatronSearchMethod system preference description This updates the system preference description of DefaultPatronSearchMethod so that it's clear that the preference applies to all patron searches, including patron module search and auto-completes. To test: * Search for DefaultPatronSearchMethod system preference in administration * Verify the setting is reflected in the filters of the patron search * Apply patch * Verify that the description now is now improved. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 21:31:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 20:31:02 +0000 Subject: [Koha-bugs] [Bug 35395] Update description of DefaultPatronSearchMethod In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35395 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 21:31:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 20:31:37 +0000 Subject: [Koha-bugs] [Bug 35407] Terminology: Show fewer collection codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35407 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 21:32:25 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 20:32:25 +0000 Subject: [Koha-bugs] [Bug 35407] Terminology: Show fewer collection codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35407 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|katrin.fischer at bsz-bw.de |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 21:40:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 20:40:57 +0000 Subject: [Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 22:15:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 21:15:03 +0000 Subject: [Koha-bugs] [Bug 35517] Choose correct default header search tab according to permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35517 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #3 from Victor Grousset/tuxayo --- How should this interact with Bug 30230 ? Just do the following substitution? (CAN_user_borrowers_edit_borrowers) ↓↓ (CAN_user_borrowers_edit_borrowers) || (CAN_user_borrowers_list_borrowers) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 22:25:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 21:25:52 +0000 Subject: [Koha-bugs] [Bug 35720] New: Add option to require confirmation of hold override when placing hold Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35720 Bug ID: 35720 Summary: Add option to require confirmation of hold override when placing hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: lisette.scheer at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It would be helpful to some libraries to be able to require staff to confirm when they're overriding policy to place a hold. This would help highlight that they are overriding, not just placing a normal hold. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 22:53:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 21:53:30 +0000 Subject: [Koha-bugs] [Bug 35265] Remove drag and drop in Elasticsearch mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159835|0 |1 is obsolete| | --- Comment #18 from Victor Grousset/tuxayo --- Created attachment 160605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160605&action=edit Bug 35265: Remove drag and drop in Elasticsearch mappings Bug 18827 says ordering search fields in Elasticsearch mappings is useless. This patch removes it. Drag and drop is kept for facets. Test plan : 1) Enable Elasticsearch 2) Go to Administration > Search engine configuration (Elasticsearch) 3) Go to tab 'Bibliographic records' 4) Check there is no Javscript error 5) Check you can't drag and drop lines anymore Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Barbara Petritsch Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 22:54:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 21:54:08 +0000 Subject: [Koha-bugs] [Bug 35720] Add option to require confirmation of hold override when placing hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35720 Suzanne changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |smhodson123extra at yahoo.com --- Comment #1 from Suzanne --- Created attachment 160606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160606&action=edit Screenshot of the Message as it is. Would love to have a message pop up to confirm that staff want to override if they click on Place Hold. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 22:55:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 21:55:35 +0000 Subject: [Koha-bugs] [Bug 35720] Add option to require confirmation of hold override when placing hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35720 --- Comment #2 from Suzanne --- Because staff can still click on "Place Hold" without seeing anything pop up in front of what they are doing, they don't always notice the pop up that says "No holds allowed." (See the attached screen shot.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 22:55:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2024 21:55:52 +0000 Subject: [Koha-bugs] [Bug 35265] Remove drag and drop in Elasticsearch mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Signed Off |Passed QA --- Comment #19 from Victor Grousset/tuxayo --- Works (facets still ok, adding, removing, editing biblio and auth record mappings too), makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 7 09:30:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2024 08:30:35 +0000 Subject: [Koha-bugs] [Bug 35394] Tone down "!!A booking exists!!" a bit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35394 --- Comment #2 from Martin Renvoize --- Pretty sure this was just debugging left in by mistake. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 7 15:23:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2024 14:23:46 +0000 Subject: [Koha-bugs] [Bug 30745] ES : Search never return result using after-date and/or before-date in labels/label-item-search.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alex.arnaud at biblibre.com |emily-rose.francoeur at inLibr | |o.com CC| |david at davidnind.com Status|Needs Signoff |Failed QA --- Comment #19 from David Nind --- I was about to sign off, but then came across this Zebra only error - I get this error after the patches are applied (and a reindex): Error: Can't use an undefined value as an ARRAY reference at /kohadevbox/koha/labels/label-item-search.pl line 88 .... 1. Generated by putting a letter in the input box for these index searches (without any dates in the filters): publication date, standard number, ISBN, ISSN, call number, acquisition date 2. I could also generate this error with a number in a text field, for example: Author index, 2011 (but with 2000 no error is generated) 3. With Elasticsearch, no results are displayed and the form just refreshes (both before and after the patches, and the same with Zebra before the patches) Other notes =========== 1. I couldn't work out how or where cgi-bin/koha/labels/label-item-search.pl is used/accessed from - something to do with acquisitions? 2. I've changed the assignee. 3. I didn't test with a UNIMARC installation. Testing notes (using koha-testing-docker) ========================================= Setup ~~~~~ To test with Elasticsearch or OpenSearch - start up KTD with Elasticsearch or OpenSearch: ktd --es8 up OR ktd --os2 up (I didn't test with Open Search, just Zebra and Elasticsearch) Go to this page in the staff interface: http://127.0.0.1:8081/cgi-bin/koha/labels/label-item-search.pl Searching using Zebra (after KTD is started with --es8): - Change the SearchEngine system preference to Zebra - Reload http://127.0.0.1:8081/cgi-bin/koha/labels/label-item-search.pl - Reindex: koha-rebuild-zebra -d -f -v kohadev - Repeat all the example searches - you should get the same results Demonstrating the issue and that the patches fix it ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Notes: In the sample data, the acquisition date is recorded in 952$d - Date acquired. For many items, 09/04/2014 is used. For some items, these dates are used 05/08/2014, 05/07/2014, 10/15/2014, 12/04/2014, 1/05/2015. Many items don't have a date recorded. If there is no value in the index field, it is ignored. If an index is selected and a value is entered, the results should be filtered by any values entered in 'Added on or after date' and 'Added on or before date' fields. Before the patches: index searches work, but when used with 'Added on or after date' and 'Added on or before date' options, the search results ignore them. However, entering a date for the 'Acquisition date' index does work. A title index search: - Title index: perl => Expected result: 11 => Actual result: 11 A combined search with dates: - Title index: perl - Added on or after date: 09/04/2014 => Expected result: 10 (1 perl record has no items) => Actual result: No results A combined search with dates: - Title index: perl - Added on or before date: 09/04/2014 => Expected result: 10 (1 perl record has no items) => Actual result: No results Acquisition date index search: - Index: select 'Acquisition date' from the dropdown list - Value to enter: 09/04/2014 => Expected result: 352 results => Actual result: 352 result Acquisition date index search: - Index: select 'Acquisition date' from the dropdown list - Value to enter: 09/04/2014 - Added on or after date: 09/04/2014 OR - Added on or before date: 09/04/2014 OR Use both or none => Expected result: 352 results => Actual result: 352 results Search using 'Added on or after date' (after date) only: - Added on or after date: 09/04/2014 => Expected result: should get 408 records => Actual result: 0 results Search using 'Added on or before date' (before date) only: - Added on or after date: 09/04/2014 => Expected result: should get 354 records => Actual result: 0 results Publication date index search using 2011 (AFTER patches are applied - doesn't work as expected BEFORE the patches are applied): - Results if no before or after filter added: 8 (as expected) - Results if Added on or after date: 09/04/2014 - 8 (as expected) - Results if Added on or before date: 09/04/2014 - 7 (as expected) - Results for a date range - 7 (as expected): . Added on or after date: 09/04/2014 . Added on or before date: 09/05/2014 - Results for a date range - 8 (as expected): . Added on or after date: 09/04/2014 . Added on or before date: 10/15/2014 - Results for a date range - 1 (as expected): . Added on or after date: 09/05/2014 . Added on or before date: 10/15/2014 (One record and all its items has acquisition dates of 10/15/2014 - Blackstone's statutes on company law 2014-2015; the rest have 09/04/2014 acquisition dates) Search using just a date range (and no index) (AFTER patches are applied - doesn't work as expected BEFORE the patches are applied): - Added on or after date: 09/04/2014 => should get 408 results - Added on or before date: 09/03/2014 => should get 3 results - Added on or before date: today's date => should get 410 results (note: 408 + 3 doesn't equal 410 but it is correct, as one record has items with different acquisition dates: The C programming language has items with different acquisition dates - 1 x 09/04/2014 and 3 x 05/08/2014) - Added on or after date: 09/05/2014 => should get 56 results - Added on or after date: 12/04/2014 => should get 40 results - Added on or after date: 09/05/2014 - Added on or before date: 12/03/2014 => should get 16 records Pagination of search results ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1. Perform a search that returns more than 20 results - for example Title index, a: 2. Navigate through different result page navigation using page numbers, the "Next" button, and the "Previous" button => On each page, check that "Results X through X of X" displays the correct information - 20 results are displayed for each page - the total number of results should not change -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 7 15:38:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2024 14:38:02 +0000 Subject: [Koha-bugs] [Bug 25691] Debian packages point to /usr/share/doc/koha/README.Debian which does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25691 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 7 15:38:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2024 14:38:05 +0000 Subject: [Koha-bugs] [Bug 25691] Debian packages point to /usr/share/doc/koha/README.Debian which does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25691 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160599|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 160607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160607&action=edit Bug 25691: Replace link to non-existing README with wiki link This doesn't update the occurrence in the control file as it says in control.in: To test: * Verify all occurrences of the README file have been updated. Exceptions: * control (see above) * changelog Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 7 15:38:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2024 14:38:07 +0000 Subject: [Koha-bugs] [Bug 25691] Debian packages point to /usr/share/doc/koha/README.Debian which does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25691 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160600|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 160608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160608&action=edit Bug 25691: (follow-up) Update control file with wiki link This is in case it's needed anyway (see comment on previous patch) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 7 15:44:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2024 14:44:07 +0000 Subject: [Koha-bugs] [Bug 35602] Typo: AutoMemberNum In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35602 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 7 15:44:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2024 14:44:09 +0000 Subject: [Koha-bugs] [Bug 35602] Typo: AutoMemberNum In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35602 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160601|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 160609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160609&action=edit Bug 35602: Fix typo AutoMemberNum The correct spelling is autoMemberNum. To test: * Enable autoMemberNum system preference * Set cardnumber to mandatory in BorrowerMandatoryField * Add a new patron account * Verify correct spelling in hint below cardnumber input field Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 7 15:51:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2024 14:51:42 +0000 Subject: [Koha-bugs] [Bug 35323] Terminology: Add additional elements to the "More Searches" bar... In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35323 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 7 15:51:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2024 14:51:45 +0000 Subject: [Koha-bugs] [Bug 35323] Terminology: Add additional elements to the "More Searches" bar... In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35323 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160602|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 160610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160610&action=edit Bug 35323: Fix hint for OpacMoreSearches HTML customization There was some confusion on where this content appears. This patch fixes the description shown as hint in the HTML customizations tool when when the OpacMoreSearches entry is selected. To test: * Before appyling the patch * Add a new HTML customization for OpacMoreSearches * Verif hint showing below the pull down * Set a title and a publication date in the past * Enter a short text, like "Koha" as content * Save * Go to the OPAC, verify text shows in the navigation * Apply patch * Verify hint is now correct Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 7 16:05:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2024 15:05:11 +0000 Subject: [Koha-bugs] [Bug 35395] Update description of DefaultPatronSearchMethod In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35395 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 7 16:05:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2024 15:05:13 +0000 Subject: [Koha-bugs] [Bug 35395] Update description of DefaultPatronSearchMethod In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35395 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160604|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 160611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160611&action=edit Bug 35395: Update DefaultPatronSearchMethod system preference description This updates the system preference description of DefaultPatronSearchMethod so that it's clear that the preference applies to all patron searches, including patron module search and auto-completes. To test: * Search for DefaultPatronSearchMethod system preference in administration * Verify the setting is reflected in the filters of the patron search * Apply patch * Verify that the description now is now improved. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 7 16:13:34 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2024 15:13:34 +0000 Subject: [Koha-bugs] [Bug 35300] Add page-section to table of invoice files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35300 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 7 16:13:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2024 15:13:36 +0000 Subject: [Koha-bugs] [Bug 35300] Add page-section to table of invoice files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35300 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160603|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 160612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160612&action=edit Bug 35300: Add page-section to invoice files page To test: * Enable AcqEnableFiles system preference * Go to acquisitions * Search for a vendor and receive shipment * Enter an invoice number and create new invoice * Finish receive * Click on 'manage invice files' link * Upload a sample file * Verify the table is missing the usual white background * Apply patch * Verify the the table now displays with the usual white background Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 7 16:19:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2024 15:19:35 +0000 Subject: [Koha-bugs] [Bug 35718] Remove ES6 warnings from JavaScript system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35718 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 7 16:19:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2024 15:19:37 +0000 Subject: [Koha-bugs] [Bug 35718] Remove ES6 warnings from JavaScript system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35718 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160584|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 160613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160613&action=edit Bug 35718: Remove ES6 warns from JS system preferences To test: 1. Add some JS like this to any of the UserJS system preferences: $(document).ready( function() { let something = 1; const another_thing = 2; let an_arrow_function = (a, b) => a + b; console.log( an_arrow_function(something, another_thing) ); }); 2. Notice the icons and warnings to the left of the line numbers: let is available in ES6 const is available in ES6 arrow_function_syntax is available in ES6 3. APPLY PATCH 4. Try steps 1 and 2 again, the warnings should be gone. 5. Check that the JavaScript still works, in my example it should console.log 3. Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 7 16:20:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2024 15:20:27 +0000 Subject: [Koha-bugs] [Bug 35718] Remove ES6 warnings from JavaScript system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35718 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 7 22:49:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2024 21:49:30 +0000 Subject: [Koha-bugs] [Bug 28072] Z39.50/SRU servers would be a great addition to Mana KB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28072 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 7 23:20:43 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2024 22:20:43 +0000 Subject: [Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 7 23:20:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2024 22:20:46 +0000 Subject: [Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 --- Comment #7 from Katrin Fischer --- Created attachment 160614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160614&action=edit Bug 34979: Add unit test for comparing YAMl files with sysprefs.sql The unit tests will help to detect any discrepancies and missing entries in the YAML and sysprefs.sql files. To test: * Apply only this patch * prove -v t/db_dependent/check_sysprefs.t * It will fail. * Apply other patches * Run database update * Re-run test. It should pass now. * Recreate your database or reset_all with patches applied. * System preferences should be installed correctly. * Test should still pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 7 23:20:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2024 22:20:49 +0000 Subject: [Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 --- Comment #8 from Katrin Fischer --- Created attachment 160615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160615&action=edit Bug 34979: Sort sysprefs.sql alphabetically This doesn't add or remove any entries, but only changes the sequence of entries to be alphabetic again, compared to: SELECT variable FROM systempreferences ORDER BY variable; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 7 23:20:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2024 22:20:52 +0000 Subject: [Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 --- Comment #9 from Katrin Fischer --- Created attachment 160616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160616&action=edit Bug 34979: Fix mistakes in system preference files highlighted by unit test This fixes the mistakes the unit test helped to find: * Add missing system preferences to sysprefs.sql * Correct spelling for AutoUpdateSetsEmbedItemData * Correct capitalization, so that code and pref files match * Fix OverDrive sytem preferences, where explanation/options columns where switched, resulting in strange database entries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 7 23:22:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2024 22:22:52 +0000 Subject: [Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #10 from Katrin Fischer --- The mistake in OAI-PMH:AutoUpdateSetsEmbedItemData (Set vs. Sets) made the system preference non-functional, so updating this to a bug. Be gentle in review, tried my best with the unit test :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 00:30:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2024 23:30:30 +0000 Subject: [Koha-bugs] [Bug 35570] Add a generic master form in ILL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from David Nind --- I'm now getting this error after applying the first three patches (and dependent patches), for step 3 in the Atomicupdate patch: Can't locate Koha/Illrequests.pm in @INC (you may need to install the Koha::Illrequests module) (@INC contains: /kohadevbox/koha /kohadevbox/koha/lib /kohadevbox/koha/installer /kohadevbox/koha/lib/installer /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.32.1 /usr/local/share/perl/5.32.1 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl /var/lib/koha/kohadev/plugins) at /kohadevbox/koha/Koha/Illbackends/FreeForm/Base.pm line 25. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Illbackends/FreeForm/Base.pm line 25. Compilation failed in require at /kohadevbox/koha/Koha/ILL/Request.pm line 464 in Koha::ILL::Request::load_backend at /kohadevbox/koha/Koha/ILL/Request.pm line 464 461: my @raw = qw/Koha Illbackends/; # Base Path 462: my $location = join "/", @raw, $backend_name, "Base.pm"; # File to load 463: my $backend_class = join "::", @raw, $backend_name, "Base"; # Package name 464: require $location; 465: $self->{_my_backend} = $backend_class->new($backend_params); 466: } 467: .... I also tried applying all the patches, and still got the error. I'm sure I got past this point for my previous testing... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 00:50:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2024 23:50:00 +0000 Subject: [Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 00:50:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2024 23:50:02 +0000 Subject: [Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160614|0 |1 is obsolete| | --- Comment #11 from David Nind --- Created attachment 160617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160617&action=edit Bug 34979: Add unit test for comparing YAMl files with sysprefs.sql The unit tests will help to detect any discrepancies and missing entries in the YAML and sysprefs.sql files. To test: * Apply only this patch * prove -v t/db_dependent/check_sysprefs.t * It will fail. * Apply other patches * Run database update * Re-run test. It should pass now. * Recreate your database or reset_all with patches applied. * System preferences should be installed correctly. * Test should still pass. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 00:50:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2024 23:50:05 +0000 Subject: [Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160615|0 |1 is obsolete| | --- Comment #12 from David Nind --- Created attachment 160618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160618&action=edit Bug 34979: Sort sysprefs.sql alphabetically This doesn't add or remove any entries, but only changes the sequence of entries to be alphabetic again, compared to: SELECT variable FROM systempreferences ORDER BY variable; Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 00:50:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2024 23:50:08 +0000 Subject: [Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160616|0 |1 is obsolete| | --- Comment #13 from David Nind --- Created attachment 160619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160619&action=edit Bug 34979: Fix mistakes in system preference files highlighted by unit test This fixes the mistakes the unit test helped to find: * Add missing system preferences to sysprefs.sql * Correct spelling for AutoUpdateSetsEmbedItemData * Correct capitalization, so that code and pref files match * Fix OverDrive sytem preferences, where explanation/options columns where switched, resulting in strange database entries Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 09:18:25 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 08:18:25 +0000 Subject: [Koha-bugs] [Bug 34637] Wiki - email notifications aren't being sent (account registrations, password resets, etc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34637 Mark Hofstetter changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at trust-box.at --- Comment #11 from Mark Hofstetter --- hi, if it an SMTP blacklisting problem, we (HKS3/koha-support.eu) would be happy to sponsor a proper/professional SMTP mail sending provider, please just get in touch for it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 10:09:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 09:09:48 +0000 Subject: [Koha-bugs] [Bug 22567] Stock rotation manage rotas should show items current and desired locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22567 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 10:25:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 09:25:00 +0000 Subject: [Koha-bugs] [Bug 35570] Add a generic master form in ILL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #14 from Pedro Amorim --- (In reply to David Nind from comment #13) > I'm now getting this error after applying the first three patches (and > dependent patches), for step 3 in the Atomicupdate patch: > > Can't locate Koha/Illrequests.pm in @INC (you may need to install the > Koha::Illrequests module) (@INC contains: /kohadevbox/koha > /kohadevbox/koha/lib /kohadevbox/koha/installer > /kohadevbox/koha/lib/installer /etc/perl > /usr/local/lib/x86_64-linux-gnu/perl/5.32.1 /usr/local/share/perl/5.32.1 > /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 > /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 > /usr/share/perl/5.32 /usr/local/lib/site_perl /var/lib/koha/kohadev/plugins) > at /kohadevbox/koha/Koha/Illbackends/FreeForm/Base.pm line 25. > BEGIN failed--compilation aborted at > /kohadevbox/koha/Koha/Illbackends/FreeForm/Base.pm line 25. > Compilation failed in require at /kohadevbox/koha/Koha/ILL/Request.pm line > 464 > > in Koha::ILL::Request::load_backend at > /kohadevbox/koha/Koha/ILL/Request.pm line 464 > > 461: my @raw = qw/Koha Illbackends/; > # Base Path > 462: my $location = join "/", @raw, $backend_name, > "Base.pm"; # File to load > 463: my $backend_class = join "::", @raw, $backend_name, > "Base"; # Package name > 464: require $location; > 465: $self->{_my_backend} = > $backend_class->new($backend_params); > 466: } > 467: > > .... > > I also tried applying all the patches, and still got the error. > > I'm sure I got past this point for my previous testing... Hi David, thanks for persevering. I believe the error you're getting is because you may have skipped this step: 3) Please note that you need to be using FreeForm's reorganize_ILL branch at: https://github.com/PTFS-Europe/koha-ill-freeform/commits/reorganize_ILL/ After you git checkout reorganize_ILL in FreeForm you may have to koha-plack --restart. Would you please try again? Reach out to me on IRC, I'm always available. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 10:48:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 09:48:36 +0000 Subject: [Koha-bugs] [Bug 35721] New: Replace ModItemTransfer calls in circ/returns.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35721 Bug ID: 35721 Summary: Replace ModItemTransfer calls in circ/returns.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Blocks: 25754 ModItemTransfer is slowly getting removed and replaced by calls to the relevant Koha::Item and Koha::Item::Transfer methods. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25754 [Bug 25754] Deprecate C4::Items::ModItemTransfer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 10:48:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 09:48:36 +0000 Subject: [Koha-bugs] [Bug 25754] Deprecate C4::Items::ModItemTransfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25754 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35721 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35721 [Bug 35721] Replace ModItemTransfer calls in circ/returns.pl -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 10:48:44 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 09:48:44 +0000 Subject: [Koha-bugs] [Bug 35721] Replace ModItemTransfer calls in circ/returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35721 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 10:49:28 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 09:49:28 +0000 Subject: [Koha-bugs] [Bug 35721] Replace ModItemTransfer calls in circ/returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35721 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29234 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29234 [Bug 29234] Transfers generated by stock rotation alert but do not initiate at checkin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 10:49:28 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 09:49:28 +0000 Subject: [Koha-bugs] [Bug 29234] Transfers generated by stock rotation alert but do not initiate at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29234 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35721 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35721 [Bug 35721] Replace ModItemTransfer calls in circ/returns.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 12:32:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 11:32:38 +0000 Subject: [Koha-bugs] [Bug 35517] Choose correct default header search tab according to permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35517 --- Comment #4 from Owen Leonard --- (In reply to Victor Grousset/tuxayo from comment #3) > (CAN_user_borrowers_edit_borrowers) || (CAN_user_borrowers_list_borrowers) That looks correct to me. In either case the user should have access to the patron search tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 12:50:23 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 11:50:23 +0000 Subject: [Koha-bugs] [Bug 35722] New: Item transfer operations should be available from the API Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35722 Bug ID: 35722 Summary: Item transfer operations should be available from the API Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com CC: tomascohen at gmail.com We don't expose the item transfer queue in the API yet.. we should. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 12:51:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 11:51:20 +0000 Subject: [Koha-bugs] [Bug 35722] Item transfer operations should be available from the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35722 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22160 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 [Bug 22160] OMNIBUS: Transfers enhancements -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 12:51:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 11:51:20 +0000 Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35722 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35722 [Bug 35722] Item transfer operations should be available from the API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:06:28 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:06:28 +0000 Subject: [Koha-bugs] [Bug 35581] ILL Koha classes are not consistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #24 from Pedro Amorim --- Created attachment 160620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160620&action=edit Bug 35581: (QA follow-up): Missed Illrequests.pm REST API class Koha/REST/V1/Illrequests.pm -> Koha/REST/V1/ILL/Requests.pm Test plan: 1 Apply patch 2 Make sure tests pass, run: prove t/db_dependent/api/v1/ill_* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:11:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:11:42 +0000 Subject: [Koha-bugs] [Bug 35582] Advanced search languages should be listed with selected UI language descriptions shown first if available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 Lari Strand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159892|0 |1 is obsolete| | --- Comment #5 from Lari Strand --- Created attachment 160621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160621&action=edit Bug 35582: Advanced search languages should be listed with selected UI language descriptions shown first if available -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:18:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:18:05 +0000 Subject: [Koha-bugs] [Bug 35582] Advanced search languages should be listed with selected UI language descriptions shown first if available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 --- Comment #6 from Lari Strand --- To test: 1) Go to advanced search and bring up the language pulldowns from the Limits section 2) Notice the languages are shown with their native description first 3) Apply patch 4) Bring up the languages dropdowns and notice the localized language translations are shown first if the language (selected intranet language) has a local translation in language_descriptions table, otherwise defaulting to the English translation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:20:58 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:20:58 +0000 Subject: [Koha-bugs] [Bug 35581] ILL Koha classes are not consistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35331 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 [Bug 35331] Add an ILL table actions plugin hook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:20:58 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:20:58 +0000 Subject: [Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35581 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 [Bug 35581] ILL Koha classes are not consistent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:22:25 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:22:25 +0000 Subject: [Koha-bugs] [Bug 35581] ILL Koha classes are not consistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #25 from Pedro Amorim --- Created attachment 160622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160622&action=edit Bug 35581: (QA follow-up): Update changes coming from bug 35331 Test plan: prove t/db_dependent/Koha/Plugins/Ill_hooks.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:29:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:29:31 +0000 Subject: [Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160575|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 160623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160623&action=edit Bug 35100: Various fixes 1) Don't automagically always set a transfer to in transit on checkin.. wait for the user to actually confirm that's the case 2) New transfers triggered by a hold should take precidence, so hide transfers for any other reason from display 3) Remove current_branchtransfers prefetch from detail.pl as doing a prefetch completely nukes the order_by that this transfer method relies heavily upon to get the right modified FIFO transfer of the queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:30:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:30:59 +0000 Subject: [Koha-bugs] [Bug 35582] Advanced search languages should be listed with selected UI language descriptions shown first if available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 Lari Strand changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Lari Strand --- I can provide full Finnish and Swedish translations for the language codes if interested. I seems a couple of language codes are missing altogether from the English language descriptions in 23x. Here's a few: afa | Afroasiatic languages bua | Buriat fro | French, Old (ca. 842-1400) haw | Hawaiian lad | Ladino nai | North American Indian languages tmh | Tamashek wol | Wolof I can open another ticket for this / these. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:31:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:31:12 +0000 Subject: [Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 --- Comment #11 from Martin Renvoize --- OK.. I think this is the most backportable fix I can come up with.. the code in returns needs some reworking in the middle term.. we really shouldn't have as many variables passed around meaning almost the same things as we do.. and there's really no reason to have two distinct modals for the same actions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:32:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:32:09 +0000 Subject: [Koha-bugs] [Bug 35721] Replace ModItemTransfer calls in circ/returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35721 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29234 |35100 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29234 [Bug 29234] Transfers generated by stock rotation alert but do not initiate at checkin https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:32:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:32:09 +0000 Subject: [Koha-bugs] [Bug 29234] Transfers generated by stock rotation alert but do not initiate at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29234 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|35721 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35721 [Bug 35721] Replace ModItemTransfer calls in circ/returns.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:32:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:32:09 +0000 Subject: [Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35721 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35721 [Bug 35721] Replace ModItemTransfer calls in circ/returns.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:32:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:32:59 +0000 Subject: [Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22160 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 [Bug 22160] OMNIBUS: Transfers enhancements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:32:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:32:59 +0000 Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|35100 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:34:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:34:11 +0000 Subject: [Koha-bugs] [Bug 25753] Replace transferbook in circ/branchtransfers with Koha::Object method calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|28382 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 [Bug 28382] 'Reserve' should be passed through as transfer reason appropriately in branchtransfers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:34:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:34:11 +0000 Subject: [Koha-bugs] [Bug 28382] 'Reserve' should be passed through as transfer reason appropriately in branchtransfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25753 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753 [Bug 25753] Replace transferbook in circ/branchtransfers with Koha::Object method calls -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:35:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:35:30 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22161 |22160 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 [Bug 22160] OMNIBUS: Transfers enhancements https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22161 [Bug 22161] Move C4::Circulation::transferbook and C4::Items::ModItemTransfer to Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:35:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:35:30 +0000 Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24295 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:35:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:35:30 +0000 Subject: [Koha-bugs] [Bug 22161] Move C4::Circulation::transferbook and C4::Items::ModItemTransfer to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22161 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24295 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:36:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:36:47 +0000 Subject: [Koha-bugs] [Bug 25753] Replace transferbook in circ/branchtransfers with Koha::Object method calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25754 |22161 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22161 [Bug 22161] Move C4::Circulation::transferbook and C4::Items::ModItemTransfer to Koha namespace https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25754 [Bug 25754] Deprecate C4::Items::ModItemTransfer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:36:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:36:47 +0000 Subject: [Koha-bugs] [Bug 22161] Move C4::Circulation::transferbook and C4::Items::ModItemTransfer to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22161 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25753 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753 [Bug 25753] Replace transferbook in circ/branchtransfers with Koha::Object method calls -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:36:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:36:47 +0000 Subject: [Koha-bugs] [Bug 25754] Deprecate C4::Items::ModItemTransfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25754 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|25753 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753 [Bug 25753] Replace transferbook in circ/branchtransfers with Koha::Object method calls -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:40:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:40:42 +0000 Subject: [Koha-bugs] [Bug 35395] Update description of DefaultPatronSearchMethod In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35395 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:40:44 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:40:44 +0000 Subject: [Koha-bugs] [Bug 35395] Update description of DefaultPatronSearchMethod In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35395 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160611|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 160624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160624&action=edit Bug 35395: Update DefaultPatronSearchMethod system preference description This updates the system preference description of DefaultPatronSearchMethod so that it's clear that the preference applies to all patron searches, including patron module search and auto-completes. To test: * Search for DefaultPatronSearchMethod system preference in administration * Verify the setting is reflected in the filters of the patron search * Apply patch * Verify that the description now is now improved. Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:41:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:41:38 +0000 Subject: [Koha-bugs] [Bug 35582] Advanced search languages should be listed with selected UI language descriptions shown first if available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 --- Comment #8 from Lari Strand --- Seems a couple of language codes are missing altogether > from the English language descriptions in 23x. Here's a few: > > afa | Afroasiatic languages > bua | Buriat > fro | French, Old (ca. 842-1400) > haw | Hawaiian > lad | Ladino > nai | North American Indian languages > tmh | Tamashek > wol | Wolof > Sorry these were missing from our Finnish/Swedish translations. English translations that seem to be missing: afa, chu, den, haw, sqn -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:44:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:44:18 +0000 Subject: [Koha-bugs] [Bug 35723] New: Remove call to transferbook from Recalls Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35723 Bug ID: 35723 Summary: Remove call to transferbook from Recalls Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Koha::Item->request_transfer has existed for a couple of years now.. the use of C4::Circulation::transferbook should never have made it into the Recalls code during QA :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:44:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:44:41 +0000 Subject: [Koha-bugs] [Bug 1707] Search for patron '%' returns all results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 --- Comment #18 from Nick Clemens --- (In reply to Katrin Fischer from comment #17) > Could we close this with the "new" API based patron search? +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:44:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:44:55 +0000 Subject: [Koha-bugs] [Bug 35723] Remove call to transferbook from Recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35723 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22161 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22161 [Bug 22161] Move C4::Circulation::transferbook and C4::Items::ModItemTransfer to Koha namespace -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:44:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:44:55 +0000 Subject: [Koha-bugs] [Bug 22161] Move C4::Circulation::transferbook and C4::Items::ModItemTransfer to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22161 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35723 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35723 [Bug 35723] Remove call to transferbook from Recalls -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:49:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:49:31 +0000 Subject: [Koha-bugs] [Bug 1707] Search for patron '%' returns all results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:49:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:49:32 +0000 Subject: [Koha-bugs] [Bug 6253] Unified Patron Search subroutine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6253 Bug 6253 depends on bug 1707, which changed state. Bug 1707 Summary: Search for patron '%' returns all results https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:56:51 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:56:51 +0000 Subject: [Koha-bugs] [Bug 35721] Replace ModItemTransfer calls in circ/returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35721 --- Comment #1 from Martin Renvoize --- Created attachment 160625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160625&action=edit Bug 35721: ModItemTransfer -> Koha::Item->request_transfer - returns.pl This patch replaces the call to ModItemTransfer in circ/returns.pl with a call to Koha::Item->request_transfer and Koha::Item::Transfer->transit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:57:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:57:01 +0000 Subject: [Koha-bugs] [Bug 35721] Replace ModItemTransfer calls in circ/returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35721 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:57:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 12:57:17 +0000 Subject: [Koha-bugs] [Bug 35721] Replace ModItemTransfer calls in circ/returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35721 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 14:00:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 13:00:40 +0000 Subject: [Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 --- Comment #25 from Jonathan Druart --- What's the next step then, Victor? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 14:22:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 13:22:55 +0000 Subject: [Koha-bugs] [Bug 35530] Can't tell if UserCSS and UserJS in libraries are for staff interface or OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can't tell if UserCSS and |Can't tell if UserCSS and |UserJS in ibraries are for |UserJS in libraries are for |staff interface or OPAC |staff interface or OPAC CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 14:29:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 13:29:09 +0000 Subject: [Koha-bugs] [Bug 35530] Can't tell if UserCSS and UserJS in libraries are for staff interface or OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 14:33:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 13:33:14 +0000 Subject: [Koha-bugs] [Bug 35530] Can't tell if UserCSS and UserJS in libraries are for staff interface or OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 14:33:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 13:33:16 +0000 Subject: [Koha-bugs] [Bug 35530] Can't tell if UserCSS and UserJS in libraries are for staff interface or OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 --- Comment #1 from Fridolin Somers --- Created attachment 160626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160626&action=edit Bug 35530: Tell UserCSS and UserJS in libraries administration are for OPAC In libraries administration new fields UserCSS and UserJS are for OPAC, this should be in label. This patch uses text "Specific OPAC CSS", since the system preference OPACUserCSS as help : Library specific CSS can be defined in ... Test plan 1) Go to Administration > Libraries 2) Modify a library 3) Check you see new labels -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:06:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 14:06:08 +0000 Subject: [Koha-bugs] [Bug 35658] Typo in /patrons/:patron_id/holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35658 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.02 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:06:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 14:06:55 +0000 Subject: [Koha-bugs] [Bug 35698] Wrong bug number in db_revs/220600084.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35698 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.02 released in| | --- Comment #3 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:15:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 14:15:20 +0000 Subject: [Koha-bugs] [Bug 35688] RFID Envisionware Software Requires Static Page Title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35688 --- Comment #2 from Eliana --- I submitted this on behalf of another institution, but I can have them pass that question onto Envisionware! I'm guessing they probably would have suggested that if it was an option, but it doesn't hurt to check. Thank you for the suggestion. (In reply to Katrin Fischer from comment #1) > Hi Eliana, have you checked with your support provider if you maybe can use > a wildcard/truncation in the software settings? If you could tell the > software to look or a page title of "Check in > Circulation*" that could > solve your issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:16:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 14:16:59 +0000 Subject: [Koha-bugs] [Bug 35070] Koha plugins implementing "background_jobs" hook can't provide view template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35070 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #23 from Fridolin Somers --- Hook moved in wiki page : https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks#Implemented_hooks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:23:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 14:23:01 +0000 Subject: [Koha-bugs] [Bug 35686] Case missing from installer step 3 template title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 --- Comment #4 from Owen Leonard --- Created attachment 160627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160627&action=edit Bug 35686: (follow-up) Correct page heading -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:26:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 14:26:24 +0000 Subject: [Koha-bugs] [Bug 35502] [Omnibus] Rewrite koha-restore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35502 --- Comment #1 from Magnus Enger --- koha-restore rebuilds Zebra: koha-rebuild-zebra --full "$name" But there is nothing similar if the site is configured to use Elasticsearch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:26:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 14:26:48 +0000 Subject: [Koha-bugs] [Bug 30623] Copy permissions from one user to another In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30623 --- Comment #16 from Owen Leonard --- (In reply to Marcel de Rooy from comment #7) > Moving this to In Discussion temporarily. Will mail QA about it. I'm curious whether there has been a QA team discussion about this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:28:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 14:28:38 +0000 Subject: [Koha-bugs] [Bug 35070] Koha plugins implementing "background_jobs" hook can't provide view template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35070 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.02 released in| | --- Comment #24 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:29:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 14:29:11 +0000 Subject: [Koha-bugs] [Bug 35724] New: Define non-standard port numbers for SFTP upload/download in EDI accounts Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35724 Bug ID: 35724 Summary: Define non-standard port numbers for SFTP upload/download in EDI accounts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org We have a partner library that has one EDI vendor that will only accept Koha connecting on port 10022. Currently Koha will only connect on port 22, so this library cannot download EDI files from this vendor. It would be helpful if libraries could define a non-standard SFTP ports for uploading and downloading, at a EDI account level (not a global level) as different vendors may require different ports to be used. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:29:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 14:29:32 +0000 Subject: [Koha-bugs] [Bug 35724] Define non-standard port numbers for SFTP upload/download in EDI accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35724 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alexbuckley at catalyst.net.nz |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:30:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 14:30:26 +0000 Subject: [Koha-bugs] [Bug 35477] Adding non-existent items to the waiting list should display a warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35477 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #19 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:32:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 14:32:13 +0000 Subject: [Koha-bugs] [Bug 34900] The translation of the string "The " should depend on context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #31 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:34:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 14:34:14 +0000 Subject: [Koha-bugs] [Bug 35629] Redundant code in includes/patron-search.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35629 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #10 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:35:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 14:35:14 +0000 Subject: [Koha-bugs] [Bug 35696] Transit status not properly updated for items advanced in Stock Rotation tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35696 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.02 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:36:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 14:36:46 +0000 Subject: [Koha-bugs] [Bug 35587] Items lose their lost status when check-in triggers a transfer even though BlockReturnOfLostItems is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35587 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #14 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:42:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 14:42:57 +0000 Subject: [Koha-bugs] [Bug 35725] New: ILL - Generic master form does not keep patron and cardnumber when changing type Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35725 Bug ID: 35725 Summary: ILL - Generic master form does not keep patron and cardnumber when changing type Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: pedro.amorim at ptfs-europe.com CC: pedro.amorim at ptfs-europe.com Depends on: 35570 Test plan: 1) Apply 35570 2) Enable ILLModule sys pref through UI, or run: echo "update systempreferences set value = 1 where variable = \"ILLModule\";" | koha-mysql kohadev 3) Create a new Standard request, visit: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 4) Input a cardnumber and/or set a library at the bottom under "Patron options". 5) Change the type (top of the form). Notice the data from step 4) is gone. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 [Bug 35570] Add a generic master form in ILL -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:42:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 14:42:57 +0000 Subject: [Koha-bugs] [Bug 35570] Add a generic master form in ILL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35725 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35725 [Bug 35725] ILL - Generic master form does not keep patron and cardnumber when changing type -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:42:58 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 14:42:58 +0000 Subject: [Koha-bugs] [Bug 35552] Cannot change column 'itemnumber': used in a foreign key constraint 'tmp_holdsqueue_ibfk_1' at /usr/share/koha/lib/C4/Installer.pm line 741 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35552 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin Somers --- Duplicate of Bug 35687 ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:42:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 14:42:59 +0000 Subject: [Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160623|0 |1 is obsolete| | --- Comment #12 from Nick Clemens --- Created attachment 160628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160628&action=edit Bug 35100: Various fixes 1) Don't automagically always set a transfer to in transit on checkin.. wait for the user to actually confirm that's the case 2) New transfers triggered by a hold should take precidence, so hide transfers for any other reason from display 3) Remove current_branchtransfers prefetch from detail.pl as doing a prefetch completely nukes the order_by that this transfer method relies heavily upon to get the right modified FIFO transfer of the queue. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:43:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 14:43:03 +0000 Subject: [Koha-bugs] [Bug 35552] Cannot change column 'itemnumber': used in a foreign key constraint 'tmp_holdsqueue_ibfk_1' at /usr/share/koha/lib/C4/Installer.pm line 741 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35552 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35687 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:43:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 14:43:03 +0000 Subject: [Koha-bugs] [Bug 35687] Upgrade to 23.06.00.013 may fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35552 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:43:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 14:43:45 +0000 Subject: [Koha-bugs] [Bug 35725] ILL - Generic master form does not keep patron and cardnumber when changing type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35725 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:43:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 14:43:48 +0000 Subject: [Koha-bugs] [Bug 35725] ILL - Generic master form does not keep patron and cardnumber when changing type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35725 --- Comment #1 from Pedro Amorim --- Created attachment 160629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160629&action=edit 35725: Keep cardnumber and library data when changing request type -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:45:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 14:45:21 +0000 Subject: [Koha-bugs] [Bug 35725] ILL - Generic master form does not keep patron and cardnumber when changing type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35725 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160629|0 |1 is obsolete| | --- Comment #2 from Pedro Amorim --- Created attachment 160630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160630&action=edit Bug 35725: Keep cardnumber and library data when changing request type Test plan: 1) Apply 35570 2) Enable ILLModule sys pref through UI, or run: echo "update systempreferences set value = 1 where variable = \"ILLModule\";" | koha-mysql kohadev 3) Create a new Standard request, visit: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 4) Input a cardnumber and/or set a library at the bottom under "Patron options". 5) Change the type (top of the form). Notice the data from step 4) is gone. 6) Apply patch. Repeat test plan and notice data is kept when changing request type. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:45:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 14:45:50 +0000 Subject: [Koha-bugs] [Bug 35725] ILL - Generic master form does not keep patron and cardnumber when changing type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35725 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com, | |katrin.fischer at bsz-bw.de, | |magnus at libriotech.no, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:46:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 14:46:06 +0000 Subject: [Koha-bugs] [Bug 35725] ILL - Generic master form does not keep patron and cardnumber when changing type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35725 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pedro.amorim at ptfs-europe.co |ity.org |m Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:48:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 14:48:41 +0000 Subject: [Koha-bugs] [Bug 35721] Replace ModItemTransfer calls in circ/returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35721 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160625|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 160631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160631&action=edit Bug 35721: ModItemTransfer -> Koha::Item->request_transfer - returns.pl This patch replaces the call to ModItemTransfer in circ/returns.pl with a call to Koha::Item->request_transfer and Koha::Item::Transfer->transit. Test plan 1) Set 'AutomaticItemReturn' to "Don't" 2) Check an item in at a location other than it's 'home' or 'holding' branch 3) Note you should be asked a about returning the item to another branch 4) Opting to not proceed should NOT result in a row in the branchtransfers table 5) Option to proceed (either with a print slip or just 'OK') should result in a branchtransfer from the current checkin branch to the home or holding branch depending on the circulation rules. 5a) The item should be marked as immediately in transit in, i.e. the 'datesent' set to today. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:51:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 14:51:38 +0000 Subject: [Koha-bugs] [Bug 19605] ILL backends should be pluggable through regular Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|19822 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 [Bug 19822] Add system preferences for ILL Module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:51:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 14:51:38 +0000 Subject: [Koha-bugs] [Bug 19822] Add system preferences for ILL Module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|19605 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605 [Bug 19605] ILL backends should be pluggable through regular Koha plugins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:56:51 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 14:56:51 +0000 Subject: [Koha-bugs] [Bug 35721] Replace ModItemTransfer calls in circ/returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35721 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160631|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 160632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160632&action=edit Bug 35721: ModItemTransfer -> Koha::Item->request_transfer - returns.pl This patch replaces the call to ModItemTransfer in circ/returns.pl with a call to Koha::Item->request_transfer and Koha::Item::Transfer->transit. Test plan 1) Set 'AutomaticItemReturn' to "Don't" 2) Check an item in at a location other than it's 'home' or 'holding' branch 3) Note you should be asked a about returning the item to another branch 4) Opting to not proceed should NOT result in a row in the branchtransfers table 5) Option to proceed (either with a print slip or just 'OK') should result in a branchtransfer from the current checkin branch to the home or holding branch depending on the circulation rules. 5a) The item should be marked as immediately in transit in, i.e. the 'datesent' set to today. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 16:07:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 15:07:52 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 Matthias changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 16:07:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 15:07:54 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 Matthias changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160114|0 |1 is obsolete| | --- Comment #41 from Matthias --- Created attachment 160633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160633&action=edit Bug 29393: Prevent SQL errors when SQL strict mode is set Signed-off-by: matthias -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 16:10:51 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 15:10:51 +0000 Subject: [Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159106|0 |1 is obsolete| | --- Comment #22 from Pedro Amorim --- Created attachment 160634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160634&action=edit Bug 35331: Add table actions hook to ILL table Test plan, k-t-d, apply patches: 1) Install FreeForm backend, enable ILLModule sys pref, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Navigate to ILL requests, visit: /cgi-bin/koha/ill/ill-requests.pl 3) Click '+New ILL request', select a type, enter an existing cardnumber (e.g. '42') and pick a library. Click 'Create'. 4) Visit ILL requests again, repeat 2) 5) Notice the row for the created request has the already existing action button 'Manage request' 6) Install the ILL actions plugin, located at: https://github.com/PTFS-Europe/koha-plugin-ill-actions/releases/tag/v1.0.0 7) Restart plack, run: koha-plack --restart kohadev 8) Repeat 4) and 5). Notice the row for the created request now has a new custom action in addition to the already existing core one. Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 16:10:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 15:10:53 +0000 Subject: [Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159107|0 |1 is obsolete| | --- Comment #23 from Pedro Amorim --- Created attachment 160635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160635&action=edit Bug 35331: Add plugin hook tests prove t/db_dependent/Koha/Plugins/Ill_hooks.t Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 16:10:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 15:10:57 +0000 Subject: [Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159108|0 |1 is obsolete| | --- Comment #24 from Pedro Amorim --- Created attachment 160636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160636&action=edit Bug 35331: (QA follow-up): Avoid code pattern iterating on plugin responses (see bug 28010) Use plugin call pattern established in bug 28211. Please utilize version 1.0.1 of the plugin to test this follow-up: https://github.com/PTFS-Europe/koha-plugin-ill-actions/releases/tag/v1.0.1 Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 16:11:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 15:11:00 +0000 Subject: [Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159109|0 |1 is obsolete| | --- Comment #25 from Pedro Amorim --- Created attachment 160637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160637&action=edit Bug 35331: (QA follow-up): Patron ILL history With the previous patches applied and successfull test plans, access the users ILL history page, visit: /cgi-bin/koha/members/ill-requests.pl?borrowernumber=51 Notice you get an error. Apply this patch, and try again, notice the error is gone and the custom plugin action is also in the patron's ILL history table Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 16:11:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 15:11:11 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 Matthias changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160633|0 |1 is obsolete| | --- Comment #42 from Matthias --- Created attachment 160638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160638&action=edit Bug 29393: Prevent SQL errors when SQL strict mode is set Signed-off-by: matthias -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 16:11:28 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 15:11:28 +0000 Subject: [Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #26 from Pedro Amorim --- It no longer applied after bug 35070. Rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 16:11:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 15:11:31 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 Phan Tung Bui changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160638|0 |1 is obsolete| | --- Comment #43 from Phan Tung Bui --- Created attachment 160639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160639&action=edit Bug 29393: Prevent SQL errors when SQL strict mode is set Signed-off-by: Phan Tung Bui -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 16:50:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 15:50:46 +0000 Subject: [Koha-bugs] [Bug 35554] Authority search popup is only 700px In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 16:50:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 15:50:49 +0000 Subject: [Koha-bugs] [Bug 35554] Authority search popup is only 700px In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159778|0 |1 is obsolete| | --- Comment #4 from Fridolin Somers --- Created attachment 160640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160640&action=edit Bug 35554: Authority search popup width 800px Authority search popup is only 700 pixels width. Most popups use 800 pixels, like the z3950 one. Test plan : 1) Edit a biblio record 2) Click on value builder in a field linked to authority (ie 700) 3) Check popup is 800 pixels wide 4) Same with advanced editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 16:51:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 15:51:54 +0000 Subject: [Koha-bugs] [Bug 35554] Authority search popup is only 700px In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 --- Comment #5 from Fridolin Somers --- (In reply to Anneli Österman from comment #3) > I had the same test results as Barbara in PTFS Europe's sandbox. Pop up > doesn't get any wider. Indeed ^^ Code to impact is in JS file, basic and advanced editors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 17:03:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 16:03:22 +0000 Subject: [Koha-bugs] [Bug 24731] Privacy concerns in Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24731 Brendon Ford changed: What |Removed |Added ---------------------------------------------------------------------------- CC|brendon.ford at manhattan.edu | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 17:04:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 16:04:03 +0000 Subject: [Koha-bugs] [Bug 23660] Add system preference to remove message body from sent notices after notice status switches to sent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23660 Brendon Ford changed: What |Removed |Added ---------------------------------------------------------------------------- CC|brendon.ford at manhattan.edu | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 17:11:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 16:11:31 +0000 Subject: [Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160557|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 160641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160641&action=edit Bug 35100: Unit tests This patch adds a unit test to ensure StockrotationAdvance transfers are not cancelled from request_transfer when called with 'replace'. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 17:11:33 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 16:11:33 +0000 Subject: [Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160558|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 160642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160642&action=edit Bug 35100: Prevent StockrotationAdvance transfers from being cancelled ModItemTransfer is still very heavy handed and outright overrules existing transfers in the queue. For StockrotationAdvance transfers it's important that they remain in the queue to get actioned later, even if a higher precident transfer is actions in the interim. This patch adds a clause to the cancellation call within request_transfer such that StockrationAdvance transfers are left in tact for the next time the item is checked in. Test plan 1) Item is added to stock rotation 2) The cronjob creates a 'StockRotationAdvance' transfer 3) The item is checked in, which initiates the transfer, however, a hold is triggered 4) The hold is confirmed, which replaces the StockRotationAdvance 5) The item is checked out 6) The item is checked in, which initiates the transfer again 7) The item is checked in at it's destination and the StockrotationAdvance transfer has the proper date arrived date set. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 17:11:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 16:11:36 +0000 Subject: [Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160628|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize --- Created attachment 160643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160643&action=edit Bug 35100: Various fixes 1) Don't automagically always set a transfer to in transit on checkin.. wait for the user to actually confirm that's the case 2) New transfers triggered by a hold should take precidence, so hide transfers for any other reason from display 3) Update get_transfer and get_transfers to ensure ordering isn't lost when prefetch is used and add tests for this Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 17:12:23 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 16:12:23 +0000 Subject: [Koha-bugs] [Bug 35724] Define non-standard port numbers for SFTP upload/download in EDI accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35724 --- Comment #1 from Alex Buckley --- Created attachment 160644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160644&action=edit Bug 35724: Database changes Sponsored-by: Waikato Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 17:12:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 16:12:38 +0000 Subject: [Koha-bugs] [Bug 35724] Define non-standard port numbers for SFTP upload/download in EDI accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35724 --- Comment #2 from Alex Buckley --- Created attachment 160645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160645&action=edit Bug 35724: Template changes Sponsored-by: Waikato Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 17:13:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 16:13:04 +0000 Subject: [Koha-bugs] [Bug 35724] Define non-standard port numbers for SFTP upload/download in EDI accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35724 --- Comment #3 from Alex Buckley --- Created attachment 160646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160646&action=edit Bug 35724: Define non-standard ports for EDI SFTP in EDI accounts Not all EDI vendors accept Koha servers connecting on port 22, sometimes they require a different port to be used, so it would be helpful for librarians to be able to configure non-standard EDI SFTP ports themselves. Test plan: 1. Set EDIFACT syspref = 'Enable' and define a EDI account: Administration > Acquisition parameters > EDI accounts. 2. Create an EDI order: https://koha-community.org/manual/latest/en/html/acquisitions.html#ordering-via-edi 3. Confirm you can upload the EDI order and download the vendor invoice. 4. Apply patches, update database, and restart services. 5. Go to the EDI account you made in #1. 6. Confirm there are two new fields: Upload port and Download port, both have the value of 22. 7. Create a new EDI order. 8. Confirm you can upload the EDI order and download the vendor invoice. 9. Change the EDI account. Set the Download port = 10022. 10. Create a third EDI order. 11. Confirm you can upload the EDI order and download the vendor invoice. Sponsored-by: Waikato Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 17:18:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 16:18:27 +0000 Subject: [Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34639 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34639 [Bug 34639] Item shown in transit on detail.pl even if marked as arrived or cancelled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 17:18:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 16:18:27 +0000 Subject: [Koha-bugs] [Bug 34639] Item shown in transit on detail.pl even if marked as arrived or cancelled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34639 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35100 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 17:27:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 16:27:17 +0000 Subject: [Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160643|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize --- Created attachment 160647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160647&action=edit Bug 35100: Various fixes 1) Don't automagically always set a transfer to in transit on checkin.. wait for the user to actually confirm that's the case 2) New transfers triggered by a hold should take precidence, so hide transfers for any other reason from display 3) Update get_transfer and get_transfers to ensure ordering isn't lost when prefetch is used and add tests for this Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 17:31:25 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 16:31:25 +0000 Subject: [Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160647|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize --- Created attachment 160648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160648&action=edit Bug 35100: Various fixes 1) Don't automagically always set a transfer to in transit on checkin.. wait for the user to actually confirm that's the case 2) New transfers triggered by a hold should take precidence, so hide transfers for any other reason from display 3) Update get_transfer and get_transfers to ensure ordering isn't lost when prefetch is used and add tests for this Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 17:33:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 16:33:38 +0000 Subject: [Koha-bugs] [Bug 35721] Replace ModItemTransfer calls in circ/returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35721 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160632|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 160649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160649&action=edit Bug 35721: ModItemTransfer -> Koha::Item->request_transfer - returns.pl This patch replaces the call to ModItemTransfer in circ/returns.pl with a call to Koha::Item->request_transfer and Koha::Item::Transfer->transit. Test plan 1) Set 'AutomaticItemReturn' to "Don't" 2) Check an item in at a location other than it's 'home' or 'holding' branch 3) Note you should be asked a about returning the item to another branch 4) Opting to not proceed should NOT result in a row in the branchtransfers table 5) Option to proceed (either with a print slip or just 'OK') should result in a branchtransfer from the current checkin branch to the home or holding branch depending on the circulation rules. 5a) The item should be marked as immediately in transit in, i.e. the 'datesent' set to today. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 17:37:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 16:37:54 +0000 Subject: [Koha-bugs] [Bug 35726] New: Add ability to edit automatic item modification by age rules individually Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35726 Bug ID: 35726 Summary: Add ability to edit automatic item modification by age rules individually Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: esther.melander at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When there are several rules, it would be nice if it were possible to edit individual rules. Right now, in order to edit one rule, all rules are opened for editing. This could be done by adding an edit button at the end of the row in the table that lists the rules. As an extension, the rules table should be sortable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 17:56:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 16:56:19 +0000 Subject: [Koha-bugs] [Bug 35725] ILL - Generic master form does not keep patron and cardnumber when changing type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35725 --- Comment #3 from Pedro Amorim --- Created attachment 160650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160650&action=edit Bug 35725: Fix 'Create' button enabled/disabled The previous patch fixed what it stated, but uncovered a new issue: If you input a cardnumber + a branchcode and then change type, the 'Create' button becomes disabled This happens because the trigger for it is on change only, the current patch updates this to also happen on DOMContentLoaded. Test plan: 1) Apply previous patch 2) Do steps from previous patch plan up to and including step 5) 3) Click 'Create'. Notice it doesn't submit (nothing happens). 4) Apply this patch and do a hard reload (clearing browser js cache) 5) Repeat steps 1) to 3). Notice it now submits correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 17:56:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 16:56:37 +0000 Subject: [Koha-bugs] [Bug 35727] New: Unused code in HoldsQueue::MapItemsToHoldRequests Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35727 Bug ID: 35727 Summary: Unused code in HoldsQueue::MapItemsToHoldRequests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: andreas.jonsson at kreablo.se QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The hash %specific_items_requested is computed but never used anywhere. I went all the way back to v3.0.6 and couldn't find any sign that it has ever been used. # identify item-level requests my %specific_items_requested = map { $_->{itemnumber} => 1 } grep { defined($_->{itemnumber}) } @$hold_requests; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 17:56:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 16:56:48 +0000 Subject: [Koha-bugs] [Bug 35707] Item statuses in the holdings table on biblio details should appear one per line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35707 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 17:56:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 16:56:50 +0000 Subject: [Koha-bugs] [Bug 35707] Item statuses in the holdings table on biblio details should appear one per line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35707 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160571|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 160651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160651&action=edit Bug 35707: (alternate) Add clearfix to item statuses This proposed alterantive patch adds changes the status s to
    s. A div is basically the block-level equivalent of a span. This has the same effect of pushing each status onto its own line. The patch also adds generic "item_status" class to the
    s as well so that we can attach a consistent style to all statuses. The patch includes a small amount of padding on these items in order to repeat legibility. To test, apply the patch and rebuild the staff interface CSS. 1) Add an item to stockrotation and trigger the first transfer 2) Place a hold on the item 3) Note that you will now see two statuses, one above the other as displayed in the screenshots attached to the bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 18:00:58 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 17:00:58 +0000 Subject: [Koha-bugs] [Bug 35727] Unused code in HoldsQueue::MapItemsToHoldRequests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35727 --- Comment #1 from Andreas Jonsson --- Created attachment 160652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160652&action=edit Bug 35727 Remove unused code in HoldsQueue::MapItemsToHoldRequests Test plan: prove t/db_dependent/HoldsQueue.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 18:01:25 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 17:01:25 +0000 Subject: [Koha-bugs] [Bug 35727] Unused code in HoldsQueue::MapItemsToHoldRequests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35727 Andreas Jonsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 18:02:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 17:02:13 +0000 Subject: [Koha-bugs] [Bug 35584] Missing licenses in about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 18:02:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 17:02:15 +0000 Subject: [Koha-bugs] [Bug 35584] Missing licenses in about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 --- Comment #13 from Owen Leonard --- Created attachment 160653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160653&action=edit Bug 35584: (follow-up) Remove duplicate license entry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 18:10:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 17:10:13 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35721 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35721 [Bug 35721] Replace ModItemTransfer calls in circ/returns.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 18:10:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 17:10:13 +0000 Subject: [Koha-bugs] [Bug 35721] Replace ModItemTransfer calls in circ/returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35721 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28294 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 18:48:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 17:48:00 +0000 Subject: [Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 19:53:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 18:53:36 +0000 Subject: [Koha-bugs] [Bug 32105] Patron lists needs to share to specific people or groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 Matthias Le Gac changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |matthias.le-gac at inlibro.com --- Comment #4 from Matthias Le Gac --- Patch doesn't apply. I have this error : Applying: Bug 32105 - Add Library and Individual sharing modes to Patron Lists error: sha1 information is lacking or useless (patron_lists/patron-lists-tab.pl). error: could not build fake ancestor Patch failed at 0001 Bug 32105 - Add Library and Individual sharing modes to Patron Lists hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-32105---Add-Library-and-Individual-sharing-mod-6hyf27nh.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 21:32:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 20:32:26 +0000 Subject: [Koha-bugs] [Bug 35554] Authority search popup is only 700px In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 Matthias Le Gac changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.le-gac at inlibro.com Status|Needs Signoff |Failed QA --- Comment #6 from Matthias Le Gac --- Failed QA The authority search popup remains at a width of 700 pixels after the patch is applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 21:33:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 20:33:45 +0000 Subject: [Koha-bugs] [Bug 32105] Patron lists needs to share to specific people or groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 Matthias Le Gac changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 21:41:10 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 20:41:10 +0000 Subject: [Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 --- Comment #26 from Victor Grousset/tuxayo --- Great, so the main idea of the patch doesn't have a fatal flaw. That was the main focus of the last few days. > What's the next step then There is this question remaining: Instead of having the flag window._pageFullyReady, should the problematic buttons be hidden in the HTML? (and *maybe* have a dummy button with a loading icon in place to show the user that stuff it loading) And then the stuff in $(document).ready() makes them visible after setting the onclick callback. And the test just waits for the button to be visible instead of the flag to be set. ---- Also, can we try without the sleeps (DT_delay) before wait_for_ajax? That's 10 seconds of sleep in total (because loop). And in my very numerous runs, I never had a failure where wait_for_ajax instantly returned and the table content wasn't loaded. So there are fair chances that the show checkout button isn't affected by the same issue as seen in bug 35284. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 21:46:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 20:46:38 +0000 Subject: [Koha-bugs] [Bug 35570] Add a generic master form in ILL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 21:46:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 20:46:41 +0000 Subject: [Koha-bugs] [Bug 35570] Add a generic master form in ILL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159942|0 |1 is obsolete| | --- Comment #15 from David Nind --- Created attachment 160654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160654&action=edit Bug 35570: Put 'FreeForm' backend into core as 'Standard' FreeForm copied as is from HEAD 369dffb159f1e70162b685b473dcf26c76f7e7e7 At https://github.com/PTFS-Europe/koha-ill-freeform/commits/reorganize_ILL/ Only edits made were 'freeform' -> 'standard' in the markup of the .inc files and some occurrences of FreeForm in Standard.pm (previous Base.pm) file. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 21:46:44 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 20:46:44 +0000 Subject: [Koha-bugs] [Bug 35570] Add a generic master form in ILL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159943|0 |1 is obsolete| | --- Comment #16 from David Nind --- Created attachment 160655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160655&action=edit Bug 35570: Consider 'Standard' core backend Added File::Basename qw( dirname ) Sorted Koha:: dependencies alphabetically DRYed load_backend a bit and included 'Standard' backend check Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 21:46:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 20:46:47 +0000 Subject: [Koha-bugs] [Bug 35570] Add a generic master form in ILL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159944|0 |1 is obsolete| | --- Comment #17 from David Nind --- Created attachment 160656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160656&action=edit Bug 35570: Atomicupdate Move stuff out of 'FreeForm' into 'Standard' This atomicupdate will printout the changes it made, if any. It will also print out the report IDs of reports that may contain occurrences of 'FreeForm'. This is to give the sys admin the chance to fix those reports before users. To test, empty k-t-d: 1) Run updatedatabase, notice nothing happens 2) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 3) Create a new 'FreeForm' ILL batch (requires a metadata enrichment plugin like https://github.com/PTFS-Europe/koha-plugin-api-pubmed) 4) Add '123' to the pubmedid list of identifiers and finish creating the batch 5) Upon creating the batch, you will now have 1 request, 1 batch and a few illrequestattributes in the 'FreeForm' backend 6) Run the updatedatabase again, notice the print outs. 7) Create a saved sql report like: 'Select * from illrequests where backend="FreeForm";' 8) Run the updatedatabase again, notice you get a warning for the above report Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 21:46:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 20:46:50 +0000 Subject: [Koha-bugs] [Bug 35570] Add a generic master form in ILL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159946|0 |1 is obsolete| | --- Comment #18 from David Nind --- Created attachment 160657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160657&action=edit Bug 35570: Prevent use of ILL module if deprecated FreeForm backend is installed Test plan: 1) This patch should not be applied in order to be able to go through the previous patch's test plan 2) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 3) Please note that you need to be using FreeForm's reorganize_ILL branch at: https://github.com/PTFS-Europe/koha-ill-freeform/commits/reorganize_ILL/ 4) Visit ILL page: /cgi-bin/koha/ill/ill-requests.pl 5) Notice there's a configuration error preventing the use of the ILL module. 6) Click the 'about page' link and verify there is a warning about FreeForm 7) Remove FreeForm from /kohadevbox/koha/Koha/Illbackends and refresh the page 8) Repeat 4), notice the requests are listed as expected and you can now use the ILL module again. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 21:46:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 20:46:54 +0000 Subject: [Koha-bugs] [Bug 35570] Add a generic master form in ILL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159947|0 |1 is obsolete| | Attachment #160457|0 |1 is obsolete| | --- Comment #19 from David Nind --- Created attachment 160658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160658&action=edit Bug 35570: (QA follow-up): Make QA script green, fix: - Variables declared in condition - Use of DateTime->now should certainly be replaced with dt_from_string (bug 24840) - missing_filter - forbidden pattern: Do not use line breaks inside template tags (bug 18675) - Attribute type should not be used for script tags (bug 20053) - File must have the exec flag - forbidden pattern: trailing space char - valid_template: /shared-includes/custom_fields.inc: not found Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 21:46:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 20:46:57 +0000 Subject: [Koha-bugs] [Bug 35570] Add a generic master form in ILL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160452|0 |1 is obsolete| | --- Comment #20 from David Nind --- Created attachment 160659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160659&action=edit Bug 35570: QA follow-up: Update updatedatabase report colors to base on bug 35681 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 21:47:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 20:47:00 +0000 Subject: [Koha-bugs] [Bug 35570] Add a generic master form in ILL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #21 from David Nind --- Created attachment 160660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160660&action=edit Bug 35570: (QA follow-up): Add FreeForm fix from https://github.com/PTFS-Europe/koha-ill-freeform/commit/9c9da5ff2815fb6ce0af0181341dea5ce8c3bb2e into this work. This is to keep this work up to date with latest FreeForm's fixes. See bug 35685 for context and test plan. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 21:49:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 20:49:17 +0000 Subject: [Koha-bugs] [Bug 35570] Add a generic master form in ILL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #22 from David Nind --- (In reply to Pedro Amorim from comment #14) ... > > I believe the error you're getting is because you may have skipped this step: > 3) Please note that you need to be using FreeForm's reorganize_ILL branch at: > https://github.com/PTFS-Europe/koha-ill-freeform/commits/reorganize_ILL/ > > After you git checkout reorganize_ILL in FreeForm you may have to koha-plack > --restart. Would you please try again? Reach out to me on IRC, I'm always > available. Thanks! Thanks Pedro. That was the issue! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 21:54:44 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 20:54:44 +0000 Subject: [Koha-bugs] [Bug 35554] Authority search popup is only 700px In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 Phan Tung Bui changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phan-tung.bui at inlibro.com --- Comment #7 from Phan Tung Bui --- Failed QA The width of the popup remains 700px -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 21:55:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 20:55:18 +0000 Subject: [Koha-bugs] [Bug 35570] Add a generic master form in ILL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #23 from David Nind --- Testing notes (using KTD): 1. Apply the first three patches: - Bug 35570: Put 'FreeForm' backend into core as 'Standard' - Bug 35570: Consider 'Standard' core backend - Bug 35570: Atomicupdate Notes: - Apply all the dependent bugs - For 35570 (this bug) use i (for interactive) and add a # hash in front of the patches not to apply at this time 2. Run the database update: updatedatabase => Output: Upgrade to 23.12.00.003 [18:41:32]: Bug 35681 - Test DB Rev output Something in red is a warning Somthing in yellow is a call to action Something in blue is for information only You could use 'WHITE' too? Or leave color off and stick to default DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35570.pl [18:41:32]: Bug 35570 - Update 'FreeForm' ILL backend to 'Standard' Bug 35570: Finished database update. DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35681.pl [18:41:32]: Bug 35681 - Test Atomic update output Something in red is a warning Somthing in yellow is a call to action Something in blue is for information only You could use 'WHITE' too? Or leave color off and stick to default 3. Install the FreeForm backend. Run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 4. Change the FreeForm branch to reorganize_ILL. From within the Koha/Illbackends/FreeForm directory: git checkout reorganize_ILL 5. Run flush_memcached and restart_all (not sure whether these are required here, but I ran them anyway). 6. Install the Pubmed plugin: - Download from https://github.com/PTFS-Europe/koha-plugin-api-pubmed - Upload the plugin: Koha administration > Plugins > Manage plugins - Run restart_all 7. Create a new 'FreeForm' ILL batch: - + New ILL requests batch - Select the 'FreeForm' option - Batch details: . Batch name: BZ35570 . Card number...: 42 (koha) . Library: Centerville - Select 'Continue' - Add '123' to the PubMed ID list of identifiers - Click 'Process identifiers' - Once processed, click 'Add items to batch' - Click 'Finish and view batch' => You now have 1 request, 1 batch and a few ILL request attributes in the 'FreeForm' backend 8. Run updatedatabase again, notice that there are now extra messages from the previous database update - "Updated ILL batches from 'FreeForm' to 'Standard'...": DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35570.pl [19:26:57]: Bug 35570 - Update 'FreeForm' ILL backend to 'Standard' Bug 35570: Updated ILL batches from 'FreeForm' to 'Standard Bug 35570: Updated ILL request attributes from 'FreeForm' to 'Standard Bug 35570: Updated ILL requests from 'FreeForm' to 'Standard Bug 35570: Finished database update. DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35681.pl [19:26:57]: Bug 35681 - Test Atomic update output Something in red is a warning Somthing in yellow is a call to action Something in blue is for information only You could use 'WHITE' too? Or leave color off and stick to default 9. Create a saved SQL report with this SQL (note that if you run the report you get no results): Select * from illrequests where backend="FreeForm" 10. Run the updatedatabase again. Note that there is a warning about the report you created "Bug 35570: **ACTION REQUIRED**: Saved SQL reports containing occurrences of 'FreeForm' were found.....": DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35570.pl [19:30:47]: Bug 35570 - Update 'FreeForm' ILL backend to 'Standard' Bug 35570: **ACTION REQUIRED**: Saved SQL reports containing occurrences of 'FreeForm' were found. The following reports MUST be updated accordingly ('FreeForm' -> 'Standard'): Report ID: 1 | Edit link: http://kohadev-intra.koha-testing:8081/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Edit%20SQL DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35681.pl [19:30:47]: Bug 35681 - Test Atomic update output Something in red is a warning Somthing in yellow is a call to action Something in blue is for information only You could use 'WHITE' too? Or leave color off and stick to default 11. Apply the remainder of the patches for this bug: - Say no for all the dependencies, as they are already installed - For 35570 (this bug) use i (for interactive) and add a # hash in front of the first three patches - There is no need to run the databaseupdate again - Run flush_memcached and restart_all (not sure if this is required, but is what I normally do after applying a patch) 12. Go to the ILL page: Administration > ILL requests 13. Notice that there is a configuration error preventing the use of the ILL module. The message displayed is "ILL module configuration problem. Take a look at the about page". 14. Click the 'about page' link and verify there is a warning about the FreeForm backend: The ILL module is enabled, but the deprecated 'FreeForm' backend is installed. 'FreeForm' has since become part of core Koha as 'Standard'. All 'FreeForm' ILL content should've been migrated to 'Standard' upon upgrading Koha to 24.05. To avoid confusion or redundancy, please uninstall the 'FreeForm' backend before using the ILL module. 15. Remove the FreeForm backend from /kohadevbox/koha/Koha/Illbackends (sudo rm -R /kohadevbox/koha/Koha/Illbackends/FreeForm) and refresh the page. 16. Repeat step 12. Note that: - The requests are listed as expected, and you can now use the ILL module again. - For '+ New ILL requests batch', 'Standard' is now the only option shown. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 21:57:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 20:57:59 +0000 Subject: [Koha-bugs] [Bug 35570] Add a generic master form in ILL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #24 from David Nind --- Additional testing ================== I created a new ILL request and tested the various options available on the ILL requests page (this wasn't part of the test plan): - Confirm request: page not found (404) error when confirming request (URL was /cgi-bin/koha/ill/%2Fcgi-bin%2Fkoha%2Fill%2Fill-requests.pl%3Fmethod%3Dconfirm%26stage%3Dconfirm%26illrequest_id%3D2) - presume something else is required to configure this? - All the other areas seemed to work as expected: . Edit request . Place request with partner libraries (add a couple of patrons to the Inter-Library Loan patron category, make sure they have an email address) . Delete request . Edit item metadata . Send notice to patron (I added an email to the patron used to create the request, updated patron message preferences, and added an email address to the various email system preferences) . Display supplier metadata (found this confusing - it shows the request metadata, but this is the existing terminology) . ILL request log (changes made to the request show after enabling the IllLog system preference) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 22:27:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 21:27:19 +0000 Subject: [Koha-bugs] [Bug 35725] ILL - Generic master form does not keep patron and cardnumber when changing type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35725 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 22:27:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 21:27:21 +0000 Subject: [Koha-bugs] [Bug 35725] ILL - Generic master form does not keep patron and cardnumber when changing type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35725 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160630|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 160661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160661&action=edit Bug 35725: Keep cardnumber and library data when changing request type Test plan: 1) Apply 35570 2) Enable ILLModule sys pref through UI, or run: echo "update systempreferences set value = 1 where variable = \"ILLModule\";" | koha-mysql kohadev 3) Create a new Standard request, visit: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 4) Input a cardnumber and/or set a library at the bottom under "Patron options". 5) Change the type (top of the form). Notice the data from step 4) is gone. 6) Apply patch. Repeat test plan and notice data is kept when changing request type. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 22:27:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 21:27:24 +0000 Subject: [Koha-bugs] [Bug 35725] ILL - Generic master form does not keep patron and cardnumber when changing type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35725 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160650|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 160662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160662&action=edit Bug 35725: Fix 'Create' button enabled/disabled The previous patch fixed what it stated, but uncovered a new issue: If you input a cardnumber + a branchcode and then change type, the 'Create' button becomes disabled This happens because the trigger for it is on change only, the current patch updates this to also happen on DOMContentLoaded. Test plan: 1) Apply previous patch 2) Do steps from previous patch plan up to and including step 5) 3) Click 'Create'. Notice it doesn't submit (nothing happens). 4) Apply this patch and do a hard reload (clearing browser js cache) 5) Repeat steps 1) to 3). Notice it now submits correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 22:38:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 21:38:48 +0000 Subject: [Koha-bugs] [Bug 35707] Item statuses in the holdings table on biblio details should appear one per line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35707 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 22:38:51 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 21:38:51 +0000 Subject: [Koha-bugs] [Bug 35707] Item statuses in the holdings table on biblio details should appear one per line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35707 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160651|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 160663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160663&action=edit Bug 35707: (alternate) Add clearfix to item statuses This proposed alterantive patch adds changes the status s to
    s. A div is basically the block-level equivalent of a span. This has the same effect of pushing each status onto its own line. The patch also adds generic "item_status" class to the
    s as well so that we can attach a consistent style to all statuses. The patch includes a small amount of padding on these items in order to repeat legibility. To test, apply the patch and rebuild the staff interface CSS. 1) Add an item to stockrotation and trigger the first transfer 2) Place a hold on the item 3) Note that you will now see two statuses, one above the other as displayed in the screenshots attached to the bug. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 22:42:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 21:42:20 +0000 Subject: [Koha-bugs] [Bug 35727] Unused code in HoldsQueue::MapItemsToHoldRequests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35727 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 22:42:23 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 21:42:23 +0000 Subject: [Koha-bugs] [Bug 35727] Unused code in HoldsQueue::MapItemsToHoldRequests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35727 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160652|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 160664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160664&action=edit Bug 35727 Remove unused code in HoldsQueue::MapItemsToHoldRequests Test plan: prove t/db_dependent/HoldsQueue.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 23:02:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 22:02:01 +0000 Subject: [Koha-bugs] [Bug 35721] Replace ModItemTransfer calls in circ/returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35721 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 23:02:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 22:02:03 +0000 Subject: [Koha-bugs] [Bug 35721] Replace ModItemTransfer calls in circ/returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35721 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160649|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 160665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160665&action=edit Bug 35721: ModItemTransfer -> Koha::Item->request_transfer - returns.pl This patch replaces the call to ModItemTransfer in circ/returns.pl with a call to Koha::Item->request_transfer and Koha::Item::Transfer->transit. Test plan 1) Set 'AutomaticItemReturn' to "Don't" 2) Check an item in at a location other than it's 'home' or 'holding' branch 3) Note you should be asked a about returning the item to another branch 4) Opting to not proceed should NOT result in a row in the branchtransfers table 5) Option to proceed (either with a print slip or just 'OK') should result in a branchtransfer from the current checkin branch to the home or holding branch depending on the circulation rules. 5a) The item should be marked as immediately in transit in, i.e. the 'datesent' set to today. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 23:10:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 22:10:19 +0000 Subject: [Koha-bugs] [Bug 35530] Can't tell if UserCSS and UserJS in libraries are for staff interface or OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 23:10:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 22:10:21 +0000 Subject: [Koha-bugs] [Bug 35530] Can't tell if UserCSS and UserJS in libraries are for staff interface or OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160626|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 160666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160666&action=edit Bug 35530: Tell UserCSS and UserJS in libraries administration are for OPAC In libraries administration new fields UserCSS and UserJS are for OPAC, this should be in label. This patch uses text "Specific OPAC CSS", since the system preference OPACUserCSS as help : Library specific CSS can be defined in ... Test plan 1) Go to Administration > Libraries 2) Modify a library 3) Check you see new labels Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 23:17:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 22:17:32 +0000 Subject: [Koha-bugs] [Bug 35530] Can't tell if UserCSS and UserJS in libraries are for staff interface or OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- I don't mind the replacement labels, as they are a great improvement: - UserJS -> Specific OPAC JS - UserCSS -> Specific OPAC CSS Some alternatives: 1. Library specific OPAC JavaScript Library specific OPAC CSS 2. Library specific JavaScript for the OPAC Library specific CSS for the OPAC 3. OPAC JavaScript for this library OPAC CSS for this library I think I like 3 better, but leaving up to the QA Team. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 23:34:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 22:34:01 +0000 Subject: [Koha-bugs] [Bug 35530] Can't tell if UserCSS and UserJS in libraries are for staff interface or OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 --- Comment #4 from Katrin Fischer --- As we are on the library page, I feel like we don't need to point out that it's library specific, all the fields on the page are and it would help to keep the label/hint a bit shorter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 23:45:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 22:45:59 +0000 Subject: [Koha-bugs] [Bug 35633] Upgrade Chocolat JS library from v1.1.0 to v1.1.2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35633 Phan Tung Bui changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 23:46:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 22:46:01 +0000 Subject: [Koha-bugs] [Bug 35633] Upgrade Chocolat JS library from v1.1.0 to v1.1.2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35633 Phan Tung Bui changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160220|0 |1 is obsolete| | --- Comment #5 from Phan Tung Bui --- Created attachment 160667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160667&action=edit Bug 35633: (follow-up) Custom style updates This patch adds custom CSS to the OPAC and staff interface to override the default style of Chocolat controls (for left arrow, right arrow, loading, and close window). These controls are given a green color matching Koha's color scheme. The bibliographic detail pages in the OPAC and staff interface have been revised so that the inclusion of Chocolat CSS comes before the inclusion of Koha's global CSS. We should do this with third-party CSS so that it can be more easily overridden by ours. The patch also makes a minor change to chocolat.js to correct a bug. See commit 6ac89ca8558. To test, apply the patch and rebuild the OPAC and staff interface CSS. - Go to Administration -> System preferences and enable the AllowMultipleCovers, OPACLocalCoverImages, and LocalCoverImages system preferences. - Add a local cover image to a bibliographic record: - Locate a bibliographic record. - From the detail page, click the "Images" tab and then "Upload." - Upload an image to attach to the record. - Upload another image. - Return to the bibliographic detail page fro that record, and click the image you uploaded. - The full-page image viewer should appear, and the controls should look correct, with green matching Koha's color scheme: - The close button in the upper-right - The right-arrow, and then when you click through to the second image, the left-arrow. - In the footer, the "edit" link should work correctly. - Test that the "Full screen" control works too. - Click the "OPAC view" link to load the record in the OPAC, and perform the same tests. - Nicely done! Signed-off-by: Phan Tung Bui -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 23:47:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 22:47:46 +0000 Subject: [Koha-bugs] [Bug 35728] New: Add option to NOT redirect to result when search returns only one record Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35728 Bug ID: 35728 Summary: Add option to NOT redirect to result when search returns only one record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 23:49:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 22:49:22 +0000 Subject: [Koha-bugs] [Bug 35728] Add option to NOT redirect to result when search returns only one record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35728 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 23:55:25 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 22:55:25 +0000 Subject: [Koha-bugs] [Bug 34423] (proof-of-concept) Bugzilla could look better with a new skin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34423 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Chris Cormack --- This has been applied, I like it :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 00:01:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 23:01:54 +0000 Subject: [Koha-bugs] [Bug 34423] (proof-of-concept) Bugzilla could look better with a new skin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34423 --- Comment #3 from Chris Cormack --- Sorry I forgot to mention you will need to go to https://bugs.koha-community.org/bugzilla3/userprefs.cgi and set your skin to KohaV2 to see the new skin. Few little things to work out on smaller screens but people can test it now. I've symlinked in the repo so if you update it lemme know and ill do a git pull and you can see the changes in bugzilla -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 00:12:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 23:12:22 +0000 Subject: [Koha-bugs] [Bug 35530] Can't tell if UserCSS and UserJS in libraries are for staff interface or OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #5 from Lucas Gass --- (In reply to Katrin Fischer from comment #4) > As we are on the library page, I feel like we don't need to point out that > it's library specific, all the fields on the page are and it would help to > keep the label/hint a bit shorter. I agree. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 00:13:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 23:13:57 +0000 Subject: [Koha-bugs] [Bug 35728] Add option to NOT redirect to result when search returns only one record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35728 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 00:13:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 23:13:59 +0000 Subject: [Koha-bugs] [Bug 35728] Add option to NOT redirect to result when search returns only one record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35728 --- Comment #1 from Aleisha Amohia --- Created attachment 160668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160668&action=edit Bug 35728: Add ability to NOT redirect to result when search returns only one record This enhancement adds a new system preference RedirectToSoleResult. By default it is enabled, which matches current behaviour - to redirect to the detail page if it is the only search result. To test: 1) Apply the patch, install database updates, restart services. 2) Go to Koha Administration -> Global system preferences. The RedirectToSoleResult system preference is in the Searching tab. Confirm it is enabled (set to "Redirect") by default. 3) Conduct a catalogue search on the staff interface that you know will return a single result. Confirm you are redirected to the detail page. 4) Do the same search on the OPAC. Confirm you are redirected to the detail page. 5) Go back to the system preferences and disable the RedirectToSoleResult system preference by setting it to "Don't redirect" 6) Do the searches again on the staff interface and OPAC. Confirm you are NOT redirected to the detail page, and the search results page shows as expected. Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 00:23:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 23:23:26 +0000 Subject: [Koha-bugs] [Bug 11180] IP branch attribute should accept CIDR notation and add multiple ip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11180 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131927|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 160669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160669&action=edit Bug 11180: IP branch attribute should accept CIDR notation This patch adds the ability to set more than ip to IP setting of a branch and also CIDR notation can recognised also. Test plan: 1) Change systempreference AutoLocation to "Yes" 2) Go to the library settings ( Administration -> Libraries ) and you can add only one ip at format xxx.xxx.xxx.xxx or xxx.xxx.* 3) Apply patch 4) Go to the library settings and you can enter to IP setting those ip(s) you want seperate by space in any format like xxx.xxx.xxx.xxx or xxx.xxx.xxx.0/24 or xxx.xxx.xxx.* or only one also on the same formats. 3) Logout 4) Try to login from an ip that not belong on the set of ip that you enter before and now CIDR notation can regognized also and also you can have more than one ip for restriction. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 00:23:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 23:23:37 +0000 Subject: [Koha-bugs] [Bug 11180] IP branch attribute should accept CIDR notation and add multiple ip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11180 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131933|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 160670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160670&action=edit Bug 11180: IP branch attribute should accept CIDR notation and add multiple ip This patch adds the ability to set more than ip to IP setting of a branch and also CIDR notation can recognised also. Test plan: 1) Change systempreference AutoLocation to "Yes" 2) Go to the library settings ( Administration -> Libraries ) and you can add only one ip at format xxx.xxx.xxx.xxx or xxx.xxx.* 3) Apply patch 4) Go to the library settings and you can enter to IP setting those ip(s) you want seperate by space in any format like xxx.xxx.xxx.xxx or xxx.xxx.xxx.0/24 or xxx.xxx.xxx.* or only one also on the same formats. 3) Logout 4) Try to login from an ip that not belong on the set of ip that you enter before and now CIDR notation can regognized also and also you can have more than one ip for restriction. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 00:40:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 23:40:24 +0000 Subject: [Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |lucas at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 00:40:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 23:40:54 +0000 Subject: [Koha-bugs] [Bug 35517] Choose correct default header search tab according to permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35517 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159677|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo --- Created attachment 160671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160671&action=edit Bug 35517: Choose correct default header search tab according to permissions This patch adds some additional template logic to the header search form for the staff interface home page so that users with different permissions will see the correct tab in the header search form. To test, apply the patch and view the staff interface home page using a user with different permissions: - 'catalogue' and 'circulate' - Header should show circulation search - 'catalogue' and 'borrowers' - Header should show patron search - 'catalogue' only - Header should show catalog search Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 00:41:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 23:41:11 +0000 Subject: [Koha-bugs] [Bug 35517] Choose correct default header search tab according to permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35517 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Victor Grousset/tuxayo --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 00:41:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 23:41:46 +0000 Subject: [Koha-bugs] [Bug 31286] Embed see-from headings into bibliographic records export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31286 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 00:41:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 23:41:48 +0000 Subject: [Koha-bugs] [Bug 31286] Embed see-from headings into bibliographic records export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31286 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138520|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 160672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160672&action=edit Bug 31286: Embed see-from headings into bibliographic records export In misc/export_records.pl add an option to add see-from headings (from authorities 4xx) into bibliographic records export. Like it is done during record indexing. Test plan : 1) Choose a biblio record having a field (for example 650) linked to an authority with a see-form. 2) Export this record without see-from headings : misc/export_records.pl --starting_biblionumber=X --ending_biblionumber=X --filename /tmp/record_without.xml --format xml 3) Export this record with see-from headings : misc/export_records.pl --starting_biblionumber=X --ending_biblionumber=X --filename /tmp/record_with.xml --format xml --embed_see_from_headings 4) Compare /tmp/record_without.xml and /tmp/record_with.xml => you should see two 650, one with main heading and one with see-from heading Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 00:44:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 23:44:16 +0000 Subject: [Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #29 from Lucas Gass --- Working as described. QA script is mostly happy, 1 issue with file permissions that I am fixing in a follow-up. The rest of the code looks good. DBUpdate looks good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 00:44:51 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 23:44:51 +0000 Subject: [Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 00:44:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 23:44:54 +0000 Subject: [Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158528|0 |1 is obsolete| | --- Comment #30 from Lucas Gass --- Created attachment 160673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160673&action=edit Bug 34668: Add popup warn librarians of waiting holds when checking out When there are holds waiting for patrons, sometimes the librarian misses the "Holds waiting here" display. This patch adds a modal popup warning when checking out an item for a patron with waiting holds. Test plan: 1) find a user (user1) 2) find a biblio (biblio1) 3) add a hold for biblio1 to user1 (search biblio1 > Holds > find user1 > Place hold) 4) checkout biblio1 to another user if not already checked out and checkin through circulation page (not through the user page) > confirm hold 5) there should be a "Holds waiting here (1)" section added on user1 page 6) checkout any items that isn't the one on hold for user1 -> notice it just checks out as normal 7) apply patch and update database 8) go to administration > system preferences > switch "WaitingNotifyAtCheckout" to "Notify" 9) refresh page and redo step 6 -> notice there is now a modal to warn the librarian of a waiting hold click Ok to proceed with the checkout, click outside the modal to not do anything 10) additionnally, the popup shouldn't appear if we checkout any of user1's waiting hold Signed-off-by: Matt Blenkinsop Signed-off-by: Mia Kujala Signed-off-by: Kelly Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 00:44:56 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 23:44:56 +0000 Subject: [Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158529|0 |1 is obsolete| | --- Comment #31 from Lucas Gass --- Created attachment 160674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160674&action=edit Bug 34668: remove binding/unbinding event for one submit event Signed-off-by: Mia Kujala Signed-off-by: Kelly Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 00:44:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 23:44:59 +0000 Subject: [Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158530|0 |1 is obsolete| | --- Comment #32 from Lucas Gass --- Created attachment 160675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160675&action=edit Bug 34668: pass whole waiting_holds rs Signed-off-by: Kelly Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 00:45:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 23:45:02 +0000 Subject: [Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #33 from Lucas Gass --- Created attachment 160676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160676&action=edit Bug 34668: (QA follow-up) Change file permission Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 00:48:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 23:48:41 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #69 from Victor Grousset/tuxayo --- Hi :) change needed when bug 35517 (passed QA) is pushed to master (so soon unless a surprise comes up): Look at the patch: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160671&action=diff The change should be: [% ELSIF ( CAN_user_borrowers_edit_borrowers ) %] ↓↓ [% ELSIF ( CAN_user_borrowers_edit_borrowers ) || ( CAN_user_borrowers_list_borrowers ) %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 00:50:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 23:50:21 +0000 Subject: [Koha-bugs] [Bug 35686] Case missing from installer step 3 template title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |lucas at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 00:51:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 23:51:04 +0000 Subject: [Koha-bugs] [Bug 35686] Case missing from installer step 3 template title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 --- Comment #5 from Lucas Gass --- Straightforward and simple fixes, no issues with the QA tool. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 00:51:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 23:51:37 +0000 Subject: [Koha-bugs] [Bug 35686] Case missing from installer step 3 template title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 00:51:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 23:51:39 +0000 Subject: [Koha-bugs] [Bug 35686] Case missing from installer step 3 template title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160593|0 |1 is obsolete| | --- Comment #6 from Lucas Gass --- Created attachment 160677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160677&action=edit Bug 35686: Case missing from installer step 3 template title This patch adds a missing case to the display of the title on step 3 of the web installer. This resulted in an empty first part of the title: " > Web installer > Koha" To test, apply the patch and reset the database version from the command line in Koha Testing Docker: > koha-mysql kohadev > UPDATE systempreferences SET value = '23.1200002 WHERE variable = 'version'; > quit > Restart all - Go to the staff interface. You should be taken to the web installer. - Log in to the web installer and proceed through until you get to the "Updating database structure" page. - Confirm that the page title is correct. Signed-off-by: David Nind Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 00:51:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2024 23:51:41 +0000 Subject: [Koha-bugs] [Bug 35686] Case missing from installer step 3 template title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160627|0 |1 is obsolete| | --- Comment #7 from Lucas Gass --- Created attachment 160678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160678&action=edit Bug 35686: (follow-up) Correct page heading Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 01:35:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 00:35:14 +0000 Subject: [Koha-bugs] [Bug 32105] Patron lists needs to share to specific people or groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149475|0 |1 is obsolete| | --- Comment #5 from Michael Hafen --- Created attachment 160679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160679&action=edit Bug 32105 - Add Library and Individual sharing modes to Patron Lists [Rebase on master 2023-12-28] Test Plan: 1. apply patch, restart Plack, etc. 2. create or select three users, two at the same library and one not. 3. create or select a patron list owned by one of the users at the same library. 4. edit list and change sharing mode to 'Library and individuals'. 5. login as the other user at the same library and navigate to patron lists. 6. observe that the list is shared. 7. login as the third user and navigate to patron lists. 8. observe that the list is not shared with this user. 9. login as the owner of the list. 10. edit the list and add the third user as an individual. 11. login as the third user and navigate to patron lists. 12. observe that the list is now shared with the third user. 13. login as the owner of the list. 14. edit the list to change the sharing mode to 'Individuals'. 15. login as the second and third users. 16. observe that the list is not shared with the second user, but still is with the third user. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 02:11:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 01:11:36 +0000 Subject: [Koha-bugs] [Bug 35729] New: Coce Should Account for New ISBN 979* Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729 Bug ID: 35729 Summary: Coce Should Account for New ISBN 979* Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: kalleen at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Hi, I noticed that there was a cover mismatch with a coce_amazon cover because the new 2024 title has an ISBN of 9798885795692 (using the 979 instead of 978). There is an Italian title with an ISBN of 8885795692 that is showing instead. It looks like they have updated the valid ISBN standards: https://isbn.org/about_isbn_standard and it seems like coce should be updated to recognize this new standard and not match 9798885795692 to be the same as 8885795692. Thanks! Kal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 06:01:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 05:01:19 +0000 Subject: [Koha-bugs] [Bug 35730] New: No translation is required Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35730 Bug ID: 35730 Summary: No translation is required Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: translate.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: Igor.A.Sychev at mail.ru QA Contact: testopia at bugs.koha-community.org %s%sISBN: %s%s%s; %s%s%s%s -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 06:03:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 05:03:35 +0000 Subject: [Koha-bugs] [Bug 35731] New: No translation is required Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35731 Bug ID: 35731 Summary: No translation is required Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: translate.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: Igor.A.Sychev at mail.ru QA Contact: testopia at bugs.koha-community.org %sLCCN: %s%s%s -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 06:04:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 05:04:54 +0000 Subject: [Koha-bugs] [Bug 35732] New: No translation is required Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35732 Bug ID: 35732 Summary: No translation is required Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: translate.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: Igor.A.Sychev at mail.ru QA Contact: testopia at bugs.koha-community.org %sURL: %s%s%s -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 06:26:38 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 05:26:38 +0000 Subject: [Koha-bugs] [Bug 35728] Add option to NOT redirect to result when search returns only one record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35728 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #2 from David Nind --- Hi Aleisha. I like this! It looks like the patch(es) with the database update/system preference addition is missing... David Testing notes (using KTD and the sample data): 1. Search for higher-order for a single search result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 06:31:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 05:31:03 +0000 Subject: [Koha-bugs] [Bug 35545] "additional" item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35545 --- Comment #3 from Igor A. Sychev --- Created attachment 160680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160680&action=edit staff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 06:34:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 05:34:14 +0000 Subject: [Koha-bugs] [Bug 35545] "additional" item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35545 --- Comment #4 from Igor A. Sychev --- Created attachment 160681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160681&action=edit MARC preview -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 06:35:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 05:35:08 +0000 Subject: [Koha-bugs] [Bug 35545] "additional" item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35545 --- Comment #5 from Igor A. Sychev --- OPAC https://koha.lib.tpu.ru/cgi-bin/koha/opac-detail.pl?biblionumber=669655 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 06:37:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 05:37:27 +0000 Subject: [Koha-bugs] [Bug 35545] "additional" item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35545 --- Comment #6 from Igor A. Sychev --- Created attachment 160682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160682&action=edit OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 06:42:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 05:42:04 +0000 Subject: [Koha-bugs] [Bug 33364] Stop Holds to Pull report showing items that have been allocated to a recall In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33364 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from David Nind --- The patch for master still applies, however the tests are still failing. I haven't fully re-tested the 22.05 and master patches yet - see comment #10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 06:48:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 05:48:31 +0000 Subject: [Koha-bugs] [Bug 35697] Checkingout books causes a error 500 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35697 Pradeep changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agastilib at gmail.com --- Comment #2 from Pradeep --- I also experienced same problem. all other functions are working fine. While checking out it gives 500 error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 07:34:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 06:34:12 +0000 Subject: [Koha-bugs] [Bug 34423] (proof-of-concept) Bugzilla could look better with a new skin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34423 --- Comment #4 from Martin Renvoize --- This is looking great, nice one. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 07:35:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 06:35:21 +0000 Subject: [Koha-bugs] [Bug 35707] Item statuses in the holdings table on biblio details should appear one per line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35707 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 07:39:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 06:39:45 +0000 Subject: [Koha-bugs] [Bug 35716] Duplicated assets in both koha-tmpl/intra-tmpl and koha-tmpl/opac-tmpl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35716 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 07:58:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 06:58:18 +0000 Subject: [Koha-bugs] [Bug 35728] Add option to NOT redirect to result when search returns only one record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35728 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 08:10:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 07:10:12 +0000 Subject: [Koha-bugs] [Bug 35728] Add option to NOT redirect to result when search returns only one record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35728 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=1610 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 08:10:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 07:10:12 +0000 Subject: [Koha-bugs] [Bug 1610] Redirect to result when opac search returns only one item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1610 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35728 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 08:16:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 07:16:45 +0000 Subject: [Koha-bugs] [Bug 35729] Coce Should Account for New ISBN 979* In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- Thanks for reporting this one, Kal. I think this is going to have wide-ranging implications across a number of different areas of Koha (and other library systems). I haven't done anything with Coce but I'm going to think about some of those other consequences of this new(ish) prefix... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 08:24:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 07:24:06 +0000 Subject: [Koha-bugs] [Bug 11180] IP branch attribute should accept CIDR notation and add multiple ip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11180 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 08:30:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 07:30:24 +0000 Subject: [Koha-bugs] [Bug 35697] Checkingout books causes a error 500 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35697 --- Comment #3 from Katrin Fischer --- (In reply to Katrin Fischer from comment #1) > Please verify that your item has complete information. It needs: > > * an itemtype (MARC21 $y) > * a homebranch (MARC21 $a) > * a holdingbranch (MARC21 $b) > > If the item is complete, it would help to get the full error from the server > logs. Did you check these? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 08:31:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 07:31:36 +0000 Subject: [Koha-bugs] [Bug 35732] No translation is required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35732 --- Comment #1 from Katrin Fischer --- What is the issue you are trying to point out? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 08:32:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 07:32:22 +0000 Subject: [Koha-bugs] [Bug 35732] No translation is required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35732 --- Comment #2 from Katrin Fischer --- We can't assume URL is common with the English term in every language, so they should show in translations. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 08:37:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 07:37:48 +0000 Subject: [Koha-bugs] [Bug 35718] Remove ES6 warnings from JavaScript system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35718 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- If no one else gets this first, I'll try to look at it tomorrow or week after next... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 08:40:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 07:40:49 +0000 Subject: [Koha-bugs] [Bug 24778] Move from Memcached to Redis to solve L1 caching issues? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24778 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 09:06:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 08:06:49 +0000 Subject: [Koha-bugs] [Bug 35733] New: Request is denied for getting access token. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35733 Bug ID: 35733 Summary: Request is denied for getting access token. Change sponsored?: --- Product: Koha Version: 23.11 Hardware: PC OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: esharat1992 at gmail.com CC: tomascohen at gmail.com Hello, having a good day everyone. I am trying to get access token using python requests library but getting the error code 403 (access forbidden). But I am using bywater demo koha admin url then I got access token. I configured with same parameters in my admin interface and bywater demo admin interface. Need any extra apache or koha configuration for rest api from server side? Thanks in advance everyone. @Esharat Mia -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 09:13:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 08:13:40 +0000 Subject: [Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 --- Comment #27 from Jonathan Druart --- I do not longer recreate the failure locally so it's hard to help here. However I do not see how your approach is correct. Selenium waits for the page to load before starting the tests. I would add a wait_for_element_visible on the page before selecting the th. And I would not add more delay, 10 should be enough. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 09:25:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 08:25:08 +0000 Subject: [Koha-bugs] [Bug 22972] Proposal for enriching the bibliographic records with standard identifiers from authority data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22972 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #14 from Fridolin Somers --- diff --git a/installer/data/mysql/atomicupdate/bug-22972.pl b/installer/data/mysql/atomicupdate/bug-22972.pl new file mode 100644 Atomic updates need perm 755 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 09:33:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 08:33:00 +0000 Subject: [Koha-bugs] [Bug 35733] Request is denied for getting access token. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35733 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Hi, bugzilla is used for enhancement requests and bug reports, but your's is more a support question. Please use the mailing lists or the the IRC chat instead. https://koha-community.org/support/community-support/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 09:37:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 08:37:53 +0000 Subject: [Koha-bugs] [Bug 34423] (proof-of-concept) Bugzilla could look better with a new skin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34423 --- Comment #5 from Katrin Fischer --- Started to use the new skin to help find any small glitches, I quite like the feel of it! 1) When the bug comment is saved, it shows in a fixed width font, but when writing the note, it doesn't. My first feeling would be that they should match up and until bugzilla supports basic formatting like lists etc. it would be nicer to have the fixed-width font on editing too. 2) The input fields for "Documentation contact" and "Documentation submission" are a bit too wide, creating a horizontal scroll bar on the bug edit page. 3) The breaking point for smaller screens is a bit too early an the navigation immediately takes up a lot of space and is all centered. I think a like "half-screen" view needs a little bit more attention. 4) the comment sections are much wider than before, with a lot of "white space" after the text. I think keeping it at an easy to read length is good, but we should "shrink" the white background back to size. (hope that one makes sense) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 10:23:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 09:23:14 +0000 Subject: [Koha-bugs] [Bug 35707] Item statuses in the holdings table on biblio details should appear one per line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35707 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160663|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 160683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160683&action=edit Bug 35707: (alternate) Add clearfix to item statuses This proposed alterantive patch adds changes the status s to
    s. A div is basically the block-level equivalent of a span. This has the same effect of pushing each status onto its own line. The patch also adds generic "item_status" class to the
    s as well so that we can attach a consistent style to all statuses. The patch includes a small amount of padding on these items in order to repeat legibility. To test, apply the patch and rebuild the staff interface CSS. 1) Add an item to stockrotation and trigger the first transfer 2) Place a hold on the item 3) Note that you will now see two statuses, one above the other as displayed in the screenshots attached to the bug. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 10:24:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 09:24:15 +0000 Subject: [Koha-bugs] [Bug 35707] Item statuses in the holdings table on biblio details should appear one per line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35707 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin.renvoize at ptfs-europe |oleonard at myacpl.org |.com | QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize --- As Owen re-wrote this, and I agree, 'div' is more appropriate really. I'm using the opportunity to QA. Passing QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 10:28:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 09:28:49 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 Axelle Aix-Marseille Université changed: What |Removed |Added ---------------------------------------------------------------------------- CC|axelle.clarisse at univ-amu.fr | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 10:34:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 09:34:05 +0000 Subject: [Koha-bugs] [Bug 34637] Wiki - email notifications aren't being sent (account registrations, password resets, etc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34637 Paul Derscheid changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid at lmscloud.de --- Comment #12 from Paul Derscheid --- Hi Mark, would you be fine with hosting the mailing lists as well. We'll get in touch during the migration to discourse? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 10:38:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 09:38:00 +0000 Subject: [Koha-bugs] [Bug 35734] New: Message queue table lock will crash Koha Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35734 Bug ID: 35734 Summary: Message queue table lock will crash Koha Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: johanna.raisa at koha-suomi.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Locking the message_queue table on circulation and reserves will crash Koha, if there are many circulation or/and reservation operations on running and the process_message_queue cron is processing messages. Locking a table is not a very good way to handle digest messages and active queue, this should be handled with a new message status instead. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 10:38:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 09:38:37 +0000 Subject: [Koha-bugs] [Bug 34637] Wiki - email notifications aren't being sent (account registrations, password resets, etc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34637 --- Comment #13 from Paul Derscheid --- Hi Mark, my previous comment was worded completely wrong (still tired). Would you be fine with the community using that smtp-server for the mailing lists as well? We'd set it up during our migration to discourse. We can talk about it soon if you're interested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 10:48:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 09:48:13 +0000 Subject: [Koha-bugs] [Bug 35639] Long SMS messages are not sent if they exceed the character limitation of the messaging driver In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35639 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 10:48:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 09:48:15 +0000 Subject: [Koha-bugs] [Bug 35639] Long SMS messages are not sent if they exceed the character limitation of the messaging driver In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35639 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160243|0 |1 is obsolete| | --- Comment #2 from Matt Blenkinsop --- Created attachment 160684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160684&action=edit Bug 35639: Trim the messages that are too long before sending them via SMS I created a new system preference, SMSSendMaxChar, which allows you to set a limit for the number of characters in SMS messages to send. When a limit is set, messages that exceed it will be trimed. TEST PLAN 1) Apply the patch 2) Run prove t/db_dependent/Letters.t Signed-off-by: Matt Blenkinsop -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 10:50:29 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 09:50:29 +0000 Subject: [Koha-bugs] [Bug 35461] Renew All 66 SIP server response messages produce HASH content in replies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35461 Lari Strand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160497|0 |1 is obsolete| | --- Comment #16 from Lari Strand --- Created attachment 160685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160685&action=edit Bug 35461: Fix function call parameters causing the HASH to show in the renew all responses "Renew All" -function aka. 65-66-messages work like this: 66-return messages has renewed items in BM-fields and non-renewables go into BN-fields. If all items were renewable, then the reply message looks like: Reply: 13.07.2022 10:06:17:530 OUTESTI1 6610005000020220713 100616AOOUPK|BM564N15977171|BM564N09203960|BM564N23261720|BM564N25161958|BM564N23455012|C4::SIP::SIPServer=HASHC4::SIP::SIPServer=HASHAY6AZCEFE If items include renewables and non-renewables, the response includes the renewed items first, then a HASH mixed into the first BN-field, then rest of the renewed ones like they should show in BN-fields and after that, anohter HASH: 13.07.2022 14:41:32:610 OUTESTI1 6610003000420220713 144130AOOUPK|BM564N23455012|BM564N23261720|BM564N25161958|C4::SIP::SIPServer=HASHBN564N09203960|BN564N04191259|BN564N15977171|BN564N13788332|C4::SIP::SIPServer=HASHAY8AZC7C5 If all loans were unrenewable (this test included just one item), you first get a HASH in a BN-field, and another at the end. 13.07.2022 14:49:00:037 OUTESTI1 6610000000120220713 144858AOOUPK|C4::SIP::SIPServer=HASHBN564N19874533|C4::SIP::SIPServer=HASHAY9AZDD3B Our self checkout/checkin machine can handle/parse these reply messages correctly, but this might not be the case with all self checkout/checkin devices. Test Plan: 1) Unit test patch 2) prove t/db_dependent/SIP/Message.t 3) Note failures 4) Apply this patch 5) prove t/db_dependent/SIP/Message.t 6) Tests pass! Signed-off-by: Kyle M Hall Signed-off-by: David Nind Signed-off-by: lmstrand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 10:53:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 09:53:20 +0000 Subject: [Koha-bugs] [Bug 35461] Renew All 66 SIP server response messages produce HASH content in replies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35461 --- Comment #17 from Katrin Fischer --- Love to see the sign-offs - Kyle, can we count you for QA on this one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 10:56:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 09:56:12 +0000 Subject: [Koha-bugs] [Bug 30657] Make patron attributes available via Template Toolkit in overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Thibault Keromnès changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thibault.keromnes at univ-pari | |s8.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 10:56:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 09:56:53 +0000 Subject: [Koha-bugs] [Bug 35570] Add a generic master form in ILL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #25 from Pedro Amorim --- Created attachment 160686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160686&action=edit Bug 35570: (QA follow-up): Fix action button links. Use url filter instead of uri. Before applying this patch: 1) Click 'Manage Request' for a request, then on the top toolbar click 'Confirm request'. 2) Click the 'Confirm request' button on the bottom of the text. Notice it fails with a 404. Use the browser to go back. 3) Click the 'Cancel' button on the bottom of the text. Notice it fails with a 404. Use the browser to go back. 4) Set all the requests to status to 'REQ' (relevant for next test), ktd kshell, run: echo 'update illrequests set status = 'REQ';' | koha-mysql kohadev 5) Click 'Manage Request' for a request, then on the top toolbar click 'Revert request'. 6) Click the 'Revert request' button on the bottom of the text. Notice it fails with a 404. Use the browser to go back. 7) Click the 'Cancel' button on the bottom of the text. Notice it fails with a 404. Use the browser to go back. 8) Apply patch. Repeat test plan. Notice all the action buttons now work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 10:57:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 09:57:26 +0000 Subject: [Koha-bugs] [Bug 34472] Template Toolkit reference guide needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 Thibault Keromnès changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thibault.keromnes at univ-pari | |s8.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 10:58:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 09:58:36 +0000 Subject: [Koha-bugs] [Bug 35570] Add a generic master form in ILL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #26 from Pedro Amorim --- (In reply to David Nind from comment #24) > Additional testing > ================== > > I created a new ILL request and tested the various options available on the > ILL requests page (this wasn't part of the test plan): > > - Confirm request: page not found (404) error when confirming request (URL > was > /cgi-bin/koha/ill/%2Fcgi-bin%2Fkoha%2Fill%2Fill-requests. > pl%3Fmethod%3Dconfirm%26stage%3Dconfirm%26illrequest_id%3D2) - presume > something else is required to configure this? Hi David, nice catch. This was an oversight ('uri' instead of 'url') and an actual bug. I've submitted a patch. Thank you so much for your extensive testing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 10:59:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 09:59:11 +0000 Subject: [Koha-bugs] [Bug 35735] New: Document fourth argument to CanBookBeRenewed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35735 Bug ID: 35735 Summary: Document fourth argument to CanBookBeRenewed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com In C4/Circulation.pm we have this: 2920 =head2 CanBookBeRenewed 2921 2922 ($ok,$error,$info) = &CanBookBeRenewed($patron, $issue, $override_limit); 2923 2924 Find out whether a borrowed item may be renewed. 2925 2926 C<$patron> is the patron who currently has the issue. 2927 2928 C<$issue> is the checkout to renew. 2929 2930 C<$override_limit>, if supplied with a true value, causes 2931 the limit on the number of times that the loan can be renewed 2932 (as controlled by the item type) to be ignored. Overriding also allows 2933 to renew sooner than "No renewal before" and to manually renew loans 2934 that are automatically renewed. ... 2946 sub CanBookBeRenewed { 2947 my ( $patron, $issue, $override_limit, $cron ) = @_; The fourth argument, $cron, should be added to the example and to the list of arguments. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 11:00:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 10:00:01 +0000 Subject: [Koha-bugs] [Bug 35461] Renew All 66 SIP server response messages produce HASH content in replies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35461 --- Comment #18 from Lari Strand --- Also tested with a Lyngsoe Systems self checkout/service device and it was happy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 11:00:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 10:00:06 +0000 Subject: [Koha-bugs] [Bug 35735] Document fourth argument to CanBookBeRenewed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35735 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 11:00:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 10:00:47 +0000 Subject: [Koha-bugs] [Bug 34423] (proof-of-concept) Bugzilla could look better with a new skin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34423 Paul Derscheid changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid at lmscloud.de --- Comment #6 from Paul Derscheid --- Wow, that's so awesome. Let's get this moving ASAP! :D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 11:12:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 10:12:18 +0000 Subject: [Koha-bugs] [Bug 34637] Wiki - email notifications aren't being sent (account registrations, password resets, etc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34637 --- Comment #14 from Mark Hofstetter --- yes you could use ist for whatever koha purpose what is the hourly/weekly/monthly mail volume? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 11:21:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 10:21:01 +0000 Subject: [Koha-bugs] [Bug 34637] Wiki - email notifications aren't being sent (account registrations, password resets, etc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34637 --- Comment #15 from Paul Derscheid --- When I asked joubu last year, his estimation was around 100 topics/replies per month. But we want this to increase with the migration. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 12:38:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 11:38:57 +0000 Subject: [Koha-bugs] [Bug 33161] Implement +strings for GET /items and GET /items/:item_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33161 --- Comment #34 from Jonathan Druart --- (In reply to Jonathan Druart from comment #33) > + _strings: > + type: > + - object > + - "null" > description: A return claims object if one exists that's unresolved > > > Missing description in the api spec file. still valid... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:13:58 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:13:58 +0000 Subject: [Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160641|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize --- Created attachment 160687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160687&action=edit Bug 35100: Unit tests This patch adds a unit test to ensure StockrotationAdvance transfers are not cancelled from request_transfer when called with 'replace'. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:14:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:14:01 +0000 Subject: [Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160642|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize --- Created attachment 160688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160688&action=edit Bug 35100: Prevent StockrotationAdvance transfers from being cancelled ModItemTransfer is still very heavy handed and outright overrules existing transfers in the queue. For StockrotationAdvance transfers it's important that they remain in the queue to get actioned later, even if a higher precident transfer is actions in the interim. This patch adds a clause to the cancellation call within request_transfer such that StockrationAdvance transfers are left in tact for the next time the item is checked in. Test plan 1) Item is added to stock rotation 2) The cronjob creates a 'StockRotationAdvance' transfer 3) The item is checked in, which initiates the transfer, however, a hold is triggered 4) The hold is confirmed, which replaces the StockRotationAdvance 5) The item is checked out 6) The item is checked in, which initiates the transfer again 7) The item is checked in at it's destination and the StockrotationAdvance transfer has the proper date arrived date set. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:14:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:14:03 +0000 Subject: [Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160648|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize --- Created attachment 160689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160689&action=edit Bug 35100: Various fixes 1) Don't automagically always set a transfer to in transit on checkin.. wait for the user to actually confirm that's the case 2) New transfers triggered by a hold should take precidence, so hide transfers for any other reason from display 3) Update get_transfer and get_transfers to ensure ordering isn't lost when prefetch is used and add tests for this Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:14:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:14:06 +0000 Subject: [Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 --- Comment #21 from Martin Renvoize --- Created attachment 160690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160690&action=edit Bug 35100: Revert change to request_transfer This patch reverts the change to request_transfer, opting to tackle the StockRotationAdvance requirement to stay in place in ModItemTransfer itself. We also add a FIXME to RotatingCollections.. I'll look to removing that on another bug to reduce the scope of this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:16:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:16:09 +0000 Subject: [Koha-bugs] [Bug 35721] Replace ModItemTransfer calls in circ/returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35721 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160665|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 160691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160691&action=edit Bug 35721: ModItemTransfer -> Koha::Item->request_transfer - returns.pl This patch replaces the call to ModItemTransfer in circ/returns.pl with a call to Koha::Item->request_transfer and Koha::Item::Transfer->transit. Test plan 1) Set 'AutomaticItemReturn' to "Don't" 2) Check an item in at a location other than it's 'home' or 'holding' branch 3) Note you should be asked a about returning the item to another branch 4) Opting to not proceed should NOT result in a row in the branchtransfers table 5) Option to proceed (either with a print slip or just 'OK') should result in a branchtransfer from the current checkin branch to the home or holding branch depending on the circulation rules. 5a) The item should be marked as immediately in transit in, i.e. the 'datesent' set to today. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:18:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:18:17 +0000 Subject: [Koha-bugs] [Bug 29997] Allow to send email notification when a serial issue is late In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997 Matthias Le Gac changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |matthias.le-gac at inlibro.com --- Comment #6 from Matthias Le Gac --- Could you fixed the bug. Applying: Bug 29997: Allow to send email notification when a serial issue is late error: sha1 information is lacking or useless (C4/Serials.pm). error: could not build fake ancestor Patch failed at 0001 Bug 29997: Allow to send email notification when a serial issue is late Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:25:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:25:14 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 --- Comment #48 from Martin Renvoize --- Created attachment 160692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160692&action=edit Bug 28294: Remove updateWrongTransfer This patch removes the last remaining use of updateWrongTransfer and the method itself. We replace it with a call to request_transfer that passes the 'replace' reason of 'WrongTransfer' through to Koha::Item::Transfer->cancel. Test plan 1/ git grep updateWrongTransfer to confirm there are no more uses of the method. 2/ Confirm an incorrect transfer still behaves as expected at circulation returns. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:25:29 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:25:29 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160536|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:30:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:30:35 +0000 Subject: [Koha-bugs] [Bug 35736] New: Transfer modals should be merged in returns.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35736 Bug ID: 35736 Summary: Transfer modals should be merged in returns.tt Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 28294 Blocks: 22160 There are two modals in the circ/returns.tt template.. they should logically be just one.. this would lead to DRY'er code and simpler maintanence. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 [Bug 22160] OMNIBUS: Transfers enhancements https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:30:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:30:35 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35736 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35736 [Bug 35736] Transfer modals should be merged in returns.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:30:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:30:35 +0000 Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35736 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35736 [Bug 35736] Transfer modals should be merged in returns.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:30:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:30:47 +0000 Subject: [Koha-bugs] [Bug 35736] Transfer modals should be merged in returns.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35736 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:30:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:30:53 +0000 Subject: [Koha-bugs] [Bug 35736] Transfer modals should be merged in returns.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35736 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin.renvoize at ptfs-europe |koha-bugs at lists.koha-commun |.com |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:32:51 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:32:51 +0000 Subject: [Koha-bugs] [Bug 35737] New: Replace ModItemTransfer calls in circ/pendingreserves.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35737 Bug ID: 35737 Summary: Replace ModItemTransfer calls in circ/pendingreserves.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: nick at bywatersolutions.com, testopia at bugs.koha-community.org Blocks: 25754 ModItemTransfer is slowly getting removed and replaced by calls to the relevant Koha::Item and Koha::Item::Transfer methods. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25754 [Bug 25754] Deprecate C4::Items::ModItemTransfer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:32:51 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:32:51 +0000 Subject: [Koha-bugs] [Bug 25754] Deprecate C4::Items::ModItemTransfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25754 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35737 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35737 [Bug 35737] Replace ModItemTransfer calls in circ/pendingreserves.pl -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:33:29 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:33:29 +0000 Subject: [Koha-bugs] [Bug 35738] New: Replace ModItemTransfer calls in circ/waitingreserves.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35738 Bug ID: 35738 Summary: Replace ModItemTransfer calls in circ/waitingreserves.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: koha-bugs at lists.koha-community.org, nick at bywatersolutions.com, testopia at bugs.koha-community.org Blocks: 25754 ModItemTransfer is slowly getting removed and replaced by calls to the relevant Koha::Item and Koha::Item::Transfer methods. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25754 [Bug 25754] Deprecate C4::Items::ModItemTransfer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:33:29 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:33:29 +0000 Subject: [Koha-bugs] [Bug 25754] Deprecate C4::Items::ModItemTransfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25754 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35738 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35738 [Bug 35738] Replace ModItemTransfer calls in circ/waitingreserves.pl -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:33:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:33:57 +0000 Subject: [Koha-bugs] [Bug 35739] New: Replace ModItemTransfer calls in C4::SIP::ILS::Transaction::Checkin Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35739 Bug ID: 35739 Summary: Replace ModItemTransfer calls in C4::SIP::ILS::Transaction::Checkin Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: koha-bugs at lists.koha-community.org, nick at bywatersolutions.com, testopia at bugs.koha-community.org Blocks: 25754 ModItemTransfer is slowly getting removed and replaced by calls to the relevant Koha::Item and Koha::Item::Transfer methods. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25754 [Bug 25754] Deprecate C4::Items::ModItemTransfer -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:33:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:33:57 +0000 Subject: [Koha-bugs] [Bug 25754] Deprecate C4::Items::ModItemTransfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25754 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35739 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35739 [Bug 35739] Replace ModItemTransfer calls in C4::SIP::ILS::Transaction::Checkin -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:34:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:34:22 +0000 Subject: [Koha-bugs] [Bug 35740] New: Replace ModItemTransfer calls in C4::Reserves Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35740 Bug ID: 35740 Summary: Replace ModItemTransfer calls in C4::Reserves Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: koha-bugs at lists.koha-community.org, nick at bywatersolutions.com, testopia at bugs.koha-community.org Blocks: 25754 ModItemTransfer is slowly getting removed and replaced by calls to the relevant Koha::Item and Koha::Item::Transfer methods. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25754 [Bug 25754] Deprecate C4::Items::ModItemTransfer -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:34:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:34:22 +0000 Subject: [Koha-bugs] [Bug 25754] Deprecate C4::Items::ModItemTransfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25754 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35740 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35740 [Bug 35740] Replace ModItemTransfer calls in C4::Reserves -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:35:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:35:04 +0000 Subject: [Koha-bugs] [Bug 35741] New: Replace ModItemTransfer calls in C4::Circulation::AddReturn Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35741 Bug ID: 35741 Summary: Replace ModItemTransfer calls in C4::Circulation::AddReturn Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: koha-bugs at lists.koha-community.org, nick at bywatersolutions.com, testopia at bugs.koha-community.org Blocks: 25754 ModItemTransfer is slowly getting removed and replaced by calls to the relevant Koha::Item and Koha::Item::Transfer methods. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25754 [Bug 25754] Deprecate C4::Items::ModItemTransfer -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:35:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:35:04 +0000 Subject: [Koha-bugs] [Bug 25754] Deprecate C4::Items::ModItemTransfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25754 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35741 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35741 [Bug 35741] Replace ModItemTransfer calls in C4::Circulation::AddReturn -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:35:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:35:54 +0000 Subject: [Koha-bugs] [Bug 32105] Patron lists needs to share to specific people or groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 Matthias Le Gac changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:37:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:37:41 +0000 Subject: [Koha-bugs] [Bug 35729] Coce Should Account for New ISBN 979* In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:46:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:46:57 +0000 Subject: [Koha-bugs] [Bug 35742] New: Cannot remove new user added to fund Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35742 Bug ID: 35742 Summary: Cannot remove new user added to fund Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Staff interface Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com On the fund edition page, if a new user is added the "Remove" link does not remove the user. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:49:28 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:49:28 +0000 Subject: [Koha-bugs] [Bug 35743] New: The "category" filter is not selected in the column filter dropdown Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35743 Bug ID: 35743 Summary: The "category" filter is not selected in the column filter dropdown Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Patrons Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 32517 When a patron search is triggered and a category has been selected, the dropdown filter on top of the column does not contain the selected category. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32517 [Bug 32517] Patron search dies on case mismatch of patron category -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:49:28 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:49:28 +0000 Subject: [Koha-bugs] [Bug 32517] Patron search dies on case mismatch of patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32517 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35743 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35743 [Bug 35743] The "category" filter is not selected in the column filter dropdown -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:50:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:50:36 +0000 Subject: [Koha-bugs] [Bug 35744] New: Implement +strings for GET /patrons/:patron_id Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35744 Bug ID: 35744 Summary: Implement +strings for GET /patrons/:patron_id Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: REST API Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com CC: tomascohen at gmail.com It would be helpful to have the library's name and patron category's description. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:52:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:52:52 +0000 Subject: [Koha-bugs] [Bug 35745] New: Setting suggester on the suggestion edit form does not show library and category Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35745 Bug ID: 35745 Summary: Setting suggester on the suggestion edit form does not show library and category Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Staff interface Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 35744 On the suggestion edit form, if a suggester is selected using the "Set to patron" (and patron search), the details of the selected patron will contained "undefined" for the library's name and patron's category description. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35744 [Bug 35744] Implement +strings for GET /patrons/:patron_id -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:52:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:52:52 +0000 Subject: [Koha-bugs] [Bug 35744] Implement +strings for GET /patrons/:patron_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35744 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35745 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35745 [Bug 35745] Setting suggester on the suggestion edit form does not show library and category -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:53:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:53:03 +0000 Subject: [Koha-bugs] [Bug 35742] Cannot remove new user added to fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35742 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35329 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 [Bug 35329] Move patron searches to a modal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:53:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:53:03 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35742 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35742 [Bug 35742] Cannot remove new user added to fund -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:53:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:53:06 +0000 Subject: [Koha-bugs] [Bug 35743] The "category" filter is not selected in the column filter dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35743 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35329 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 [Bug 35329] Move patron searches to a modal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:53:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:53:06 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35743 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35743 [Bug 35743] The "category" filter is not selected in the column filter dropdown -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:53:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:53:16 +0000 Subject: [Koha-bugs] [Bug 35744] Implement +strings for GET /patrons/:patron_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35744 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35329 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 [Bug 35329] Move patron searches to a modal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:53:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:53:16 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35744 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35744 [Bug 35744] Implement +strings for GET /patrons/:patron_id -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:53:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:53:20 +0000 Subject: [Koha-bugs] [Bug 35745] Setting suggester on the suggestion edit form does not show library and category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35745 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35329 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 [Bug 35329] Move patron searches to a modal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:53:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:53:20 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35745 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35745 [Bug 35745] Setting suggester on the suggestion edit form does not show library and category -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:53:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:53:55 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35701 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35701 [Bug 35701] Cannot use i18n.inc from MACRO block? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:53:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:53:55 +0000 Subject: [Koha-bugs] [Bug 35701] Cannot use i18n.inc from MACRO block? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35701 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35329 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 [Bug 35329] Move patron searches to a modal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:54:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:54:30 +0000 Subject: [Koha-bugs] [Bug 32105] Patron lists needs to share to specific people or groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 Matthias Le Gac changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Matthias Le Gac --- I can apply the patch but when I click on the button "New patron list" I have an 500 error. I have update my DB and I have the new table "patron_lis_user" and the new shares modes. I missed something ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:57:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:57:14 +0000 Subject: [Koha-bugs] [Bug 35701] Cannot use i18n.inc from MACRO block? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35701 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:57:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:57:17 +0000 Subject: [Koha-bugs] [Bug 35701] Cannot use i18n.inc from MACRO block? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35701 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160535|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 160693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160693&action=edit Bug 35701: Do not use t To not interfer with the t from I18N On bug 35329 we are using the I18N TT plugin that is providing the 't' subroutine. This loop is redefining the subroutine, therefore it is not longer accessible. Test plan: Edit a patron and confirm the the "Title" dropdown still contain the different values of syspref BorrowersTitles. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:59:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:59:14 +0000 Subject: [Koha-bugs] [Bug 35742] Cannot remove new user added to fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35742 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:59:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:59:16 +0000 Subject: [Koha-bugs] [Bug 35742] Cannot remove new user added to fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35742 --- Comment #1 from Jonathan Druart --- Created attachment 160694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160694&action=edit Bug 35742: Fix removal of added user from fund On the fund edition page, if a new user is added the "Remove" link does not remove the user. Test plan: 0. Do not apply this patch 1. Edit a fund 2. Click "Add users" 3. Search for patron and add some users => Notice that the "Remove" link does not remove the user 4. Apply this patch and repat 1, 2, 3 => Notice that the "Remove" link remove the user -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:59:43 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 13:59:43 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #117 from Nick Clemens --- Must fix: This is looking nice, it works in basic setups, however, there is an issue if 'TranslateNotices' is enabled, the form value is not passed correctly for multiple languages. So on save sometimes the values are lost. The 'Apply format settings to all notices:' also seems to reflect separate languages in the code - it should be made to work with multiple languages and the title updated. The patches should also be rebased/squashed to reflect the current state (and drop the addition of multiple fields) Please also see bug 33260 comment 39 and move that patch here. Note: The 'style' field is saved for each MTT of the letter - though only used in the print version. I think this is more an architecture issue, some slips are printed from the 'email' template, some are from 'print' I am not blocking here, but we should file a bug for this as it will be confusing and is some duplication in the DB -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:01:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 14:01:26 +0000 Subject: [Koha-bugs] [Bug 35743] The "category" filter is not selected in the column filter dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35743 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:01:29 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 14:01:29 +0000 Subject: [Koha-bugs] [Bug 35743] The "category" filter is not selected in the column filter dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35743 --- Comment #1 from Jonathan Druart --- Created attachment 160695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160695&action=edit Bug 35743: Fix patron's category selection in the column filter The "category" filter is not selected in the column filter dropdown. Test plan: 0. Do not apply this patch 1. Search for patron, select a patron's category => Notice that the "Category" column has a column filter, but no option is selected 2. Apply the patch 3. Repeat 1 => The "Category" column has the option you selected in the filter block. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:08:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 14:08:53 +0000 Subject: [Koha-bugs] [Bug 35744] Implement +strings for GET /patrons/:patron_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35744 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:08:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 14:08:55 +0000 Subject: [Koha-bugs] [Bug 35744] Implement +strings for GET /patrons/:patron_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35744 --- Comment #1 from Jonathan Druart --- Created attachment 160696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160696&action=edit Bug 35744: Implement +strings for GET /patrons/:patron_id In order to retrieve the library's name and patron category's description alongwith other patron's info. Test plan: Run the following command before and after this patch: % curl -u koha:koha --request GET 'http://localhost:8081/api/v1/patrons/42' --header "Content-Type: application/json" --header "x-koha-embed: +strings" | jq Notice that you now have _strings which contains the library's name and patron category's description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:09:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 14:09:08 +0000 Subject: [Koha-bugs] [Bug 35744] Implement +strings for GET /patrons/:patron_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35744 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|35329 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 [Bug 35329] Move patron searches to a modal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:09:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 14:09:08 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|35744 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35744 [Bug 35744] Implement +strings for GET /patrons/:patron_id -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:10:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 14:10:32 +0000 Subject: [Koha-bugs] [Bug 35745] Setting suggester on the suggestion edit form does not show library and category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35745 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:10:34 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 14:10:34 +0000 Subject: [Koha-bugs] [Bug 35745] Setting suggester on the suggestion edit form does not show library and category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35745 --- Comment #1 from Jonathan Druart --- Created attachment 160697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160697&action=edit Bug 35745: Fix 'Set suggester' of a suggestion On the suggestion edit form, if a suggester is selected using the "Set to patron" (and patron search), the details of the selected patron will contained "undefined" for the library's name and patron's category description. Test plan: Edit a suggestion, click "Set to patron", select a patron Notice that with this patch the library's name and patron category is correctly displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:22:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 14:22:55 +0000 Subject: [Koha-bugs] [Bug 35545] "additional" item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35545 --- Comment #7 from Caroline Cyr La Rose --- I looked at the screenshots and noticed that the item that appears in staff but not in the OPAC is withdrawn. Is it possible OPACHiddenItems hides withdrawn items from the OPAC? In the staff screenshot, the biblionumber seems to be 151173 and the itemnumber is 669653. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:22:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 14:22:59 +0000 Subject: [Koha-bugs] [Bug 35569] Remember user-selected columns in holdings table on staff detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35569 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33484 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:22:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 14:22:59 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35569 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:32:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 14:32:46 +0000 Subject: [Koha-bugs] [Bug 35710] Indexing problem with "&" symbol in Zebra. Some biblio-records with "&" symbol are not searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35710 --- Comment #4 from Yuriy Kotsyuk --- (In reply to Katrin Fischer from comment #1) > Hi Yuriy, 21.05 is very old and no longer maintained. I suggest that you do > a test in a newer version of Koha if the problem still remains. You could > use a Koha sandbox or one of the publicly available demo installations. Well, I updated the version of koha to 23.05.06.000, but the problem still exists. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:38:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 14:38:53 +0000 Subject: [Koha-bugs] [Bug 32105] Patron lists needs to share to specific people or groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 Matthias Le Gac changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Matthias Le Gac --- My bad I found the problem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:45:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 14:45:14 +0000 Subject: [Koha-bugs] [Bug 34637] Wiki - email notifications aren't being sent (account registrations, password resets, etc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34637 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #16 from Jonathan Druart --- Weblate is sending 50-200 emails per day. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:45:23 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 14:45:23 +0000 Subject: [Koha-bugs] [Bug 35729] Coce Should Account for New ISBN 979* In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729 --- Comment #2 from Lucas Gass --- I think Koha needs an updated Business::ISBN. I recently filed an issue, which is only an issue in older versions: https://github.com/briandfoy/business-isbn/issues/25 Currently using Business::ISBN: 3.006 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:49:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 14:49:16 +0000 Subject: [Koha-bugs] [Bug 35461] Renew All 66 SIP server response messages produce HASH content in replies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35461 --- Comment #19 from Kyle M Hall --- (In reply to Katrin Fischer from comment #17) > Love to see the sign-offs - Kyle, can we count you for QA on this one? I wrote the patches so not unless you think it's sufficient :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:50:51 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 14:50:51 +0000 Subject: [Koha-bugs] [Bug 35701] Cannot use i18n.inc from memberentrygen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35701 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cannot use i18n.inc from |Cannot use i18n.inc from |MACRO block? |memberentrygen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:53:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 14:53:30 +0000 Subject: [Koha-bugs] [Bug 24778] Move from Memcached to Redis to solve L1 caching issues? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24778 --- Comment #2 from Kyle M Hall --- (In reply to Katrin Fischer from comment #1) > This was filed almost 4 years ago - have we come to a decision about this? I don't think it's ever been discussed anywhere other than me filing this bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:54:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 14:54:06 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:54:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 14:54:09 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #2 from Jonathan Druart --- Created attachment 160698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160698&action=edit Bug 35329: move patron search to modal - Add guarantor This is the first of many patches to come. We will rewrite the patron search popup to convert it to a Bootstrap's modal. I faced different problems on different pages, it is preferable to test each page on top of the whole patchset, to make sure a futur change will not break previous pages (and this is why they are all on the same bug report). For each page we will test that: * the different filters work * the "Clear" filters button work * the "Add" or "Select" patron button works * the nested modal to display patron's details (when clicking on their name or cardnumber) works On this patch we are testing the guarantor search: Create a edit a patron and click "Add guarantor" to open the modal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:54:11 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 14:54:11 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #3 from Jonathan Druart --- Created attachment 160699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160699&action=edit Bug 35329: Move patron search to modal - neworderempty Test plan: Create a new acquisition order and add users. FIXME: Note that rules for .modal-dialog .dialog.message need to be adjusted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:54:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 14:54:14 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #4 from Jonathan Druart --- Created attachment 160700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160700&action=edit Bug 35329: Move patron search to modal - basket Add user to an acquisition basket -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:54:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 14:54:17 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #5 from Jonathan Druart --- Created attachment 160701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160701&action=edit Bug 35329: Move patron search to modal - funds This is a tricky one. We can have several modals per page, patron-search.inc needs to be adjusted to not use ids but classes. Also we need to declare JS variables with 'var' instead of 'let' (which does not allow redefinition of the same variable). Test plan: Create or modify a fund "Select owner" and "Add users" to open the modals. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:54:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 14:54:20 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #6 from Jonathan Druart --- Created attachment 160702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160702&action=edit Bug 35329: Move patron search to modal - edit-batch Test plan: Create new patron card batch Keep the textarea empty and click "Add patron(s)" to open the modal There is a special feature here, the "checkbox" column is displayed and you can select several patrons and click "Add selected patrons". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:54:23 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 14:54:23 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #7 from Jonathan Druart --- Created attachment 160703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160703&action=edit Bug 35329: Move patron search to modal - routing list The behaviour is a bit different here. Adding a patron from the popup refreshed the parent page with the newly added patron. With this patch the refresh of the page will happen when the modal is closed (if patrons have been added). Test plan: Create a subscription, receive one item, create a routing list. Add users. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:54:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 14:54:26 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #8 from Jonathan Druart --- Created attachment 160704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160704&action=edit Bug 35329: Move patron search to modal - erm Test plan: Edit an agreement or a license Add new user and click "Select user" to open the modal Test with different user for the same agreement/license -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:54:29 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 14:54:29 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #9 from Jonathan Druart --- Created attachment 160705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160705&action=edit Bug 35329: Move patron search to modal - suggestion Test plan: Edit a suggestion Click "Set patron" to change the suggester Click "Select manager" to set the manager On the suggestion list view, you can also select a manager. Make sure you are testing with different tabs (suggestions with different statuses). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:54:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 14:54:31 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #10 from Jonathan Druart --- Created attachment 160706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160706&action=edit Bug 35329: Move patron search to modal - remove members/search.pl git grep members/search.pl should not return any results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:00:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 15:00:40 +0000 Subject: [Koha-bugs] [Bug 23909] SCO allows to check out items with Waiting state if AllowItemsOnHoldCheckoutSCO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23909 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=7090 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:00:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 15:00:40 +0000 Subject: [Koha-bugs] [Bug 7090] Add "AllowItemsOnHoldCheckout" syspref to allow issue to the patron regardless of hold status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7090 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23909 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:10:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 15:10:55 +0000 Subject: [Koha-bugs] [Bug 35701] Cannot use i18n.inc from memberentrygen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35701 --- Comment #6 from Julian Maurice --- There is one [% t | html %] left (under ELSE) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:18:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 15:18:13 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #62 from Jonathan Druart --- Remote branch rebased against master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:19:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 15:19:18 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #63 from Jonathan Druart --- (In reply to Andrii Nugged from comment #61) > We can take this for our libraries in Finland and maybe for Ukraine in our > custom build for testing, until this "more or less complete". They asking > for this feature. Is it being tested? Any feedback? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:21:37 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 15:21:37 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #11 from Jonathan Druart --- (In reply to Jonathan Druart from comment #2) > Created attachment 160698 [details] [review] > Bug 35329: move patron search to modal - Add guarantor This patch is co-authored-by: Owen, thanks! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:21:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 15:21:47 +0000 Subject: [Koha-bugs] [Bug 33217] Allow different default sorting when click author links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33217 Rasa Satinskiene changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/807 Resolution|--- |FIXED --- Comment #17 from Rasa Satinskiene --- Manual updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:30:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 15:30:07 +0000 Subject: [Koha-bugs] [Bug 28166] Optionally add MARC fields to authority search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Rasa Satinskiene changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/809 Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #34 from Rasa Satinskiene --- Manual updated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:30:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 15:30:24 +0000 Subject: [Koha-bugs] [Bug 35305] Add XSLT for authority details page in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35305 Matthias Le Gac changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |matthias.le-gac at inlibro.com --- Comment #4 from Matthias Le Gac --- The display match with the XSLT for type GEOGR_NAME but for the other types the default display isn't use, it's the XSLT display who is using. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:39:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 15:39:06 +0000 Subject: [Koha-bugs] [Bug 35729] Upgrade Business::ISBN to at least 3.008 minimum version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Version|unspecified |master Summary|Coce Should Account for New |Upgrade Business::ISBN to |ISBN 979* |at least 3.008 minimum | |version -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:39:23 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 15:39:23 +0000 Subject: [Koha-bugs] [Bug 35729] Upgrade Business::ISBN to at least 3.008 minimum version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:52:23 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 15:52:23 +0000 Subject: [Koha-bugs] [Bug 35714] Clicking Print slips when no letter template selected causes error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35714 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:52:25 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 15:52:25 +0000 Subject: [Koha-bugs] [Bug 35714] Clicking Print slips when no letter template selected causes error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35714 --- Comment #1 from Jonathan Druart --- Created attachment 160707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160707&action=edit Bug 35714: Prevent items not linked with processing with a letter code a to be printed Items linked with a processing which does not have a letter code are not supposed to be printed. Currently the code is allowing to "print slip" for items when using the link on top of the table. It results in an error "No letter_code at /kohadevbox/koha/preservation/print_slip.pl line 45." Test plan: Create a processing without a letter code Add 2 items to the waiting list then add them to a train Go to the "show train" view => notice that you cannot print slip for those items Create another processing with a letter code Edit one of the item and set it the new processing => A slip for this item can be printed Edit the other item and the train to make them use the new processing => A slip for those items can be printed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 17:09:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 16:09:22 +0000 Subject: [Koha-bugs] [Bug 32105] Patron lists needs to share to specific people or groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 --- Comment #8 from Matthias Le Gac --- (In reply to Matthias Le Gac from comment #7) > -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 17:10:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 16:10:52 +0000 Subject: [Koha-bugs] [Bug 32105] Patron lists needs to share to specific people or groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 --- Comment #9 from Matthias Le Gac --- (In reply to Matthias Le Gac from comment #7) > My bad I found the problem I always have the error 500 but Ithink it's a problem with my configuration of Koha. I check for signoff when i fix my problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 17:16:54 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 16:16:54 +0000 Subject: [Koha-bugs] [Bug 35701] Cannot use i18n.inc from memberentrygen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35701 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 17:16:56 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 16:16:56 +0000 Subject: [Koha-bugs] [Bug 35701] Cannot use i18n.inc from memberentrygen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35701 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160693|0 |1 is obsolete| | --- Comment #7 from Owen Leonard --- Created attachment 160708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160708&action=edit Bug 35701: Do not use t To not interfer with the t from I18N On bug 35329 we are using the I18N TT plugin that is providing the 't' subroutine. This loop is redefining the subroutine, therefore it is not longer accessible. Test plan: Edit a patron and confirm the the "Title" dropdown still contain the different values of syspref BorrowersTitles. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 17:16:58 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 16:16:58 +0000 Subject: [Koha-bugs] [Bug 35701] Cannot use i18n.inc from memberentrygen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35701 --- Comment #8 from Owen Leonard --- Created attachment 160709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160709&action=edit Bug 35701: (follow-up) Fix last instance of t variable Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 17:24:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 16:24:59 +0000 Subject: [Koha-bugs] [Bug 35742] Cannot remove new user added to fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35742 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 17:25:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 16:25:01 +0000 Subject: [Koha-bugs] [Bug 35742] Cannot remove new user added to fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35742 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160694|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 160710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160710&action=edit Bug 35742: Fix removal of added user from fund On the fund edition page, if a new user is added the "Remove" link does not remove the user. Test plan: 0. Do not apply this patch 1. Edit a fund 2. Click "Add users" 3. Search for patron and add some users => Notice that the "Remove" link does not remove the user 4. Apply this patch and repat 1, 2, 3 => Notice that the "Remove" link remove the user Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 17:26:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 16:26:18 +0000 Subject: [Koha-bugs] [Bug 35746] New: Multiple selections for parameters used in the IN function Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Bug ID: 35746 Summary: Multiple selections for parameters used in the IN function Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org It would be great if when a dropdown selection is used in something like an IN statement in WHERE, that Koha would allow you to select multiple options. So, for example: WHERE branchcode IN (<>) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 17:29:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 16:29:26 +0000 Subject: [Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 17:34:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 16:34:07 +0000 Subject: [Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Brendan Lawlor changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor at clamsnet.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 17:35:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 16:35:27 +0000 Subject: [Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #1 from Barbara Johnson --- +1 - We have multiple reports where this would be really useful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 17:45:56 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 16:45:56 +0000 Subject: [Koha-bugs] [Bug 35743] The "category" filter is not selected in the column filter dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35743 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 17:45:58 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 16:45:58 +0000 Subject: [Koha-bugs] [Bug 35743] The "category" filter is not selected in the column filter dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35743 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160695|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 160711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160711&action=edit Bug 35743: Fix patron's category selection in the column filter The "category" filter is not selected in the column filter dropdown. Test plan: 0. Do not apply this patch 1. Search for patron, select a patron's category => Notice that the "Category" column has a column filter, but no option is selected 2. Apply the patch 3. Repeat 1 => The "Category" column has the option you selected in the filter block. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 17:53:29 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 16:53:29 +0000 Subject: [Koha-bugs] [Bug 35744] Implement +strings for GET /patrons/:patron_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35744 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 17:53:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 16:53:31 +0000 Subject: [Koha-bugs] [Bug 35744] Implement +strings for GET /patrons/:patron_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35744 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160696|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 160712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160712&action=edit Bug 35744: Implement +strings for GET /patrons/:patron_id In order to retrieve the library's name and patron category's description alongwith other patron's info. Test plan: Run the following command before and after this patch: % curl -u koha:koha --request GET 'http://localhost:8081/api/v1/patrons/42' --header "Content-Type: application/json" --header "x-koha-embed: +strings" | jq Notice that you now have _strings which contains the library's name and patron category's description Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 17:53:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 16:53:57 +0000 Subject: [Koha-bugs] [Bug 35744] Implement +strings for GET /patrons/:patron_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35744 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 17:57:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 16:57:09 +0000 Subject: [Koha-bugs] [Bug 21173] Add hours as age unit to auto item modifications by age for damaged_on, itemlost_on and withdrawn_on fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Phan Tung Bui changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phan-tung.bui at inlibro.com --- Comment #38 from Phan Tung Bui --- Please update the test plan to reflect the current location of the 'Automatic Item Modifications by Age' feature. It is no longer found under 'Tools' but has been moved to 'Cataloging'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 17:57:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 16:57:40 +0000 Subject: [Koha-bugs] [Bug 32105] Patron lists needs to share to specific people or groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 Matthias Le Gac changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Matthias Le Gac --- My configuration of Koha is good now and I always have the 500 error. The log is : [Tue Jan 09 11:47:39.080444 2024] [core:notice] [pid 6891] AH00094: Command line: '/usr/sbin/apache2' Template process failed: file error - patron_search_filters_simple: not found at /inlibro/git/koha-master-dev-matthias/C4/Templates.pm line 134. Template process failed: file error - patron_search_filters_simple: not found at /inlibro/git/koha-master-dev-matthias/C4/Templates.pm line 134. I have the 500 error when I want to create a new "Patron list" and when I don't have the patch I can create a new "Patron list". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 17:58:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 16:58:55 +0000 Subject: [Koha-bugs] [Bug 35745] Setting suggester on the suggestion edit form does not show library and category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35745 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 17:58:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 16:58:57 +0000 Subject: [Koha-bugs] [Bug 35745] Setting suggester on the suggestion edit form does not show library and category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35745 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160697|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 160713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160713&action=edit Bug 35745: Fix 'Set suggester' of a suggestion On the suggestion edit form, if a suggester is selected using the "Set to patron" (and patron search), the details of the selected patron will contained "undefined" for the library's name and patron's category description. Test plan: Edit a suggestion, click "Set to patron", select a patron Notice that with this patch the library's name and patron category is correctly displayed. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 18:01:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 17:01:18 +0000 Subject: [Koha-bugs] [Bug 35380] PUT /biblios/:biblio_id doesn't respect overlay rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35380 Miranda Nero changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mnero at oslri.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 18:01:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 17:01:55 +0000 Subject: [Koha-bugs] [Bug 35693] Granular Permissions to Everything In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35693 --- Comment #2 from Christopher Brannon --- I think that is a great idea. Also, I think maybe the best approach to something of this nature is creating a foundation framework for this that new features can use and existing features can hook onto as they are improved. I don't want people to look at this as a major overhaul to existing permissions. This should be something we can create the structure for and then move things over to as we move forward. Otherwise, I fear that developers are going to look at this as a daunting task, and too big to take on, especially as more and more features are continually developed and added on to Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 18:05:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 17:05:59 +0000 Subject: [Koha-bugs] [Bug 34423] (proof-of-concept) Bugzilla could look better with a new skin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34423 --- Comment #7 from Jake Deery --- Hello all, Thanks for all the feedback. I've pushed another commit today, hoping to address: * Width issues on mobile * Inconsistent fonts (i.e. the editor being sans-serif, while the comments being monospace) * Adding more breakpoints to make the transition through screen-sizes more managable It's not a final draft; much more work is needed. But hopefully we all agree we're moving in the right direction. :-) P.S. the test site is back, at https://bugzilla.llownd.net/bugzilla5 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 18:13:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 17:13:45 +0000 Subject: [Koha-bugs] [Bug 35747] New: Some PUT endpoints wipe data if embeds are missing from the payload Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35747 Bug ID: 35747 Summary: Some PUT endpoints wipe data if embeds are missing from the payload Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: pedro.amorim at ptfs-europe.com CC: jonathan.druart+koha at gmail.com, martin.renvoize at ptfs-europe.com, tomascohen at gmail.com To reproduce: 0) Enable RESTBasicAuth syspref 1) Add a new license, visit: /cgi-bin/koha/erm/licenses/add 2) Fill in mandatory fields, click "Add document" and upload a file. 3) Click 'Submit' 4) Edit the license, visit: /cgi-bin/koha/erm/licenses/edit/1 5) Pretend you're a third-party app wanting to update name and description of the license. Run the following curl: curl -u "koha:koha" -X PUT \ 'http://localhost:8081/api/v1/erm/licenses/1' \ --header 'Accept: */*' \ --header 'User-Agent: Thunder Client (https://www.thunderclient.com)' \ --header 'Content-Type: application/json' \ --data-raw '{"description":"testing","name":"testing","status":"not_yet_active","type":"consortial"}' 6) Check the license again, visit: /cgi-bin/koha/erm/licenses/edit/1 7) Notice the file you uploaded in 2) has been wiped. This PUT request is missing the documents property, so Koha will wipe all documents related to that license. Same happens for users (property 'user_roles'). Same happens if the property is sent empty. I believe this is by design, as the Koha form will always be pre-populated with any existing data thus not wiping anything unintendedly. I understand this is how PUT is supposed to work, and that this should be a PATCH instead, but we're currently not supporting PATCH endpoints (?). What is the best approach here, support PATCH or change the logic behind the PUT endpoint? Other? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 18:18:12 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 17:18:12 +0000 Subject: [Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #23 from Pedro Amorim --- (In reply to Martin Renvoize from comment #22) > Comment on attachment 159639 [details] [review] > Bug 35287: REST API - Add additional fields support to ERM Licenses > > Review of attachment 159639 [details] [review]: > ----------------------------------------------------------------- > > ::: Koha/REST/V1/ERM/Licenses.pm > @@ +183,5 @@ > > $license->user_roles($user_roles); > > $license->documents($documents); > > > > + my @extended_attributes = map { {'id' => $_->{field_id}, 'value' => $_->{value}} } @{$extended_attributes}; > > + $license->extended_attributes( \@extended_attributes ); > > Won't you need to check here that @extended_attributes is indeed populated.. > else you may wipe them away without meaning to? Good point. It's working like that by design. The scenario of wiping additional attributes without meaning to should not be possible through the Koha form, as existing data is always pre-populated on the form when editing. Having said that, it is still possible with a third-party request to the REST API but I believe that to be a wider topic. I've opened bug 35747 where I provide a test plan to discuss it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 18:55:56 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 17:55:56 +0000 Subject: [Koha-bugs] [Bug 35693] Granular Permissions to Everything In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35693 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 18:56:25 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 17:56:25 +0000 Subject: [Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us --- Comment #2 from Rebecca Coert --- +1 this would be extremely helpful! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 18:57:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 17:57:26 +0000 Subject: [Koha-bugs] [Bug 28970] Create runtime parameters on the fly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28970 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us --- Comment #3 from Rebecca Coert --- +1 - I'd love to see this functionality added to Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:08:09 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 18:08:09 +0000 Subject: [Koha-bugs] [Bug 29007] Prompt for reason when cancelling waiting hold via popup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #14 from Kelly McElligott --- This documentation is done and in the manual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:15:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 18:15:39 +0000 Subject: [Koha-bugs] [Bug 35729] Upgrade Business::ISBN to at least 3.008 minimum version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729 --- Comment #3 from Lucas Gass --- Created attachment 160714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160714&action=edit Bug 35729: Update Business::ISBN mimimum version to 3.008 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:16:29 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 18:16:29 +0000 Subject: [Koha-bugs] [Bug 35729] Upgrade Business::ISBN to at least 3.008 minimum version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729 --- Comment #4 from Lucas Gass --- The hard part here is packaging and I've CC'd Mason. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:21:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 18:21:05 +0000 Subject: [Koha-bugs] [Bug 24738] Online registration confirmation/clarification when same email address is used multiple times In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24738 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WORKSFORME |--- Status|RESOLVED |REOPENED --- Comment #3 from Christopher Brannon --- (In reply to Katrin Fischer from comment #2) > * Show a message that an email has already been registered: We should not do > this, as it would give away that the email address exists and is a user at > the library. This is a privacy concern. I have not known a system that doesn't either say that the email address is already in use if you try to register under it, or at least give a generic error message. However, as I think through this specific piece, since a patron is trying to register under the email address, it is assumed that if it is legit, they would have access to either the email or the person that has access to it, and therefore noting that the email address is already in use may not be necessary. > * Sent an email to verify: we already have email verification for self > registration that works this way. I think the key point to this bug was to see if there is a way to indicate that the patron has already registered. I will rework the title of this bug. I wonder if maybe in the online registration process the patron could be asked if they already have a library card number, then ask for it, verify that the account still exists, and then redirect them to contact their library rather than complete a request online that is not needed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:21:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 18:21:46 +0000 Subject: [Koha-bugs] [Bug 24738] Online registration should check if patron is registering for an already existing account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24738 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Online registration |Online registration should |confirmation/clarification |check if patron is |when same email address is |registering for an already |used multiple times |existing account -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:32:29 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 18:32:29 +0000 Subject: [Koha-bugs] [Bug 21173] Add hours as age unit to auto item modifications by age for damaged_on, itemlost_on and withdrawn_on fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Matthias Le Gac changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:32:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 18:32:31 +0000 Subject: [Koha-bugs] [Bug 21173] Add hours as age unit to auto item modifications by age for damaged_on, itemlost_on and withdrawn_on fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Matthias Le Gac changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158575|0 |1 is obsolete| | --- Comment #39 from Matthias Le Gac --- Created attachment 160715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160715&action=edit Bug 21173: (follow-up) Re-ordering input fields in item modification by age form Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: matthias le gac -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:49:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 18:49:01 +0000 Subject: [Koha-bugs] [Bug 21173] Add hours as age unit to auto item modifications by age for damaged_on, itemlost_on and withdrawn_on fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Phan Tung Bui changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160715|0 |1 is obsolete| | --- Comment #40 from Phan Tung Bui --- Created attachment 160716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160716&action=edit Bug 21173: (follow-up) Re-ordering input fields in item modification by age form Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: Phan Tung Bui -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:49:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 18:49:40 +0000 Subject: [Koha-bugs] [Bug 21173] Add hours as age unit to auto item modifications by age for damaged_on, itemlost_on and withdrawn_on fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #41 from Phan Tung Bui --- Note: To avoid confusion, when selecting a rule other than 'items.damaged_on', 'items.itemlost_on', or 'items.withdrawn_on', the option 'Hours' should be disabled since these specific fields are associated with the 'Days' unit. Enabling 'Hours' for other fields may lead to misinterpretation of the rule's intended behavior. Disabling 'Hours' ensures consistency in the presentation of rules and helps users make accurate selections. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:57:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 18:57:00 +0000 Subject: [Koha-bugs] [Bug 35724] Define non-standard port numbers for SFTP upload/download in EDI accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35724 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160644|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:57:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 18:57:07 +0000 Subject: [Koha-bugs] [Bug 35724] Define non-standard port numbers for SFTP upload/download in EDI accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35724 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160645|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:57:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 18:57:14 +0000 Subject: [Koha-bugs] [Bug 35724] Define non-standard port numbers for SFTP upload/download in EDI accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35724 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160646|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:57:33 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 18:57:33 +0000 Subject: [Koha-bugs] [Bug 35724] Define non-standard port numbers for SFTP upload/download in EDI accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35724 --- Comment #4 from Alex Buckley --- Created attachment 160717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160717&action=edit Bug 35724: Database changes Sponsored-by: Waikato Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:57:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 18:57:48 +0000 Subject: [Koha-bugs] [Bug 35724] Define non-standard port numbers for SFTP upload/download in EDI accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35724 --- Comment #5 from Alex Buckley --- Created attachment 160718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160718&action=edit Bug 35724: Template changes Sponsored-by: Waikato Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:57:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 18:57:52 +0000 Subject: [Koha-bugs] [Bug 24956] Add ability to define emergency/override circ rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24956 Jason Robb changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb at sekls.org --- Comment #1 from Jason Robb --- It would save a lot of time and headache if there were an override layer above the existing circ/fine rules setup. We heavily rely on an "All/All" rule at each branch to reduce the total number of rules needed to accommodate a fluctuating number of item types and patron categories. That works well, but it means if we need a rule that affects all branches, it requires a new rule line for each individual branch. As an example, we don't want self-registered patrons to be able to check out until they upgrade their account to a regular patron category. At the moment, every branch needs a SELFREG/All rule to prevent checkouts to the SELFREG category. If those rules aren't set, they'll hit the All/All rule for that branch before they can reach a SELFREG/All rule on the "Standard rules" setup. A global override rule would reduce the rules needed from one per branch to just one rule. Another possible implementation might be to make a "Global rule overrides for all libraries" page similar to the "Standard rules for all libraries" page, where any rules set on the overrides page would take top priority. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:58:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 18:58:03 +0000 Subject: [Koha-bugs] [Bug 35724] Define non-standard port numbers for SFTP upload/download in EDI accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35724 --- Comment #6 from Alex Buckley --- Created attachment 160719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160719&action=edit Bug 35724: Define non-standard ports for EDI SFTP in EDI accounts Not all EDI vendors accept Koha servers connecting on port 22, sometimes they require a different port to be used, so it would be helpful for librarians to be able to configure non-standard EDI SFTP ports themselves. Test plan: 1. Set EDIFACT syspref = 'Enable' and define a EDI account: Administration > Acquisition parameters > EDI accounts. 2. Create an EDI order: https://koha-community.org/manual/latest/en/html/acquisitions.html#ordering-via-edi 3. Confirm you can upload the EDI order and download the vendor invoice. 4. Apply patches, update database, and restart services. 5. Go to the EDI account you made in #1. 6. Confirm there are two new fields: Upload port and Download port, both have the value of 22. 7. Create a new EDI order. 8. Confirm you can upload the EDI order and download the vendor invoice. 9. Change the EDI account. Set the Download port = 10022. 10. Create a third EDI order. 11. Confirm you can upload the EDI order and download the vendor invoice. Sponsored-by: Waikato Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:58:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 18:58:16 +0000 Subject: [Koha-bugs] [Bug 35724] Define non-standard port numbers for SFTP upload/download in EDI accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35724 --- Comment #7 from Alex Buckley --- Created attachment 160720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160720&action=edit Bug 35724: DBIX Schema file changes Sponsored-by: Waikato Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 20:12:58 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 19:12:58 +0000 Subject: [Koha-bugs] [Bug 11180] IP branch attribute should accept CIDR notation and add multiple ip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11180 Phan Tung Bui changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160670|0 |1 is obsolete| | --- Comment #5 from Phan Tung Bui --- Created attachment 160721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160721&action=edit Bug 11180: IP branch attribute should accept CIDR notation and add multiple ip This patch adds the ability to set more than ip to IP setting of a branch and also CIDR notation can recognised also. Test plan: 1) Change systempreference AutoLocation to "Yes" 2) Go to the library settings ( Administration -> Libraries ) and you can add only one ip at format xxx.xxx.xxx.xxx or xxx.xxx.* 3) Apply patch 4) Go to the library settings and you can enter to IP setting those ip(s) you want seperate by space in any format like xxx.xxx.xxx.xxx or xxx.xxx.xxx.0/24 or xxx.xxx.xxx.* or only one also on the same formats. 3) Logout 4) Try to login from an ip that not belong on the set of ip that you enter before and now CIDR notation can regognized also and also you can have more than one ip for restriction. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 20:17:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 19:17:45 +0000 Subject: [Koha-bugs] [Bug 11180] IP branch attribute should accept CIDR notation and add multiple ip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11180 Phan Tung Bui changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |phan-tung.bui at inlibro.com --- Comment #6 from Phan Tung Bui --- Attempted to apply the batch, but encountered an Internal Server Error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 20:23:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 19:23:45 +0000 Subject: [Koha-bugs] [Bug 11180] IP branch attribute should accept CIDR notation and add multiple ip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11180 Matthias Le Gac changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.le-gac at inlibro.com --- Comment #7 from Matthias Le Gac --- According to the logs, the error probably comes from the file : C4/Auth.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 20:32:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 19:32:42 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #12 from Owen Leonard --- Here's what I've found so far: - The search from neworderempty.pl doesn't work at all. The form shows up but doesn't work to return results. - On some pages there is feedback when you click an "Add" button from the search results. If you select a patron who has a space in borrowers.firstname, e.g. "John Quincy" the message looks like this: "Patron 'John%20Quincy Adams' added." - Intermittently I get this error: Uncaught TypeError: can't access property "description", categories_map[data.toLowerCase()] is undefined ...but I haven't been able to pin down how to reproduce it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 20:47:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 19:47:05 +0000 Subject: [Koha-bugs] [Bug 35728] Add option to NOT redirect to result when search returns only one record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35728 --- Comment #3 from Aleisha Amohia --- Created attachment 160722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160722&action=edit Bug 35728: Add RedirectToSoleResult system preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 20:47:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 19:47:07 +0000 Subject: [Koha-bugs] [Bug 35728] Add option to NOT redirect to result when search returns only one record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35728 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160668|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia --- Created attachment 160723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160723&action=edit Bug 35728: Add ability to NOT redirect to result when search returns only one record This enhancement adds a new system preference RedirectToSoleResult. By default it is enabled, which matches current behaviour - to redirect to the detail page if it is the only search result. To test: 1) Apply the patch, install database updates, restart services. 2) Go to Koha Administration -> Global system preferences. The RedirectToSoleResult system preference is in the Searching tab. Confirm it is enabled (set to "Redirect") by default. 3) Conduct a catalogue search on the staff interface that you know will return a single result. Confirm you are redirected to the detail page. 4) Do the same search on the OPAC. Confirm you are redirected to the detail page. 5) Go back to the system preferences and disable the RedirectToSoleResult system preference by setting it to "Don't redirect" 6) Do the searches again on the staff interface and OPAC. Confirm you are NOT redirected to the detail page, and the search results page shows as expected. Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 20:47:28 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 19:47:28 +0000 Subject: [Koha-bugs] [Bug 35728] Add option to NOT redirect to result when search returns only one record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35728 --- Comment #5 from Aleisha Amohia --- (In reply to David Nind from comment #2) > Hi Aleisha. > > I like this! > > It looks like the patch(es) with the database update/system preference > addition is missing... > > David Oops! There you go -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 20:48:51 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 19:48:51 +0000 Subject: [Koha-bugs] [Bug 23295] Automatically debar patrons if SMS or email notice fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23295 Matthias Le Gac changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |matthias.le-gac at inlibro.com --- Comment #13 from Matthias Le Gac --- When I applied the patch it doesnt't work. I have this error : Applying: Bug 23295: Automatically restrict (debar) patrons when email/sms notices fail Using index info to reconstruct a base tree... M Koha/Notice/Message.pm M installer/data/mysql/mandatory/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref Auto-merging installer/data/mysql/mandatory/sysprefs.sql Auto-merging Koha/Notice/Message.pm CONFLICT (content): Merge conflict in Koha/Notice/Message.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 23295: Automatically restrict (debar) patrons when email/sms notices fail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 20:51:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 19:51:19 +0000 Subject: [Koha-bugs] [Bug 35748] New: Allow holds to be suspended, unsuspended, or canceled in batches based on branch or patron category code Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35748 Bug ID: 35748 Summary: Allow holds to be suspended, unsuspended, or canceled in batches based on branch or patron category code Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: wizzyrea at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Sometimes libraries have to close a branch or altogether, and they'd like to be able to cancel, suspend, and unsuspend holds in a batch. Currently this is achieved through command line database updates which are risky and require professional assistance, especially if your library is hosted. Normally this would be a per branch operation due to the "library is closing" use case, but it might be nice to be able to do this per patron category too. It would also be good if this job were implemented as a long_task background job. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 20:55:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 19:55:07 +0000 Subject: [Koha-bugs] [Bug 35748] Allow holds to be suspended, unsuspended, or canceled in batches based on branch or patron category code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35748 hebah at bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:01:34 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 20:01:34 +0000 Subject: [Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 --- Comment #28 from Victor Grousset/tuxayo --- (In reply to Jonathan Druart from comment #27) > However I do not see how your approach is correct. Selenium waits for the > page to load before starting the tests. It's a confusing trap ^^ This is a thing that was systematically causing confusion when I was trying to get help on a JavaScript chat. It's not about the page to be loaded. It's about $(document).ready() to have finished all it's content. The event Selenium waits for is the same as the one $(document).ready() waits for to start executing IIUC. The content of $(document).ready() callback is our stuff and there is no event to mark it's end. The flag is a way to replace that lack. > I would add a wait_for_element_visible on the page before selecting the th. IIRC, at the beginning I added a sleep after clicking the "show checkouts" button and the screenshot still showed the button pressed and not even the message that checkouts are loading. Stuff is just not loading and there is nothing to wait for, the click was too early and didn't trigger the request for checkout list. Ok here is a way to replicate what happens in the tests! :D In checkouts.js After `$(document).ready(function() {` Add `wait (5000);` So now it's possible to go hit the "show checkouts" button faster than the callback is set. And we see the same things that the screenshot showed in the early work on this ticket: the button stays down and checkouts never load. > And I would not add more delay, 10 should be enough. If there is no sign that the CI is hitting the timeout (we will see since there was no wait_for_ajax here) yeah, let's not have those crazy high ones. Question 1: Can we still keep the possibility of changing it? (the accessors added by the patch) Because next time I work on flaky tests elsewhere, I'll again need to extend the timeouts to be able to run a lot of times the rest of the tests without hindrance from the very long XHR response times I get. Question 2: I'm only thinking of this now: shouldn't I have not used accessors but instead have given wait_for_ajax() an optional param to overload the default max_retries? That would be easier to use than - getting the old max_retries value, - setting the new value - after the wait, setting back the original. Question 3: For a similar reason as to why we won't keep a high max_retries. (we can expect the CI to not hit this need) Can we try without the sleeps (DT_delay) before wait_for_ajax? It's to spare us unconditional sleep() (10 in total) which is more bothering than a timeout and even on my machine that seems to be very good at exposing flaky tests, the need for sleep $DT_delay didn't show up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:02:24 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 20:02:24 +0000 Subject: [Koha-bugs] [Bug 35748] Allow holds to be suspended, unsuspended, or canceled in batches based on branch or patron category code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35748 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:08:43 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 20:08:43 +0000 Subject: [Koha-bugs] [Bug 35748] Allow holds to be suspended, unsuspended, or canceled in batches based on branch or patron category code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35748 Laura O'Neil changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laura at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:18:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 20:18:55 +0000 Subject: [Koha-bugs] [Bug 35749] New: Allow hold pickup location to be batch changed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35749 Bug ID: 35749 Summary: Allow hold pickup location to be batch changed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: lisette.scheer at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If a library is closing, such as for a renovation or a school's summer closure, having the option to batch change all holds to pickup at the closest location can currently only be done at the command line. Having a tool for making that change on the staff side would be very helpful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:19:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 20:19:04 +0000 Subject: [Koha-bugs] [Bug 35749] Allow hold pickup location to be batch changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35749 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35748 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:19:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 20:19:04 +0000 Subject: [Koha-bugs] [Bug 35748] Allow holds to be suspended, unsuspended, or canceled in batches based on branch or patron category code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35748 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35749 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:19:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 20:19:39 +0000 Subject: [Koha-bugs] [Bug 35724] Define non-standard port numbers for SFTP upload/download in EDI accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35724 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #8 from Alex Buckley --- Hi all, This patchset is ready for testing. Please note, I hav checked and the changes I made to Koha/Edifact/Transport.pm are in functions not covered by unit tests: Koha::Edifact::Transport->sftp_upload() Koha::Edifact::Transport->sftp_download() The functions that call these subroutines are also not covered by unit tests: Koha::Edifact::Transport->upload_messages() Koha::Edifact::Transport->download_messages() I have, therefore, not written unit tests for this enhancement. However, if you believe unit tests are required please let me know. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:19:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 20:19:45 +0000 Subject: [Koha-bugs] [Bug 35724] Define non-standard port numbers for SFTP upload/download in EDI accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35724 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:22:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 20:22:55 +0000 Subject: [Koha-bugs] [Bug 35728] Add option to NOT redirect to result when search returns only one record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35728 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:22:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 20:22:57 +0000 Subject: [Koha-bugs] [Bug 35728] Add option to NOT redirect to result when search returns only one record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35728 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160722|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 160724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160724&action=edit Bug 35728: Add RedirectToSoleResult system preference Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:22:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 20:22:59 +0000 Subject: [Koha-bugs] [Bug 35728] Add option to NOT redirect to result when search returns only one record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35728 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160723|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 160725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160725&action=edit Bug 35728: Add ability to NOT redirect to result when search returns only one record This enhancement adds a new system preference RedirectToSoleResult. By default it is enabled, which matches current behaviour - to redirect to the detail page if it is the only search result. To test: 1) Apply the patch, install database updates, restart services. 2) Go to Koha Administration -> Global system preferences. The RedirectToSoleResult system preference is in the Searching tab. Confirm it is enabled (set to "Redirect") by default. 3) Conduct a catalogue search on the staff interface that you know will return a single result. Confirm you are redirected to the detail page. 4) Do the same search on the OPAC. Confirm you are redirected to the detail page. 5) Go back to the system preferences and disable the RedirectToSoleResult system preference by setting it to "Don't redirect" 6) Do the searches again on the staff interface and OPAC. Confirm you are NOT redirected to the detail page, and the search results page shows as expected. Sponsored-by: Education Services Australia SCIS Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:28:23 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 20:28:23 +0000 Subject: [Koha-bugs] [Bug 35748] Allow holds to be suspended, unsuspended, or canceled in batches based on branch or patron category code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35748 Esther Melander changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander at bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:33:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 20:33:14 +0000 Subject: [Koha-bugs] [Bug 35504] Release team 24.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 --- Comment #24 from Martin Renvoize --- Ordering is in the template hard coded and it depends on whether your running a stable or dev branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:38:33 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 20:38:33 +0000 Subject: [Koha-bugs] [Bug 35714] Clicking Print slips when no letter template selected causes error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35714 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:44:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 20:44:19 +0000 Subject: [Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 Matthias Le Gac changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.le-gac at inlibro.com --- Comment #89 from Matthias Le Gac --- Do you need again a signoff or it's good ? Because I can't find the field "Expire reserve charge" when I want to create smart rules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:51:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 20:51:48 +0000 Subject: [Koha-bugs] [Bug 34053] Text in holdings table gets wrapped on mobile, breaking words and decreasing readability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34053 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version|22.11 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:58:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 20:58:22 +0000 Subject: [Koha-bugs] [Bug 34053] Text in holdings table gets wrapped on mobile, breaking words and decreasing readability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34053 --- Comment #4 from Lucas Gass --- This looks to be solved by Bug 32341. Should we still use this bug to remove the custom style Owen mentioned? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 22:01:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 21:01:03 +0000 Subject: [Koha-bugs] [Bug 25813] Enhance patron expiration in SIP display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813 Matthias Le Gac changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.le-gac at inlibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Matthias Le Gac --- I can't apply le patch Applying: Bug 25813: Enhance patron expiration in SIP display Using index info to reconstruct a base tree... M C4/SIP/ILS/Patron.pm M t/db_dependent/SIP/Patron.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/SIP/Patron.t Auto-merging C4/SIP/ILS/Patron.pm CONFLICT (content): Merge conflict in C4/SIP/ILS/Patron.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 25813: Enhance patron expiration in SIP display -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 22:07:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 21:07:52 +0000 Subject: [Koha-bugs] [Bug 35750] New: Add DataTables responsive plugin to staff interface Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35750 Bug ID: 35750 Summary: Add DataTables responsive plugin to staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The OPAC has the DataTables responsive plugin to deal with tables on smaller screen sizes. The staff interface should have the same. The holdings table is a good example of a table that does work well with smaller screens. To recreate: 1. Go to detail page and look at the holdings table 2. At about 1000px or less you will start to see the table run off the screen 3. Look at the holdings table on an OPAC detail page. The table responds to screen size. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 22:09:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 21:09:48 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Phan Tung Bui changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phan-tung.bui at inlibro.com Status|Needs Signoff |Failed QA --- Comment #47 from Phan Tung Bui --- When i enter an incorrect username or password on the opac-user pl pages then click on log-in, instead of seeing the expected information like your username or card number, you only see a colon ":". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 22:14:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 21:14:36 +0000 Subject: [Koha-bugs] [Bug 35751] New: When recording local use with a statistical patron, alert of active transfers Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35751 Bug ID: 35751 Summary: When recording local use with a statistical patron, alert of active transfers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: emily.lamancusa at montgomerycountymd.gov QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 27992 Bug 27992 added alerts for many item statuses when a local use is recorded with a statistical patron - which is a great quality of life improvement! It would be great if an alert were added when the scanned item has an active transfer. Ideally, Koha would handle the transfer and display a modal as in a normal check-in, but at the very least it should display an alert informing the staff member that the item is in transit and needs to be checked in. This is particularly important if the item's physical transfer has gone awry somehow: currently, if an item is in-transit from Library A to Library B, and is scanned to a statistical patron at Library C for some reason, it would show as in-transit from A to B, but with a current location of C, which doesn't make much sense. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 [Bug 27992] When recording local use with statistical patron items are not checked in -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 22:14:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 21:14:36 +0000 Subject: [Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35751 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35751 [Bug 35751] When recording local use with a statistical patron, alert of active transfers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 22:32:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 21:32:05 +0000 Subject: [Koha-bugs] [Bug 35504] Release team 24.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 --- Comment #25 from David Nind --- A couple of things I noticed: 1. Under the 'Current maintenance team' - Wiki team: Mason James and George Williams to be added (already noted in comment #22), Katrin does so many updates to the Wiki - I think should be included 8-) - Release maintainers: These are not shown, not sure whether this role should be shown here or not (are listed under individual names in the 'Koha development team' section) - Continuous integration manager: Mason James not shown, not sure whether this role should be shown here or not (is listed under individual name in the 'Koha development team' section) 2. Under 'Koha development team' section: - Tomás Cohen Arazi: There is a bullet point then (24.05), assuming before that should be KTD maintainer - Frédéric Demians: Shows as Release Maintainer for 24.05 (not correct), should be 22.11 (LTS) * - Katrin Fischer: There is a bullet point then (23.05), not sure what that role should be for - Lucas Gass: Shows as Release Maintainer for 23.05 (correct), 23.11 (not correct), 24.05 (not correct) * - Andreas Hedström Mace: There is a bullet point then (20.05), not sure what that role should be for - Pedro Amorim, Agustín Moyano: Combined names for Topic expert (23.05) - Liz Rea: There is a bullet point then (23.05, 23.11, 24.05), assuming before that should be Website - Martin Renvoize: There is a bullet point then (23.05), not sure what that role should be for - Danyon Sewell: Shows as Release Maintainer for 23.11 (not correct) and 24.05 (not correct), should be 22.05 * - Fridolin Somers: Shows as Release Maintainer for 23.11 (correct) and 24.05 (not correct) * - Wainui Witika-Park: Shows as Release Maintainer for 21.11 (not checked), 22.05 (correct), 23.05 (not correct) * * Not sure how release maintainers should be shown - release cycle or individual releases. I think it should be the individual release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 22:46:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 21:46:06 +0000 Subject: [Koha-bugs] [Bug 35752] New: Can't delete additional contents with 'Delete selected' button Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35752 Bug ID: 35752 Summary: Can't delete additional contents with 'Delete selected' button Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 22:48:30 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 21:48:30 +0000 Subject: [Koha-bugs] [Bug 35752] Can't delete additional contents with 'Delete selected' button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35752 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34368 --- Comment #1 from Lucas Gass --- To recreate: 1. Have multiple additional content items ( news/HTML customization/Pages ) 2. On one of the pages ( news/HTML customization/Pages ) select more than one item and try to delete using the 'Delete selected' button 3. You are redirected but nothing happens. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 22:50:46 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 21:50:46 +0000 Subject: [Koha-bugs] [Bug 35752] Can't delete additional contents with 'Delete selected' button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35752 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 22:50:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 21:50:48 +0000 Subject: [Koha-bugs] [Bug 35752] Can't delete additional contents with 'Delete selected' button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35752 --- Comment #2 from Lucas Gass --- Created attachment 160726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160726&action=edit Bug 35752: Pass CSRF token to del_form To test: 1. Have multiple additional content items ( news/HTML customization/Pages ) 2. On one of the pages ( news/HTML customization/Pages ) select more than one item and try to delete using the 'Delete selected' button 3. You are redirected but nothing happens. 4. APPLY PATCH 5. Try again, this time you should be able to successfully delete additional-contents. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 22:51:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 21:51:02 +0000 Subject: [Koha-bugs] [Bug 35752] Can't delete additional contents with 'Delete selected' button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35752 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |lucas at bywatersolutions.com |y.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 22:56:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 21:56:26 +0000 Subject: [Koha-bugs] [Bug 35753] New: Is the Checkbox() function in additional-contents really necessary? Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35753 Bug ID: 35753 Summary: Is the Checkbox() function in additional-contents really necessary? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com There is a function in additional-contents.tt called Checkbox(). It checks to see if any checkboxes are checked. Can we just check the length with a selector and get rid of the function? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 22:56:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 21:56:36 +0000 Subject: [Koha-bugs] [Bug 35753] Is the Checkbox() function in additional-contents really necessary? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35753 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35752 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35752 [Bug 35752] Can't delete additional contents with 'Delete selected' button -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 22:56:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 21:56:36 +0000 Subject: [Koha-bugs] [Bug 35752] Can't delete additional contents with 'Delete selected' button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35752 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35753 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35753 [Bug 35753] Is the Checkbox() function in additional-contents really necessary? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 23:01:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 22:01:16 +0000 Subject: [Koha-bugs] [Bug 35753] Is the Checkbox() function in additional-contents really necessary? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35753 --- Comment #1 from Lucas Gass --- Created attachment 160727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160727&action=edit Bug 35753: Remove Checkbox() function To test: 1. APPLY PATCH and clear browser cache. 2. Have multiple additional content items ( news/HTML customization/Pages ) 3. From one of the pages ( news/HTML customization/Pages ) click the 'Delete selected' button. Since no items are checked you should see the 'Please select content to delete' alert. 4. Check some items and click 'Delete selected' they should be correctly deleted. Note: There is no change in behavior from this patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 23:01:28 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 22:01:28 +0000 Subject: [Koha-bugs] [Bug 35753] Is the Checkbox() function in additional-contents really necessary? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35753 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 23:14:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 22:14:41 +0000 Subject: [Koha-bugs] [Bug 35754] New: Place multiple item-group holds at once for the same record Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35754 Bug ID: 35754 Summary: Place multiple item-group holds at once for the same record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: jzairo at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com With the availability for item-groups and item group holds it make it very easy for patrons to place a hold on a group of items. This enhancement would provide an option to place multiple item-group holds for the same record. An example use case could be a patron wants to place a hold on volume 4, 5, and 6. Current behavior requires the user to place a hold for vol 4, then place another for vol 5, then finally place a hold for vol 6. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 23:18:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 22:18:47 +0000 Subject: [Koha-bugs] [Bug 33929] Cannot export genre/form authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33929 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #5 from Caroline Cyr La Rose --- Still valid on master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 23:34:25 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 22:34:25 +0000 Subject: [Koha-bugs] [Bug 35729] Upgrade Business::ISBN to at least 3.008 minimum version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729 --- Comment #5 from David Cook --- (In reply to Lucas Gass from comment #4) > The hard part here is packaging and I've CC'd Mason. It looks like Debian have a package for 3.008 libbusiness-isbn-perl, so we should be able to pluck it and libbusiness-isbn-data-perl off packages.debian.org and pop it into the Koha community apt repo. -- I was going to suggest adding unit tests, and that led me down a little rabbit hole. I think we will need to review the unit tests, since tests (like t/db_dependent/Koha.t) for things like C4::Koha::NormalizeISBN will probably start returning different values. I'm not sure what Business::ISBN does if you request a ISBN-10 from ISBN-13 prefixed with 979... but there are some existing bugs for this as well, so I'll add them as See Alsos... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 23:34:44 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 22:34:44 +0000 Subject: [Koha-bugs] [Bug 35729] Upgrade Business::ISBN to at least 3.008 minimum version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13167, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14287, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21821 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 23:34:44 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 22:34:44 +0000 Subject: [Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing valid 979* ISBN-13 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35729 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 23:34:44 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 22:34:44 +0000 Subject: [Koha-bugs] [Bug 14287] Preserve valid ISBN-13 identifiers if they start with something else than 978 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14287 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35729 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 23:34:44 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 22:34:44 +0000 Subject: [Koha-bugs] [Bug 21821] We should bundle an up to date RangeMessage.xml for Business::ISBN In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21821 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35729 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 23:56:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 22:56:35 +0000 Subject: [Koha-bugs] [Bug 35729] Upgrade Business::ISBN to at least 3.008 minimum version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729 --- Comment #6 from David Cook --- (In reply to Kal from comment #0) > I noticed that there was a cover mismatch with a coce_amazon cover because > the new 2024 title has an ISBN of 9798885795692 (using the 979 instead of > 978). There is an Italian title with an ISBN of 8885795692 that is showing > instead. Actually... looking back on Kal's original comment... I'd like to hear some steps on how to reproduce this problem. Because currently Koha will generate an empty "normalized_isbn" value for a ISBN starting with 979, so Koha shouldn't be trying to display any cover images. I just tested in koha-testing-docker and no cover image is even attempted with a record with the 9798885795692 ISBN. So... I'm not sure how this could be happening in Koha. Now I think that we should upgrade Business::ISBN because we do want to support ISBNs starting with 979. I think that will be a bit of work. However, even if we do that, Amazon is still going to be a problem. From past experience, I don't think that Amazon actually supports ISBN-13 at all when it comes to cover images. For example, note that all 3 of these URLs returns the same image. https://images-na.ssl-images-amazon.com/images/P/9798885795692.01.LZZZZZZZ.jpg https://images-na.ssl-images-amazon.com/images/P/9788885795692.01.LZZZZZZZ.jpg https://images-na.ssl-images-amazon.com/images/P/8885795692.01.LZZZZZZZ.jpg In the past, I think that's why we've used the ISBN-10 version for requesting images from Amazon. ISBN-13 with 979 is going to be a problem for Amazon images in particular. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 00:11:01 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 23:11:01 +0000 Subject: [Koha-bugs] [Bug 35729] Upgrade Business::ISBN to at least 3.008 minimum version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729 --- Comment #7 from Kal --- I noticed my cover mismatch in Aspen Discovery, not Koha, but we pull from coce.bywatersolutions.com and the cover source was coce_amazon so it's a bit of a gray area but why I put in the request for coce to be updated. I hope that helps! Thanks, Kal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 00:20:33 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 23:20:33 +0000 Subject: [Koha-bugs] [Bug 35729] Upgrade Business::ISBN to at least 3.008 minimum version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729 --- Comment #8 from Lucas Gass --- > However, even if we do that, Amazon is still going to be a problem. From > past experience, I don't think that Amazon actually supports ISBN-13 at all > when it comes to cover images. Well, that is a problem since 979 ISBN's cannot be converted to ISBN10. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 00:21:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 23:21:13 +0000 Subject: [Koha-bugs] [Bug 35729] Upgrade Business::ISBN to at least 3.008 minimum version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729 --- Comment #9 from David Cook --- This twigged another memory... (Note I'm not including lots of URLs here because Bugzilla always blocks me when I do.) If you look at the Amazon entry for "Berry Pickers" by Amanda Peters, obviously Amazon do have a cover image for it. But they're not using an ISBN to retrieve it. They use a different URL format with the key "91Yab+VyPgL._SY342_" And if you look at the "Product Advertising API" documentation, you can see that the API returns something like this: So https://m.media-amazon.com/images/I/91Yab+VyPgL._SY342_.jpg will be our book cover. Note that 91Yab+VyPgL._SY342_ isn't the identifier for the book. It's an image ID. The ASIN looks like it's B0BTSC3TN6. It looks like you might be able to use an ISBN to lookup "paapi5/documentation/use-cases/search-with-external-identifiers.html" However... I don't know whether they even support ISBN-13 for this lookup. Plus you need to be an Amazon Associate to use this API. -- So ultimately... Amazon cover images are going to be a problem whether or not we improve support for ISBN-13 979 prefixes througout Koha. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 00:21:56 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 23:21:56 +0000 Subject: [Koha-bugs] [Bug 35729] Upgrade Business::ISBN to at least 3.008 minimum version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729 --- Comment #10 from David Cook --- (In reply to Lucas Gass from comment #8) > > However, even if we do that, Amazon is still going to be a problem. From > > past experience, I don't think that Amazon actually supports ISBN-13 at all > > when it comes to cover images. > > Well, that is a problem since 979 ISBN's cannot be converted to ISBN10. Yup :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 00:24:25 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 23:24:25 +0000 Subject: [Koha-bugs] [Bug 35729] Upgrade Business::ISBN to at least 3.008 minimum version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729 --- Comment #11 from David Cook --- (In reply to Kal from comment #7) > I noticed my cover mismatch in Aspen Discovery, not Koha, but we pull from > coce.bywatersolutions.com and the cover source was coce_amazon so it's a bit > of a gray area but why I put in the request for coce to be updated. I hope > that helps! > > Thanks, > Kal Thanks, Kal. Unfortunately, I don't know enough about Coce or how Bywater populated it. But your report has certainly surfaced an interesting issue! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 00:28:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 23:28:17 +0000 Subject: [Koha-bugs] [Bug 24778] Move from Memcached to Redis to solve L1 caching issues? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24778 --- Comment #3 from David Cook --- I don't think it would really work anyway. We need to flush the L1 caches after each request for more reasons than just sysprefs as well I believe. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 00:29:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 23:29:15 +0000 Subject: [Koha-bugs] [Bug 35729] Upgrade Business::ISBN to at least 3.008 minimum version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729 --- Comment #12 from David Cook --- I wonder if we should change the name back to "Amazon images don't work for ISBNs starting with 979" and then have a separate report for upgrading Business::ISBN, since related but different? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 00:32:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 23:32:19 +0000 Subject: [Koha-bugs] [Bug 35729] Upgrade Business::ISBN to at least 3.008 minimum version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729 --- Comment #13 from Lucas Gass --- (In reply to David Cook from comment #12) > I wonder if we should change the name back to "Amazon images don't work for > ISBNs starting with 979" and then have a separate report for upgrading > Business::ISBN, since related but different? David, that's fine by me. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 00:32:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 23:32:36 +0000 Subject: [Koha-bugs] [Bug 35729] Amazon images don't work for > ISBNs starting with 979 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Upgrade Business::ISBN to |Amazon images don't work |at least 3.008 minimum |for > ISBNs starting with |version |979 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 00:32:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 23:32:48 +0000 Subject: [Koha-bugs] [Bug 35729] Amazon images don't work for > ISBNs starting with 979 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160714|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 00:32:58 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 23:32:58 +0000 Subject: [Koha-bugs] [Bug 35729] Amazon images don't work for > ISBNs starting with 979 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC|mtj at kohaaloha.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 00:39:43 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 23:39:43 +0000 Subject: [Koha-bugs] [Bug 35729] Amazon images don't work for ISBNs starting with 979 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Amazon images don't work |Amazon images don't work |for > ISBNs starting with |for ISBNs starting with 979 |979 | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 00:43:28 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 23:43:28 +0000 Subject: [Koha-bugs] [Bug 35754] Place multiple item-group holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35754 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- I don't think I understand the item-group functionality yet, but curious if the desire to place a hold on volume 4, 5, 6 would be the same as bug 15565 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 00:47:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 23:47:53 +0000 Subject: [Koha-bugs] [Bug 35754] Place multiple item-group holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35754 --- Comment #2 from David Cook --- Actually, after reading through your Monday Minutes on item groups... it looks like the same kind of idea but for multiple item groups and not multiple items. Got it... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 00:53:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2024 23:53:26 +0000 Subject: [Koha-bugs] [Bug 24738] Online registration should check if patron is registering for an already existing account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24738 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #4 from David Cook --- (In reply to Christopher Brannon from comment #0) > I think it would be good, if online registration noted that an account with > the e-mail address a patron is registering with is already in use. I'm pretty sure this is already possible using the system preference "PatronSelfRegistrationEmailMustBeUnique". Of course, I think it has a shortcoming in that it only looks at borrowers.email and not all email fields. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 01:16:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 00:16:59 +0000 Subject: [Koha-bugs] [Bug 35693] Granular Permissions to Everything In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35693 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- (In reply to Christopher Brannon from comment #0) > I am hoping that Koha will start thinking more about roles in the library, > and allowing us to give specific people access to specific pages, > customizations, etc. This goes even further with who can override things. > We don't have a lot of control over who can do what specific things. I think that you make a very good point, but Koha developers are a fairly loose group which support a variety of different libraries, and I think most developers have never worked as librarians themselves (with the exception of a few of us). Change usually comes from starting with one developer/vendor and then building support across the group. Personally, most of my (many) libraries have very small staff sizes, and I haven't heard any complaints around permissions (except for the latest one about requiring "edit_borrowers" to search/list borrowers). So I'm unlikely to get sponsorship for such a change. But I imagine there are other vendors who support libraries with larger staffs who would be more likely to get that kind of sponsorship. In the meantime, something that could be helpful is libraries coming up with a list of "personas" and "scenarios". These are useful elements of system design. Something basic like "Joe is a collection development librarian" (persona). The collection development librarian "needs to search the catalogue" (scenario), "needs to update only certain allowed lists" (scenario), "needs to update only collection development HTML pages" (scenario). Basically just outlining the hypothetical people and the things they need to do. >From there the developers can start working out how we can technologically allow those people to do those scenarios. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 01:30:48 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 00:30:48 +0000 Subject: [Koha-bugs] [Bug 24738] Online registration should check if patron is registering for an already existing account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24738 --- Comment #5 from Christopher Brannon --- (In reply to David Cook from comment #4) > (In reply to Christopher Brannon from comment #0) > > I think it would be good, if online registration noted that an account with > > the e-mail address a patron is registering with is already in use. > > I'm pretty sure this is already possible using the system preference > "PatronSelfRegistrationEmailMustBeUnique". No this setting is to only allow one account to have a specific email address. What I'm trying to ask for is that the patron be asked if they already have a card, that they somehow be told that they should already have an account and not be allowed to request a new one. Or, if they don't remember they have a card, and try to apply, and certain match points exist, that it not allow them to register online. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 03:23:05 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 02:23:05 +0000 Subject: [Koha-bugs] [Bug 24738] Online registration should check if patron is registering for an already existing account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24738 --- Comment #6 from David Cook --- (In reply to Christopher Brannon from comment #5) > (In reply to David Cook from comment #4) > > (In reply to Christopher Brannon from comment #0) > > > I think it would be good, if online registration noted that an account with > > > the e-mail address a patron is registering with is already in use. > > > > I'm pretty sure this is already possible using the system preference > > "PatronSelfRegistrationEmailMustBeUnique". > > No this setting is to only allow one account to have a specific email > address. What I'm trying to ask for is that the patron be asked if they > already have a card, that they somehow be told that they should already have > an account and not be allowed to request a new one. Or, if they don't > remember they have a card, and try to apply, and certain match points exist, > that it not allow them to register online. Currently, with that system preference, if they try to re-register using the same email address, it will say that they're already on the system. Are you saying that you just want additional match points? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 03:26:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 02:26:15 +0000 Subject: [Koha-bugs] [Bug 24738] Online registration should check if patron is registering for an already existing account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24738 --- Comment #7 from David Cook --- (In reply to Christopher Brannon from comment #3) > I have not known a system that doesn't either say that the email address is > already in use if you try to register under it, or at least give a generic > error message. Note that just because other systems do something doesn't mean that we're going to do it. I see potential security issues in so many other systems that I use routinely. And in the case of using additional match points, that involves capturing and storing more personal information as well, which then leads to increased risk to users in the event that there is a leak. But if you can articulate things a bit more clearly perhaps we can look at it a bit more. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 03:30:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 02:30:07 +0000 Subject: [Koha-bugs] [Bug 35755] New: Upgrade Business::ISBN to at least 3.008 minimum version Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 Bug ID: 35755 Summary: Upgrade Business::ISBN to at least 3.008 minimum version Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org As Lucas notes at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729#c2 we should upgrade Business::ISBN to handle ISBN-13 with a prefix of 979 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 03:30:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 02:30:15 +0000 Subject: [Koha-bugs] [Bug 35729] Amazon images don't work for ISBNs starting with 979 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35755 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 03:30:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 02:30:15 +0000 Subject: [Koha-bugs] [Bug 35755] Upgrade Business::ISBN to at least 3.008 minimum version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35729 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 03:30:33 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 02:30:33 +0000 Subject: [Koha-bugs] [Bug 35755] Upgrade Business::ISBN to at least 3.008 minimum version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13167, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14287, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21821 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 03:30:33 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 02:30:33 +0000 Subject: [Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing valid 979* ISBN-13 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35755 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 03:30:33 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 02:30:33 +0000 Subject: [Koha-bugs] [Bug 14287] Preserve valid ISBN-13 identifiers if they start with something else than 978 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14287 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35755 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 03:30:33 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 02:30:33 +0000 Subject: [Koha-bugs] [Bug 21821] We should bundle an up to date RangeMessage.xml for Business::ISBN In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21821 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35755 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 03:35:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 02:35:57 +0000 Subject: [Koha-bugs] [Bug 34423] (proof-of-concept) Bugzilla could look better with a new skin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34423 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 03:41:08 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 02:41:08 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 03:49:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 02:49:07 +0000 Subject: [Koha-bugs] [Bug 35710] Indexing problem with "&" symbol in Zebra. Some biblio-records with "&" symbol are not searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35710 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #5 from David Cook --- (In reply to Yuriy Kotsyuk from comment #3) > I’m not really sure that the problem is with the old koha version… This has the look of a data migration issue to me... When the & is added to the MARC record via the HTML form, it should be automatically converted into the entity & When I do use the HTML form, I see the following in the database: Norton & Company If I recall correctly, this automatic entity escaping is part of the MARC::File::XML: https://metacpan.org/dist/MARC-File-XML/source/lib/MARC/File/XML.pm#L370 -- Do you know how this record was added to Koha? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 03:53:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 02:53:15 +0000 Subject: [Koha-bugs] [Bug 35710] Indexing problem with "&" symbol in Zebra. Some biblio-records with "&" symbol are not searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35710 --- Comment #6 from David Cook --- The problem is that your record isn't valid XML. While it is possible for Koha to make invalid XML via the HTML form, it's very unlikely to happen with the &. So I'd say these records are from an external source that created them without regard to XML validity. Another noticeable flaw is also the following: That would never happen in a record created by Koha I think. If there's an empty value, the subfield and field would not have been created at all. -- My suggestion would be to write a script to iterate through your records and check whether or not they can be parsed as XML. Flag the ones that cannot be parsed, and look at fixing the problems. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 03:54:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 02:54:49 +0000 Subject: [Koha-bugs] [Bug 35710] Indexing problem with "&" symbol in Zebra. Some biblio-records with "&" symbol are not searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35710 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #7 from David Cook --- I'm going to mark this as invalid as I don't think it's a Koha bug. You can find more information on getting support with Koha here: https://koha-community.org/support/ I'm also happy to answer some follow up questions to the answers I've left here, since it seems like you're not too far away from a solution to the data problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 04:18:50 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 03:18:50 +0000 Subject: [Koha-bugs] [Bug 35701] Cannot use i18n.inc from memberentrygen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35701 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #9 from David Cook --- Variable scope in template toolkit definitely leaves a lot to be desired. I've bumped into similar issues with MACROs in email templates as well.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 04:19:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 03:19:45 +0000 Subject: [Koha-bugs] [Bug 35701] Cannot use i18n.inc from memberentrygen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35701 --- Comment #10 from David Cook --- Should probably change this bug title although I don't have a good title immediately in mind... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 04:25:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 03:25:18 +0000 Subject: [Koha-bugs] [Bug 24383] koha-create doesn't restart / empty memcached causing installer fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24383 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 05:56:42 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 04:56:42 +0000 Subject: [Koha-bugs] [Bug 11180] IP branch attribute should accept CIDR notation and add multiple ip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11180 --- Comment #8 from David Cook --- (In reply to Phan Tung Bui from comment #6) > Attempted to apply the batch, but encountered an Internal Server Error. Did you apply the database update? It looks like they forgot to mention that step in their test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 06:48:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 05:48:19 +0000 Subject: [Koha-bugs] [Bug 35752] Can't delete additional contents with 'Delete selected' button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35752 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 08:05:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 07:05:32 +0000 Subject: [Koha-bugs] [Bug 35728] Add option to NOT redirect to result when search returns only one record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35728 --- Comment #8 from Magnus Enger --- Would it make sense to split this in two, with one syspref for the OPAC and one for staff? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 08:36:45 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 07:36:45 +0000 Subject: [Koha-bugs] [Bug 35747] Some PUT endpoints wipe data if embeds are missing from the payload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35747 --- Comment #1 from Jonathan Druart --- We should use PATCH. There have been discussions about that, but I cannot find them! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 08:54:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 07:54:41 +0000 Subject: [Koha-bugs] [Bug 35756] New: Wrong use of encodeURIComponent in patron-search.inc Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35756 Bug ID: 35756 Summary: Wrong use of encodeURIComponent in patron-search.inc Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When a new patron is selected, the info message is showing "Patron %s is already in the list" or "Patron %s added". If the patron has space in their name, they will be substituted with %20 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 08:57:53 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 07:57:53 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #13 from Jonathan Druart --- Created attachment 160728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160728&action=edit Bug 35329: Fix neworderempty Hum I had to put it that way but I cannot remember why. Moving patron_search_js after patron_search_modal fixes the search problem (see comment 12). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 08:58:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 07:58:07 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #14 from Jonathan Druart --- (In reply to Owen Leonard from comment #12) > Here's what I've found so far: > > - The search from neworderempty.pl doesn't work at all. The form shows up > but doesn't work to return results. Should be fixed on "Bug 35329: Fix neworderempty" > - On some pages there is feedback when you click an "Add" button from the > search results. If you select a patron who has a space in > borrowers.firstname, e.g. "John Quincy" the message looks like this: > > "Patron 'John%20Quincy Adams' added." Reported on a separate bug (it affects master): bug 35756 > - Intermittently I get this error: > > Uncaught TypeError: can't access property "description", > categories_map[data.toLowerCase()] is undefined > > ...but I haven't been able to pin down how to reproduce it. This can happen if one of patron's category is not defined in the patron categories admin area (not possible, we have a FK, but maybe it's NULL?). Or if you have created a patron category in a separate window and run the search from the modal without having refreshed it. Just guesses here... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 08:59:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 07:59:47 +0000 Subject: [Koha-bugs] [Bug 34349] Validate inputs for task scheduler In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34349 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Product|Koha security |Koha Group|Koha security | Component|Koha |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 09:06:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 08:06:14 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #15 from Jonathan Druart --- Created attachment 160729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160729&action=edit Bug 35329: Remove fixedHeader If fixedHeader is set for the result table in the modal, the header will still appear (quite randomly) on the main view. To recreate the problem: Go to /cgi-bin/koha/members/memberentry.pl Click Add guarantor Search Close the modal Scroll down => The header of the table will be displayed randomly at the top of the page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 09:06:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 08:06:39 +0000 Subject: [Koha-bugs] [Bug 25813] Enhance patron expiration in SIP display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154697|0 |1 is obsolete| | --- Comment #5 from Matthias Meusburger --- Created attachment 160730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160730&action=edit Bug 25813: Enhance patron expiration in SIP display Currently, the patron information returned by SIP only shows "PATRON EXPIRED" when the patron card has expired. This patch makes the display more consistant with the Opac display and also complies with the NotifyBorrowerDeparture system preference. Test plan: - apply the patch - set NotifyBorrowerDeparture to 0 - check that nothing is ever displayed about the card expiration - set NotifyBorrowerDeparture to a value greater than 0 - check that the following message will be displayed for a card that will expire within NotifyBorrowerDeparture days: "Your card will expire on {correctly formatted date}" - check that the following message will be displayed for a card that has expired: "Your account has expired as of {correctly formatted date}" You can use src/C4/SIP/interactive_patron_dump.pl for easier testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 09:07:07 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 08:07:07 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #16 from Jonathan Druart --- Remaining work: 1. Add/fix some styling 2. Fix Select2 styling (width is too short) 3. Add E2E tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 09:07:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 08:07:41 +0000 Subject: [Koha-bugs] [Bug 25813] Enhance patron expiration in SIP display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #6 from Matthias Meusburger --- The patch has been rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 09:22:16 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 08:22:16 +0000 Subject: [Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 --- Comment #29 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #28) > In checkouts.js > After `$(document).ready(function() {` > Add `wait (5000);` "Uncaught ReferenceError: wait is not defined" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 09:23:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 08:23:20 +0000 Subject: [Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 --- Comment #30 from Jonathan Druart --- Can you attach here one patch to recreate the problem and one (as simple as possible) patch to fix it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 09:30:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 08:30:15 +0000 Subject: [Koha-bugs] [Bug 35545] "additional" item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35545 --- Comment #8 from Igor A. Sychev --- Created attachment 160731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160731&action=edit item number 669653 Item is withdrawn. Item number - 669653. biblionumber - 151173. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 09:39:28 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 08:39:28 +0000 Subject: [Koha-bugs] [Bug 35756] Wrong use of encodeURIComponent in patron-search.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35756 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 09:39:31 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 08:39:31 +0000 Subject: [Koha-bugs] [Bug 35756] Wrong use of encodeURIComponent in patron-search.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35756 --- Comment #1 from Jonathan Druart --- Created attachment 160732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160732&action=edit Bug 35756: Correctly serialize patron's data in patron search popup/modal We are incorrectly using encodeURIComponent in patron-search.inc. When a new patron is selected, the info message is showing "Patron %s is already in the list" or "Patron %s added". If the patron has space in their name, they will be substituted with %20. We are using JSON for select, we can reuse it for add. Test plan: Have a patron with spaces in their name Add users to a fund Notice that the name is correctly displayed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 09:43:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 08:43:20 +0000 Subject: [Koha-bugs] [Bug 35545] "additional" item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35545 --- Comment #9 from Igor A. Sychev --- In the second screenshot, the biblionumber is 669655. 461$9 - link to biblionumber 669653. Perhaps it does not work correctly. Why itemnumber 669653 from biblionumber 151173 "appear" in biblionumber 669655? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 09:45:18 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 08:45:18 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160698|0 |1 is obsolete| | Attachment #160699|0 |1 is obsolete| | Attachment #160700|0 |1 is obsolete| | Attachment #160701|0 |1 is obsolete| | Attachment #160702|0 |1 is obsolete| | Attachment #160703|0 |1 is obsolete| | Attachment #160704|0 |1 is obsolete| | Attachment #160705|0 |1 is obsolete| | Attachment #160706|0 |1 is obsolete| | Attachment #160728|0 |1 is obsolete| | Attachment #160729|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart --- Created attachment 160733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160733&action=edit Bug 35329: move patron search to modal - Add guarantor This is the first of many patches to come. We will rewrite the patron search popup to convert it to a Bootstrap's modal. I faced different problems on different pages, it is preferable to test each page on top of the whole patchset, to make sure a futur change will not break previous pages (and this is why they are all on the same bug report). For each page we will test that: * the different filters work * the "Clear" filters button work * the "Add" or "Select" patron button works * the nested modal to display patron's details (when clicking on their name or cardnumber) works On this patch we are testing the guarantor search: Create a edit a patron and click "Add guarantor" to open the modal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 09:45:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 08:45:21 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #18 from Jonathan Druart --- Created attachment 160734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160734&action=edit Bug 35329: Move patron search to modal - neworderempty Test plan: Create a new acquisition order and add users. FIXME: Note that rules for .modal-dialog .dialog.message need to be adjusted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 09:45:23 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 08:45:23 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #19 from Jonathan Druart --- Created attachment 160735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160735&action=edit Bug 35329: Move patron search to modal - basket Add user to an acquisition basket -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 09:45:25 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 08:45:25 +0000 Subject: [Koha-bugs] [Bug 35756] Wrong use of encodeURIComponent in patron-search.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35756 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 09:45:26 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 08:45:26 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #20 from Jonathan Druart --- Created attachment 160736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160736&action=edit Bug 35329: Move patron search to modal - funds This is a tricky one. We can have several modals per page, patron-search.inc needs to be adjusted to not use ids but classes. Also we need to declare JS variables with 'var' instead of 'let' (which does not allow redefinition of the same variable). Test plan: Create or modify a fund "Select owner" and "Add users" to open the modals. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 09:45:29 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 08:45:29 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #21 from Jonathan Druart --- Created attachment 160737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160737&action=edit Bug 35329: Move patron search to modal - edit-batch Test plan: Create new patron card batch Keep the textarea empty and click "Add patron(s)" to open the modal There is a special feature here, the "checkbox" column is displayed and you can select several patrons and click "Add selected patrons". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 09:45:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 08:45:32 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #22 from Jonathan Druart --- Created attachment 160738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160738&action=edit Bug 35329: Move patron search to modal - routing list The behaviour is a bit different here. Adding a patron from the popup refreshed the parent page with the newly added patron. With this patch the refresh of the page will happen when the modal is closed (if patrons have been added). Test plan: Create a subscription, receive one item, create a routing list. Add users. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 09:45:35 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 08:45:35 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #23 from Jonathan Druart --- Created attachment 160739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160739&action=edit Bug 35329: Move patron search to modal - erm Test plan: Edit an agreement or a license Add new user and click "Select user" to open the modal Test with different user for the same agreement/license -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 09:45:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 08:45:39 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #24 from Jonathan Druart --- Created attachment 160740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160740&action=edit Bug 35329: Move patron search to modal - suggestion Test plan: Edit a suggestion Click "Set patron" to change the suggester Click "Select manager" to set the manager On the suggestion list view, you can also select a manager. Make sure you are testing with different tabs (suggestions with different statuses). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 09:45:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 08:45:41 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #25 from Jonathan Druart --- Created attachment 160741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160741&action=edit Bug 35329: Move patron search to modal - remove members/search.pl git grep members/search.pl should not return any results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 09:45:44 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 08:45:44 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #26 from Jonathan Druart --- Created attachment 160742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160742&action=edit Bug 35329: Fix neworderempty Hum I had to put it that way but I cannot remember why. Moving patron_search_js after patron_search_modal fixes the search problem (see comment 12). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 09:45:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 08:45:47 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #27 from Jonathan Druart --- Created attachment 160743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160743&action=edit Bug 35329: Remove fixedHeader If fixedHeader is set for the result table in the modal, the header will still appear (quite randomly) on the main view. To recreate the problem: Go to /cgi-bin/koha/members/memberentry.pl Click Add guarantor Search Close the modal Scroll down => The header of the table will be displayed randomly at the top of the page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 09:46:23 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 08:46:23 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35756 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35756 [Bug 35756] Wrong use of encodeURIComponent in patron-search.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 09:46:23 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 08:46:23 +0000 Subject: [Koha-bugs] [Bug 35756] Wrong use of encodeURIComponent in patron-search.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35756 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35329 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 [Bug 35329] Move patron searches to a modal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 10:00:41 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 09:00:41 +0000 Subject: [Koha-bugs] [Bug 35111] Background jobs worker crashes on SIGPIPE when database connection lost in Ubuntu 22.04 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35111 --- Comment #27 from Jonathan Druart --- (In reply to David Cook from comment #24) > I've manually applied it to a 22.11 and they've been having a much better > past few days with this patch :) What do you see now? Can you search for jobs stuck since this patch has been applied? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 10:15:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 09:15:02 +0000 Subject: [Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35747 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 10:15:02 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 09:15:02 +0000 Subject: [Koha-bugs] [Bug 35747] Some PUT endpoints wipe data if embeds are missing from the payload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35747 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35287 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 10:24:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 09:24:32 +0000 Subject: [Koha-bugs] [Bug 34360] [WARN] DBIx::Class::ResultSetColumn::new(): Attempting to retrieve non-unique column 'biblionumber' on a resultset containing one-to-many joins will return duplicate results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34360 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Depends on| |33497 --- Comment #3 from Jonathan Druart --- This is coming from commit 2cf00f1a49a7b9f8d5ca105e2dd1add5d5d95198 Bug 33497: Use 'host_items' param to fetch all items at once -my @items = $biblio->items->search_ordered( $params )->as_list; +my $items = $biblio->items({ host_items => 1 })->search_ordered( $params, { prefetch => ['issue','branchtransfers'] } ); And the get_column call from Koha::Items->search_ordered 453 my @biblionumbers = uniq $self->get_column('biblionumber'); Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 [Bug 33497] Reduce DB calls on staff detail page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 10:24:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 09:24:32 +0000 Subject: [Koha-bugs] [Bug 33497] Reduce DB calls on staff detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34360 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34360 [Bug 34360] [WARN] DBIx::Class::ResultSetColumn::new(): Attempting to retrieve non-unique column 'biblionumber' on a resultset containing one-to-many joins will return duplicate results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 10:35:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 09:35:36 +0000 Subject: [Koha-bugs] [Bug 35659] OAI Harvester In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160356|0 |1 is obsolete| | --- Comment #9 from Matthias Meusburger --- Created attachment 160744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160744&action=edit Bug 35659: OAI Harvester Test plan: - Run updatedatabase.pl - Apply the DBIC update patch - Setup an OAI repository in Administration -> OAI repositories (admin/oaiservers.pl) If the repository dataformat is in oai_dc, you can use the sample XSLT files: For Unimarc: OAIDCtoUNIMARCXML.xsl for bibliographic records AuthOAIDCtoUNIMARCXML.xsl for authorities For Marc21: OAIDCtoMARC21XML.xsl for bibliographic records AuthOAIDCtoMARC21XML.xsl for authorities If the repository dataformat is in marc-xml, you can use OAIMarcxml2KohaMarcxml.xsl for both Unimarc and Marc21. - Some repositories to test with: Bibliographic records, oai_dc: Endpoint: http://staroai.theses.fr/OAIHandler Set: ddc:260 XSLT: /koha-tmpl/intranet-tmpl/prog/en/xslt/OAIDCtoUNIMARCXML.xsl or XSLT: /koha-tmpl/intranet-tmpl/prog/en/xslt/OAIDCtoMARC21XML.xsl Authorities, oai_dc: Endpoint: https://www.idref.fr/OAI/oai.jsp Set: a XSLT: /koha-tmpl/intranet-tmpl/prog/en/xslt/AuthOAIDCtoUNIMARCXML.xsl or XSLT: /koha-tmpl/intranet-tmpl/prog/en/xslt/AuthOAIDCtoMARC21XML.xsl Authorities, marc-xml, Unimarc: Endpoint: https://www.idref.fr/OAI/oai.jsp Set: a XSLT: /koha-tmpl/intranet-tmpl/prog/en/xslt/OAIMarcxml2KohaMarcxml.xsl - Note: marc-xml harvesting will not work with HTTP::OAI::Harvester version 3.xx Version 4.xx is needed. See Bug 17704 for updating Koha default version to 4.xx - If you want to receive a report email, fill the OAI-PMH:HarvestEmailReport syspref. The model used (OAI_HARVEST_REPORT) can be edited in tools -> Notices and slips. - start a harvest with the following command: misc/cronjobs/harvest_oai.pl This script starts an OAI Harvest This script has the following parameters : -h --help: this message -v --verbose (enable output to stdout) -r --repository: id of the OAI repository -d --days: number of days to harvest from (optional) -l --list: list the OAI repositories -f --force: force harvesting (ignore records datestamps) (optional) Example: misc/cronjobs/harvest_oai.pl -r 1 -d 10 -v -f - Check the logs in the Log Viewer (tools/viewlog.pl) (CronjobLog syspref must be activated) Sponsored-by: KohaLa -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 10:37:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 09:37:20 +0000 Subject: [Koha-bugs] [Bug 34360] [WARN] DBIx::Class::ResultSetColumn::new(): Attempting to retrieve non-unique column 'biblionumber' on a resultset containing one-to-many joins will return duplicate results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34360 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major --- Comment #4 from Jonathan Druart --- I am failing at providing a correct fix. The warning looks bad, we should not ignore it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 10:45:34 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 09:45:34 +0000 Subject: [Koha-bugs] [Bug 35659] OAI Harvester In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #10 from Matthias Meusburger --- Hi David! The typo in Koha/Import/Oaipmh/Authority.pm, Koha/Import/Oaipmh/Biblio.pm and Koha/OaiServers.pm has been fixed. POD has been added to Koha/OAI/Client/Harvester.pm > I think the error for Koha/OaiServer.pm is false though. Not sure why that's getting a pod coverage error... About those, ashimema told me on IRC: 15:07 ashimema if they're new classes you can safely ignore that.. 15:07 there's a bug in the POD detection for new clases > I think the tidiness can also be ignored for the Schema files... That's what I thought too, since they are auto-generated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 11:04:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 10:04:17 +0000 Subject: [Koha-bugs] [Bug 25885] Show list of hits for one search result In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25885 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #13 from Magnus Enger --- *** This bug has been marked as a duplicate of bug 35728 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 11:04:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 10:04:17 +0000 Subject: [Koha-bugs] [Bug 35728] Add option to NOT redirect to result when search returns only one record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35728 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #9 from Magnus Enger --- *** Bug 25885 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 11:06:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 10:06:27 +0000 Subject: [Koha-bugs] [Bug 35697] Checkingout books causes a error 500 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35697 --- Comment #4 from Pradeep --- I have checked $y, $a and $b item have all information. Also checked log. Problem occurred after upgrade (23.11) Now we are using Koha Offline circulation Firefox plugin to do check out. Renew and Check in is working very well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 11:08:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 10:08:20 +0000 Subject: [Koha-bugs] [Bug 35697] Checkingout books causes a error 500 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35697 --- Comment #5 from Pradeep --- I have checked $y, $a and $b item have all information. Also checked log. Problem occurred after upgrade (23.11) Now we are using Koha Offline circulation Firefox plugin to do check out. Renew and Check in is working very well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 11:12:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 10:12:55 +0000 Subject: [Koha-bugs] [Bug 35757] New: Sushi service and counter registry tests are failing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35757 Bug ID: 35757 Summary: Sushi service and counter registry tests are failing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: matt.blenkinsop at ptfs-europe.com CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, matt.blenkinsop at ptfs-europe.com, pedro.amorim at ptfs-europe.com The tests for the sushi service and counter registry endpoints are failing. Currently they are based on comparing an expected response with an actual response which is not ideal. This bug is to re-write the tests to just check the field names that are being returned by the external API so identify any changes to the API that could affect functionality in Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 11:13:04 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 10:13:04 +0000 Subject: [Koha-bugs] [Bug 35757] Sushi service and counter registry tests are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35757 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha at gmail. |matt.blenkinsop at ptfs-europe |com |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 11:19:34 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 10:19:34 +0000 Subject: [Koha-bugs] [Bug 35757] Sushi service and counter registry tests are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35757 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 11:19:36 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 10:19:36 +0000 Subject: [Koha-bugs] [Bug 35757] Sushi service and counter registry tests are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35757 --- Comment #1 from Matt Blenkinsop --- Created attachment 160745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160745&action=edit Bug 35757: Add new fields to api definitions The counter registry API has added a new field to both the counter registry and sushi service endpoints. This patch adds those new fields to the definitions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 11:19:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 10:19:39 +0000 Subject: [Koha-bugs] [Bug 35757] Sushi service and counter registry tests are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35757 --- Comment #2 from Matt Blenkinsop --- Created attachment 160746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160746&action=edit Bug 35757: Fix unit tests for external counter registry API This patch updates the unit tests for the external counter registry API used in the Usage Statistics module. The intent of the tests is to identify any changes in the external response that could lead to errors in Koha. To do this, the tests now compare the list of hask keys returned in the response with the current definition in Koha, and identifies any new fields that need to be added to the definition. Test plan: prove t/db_dependent/api/v1/erm_counter_registries.t prove t/db_dependent/api/v1/erm_sushi_services.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 11:22:59 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 10:22:59 +0000 Subject: [Koha-bugs] [Bug 35757] Sushi service and counter registry tests are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35757 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160746|0 |1 is obsolete| | --- Comment #3 from Matt Blenkinsop --- Created attachment 160747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160747&action=edit Bug 35757: Fix unit tests for external counter registry API This patch updates the unit tests for the external counter registry API used in the Usage Statistics module. The intent of the tests is to identify any changes in the external response that could lead to errors in Koha. To do this, the tests now compare the list of hash keys returned in the response with the current definition in Koha, and identifies any new fields that need to be added to the definition. Test plan: prove t/db_dependent/api/v1/erm_counter_registries.t prove t/db_dependent/api/v1/erm_sushi_services.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 11:25:17 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 10:25:17 +0000 Subject: [Koha-bugs] [Bug 35757] Sushi service and counter registry tests are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35757 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 11:25:19 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 10:25:19 +0000 Subject: [Koha-bugs] [Bug 35757] Sushi service and counter registry tests are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35757 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160745|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 160748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160748&action=edit Bug 35757: Add new fields to api definitions The counter registry API has added a new field to both the counter registry and sushi service endpoints. This patch adds those new fields to the definitions. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 11:25:22 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 10:25:22 +0000 Subject: [Koha-bugs] [Bug 35757] Sushi service and counter registry tests are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35757 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160747|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 160749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160749&action=edit Bug 35757: Fix unit tests for external counter registry API This patch updates the unit tests for the external counter registry API used in the Usage Statistics module. The intent of the tests is to identify any changes in the external response that could lead to errors in Koha. To do this, the tests now compare the list of hash keys returned in the response with the current definition in Koha, and identifies any new fields that need to be added to the definition. Test plan: prove t/db_dependent/api/v1/erm_counter_registries.t prove t/db_dependent/api/v1/erm_sushi_services.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 12:01:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 11:01:13 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #19 from Martin Renvoize --- Created attachment 160750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160750&action=edit Bug 35681: [ALT] Use ::Bootstrap version of FromANSI With the next iteration of HTML::FromANSI::Tiny we can add our own subclass to map ANSI strings to Bootstrap classes. This patch adds a local lib HTML::FromANSI::Tiny::Bootstrap module to do said mapping and then uses it in the installer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 12:01:15 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 11:01:15 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #20 from Martin Renvoize --- Created attachment 160751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160751&action=edit Bug 35681: [TESTING] Add local copy of latest Tiny This temporary patch is for testing only.. we add a local copy of the updated version of HTML::FromANSI::Tiny to allow simple testing without having to manually install the pre-release module version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 12:07:27 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 11:07:27 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #21 from Martin Renvoize --- I have an alternative to the follow-up that switched us from inline styles to custom classes. After I opened an issue against the upstream module about mapping ANSI codes to local Classes, he quickly replied with a change to review. It works great, so I've added an alternative patch here that utilises it. The [ALT] patch is meant to replace 'Use CSS class instead of inline style' in the patchset and then the [TESTING] patch that follows it is to simplify testing whilst we wait for the upstream change to be merged (I take a local copy of the adapted class into the local koha lib so you no longer need to install from cpan to test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 12:07:40 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 11:07:40 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 12:15:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 11:15:03 +0000 Subject: [Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 12:44:49 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 11:44:49 +0000 Subject: [Koha-bugs] [Bug 35504] Release team 24.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160463|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize --- Created attachment 160752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160752&action=edit Bug 35504: New cycle, new team :) Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 12:44:52 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 11:44:52 +0000 Subject: [Koha-bugs] [Bug 35504] Release team 24.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160464|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize --- Created attachment 160753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160753&action=edit Bug 35504: Typo fix Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 12:44:55 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 11:44:55 +0000 Subject: [Koha-bugs] [Bug 35504] Release team 24.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160465|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize --- Created attachment 160754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160754&action=edit Bug 35504: Corrections to team Correction of 'advocate' to 'advocates' to ensure they appear in the team. Addition of 'website' and 'wiki' handling to ensure they also appear in the team. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 12:44:57 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 11:44:57 +0000 Subject: [Koha-bugs] [Bug 35504] Release team 24.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160466|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize --- Created attachment 160755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160755&action=edit Bug 35504: Add ktd maintainer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 12:45:00 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 11:45:00 +0000 Subject: [Koha-bugs] [Bug 35504] Release team 24.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 --- Comment #30 from Martin Renvoize --- Created attachment 160756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160756&action=edit Bug 35504: Corrections to wiki team -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 12:45:03 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 11:45:03 +0000 Subject: [Koha-bugs] [Bug 35504] Release team 24.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 --- Comment #31 from Martin Renvoize --- Created attachment 160757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160757&action=edit Bug 35504: Change 'Jenkins' to 'Continuous integration' We were naming these roles differently between the 'current team' and 'past roles' display. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 12:45:06 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 11:45:06 +0000 Subject: [Koha-bugs] [Bug 35504] Release team 24.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 --- Comment #32 from Martin Renvoize --- Created attachment 160758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160758&action=edit Bug 35504: Add full maintainers list into development branch On a stable branch the current maintainer of your running version is listed at the top of the current maintanence team.. however when you're on a development branch the RM is responsible for your branch and the maintainers were missing from display. This patch adds the maintainers list back to the bottom of the current maintanence team section, just for the development branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 12:56:21 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 11:56:21 +0000 Subject: [Koha-bugs] [Bug 34312] Advanced Editor - Rancor - Restore UNIMARC encoding support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34312 Mathieu Saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 13:02:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 12:02:47 +0000 Subject: [Koha-bugs] [Bug 35754] Place multiple item-group holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35754 --- Comment #3 from Jessie Zairo --- (In reply to David Cook from comment #1) > I don't think I understand the item-group functionality yet, but curious if > the desire to place a hold on volume 4, 5, 6 would be the same as bug 15565 Exactly, David. Very similar to 15565 if I was placing a hold for single items. In this case, just for item groups. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 13:19:47 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 12:19:47 +0000 Subject: [Koha-bugs] [Bug 35504] Release team 24.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 --- Comment #33 from Martin Renvoize --- (In reply to David Nind from comment #25) > A couple of things I noticed: > > 1. Under the 'Current maintenance team' > - Wiki team: Mason James and George Williams to be added (already noted > in comment #22), Katrin does so many updates to the Wiki - I think should be > included 8-) Fixed - I removed Katrin, but I agree, she does lots of Wiki stuff so I would have been happy to keep her too. > - Release maintainers: These are not shown, not sure whether this role > should be shown here or not (are listed under individual names in the 'Koha > development team' section) This all depends on what Koha version you're looking at (i.e. a development checkout vs a stable branch). For a stable branch the maintainer for the version your on will appear at the top.. for a development one the maintainers list wasn't appearing at all.. I've added a patch to get them to appear for the development channel too. > - Continuous integration manager: Mason James not shown, not sure whether > this role should be shown here or not (is listed under individual name in > the 'Koha development team' section) It was listed as 'Jenkins'.. I've updated the term to match what we call it in the lower section. > 2. Under 'Koha development team' section: Looking at these one's now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 13:31:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 12:31:14 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #28 from Owen Leonard --- Created attachment 160759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160759&action=edit Bug 35329: (follow-up) Trigger Select2 upon modal open If we wait until the modal is visible Select2 can correctly calculate the width needed for the Sort 1 and Sort 2 dropdowns. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 13:56:29 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 12:56:29 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #29 from Jonathan Druart --- Created attachment 160760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160760&action=edit Bug 35329: Prevent XSS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 14:04:13 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 13:04:13 +0000 Subject: [Koha-bugs] [Bug 35569] Remember user-selected columns in holdings table on staff detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35569 --- Comment #4 from Piia Semenoff --- (In reply to Katrin Fischer from comment #3) > Hi Piia, I am changing the bug title to make it about this table. I think we > need to make it happen table by table right now. Thanks, and sorry I didn't give all the information needed right away. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 14:08:14 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 13:08:14 +0000 Subject: [Koha-bugs] [Bug 30623] Copy permissions from one user to another In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30623 --- Comment #17 from Marcel de Rooy --- (In reply to Owen Leonard from comment #16) > (In reply to Marcel de Rooy from comment #7) > > Moving this to In Discussion temporarily. Will mail QA about it. > > I'm curious whether there has been a QA team discussion about this? Owen, unfortunately I am not aware of any specific feedback that should have been noted here apart from the comment of Tomas. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 14:13:39 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 13:13:39 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160760|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart --- Created attachment 160761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160761&action=edit Bug 35329: Prevent XSS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 14:19:20 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 13:19:20 +0000 Subject: [Koha-bugs] [Bug 35758] New: Background jobs should not log personal data apart from borrowernumber Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35758 Bug ID: 35758 Summary: Background jobs should not log personal data apart from borrowernumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: michaela.sieber at kit.edu When looking at the background_jobs table the column context contains a lot of personal information that is not necessary for the purpose of this table: * firstname * surname * email address This makes it hard to share data for debugging. It's also end user information, not only staff accounts. Example: If the library is using Elasticsearch, renewing items in the OPAC will create a reindex job entry for each biblionumber. This will be logged with the context of the patron. There is no reason to duplicate this data into the context table, we can save space and avoid headaches by removing this information. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 14:39:32 2024 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2024 13:39:32 +0000 Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #31 from Owen Leonard --- Created attachment 160762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160762&action=edit Bug 35329: (follow-up) Label changes for improved accessibility This patch alters the patron search form so that