[Koha-bugs] [Bug 35659] OAI Harvester

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au
             Status|Needs Signoff               |Failed QA

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
This is great news! Once my January holidays are done, I can look more at these
patches!

At a glance, you will need to add unit tests for Koha::OAI::Client::Harvester
before this can Pass QA (PERL17 in the coding guidelines), and that might
require a bit of refactoring. (Missing unit tests are what ultimately bit me
with bug 10662.)

I think that we're not allowing function declarations in .pl scripts anymore
either (for admin/oaiservers.pl) so that might need to be refactored. That
said, I can't find a reference to it in the coding guidelines and the patches
pass the QA scripts, so I could be wrong there. 

But other than that the patches are looking pretty good at a glance I think.

-- 
You are receiving this mail because:
You are watching all bug changes.