[Koha-bugs] [Bug 35659] OAI Harvester

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659

--- Comment #5 from David Cook <dcook at prosentient.com.au> ---
I updated my ktd and now I'm getting failures when running the QA tools,
although I've got the unit test working.

I notice there is a little typo in the pod in Koha/Import/Oaipmh/Authority.pm
where it says "type" instead of "_type". Same with Koha/Import/Oaipmh/Biblio.pm
and Koha/OaiServers.pm. 

Koha/OAI/Client/Harvester.pm is missing POD. 

I think the error for Koha/OaiServer.pm is false though. Not sure why that's
getting a pod coverage error... 

I think the tidiness can also be ignored for the Schema files...

--

qa -c 2 -v 2
testing 2 commit(s) (applied to ac02c1d 'ad Bug 35405: Remove noise from
MARC:')

Processing files before patches
The PO directory has not been found. There is a problem in your Koha
installation. at /kohadevbox/koha/Koha/I18N.pm line 197.
|========================>| 27 / 27 (100.00%)
Processing files after patches
|========================>| 27 / 27 (100.00%)

 OK     Koha/Import/Oaipmh/Authorities.pm

 FAIL   Koha/Import/Oaipmh/Authority.pm
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666

 FAIL   Koha/Import/Oaipmh/Biblio.pm
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666

 OK     Koha/Import/Oaipmh/Biblios.pm

 FAIL   Koha/OAI/Client/Harvester.pm
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666

 FAIL   Koha/OaiServer.pm
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666

 OK     Koha/OaiServers.pm

 FAIL   Koha/Schema/Result/ImportOaipmhAuthority.pm
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 0,
now: 33)

 FAIL   Koha/Schema/Result/ImportOaipmhBiblio.pm
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 0,
now: 28)

 FAIL   Koha/Schema/Result/Oaiserver.pm
   FAIL   pod coverage
                POD is missing for koha_object_class
                POD is missing for koha_objects_class
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 0,
now: 24)

 OK     admin/oaiservers.pl

 OK     installer/data/mysql/atomicupdate/Bug-35659.pl

 OK     installer/data/mysql/en/mandatory/sample_notices.yml

 OK     installer/data/mysql/kohastructure.sql

 OK     installer/data/mysql/mandatory/sysprefs.sql

 OK     koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc

 OK     koha-tmpl/intranet-tmpl/prog/en/includes/oai-admin-search.inc

 OK     koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc

 OK     koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt

 OK     koha-tmpl/intranet-tmpl/prog/en/modules/admin/oaiservers.tt

 OK     koha-tmpl/intranet-tmpl/prog/en/xslt/AuthOAIDCtoMARC21XML.xsl

 OK     koha-tmpl/intranet-tmpl/prog/en/xslt/AuthOAIDCtoUNIMARCXML.xsl

 OK     koha-tmpl/intranet-tmpl/prog/en/xslt/OAIDCtoMARC21XML.xsl

 OK     koha-tmpl/intranet-tmpl/prog/en/xslt/OAIDCtoUNIMARCXML.xsl

 OK     koha-tmpl/intranet-tmpl/prog/en/xslt/OAIMarcxml2KohaMarcxml.xsl

 OK     misc/cronjobs/harvest_oai.pl

 OK     t/db_dependent/Koha/OAIServers.t


Processing additional checks

        * Commit title does not start with 'Bug XXXXX: ' - 44b002f8cc

Running tests (1)
        * Proving /kohadevbox/koha/t/db_dependent/Koha/OAIServers.t OK!

-- 
You are receiving this mail because:
You are watching all bug changes.