[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Jan 3 14:14:26 CET 2024


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #15 from Nick Clemens <nick at bywatersolutions.com> ---
Using the settings and test file from bug 34645 I expect to get 8 items - I
only get 2. I suspect there is a problem in
_get_MarcItemFieldsToOrder_syspref_data as it builds an array, but only returns
a single:
return $result[0];

Two routines that are used have not been imported:
+    GetImportBatchRangeDesc
+    GetNumberOfNonZ3950ImportBatches


Why not use C4::Context->yaml_preference in the _get_MarcItem... subroutines?

Can you provide a test plan with sample data (feel free to steal from 34645) we
should test with a file with multiple records and multiple orders per record

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list