[Koha-bugs] [Bug 30745] ES : Search never return result using after-date and/or before-date in labels/label-item-search.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|alex.arnaud at biblibre.com    |emily-rose.francoeur at inLibr
                   |                            |o.com
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Failed QA

--- Comment #19 from David Nind <david at davidnind.com> ---
I was about to sign off, but then came across this Zebra only error - I get
this error after the patches are applied (and a reindex):

   Error: Can't use an undefined value as an ARRAY reference at
/kohadevbox/koha/labels/label-item-search.pl line 88
   ....

1. Generated by putting a letter in the input box for these index searches
(without any dates in the filters): publication date, standard number, ISBN,
ISSN, call number, acquisition date

2. I could also generate this error with a number in a text field, for example:
Author index, 2011 (but with 2000 no error is generated)

3. With Elasticsearch, no results are displayed and the form just refreshes
(both before and after the patches, and the same with Zebra before the patches)

Other notes
===========

1. I couldn't work out how or where cgi-bin/koha/labels/label-item-search.pl is
used/accessed from - something to do with acquisitions?

2. I've changed the assignee.

3. I didn't test with a UNIMARC installation.

Testing notes (using koha-testing-docker)
=========================================

Setup
~~~~~

To test with Elasticsearch or OpenSearch - start up KTD with Elasticsearch or
OpenSearch: ktd --es8 up OR ktd --os2 up (I didn't test with Open Search, just
Zebra and Elasticsearch)

Go to this page in the staff interface:
http://127.0.0.1:8081/cgi-bin/koha/labels/label-item-search.pl

Searching using Zebra (after KTD is started with --es8):
- Change the SearchEngine system preference to Zebra
- Reload http://127.0.0.1:8081/cgi-bin/koha/labels/label-item-search.pl
- Reindex: koha-rebuild-zebra -d -f -v kohadev
- Repeat all the example searches - you should get the same results

Demonstrating the issue and that the patches fix it
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Notes: In the sample data, the acquisition date is recorded in 952$d - Date
acquired. 
       For many items, 09/04/2014 is used.
       For some items, these dates are used 05/08/2014, 05/07/2014, 10/15/2014,
12/04/2014, 1/05/2015.
       Many items don't have a date recorded.
       If there is no value in the index field, it is ignored.
       If an index is selected and a value is entered, the results should be
filtered by any values entered in 'Added on or after date' and 'Added on or
before date' fields.

Before the patches: index searches work, but when used with 'Added on or after
date' and 'Added on or before date' options, the search results ignore them.
However, entering a date for the 'Acquisition date' index does work.

A title index search:
- Title index: perl
  => Expected result: 11
  => Actual result: 11

A combined search with dates:
- Title index: perl
- Added on or after date: 09/04/2014
  => Expected result: 10 (1 perl record has no items)
  => Actual result: No results

A combined search with dates:
- Title index: perl
- Added on or before date: 09/04/2014
  => Expected result: 10 (1 perl record has no items)
  => Actual result: No results

Acquisition date index search:
- Index: select 'Acquisition date' from the dropdown list
- Value to enter: 09/04/2014
  => Expected result: 352 results
  => Actual result: 352 result

Acquisition date index search:
- Index: select 'Acquisition date' from the dropdown list
- Value to enter: 09/04/2014
- Added on or after date: 09/04/2014
  OR
- Added on or before date: 09/04/2014
  OR
  Use both or none
  => Expected result: 352 results
  => Actual result: 352 results

Search using 'Added on or after date' (after date) only:
- Added on or after date: 09/04/2014
  => Expected result: should get 408 records
  => Actual result: 0 results

Search using 'Added on or before date' (before date) only:
- Added on or after date: 09/04/2014
  => Expected result: should get 354 records
  => Actual result: 0 results

Publication date index search using 2011 (AFTER patches are applied - doesn't
work as expected BEFORE the patches are applied):
- Results if no before or after filter added: 8 (as expected)
- Results if Added on or after date: 09/04/2014 - 8 (as expected)
- Results if Added on or before date: 09/04/2014 - 7 (as expected)
- Results for a date range - 7 (as expected):
  . Added on or after date: 09/04/2014
  . Added on or before date: 09/05/2014
- Results for a date range - 8 (as expected):
  . Added on or after date: 09/04/2014
  . Added on or before date: 10/15/2014
- Results for a date range - 1 (as expected):
  . Added on or after date: 09/05/2014
  . Added on or before date: 10/15/2014
(One record and all its items has acquisition dates of 10/15/2014 -
Blackstone's statutes on company law 2014-2015; the rest have 09/04/2014
acquisition dates)

Search using just a date range (and no index) (AFTER patches are applied -
doesn't work as expected BEFORE the patches are applied):
- Added on or after date: 09/04/2014
  => should get 408 results
- Added on or before date: 09/03/2014
  => should get 3 results
- Added on or before date: today's date
  => should get 410 results
    (note: 408 + 3 doesn't equal 410 but it is correct, as one record has items
with different acquisition dates: The C programming language has items with
different acquisition dates - 1 x 09/04/2014 and 3 x 05/08/2014)
- Added on or after date: 09/05/2014
  => should get 56 results
- Added on or after date: 12/04/2014
  => should get 40 results
- Added on or after date: 09/05/2014
- Added on or before date: 12/03/2014
  => should get 16 records


Pagination of search results
~~~~~~~~~~~~~~~~~~~~~~~~~~~~

1. Perform a search that returns more than 20 results -  for example Title
index, a:

2. Navigate through different result page navigation using page numbers, the
"Next" button, and the "Previous" button
  => On each page, check that "Results X through X of X" displays the correct
information
     - 20 results are displayed for each page
     - the total number of results should not change

-- 
You are receiving this mail because:
You are watching all bug changes.