[Koha-bugs] [Bug 35570] Add a generic master form in ILL

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570

--- Comment #23 from David Nind <david at davidnind.com> ---
Testing notes (using KTD):

1. Apply the first three patches:
   - Bug 35570: Put 'FreeForm' backend into core as 'Standard'
   - Bug 35570: Consider 'Standard' core backend
   - Bug 35570: Atomicupdate

   Notes:
   - Apply all the dependent bugs
   - For 35570 (this bug) use i (for interactive) and add a # hash in front of
the patches not to apply at this time

2. Run the database update: updatedatabase
   => Output:

Upgrade to 23.12.00.003  [18:41:32]: Bug 35681 - Test DB Rev output
        Something in red is a warning
        Somthing in yellow is a call to action
        Something in blue is for information only
        You could use 'WHITE' too?
        Or leave color off and stick to default
DEV atomic update
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35570.pl  [18:41:32]:
Bug 35570 - Update 'FreeForm' ILL backend to 'Standard'
        Bug 35570: Finished database update.
DEV atomic update
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35681.pl  [18:41:32]:
Bug 35681 - Test Atomic update output
        Something in red is a warning
        Somthing in yellow is a call to action
        Something in blue is for information only
        You could use 'WHITE' too?
        Or leave color off and stick to default

3. Install the FreeForm backend. Run:
bash <(curl -s
https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)

4. Change the FreeForm branch to reorganize_ILL. From within the
Koha/Illbackends/FreeForm directory: git checkout reorganize_ILL

5. Run flush_memcached and restart_all (not sure whether these are required
here, but I ran them anyway).

6. Install the Pubmed plugin: 
   - Download from https://github.com/PTFS-Europe/koha-plugin-api-pubmed
   - Upload the plugin: Koha administration > Plugins > Manage plugins
   - Run restart_all

7. Create a new 'FreeForm' ILL batch:
   - + New ILL requests batch
   - Select the 'FreeForm' option
   - Batch details:
     . Batch name: BZ35570
     . Card number...: 42 (koha)
     . Library: Centerville
    - Select 'Continue'
    - Add '123' to the PubMed ID list of identifiers
    - Click 'Process identifiers'
    - Once processed, click 'Add items to batch'
    - Click 'Finish and view batch'
    => You now have 1 request, 1 batch and a few ILL request attributes in the
'FreeForm' backend

8. Run updatedatabase again, notice that there are now extra messages from the
previous database update - "Updated ILL batches from 'FreeForm' to
'Standard'...":

DEV atomic update
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35570.pl  [19:26:57]:
Bug 35570 - Update 'FreeForm' ILL backend to 'Standard'
        Bug 35570: Updated ILL batches from 'FreeForm' to 'Standard
        Bug 35570: Updated ILL request attributes from 'FreeForm' to 'Standard
        Bug 35570: Updated ILL requests from 'FreeForm' to 'Standard
        Bug 35570: Finished database update.
DEV atomic update
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35681.pl  [19:26:57]:
Bug 35681 - Test Atomic update output
        Something in red is a warning
        Somthing in yellow is a call to action
        Something in blue is for information only
        You could use 'WHITE' too?
        Or leave color off and stick to default

9. Create a saved SQL report with this SQL (note that if you run the report you
get no results): Select * from illrequests where backend="FreeForm"

10. Run the updatedatabase again. Note that there is a warning about the report
you created "Bug 35570: **ACTION REQUIRED**: Saved SQL reports containing
occurrences of 'FreeForm' were found.....":

DEV atomic update
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35570.pl  [19:30:47]:
Bug 35570 - Update 'FreeForm' ILL backend to 'Standard'
        Bug 35570: **ACTION REQUIRED**: Saved SQL reports containing
occurrences of 'FreeForm' were found.
        The following reports MUST be updated accordingly ('FreeForm' ->
'Standard'):
                Report ID: 1 | Edit link:
http://kohadev-intra.koha-testing:8081/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Edit%20SQL
DEV atomic update
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35681.pl  [19:30:47]:
Bug 35681 - Test Atomic update output
        Something in red is a warning
        Somthing in yellow is a call to action
        Something in blue is for information only
        You could use 'WHITE' too?
        Or leave color off and stick to default

11. Apply the remainder of the patches for this bug:
    - Say no for all the dependencies, as they are already installed
    - For 35570 (this bug) use i (for interactive) and add a # hash in front of
the first three patches
    - There is no need to run the databaseupdate again
    - Run flush_memcached and restart_all (not sure if this is required, but is
what I normally do after applying a patch)

12. Go to the ILL page: Administration > ILL requests

13. Notice that there is a configuration error preventing the use of the ILL
module. The message displayed is "ILL module configuration problem. Take a look
at the about page".

14. Click the 'about page' link and verify there is a warning about the
FreeForm backend:

     The ILL module is enabled, but the deprecated 'FreeForm' backend is
installed.
     'FreeForm' has since become part of core Koha as 'Standard'.
     All 'FreeForm' ILL content should've been migrated to 'Standard' upon
upgrading Koha to 24.05.
     To avoid confusion or redundancy, please uninstall the 'FreeForm' backend
before using the ILL module.

15. Remove the FreeForm backend from /kohadevbox/koha/Koha/Illbackends (sudo rm
-R /kohadevbox/koha/Koha/Illbackends/FreeForm) and refresh the page.

16. Repeat step 12. Note that:
    - The requests are listed as expected, and you can now use the ILL module
again.
    - For '+ New ILL requests batch', 'Standard' is now the only option shown.

-- 
You are receiving this mail because:
You are watching all bug changes.