[Koha-bugs] [Bug 35322] AllowItemsOnHoldCheckoutSCO and AllowItemsOnHoldCheckoutSIP do not work

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35322

Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #159510|0                           |1
        is obsolete|                            |

--- Comment #5 from Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> ---
Created attachment 160892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160892&action=edit
Bug 35322: Fix the logic for checking for holds in CanBookBeIssued

We are having reports that AllowItemsOnHoldCheckoutSCO and
AllowItemsOnHoldCheckoutSIP no longer work. It appreas that in CanBookBeIssued,
the ignore reserves check was changed from "check reserves unless the ignore
reserves flag was passed" to "check reserves unless the ignore reserves flag
was passed *and* we have a recall". I think this was a logic mistake and we
want to check reserves unless we have an ignore flag *or* there is a recall.

Test Plan:
1) Enable AllowItemsOnHoldCheckoutSCO
2) Place a hold on an item
3) Attempt to check that item out to another patron
4) Note the checkout is blocked
5) Apply this patch
6) Restart all the things!
7) Attempt the checkout again
8) The checkout now succeeds!

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov>

-- 
You are receiving this mail because:
You are watching all bug changes.