[Koha-bugs] [Bug 35360] Inconsistent use/look of 'Cancel hold(s)' button on circ/waitingreserves.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35360

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #160010|0                           |1
        is obsolete|                            |

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 161205
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161205&action=edit
Bug 35360: Make HTML/buttons consistent on waitingreserves.tt

To test:
0. Turn on hold cancellation requests in Administration -> Circulation rules.
1. Have some holds that are waiting, waiting over expiration date, and
cancelled waiting holds. In order to create holds waiting over expiration date,
if you are in ktd, you can use SQL to update the expirationdate in reserves:
UPDATE reserves SET expirationdate="2022-01-01" WHERE reserve_id=1; (make sure
it's the correct reserve_id!)
1a. If you are not using ktd, you will need to set ReservesMaxPickUpDelay to 0
days, then return the reserved item and then wait one day before it will be
marked as over expiration date.
1b. In order to create cancelled waiting holds, you will need to send a cancel
request over the OPAC, that is, reserve something after logging in to the OPAC,
return it in the staff interface, and then go to the OPAC -> Your Account ->
Holds -> click Cancel on the waiting hold.
2. Notice the differences between the 3 tables and their related buttons:
-Holds waiting
-Holds waiting past their expiration date
-Holds with cancellation requests

-Holds waiting includes a 'Canceled selected' button at the top of the table.
It is with in a #toolbar.

-Holds waiting past their expiration date includes a 'Cancel selected' and a
'Cancel all' button. None are within a #toolbar. The 'Cancel selected' here
lacks a Bootstrap .btn class. The 'Cancel all' button does have a .btn class.

-Holds with cancellation requests has neither a 'Cancel selected' or a 'Cancel
all' button.

3. APPLY PATCH
4. Look again and the tables/buttons should be more consistent.
5. The 'Holds with cancellation requests: X' tab should now include a 'Cancel
selected (X)' button. Make sure is works.
6. Make sure TransferWhenCancelAllWaitingHolds is set to "Don't transfer" and
make sure the hint displays well in the Holds over table.

Signed-off-by: Philip Orr <philip.orr at lmscloud.de>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.