[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
(In reply to Emily Lamancusa from comment #5)
> Hmmm...looking at the patch from 27992, all of the checking for holds,
> recalls, return claims, and lost or withdrawn statuses is based on the
> return values from AddReturn. So avoiding the call when the item isn't
> checked out would undo a lot of the functionality for 27992. (I did a quick
> test on master and confirmed this.) Wouldn't it be better to skip logging
> the local use in CanBookBeIssued if RecordLocalUseOnReturn is enabled
> (probably with a comment in the code that it is being skipped because
> AddReturn will log the local use in that case)?
> 
> Either way, this is also going to need a unit test. :)

Maybe this? If you like this better I'll write a unit test. Let me know.

-- 
You are receiving this mail because:
You are watching all bug changes.