[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972

--- Comment #6 from Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> ---
Thanks for testing, David!

It looks like returns.pl is using GetOtherReserves to initiate the item
transfer (i.e. add it to the branchtransfers table) - but not to put the hold
into the Transit status. In fact, GetOtherReserves doesn't even try to put the
hold into the Transit status.

returns.pl already imports ModItemTransfer...why not trigger the item transfer
directly when confirming the hold? (Notably, the current code calls
GetOtherReserves both before and after prompting the user to confirm the
transfer, so it's initiating a transfer before confirming whether it should!)

I still think the way to go is remove side effects from GetOtherReserves, and
have returns.pl initiate the transfer directly (at the correct time). I'll work
on a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.