[Koha-bugs] [Bug 35915] New: Add URL encoding to status tabs in purchase suggestions management

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35915

            Bug ID: 35915
           Summary: Add URL encoding to status tabs in purchase
                    suggestions management
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

If users add custom suggestion statuses in the SUGGEST_STATUS authorized values
and the value has spaces (or probably any other weird character), the tab in
the suggestions management page becomes unclickable/inaccessible.

To recreate:
1. Add a custom suggestion status with a space in the authorized value (e.g.
"En analyse")
   1.1. Go to Adminsitration > Authorized values > SUGGEST_STATUS
   1.2. Click Add new authorized value
   1.3. Fill out the form
        - Authorized value: term with a space (e.g. "En analyse")
        - Description: description (e.g. "En analyse")
   1.4. Click Save

2. Create two suggestions
   2.1. Go to Acquisitions > Suggestions
   2.2. Click New purchase suggestion
   2.3. Fill out the form (with whatever)
   2.4. Click Submit your suggestion
   2.5. Redo steps 2.2 to 2.4 for the second suggestion

3. Change the status of one of the suggestion to the custom status
   3.1. Check the box next to one of the suggestion
   3.2. At the bottom of the page, under Mark selected as, choose the custom
status
   3.3. Click Submit

4. Try to access the custom status tab
   --> Nothing happens

If you look at the URL it's trying to access it's "suggestion.pl#En
analyse_panel" with the space instead of %20. I don't know if that's the
blocking element, but it looks suspicious...

Now, I know some of you are going to say "Just don't put spaces in the
authorized value!" But even though I repeat it ALL the time and wrote it in RED
in our FAQ, users are gonna use... So either we make it impossible to enter
spaces in authorized values (I don't think that's a good idea, as some
categories might require spaces, such as categories to fill out marc fields),
or we make it so that Koha doesn't break if there is a space...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.