[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Confusing material.
Why did we add AddReturn to CanBookBeIssued in the first place? It feels not
good.
Consider this out of scope :)

Would be helpful to have the module changes in one patch and the test in
another. Now they are spread. Could be squashed?

Please add POD changes for the new parameter of AddReturn.

The name $localuse is not clear enough imo. You want to skip localuse, right?

The unit test is not completely clear too. The results of various searches on
item3 could overlap or so?
Could you make more explicit what really happens for both patrons?

Needs a bit of attention still. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.