[Koha-bugs] [Bug 35685] ILL - OPAC request creation error if submitted empty while ILLModuleDisclaimerByType is in use

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35685

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #8 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
(In reply to Marcel de Rooy from comment #6)
>                 print
> $query->redirect('/cgi-bin/koha/opac-illrequests.pl?message=2');
> 
>                 # After creation actions
>                 if ( $params->{type_disclaimer_submitted} ) {
>                     $type_disclaimer->after_request_created( $params,
> $request );
>                     print
> $query->redirect('/cgi-bin/koha/opac-illrequests.pl?message=2');
> 
> 
> Possibly, two redirects in a row ?

Thank you Marcel, certainly not great code! Thanks for pointing it out. I've
amended the original patch and updated the test plan to reinforce that there
are no regressions in how the data is saved.

-- 
You are receiving this mail because:
You are watching all bug changes.