[Koha-bugs] [Bug 35797] REST API: Add GET route for patronimage

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35797

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #6 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
All remarks have been (hopefully well) implemented.

I am not sure about a patron having multiple images since I currently cannot
see any practical reason for such a thing, but I renamed the route just in case
since it's trivial to do.

One thing I thought I should comment on is that currently all images uploaded
as patron image seem to be converted to png. So I hardcoded the return format
for simplicity. Else (if say we preserve the image format), I think we would
need some sort of mapping of koha db patronimage mimetype to mojolicious
accepted format option
(https://docs.mojolicious.org/Mojolicious/Types#DESCRIPTION)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.