[Koha-bugs] [Bug 33646] "Cataloging search" missing important data for not for loan items

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33646

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There are issues with this patch:

- With this patch applied we always have the "Available" sub-heading, even on
records with no items. 
- When one item is "damaged" it will now show, but the "nor for loan"
sub-heading will still show. And it's falsely formatted in italic. Possibly
inherited?

You check for the loop size, but then only items with notforloan are displayed
- I haven't tested/checked what other items might be in the loop, but damaged
seems to be:

+                                                [% IF (
resultsloo.other_items_loop.size ) %]
+                                                    <div
class="results_unavailable">Not for loan:</div>
                                                     [% FOREACH items_loo IN
resultsloo.other_items_loop %]
-                                                        [% IF (
items_loo.notforloan ) %][% items_loo.notforloan | html %] ([% items_loo.count
| html %])<br />[% END %]
+                                                        [% IF (
items_loo.notforloan ) %]


Please fix!

-- 
You are receiving this mail because:
You are watching all bug changes.