From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 00:09:49 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Feb 2024 23:09:49 +0000
Subject: [Koha-bugs] [Bug 36206] Administrative plugins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36206
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lucas at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 00:20:17 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Feb 2024 23:20:17 +0000
Subject: [Koha-bugs] [Bug 35169] Make long overdue borrower category options
configurable in interface
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #7 from Lucas Gass ---
Matthias,
I tested this and it seems to work as intended, you sysprefs.sql update looks
good to me.
However, your DBUpdate explanation and type should not be NULL. Sorry to be a
pain!
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 00:28:12 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Feb 2024 23:28:12 +0000
Subject: [Koha-bugs] [Bug 23641] Checkout via camera on device
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23641
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lucas at bywatersolutions.com
--- Comment #18 from Lucas Gass ---
Very cool, David. Do you we need to add license information to the about page
ZXing library?
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 00:36:49 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Feb 2024 23:36:49 +0000
Subject: [Koha-bugs] [Bug 34755] Error authenticating to external OpenID
Connect (OIDC) identity provider : wrong_csrf_token
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #15 from David Cook ---
Once again, I cannot reproduce this problem.
After authenticating in Keycloak, I'm redirected to the Koha endpoint at
http://localhost:8080/api/v1/public/oauth/login/Keycloak/opac which is a GET
request.
My request cookie has a CGISESSID value of 8435418b15fc0280af09f72a5f6c31cd.
This is an anonymous session.
My response cookie has a CGISESSID value of 1a11450a805d152b0dfcfcc91da3c341.
This is an authenticated session.
http://localhost:8080/api/v1/public/oauth/login/Keycloak/opac redirects as a
GET request to opac-user.pl.
Anti-CSRF shouldn't be involved here...
--
I'm looking at Koha/REST/V1/OAuth/Client.pm and it looks OK to me. Personally,
I would use a random value for a "state" parameter and save it to the session.
Using a CSRF token in this case is problematic for a number of reasons I won't
get into here.
But the thing is... if you're getting wrong_csrf_token here it's because you've
lost your session (well more specifically your userenv since master doesn't yet
have the CSRF session fix Jonathan mentions above) between the time the "state"
parameter was generated and the time the "state" parameter was checked.
That means the test plan given in Comment 2 can't possibly work.
Which takes me to Comment 10... there was something about navigating around
Koha before posting the SSO login form.
Now I have no idea why a person would do that, because it makes no sense at
all. If you're clicking "Log in with Keycloak", then I'd just complete the
login. But anyway...
Recently I did notice that there is somewhere in Koha.. I think on the OPAC..
where the cookie isn't returned when it should be and that did cause me some
grief.
Let me try...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 00:41:25 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Feb 2024 23:41:25 +0000
Subject: [Koha-bugs] [Bug 34755] Error authenticating to external OpenID
Connect (OIDC) identity provider : wrong_csrf_token
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #16 from David Cook ---
I was trying my best to break my sessions, and I did manage to reproduce the
problem, but I can't recall exactly how.
So I'm going to keep trying again (more carefully).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 00:47:10 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Feb 2024 23:47:10 +0000
Subject: [Koha-bugs] [Bug 34755] Error authenticating to external OpenID
Connect (OIDC) identity provider : wrong_csrf_token
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #17 from David Cook ---
(In reply to David Cook from comment #16)
> I was trying my best to break my sessions, and I did manage to reproduce the
> problem, but I can't recall exactly how.
>
> So I'm going to keep trying again (more carefully).
Ok so one way to do it would be to do the following:
1. Go to http://localhost:8080
2. Click "Log in with Keycloak" but don't log in
3. In a new tab, go to http://localhost:8080, and do a local login
4. Log out of the local login
5. Go back to original tab and complete the Keycloak login
You'll get a wrong_csrf_token because the CGISESSID cookie value has changed.
An anonymous user becoming an authenticated user will keep the same session ID,
but an authenticated user becoming an anonymous user will lose their session
ID.
You should be getting the wrong_csrf_token warning in this case.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 00:51:16 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Feb 2024 23:51:16 +0000
Subject: [Koha-bugs] [Bug 34755] Error authenticating to external OpenID
Connect (OIDC) identity provider : wrong_csrf_token
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #18 from David Cook ---
Comment on attachment 161783
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161783
Bug 34755: Unit tests
Review of attachment 161783:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=34755&attachment=161783)
-----------------------------------------------------------------
::: t/db_dependent/api/v1/idp.t
@@ +309,5 @@
> + $tx->req->cookies( { name => 'CGISESSID', value => $session_id } );
> + $t->request_ok($tx);
> +
> + my $error = URI->new($t->tx->res->headers->location)->query_param("auth_error");
> + isnt($error, "wrong_csrf_token", "CRSF token is recognized even when another user is logged in.");
Ok this is interesting. Why would another user be logged in?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 00:57:33 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Feb 2024 23:57:33 +0000
Subject: [Koha-bugs] [Bug 34755] Error authenticating to external OpenID
Connect (OIDC) identity provider : wrong_csrf_token
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #19 from David Cook ---
(In reply to David Cook from comment #18)
> Ok this is interesting. Why would another user be logged in?
Ahhhhh I know what the problem is now.
So I'm going to keep this as Failed QA because the attached patch is not the
solution. As I mentioned on Comment 11, you've actually bumped into a different
bug which isn't directly related to the OpenID Connect Authentication.
It is due to a problem with C4::Context->userenv, but I won't get into the
reasons why.
Leave it to me and Jonathan. We'll take care of it.
Thanks for your patience on this one.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 00:58:04 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 29 Feb 2024 23:58:04 +0000
Subject: [Koha-bugs] [Bug 34755] Error authenticating to external OpenID
Connect (OIDC) identity provider : wrong_csrf_token
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=36149
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 01:00:58 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 00:00:58 +0000
Subject: [Koha-bugs] [Bug 34755] Error authenticating to external OpenID
Connect (OIDC) identity provider : wrong_csrf_token
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |36098
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36098
[Bug 36098] Create Koha::Session module
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 01:00:58 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 00:00:58 +0000
Subject: [Koha-bugs] [Bug 36098] Create Koha::Session module
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36098
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |34755
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
[Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity
provider : wrong_csrf_token
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 01:02:17 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 00:02:17 +0000
Subject: [Koha-bugs] [Bug 34755] Error authenticating to external OpenID
Connect (OIDC) identity provider : wrong_csrf_token
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #20 from David Cook ---
(In reply to Jonathan Druart from comment #13)
> David, isn't the same problem we encountered on 34478? Should not we
> backport "Make Koha::Token use session id not userenv id"?
Yep, 100%. We need to backport it.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 01:07:55 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 00:07:55 +0000
Subject: [Koha-bugs] [Bug 23641] Checkout via camera on device
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23641
--- Comment #19 from David Cook ---
(In reply to Lucas Gass from comment #18)
> Very cool, David. Do you we need to add license information to the about
> page ZXing library?
For some reason I thought people meant David Nind. Glad I decided to
double-check the bug.
Yeah, we'd better do that. This looks like the one:
https://github.com/zxing-js/browser/blob/master/LICENSE
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 01:09:59 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 00:09:59 +0000
Subject: [Koha-bugs] [Bug 23641] Checkout via camera on device
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23641
--- Comment #20 from David Cook ---
As I mentioned before, we had a library try it and it didn't work well enough
for them.
We did another version using a commercial vendor (Scandit) which worked much
better, although that has on-going costs associated with it.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 01:12:49 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 00:12:49 +0000
Subject: [Koha-bugs] [Bug 36206] Administrative plugins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36206
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 01:45:04 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 00:45:04 +0000
Subject: [Koha-bugs] [Bug 36208] New: Add -not_itemtype argument to
misc/export_records.pl
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36208
Bug ID: 36208
Summary: Add -not_itemtype argument to misc/export_records.pl
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Cataloging
Assignee: koha-bugs at lists.koha-community.org
Reporter: alexbuckley at catalyst.net.nz
QA Contact: testopia at bugs.koha-community.org
CC: m.de.rooy at rijksmuseum.nl
It is currently possible to pass the --itemtype argument to
misc/export_records.pl to export biblios from a given itemtype.
It would be nice if libraries pass a --not_itemtype argument to
misc/export_records.pl to exclude exporting biblios with a given item type.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 01:46:18 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 00:46:18 +0000
Subject: [Koha-bugs] [Bug 36208] Add -not_itemtype argument to
misc/export_records.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36208
Alex Buckley changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|koha-bugs at lists.koha-commun |alexbuckley at catalyst.net.nz
|ity.org |
Change sponsored?|--- |Sponsored
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 01:52:02 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 00:52:02 +0000
Subject: [Koha-bugs] [Bug 36208] Add -not_itemtype argument to
misc/export_records.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36208
--- Comment #1 from Alex Buckley ---
Created attachment 162629
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162629&action=edit
Bug 36208: Add --not_itemtype argument to misc/export_records.pl
WIP
Sponsored-By: The Treasury, New Zealand
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 01:52:32 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 00:52:32 +0000
Subject: [Koha-bugs] [Bug 36208] Add -not_itemtype argument to
misc/export_records.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36208
--- Comment #2 from Alex Buckley ---
Test plan and refinements to come.
Not ready for testing yet.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 02:29:36 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 01:29:36 +0000
Subject: [Koha-bugs] [Bug 36209] New: Recalls: Do not force a change to the
due date when an item is recalled
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36209
Bug ID: 36209
Summary: Recalls: Do not force a change to the due date when an
item is recalled
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs at lists.koha-community.org
Reporter: aleisha at catalyst.net.nz
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
When an item is recalled, Koha looks to the relevant due date interval
circulation rule to adjust the checkout's due date.
If the circulation rule for recall due date interval is not defined (empty),
Koha defaults to 5 days.
We should remove this default so that if the circulation rule for recall due
date interval is left empty, then the checkout due date is not adjusted.
This has been prompted by a library who uses recalls in a way that the due date
is not adjusted, but the patron is charged a specific recall fine if they are
late to return it.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 02:29:45 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 01:29:45 +0000
Subject: [Koha-bugs] [Bug 36209] Recalls: Do not force a change to the due
date when an item is recalled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36209
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |19532
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
[Bug 19532] Recalls for Koha
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 02:29:45 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 01:29:45 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |36209
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36209
[Bug 36209] Recalls: Do not force a change to the due date when an item is
recalled
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 02:53:23 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 01:53:23 +0000
Subject: [Koha-bugs] [Bug 36210] New: Add Recalls preferences to Hea usage
statistics
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36210
Bug ID: 36210
Summary: Add Recalls preferences to Hea usage statistics
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs at lists.koha-community.org
Reporter: aleisha at catalyst.net.nz
QA Contact: testopia at bugs.koha-community.org
Preferences shared with Hea are listed at C4/UsageStats.pm
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 02:53:29 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 01:53:29 +0000
Subject: [Koha-bugs] [Bug 36210] Add Recalls preferences to Hea usage
statistics
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36210
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |19532
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
[Bug 19532] Recalls for Koha
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 02:53:29 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 01:53:29 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |36210
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36210
[Bug 36210] Add Recalls preferences to Hea usage statistics
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 08:57:02 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 07:57:02 +0000
Subject: [Koha-bugs] [Bug 35718] Remove ES6 warnings from JavaScript system
preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35718
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #160613|0 |1
is obsolete| |
--- Comment #6 from Julian Maurice ---
Created attachment 162631
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162631&action=edit
Bug 35718: Remove ES6 warns from JS system preferences
To test:
1. Add some JS like this to any of the UserJS system preferences:
$(document).ready( function() {
let something = 1;
const another_thing = 2;
let an_arrow_function = (a, b) => a + b;
console.log( an_arrow_function(something, another_thing) );
});
2. Notice the icons and warnings to the left of the line numbers:
let is available in ES6
const is available in ES6
arrow_function_syntax is available in ES6
3. APPLY PATCH
4. Try steps 1 and 2 again, the warnings should be gone.
5. Check that the JavaScript still works, in my example it should console.log
3.
Signed-off-by: David Nind
Signed-off-by: Julian Maurice
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 08:57:05 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 07:57:05 +0000
Subject: [Koha-bugs] [Bug 35718] Remove ES6 warnings from JavaScript system
preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35718
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #162623|0 |1
is obsolete| |
--- Comment #7 from Julian Maurice ---
Created attachment 162632
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162632&action=edit
Bug 35718: Remove ES6 warnings branches.tt
Signed-off-by: Julian Maurice
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 08:57:42 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 07:57:42 +0000
Subject: [Koha-bugs] [Bug 35718] Remove ES6 warnings from JavaScript system
preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35718
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--- Comment #8 from Julian Maurice ---
Thanks for the follow-up.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 08:59:48 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 07:59:48 +0000
Subject: [Koha-bugs] [Bug 36100] Regression in bookings edit
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36100
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #162229|0 |1
is obsolete| |
--- Comment #10 from Marcel de Rooy ---
Created attachment 162633
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162633&action=edit
Bug 36100: Remove readOnly from bookings definition.
Whilst readOnly feels correct here, swagger doesn't work that way at our
version. It must be removed to restore the ability to edit exising
bookings.
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 08:59:50 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 07:59:50 +0000
Subject: [Koha-bugs] [Bug 36100] Regression in bookings edit
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36100
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #162230|0 |1
is obsolete| |
--- Comment #11 from Marcel de Rooy ---
Created attachment 162634
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162634&action=edit
Bug 36100: Update unit tests for add
This patch updates the unit tests for booking add to confirm that
without readOnly we still return an error should a user attempt to
submit a booking with a booking_id that would clash.
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 08:59:53 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 07:59:53 +0000
Subject: [Koha-bugs] [Bug 36100] Regression in bookings edit
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36100
--- Comment #12 from Marcel de Rooy ---
Created attachment 162635
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162635&action=edit
Bug 36100: (QA follow-up) Move 400 to 409
Duplicate exceptions tend to generate a 409 in our REST API.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:00:17 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 08:00:17 +0000
Subject: [Koha-bugs] [Bug 36100] Regression in bookings edit
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36100
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
|y.org |
Status|Signed Off |Passed QA
CC| |m.de.rooy at rijksmuseum.nl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:00:52 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 08:00:52 +0000
Subject: [Koha-bugs] [Bug 36100] Regression in bookings edit
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36100
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #162633|0 |1
is obsolete| |
--- Comment #13 from Marcel de Rooy ---
Created attachment 162636
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162636&action=edit
Bug 36100: Remove readOnly from bookings definition.
Whilst readOnly feels correct here, swagger doesn't work that way at our
version. It must be removed to restore the ability to edit exising
bookings.
Signed-off-by: David Nind
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:00:54 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 08:00:54 +0000
Subject: [Koha-bugs] [Bug 36100] Regression in bookings edit
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36100
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #162634|0 |1
is obsolete| |
--- Comment #14 from Marcel de Rooy ---
Created attachment 162637
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162637&action=edit
Bug 36100: Update unit tests for add
This patch updates the unit tests for booking add to confirm that
without readOnly we still return an error should a user attempt to
submit a booking with a booking_id that would clash.
Signed-off-by: David Nind
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:00:56 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 08:00:56 +0000
Subject: [Koha-bugs] [Bug 36100] Regression in bookings edit
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36100
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #162635|0 |1
is obsolete| |
--- Comment #15 from Marcel de Rooy ---
Created attachment 162638
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162638&action=edit
Bug 36100: (QA follow-up) Move 400 to 409
Duplicate exceptions tend to generate a 409 in our REST API.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:04:38 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 08:04:38 +0000
Subject: [Koha-bugs] [Bug 36206] Administrative plugins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36206
--- Comment #3 from Martin Renvoize ---
Created attachment 162639
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162639&action=edit
Bug 36206: Expose administration page to users with plugins_admin permission
This patch updates the intranet home page logic such that the
administration button appears for those users with just the 'admin'
subpermission of plugins to allow them to access such plugins.
We also update the display logic found inside the admin-home page so
that user see plugin management appropriately.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:09:13 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 08:09:13 +0000
Subject: [Koha-bugs] [Bug 36206] Administrative plugins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36206
--- Comment #4 from Martin Renvoize ---
Created attachment 162640
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162640&action=edit
Bug 36206: Add 'Run administration tool' to plugin actions
This patch adds the new 'Run administration tool' option to the plugin
actions dropdown menu for plugins with such a function.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:10:24 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 08:10:24 +0000
Subject: [Koha-bugs] [Bug 36206] Administrative plugins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36206
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #162640|0 |1
is obsolete| |
--- Comment #5 from Martin Renvoize ---
Created attachment 162641
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162641&action=edit
Bug 36206: Add 'Run administration tool' to plugin actions
This patch adds the new 'Run administration tool' option to the plugin
actions dropdown menu for plugins with such a function.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:13:32 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 08:13:32 +0000
Subject: [Koha-bugs] [Bug 36175] Checking out items that are booked doesn't
quite work
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36175
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:13:34 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 08:13:34 +0000
Subject: [Koha-bugs] [Bug 36175] Checking out items that are booked doesn't
quite work
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36175
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #162598|0 |1
is obsolete| |
--- Comment #3 from Marcel de Rooy ---
Created attachment 162642
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162642&action=edit
Bug 36175: Corrections to reduced due for booked items
This patch fixes a mistake in the circulation controller such that the
proper reduceddue date is passed to the template when a checkout would
overlap with a booking.
I also take the oportunity to enhance the functionality to allow
librarians to set their own reduceddue date between now and the hard
reduceddue as required for the existing booking.
Test plan
1) Set an item to 'bookable'
2) Add a booking to that item for user A for a few days time.
3) Attempt to checkout the item to user B and note the warning that
the item is booked for another user.
4) With the patch applied, a reduced due date of 1 day prior to the
booking should be defaulted to in the displayed date picker.
5) You should be able to select any date between today and the day
before the booking starts
6) Confirm you can checkout with the reduceddue date set.
7) Bonus point, confirm the field is required, so if you try to wipe it
and then checkout, you will be blocked.
Signed-off-by: Kelly
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:13:51 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 08:13:51 +0000
Subject: [Koha-bugs] [Bug 36175] Checking out items that are booked doesn't
quite work
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36175
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
|y.org |
Version|23.11 |master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:14:11 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 08:14:11 +0000
Subject: [Koha-bugs] [Bug 36098] Create Koha::Session module
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36098
--- Comment #16 from Jonathan Druart ---
(In reply to David Cook from comment #15)
> Comment on attachment 162314 [details] [review]
> Bug 36098: Default to 'file' if pref does not exist
>
> Review of attachment 162314 [details] [review]:
> -----------------------------------------------------------------
>
> ::: Koha/Session.pm
> @@ +53,4 @@
> > sub _get_session_params {
> > my ( $class, $args ) = @_;
> > my $storage_method = $args->{storage_method};
> > + $storage_method ||= C4::Context->preference('SessionStorage') || 'file';
>
> This isn't very human-friendly to read.
Really? This is trivial Perl...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:16:30 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 08:16:30 +0000
Subject: [Koha-bugs] [Bug 36192] [OMNIBUS] CSRF Protection for Koha
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=36149
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:22:49 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 08:22:49 +0000
Subject: [Koha-bugs] [Bug 35892] Fallback to GetMarcPrice in addorderiso2907
no longer works
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35892
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:22:51 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 08:22:51 +0000
Subject: [Koha-bugs] [Bug 35892] Fallback to GetMarcPrice in addorderiso2907
no longer works
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35892
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #161468|0 |1
is obsolete| |
--- Comment #6 from Marcel de Rooy ---
Created attachment 162643
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162643&action=edit
Bug 35892: Populate order price using GetMarcPrice if no price specified
Previously this happened after the fact, automagically, if no price was
included in the order record. We should
rather load the Marc price into the order form if we don't have a price form
the '...ToOrder' system preferences
To test:
Setup -- Set systempreferences below
MarcFieldsToOrder:
price: 949$g
quantity: 949$k
budget_code: 949$l
discount: 949$m
sort1: 949$n
sort2: 949$q
MarcItemFieldsToOrder:
homebranch: 949$a
holdingbranch: 949$b
itype: 949$y
nonpublic_note: 949$x
public_note: 949$z
loc: 949$c
ccode: 949$8
notforloan: 949$7
uri: 949$u
copyno: 949$t
replacementprice: 949$v
itemcallnumber: 949$o
quantity: 949$k
budget_code: 949$l
Stage the attached bib-303.marcxml file
Add to basket from the staged file
Note that item prices are populated as '6.50' from 949$g
Cancel
Update MarcFieldsToOrder and map price to "020$c"
Add to basket from the staged file
Note the price is not populated, because 020$c contains a dollar sign
Cancel
Apply patch, restart all
Add to basket from the staged file
Note the price is now correctly populated from fallback to GetMarcPrice
Note: GetMarcPrice does some automatic munging, that's why 020$c on it's own
doesn't work - this could be done to fields in
MarcFieldsToOrder/MarcItemFieldsToOrder but this would be an enhancement.
This bug simply restores the previous behavious, but does it on the front end
and is more obvious to the user
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:23:04 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 08:23:04 +0000
Subject: [Koha-bugs] [Bug 35892] Fallback to GetMarcPrice in addorderiso2907
no longer works
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35892
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:26:22 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 08:26:22 +0000
Subject: [Koha-bugs] [Bug 35473] Core bookings and room reservations plugin
tables clash
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35473
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
--- Comment #14 from Marcel de Rooy ---
(In reply to Martin Renvoize from comment #13)
> This is a pretty darn critical bug for upgrades that can completely break
> Koha.. amazing it doesn't get any attention
Will have a look now. But you know about 34478 ;)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:26:36 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 08:26:36 +0000
Subject: [Koha-bugs] [Bug 35473] Core bookings and room reservations plugin
tables clash
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35473
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:41:19 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 08:41:19 +0000
Subject: [Koha-bugs] [Bug 35473] Core bookings and room reservations plugin
tables clash
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35473
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |In Discussion
--- Comment #15 from Marcel de Rooy ---
This is an interesting patch. I tend to think that we should not touch the
tables of a plugin. And just abort here? But that may be a bit too formal
response?
I like to have bit more feedback from QA. Moving to ID and sending a mail.
Do we choose for Pragmatic here and just move the tables, or do we choose to
just bail out and let the plugin stuff be handled outside Koha?
Note that the question also arises: What should we do for other plugins in the
future that created tables in Koha and clash? I would normally not expect Koha
to contain knowledge about plugin tables?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:47:10 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 08:47:10 +0000
Subject: [Koha-bugs] [Bug 35944] Bookings is not taken into account in
CanBookBeRenewed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
--- Comment #10 from Marcel de Rooy ---
There is a whole dependency tree still in PQA for this one. Skipping for now.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:52:54 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 08:52:54 +0000
Subject: [Koha-bugs] [Bug 35469] Cannot create bookings without circulation
permissions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35469
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:52:57 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 08:52:57 +0000
Subject: [Koha-bugs] [Bug 35469] Cannot create bookings without circulation
permissions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35469
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #161641|0 |1
is obsolete| |
--- Comment #28 from Marcel de Rooy ---
Created attachment 162644
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162644&action=edit
Bug 35469: Add 'manage_bookings' subpermission to /checkouts
This patch adds the 'manage_bookings' permission to allow fetching of
checkouts on the API should the user have 'manage_bookings' but not have
'circulate_remaining_permissions'
Signed-off-by: Nick Clemens
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:52:59 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 08:52:59 +0000
Subject: [Koha-bugs] [Bug 35469] Cannot create bookings without circulation
permissions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35469
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #161642|0 |1
is obsolete| |
--- Comment #29 from Marcel de Rooy ---
Created attachment 162645
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162645&action=edit
Bug 35469: Add 'manage_bookings' permission to biblios/checkouts
This patch adds the manage_bookings subpermission check to the
biblios/{biblio_id}/checkouts endpoint and updates the corresponding
unit test too.
Signed-off-by: Nick Clemens
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:00:43 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 09:00:43 +0000
Subject: [Koha-bugs] [Bug 31427] Automatic renewal errors should come before
many other renewal errors
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427
--- Comment #31 from Marcel de Rooy ---
Still having trouble with tests:
Running tests (1)
* Proving /usr/share/koha/t/db_dependent/Circulation.t KO!
DBIx::Class::Storage::DBI::select_single(): Query returned more than one row.
SQL that returns multiple rows is DEPRECATED for ->find and ->single at
/usr/share/koha/Koha/Objects.pm line 96
DBIx::Class::Storage::DBI::select_single(): Query returned more than one row.
SQL that returns multiple rows is DEPRECATED for ->find and ->single at
/usr/share/koha/Koha/Objects.pm line 96
DBIx::Class::Storage::DBI::select_single(): Query returned more than one row.
SQL that returns multiple rows is DEPRECATED for ->find and ->single at
/usr/share/koha/Koha/Objects.pm line 96
DBIx::Class::Storage::DBI::select_single(): Query returned more than one row.
SQL that returns multiple rows is DEPRECATED for ->find and ->single at
/usr/share/koha/Koha/Objects.pm line 96
# Looks like you planned 9 tests but ran 3.
# Failed test 'transferbook tests'
# at /usr/share/koha/t/db_dependent/Circulation.t line 5754.
Exception 'Koha::Exceptions::MissingParameter' thrown 'The to parameter is
mandatory'
# Looks like your test exited with 11 just after 57.
/usr/share/koha/t/db_dependent/Circulation.t ..
Dubious, test returned 11 (wstat 2816, 0xb00)
Failed 12/68 subtests
Test Summary Report
-------------------
/usr/share/koha/t/db_dependent/Circulation.t (Wstat: 2816 Tests: 57 Failed: 1)
Failed test: 57
Non-zero exit status: 11
Parse errors: Bad plan. You planned 68 tests but ran 57.
Files=1, Tests=57, 41 wallclock secs ( 0.11 usr 0.01 sys + 32.32 cusr 4.83
csys = 37.27 CPU)
Result: FAIL
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:02:52 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 09:02:52 +0000
Subject: [Koha-bugs] [Bug 35473] Core bookings and room reservations plugin
tables clash
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35473
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |julian.maurice at biblibre.com
--- Comment #16 from Julian Maurice ---
(In reply to Marcel de Rooy from comment #15)
> Note that the question also arises: What should we do for other plugins in
> the future that created tables in Koha and clash? I would normally not
> expect Koha to contain knowledge about plugin tables?
I think we should try to avoid using table names that are already used by known
plugins, but if that happens (like in this bug) I think it's the plugin
responsibility to move its own data.
Now what should Koha do ? Stop the update process, and if the plugin is known
add a message suggesting to update the plugin first ? Can the plugin update be
done in the middle of the updatedb process ?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:08:54 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 09:08:54 +0000
Subject: [Koha-bugs] [Bug 35473] Core bookings and room reservations plugin
tables clash
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35473
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at gmail.com
--- Comment #17 from Jonathan Druart ---
On bug 30650 (Curbside pickups) I took care of the plugin's data (the idea was
to provide the same feature as the plugin).
The patch created the same tables as the plugin, then adjusted the structure to
reach the new one.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:25:00 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 09:25:00 +0000
Subject: [Koha-bugs] [Bug 36211] New: Add support for script modules to Asset
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36211
Bug ID: 36211
Summary: Add support for script modules to Asset
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Templates
Assignee: oleonard at myacpl.org
Reporter: jonathan.druart at gmail.com
QA Contact: testopia at bugs.koha-community.org
Depends on: 36084
Bug 36084: svc - authorised_values - APIClient now global
+
We should use Asset.js here.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:37:29 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 09:37:29 +0000
Subject: [Koha-bugs] [Bug 36212] New: transferbook should not look for items
without barcode
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36212
Bug ID: 36212
Summary: transferbook should not look for items without barcode
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: trivial
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs at lists.koha-community.org
Reporter: m.de.rooy at rijksmuseum.nl
QA Contact: testopia at bugs.koha-community.org
Circulation.t fails if you have items without barcode on transferbook tests.
See also bug 31427.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:41:47 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 09:41:47 +0000
Subject: [Koha-bugs] [Bug 36212] transferbook should not look for items
without barcode
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36212
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:41:49 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 09:41:49 +0000
Subject: [Koha-bugs] [Bug 36212] transferbook should not look for items
without barcode
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36212
--- Comment #1 from Marcel de Rooy ---
Created attachment 162646
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162646&action=edit
Bug 36212: Add check on barcode before searching items
Test plan:
Add an item to your database that has no barcode.
Run t/db_dependent/Circulation.t
It will fail without this patch, pass with this patch.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:42:05 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 09:42:05 +0000
Subject: [Koha-bugs] [Bug 36212] transferbook should not look for items
without barcode
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36212
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
|ity.org |
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:42:53 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 09:42:53 +0000
Subject: [Koha-bugs] [Bug 36212] transferbook should not look for items
without barcode
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36212
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--- Comment #2 from Marcel de Rooy ---
Trivial. This is kind of QA follow-up for getting 31427 further.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:43:15 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 09:43:15 +0000
Subject: [Koha-bugs] [Bug 36212] transferbook should not look for items
without barcode
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36212
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=31427
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:43:15 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 09:43:15 +0000
Subject: [Koha-bugs] [Bug 31427] Automatic renewal errors should come before
many other renewal errors
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=36212
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:43:59 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 09:43:59 +0000
Subject: [Koha-bugs] [Bug 31427] Automatic renewal errors should come before
many other renewal errors
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427
--- Comment #32 from Marcel de Rooy ---
Needs a little digging. Test fails without this patch too.
And culprit is transferbook:
my $item = Koha::Items->find( { barcode => $barcode } );
If barcode is empty and you have items without barcode, things go wrong.
Solved it on bug 36212. Chose to not record as dependency.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:59:38 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 09:59:38 +0000
Subject: [Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object
methods
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026
Matt Blenkinsop changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:59:41 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 09:59:41 +0000
Subject: [Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object
methods
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026
Matt Blenkinsop changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #159969|0 |1
is obsolete| |
--- Comment #26 from Matt Blenkinsop ---
Created attachment 162647
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162647&action=edit
Bug 35026: Add a MarcOrder object class
This patch adds a MarcOrder object class. This will primarily be used for the
functionality in bug 34355 to automate order creation from a Marc file. The
automation functionality is similar in principle to the functionality in the
addorderis02709.pl script so it makes sense to refactor this script to use the
same code.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:59:44 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 09:59:44 +0000
Subject: [Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object
methods
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026
Matt Blenkinsop changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #160833|0 |1
is obsolete| |
--- Comment #27 from Matt Blenkinsop ---
Created attachment 162648
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162648&action=edit
Bug 35026: Refactor addorderiso2709.pl to use the MarcOrder class
This script uses the newly created MarcOrder class to refactor the script into
a cleaner controller function. This MarcOrder class will also be used in bug
34355 to automate the creation of order lines from marc records.
Test plan:
1) In system preferences, click Search and then select the Acquisitions option
from the left hand menu
2) Paste the following into MarcFieldsToOrder
price: 975$p
quantity: 975$q
budget_code: 975$h
3) Paste the following into MarcItemFieldsToOrder
homebranch: 949$a
holdingbranch: 949$b
itype: 949$y
nonpublic_note: 949$x
public_note: 949$z
loc: 949$c
ccode: 949$8
notforloan: 949$7
uri: 949$u
copyno: 949$t
price: 949$g
replacementprice: 949$v
itemcallnumber: 949$o
quantity: 949$k
budget_code: 949$l
Now save the sysprefs
4) Navigate to acquisitions and go into a basket
5) Click Add to basket and select “From a new file”
6) Download the file attached to this bug
7) Import the file and when the job is complete click “Add staged files to
basket”
8) Click the checkbox next to the record to display the items and confirm that
the data matches the mappings from the file that you imported - there should be
8 items, grouped in 4 pairs of identical items
9) Fill in the required fields and click “Save”
10) That basket should be correctly populated with an order matching the file
that you imported
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:59:46 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 09:59:46 +0000
Subject: [Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object
methods
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026
Matt Blenkinsop changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #160834|0 |1
is obsolete| |
--- Comment #28 from Matt Blenkinsop ---
Created attachment 162649
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162649&action=edit
Bug 35026: Tidy file
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:59:49 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 09:59:49 +0000
Subject: [Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object
methods
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026
Matt Blenkinsop changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #160835|0 |1
is obsolete| |
--- Comment #29 from Matt Blenkinsop ---
Created attachment 162650
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162650&action=edit
Bug 35026: Make add_items_from_import_record DRY
This patch improves the code in add_items_from_import_record to make sure that
the code is not repeating itself
It also fixes a minor error in the template file and rebases in changes from
bugs 35254 and 33170
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:59:51 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 09:59:51 +0000
Subject: [Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object
methods
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026
Matt Blenkinsop changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #160836|0 |1
is obsolete| |
--- Comment #30 from Matt Blenkinsop ---
Created attachment 162651
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162651&action=edit
Bug 35026: Add unit tests
This commit adds a set of unit tests for the new methods in Koha::MarcOrder
The two controller functions at the start of the file have not been included as
they simply call the functions in these tests
The _stage_file method is also not included as this is a copy of the existing
file staging code with the background job functionality removed
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:59:54 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 09:59:54 +0000
Subject: [Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object
methods
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026
Matt Blenkinsop changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #160837|0 |1
is obsolete| |
--- Comment #31 from Matt Blenkinsop ---
Created attachment 162652
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162652&action=edit
Bug 35026: Allow multiple records from one marc file
This patch addresses a bug where only one record would be read from a marc file
and other records would be lost. All records are now read from the file and
displayed in the UI.
Test plan as above
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:59:57 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 09:59:57 +0000
Subject: [Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object
methods
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026
--- Comment #32 from Matt Blenkinsop ---
Created attachment 162653
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162653&action=edit
Bug 35026: Adjust price field to match UI
Following bug 36036 the price field has been renamed in the UI- this patch
removes the logic that was renaming that field in the backend to match this
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:59:59 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 09:59:59 +0000
Subject: [Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object
methods
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026
--- Comment #33 from Matt Blenkinsop ---
Created attachment 162654
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162654&action=edit
Bug 35026: Fix unit tests
This patch fixes the unit tests that were failing and also removes some tests
that should not be introduced until bug 34355
Test plan:
prove t/db_dependent/Koha/MarcOrder.t
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:08:32 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:08:32 +0000
Subject: [Koha-bugs] [Bug 31427] Automatic renewal errors should come before
many other renewal errors
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427
--- Comment #33 from Marcel de Rooy ---
Another related observation in CanBookBeRenewed:
if ( $auto_renew eq 'auto_too_soon' ) {
# If its cron, tell it it's too soon for a an auto renewal
return ( 0, $auto_renew, { soonest_renew_date => $soonest } ) if $cron;
# Check if it's too soon for a manual renewal
my $soonestManual = GetSoonestRenewDate( $patron, $issue );
if ( $soonestManual > dt_from_string() ) {
return ( 0, "too_soon", { soonest_renew_date => $soonestManual } )
unless $override_limit;
}
}
$soonest = GetSoonestRenewDate($patron, $issue);
if ( $soonest > dt_from_string() ){
return (0, "too_soon", { soonest_renew_date => $soonest } ) unless
$override_limit;
}
When we have auto_too_soon, we might be calling GetSoonestRenewDate twice here?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:17:00 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:17:00 +0000
Subject: [Koha-bugs] [Bug 31427] Automatic renewal errors should come before
many other renewal errors
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427
--- Comment #34 from Marcel de Rooy ---
Koha::Checkout
sub attempt_auto_renew {
my ( $self, $params ) = @_;
my $confirm = $params->{confirm} // 0;
# CanBookBeRenewed returns 'auto_renew' when the renewal should be done by
this script
my ( $ok, $error ) = C4::Circulation::CanBookBeRenewed( $self->patron,
$self, undef, 1 );
After this call the $ok result is not even checked?!
Could be 'fine' but does not look good in general.
Related observation, going out of scope. In the same routine:
my $updated = 0;
if ( !$self->auto_renew_error || $error ne $self->auto_renew_error ) {
$updated = 1
unless (
$self->auto_renew_error
&& ( $self->auto_renew_error eq 'auto_renew_final' && $error
eq 'too_many'
|| $self->auto_renew_error eq 'auto_unseen_final' && $error
eq 'too_unseen' )
);
$self->auto_renew_error($error)->store if $confirm;
}
return ( 0, $error, $updated );
This does not look good either. $updated is passed back but $confirm is not
checked?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:19:29 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:19:29 +0000
Subject: [Koha-bugs] [Bug 35145] Add ability to order patron attributes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145
Pedro Amorim changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Patch doesn't apply
--- Comment #17 from Pedro Amorim ---
Applying: Bug 35145 : Schema file
Using index info to reconstruct a base tree...
M Koha/Schema/Result/BorrowerAttributeType.pm
Falling back to patching base and 3-way merge...
Auto-merging Koha/Schema/Result/BorrowerAttributeType.pm
CONFLICT (content): Merge conflict in
Koha/Schema/Result/BorrowerAttributeType.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 35145 : Schema file
Patches don't apply on current master.
Can you please submit a squashed version of the patches or make obsolete those
not needed.
Reach out on IRC, we can help with this if needed.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:27:22 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:27:22 +0000
Subject: [Koha-bugs] [Bug 36206] Administrative plugins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36206
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
URL| |https://github.com/PTFS-Eur
| |ope/koha-plugin-crontab/tre
| |e/admin_plugin
--
You are receiving this mail because:
You are watching all bug changes.
From jops at riseup.net Fri Mar 1 11:27:17 2024
From: jops at riseup.net (jops)
Date: Fri, 1 Mar 2024 11:27:17 +0100
Subject: [Koha-bugs] Field userid is not valid (probably not unique),
after login
Message-ID: <8c3d51a0-9bf7-45a3-bab6-e92c0e8075dc@riseup.net>
Hi,
we are migrating server from ola.bida.im (koha version 20.11.03-1) to
bib.bida.im (koha version 23.11.02-1).
The search seams ok, but when we enter in bib-intra.bida.im we have an
500 internal server error with this message log in intranet-error.log
[Fri Mar 01 10:17:37.076210 2024] [cgi:error] [pid 233068] [client
46.255.84.17:65195] AH01215: [Field userid is not valid (probably not
unique)]: /usr/share/koha/intranet/cgi-bin/mainpage.pl, referer:
https://bib-intra.bida.im/cgi-bin/koha/mainpage.pl
[Fri Mar 01 10:17:37.223900 2024] [cgi:error] [pid 233068] [client
46.255.84.17:65195] End of script output before headers: mainpage.pl,
referer: https://bib-intra.bida.im/cgi-bin/koha/mainpage.pl
can you help us?
thanks
--
jops
GPG keys available via keyservers
https://keys.openpgp.org/search?q=jops%40riseup.net
https://keys.openpgp.org/vks/v1/by-fingerprint/32D254CF0B219482E28909CDC2FF3AC90AFDD78A
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:27:42 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:27:42 +0000
Subject: [Koha-bugs] [Bug 35659] OAI Harvester
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659
--- Comment #33 from Matthias Meusburger ---
Thank you Andreas for your feedback!
Not sure if I can sign-off your follow-up myself, since I'm the author of the
main patch, but I can confirm that it works as intended: warnings are gone, and
encoding is now correct.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:27:54 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:27:54 +0000
Subject: [Koha-bugs] [Bug 36206] Administrative plugins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36206
--- Comment #6 from Martin Renvoize ---
Currently this is easiest to test using the in-development crontab manager
plugin, admin_plugin branch:
https://github.com/PTFS-Europe/koha-plugin-crontab/tree/admin_plugin
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:32:32 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:32:32 +0000
Subject: [Koha-bugs] [Bug 36093] Fix missing array reference in provider
rollup reports
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36093
Matt Blenkinsop changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:32:35 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:32:35 +0000
Subject: [Koha-bugs] [Bug 36093] Fix missing array reference in provider
rollup reports
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36093
--- Comment #4 from Matt Blenkinsop ---
Created attachment 162655
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162655&action=edit
Bug 36093: Add unit test and fix QA tests
prove t/db_dependent/api/v1/erm_custom_reports.t
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:33:10 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:33:10 +0000
Subject: [Koha-bugs] [Bug 31427] Automatic renewal errors should come before
many other renewal errors
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:33:13 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:33:13 +0000
Subject: [Koha-bugs] [Bug 31427] Automatic renewal errors should come before
many other renewal errors
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #162239|0 |1
is obsolete| |
--- Comment #35 from Marcel de Rooy ---
Created attachment 162656
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162656&action=edit
Bug 31427: Get auto renewal errors before other renewal errors
This patch changes CanBookBeRenewed so that automatic renewal
errors pop up before other renewal errors. This means that a book
will be considered "auto_too_soon" before things like "too_many" or
"restricted". (Otherwise, you'll get an email saying you can't renew
a book the day after using your last auto renewal, even though the
earliest renewal isn't available until later.)
Test plan:
0. Apply patch
1. prove t/db_dependent/Circulation.t
2. prove t/db_dependent/Holds.t
3. prove t/db_dependent/Koha/Account/Line.t
4. prove t/db_dependent/Koha/Account.t
Additional tests:
5. Go to
http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=RestrictionBlockRenewing
6. Change to "block"
7. Go to
http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=AutoRenewalNotices
8. Change to "according to patron messaging preferences"
9. Go to http://localhost:8081/cgi-bin/koha/admin/smart-rules.pl
10. Set "Automatic renewal" to "Yes" and "No renewal before" to 4
11. Go to
http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51
12. Checkout 39999000001310 with a due date 4 days in the future
13. Add a manual restriction
14. Run `perl ./misc/cronjobs/automatic_renewals.pl`
15. Note that it says something like the following:
Issue id: 1237 for borrower: 51 and item: 73 would not be renewed.
(auto_too_soon)
Instead of something like the following:
Issue id: 1237 for borrower: 51 and item: 73 would not be renewed.
(restriction)
Signed-off-by: Sam Lau
Signed-off-by: Martin Renvoize
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:33:16 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:33:16 +0000
Subject: [Koha-bugs] [Bug 31427] Automatic renewal errors should come before
many other renewal errors
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #162240|0 |1
is obsolete| |
--- Comment #36 from Marcel de Rooy ---
Created attachment 162657
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162657&action=edit
Bug 31427: (follow-up) Unit tests
This patch adds a unit test for error precidence where autorenewals is
involved.
It is not comprehensive however, and I'm a little confused by the logic
around cron vs non-cron handling...
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:33:19 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:33:19 +0000
Subject: [Koha-bugs] [Bug 31427] Automatic renewal errors should come before
many other renewal errors
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427
--- Comment #37 from Marcel de Rooy ---
Created attachment 162658
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162658&action=edit
Bug 31427: Remove a few refs to CanBookBeRenewed
Actually, the module is not even needed anymore here.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:34:10 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:34:10 +0000
Subject: [Koha-bugs] [Bug 31427] Automatic renewal errors should come before
many other renewal errors
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427
--- Comment #38 from Marcel de Rooy ---
Looks good to me. Checked references to CanBookBeRenewed and
->attempt_auto_renew.
[OK] prove t/db_dependent/Holds.t t/db_dependent/Koha/Account/Line.t
t/db_dependent/Koha/Account.t
Could be in test plan too:
prove t/db_dependent/Koha/Checkouts.t
t/db_dependent/Koha/Checkouts.t .. ok
All tests successful.
Files=1, Tests=12, 7 wallclock secs ( 0.03 usr 0.01 sys + 5.42 cusr 0.87
csys = 6.33 CPU)
Result: PASS
C4/SIP/ILS/Transaction/Renew.pm
sub do_renew_for
The auto_xxx codes from CanBookBeRenewed are not listed here, but seem to be
passed through as-is.
Added a follow-up where CanBookBeRenewed is no longer called.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:37:18 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:37:18 +0000
Subject: [Koha-bugs] [Bug 31427] Automatic renewal errors should come before
many other renewal errors
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:38:04 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:38:04 +0000
Subject: [Koha-bugs] [Bug 36205] Plugins should be able to create permissions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36205
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=28957
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:38:04 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:38:04 +0000
Subject: [Koha-bugs] [Bug 28957] Many plugins require the full plugins
permission set to run
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28957
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=36205
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:38:50 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:38:50 +0000
Subject: [Koha-bugs] [Bug 36205] Plugins should be able to create permissions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36205
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |matt.blenkinsop at ptfs-europe
| |.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:39:00 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:39:00 +0000
Subject: [Koha-bugs] [Bug 36205] Plugins should be able to create permissions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36205
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kyle at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:40:21 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:40:21 +0000
Subject: [Koha-bugs] [Bug 32693] The 'About Koha' page loads slowly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
Severity|minor |enhancement
--- Comment #24 from Marcel de Rooy ---
About is slow. But this feels much more as enh than bugfix. Correct me if I am
mistaken..
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:42:10 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:42:10 +0000
Subject: [Koha-bugs] [Bug 36036] Fix location field in addorderiso2709.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36036
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
--- Comment #4 from Marcel de Rooy ---
This is trivial bugfix on top of an enh. Thats not the logical order? Can it be
done differently or should we move to enh?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:45:28 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:45:28 +0000
Subject: [Koha-bugs] [Bug 36176] We need tests to check for 'cud-'
operations in stable branches (pre-24.05)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36176
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:45:30 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:45:30 +0000
Subject: [Koha-bugs] [Bug 36176] We need tests to check for 'cud-'
operations in stable branches (pre-24.05)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36176
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #162550|0 |1
is obsolete| |
--- Comment #6 from Marcel de Rooy ---
Created attachment 162659
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162659&action=edit
Bug 36176: Reject cud- for stable branches
Signed-off-by: Lucas Gass
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:46:14 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:46:14 +0000
Subject: [Koha-bugs] [Bug 36176] We need tests to check for 'cud-'
operations in stable branches (pre-24.05)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36176
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
|y.org |
CC| |m.de.rooy at rijksmuseum.nl
--- Comment #7 from Marcel de Rooy ---
At some point we may need to make this test a bit smarter since cud- may leak
into comments, release notes, etc ?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:48:25 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:48:25 +0000
Subject: [Koha-bugs] [Bug 32693] The 'About Koha' page loads slowly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693
--- Comment #25 from Pedro Amorim ---
(In reply to Marcel de Rooy from comment #24)
> About is slow. But this feels much more as enh than bugfix. Correct me if I
> am mistaken..
Agreed. Yes.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:48:32 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:48:32 +0000
Subject: [Koha-bugs] [Bug 36003] Printing list from OPAC shows "Cookies"
when CookieConsent enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36003
--- Comment #4 from Marcel de Rooy ---
Whole bunch of deps in PQA and SO too. Skipping for now.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:55:23 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:55:23 +0000
Subject: [Koha-bugs] [Bug 32693] The 'About Koha' page loads slowly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:55:27 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:55:27 +0000
Subject: [Koha-bugs] [Bug 32693] The 'About Koha' page loads slowly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #162219|0 |1
is obsolete| |
Attachment #162220|0 |1
is obsolete| |
Attachment #162221|0 |1
is obsolete| |
Attachment #162222|0 |1
is obsolete| |
Attachment #162223|0 |1
is obsolete| |
Attachment #162224|0 |1
is obsolete| |
Attachment #162225|0 |1
is obsolete| |
--- Comment #26 from Jonathan Druart ---
Created attachment 162660
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162660&action=edit
Bug 32693: Update tab_item html helper
tab_item html helper now allows for a boolean tablink option to set if the the
tab item is a link or not
Signed-off-by: David Nind
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:55:30 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:55:30 +0000
Subject: [Koha-bugs] [Bug 32693] The 'About Koha' page loads slowly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693
--- Comment #27 from Jonathan Druart ---
Created attachment 162661
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162661&action=edit
Bug 32693: Update tab_items
tab_items are now linktabs
tab_items are now styled active depending if the URL param 'tab' matches the
tab name or not
Signed-off-by: David Nind
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:55:33 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:55:33 +0000
Subject: [Koha-bugs] [Bug 32693] The 'About Koha' page loads slowly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693
--- Comment #28 from Jonathan Druart ---
Created attachment 162662
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162662&action=edit
Bug 32693: Update tab_panels
Each tab panel's content has now been moved to its own BLOCK.
Each tab panel's content is now only loaded if said tab is the one being viewed
Signed-off-by: David Nind
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:55:36 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:55:36 +0000
Subject: [Koha-bugs] [Bug 32693] The 'About Koha' page loads slowly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693
--- Comment #29 from Jonathan Druart ---
Created attachment 162663
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162663&action=edit
Bug 32693: Preparation: About script: docdir
docdir is used in both team + history tabs
was previously being loaded in team and additionally used in history
but because now we're only loading one tab at a time, we need to move this
Signed-off-by: David Nind
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:55:39 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:55:39 +0000
Subject: [Koha-bugs] [Bug 32693] The 'About Koha' page loads slowly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693
--- Comment #30 from Jonathan Druart ---
Created attachment 162664
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162664&action=edit
Bug 32693: Preparation: About script: Move template params
These template params are only used in the default first 'about' tab but were
being added further down in the script
Signed-off-by: David Nind
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:55:42 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:55:42 +0000
Subject: [Koha-bugs] [Bug 32693] The 'About Koha' page loads slowly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693
--- Comment #31 from Jonathan Druart ---
Created attachment 162665
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162665&action=edit
Bug 32693: Preparation: About script: versions
versions is being used in both 'team' and 'about' tabs, needs to be
moved
Signed-off-by: David Nind
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:55:45 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:55:45 +0000
Subject: [Koha-bugs] [Bug 32693] The 'About Koha' page loads slowly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693
--- Comment #32 from Jonathan Druart ---
Created attachment 162666
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162666&action=edit
Bug 32693: About script: Process only the tab being queried
Signed-off-by: David Nind
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:56:57 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 10:56:57 +0000
Subject: [Koha-bugs] [Bug 36176] We need tests to check for 'cud-'
operations in stable branches (pre-24.05)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36176
--- Comment #8 from Jonathan Druart ---
Yes sure, this will certainly need to be adjusted, but at least it will be
effective for the first months.
Even in release notes we should not refer to cud- in stable branches.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:15:47 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 11:15:47 +0000
Subject: [Koha-bugs] [Bug 26869] Enable batch record modification to create
952/item on existing bibs
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26869
--- Comment #21 from Pedro Amorim ---
(In reply to Esther Melander from comment #19)
> The test plan works through step 11 and an item is created. The item created
> defaulted to the 952$y item type Book, even though only the 952$a is in the
> action. That may not always be the correct item type, though it is probably
> better for something to be assigned than nothing.
Good catch. Thanks. I took a deeper look and I'm convinced this is because of
the following code in Item.pm sub store:
unless ( $self->itype ) {
$self->itype($self->biblio->biblioitem->itemtype);
}
The item will default to the itemtype at the biblio level if not mapping for
itype is exists.
In the case of this test plan, biblio 79 field 942$c is 'BK' so the code is
grabbing that when storing the item.
This follows core logic as the patch is using a core method AddItemFromMarc.
I think this is a good behavior for this use case. Let me know if you disagree!
> The test plan implies the 952$a is required to create an item, but I was
> able to create an item with only the 952$8.
Interesting! I'm sure I was unable to create an item without 952$a before but
I've tried now and, as you say, the item is created regardless of 952$a mapping
existing or not.
I had different approaches for this solution before the current patch, using
different methods, so this is likely a remnant of that i.e. with a previous
version of the patch this was the case, but not anymore it seems.
(In reply to Andrew Fuerste-Henry from comment #20)
> If we were creating items from a 952 while importing a new bib, which item
> fields, if any, would be required? It makes sense to me to have this process
> match those requirements.
This does make sense, I agree.
Are you referring to bulkmarcimport.pl or a different method? Can you please
provide a test plan on creating items from a 952 while importing a new bib? If
so, I'll have a go at testing that myself. Thanks!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:22:46 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 11:22:46 +0000
Subject: [Koha-bugs] [Bug 36213] New: Barcode should be visible in the
results listing
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36213
Bug ID: 36213
Summary: Barcode should be visible in the results listing
Change sponsored?: ---
Product: Koha
Version: 22.11
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Staff interface
Assignee: koha-bugs at lists.koha-community.org
Reporter: verolencinas at yahoo.com.ar
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com
To check a barcode in the staff interface in Koha you need to go to the detail
screen. In the results list you have access to a lot of item information like
callnumbers, check-outs, locations, etc. but not to the barcodes.
It would be helpful to some libraries to be able to check barcodes in the
results listing. Koha should be able to turn this feature on or off since some
libraries could prefer the actual result listing information.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:41:16 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 11:41:16 +0000
Subject: [Koha-bugs] [Bug 32565] Holds placed when all libraries are closed
do not get added to holds queue if HoldsQueueSkipClosed and
RealTimeHoldsQueue are enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565
Pedro Amorim changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #162297|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:50:11 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 11:50:11 +0000
Subject: [Koha-bugs] [Bug 32565] Holds placed when all libraries are closed
do not get added to holds queue if HoldsQueueSkipClosed and
RealTimeHoldsQueue are enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565
--- Comment #24 from Pedro Amorim ---
(In reply to Nick Clemens from comment #23)
> (In reply to Pedro Amorim from comment #22)
> > Hey guys, I'd love some feedback on my latest patch.
> > I think it makes sense considering build_holds_queue.pl --unallocated should
> > be idempotent.
> > I'm okay with it being dropped if you feel that's best or if I missed
> > something.
>
> In a system without RTHQ there are times a library would like the queue to
> remain static for a period of time, but have new holds be picked up. i.e.
> giving a library more time to fill holds until a full rebuild, so I think
> the switch is necessary even when not using the RTHQ. Having the switch
> allows this code to satisfy bug 34676 and 32328 at leats partially
I've made my latest patch obsolete for these reasons, I had not considered this
specific use case.
As it stands now, the following cron entries configurations will work like
this:
Without RTHQ:
0 * * * * /usr/share/koha/bin/cronjobs/holds/build_holds_queue.pl
--unallocated-only # run this hourly
0 1 * * * /usr/share/koha/bin/cronjobs/holds/build_holds_queue.pl # run this
daily
With RTHQ:
0 * * * * /usr/share/koha/bin/cronjobs/holds/build_holds_queue.pl
--unallocated-only # run this hourly
0 1 * * * /usr/share/koha/bin/cronjobs/holds/build_holds_queue.pl # run this
daily !This will not do anything because RTHQ is enabled and --force is missing
Nick, please intervene if any of the above needs correcting.
My opinion is that a note along the lines of "It is recommended to use the cron
build_holds_queue.pl --unallocated-only cron if using RTHQ" would be useful in
the UI.
I think this is good to go and I don't have anything else to add, but because
of my involvement in it I'll leave it to someone else to PQA.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:59:01 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 11:59:01 +0000
Subject: [Koha-bugs] [Bug 35473] Core bookings and room reservations plugin
tables clash
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35473
--- Comment #18 from Martin Renvoize ---
Hmm, it does raise a fiar question.
In this case I worked with the plugin maintainers to get both sides of the
equation done.. so, with this patch we don't just explode badly and you cna
upgrade the plugin either before or after the upgrade and it works.
Withouth this patch, if you don't happen to know you need to upgrade the plugin
first, you'll end up with a nasty silent failure during upgrade which, without
some code that's very much aware of the plugin table layout isn't at all easy
to spot.
I'm open to suggestions of course, but I couldn't see an alternative.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 13:29:45 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 12:29:45 +0000
Subject: [Koha-bugs] [Bug 27153] ElasticSearch should search keywords
apostrophe blind
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153
--- Comment #50 from Nick Clemens ---
Current patches apply cleanly to 23.05.x and work in my testing - can this be
considered for backport?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:18:14 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 13:18:14 +0000
Subject: [Koha-bugs] [Bug 34426] Add tests for CSRF checks missing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34426
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|Koha |Architecture, internals,
| |and plumbing
Product|Koha security |Koha
Group|Koha security |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:18:26 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 13:18:26 +0000
Subject: [Koha-bugs] [Bug 35949] Useless code pointing to branchreserves.pl
in request.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35949
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |24.05.00
released in| |
Status|Passed QA |Pushed to master
--- Comment #4 from Jonathan Druart ---
Pushed to master for 24.05.00.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:18:35 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 13:18:35 +0000
Subject: [Koha-bugs] [Bug 36017] Dead code in admin/clone-rules
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36017
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |24.05.00
released in| |
Status|Passed QA |Pushed to master
--- Comment #4 from Jonathan Druart ---
Pushed to master for 24.05.00.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:18:45 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 13:18:45 +0000
Subject: [Koha-bugs] [Bug 36019] Dead code in tags/review
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36019
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to master
Version(s)| |24.05.00
released in| |
--- Comment #3 from Jonathan Druart ---
Pushed to master for 24.05.00.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:19:29 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 13:19:29 +0000
Subject: [Koha-bugs] [Bug 35890] AutoLocation system preference + setting
the library IP field - can still login and unexpected results
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35890
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|Koha |Architecture, internals,
| |and plumbing
Product|Koha security |Koha
QA Contact| |testopia at bugs.koha-communit
| |y.org
Group|Koha security |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:19:41 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 13:19:41 +0000
Subject: [Koha-bugs] [Bug 35918] Incorrect library used when AutoLocation
configured using the same IP
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35918
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|Koha |Architecture, internals,
| |and plumbing
Product|Koha security |Koha
Group|Koha security |
QA Contact| |testopia at bugs.koha-communit
| |y.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:19:58 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 13:19:58 +0000
Subject: [Koha-bugs] [Bug 35935] Wrong branch picked after an incorrect login
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35935
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to master
Version(s)| |24.05.00
released in| |
--- Comment #4 from Jonathan Druart ---
Pushed to master for 24.05.00.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:20:06 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 13:20:06 +0000
Subject: [Koha-bugs] [Bug 36098] Create Koha::Session module
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36098
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to master
Version(s)| |24.05.00
released in| |
--- Comment #17 from Jonathan Druart ---
Pushed to master for 24.05.00.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:20:25 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 13:20:25 +0000
Subject: [Koha-bugs] [Bug 35955] New CSRF token generated everytime we need
one
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35955
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|Koha |Architecture, internals,
| |and plumbing
Version(s)| |24.05.00
released in| |
Product|Koha security |Koha
Status|Passed QA |Pushed to master
Group|Koha security |
--- Comment #11 from Jonathan Druart ---
Pushed to master for 24.05.00.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:20:38 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 13:20:38 +0000
Subject: [Koha-bugs] [Bug 34478] Full CSRF protection
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Passed QA
Group|Koha security |
Product|Koha security |Koha
Version(s)| |24.05.00
released in| |
Component|Koha |Architecture, internals,
| |and plumbing
QA Contact| |testopia at bugs.koha-communit
| |y.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:20:45 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 13:20:45 +0000
Subject: [Koha-bugs] [Bug 34478] Full CSRF protection
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to master
--- Comment #181 from Jonathan Druart ---
Pushed to master for 24.05.00.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:21:13 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 13:21:13 +0000
Subject: [Koha-bugs] [Bug 36102] Protect login forms from CSRF attacks
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36102
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Group|Koha security |
QA Contact| |testopia at bugs.koha-communit
| |y.org
Component|Koha |Architecture, internals,
| |and plumbing
Status|Passed QA |Pushed to master
Product|Koha security |Koha
Version(s)| |Pushed to master for
released in| |24.05.00.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:21:28 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 13:21:28 +0000
Subject: [Koha-bugs] [Bug 36102] Protect login forms from CSRF attacks
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36102
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|Pushed to master for |24.05.00
released in|24.05.00. |
--- Comment #40 from Jonathan Druart ---
Pushed to master for 24.05.00.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:22:04 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 13:22:04 +0000
Subject: [Koha-bugs] [Bug 36084] Pass CSRF token to SVC scripts (1/2)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36084
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Group|Koha security |
Product|Koha security |Koha
Status|Passed QA |Pushed to master
Summary|Pass CSRF token to SVC |Pass CSRF token to SVC
|scripts |scripts (1/2)
Version(s)| |24.05.00
released in| |
Component|Koha |Architecture, internals,
| |and plumbing
QA Contact| |testopia at bugs.koha-communit
| |y.org
--- Comment #37 from Jonathan Druart ---
Pushed to master for 24.05.00.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:22:20 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 13:22:20 +0000
Subject: [Koha-bugs] [Bug 36084] Pass CSRF token to SVC scripts (1/2)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36084
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|36094 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36094
[Bug 36094] svc/authentication needs adjustements
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:22:20 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 13:22:20 +0000
Subject: [Koha-bugs] [Bug 36094] svc/authentication needs adjustements
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36094
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|36084 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36084
[Bug 36084] Pass CSRF token to SVC scripts (1/2)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:23:08 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 13:23:08 +0000
Subject: [Koha-bugs] [Bug 36194] CSRF - svc (2/2)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36194
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |36084
Summary|CSRF - svc |CSRF - svc (2/2)
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36084
[Bug 36084] Pass CSRF token to SVC scripts (1/2)
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:23:08 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 13:23:08 +0000
Subject: [Koha-bugs] [Bug 36084] Pass CSRF token to SVC scripts (1/2)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36084
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |36194
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36194
[Bug 36194] CSRF - svc (2/2)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:23:54 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 13:23:54 +0000
Subject: [Koha-bugs] [Bug 36148] Move CSRF check code outside of CGI->new
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36148
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |24.05.00
released in| |
QA Contact| |testopia at bugs.koha-communit
| |y.org
Status|Passed QA |Pushed to master
Component|Koha |Architecture, internals,
| |and plumbing
Product|Koha security |Koha
Group|Koha security |
--- Comment #31 from Jonathan Druart ---
Pushed to master for 24.05.00.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:24:09 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 13:24:09 +0000
Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to master
Version(s)| |24.05.00
released in| |
--- Comment #157 from Jonathan Druart ---
Pushed to master for 24.05.00.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:43:28 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 13:43:28 +0000
Subject: [Koha-bugs] [Bug 30745] ES : Search never return result using
after-date and/or before-date in labels/label-item-search.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745
Phan Tung Bui changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |phan-tung.bui at inlibro.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:54:35 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 13:54:35 +0000
Subject: [Koha-bugs] [Bug 35169] Make long overdue borrower category options
configurable in interface
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169
Matthias Le Gac changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:54:37 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 13:54:37 +0000
Subject: [Koha-bugs] [Bug 35169] Make long overdue borrower category options
configurable in interface
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169
--- Comment #8 from Matthias Le Gac ---
Created attachment 162667
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162667&action=edit
Bug 35169: update DBupdate file
Test Plan :
1 - Apply the patch
2 - Go to Koha administration > System preferences > Circulation > Checkout
policy
3 - Set "DefaultLongOverdueLostValue" to "Lost" and "DefaultLongOverdueDays" to
"2"
4 - Check out an item to a patron and set the date to more than two days.
5 - Remember the category of the patron
Test of DefaultLongOverdueBorrowerCategories option :
6 - Go to Koha administration > System preferences > Circulation > Checkout
policy
7 - Set "DefaultLongOverdueBorrowerCategories" to the category of the patron
8 - Go to the terminal in the koha environment and execute the script
"./misc/cronjobs/longoverdue.pl"
9 - Normaly you see in list the check out item set just before and the list
it's only borrowers with the category
Test of DefaultLongOverdueSkipBorrowerCategories option :
10 - Go to Koha administration > System preferences > Circulation > Checkout
policy
11 - Set "DefaultLongOverdueSkipBorrowerCategories" to the category of the
patron
12 - Go to the terminal in the koha environment and execute the script
"./misc/cronjobs/longoverdue.pl"
13 - Normaly you don't see in list the check out item set just before and the
list it's only borrowers with others categories
Test of warning :
14 - Go to Koha administration > System preferences > Circulation > Checkout
policy
15 - Set "DefaultLongOverdueBorrowerCategories" to the category of the patron
and Set "DefaultLongOverdueSkipBorrowerCategories" to the category of the
patron
16 - Go to the terminal in the koha environment and execute the script
"./misc/cronjobs/longoverdue.pl"
17 - Normaly you don't see in list the check out item set just before because
the "DefaultLongOverdueSkipBorrowerCategories" take advantage of
"DefaultLongOverdueBorrowerCategories"
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:56:32 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 13:56:32 +0000
Subject: [Koha-bugs] [Bug 35169] Make long overdue borrower category options
configurable in interface
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169
--- Comment #9 from Matthias Le Gac ---
(In reply to Lucas Gass from comment #7)
> Matthias,
>
> I tested this and it seems to work as intended, you sysprefs.sql update
> looks good to me.
>
> However, your DBUpdate explanation and type should not be NULL. Sorry to be
> a pain!
Thank you for your feedback. Normally it's good now.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:01:22 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 14:01:22 +0000
Subject: [Koha-bugs] [Bug 35145] Add ability to order patron attributes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145
Phan Tung Bui changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #162347|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:11:09 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 14:11:09 +0000
Subject: [Koha-bugs] [Bug 35473] Core bookings and room reservations plugin
tables clash
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35473
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tomascohen at gmail.com
--- Comment #19 from Tomás Cohen Arazi ---
Plugins should always use:
my $table_name = $self->get_qualified_table_name('name_you_want');
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:11:57 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 14:11:57 +0000
Subject: [Koha-bugs] [Bug 36195] CSRF - testing reports
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36195
--- Comment #1 from Jonathan Druart ---
Created attachment 162668
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162668&action=edit
Bug 36195: serials/routing-preview.pl - Fix save and preview
No idea why we are passing issue_escaped instead of the id, but this
patch fixes the regression.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:14:59 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 14:14:59 +0000
Subject: [Koha-bugs] [Bug 36192] [OMNIBUS] CSRF Protection for Koha
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192
Pedro Amorim changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pedro.amorim at ptfs-europe.co
| |m
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:28:45 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 14:28:45 +0000
Subject: [Koha-bugs] [Bug 35892] Fallback to GetMarcPrice in addorderiso2907
no longer works
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35892
Sarah Cornell changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sbcornell at cityofportsmouth.
| |com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:28:57 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 14:28:57 +0000
Subject: [Koha-bugs] [Bug 36053] Replacement prices not populating when
supplied from MarcItemFieldsToOrder
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36053
Sarah Cornell changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sbcornell at cityofportsmouth.
| |com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:30:08 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 14:30:08 +0000
Subject: [Koha-bugs] [Bug 36060] If issues table includes overdues Renew
selected items button is disabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060
Brendan Lawlor changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:35:45 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 14:35:45 +0000
Subject: [Koha-bugs] [Bug 36060] If issues table includes overdues Renew
selected items button is disabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060
--- Comment #8 from Brendan Lawlor ---
Hi Lucas, sorry for the false report and thanks for your time chatting with me.
I retested this bug this morning and could not reproduce it. So then I reset
git and tested again without the bug applied and then I could see it.
So I think what happened was I didn't have the bug applied or had applied the
wrong bug by accident when I first saw the bug.
My bad, status back to signed off.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:39:05 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 14:39:05 +0000
Subject: [Koha-bugs] [Bug 36159] Patron imports record a change for non-text
columns that are not in the import file
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36159
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |3820
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820
[Bug 3820] More detailed patron record changes log
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:39:05 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 14:39:05 +0000
Subject: [Koha-bugs] [Bug 3820] More detailed patron record changes log
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |36159
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36159
[Bug 36159] Patron imports record a change for non-text columns that are not in
the import file
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:41:52 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 14:41:52 +0000
Subject: [Koha-bugs] [Bug 36060] If issues table includes overdues Renew
selected items button is disabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060
--- Comment #9 from Lucas Gass ---
(In reply to Brendan Lawlor from comment #8)
> Hi Lucas, sorry for the false report and thanks for your time chatting with
> me.
>
> I retested this bug this morning and could not reproduce it. So then I reset
> git and tested again without the bug applied and then I could see it.
>
> So I think what happened was I didn't have the bug applied or had applied
> the wrong bug by accident when I first saw the bug.
>
> My bad, status back to signed off.
I appreciate your testing, Brendan. Thanks!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:49:59 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 14:49:59 +0000
Subject: [Koha-bugs] [Bug 36159] Patron imports record a change for non-text
columns that are not in the import file
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36159
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
|ity.org |
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:55:52 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 14:55:52 +0000
Subject: [Koha-bugs] [Bug 36159] Patron imports record a change for non-text
columns that are not in the import file
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36159
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:55:54 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 14:55:54 +0000
Subject: [Koha-bugs] [Bug 36159] Patron imports record a change for non-text
columns that are not in the import file
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36159
--- Comment #2 from Kyle M Hall ---
Created attachment 162669
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162669&action=edit
Bug 36159: Patron imports record a change for non-text columns that are not in
the import file
When importing patrons we assume a default of '' for borrower columns not
supplied in the file.
When saving we compare the new object we built to the one form the database -
for columns are that are not text type we get undef from the db and '' in the
object we make. This means we see a difference and log into the BorrowersLog:
"date_renewed" : {
"after" : "",
"before" : null
},
"dateofbirth" : {
"after" : "",
"before" : null
},
"debarred" : {
"after" : "",
"before" : null
},
"flags" : {
"after" : "",
"before" : null
},
"gonenoaddress" : {
"after" : "",
"before" : null
},
"lost" : {
"after" : "",
"before" : null
},
"password_expiration_date" : {
"after" : "",
"before" : null
},
"sms_provider_id" : {
"after" : "",
"before" : null
}
}
This can mean a lot of useless logging in sites that do automated imports
Test Plan:
1) Enable 'BorrowersLog' system preference
2) Import the borrowers file attach do this bug report file, matchig on
cardnuber, and overwriting
Contents of the borrowers file are :
surname,firstname,branchcode,categorycode,cardnumber,dateenrolled,patron_attributes,lastseen
Acosta,Ednb,CPL,PT,23529001000463,02/01/2013,,
3) Check the logs, note the modification of columns that have no date
4) Import the file again with the same settings
5) Note the new action log
6) Apply this patch
7) Restart all the things!
8) Import the file again with the same settings
9) Note no new action log was created!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:57:45 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 14:57:45 +0000
Subject: [Koha-bugs] [Bug 35145] Add ability to order patron attributes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145
Phan Tung Bui changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #162348|1 |0
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:58:09 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 14:58:09 +0000
Subject: [Koha-bugs] [Bug 35145] Add ability to order patron attributes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145
Phan Tung Bui changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #162620|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:58:49 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 14:58:49 +0000
Subject: [Koha-bugs] [Bug 35145] Add ability to order patron attributes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145
Phan Tung Bui changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #162347|1 |0
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:58:59 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 14:58:59 +0000
Subject: [Koha-bugs] [Bug 35145] Add ability to order patron attributes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145
Phan Tung Bui changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #162621|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:59:20 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 14:59:20 +0000
Subject: [Koha-bugs] [Bug 35145] Add ability to order patron attributes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145
Phan Tung Bui changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #162622|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 16:03:56 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 15:03:56 +0000
Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329
--- Comment #158 from Jonathan Druart ---
Created attachment 162670
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162670&action=edit
Bug 35329: (follow-up) Add styling to info and error
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 16:03:59 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 15:03:59 +0000
Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329
--- Comment #159 from Jonathan Druart ---
Created attachment 162671
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162671&action=edit
Bug 35329: Fix conflict with 33457
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 16:04:52 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 15:04:52 +0000
Subject: [Koha-bugs] [Bug 35329] Move patron searches to a modal
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329
--- Comment #160 from Jonathan Druart ---
Last 2 patches pushed to master.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 16:08:15 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 15:08:15 +0000
Subject: [Koha-bugs] [Bug 36060] If issues table includes overdues Renew
selected items button is disabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Patch doesn't apply
--- Comment #10 from Lucas Gass ---
Needs rebased now that Bug 34478 is in,
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 16:10:00 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 15:10:00 +0000
Subject: [Koha-bugs] [Bug 36187] Cannot set suggestedby when adding/editing
a suggestion from the staff client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Patch doesn't apply
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 16:16:55 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 15:16:55 +0000
Subject: [Koha-bugs] [Bug 36159] Patron imports record a change for non-text
columns that are not in the import file
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36159
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #162669|0 |1
is obsolete| |
--- Comment #3 from Kyle M Hall ---
Created attachment 162672
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162672&action=edit
Bug 36159: Patron imports record a change for non-text columns that are not in
the import file
When importing patrons we assume a default of '' for borrower columns not
supplied in the file.
When saving we compare the new object we built to the one form the database -
for columns are that are not text type we get undef from the db and '' in the
object we make. This means we see a difference and log into the BorrowersLog:
"date_renewed" : {
"after" : "",
"before" : null
},
"dateofbirth" : {
"after" : "",
"before" : null
},
"debarred" : {
"after" : "",
"before" : null
},
"flags" : {
"after" : "",
"before" : null
},
"gonenoaddress" : {
"after" : "",
"before" : null
},
"lost" : {
"after" : "",
"before" : null
},
"password_expiration_date" : {
"after" : "",
"before" : null
},
"sms_provider_id" : {
"after" : "",
"before" : null
}
}
This can mean a lot of useless logging in sites that do automated imports
Test Plan:
1) Enable 'BorrowersLog' system preference
2) Import the borrowers file attach do this bug report file, matchig on
cardnuber, and overwriting
Contents of the borrowers file are :
surname,firstname,branchcode,categorycode,cardnumber,dateenrolled,patron_attributes,lastseen
Acosta,Ednb,CPL,PT,23529001000463,02/01/2013,,
3) Check the logs, note the modification of columns that have no date
4) Import the file again with the same settings
5) Note the new action log
6) Apply this patch
7) Restart all the things!
8) Import the file again with the same settings
9) Note no new action log was created!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 16:27:31 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 15:27:31 +0000
Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in
export_records.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551
David Gustafsson changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--- Comment #76 from David Gustafsson ---
Must have forgotten to change status, setting to Needs Signoff.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 16:28:33 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 15:28:33 +0000
Subject: [Koha-bugs] [Bug 36195] CSRF - testing reports
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36195
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lucas at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 16:28:48 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 15:28:48 +0000
Subject: [Koha-bugs] [Bug 35145] Add ability to order patron attributes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145
Phan Tung Bui changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #162347|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 16:29:03 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 15:29:03 +0000
Subject: [Koha-bugs] [Bug 35145] Add ability to order patron attributes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145
Phan Tung Bui changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #162348|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 16:29:43 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 15:29:43 +0000
Subject: [Koha-bugs] [Bug 35145] Add ability to order patron attributes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145
Phan Tung Bui changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #162621|1 |0
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 16:30:03 2024
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2024 15:30:03 +0000
Subject: [Koha-bugs] [Bug 35145] Add ability to order patron attributes
In-Reply-To: