[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565

--- Comment #24 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
(In reply to Nick Clemens from comment #23)
> (In reply to Pedro Amorim from comment #22)
> > Hey guys, I'd love some feedback on my latest patch.
> > I think it makes sense considering build_holds_queue.pl --unallocated should
> > be idempotent.
> > I'm okay with it being dropped if you feel that's best or if I missed
> > something.
> 
> In a system without RTHQ there are times a library would like the queue to
> remain static for a period of time, but have new holds be picked up. i.e.
> giving a library more time to fill holds until a full rebuild, so I think
> the switch is necessary even when not using the RTHQ. Having the switch
> allows this code to satisfy bug 34676 and 32328 at leats partially

I've made my latest patch obsolete for these reasons, I had not considered this
specific use case.
As it stands now, the following cron entries configurations will work like
this:

Without RTHQ:
0 * * * * /usr/share/koha/bin/cronjobs/holds/build_holds_queue.pl
--unallocated-only # run this hourly
0 1 * * * /usr/share/koha/bin/cronjobs/holds/build_holds_queue.pl # run this
daily

With RTHQ:
0 * * * * /usr/share/koha/bin/cronjobs/holds/build_holds_queue.pl
--unallocated-only # run this hourly
0 1 * * * /usr/share/koha/bin/cronjobs/holds/build_holds_queue.pl # run this
daily !This will not do anything because RTHQ is enabled and --force is missing

Nick, please intervene if any of the above needs correcting.
My opinion is that a note along the lines of "It is recommended to use the cron
build_holds_queue.pl --unallocated-only cron if using RTHQ" would be useful in
the UI.

I think this is good to go and I don't have anything else to add, but because
of my involvement in it I'll leave it to someone else to PQA.

-- 
You are receiving this mail because:
You are watching all bug changes.