[Koha-bugs] [Bug 32142] Add HoldFeeMode option "if all items are checked out OR the record has at least one hold already"

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32142

--- Comment #15 from Philip Orr <philip.orr at lmscloud.de> ---
Looks good now, thanks.
Test plan is good, all tested OK for me.
Running qa, all changes look good.

However tests do not pass for GetReserveFee.t:

´´´
Running tests (1)
        * Proving /kohadevbox/koha/t/db_dependent/Reserves/GetReserveFee.t KO!

    #   Failed test 'HoldFeeMode=not_always, Patron 2 should not be charged'
    #   at /kohadevbox/koha/t/db_dependent/Reserves/GetReserveFee.t line 113.
    #          got: '2'
    #     expected: '0'
     # Looks like you failed 1 test of 8.

#   Failed test 'GetReserveFee'
#   at /kohadevbox/koha/t/db_dependent/Reserves/GetReserveFee.t line 138.
 # Looks like you failed 1 test of 3.
 /kohadevbox/koha/t/db_dependent/Reserves/GetReserveFee.t ..
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests

Test Summary Report
-------------------
 /kohadevbox/koha/t/db_dependent/Reserves/GetReserveFee.t (Wstat: 256 Tests: 3
Failed: 1)
  Failed test:   1
  Non-zero exit status: 1
 Files=1, Tests=3,  5 wallclock secs ( 0.02 usr  0.00 sys +  3.74 cusr  0.22
csys =  3.98 CPU)
 Result: FAIL
```

Also, I'm not sure about comma rules.. but I think the option in HoldFeeMode
should be "either if all items are checked out or the record has at least one
hold already." (that is, with no comma before the or)
Maybe a QA person can clarify? :)

-- 
You are receiving this mail because:
You are watching all bug changes.